Skip to content

feat(opentelemetry): use rest args for addOpenTelemetryInstrumentation - #11721

Merged
AbhiPrasad merged 7 commits into
developfrom
abhi-otel-instrumentation-args
Apr 23, 2024
Merged

feat(opentelemetry): use rest args for addOpenTelemetryInstrumentation#11721
AbhiPrasad merged 7 commits into
developfrom
abhi-otel-instrumentation-args

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Contributor

Based on feedback from @timfish in #11667 (comment) - update the addOpenTelemetryInstrumentation API to use rest args.

@AbhiPrasad
AbhiPrasad requested review from mydea and timfishApril 22, 2024 13:59
@AbhiPrasadAbhiPrasad self-assigned this Apr 22, 2024
@AbhiPrasad
AbhiPrasad enabled auto-merge (squash) April 22, 2024 16:00
@github-actions

github-actionsBot commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser21.65 KB (0%)
@sentry/browser (incl. Tracing)32.63 KB (0%)
@sentry/browser (incl. Tracing, Replay)67.97 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags61.37 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)72.02 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)84.21 KB (0%)
@sentry/browser (incl. Feedback)37.76 KB (0%)
@sentry/browser (incl. sendFeedback)26.43 KB (0%)
@sentry/browser (incl. FeedbackAsync)30.91 KB (0%)
@sentry/react24.33 KB (0%)
@sentry/react (incl. Tracing)35.53 KB (0%)
@sentry/vue25.26 KB (0%)
@sentry/vue (incl. Tracing)34.38 KB (0%)
@sentry/svelte21.77 KB (0%)
CDN Bundle23.95 KB (0%)
CDN Bundle (incl. Tracing)33.89 KB (0%)
CDN Bundle (incl. Tracing, Replay)67.61 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)83.44 KB (0%)
CDN Bundle - uncompressed70.56 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed100.57 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed210.18 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed256.49 KB (0%)
@sentry/nextjs (client)34.75 KB (0%)
@sentry/sveltekit (client)33.13 KB (0%)
@sentry/node152.84 KB (+0.01% 🔺)

@AbhiPrasad

AbhiPrasad commented Apr 22, 2024

Copy link
Copy Markdown
ContributorAuthor

I feel like sisyphus trying to merge this PR in

@AbhiPrasad
AbhiPrasad merged commit 0a440dd into developApr 23, 2024
@AbhiPrasad
AbhiPrasad deleted the abhi-otel-instrumentation-args branch April 23, 2024 16:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@timfish