Skip to content

fix: Restore console methods after calling uninstall#1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kamilogorek merged 1 commit into from
Feb 8, 2018
Merged

fix: Restore console methods after calling uninstall #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Gruntfile.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,14 +80,14 @@ module.exports = function(grunt) {
});

// Transpile all test scripts
tests.forEach(function(test) {
tests.forEach(function(test) {
var config = {
input: {
input: test
},
output: {
file: path.join('build', path.basename(test)),
name: path.basename(test, '.js'),
name: path.basename(test, '.js')
}
};

Expand DownExpand Up@@ -288,18 +288,17 @@ module.exports = function(grunt) {
// Build tasks
grunt.registerTask('_prep', ['gitinfo', 'version']);
grunt.registerTask('build.test', ['_prep', 'rollup:core', 'rollup:tests']);
grunt.registerTask('build.core', ['_prep', 'rollup:core', 'sri:dist']);
grunt.registerTask('build.core', ['_prep', 'rollup:core']);
grunt.registerTask('build.plugins', [
'_prep',
'generate-plugin-combinations',
'rollup:plugins',
'rollup:pluginCombinations',
'sri:dist',
'sri:build'
]);
grunt.registerTask('build', ['build.core', 'build.plugins', 'uglify']);

grunt.registerTask('dist', ['clean', 'build', 'copy:dist']);
grunt.registerTask('dist', ['clean', 'build', 'copy:dist', 'sri:dist']);

// Test tasks
grunt.registerTask('test:ci', ['config:ci', 'build:test']);
Expand Down
8 changes: 8 additions & 0 deletions src/raven.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -392,6 +392,7 @@ Raven.prototype = {

this._unpatchFunctionToString();
this._restoreBuiltIns();
this._restoreConsole();

Error.stackTraceLimit = this._originalErrorStackTraceLimit;
this._isRavenInstalled = false;
Expand DownExpand Up@@ -1383,6 +1384,13 @@ Raven.prototype = {
}
},

_restoreConsole: function() {
// eslint-disable-next-line guard-for-in
for (var method in this._originalConsoleMethods) {
this._originalConsole[method] = this._originalConsoleMethods[method];
}
},

_drainPlugins: function() {
var self = this;

Expand Down