Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,11 @@ export default function PageRoot(props) {
Home
</A>
</li>
<li>
<A href="/error-boundary-example" class="no-underline hover:underline">
Error Boundary Example
</A>
</li>
<li class="py-2 px-4">
<A href="/error" class="no-underline hover:underline">
Error
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

export default function ErrorBoundaryExample() {
return (
<SentryErrorBoundary
fallback={(error, reset) => (
<section class="bg-gray-100 text-gray-700 p-8">
<h1 class="text-2xl font-bold">Error Boundary Fallback</h1>
<div class="flex items-center space-x-2 mb-4">
<code>{error.message}</code>
</div>
<button id="errorBoundaryResetBtn" class="border rounded-lg px-2 border-gray-900" onClick={reset}>
Reset
</button>
</section>
)}
>
<NonExistentComponent />
</SentryErrorBoundary>
);
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { lazy } from 'solid-js';

import ErrorBoundaryExample from './pages/errorboundaryexample';
import Home from './pages/home';

export const routes = [
Expand All@@ -11,6 +12,10 @@ export const routes = [
path: '/user/:id',
component: lazy(() => import('./pages/user')),
},
{
path: '/error-boundary-example',
component: ErrorBoundaryExample,
},
{
path: '**',
component: lazy(() => import('./errors/404')),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('captures an exception', async ({ page }) => {
const errorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, errorEvent] = await Promise.all([page.goto('/error-boundary-example'), errorEventPromise]);

expect(errorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});

test('captures a second exception after resetting the boundary', async ({ page }) => {
const firstErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, firstErrorEvent] = await Promise.all([page.goto('/error-boundary-example'), firstErrorEventPromise]);

expect(firstErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});

const secondErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, secondErrorEvent] = await Promise.all([
page.locator('#errorBoundaryResetBtn').click(),
await secondErrorEventPromise,
]);

expect(secondErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});
27 changes: 26 additions & 1 deletion packages/solidjs/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,6 @@ Sentry.init({
dsn: '__PUBLIC_DSN__',
integrations: [Sentry.solidRouterBrowserTracingIntegration({ useBeforeLeave, useLocation })],
tracesSampleRate: 1.0, // Capture 100% of the transactions
debug: true,
});

const SentryRouter = Sentry.withSentryRouterRouting(Router);
Expand All@@ -53,6 +52,32 @@ render(
);
```

# ErrorBoundary

To automatically capture exceptions from inside a component tree and render a fallback component, wrap the native Solid
JS `ErrorBoundary` component with `Sentry.withSentryErrorBoundary`.

```js
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

Sentry.init({
dsn: '__PUBLIC_DSN__',
tracesSampleRate: 1.0, // Capture 100% of the transactions
});

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

render(
() => (
<SentryErrorBoundary fallback={err => <div>Error: {err.message}</div>}>
<ProblematicComponent />
</SentryErrorBoundary>
),
document.getElementById('root'),
);
```

# Sourcemaps and Releases

To generate and upload source maps of your Solid JS app bundle, check our guide
Expand Down
2 changes: 2 additions & 0 deletions packages/solidjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,8 @@
"@solidjs/router": "^0.13.5",
"@solidjs/testing-library": "0.8.5",
"solid-js": "^1.8.11",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/user-event": "^14.5.2",
"vite-plugin-solid": "^2.8.2"
},
"scripts": {
Expand Down
31 changes: 31 additions & 0 deletions packages/solidjs/src/errorboundary.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { captureException } from '@sentry/browser';
import type { Component, JSX } from 'solid-js';
import { mergeProps, splitProps } from 'solid-js';
import { createComponent } from 'solid-js/web';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is solid-js/web always available to us? I don't see it being listed as peerDependency or dependency in the SDK's package.json

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's available through solid-js. At least I didn't have any issues developing locally. The solidjs templates (these are used to start projects ala create-react-app) also don't specifically list it as dep, e.g. here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see, thx for explaining! Let's leave it as is and if we get error reports (I have a feeling pnpm could complain 👀 ) we can add it later.


type ErrorBoundaryProps = {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
fallback: JSX.Element | ((err: any, reset: () => void) => JSX.Element);
children: JSX.Element;
};

/**
* A higher-order component to wrap Solid's ErrorBoundary to capture exceptions.
*/
export function withSentryErrorBoundary(ErrorBoundary: Component<ErrorBoundaryProps>): Component<ErrorBoundaryProps> {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a naive question (sorry if I missed convos around this): Why do users need to pass in the ErrorBoundary component from solid here? Can we not import it like the other solid imports?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not naive at all. That's the approach I initially took, but it doesn't quite do the job correctly.

From local testing and similar experience with the router instrumentation, certain functions and functionality are app context specific. For the router, this meant that we couldn't use use hooks because they didn't have the user's router context. For the ErrorBoundary the reset function is contextual, so exporting a generic error boundary from this package would mean the reset function does nothing.

Hope this helps to understand it a bit better.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for explaining!

const SentryErrorBoundary = (props: ErrorBoundaryProps): JSX.Element => {
const [local, others] = splitProps(props, ['fallback']);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const fallback = (error: any, reset: () => void): JSX.Element => {
captureException(error);

const f = local.fallback;
return typeof f === 'function' ? f(error, reset) : f;
};

return createComponent(ErrorBoundary, mergeProps({ fallback }, others));
};

return SentryErrorBoundary;
}
1 change: 1 addition & 0 deletions packages/solidjs/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,3 +3,4 @@ export * from '@sentry/browser';
export { init } from './sdk';

export * from './solidrouter';
export * from './errorboundary';
108 changes: 108 additions & 0 deletions packages/solidjs/test/errorboundary.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/* eslint-disable @typescript-eslint/unbound-method */
import type * as SentryBrowser from '@sentry/browser';
import { createTransport, getCurrentScope, setCurrentClient } from '@sentry/core';
import { render } from '@solidjs/testing-library';
import userEvent from '@testing-library/user-event';
import { vi } from 'vitest';

import { ErrorBoundary } from 'solid-js';
import { BrowserClient, withSentryErrorBoundary } from '../src';

const mockCaptureException = vi.fn();
vi.mock('@sentry/browser', async () => {
const actual = await vi.importActual<typeof SentryBrowser>('@sentry/browser');
return {
...actual,
captureException: (...args) => mockCaptureException(...args),
} as typeof SentryBrowser;
});

const user = userEvent.setup();
const SentryErrorBoundary = withSentryErrorBoundary(ErrorBoundary);

describe('withSentryErrorBoundary', () => {
function createMockBrowserClient(): BrowserClient {
return new BrowserClient({
integrations: [],
tracesSampleRate: 1,
transport: () => createTransport({ recordDroppedEvent: () => undefined }, _ => Promise.resolve({})),
stackParser: () => [],
});
}

beforeEach(() => {
vi.clearAllMocks();

const client = createMockBrowserClient();
setCurrentClient(client);
});

afterEach(() => {
getCurrentScope().setClient(undefined);
});

it('calls `captureException` when an error occurs`', () => {
render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenLastCalledWith(new ReferenceError('NonExistentComponent is not defined'));
});

it('renders the fallback component', async () => {
const { findByText } = render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(await findByText('Ooops, an error occurred.')).toBeInTheDocument();
});

it('passes the `error` and `reset` function to the fallback component', () => {
const mockFallback = vi.fn();

render(() => {
<SentryErrorBoundary fallback={mockFallback}>
<NonExistentComponent />
</SentryErrorBoundary>;
});

expect(mockFallback).toHaveBeenCalledTimes(1);
expect(mockFallback).toHaveBeenCalledWith(
new ReferenceError('NonExistentComponent is not defined'),
expect.any(Function),
);
});

it('calls `captureException` again after resetting', async () => {
const { findByRole } = render(() => (
<SentryErrorBoundary fallback={(_, reset) => <button onClick={reset}>Reset</button>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenNthCalledWith(1, new ReferenceError('NonExistentComponent is not defined'));

const button = await findByRole('button');
await user.click(button);

expect(mockCaptureException).toHaveBeenCalledTimes(2);
expect(mockCaptureException).toHaveBeenNthCalledWith(2, new ReferenceError('NonExistentComponent is not defined'));
});

it('renders children when there is no error', async () => {
const { queryByText } = render(() => (
<SentryErrorBoundary fallback={<div>Oops, an error occurred.</div>}>
<div>Adopt a cat</div>
</SentryErrorBoundary>
));

expect(await queryByText('Adopt a cat')).toBeInTheDocument();
expect(await queryByText('Ooops, an error occurred')).not.toBeInTheDocument();
});
});
4 changes: 3 additions & 1 deletion packages/solidjs/tsconfig.test.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@

"compilerOptions": {
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["vitest/globals"]
"types": ["vitest/globals", "vite/client", "@testing-library/jest-dom"],

// other package-specific, test-specific options
"jsx": "preserve",
"jsxImportSource": "solid-js"
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,11 @@ export default function PageRoot(props) {
Home
</A>
</li>
<li>
<A href="/error-boundary-example" class="no-underline hover:underline">
Error Boundary Example
</A>
</li>
<li class="py-2 px-4">
<A href="/error" class="no-underline hover:underline">
Error
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

export default function ErrorBoundaryExample() {
return (
<SentryErrorBoundary
fallback={(error, reset) => (
<section class="bg-gray-100 text-gray-700 p-8">
<h1 class="text-2xl font-bold">Error Boundary Fallback</h1>
<div class="flex items-center space-x-2 mb-4">
<code>{error.message}</code>
</div>
<button id="errorBoundaryResetBtn" class="border rounded-lg px-2 border-gray-900" onClick={reset}>
Reset
</button>
</section>
)}
>
<NonExistentComponent />
</SentryErrorBoundary>
);
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { lazy } from 'solid-js';

import ErrorBoundaryExample from './pages/errorboundaryexample';
import Home from './pages/home';

export const routes = [
Expand All@@ -11,6 +12,10 @@ export const routes = [
path: '/user/:id',
component: lazy(() => import('./pages/user')),
},
{
path: '/error-boundary-example',
component: ErrorBoundaryExample,
},
{
path: '**',
component: lazy(() => import('./errors/404')),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('captures an exception', async ({ page }) => {
const errorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, errorEvent] = await Promise.all([page.goto('/error-boundary-example'), errorEventPromise]);

expect(errorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});

test('captures a second exception after resetting the boundary', async ({ page }) => {
const firstErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, firstErrorEvent] = await Promise.all([page.goto('/error-boundary-example'), firstErrorEventPromise]);

expect(firstErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});

const secondErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, secondErrorEvent] = await Promise.all([
page.locator('#errorBoundaryResetBtn').click(),
await secondErrorEventPromise,
]);

expect(secondErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});
27 changes: 26 additions & 1 deletion packages/solidjs/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,6 @@ Sentry.init({
dsn: '__PUBLIC_DSN__',
integrations: [Sentry.solidRouterBrowserTracingIntegration({ useBeforeLeave, useLocation })],
tracesSampleRate: 1.0, // Capture 100% of the transactions
debug: true,
});

const SentryRouter = Sentry.withSentryRouterRouting(Router);
Expand All@@ -53,6 +52,32 @@ render(
);
```

# ErrorBoundary

To automatically capture exceptions from inside a component tree and render a fallback component, wrap the native Solid
JS `ErrorBoundary` component with `Sentry.withSentryErrorBoundary`.

```js
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

Sentry.init({
dsn: '__PUBLIC_DSN__',
tracesSampleRate: 1.0, // Capture 100% of the transactions
});

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

render(
() => (
<SentryErrorBoundary fallback={err => <div>Error: {err.message}</div>}>
<ProblematicComponent />
</SentryErrorBoundary>
),
document.getElementById('root'),
);
```

# Sourcemaps and Releases

To generate and upload source maps of your Solid JS app bundle, check our guide
Expand Down
2 changes: 2 additions & 0 deletions packages/solidjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,8 @@
"@solidjs/router": "^0.13.5",
"@solidjs/testing-library": "0.8.5",
"solid-js": "^1.8.11",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/user-event": "^14.5.2",
"vite-plugin-solid": "^2.8.2"
},
"scripts": {
Expand Down
31 changes: 31 additions & 0 deletions packages/solidjs/src/errorboundary.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { captureException } from '@sentry/browser';
import type { Component, JSX } from 'solid-js';
import { mergeProps, splitProps } from 'solid-js';
import { createComponent } from 'solid-js/web';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is solid-js/web always available to us? I don't see it being listed as peerDependency or dependency in the SDK's package.json

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's available through solid-js. At least I didn't have any issues developing locally. The solidjs templates (these are used to start projects ala create-react-app) also don't specifically list it as dep, e.g. here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see, thx for explaining! Let's leave it as is and if we get error reports (I have a feeling pnpm could complain 👀 ) we can add it later.


type ErrorBoundaryProps = {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
fallback: JSX.Element | ((err: any, reset: () => void) => JSX.Element);
children: JSX.Element;
};

/**
* A higher-order component to wrap Solid's ErrorBoundary to capture exceptions.
*/
export function withSentryErrorBoundary(ErrorBoundary: Component<ErrorBoundaryProps>): Component<ErrorBoundaryProps> {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a naive question (sorry if I missed convos around this): Why do users need to pass in the ErrorBoundary component from solid here? Can we not import it like the other solid imports?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not naive at all. That's the approach I initially took, but it doesn't quite do the job correctly.

From local testing and similar experience with the router instrumentation, certain functions and functionality are app context specific. For the router, this meant that we couldn't use use hooks because they didn't have the user's router context. For the ErrorBoundary the reset function is contextual, so exporting a generic error boundary from this package would mean the reset function does nothing.

Hope this helps to understand it a bit better.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for explaining!

const SentryErrorBoundary = (props: ErrorBoundaryProps): JSX.Element => {
const [local, others] = splitProps(props, ['fallback']);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const fallback = (error: any, reset: () => void): JSX.Element => {
captureException(error);

const f = local.fallback;
return typeof f === 'function' ? f(error, reset) : f;
};

return createComponent(ErrorBoundary, mergeProps({ fallback }, others));
};

return SentryErrorBoundary;
}
1 change: 1 addition & 0 deletions packages/solidjs/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,3 +3,4 @@ export * from '@sentry/browser';
export { init } from './sdk';

export * from './solidrouter';
export * from './errorboundary';
108 changes: 108 additions & 0 deletions packages/solidjs/test/errorboundary.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/* eslint-disable @typescript-eslint/unbound-method */
import type * as SentryBrowser from '@sentry/browser';
import { createTransport, getCurrentScope, setCurrentClient } from '@sentry/core';
import { render } from '@solidjs/testing-library';
import userEvent from '@testing-library/user-event';
import { vi } from 'vitest';

import { ErrorBoundary } from 'solid-js';
import { BrowserClient, withSentryErrorBoundary } from '../src';

const mockCaptureException = vi.fn();
vi.mock('@sentry/browser', async () => {
const actual = await vi.importActual<typeof SentryBrowser>('@sentry/browser');
return {
...actual,
captureException: (...args) => mockCaptureException(...args),
} as typeof SentryBrowser;
});

const user = userEvent.setup();
const SentryErrorBoundary = withSentryErrorBoundary(ErrorBoundary);

describe('withSentryErrorBoundary', () => {
function createMockBrowserClient(): BrowserClient {
return new BrowserClient({
integrations: [],
tracesSampleRate: 1,
transport: () => createTransport({ recordDroppedEvent: () => undefined }, _ => Promise.resolve({})),
stackParser: () => [],
});
}

beforeEach(() => {
vi.clearAllMocks();

const client = createMockBrowserClient();
setCurrentClient(client);
});

afterEach(() => {
getCurrentScope().setClient(undefined);
});

it('calls `captureException` when an error occurs`', () => {
render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenLastCalledWith(new ReferenceError('NonExistentComponent is not defined'));
});

it('renders the fallback component', async () => {
const { findByText } = render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(await findByText('Ooops, an error occurred.')).toBeInTheDocument();
});

it('passes the `error` and `reset` function to the fallback component', () => {
const mockFallback = vi.fn();

render(() => {
<SentryErrorBoundary fallback={mockFallback}>
<NonExistentComponent />
</SentryErrorBoundary>;
});

expect(mockFallback).toHaveBeenCalledTimes(1);
expect(mockFallback).toHaveBeenCalledWith(
new ReferenceError('NonExistentComponent is not defined'),
expect.any(Function),
);
});

it('calls `captureException` again after resetting', async () => {
const { findByRole } = render(() => (
<SentryErrorBoundary fallback={(_, reset) => <button onClick={reset}>Reset</button>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenNthCalledWith(1, new ReferenceError('NonExistentComponent is not defined'));

const button = await findByRole('button');
await user.click(button);

expect(mockCaptureException).toHaveBeenCalledTimes(2);
expect(mockCaptureException).toHaveBeenNthCalledWith(2, new ReferenceError('NonExistentComponent is not defined'));
});

it('renders children when there is no error', async () => {
const { queryByText } = render(() => (
<SentryErrorBoundary fallback={<div>Oops, an error occurred.</div>}>
<div>Adopt a cat</div>
</SentryErrorBoundary>
));

expect(await queryByText('Adopt a cat')).toBeInTheDocument();
expect(await queryByText('Ooops, an error occurred')).not.toBeInTheDocument();
});
});
4 changes: 3 additions & 1 deletion packages/solidjs/tsconfig.test.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@

"compilerOptions": {
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["vitest/globals"]
"types": ["vitest/globals", "vite/client", "@testing-library/jest-dom"],

// other package-specific, test-specific options
"jsx": "preserve",
"jsxImportSource": "solid-js"
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,11 @@ export default function PageRoot(props) {
Home
</A>
</li>
<li>
<A href="/error-boundary-example" class="no-underline hover:underline">
Error Boundary Example
</A>
</li>
<li class="py-2 px-4">
<A href="/error" class="no-underline hover:underline">
Error
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

export default function ErrorBoundaryExample() {
return (
<SentryErrorBoundary
fallback={(error, reset) => (
<section class="bg-gray-100 text-gray-700 p-8">
<h1 class="text-2xl font-bold">Error Boundary Fallback</h1>
<div class="flex items-center space-x-2 mb-4">
<code>{error.message}</code>
</div>
<button id="errorBoundaryResetBtn" class="border rounded-lg px-2 border-gray-900" onClick={reset}>
Reset
</button>
</section>
)}
>
<NonExistentComponent />
</SentryErrorBoundary>
);
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { lazy } from 'solid-js';

import ErrorBoundaryExample from './pages/errorboundaryexample';
import Home from './pages/home';

export const routes = [
Expand All@@ -11,6 +12,10 @@ export const routes = [
path: '/user/:id',
component: lazy(() => import('./pages/user')),
},
{
path: '/error-boundary-example',
component: ErrorBoundaryExample,
},
{
path: '**',
component: lazy(() => import('./errors/404')),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('captures an exception', async ({ page }) => {
const errorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, errorEvent] = await Promise.all([page.goto('/error-boundary-example'), errorEventPromise]);

expect(errorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});

test('captures a second exception after resetting the boundary', async ({ page }) => {
const firstErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, firstErrorEvent] = await Promise.all([page.goto('/error-boundary-example'), firstErrorEventPromise]);

expect(firstErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});

const secondErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, secondErrorEvent] = await Promise.all([
page.locator('#errorBoundaryResetBtn').click(),
await secondErrorEventPromise,
]);

expect(secondErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});
27 changes: 26 additions & 1 deletion packages/solidjs/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,6 @@ Sentry.init({
dsn: '__PUBLIC_DSN__',
integrations: [Sentry.solidRouterBrowserTracingIntegration({ useBeforeLeave, useLocation })],
tracesSampleRate: 1.0, // Capture 100% of the transactions
debug: true,
});

const SentryRouter = Sentry.withSentryRouterRouting(Router);
Expand All@@ -53,6 +52,32 @@ render(
);
```

# ErrorBoundary

To automatically capture exceptions from inside a component tree and render a fallback component, wrap the native Solid
JS `ErrorBoundary` component with `Sentry.withSentryErrorBoundary`.

```js
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

Sentry.init({
dsn: '__PUBLIC_DSN__',
tracesSampleRate: 1.0, // Capture 100% of the transactions
});

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

render(
() => (
<SentryErrorBoundary fallback={err => <div>Error: {err.message}</div>}>
<ProblematicComponent />
</SentryErrorBoundary>
),
document.getElementById('root'),
);
```

# Sourcemaps and Releases

To generate and upload source maps of your Solid JS app bundle, check our guide
Expand Down
2 changes: 2 additions & 0 deletions packages/solidjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,8 @@
"@solidjs/router": "^0.13.5",
"@solidjs/testing-library": "0.8.5",
"solid-js": "^1.8.11",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/user-event": "^14.5.2",
"vite-plugin-solid": "^2.8.2"
},
"scripts": {
Expand Down
31 changes: 31 additions & 0 deletions packages/solidjs/src/errorboundary.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { captureException } from '@sentry/browser';
import type { Component, JSX } from 'solid-js';
import { mergeProps, splitProps } from 'solid-js';
import { createComponent } from 'solid-js/web';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is solid-js/web always available to us? I don't see it being listed as peerDependency or dependency in the SDK's package.json

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's available through solid-js. At least I didn't have any issues developing locally. The solidjs templates (these are used to start projects ala create-react-app) also don't specifically list it as dep, e.g. here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see, thx for explaining! Let's leave it as is and if we get error reports (I have a feeling pnpm could complain 👀 ) we can add it later.


type ErrorBoundaryProps = {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
fallback: JSX.Element | ((err: any, reset: () => void) => JSX.Element);
children: JSX.Element;
};

/**
* A higher-order component to wrap Solid's ErrorBoundary to capture exceptions.
*/
export function withSentryErrorBoundary(ErrorBoundary: Component<ErrorBoundaryProps>): Component<ErrorBoundaryProps> {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a naive question (sorry if I missed convos around this): Why do users need to pass in the ErrorBoundary component from solid here? Can we not import it like the other solid imports?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not naive at all. That's the approach I initially took, but it doesn't quite do the job correctly.

From local testing and similar experience with the router instrumentation, certain functions and functionality are app context specific. For the router, this meant that we couldn't use use hooks because they didn't have the user's router context. For the ErrorBoundary the reset function is contextual, so exporting a generic error boundary from this package would mean the reset function does nothing.

Hope this helps to understand it a bit better.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for explaining!

const SentryErrorBoundary = (props: ErrorBoundaryProps): JSX.Element => {
const [local, others] = splitProps(props, ['fallback']);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const fallback = (error: any, reset: () => void): JSX.Element => {
captureException(error);

const f = local.fallback;
return typeof f === 'function' ? f(error, reset) : f;
};

return createComponent(ErrorBoundary, mergeProps({ fallback }, others));
};

return SentryErrorBoundary;
}
1 change: 1 addition & 0 deletions packages/solidjs/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,3 +3,4 @@ export * from '@sentry/browser';
export { init } from './sdk';

export * from './solidrouter';
export * from './errorboundary';
108 changes: 108 additions & 0 deletions packages/solidjs/test/errorboundary.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/* eslint-disable @typescript-eslint/unbound-method */
import type * as SentryBrowser from '@sentry/browser';
import { createTransport, getCurrentScope, setCurrentClient } from '@sentry/core';
import { render } from '@solidjs/testing-library';
import userEvent from '@testing-library/user-event';
import { vi } from 'vitest';

import { ErrorBoundary } from 'solid-js';
import { BrowserClient, withSentryErrorBoundary } from '../src';

const mockCaptureException = vi.fn();
vi.mock('@sentry/browser', async () => {
const actual = await vi.importActual<typeof SentryBrowser>('@sentry/browser');
return {
...actual,
captureException: (...args) => mockCaptureException(...args),
} as typeof SentryBrowser;
});

const user = userEvent.setup();
const SentryErrorBoundary = withSentryErrorBoundary(ErrorBoundary);

describe('withSentryErrorBoundary', () => {
function createMockBrowserClient(): BrowserClient {
return new BrowserClient({
integrations: [],
tracesSampleRate: 1,
transport: () => createTransport({ recordDroppedEvent: () => undefined }, _ => Promise.resolve({})),
stackParser: () => [],
});
}

beforeEach(() => {
vi.clearAllMocks();

const client = createMockBrowserClient();
setCurrentClient(client);
});

afterEach(() => {
getCurrentScope().setClient(undefined);
});

it('calls `captureException` when an error occurs`', () => {
render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenLastCalledWith(new ReferenceError('NonExistentComponent is not defined'));
});

it('renders the fallback component', async () => {
const { findByText } = render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(await findByText('Ooops, an error occurred.')).toBeInTheDocument();
});

it('passes the `error` and `reset` function to the fallback component', () => {
const mockFallback = vi.fn();

render(() => {
<SentryErrorBoundary fallback={mockFallback}>
<NonExistentComponent />
</SentryErrorBoundary>;
});

expect(mockFallback).toHaveBeenCalledTimes(1);
expect(mockFallback).toHaveBeenCalledWith(
new ReferenceError('NonExistentComponent is not defined'),
expect.any(Function),
);
});

it('calls `captureException` again after resetting', async () => {
const { findByRole } = render(() => (
<SentryErrorBoundary fallback={(_, reset) => <button onClick={reset}>Reset</button>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenNthCalledWith(1, new ReferenceError('NonExistentComponent is not defined'));

const button = await findByRole('button');
await user.click(button);

expect(mockCaptureException).toHaveBeenCalledTimes(2);
expect(mockCaptureException).toHaveBeenNthCalledWith(2, new ReferenceError('NonExistentComponent is not defined'));
});

it('renders children when there is no error', async () => {
const { queryByText } = render(() => (
<SentryErrorBoundary fallback={<div>Oops, an error occurred.</div>}>
<div>Adopt a cat</div>
</SentryErrorBoundary>
));

expect(await queryByText('Adopt a cat')).toBeInTheDocument();
expect(await queryByText('Ooops, an error occurred')).not.toBeInTheDocument();
});
});
4 changes: 3 additions & 1 deletion packages/solidjs/tsconfig.test.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@

"compilerOptions": {
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["vitest/globals"]
"types": ["vitest/globals", "vite/client", "@testing-library/jest-dom"],

// other package-specific, test-specific options
"jsx": "preserve",
"jsxImportSource": "solid-js"
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,11 @@ export default function PageRoot(props) {
Home
</A>
</li>
<li>
<A href="/error-boundary-example" class="no-underline hover:underline">
Error Boundary Example
</A>
</li>
<li class="py-2 px-4">
<A href="/error" class="no-underline hover:underline">
Error
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

export default function ErrorBoundaryExample() {
return (
<SentryErrorBoundary
fallback={(error, reset) => (
<section class="bg-gray-100 text-gray-700 p-8">
<h1 class="text-2xl font-bold">Error Boundary Fallback</h1>
<div class="flex items-center space-x-2 mb-4">
<code>{error.message}</code>
</div>
<button id="errorBoundaryResetBtn" class="border rounded-lg px-2 border-gray-900" onClick={reset}>
Reset
</button>
</section>
)}
>
<NonExistentComponent />
</SentryErrorBoundary>
);
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { lazy } from 'solid-js';

import ErrorBoundaryExample from './pages/errorboundaryexample';
import Home from './pages/home';

export const routes = [
Expand All@@ -11,6 +12,10 @@ export const routes = [
path: '/user/:id',
component: lazy(() => import('./pages/user')),
},
{
path: '/error-boundary-example',
component: ErrorBoundaryExample,
},
{
path: '**',
component: lazy(() => import('./errors/404')),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('captures an exception', async ({ page }) => {
const errorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, errorEvent] = await Promise.all([page.goto('/error-boundary-example'), errorEventPromise]);

expect(errorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});

test('captures a second exception after resetting the boundary', async ({ page }) => {
const firstErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, firstErrorEvent] = await Promise.all([page.goto('/error-boundary-example'), firstErrorEventPromise]);

expect(firstErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});

const secondErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, secondErrorEvent] = await Promise.all([
page.locator('#errorBoundaryResetBtn').click(),
await secondErrorEventPromise,
]);

expect(secondErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});
27 changes: 26 additions & 1 deletion packages/solidjs/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,6 @@ Sentry.init({
dsn: '__PUBLIC_DSN__',
integrations: [Sentry.solidRouterBrowserTracingIntegration({ useBeforeLeave, useLocation })],
tracesSampleRate: 1.0, // Capture 100% of the transactions
debug: true,
});

const SentryRouter = Sentry.withSentryRouterRouting(Router);
Expand All@@ -53,6 +52,32 @@ render(
);
```

# ErrorBoundary

To automatically capture exceptions from inside a component tree and render a fallback component, wrap the native Solid
JS `ErrorBoundary` component with `Sentry.withSentryErrorBoundary`.

```js
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

Sentry.init({
dsn: '__PUBLIC_DSN__',
tracesSampleRate: 1.0, // Capture 100% of the transactions
});

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

render(
() => (
<SentryErrorBoundary fallback={err => <div>Error: {err.message}</div>}>
<ProblematicComponent />
</SentryErrorBoundary>
),
document.getElementById('root'),
);
```

# Sourcemaps and Releases

To generate and upload source maps of your Solid JS app bundle, check our guide
Expand Down
2 changes: 2 additions & 0 deletions packages/solidjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,8 @@
"@solidjs/router": "^0.13.5",
"@solidjs/testing-library": "0.8.5",
"solid-js": "^1.8.11",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/user-event": "^14.5.2",
"vite-plugin-solid": "^2.8.2"
},
"scripts": {
Expand Down
31 changes: 31 additions & 0 deletions packages/solidjs/src/errorboundary.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { captureException } from '@sentry/browser';
import type { Component, JSX } from 'solid-js';
import { mergeProps, splitProps } from 'solid-js';
import { createComponent } from 'solid-js/web';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is solid-js/web always available to us? I don't see it being listed as peerDependency or dependency in the SDK's package.json

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's available through solid-js. At least I didn't have any issues developing locally. The solidjs templates (these are used to start projects ala create-react-app) also don't specifically list it as dep, e.g. here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see, thx for explaining! Let's leave it as is and if we get error reports (I have a feeling pnpm could complain 👀 ) we can add it later.


type ErrorBoundaryProps = {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
fallback: JSX.Element | ((err: any, reset: () => void) => JSX.Element);
children: JSX.Element;
};

/**
* A higher-order component to wrap Solid's ErrorBoundary to capture exceptions.
*/
export function withSentryErrorBoundary(ErrorBoundary: Component<ErrorBoundaryProps>): Component<ErrorBoundaryProps> {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a naive question (sorry if I missed convos around this): Why do users need to pass in the ErrorBoundary component from solid here? Can we not import it like the other solid imports?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not naive at all. That's the approach I initially took, but it doesn't quite do the job correctly.

From local testing and similar experience with the router instrumentation, certain functions and functionality are app context specific. For the router, this meant that we couldn't use use hooks because they didn't have the user's router context. For the ErrorBoundary the reset function is contextual, so exporting a generic error boundary from this package would mean the reset function does nothing.

Hope this helps to understand it a bit better.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for explaining!

const SentryErrorBoundary = (props: ErrorBoundaryProps): JSX.Element => {
const [local, others] = splitProps(props, ['fallback']);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const fallback = (error: any, reset: () => void): JSX.Element => {
captureException(error);

const f = local.fallback;
return typeof f === 'function' ? f(error, reset) : f;
};

return createComponent(ErrorBoundary, mergeProps({ fallback }, others));
};

return SentryErrorBoundary;
}
1 change: 1 addition & 0 deletions packages/solidjs/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,3 +3,4 @@ export * from '@sentry/browser';
export { init } from './sdk';

export * from './solidrouter';
export * from './errorboundary';
108 changes: 108 additions & 0 deletions packages/solidjs/test/errorboundary.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/* eslint-disable @typescript-eslint/unbound-method */
import type * as SentryBrowser from '@sentry/browser';
import { createTransport, getCurrentScope, setCurrentClient } from '@sentry/core';
import { render } from '@solidjs/testing-library';
import userEvent from '@testing-library/user-event';
import { vi } from 'vitest';

import { ErrorBoundary } from 'solid-js';
import { BrowserClient, withSentryErrorBoundary } from '../src';

const mockCaptureException = vi.fn();
vi.mock('@sentry/browser', async () => {
const actual = await vi.importActual<typeof SentryBrowser>('@sentry/browser');
return {
...actual,
captureException: (...args) => mockCaptureException(...args),
} as typeof SentryBrowser;
});

const user = userEvent.setup();
const SentryErrorBoundary = withSentryErrorBoundary(ErrorBoundary);

describe('withSentryErrorBoundary', () => {
function createMockBrowserClient(): BrowserClient {
return new BrowserClient({
integrations: [],
tracesSampleRate: 1,
transport: () => createTransport({ recordDroppedEvent: () => undefined }, _ => Promise.resolve({})),
stackParser: () => [],
});
}

beforeEach(() => {
vi.clearAllMocks();

const client = createMockBrowserClient();
setCurrentClient(client);
});

afterEach(() => {
getCurrentScope().setClient(undefined);
});

it('calls `captureException` when an error occurs`', () => {
render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenLastCalledWith(new ReferenceError('NonExistentComponent is not defined'));
});

it('renders the fallback component', async () => {
const { findByText } = render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(await findByText('Ooops, an error occurred.')).toBeInTheDocument();
});

it('passes the `error` and `reset` function to the fallback component', () => {
const mockFallback = vi.fn();

render(() => {
<SentryErrorBoundary fallback={mockFallback}>
<NonExistentComponent />
</SentryErrorBoundary>;
});

expect(mockFallback).toHaveBeenCalledTimes(1);
expect(mockFallback).toHaveBeenCalledWith(
new ReferenceError('NonExistentComponent is not defined'),
expect.any(Function),
);
});

it('calls `captureException` again after resetting', async () => {
const { findByRole } = render(() => (
<SentryErrorBoundary fallback={(_, reset) => <button onClick={reset}>Reset</button>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenNthCalledWith(1, new ReferenceError('NonExistentComponent is not defined'));

const button = await findByRole('button');
await user.click(button);

expect(mockCaptureException).toHaveBeenCalledTimes(2);
expect(mockCaptureException).toHaveBeenNthCalledWith(2, new ReferenceError('NonExistentComponent is not defined'));
});

it('renders children when there is no error', async () => {
const { queryByText } = render(() => (
<SentryErrorBoundary fallback={<div>Oops, an error occurred.</div>}>
<div>Adopt a cat</div>
</SentryErrorBoundary>
));

expect(await queryByText('Adopt a cat')).toBeInTheDocument();
expect(await queryByText('Ooops, an error occurred')).not.toBeInTheDocument();
});
});
4 changes: 3 additions & 1 deletion packages/solidjs/tsconfig.test.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@

"compilerOptions": {
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["vitest/globals"]
"types": ["vitest/globals", "vite/client", "@testing-library/jest-dom"],

// other package-specific, test-specific options
"jsx": "preserve",
"jsxImportSource": "solid-js"
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,11 @@ export default function PageRoot(props) {
Home
</A>
</li>
<li>
<A href="/error-boundary-example" class="no-underline hover:underline">
Error Boundary Example
</A>
</li>
<li class="py-2 px-4">
<A href="/error" class="no-underline hover:underline">
Error
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

export default function ErrorBoundaryExample() {
return (
<SentryErrorBoundary
fallback={(error, reset) => (
<section class="bg-gray-100 text-gray-700 p-8">
<h1 class="text-2xl font-bold">Error Boundary Fallback</h1>
<div class="flex items-center space-x-2 mb-4">
<code>{error.message}</code>
</div>
<button id="errorBoundaryResetBtn" class="border rounded-lg px-2 border-gray-900" onClick={reset}>
Reset
</button>
</section>
)}
>
<NonExistentComponent />
</SentryErrorBoundary>
);
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { lazy } from 'solid-js';

import ErrorBoundaryExample from './pages/errorboundaryexample';
import Home from './pages/home';

export const routes = [
Expand All@@ -11,6 +12,10 @@ export const routes = [
path: '/user/:id',
component: lazy(() => import('./pages/user')),
},
{
path: '/error-boundary-example',
component: ErrorBoundaryExample,
},
{
path: '**',
component: lazy(() => import('./errors/404')),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('captures an exception', async ({ page }) => {
const errorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, errorEvent] = await Promise.all([page.goto('/error-boundary-example'), errorEventPromise]);

expect(errorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});

test('captures a second exception after resetting the boundary', async ({ page }) => {
const firstErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, firstErrorEvent] = await Promise.all([page.goto('/error-boundary-example'), firstErrorEventPromise]);

expect(firstErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});

const secondErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, secondErrorEvent] = await Promise.all([
page.locator('#errorBoundaryResetBtn').click(),
await secondErrorEventPromise,
]);

expect(secondErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});
27 changes: 26 additions & 1 deletion packages/solidjs/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,6 @@ Sentry.init({
dsn: '__PUBLIC_DSN__',
integrations: [Sentry.solidRouterBrowserTracingIntegration({ useBeforeLeave, useLocation })],
tracesSampleRate: 1.0, // Capture 100% of the transactions
debug: true,
});

const SentryRouter = Sentry.withSentryRouterRouting(Router);
Expand All@@ -53,6 +52,32 @@ render(
);
```

# ErrorBoundary

To automatically capture exceptions from inside a component tree and render a fallback component, wrap the native Solid
JS `ErrorBoundary` component with `Sentry.withSentryErrorBoundary`.

```js
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

Sentry.init({
dsn: '__PUBLIC_DSN__',
tracesSampleRate: 1.0, // Capture 100% of the transactions
});

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

render(
() => (
<SentryErrorBoundary fallback={err => <div>Error: {err.message}</div>}>
<ProblematicComponent />
</SentryErrorBoundary>
),
document.getElementById('root'),
);
```

# Sourcemaps and Releases

To generate and upload source maps of your Solid JS app bundle, check our guide
Expand Down
2 changes: 2 additions & 0 deletions packages/solidjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,8 @@
"@solidjs/router": "^0.13.5",
"@solidjs/testing-library": "0.8.5",
"solid-js": "^1.8.11",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/user-event": "^14.5.2",
"vite-plugin-solid": "^2.8.2"
},
"scripts": {
Expand Down
31 changes: 31 additions & 0 deletions packages/solidjs/src/errorboundary.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { captureException } from '@sentry/browser';
import type { Component, JSX } from 'solid-js';
import { mergeProps, splitProps } from 'solid-js';
import { createComponent } from 'solid-js/web';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is solid-js/web always available to us? I don't see it being listed as peerDependency or dependency in the SDK's package.json

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's available through solid-js. At least I didn't have any issues developing locally. The solidjs templates (these are used to start projects ala create-react-app) also don't specifically list it as dep, e.g. here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see, thx for explaining! Let's leave it as is and if we get error reports (I have a feeling pnpm could complain 👀 ) we can add it later.


type ErrorBoundaryProps = {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
fallback: JSX.Element | ((err: any, reset: () => void) => JSX.Element);
children: JSX.Element;
};

/**
* A higher-order component to wrap Solid's ErrorBoundary to capture exceptions.
*/
export function withSentryErrorBoundary(ErrorBoundary: Component<ErrorBoundaryProps>): Component<ErrorBoundaryProps> {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a naive question (sorry if I missed convos around this): Why do users need to pass in the ErrorBoundary component from solid here? Can we not import it like the other solid imports?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not naive at all. That's the approach I initially took, but it doesn't quite do the job correctly.

From local testing and similar experience with the router instrumentation, certain functions and functionality are app context specific. For the router, this meant that we couldn't use use hooks because they didn't have the user's router context. For the ErrorBoundary the reset function is contextual, so exporting a generic error boundary from this package would mean the reset function does nothing.

Hope this helps to understand it a bit better.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for explaining!

const SentryErrorBoundary = (props: ErrorBoundaryProps): JSX.Element => {
const [local, others] = splitProps(props, ['fallback']);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const fallback = (error: any, reset: () => void): JSX.Element => {
captureException(error);

const f = local.fallback;
return typeof f === 'function' ? f(error, reset) : f;
};

return createComponent(ErrorBoundary, mergeProps({ fallback }, others));
};

return SentryErrorBoundary;
}
1 change: 1 addition & 0 deletions packages/solidjs/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,3 +3,4 @@ export * from '@sentry/browser';
export { init } from './sdk';

export * from './solidrouter';
export * from './errorboundary';
108 changes: 108 additions & 0 deletions packages/solidjs/test/errorboundary.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/* eslint-disable @typescript-eslint/unbound-method */
import type * as SentryBrowser from '@sentry/browser';
import { createTransport, getCurrentScope, setCurrentClient } from '@sentry/core';
import { render } from '@solidjs/testing-library';
import userEvent from '@testing-library/user-event';
import { vi } from 'vitest';

import { ErrorBoundary } from 'solid-js';
import { BrowserClient, withSentryErrorBoundary } from '../src';

const mockCaptureException = vi.fn();
vi.mock('@sentry/browser', async () => {
const actual = await vi.importActual<typeof SentryBrowser>('@sentry/browser');
return {
...actual,
captureException: (...args) => mockCaptureException(...args),
} as typeof SentryBrowser;
});

const user = userEvent.setup();
const SentryErrorBoundary = withSentryErrorBoundary(ErrorBoundary);

describe('withSentryErrorBoundary', () => {
function createMockBrowserClient(): BrowserClient {
return new BrowserClient({
integrations: [],
tracesSampleRate: 1,
transport: () => createTransport({ recordDroppedEvent: () => undefined }, _ => Promise.resolve({})),
stackParser: () => [],
});
}

beforeEach(() => {
vi.clearAllMocks();

const client = createMockBrowserClient();
setCurrentClient(client);
});

afterEach(() => {
getCurrentScope().setClient(undefined);
});

it('calls `captureException` when an error occurs`', () => {
render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenLastCalledWith(new ReferenceError('NonExistentComponent is not defined'));
});

it('renders the fallback component', async () => {
const { findByText } = render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(await findByText('Ooops, an error occurred.')).toBeInTheDocument();
});

it('passes the `error` and `reset` function to the fallback component', () => {
const mockFallback = vi.fn();

render(() => {
<SentryErrorBoundary fallback={mockFallback}>
<NonExistentComponent />
</SentryErrorBoundary>;
});

expect(mockFallback).toHaveBeenCalledTimes(1);
expect(mockFallback).toHaveBeenCalledWith(
new ReferenceError('NonExistentComponent is not defined'),
expect.any(Function),
);
});

it('calls `captureException` again after resetting', async () => {
const { findByRole } = render(() => (
<SentryErrorBoundary fallback={(_, reset) => <button onClick={reset}>Reset</button>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenNthCalledWith(1, new ReferenceError('NonExistentComponent is not defined'));

const button = await findByRole('button');
await user.click(button);

expect(mockCaptureException).toHaveBeenCalledTimes(2);
expect(mockCaptureException).toHaveBeenNthCalledWith(2, new ReferenceError('NonExistentComponent is not defined'));
});

it('renders children when there is no error', async () => {
const { queryByText } = render(() => (
<SentryErrorBoundary fallback={<div>Oops, an error occurred.</div>}>
<div>Adopt a cat</div>
</SentryErrorBoundary>
));

expect(await queryByText('Adopt a cat')).toBeInTheDocument();
expect(await queryByText('Ooops, an error occurred')).not.toBeInTheDocument();
});
});
4 changes: 3 additions & 1 deletion packages/solidjs/tsconfig.test.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@

"compilerOptions": {
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["vitest/globals"]
"types": ["vitest/globals", "vite/client", "@testing-library/jest-dom"],

// other package-specific, test-specific options
"jsx": "preserve",
"jsxImportSource": "solid-js"
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,11 @@ export default function PageRoot(props) {
Home
</A>
</li>
<li>
<A href="/error-boundary-example" class="no-underline hover:underline">
Error Boundary Example
</A>
</li>
<li class="py-2 px-4">
<A href="/error" class="no-underline hover:underline">
Error
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

export default function ErrorBoundaryExample() {
return (
<SentryErrorBoundary
fallback={(error, reset) => (
<section class="bg-gray-100 text-gray-700 p-8">
<h1 class="text-2xl font-bold">Error Boundary Fallback</h1>
<div class="flex items-center space-x-2 mb-4">
<code>{error.message}</code>
</div>
<button id="errorBoundaryResetBtn" class="border rounded-lg px-2 border-gray-900" onClick={reset}>
Reset
</button>
</section>
)}
>
<NonExistentComponent />
</SentryErrorBoundary>
);
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { lazy } from 'solid-js';

import ErrorBoundaryExample from './pages/errorboundaryexample';
import Home from './pages/home';

export const routes = [
Expand All@@ -11,6 +12,10 @@ export const routes = [
path: '/user/:id',
component: lazy(() => import('./pages/user')),
},
{
path: '/error-boundary-example',
component: ErrorBoundaryExample,
},
{
path: '**',
component: lazy(() => import('./errors/404')),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('captures an exception', async ({ page }) => {
const errorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, errorEvent] = await Promise.all([page.goto('/error-boundary-example'), errorEventPromise]);

expect(errorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});

test('captures a second exception after resetting the boundary', async ({ page }) => {
const firstErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, firstErrorEvent] = await Promise.all([page.goto('/error-boundary-example'), firstErrorEventPromise]);

expect(firstErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});

const secondErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, secondErrorEvent] = await Promise.all([
page.locator('#errorBoundaryResetBtn').click(),
await secondErrorEventPromise,
]);

expect(secondErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});
27 changes: 26 additions & 1 deletion packages/solidjs/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,6 @@ Sentry.init({
dsn: '__PUBLIC_DSN__',
integrations: [Sentry.solidRouterBrowserTracingIntegration({ useBeforeLeave, useLocation })],
tracesSampleRate: 1.0, // Capture 100% of the transactions
debug: true,
});

const SentryRouter = Sentry.withSentryRouterRouting(Router);
Expand All@@ -53,6 +52,32 @@ render(
);
```

# ErrorBoundary

To automatically capture exceptions from inside a component tree and render a fallback component, wrap the native Solid
JS `ErrorBoundary` component with `Sentry.withSentryErrorBoundary`.

```js
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

Sentry.init({
dsn: '__PUBLIC_DSN__',
tracesSampleRate: 1.0, // Capture 100% of the transactions
});

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

render(
() => (
<SentryErrorBoundary fallback={err => <div>Error: {err.message}</div>}>
<ProblematicComponent />
</SentryErrorBoundary>
),
document.getElementById('root'),
);
```

# Sourcemaps and Releases

To generate and upload source maps of your Solid JS app bundle, check our guide
Expand Down
2 changes: 2 additions & 0 deletions packages/solidjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,8 @@
"@solidjs/router": "^0.13.5",
"@solidjs/testing-library": "0.8.5",
"solid-js": "^1.8.11",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/user-event": "^14.5.2",
"vite-plugin-solid": "^2.8.2"
},
"scripts": {
Expand Down
31 changes: 31 additions & 0 deletions packages/solidjs/src/errorboundary.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { captureException } from '@sentry/browser';
import type { Component, JSX } from 'solid-js';
import { mergeProps, splitProps } from 'solid-js';
import { createComponent } from 'solid-js/web';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is solid-js/web always available to us? I don't see it being listed as peerDependency or dependency in the SDK's package.json

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's available through solid-js. At least I didn't have any issues developing locally. The solidjs templates (these are used to start projects ala create-react-app) also don't specifically list it as dep, e.g. here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see, thx for explaining! Let's leave it as is and if we get error reports (I have a feeling pnpm could complain 👀 ) we can add it later.


type ErrorBoundaryProps = {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
fallback: JSX.Element | ((err: any, reset: () => void) => JSX.Element);
children: JSX.Element;
};

/**
* A higher-order component to wrap Solid's ErrorBoundary to capture exceptions.
*/
export function withSentryErrorBoundary(ErrorBoundary: Component<ErrorBoundaryProps>): Component<ErrorBoundaryProps> {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a naive question (sorry if I missed convos around this): Why do users need to pass in the ErrorBoundary component from solid here? Can we not import it like the other solid imports?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not naive at all. That's the approach I initially took, but it doesn't quite do the job correctly.

From local testing and similar experience with the router instrumentation, certain functions and functionality are app context specific. For the router, this meant that we couldn't use use hooks because they didn't have the user's router context. For the ErrorBoundary the reset function is contextual, so exporting a generic error boundary from this package would mean the reset function does nothing.

Hope this helps to understand it a bit better.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for explaining!

const SentryErrorBoundary = (props: ErrorBoundaryProps): JSX.Element => {
const [local, others] = splitProps(props, ['fallback']);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const fallback = (error: any, reset: () => void): JSX.Element => {
captureException(error);

const f = local.fallback;
return typeof f === 'function' ? f(error, reset) : f;
};

return createComponent(ErrorBoundary, mergeProps({ fallback }, others));
};

return SentryErrorBoundary;
}
1 change: 1 addition & 0 deletions packages/solidjs/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,3 +3,4 @@ export * from '@sentry/browser';
export { init } from './sdk';

export * from './solidrouter';
export * from './errorboundary';
108 changes: 108 additions & 0 deletions packages/solidjs/test/errorboundary.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/* eslint-disable @typescript-eslint/unbound-method */
import type * as SentryBrowser from '@sentry/browser';
import { createTransport, getCurrentScope, setCurrentClient } from '@sentry/core';
import { render } from '@solidjs/testing-library';
import userEvent from '@testing-library/user-event';
import { vi } from 'vitest';

import { ErrorBoundary } from 'solid-js';
import { BrowserClient, withSentryErrorBoundary } from '../src';

const mockCaptureException = vi.fn();
vi.mock('@sentry/browser', async () => {
const actual = await vi.importActual<typeof SentryBrowser>('@sentry/browser');
return {
...actual,
captureException: (...args) => mockCaptureException(...args),
} as typeof SentryBrowser;
});

const user = userEvent.setup();
const SentryErrorBoundary = withSentryErrorBoundary(ErrorBoundary);

describe('withSentryErrorBoundary', () => {
function createMockBrowserClient(): BrowserClient {
return new BrowserClient({
integrations: [],
tracesSampleRate: 1,
transport: () => createTransport({ recordDroppedEvent: () => undefined }, _ => Promise.resolve({})),
stackParser: () => [],
});
}

beforeEach(() => {
vi.clearAllMocks();

const client = createMockBrowserClient();
setCurrentClient(client);
});

afterEach(() => {
getCurrentScope().setClient(undefined);
});

it('calls `captureException` when an error occurs`', () => {
render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenLastCalledWith(new ReferenceError('NonExistentComponent is not defined'));
});

it('renders the fallback component', async () => {
const { findByText } = render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(await findByText('Ooops, an error occurred.')).toBeInTheDocument();
});

it('passes the `error` and `reset` function to the fallback component', () => {
const mockFallback = vi.fn();

render(() => {
<SentryErrorBoundary fallback={mockFallback}>
<NonExistentComponent />
</SentryErrorBoundary>;
});

expect(mockFallback).toHaveBeenCalledTimes(1);
expect(mockFallback).toHaveBeenCalledWith(
new ReferenceError('NonExistentComponent is not defined'),
expect.any(Function),
);
});

it('calls `captureException` again after resetting', async () => {
const { findByRole } = render(() => (
<SentryErrorBoundary fallback={(_, reset) => <button onClick={reset}>Reset</button>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenNthCalledWith(1, new ReferenceError('NonExistentComponent is not defined'));

const button = await findByRole('button');
await user.click(button);

expect(mockCaptureException).toHaveBeenCalledTimes(2);
expect(mockCaptureException).toHaveBeenNthCalledWith(2, new ReferenceError('NonExistentComponent is not defined'));
});

it('renders children when there is no error', async () => {
const { queryByText } = render(() => (
<SentryErrorBoundary fallback={<div>Oops, an error occurred.</div>}>
<div>Adopt a cat</div>
</SentryErrorBoundary>
));

expect(await queryByText('Adopt a cat')).toBeInTheDocument();
expect(await queryByText('Ooops, an error occurred')).not.toBeInTheDocument();
});
});
4 changes: 3 additions & 1 deletion packages/solidjs/tsconfig.test.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@

"compilerOptions": {
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["vitest/globals"]
"types": ["vitest/globals", "vite/client", "@testing-library/jest-dom"],

// other package-specific, test-specific options
"jsx": "preserve",
"jsxImportSource": "solid-js"
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,11 @@ export default function PageRoot(props) {
Home
</A>
</li>
<li>
<A href="/error-boundary-example" class="no-underline hover:underline">
Error Boundary Example
</A>
</li>
<li class="py-2 px-4">
<A href="/error" class="no-underline hover:underline">
Error
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

export default function ErrorBoundaryExample() {
return (
<SentryErrorBoundary
fallback={(error, reset) => (
<section class="bg-gray-100 text-gray-700 p-8">
<h1 class="text-2xl font-bold">Error Boundary Fallback</h1>
<div class="flex items-center space-x-2 mb-4">
<code>{error.message}</code>
</div>
<button id="errorBoundaryResetBtn" class="border rounded-lg px-2 border-gray-900" onClick={reset}>
Reset
</button>
</section>
)}
>
<NonExistentComponent />
</SentryErrorBoundary>
);
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { lazy } from 'solid-js';

import ErrorBoundaryExample from './pages/errorboundaryexample';
import Home from './pages/home';

export const routes = [
Expand All@@ -11,6 +12,10 @@ export const routes = [
path: '/user/:id',
component: lazy(() => import('./pages/user')),
},
{
path: '/error-boundary-example',
component: ErrorBoundaryExample,
},
{
path: '**',
component: lazy(() => import('./errors/404')),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('captures an exception', async ({ page }) => {
const errorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, errorEvent] = await Promise.all([page.goto('/error-boundary-example'), errorEventPromise]);

expect(errorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});

test('captures a second exception after resetting the boundary', async ({ page }) => {
const firstErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, firstErrorEvent] = await Promise.all([page.goto('/error-boundary-example'), firstErrorEventPromise]);

expect(firstErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});

const secondErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, secondErrorEvent] = await Promise.all([
page.locator('#errorBoundaryResetBtn').click(),
await secondErrorEventPromise,
]);

expect(secondErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});
27 changes: 26 additions & 1 deletion packages/solidjs/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,6 @@ Sentry.init({
dsn: '__PUBLIC_DSN__',
integrations: [Sentry.solidRouterBrowserTracingIntegration({ useBeforeLeave, useLocation })],
tracesSampleRate: 1.0, // Capture 100% of the transactions
debug: true,
});

const SentryRouter = Sentry.withSentryRouterRouting(Router);
Expand All@@ -53,6 +52,32 @@ render(
);
```

# ErrorBoundary

To automatically capture exceptions from inside a component tree and render a fallback component, wrap the native Solid
JS `ErrorBoundary` component with `Sentry.withSentryErrorBoundary`.

```js
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

Sentry.init({
dsn: '__PUBLIC_DSN__',
tracesSampleRate: 1.0, // Capture 100% of the transactions
});

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

render(
() => (
<SentryErrorBoundary fallback={err => <div>Error: {err.message}</div>}>
<ProblematicComponent />
</SentryErrorBoundary>
),
document.getElementById('root'),
);
```

# Sourcemaps and Releases

To generate and upload source maps of your Solid JS app bundle, check our guide
Expand Down
2 changes: 2 additions & 0 deletions packages/solidjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,8 @@
"@solidjs/router": "^0.13.5",
"@solidjs/testing-library": "0.8.5",
"solid-js": "^1.8.11",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/user-event": "^14.5.2",
"vite-plugin-solid": "^2.8.2"
},
"scripts": {
Expand Down
31 changes: 31 additions & 0 deletions packages/solidjs/src/errorboundary.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { captureException } from '@sentry/browser';
import type { Component, JSX } from 'solid-js';
import { mergeProps, splitProps } from 'solid-js';
import { createComponent } from 'solid-js/web';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is solid-js/web always available to us? I don't see it being listed as peerDependency or dependency in the SDK's package.json

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's available through solid-js. At least I didn't have any issues developing locally. The solidjs templates (these are used to start projects ala create-react-app) also don't specifically list it as dep, e.g. here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see, thx for explaining! Let's leave it as is and if we get error reports (I have a feeling pnpm could complain 👀 ) we can add it later.


type ErrorBoundaryProps = {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
fallback: JSX.Element | ((err: any, reset: () => void) => JSX.Element);
children: JSX.Element;
};

/**
* A higher-order component to wrap Solid's ErrorBoundary to capture exceptions.
*/
export function withSentryErrorBoundary(ErrorBoundary: Component<ErrorBoundaryProps>): Component<ErrorBoundaryProps> {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a naive question (sorry if I missed convos around this): Why do users need to pass in the ErrorBoundary component from solid here? Can we not import it like the other solid imports?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not naive at all. That's the approach I initially took, but it doesn't quite do the job correctly.

From local testing and similar experience with the router instrumentation, certain functions and functionality are app context specific. For the router, this meant that we couldn't use use hooks because they didn't have the user's router context. For the ErrorBoundary the reset function is contextual, so exporting a generic error boundary from this package would mean the reset function does nothing.

Hope this helps to understand it a bit better.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for explaining!

const SentryErrorBoundary = (props: ErrorBoundaryProps): JSX.Element => {
const [local, others] = splitProps(props, ['fallback']);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const fallback = (error: any, reset: () => void): JSX.Element => {
captureException(error);

const f = local.fallback;
return typeof f === 'function' ? f(error, reset) : f;
};

return createComponent(ErrorBoundary, mergeProps({ fallback }, others));
};

return SentryErrorBoundary;
}
1 change: 1 addition & 0 deletions packages/solidjs/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,3 +3,4 @@ export * from '@sentry/browser';
export { init } from './sdk';

export * from './solidrouter';
export * from './errorboundary';
108 changes: 108 additions & 0 deletions packages/solidjs/test/errorboundary.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/* eslint-disable @typescript-eslint/unbound-method */
import type * as SentryBrowser from '@sentry/browser';
import { createTransport, getCurrentScope, setCurrentClient } from '@sentry/core';
import { render } from '@solidjs/testing-library';
import userEvent from '@testing-library/user-event';
import { vi } from 'vitest';

import { ErrorBoundary } from 'solid-js';
import { BrowserClient, withSentryErrorBoundary } from '../src';

const mockCaptureException = vi.fn();
vi.mock('@sentry/browser', async () => {
const actual = await vi.importActual<typeof SentryBrowser>('@sentry/browser');
return {
...actual,
captureException: (...args) => mockCaptureException(...args),
} as typeof SentryBrowser;
});

const user = userEvent.setup();
const SentryErrorBoundary = withSentryErrorBoundary(ErrorBoundary);

describe('withSentryErrorBoundary', () => {
function createMockBrowserClient(): BrowserClient {
return new BrowserClient({
integrations: [],
tracesSampleRate: 1,
transport: () => createTransport({ recordDroppedEvent: () => undefined }, _ => Promise.resolve({})),
stackParser: () => [],
});
}

beforeEach(() => {
vi.clearAllMocks();

const client = createMockBrowserClient();
setCurrentClient(client);
});

afterEach(() => {
getCurrentScope().setClient(undefined);
});

it('calls `captureException` when an error occurs`', () => {
render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenLastCalledWith(new ReferenceError('NonExistentComponent is not defined'));
});

it('renders the fallback component', async () => {
const { findByText } = render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(await findByText('Ooops, an error occurred.')).toBeInTheDocument();
});

it('passes the `error` and `reset` function to the fallback component', () => {
const mockFallback = vi.fn();

render(() => {
<SentryErrorBoundary fallback={mockFallback}>
<NonExistentComponent />
</SentryErrorBoundary>;
});

expect(mockFallback).toHaveBeenCalledTimes(1);
expect(mockFallback).toHaveBeenCalledWith(
new ReferenceError('NonExistentComponent is not defined'),
expect.any(Function),
);
});

it('calls `captureException` again after resetting', async () => {
const { findByRole } = render(() => (
<SentryErrorBoundary fallback={(_, reset) => <button onClick={reset}>Reset</button>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenNthCalledWith(1, new ReferenceError('NonExistentComponent is not defined'));

const button = await findByRole('button');
await user.click(button);

expect(mockCaptureException).toHaveBeenCalledTimes(2);
expect(mockCaptureException).toHaveBeenNthCalledWith(2, new ReferenceError('NonExistentComponent is not defined'));
});

it('renders children when there is no error', async () => {
const { queryByText } = render(() => (
<SentryErrorBoundary fallback={<div>Oops, an error occurred.</div>}>
<div>Adopt a cat</div>
</SentryErrorBoundary>
));

expect(await queryByText('Adopt a cat')).toBeInTheDocument();
expect(await queryByText('Ooops, an error occurred')).not.toBeInTheDocument();
});
});
4 changes: 3 additions & 1 deletion packages/solidjs/tsconfig.test.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@

"compilerOptions": {
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["vitest/globals"]
"types": ["vitest/globals", "vite/client", "@testing-library/jest-dom"],

// other package-specific, test-specific options
"jsx": "preserve",
"jsxImportSource": "solid-js"
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,11 @@ export default function PageRoot(props) {
Home
</A>
</li>
<li>
<A href="/error-boundary-example" class="no-underline hover:underline">
Error Boundary Example
</A>
</li>
<li class="py-2 px-4">
<A href="/error" class="no-underline hover:underline">
Error
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

export default function ErrorBoundaryExample() {
return (
<SentryErrorBoundary
fallback={(error, reset) => (
<section class="bg-gray-100 text-gray-700 p-8">
<h1 class="text-2xl font-bold">Error Boundary Fallback</h1>
<div class="flex items-center space-x-2 mb-4">
<code>{error.message}</code>
</div>
<button id="errorBoundaryResetBtn" class="border rounded-lg px-2 border-gray-900" onClick={reset}>
Reset
</button>
</section>
)}
>
<NonExistentComponent />
</SentryErrorBoundary>
);
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { lazy } from 'solid-js';

import ErrorBoundaryExample from './pages/errorboundaryexample';
import Home from './pages/home';

export const routes = [
Expand All@@ -11,6 +12,10 @@ export const routes = [
path: '/user/:id',
component: lazy(() => import('./pages/user')),
},
{
path: '/error-boundary-example',
component: ErrorBoundaryExample,
},
{
path: '**',
component: lazy(() => import('./errors/404')),
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
import { expect, test } from '@playwright/test';
import { waitForError } from '@sentry-internal/test-utils';

test('captures an exception', async ({ page }) => {
const errorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, errorEvent] = await Promise.all([page.goto('/error-boundary-example'), errorEventPromise]);

expect(errorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});

test('captures a second exception after resetting the boundary', async ({ page }) => {
const firstErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, firstErrorEvent] = await Promise.all([page.goto('/error-boundary-example'), firstErrorEventPromise]);

expect(firstErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});

const secondErrorEventPromise = waitForError('solidjs', errorEvent => {
return !errorEvent.type;
});

const [, secondErrorEvent] = await Promise.all([
page.locator('#errorBoundaryResetBtn').click(),
await secondErrorEventPromise,
]);

expect(secondErrorEvent).toMatchObject({
exception: {
values: [
{
type: 'ReferenceError',
value: 'NonExistentComponent is not defined',
mechanism: {
type: 'generic',
handled: true,
},
},
],
},
transaction: '/error-boundary-example',
});
});
27 changes: 26 additions & 1 deletion packages/solidjs/README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,6 @@ Sentry.init({
dsn: '__PUBLIC_DSN__',
integrations: [Sentry.solidRouterBrowserTracingIntegration({ useBeforeLeave, useLocation })],
tracesSampleRate: 1.0, // Capture 100% of the transactions
debug: true,
});

const SentryRouter = Sentry.withSentryRouterRouting(Router);
Expand All@@ -53,6 +52,32 @@ render(
);
```

# ErrorBoundary

To automatically capture exceptions from inside a component tree and render a fallback component, wrap the native Solid
JS `ErrorBoundary` component with `Sentry.withSentryErrorBoundary`.

```js
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';

Sentry.init({
dsn: '__PUBLIC_DSN__',
tracesSampleRate: 1.0, // Capture 100% of the transactions
});

const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);

render(
() => (
<SentryErrorBoundary fallback={err => <div>Error: {err.message}</div>}>
<ProblematicComponent />
</SentryErrorBoundary>
),
document.getElementById('root'),
);
```

# Sourcemaps and Releases

To generate and upload source maps of your Solid JS app bundle, check our guide
Expand Down
2 changes: 2 additions & 0 deletions packages/solidjs/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,6 +54,8 @@
"@solidjs/router": "^0.13.5",
"@solidjs/testing-library": "0.8.5",
"solid-js": "^1.8.11",
"@testing-library/jest-dom": "^6.4.5",
"@testing-library/user-event": "^14.5.2",
"vite-plugin-solid": "^2.8.2"
},
"scripts": {
Expand Down
31 changes: 31 additions & 0 deletions packages/solidjs/src/errorboundary.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { captureException } from '@sentry/browser';
import type { Component, JSX } from 'solid-js';
import { mergeProps, splitProps } from 'solid-js';
import { createComponent } from 'solid-js/web';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is solid-js/web always available to us? I don't see it being listed as peerDependency or dependency in the SDK's package.json

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's available through solid-js. At least I didn't have any issues developing locally. The solidjs templates (these are used to start projects ala create-react-app) also don't specifically list it as dep, e.g. here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see, thx for explaining! Let's leave it as is and if we get error reports (I have a feeling pnpm could complain 👀 ) we can add it later.


type ErrorBoundaryProps = {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
fallback: JSX.Element | ((err: any, reset: () => void) => JSX.Element);
children: JSX.Element;
};

/**
* A higher-order component to wrap Solid's ErrorBoundary to capture exceptions.
*/
export function withSentryErrorBoundary(ErrorBoundary: Component<ErrorBoundaryProps>): Component<ErrorBoundaryProps> {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a naive question (sorry if I missed convos around this): Why do users need to pass in the ErrorBoundary component from solid here? Can we not import it like the other solid imports?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not naive at all. That's the approach I initially took, but it doesn't quite do the job correctly.

From local testing and similar experience with the router instrumentation, certain functions and functionality are app context specific. For the router, this meant that we couldn't use use hooks because they didn't have the user's router context. For the ErrorBoundary the reset function is contextual, so exporting a generic error boundary from this package would mean the reset function does nothing.

Hope this helps to understand it a bit better.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks for explaining!

const SentryErrorBoundary = (props: ErrorBoundaryProps): JSX.Element => {
const [local, others] = splitProps(props, ['fallback']);

// eslint-disable-next-line @typescript-eslint/no-explicit-any
const fallback = (error: any, reset: () => void): JSX.Element => {
captureException(error);

const f = local.fallback;
return typeof f === 'function' ? f(error, reset) : f;
};

return createComponent(ErrorBoundary, mergeProps({ fallback }, others));
};

return SentryErrorBoundary;
}
1 change: 1 addition & 0 deletions packages/solidjs/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,3 +3,4 @@ export * from '@sentry/browser';
export { init } from './sdk';

export * from './solidrouter';
export * from './errorboundary';
108 changes: 108 additions & 0 deletions packages/solidjs/test/errorboundary.test.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,108 @@
/* eslint-disable @typescript-eslint/unbound-method */
import type * as SentryBrowser from '@sentry/browser';
import { createTransport, getCurrentScope, setCurrentClient } from '@sentry/core';
import { render } from '@solidjs/testing-library';
import userEvent from '@testing-library/user-event';
import { vi } from 'vitest';

import { ErrorBoundary } from 'solid-js';
import { BrowserClient, withSentryErrorBoundary } from '../src';

const mockCaptureException = vi.fn();
vi.mock('@sentry/browser', async () => {
const actual = await vi.importActual<typeof SentryBrowser>('@sentry/browser');
return {
...actual,
captureException: (...args) => mockCaptureException(...args),
} as typeof SentryBrowser;
});

const user = userEvent.setup();
const SentryErrorBoundary = withSentryErrorBoundary(ErrorBoundary);

describe('withSentryErrorBoundary', () => {
function createMockBrowserClient(): BrowserClient {
return new BrowserClient({
integrations: [],
tracesSampleRate: 1,
transport: () => createTransport({ recordDroppedEvent: () => undefined }, _ => Promise.resolve({})),
stackParser: () => [],
});
}

beforeEach(() => {
vi.clearAllMocks();

const client = createMockBrowserClient();
setCurrentClient(client);
});

afterEach(() => {
getCurrentScope().setClient(undefined);
});

it('calls `captureException` when an error occurs`', () => {
render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenLastCalledWith(new ReferenceError('NonExistentComponent is not defined'));
});

it('renders the fallback component', async () => {
const { findByText } = render(() => (
<SentryErrorBoundary fallback={<div>Ooops, an error occurred.</div>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(await findByText('Ooops, an error occurred.')).toBeInTheDocument();
});

it('passes the `error` and `reset` function to the fallback component', () => {
const mockFallback = vi.fn();

render(() => {
<SentryErrorBoundary fallback={mockFallback}>
<NonExistentComponent />
</SentryErrorBoundary>;
});

expect(mockFallback).toHaveBeenCalledTimes(1);
expect(mockFallback).toHaveBeenCalledWith(
new ReferenceError('NonExistentComponent is not defined'),
expect.any(Function),
);
});

it('calls `captureException` again after resetting', async () => {
const { findByRole } = render(() => (
<SentryErrorBoundary fallback={(_, reset) => <button onClick={reset}>Reset</button>}>
<NonExistentComponent />
</SentryErrorBoundary>
));

expect(mockCaptureException).toHaveBeenCalledTimes(1);
expect(mockCaptureException).toHaveBeenNthCalledWith(1, new ReferenceError('NonExistentComponent is not defined'));

const button = await findByRole('button');
await user.click(button);

expect(mockCaptureException).toHaveBeenCalledTimes(2);
expect(mockCaptureException).toHaveBeenNthCalledWith(2, new ReferenceError('NonExistentComponent is not defined'));
});

it('renders children when there is no error', async () => {
const { queryByText } = render(() => (
<SentryErrorBoundary fallback={<div>Oops, an error occurred.</div>}>
<div>Adopt a cat</div>
</SentryErrorBoundary>
));

expect(await queryByText('Adopt a cat')).toBeInTheDocument();
expect(await queryByText('Ooops, an error occurred')).not.toBeInTheDocument();
});
});
4 changes: 3 additions & 1 deletion packages/solidjs/tsconfig.test.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,8 +5,10 @@

"compilerOptions": {
// should include all types from `./tsconfig.json` plus types for all test frameworks used
"types": ["vitest/globals"]
"types": ["vitest/globals", "vite/client", "@testing-library/jest-dom"],

// other package-specific, test-specific options
"jsx": "preserve",
"jsxImportSource": "solid-js"
}
}
Loading