Uh oh!
There was an error while loading. Please reload this page.
meta(changelog): Update Changelog for 8.9.0 - #12451
Merged
Merged
Conversation
This PR introduce a new continuous profiling mode. This mode is
exclusive from the current mode which considers starting and stopping
profiles on a per span basis.
I've picked the interval duration of 5s as somewhat arbitrarily. The
idea is that we dont want profiles to grow too large, because that might
become a performance issue in the event that we have a lot of deep stack
samples to process.
Since profiling mode is exclusive, we will require users to add a
profilerMode (subject to change) as the SDK option (this is subject to
change as we align the APIs cross sdks). In terms of convenience, we are
likely also going to add a Sentry.profiler.start/stop methods so that
users can have access as to when they can start and stop the profiler
(not implemented as we havent standardized on the approach yet) -
currently this relies on
getIntegrationByName("ProfilingIntegration").profiler.stop
Since the UI does not support this mode yet, I will hide the
profilerMode hidden and only allow the current automated instrumentationInstead of #12358, this is a simpler change which ensures we pick the transaction from the scope instead. I also added tests for the various different scenarios, to ensure we see how they behave: 1. INP is emitted _during_ pageload (span is active) 2. INP is emitted _after_ pageload a. Pageload is parametrized (route) b. Pageload is unparametrized (URL) When the pageload is unparametrized (default browser SDK), the transaction is not added to the DSC envelope header (which is correct and also what we do in other places). it is _always_ added to the span attributes now, though. If no span is active, it will use transactionName from the last active pageload/navigation span. There may be edge cases where this is not 100% correct (e.g. if the INP span is only emitted once the pageload is done but another navigation already started) but IMHO these are more edge cases and this change is probably fine for now..? (While at it, I also added an origin to the INP spans)
[Gitflow] Merge master into develop
…lambda-auto` (#12392) Guards the `tryPatcHandler` call by checking for the availability of `require` (which is undefined in ESM). In ESM mode, this call fails because `require` is not available. So let's not call it in this case.
add a test to our ESM Express e2e test app to test that http instrumentation is working correctly by ensuring a `http.client` span is captured. --------- Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
## Description As stated [here](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing) in the typescript docs, `types` exports should always come first, so that they are resolved correctly. This also applies to the nested `types` within and `exports` condition. This corrects an issue where `eslint-import-resolver-typescript` was not correctly resolving the full types for Sentry.
Ensure the `types` export is always first, as documented here: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing Follow up to #12355
Remove some unneeded deps, and align playwright version everywhere.
…12398) Fix an issue where the correct transactionName could not be obtained when using nested routes in VueRouter.
Adds CLS, FID, and INP breadcrumbs. Updates all web vital breadcrumbs to include rating Closes#11639 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Luca Forstner <luca.forstner@sentry.io> Co-authored-by: Andrei <168741329+andreiborza@users.noreply.github.com> Co-authored-by: Francesco Novy <francesco.novy@sentry.io> Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io> Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Forgot to shoutout @dohooo, @mohd-akram and @ykzts for their help fixing bugs with the SDK this release - will also update the main release notes!
We don't actually use these, so no need to install them.
This updates contributing docs to mention that we use volta, + also to set up PNPM support.
…idn't wrap handler (#12407) Fix span collision by checking if the AWS lambda handler was already wrapped by Otel instrumentation and only if not starting our own root span. The rest of our handler is still being used (i.e. the flushing logic, error capturing, etc) regardless of otel wrapping. Also Adjusted E2E tests to: - more closely resemble the AWS environment - enable auto patching of the handler with the Sentry SDK handler - better check for Otel and manual spans Ref #12409
…span (#12430) Add the `sentry.op` attribute/`op` property to the created root span/transaction of a lambda function.
To automatically capture exceptions from inside a component tree and
render a fallback component, wrap the native Solid
JS `ErrorBoundary` component with `Sentry.withSentryErrorBoundary`.
```js
import * as Sentry from '@sentry/solidjs';
import { ErrorBoundary } from 'solid-js';
Sentry.init({
dsn: '__PUBLIC_DSN__',
tracesSampleRate: 1.0, // Capture 100% of the transactions
});
const SentryErrorBoundary = Sentry.withSentryErrorBoundary(ErrorBoundary);
render(
() => (
<SentryErrorBoundary fallback={err => <div>Error: {err.message}</div>}>
<ProblematicComponent />
</SentryErrorBoundary>
),
document.getElementById('root'),
);
```
**Note**: When using an `ErrorBoundary` in conjunction with Solid
Router, the fallback component renders twice, see
[here](solidjs/solid-router#440).Waiting with merging this until the package is ready. --------- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
Follow-up as cache logic for `ioredis` was already added.
Lms24
approved these changes
Jun 11, 2024
| ### Important changes | ||
| - **feat(solid): Add solid sdk** |
Member
There was a problem hiding this comment.
totally optional:
Suggested change
| -**feat(solid): Add solid sdk** | |
| -**feat(solid): Add solid SDK** |
andreiborzaforce-pushed
the
prepare-release/8.9.0
branch
from
June 11, 2024 08:10
9b22918 to
1c36f9bCompares1gr1d
approved these changes
Jun 11, 2024
mydea
reviewed
Jun 11, 2024
| - **feat(solid): Add Solid SDK** | ||
| This release adds a dedicated SDK for [Solid JS](https://www.solidjs.com/) in alpha state with instrumentation for | ||
| [Solid Router](https://docs.solidjs.com/solid-router) and custom `ErrorBoundary`. See the |
Member
There was a problem hiding this comment.
Suggested change
| [Solid Router](https://docs.solidjs.com/solid-router) and custom `ErrorBoundary`. See the | |
| [Solid Router](https://docs.solidjs.com/solid-router) and a custom `ErrorBoundary`. See the |
mydea
reviewed
Jun 11, 2024
| ### Other changes | ||
| - build: Cleanup dependencies (#12405) |
Member
There was a problem hiding this comment.
Suggested change
| - build: Cleanup dependencies (#12405) |
mydea
approved these changes
Jun 11, 2024
andreiborzaforce-pushed
the
prepare-release/8.9.0
branch
from
June 11, 2024 08:13
1c36f9b to
7d29a99CompareContributor
size-limit report 📦
|
andreiborza
marked this pull request as draft
June 11, 2024 09:08
andreiborza
commented
Jun 11, 2024
MemberAuthor
Drafted, waiting for #12453 to make it in. |
Fix a server-side re-export problem of `@sentry/node` exports in the Astro SDK. It seems that the `export * from '@sentry/node'` "overruled" the explicit exports. So this patch changes our export statements to: - only export explicit, named exports in the JS server side entry point - continue exporting all types via the `*` export in the types entry point fixes#12410
Lms24force-pushed
the
prepare-release/8.9.0
branch
from
June 11, 2024 10:58
7d29a99 to
332a7abCompareandreiborza
marked this pull request as ready for review
June 11, 2024 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.