Uh oh!
There was an error while loading. Please reload this page.
ref: Enable noUncheckedIndexedAccess TS config - #12461
Merged
Merged
Conversation
Contributor
size-limit report 📦
|
s1gr1d
approved these changes
Jun 12, 2024
Comment on lines
+80
to
+81
| [requestHeaders, requestCookies] = _parseCookieHeaders('Cookie', request); | ||
| [responseHeaders, responseCookies] = _parseCookieHeaders('Set-Cookie', response); |
Lms24
approved these changes
Jun 12, 2024
Lms24
left a comment
Member
There was a problem hiding this comment.
Nice! Bundle size hit doesn't look too bad (and even better if we can even it out with the no-unnecessary-conditions lint rule).
mydeaforce-pushed
the
fn/fix-guard
branch
3 times, most recently
from
June 13, 2024 14:34
c2e6ade to
cc029b0Compare| console.log(`Installing typescript@${tsVersion}...`); | ||
| execSync(`yarn add --dev --ignore-workspace-root-check typescript@${tsVersion}`, { stdio: 'inherit', cwd }); |
Check warning
Code scanning / CodeQL
Indirect uncontrolled command line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the
noUncheckedIndexedAccessTS config, ensuring that we always properly guard for array/object access.Sometimes, this leads to a bit of boilerplate, but enabling this def. found some places in the code where things could go wrong before.
Closes#12440
Afterwards, we can look into enabling https://typescript-eslint.io/rules/no-unnecessary-condition/.