fix(browser): Make sure measure spans have valid start timestamps#12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AbhiPrasad merged 6 commits into from
Jun 27, 2024
Merged

fix(browser): Make sure measure spans have valid start timestamps #12648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aba67fa
fix(browser): Make sure measure spans have valid start timestamps
AbhiPrasad Jun 25, 2024
89ea011
Update packages/browser-utils/src/metrics/browserMetrics.ts
AbhiPrasad Jun 26, 2024
1965c2c
test
AbhiPrasad Jun 26, 2024
98b0280
this too
AbhiPrasad Jun 26, 2024
ef249b9
move into template
AbhiPrasad Jun 27, 2024
045c4bb
assert on correct sets of spans
AbhiPrasad Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/init.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
// Add measure before SDK initializes
const end = performance.now();
performance.measure('Next.js-before-hydration', {
duration: 1000,
end,
});

import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
debug: true,
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [
Sentry.browserTracingIntegration({
idleTimeout: 9000,
}),
],
tracesSampleRate: 1,
});
35 changes: 35 additions & 0 deletions dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import { expect } from '@playwright/test';
import type { Event } from '@sentry/types';

import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';

// Validation test for https://github.com/getsentry/sentry-javascript/issues/12281
sentryTest('should add browser-related spans to pageload transaction', async ({ getLocalTestPath, page }) => {
if (shouldSkipTracingTest()) {
sentryTest.skip();
}

const url = await getLocalTestPath({ testDir: __dirname });

const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
const browserSpans = eventData.spans?.filter(({ op }) => op === 'browser');

// Spans `domContentLoadedEvent`, `connect`, `cache` and `DNS` are not
// always inside `pageload` transaction.
expect(browserSpans?.length).toBeGreaterThanOrEqual(4);

const requestSpan = browserSpans!.find(({ description }) => description === 'request');
expect(requestSpan).toBeDefined();

const measureSpan = eventData.spans?.find(({ op }) => op === 'measure');
expect(measureSpan).toBeDefined();

expect(requestSpan!.start_timestamp).toBeLessThanOrEqual(measureSpan!.start_timestamp);
expect(measureSpan?.data).toEqual({
'sentry.browser.measure_happened_before_request': true,
'sentry.browser.measure_start_time': expect.any(Number),
'sentry.op': 'measure',
'sentry.origin': 'auto.resource.browser.metrics',
});
});
66 changes: 39 additions & 27 deletions packages/browser-utils/src/metrics/browserMetrics.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -342,15 +342,34 @@ export function _addMeasureSpans(
duration: number,
timeOrigin: number,
): number {
const measureStartTimestamp = timeOrigin + startTime;
const measureEndTimestamp = measureStartTimestamp + duration;
const navEntry = getNavigationEntry();
const requestTime = msToSec(navEntry ? navEntry.requestStart : 0);
// Because performance.measure accepts arbitrary timestamps it can produce
// spans that happen before the browser even makes a request for the page.
//
// An example of this is the automatically generated Next.js-before-hydration
// spans created by the Next.js framework.
//
// To prevent this we will pin the start timestamp to the request start time
// This does make duration inaccruate, so if this does happen, we will add
// an attribute to the span
const measureStartTimestamp = timeOrigin + Math.max(startTime, requestTime);
const startTimeStamp = timeOrigin + startTime;
const measureEndTimestamp = startTimeStamp + duration;

const attributes: SpanAttributes = {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
};

if (measureStartTimestamp !== startTimeStamp) {
attributes['sentry.browser.measure_happened_before_request'] = true;
attributes['sentry.browser.measure_start_time'] = measureStartTimestamp;
}

startAndEndSpan(span, measureStartTimestamp, measureEndTimestamp, {
name: entry.name as string,
op: entry.entryType as string,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
},
attributes,
});

return measureStartTimestamp;
Expand DownExpand Up@@ -395,36 +414,29 @@ function _addPerformanceNavigationTiming(
/** Create request and response related spans */
// eslint-disable-next-line @typescript-eslint/no-explicit-any
function _addRequest(span: Span, entry: Record<string, any>, timeOrigin: number): void {
const requestStartTimestamp = timeOrigin + msToSec(entry.requestStart as number);
const responseEndTimestamp = timeOrigin + msToSec(entry.responseEnd as number);
const responseStartTimestamp = timeOrigin + msToSec(entry.responseStart as number);
if (entry.responseEnd) {
// It is possible that we are collecting these metrics when the page hasn't finished loading yet, for example when the HTML slowly streams in.
// In this case, ie. when the document request hasn't finished yet, `entry.responseEnd` will be 0.
// In order not to produce faulty spans, where the end timestamp is before the start timestamp, we will only collect
// these spans when the responseEnd value is available. The backend (Relay) would drop the entire span if it contained faulty spans.
startAndEndSpan(
span,
timeOrigin + msToSec(entry.requestStart as number),
timeOrigin + msToSec(entry.responseEnd as number),
{
op: 'browser',
name: 'request',
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
},
startAndEndSpan(span, requestStartTimestamp, responseEndTimestamp, {
op: 'browser',
name: 'request',
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
},
);
});

startAndEndSpan(
span,
timeOrigin + msToSec(entry.responseStart as number),
timeOrigin + msToSec(entry.responseEnd as number),
{
op: 'browser',
name: 'response',
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
},
startAndEndSpan(span, responseStartTimestamp, responseEndTimestamp, {
op: 'browser',
name: 'response',
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
},
);
});
}
}

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(browser): Make sure measure spans have valid start timestamps#12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 6 commits into

from

Jun 27, 2024
 Merged


fix(browser): Make sure measure spans have valid start timestamps
#12648
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
aba67fa

fix(browser): Make sure measure spans have valid start timestamps


AbhiPrasad Jun 25, 2024
89ea011

Update packages/browser-utils/src/metrics/browserMetrics.ts


AbhiPrasad Jun 26, 2024
1965c2c

test


AbhiPrasad Jun 26, 2024
98b0280

this too


AbhiPrasad Jun 26, 2024
ef249b9

move into template


AbhiPrasad Jun 27, 2024
045c4bb

assert on correct sets of spans


AbhiPrasad Jun 27, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


21 changes: 21 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
// Add measure before SDK initializes
const end = performance.now();
performance.measure('Next.js-before-hydration', {
 duration: 1000,
 end,
});

import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 debug: true,
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 integrations: [
 Sentry.browserTracingIntegration({
 idleTimeout: 9000,
 }),
 ],
 tracesSampleRate: 1,
});

35 changes: 35 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import { expect } from '@playwright/test';
import type { Event } from '@sentry/types';

import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';

// Validation test for https://github.com/getsentry/sentry-javascript/issues/12281
sentryTest('should add browser-related spans to pageload transaction', async ({ getLocalTestPath, page }) => {
 if (shouldSkipTracingTest()) {
 sentryTest.skip();
 }

 const url = await getLocalTestPath({ testDir: __dirname });

 const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
 const browserSpans = eventData.spans?.filter(({ op }) => op === 'browser');

 // Spans `domContentLoadedEvent`, `connect`, `cache` and `DNS` are not
 // always inside `pageload` transaction.
 expect(browserSpans?.length).toBeGreaterThanOrEqual(4);

 const requestSpan = browserSpans!.find(({ description }) => description === 'request');
 expect(requestSpan).toBeDefined();

 const measureSpan = eventData.spans?.find(({ op }) => op === 'measure');
 expect(measureSpan).toBeDefined();

 expect(requestSpan!.start_timestamp).toBeLessThanOrEqual(measureSpan!.start_timestamp);
 expect(measureSpan?.data).toEqual({
 'sentry.browser.measure_happened_before_request': true,
 'sentry.browser.measure_start_time': expect.any(Number),
 'sentry.op': 'measure',
 'sentry.origin': 'auto.resource.browser.metrics',
 });
});

66 changes: 39 additions & 27 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -342,15 +342,34 @@ export function _addMeasureSpans(
 duration: number,
 timeOrigin: number,
): number {
 const measureStartTimestamp = timeOrigin + startTime;
 const measureEndTimestamp = measureStartTimestamp + duration;
 const navEntry = getNavigationEntry();
 const requestTime = msToSec(navEntry ? navEntry.requestStart : 0);
 // Because performance.measure accepts arbitrary timestamps it can produce
 // spans that happen before the browser even makes a request for the page.
 //
 // An example of this is the automatically generated Next.js-before-hydration
 // spans created by the Next.js framework.
 //
 // To prevent this we will pin the start timestamp to the request start time
 // This does make duration inaccruate, so if this does happen, we will add
 // an attribute to the span
 const measureStartTimestamp = timeOrigin + Math.max(startTime, requestTime);
 const startTimeStamp = timeOrigin + startTime;
 const measureEndTimestamp = startTimeStamp + duration;

 const attributes: SpanAttributes = {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 };

 if (measureStartTimestamp !== startTimeStamp) {
 attributes['sentry.browser.measure_happened_before_request'] = true;
 attributes['sentry.browser.measure_start_time'] = measureStartTimestamp;
 }

 startAndEndSpan(span, measureStartTimestamp, measureEndTimestamp, {
 name: entry.name as string,
 op: entry.entryType as string,
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 },
 attributes,
 });

 return measureStartTimestamp;
Expand DownExpand Up@@ -395,36 +414,29 @@ function _addPerformanceNavigationTiming(
/** Create request and response related spans */
// eslint-disable-next-line @typescript-eslint/no-explicit-any
function _addRequest(span: Span, entry: Record<string, any>, timeOrigin: number): void {
 const requestStartTimestamp = timeOrigin + msToSec(entry.requestStart as number);
 const responseEndTimestamp = timeOrigin + msToSec(entry.responseEnd as number);
 const responseStartTimestamp = timeOrigin + msToSec(entry.responseStart as number);
 if (entry.responseEnd) {
 // It is possible that we are collecting these metrics when the page hasn't finished loading yet, for example when the HTML slowly streams in.
 // In this case, ie. when the document request hasn't finished yet, `entry.responseEnd` will be 0.
 // In order not to produce faulty spans, where the end timestamp is before the start timestamp, we will only collect
 // these spans when the responseEnd value is available. The backend (Relay) would drop the entire span if it contained faulty spans.
 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.requestStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, requestStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});

 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.responseStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, responseStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});
 }
}

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(browser): Make sure measure spans have valid start timestamps#12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 6 commits into

from

Jun 27, 2024
 Merged


fix(browser): Make sure measure spans have valid start timestamps
#12648
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
aba67fa

fix(browser): Make sure measure spans have valid start timestamps


AbhiPrasad Jun 25, 2024
89ea011

Update packages/browser-utils/src/metrics/browserMetrics.ts


AbhiPrasad Jun 26, 2024
1965c2c

test


AbhiPrasad Jun 26, 2024
98b0280

this too


AbhiPrasad Jun 26, 2024
ef249b9

move into template


AbhiPrasad Jun 27, 2024
045c4bb

assert on correct sets of spans


AbhiPrasad Jun 27, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


21 changes: 21 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
// Add measure before SDK initializes
const end = performance.now();
performance.measure('Next.js-before-hydration', {
 duration: 1000,
 end,
});

import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 debug: true,
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 integrations: [
 Sentry.browserTracingIntegration({
 idleTimeout: 9000,
 }),
 ],
 tracesSampleRate: 1,
});

35 changes: 35 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import { expect } from '@playwright/test';
import type { Event } from '@sentry/types';

import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';

// Validation test for https://github.com/getsentry/sentry-javascript/issues/12281
sentryTest('should add browser-related spans to pageload transaction', async ({ getLocalTestPath, page }) => {
 if (shouldSkipTracingTest()) {
 sentryTest.skip();
 }

 const url = await getLocalTestPath({ testDir: __dirname });

 const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
 const browserSpans = eventData.spans?.filter(({ op }) => op === 'browser');

 // Spans `domContentLoadedEvent`, `connect`, `cache` and `DNS` are not
 // always inside `pageload` transaction.
 expect(browserSpans?.length).toBeGreaterThanOrEqual(4);

 const requestSpan = browserSpans!.find(({ description }) => description === 'request');
 expect(requestSpan).toBeDefined();

 const measureSpan = eventData.spans?.find(({ op }) => op === 'measure');
 expect(measureSpan).toBeDefined();

 expect(requestSpan!.start_timestamp).toBeLessThanOrEqual(measureSpan!.start_timestamp);
 expect(measureSpan?.data).toEqual({
 'sentry.browser.measure_happened_before_request': true,
 'sentry.browser.measure_start_time': expect.any(Number),
 'sentry.op': 'measure',
 'sentry.origin': 'auto.resource.browser.metrics',
 });
});

66 changes: 39 additions & 27 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -342,15 +342,34 @@ export function _addMeasureSpans(
 duration: number,
 timeOrigin: number,
): number {
 const measureStartTimestamp = timeOrigin + startTime;
 const measureEndTimestamp = measureStartTimestamp + duration;
 const navEntry = getNavigationEntry();
 const requestTime = msToSec(navEntry ? navEntry.requestStart : 0);
 // Because performance.measure accepts arbitrary timestamps it can produce
 // spans that happen before the browser even makes a request for the page.
 //
 // An example of this is the automatically generated Next.js-before-hydration
 // spans created by the Next.js framework.
 //
 // To prevent this we will pin the start timestamp to the request start time
 // This does make duration inaccruate, so if this does happen, we will add
 // an attribute to the span
 const measureStartTimestamp = timeOrigin + Math.max(startTime, requestTime);
 const startTimeStamp = timeOrigin + startTime;
 const measureEndTimestamp = startTimeStamp + duration;

 const attributes: SpanAttributes = {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 };

 if (measureStartTimestamp !== startTimeStamp) {
 attributes['sentry.browser.measure_happened_before_request'] = true;
 attributes['sentry.browser.measure_start_time'] = measureStartTimestamp;
 }

 startAndEndSpan(span, measureStartTimestamp, measureEndTimestamp, {
 name: entry.name as string,
 op: entry.entryType as string,
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 },
 attributes,
 });

 return measureStartTimestamp;
Expand DownExpand Up@@ -395,36 +414,29 @@ function _addPerformanceNavigationTiming(
/** Create request and response related spans */
// eslint-disable-next-line @typescript-eslint/no-explicit-any
function _addRequest(span: Span, entry: Record<string, any>, timeOrigin: number): void {
 const requestStartTimestamp = timeOrigin + msToSec(entry.requestStart as number);
 const responseEndTimestamp = timeOrigin + msToSec(entry.responseEnd as number);
 const responseStartTimestamp = timeOrigin + msToSec(entry.responseStart as number);
 if (entry.responseEnd) {
 // It is possible that we are collecting these metrics when the page hasn't finished loading yet, for example when the HTML slowly streams in.
 // In this case, ie. when the document request hasn't finished yet, `entry.responseEnd` will be 0.
 // In order not to produce faulty spans, where the end timestamp is before the start timestamp, we will only collect
 // these spans when the responseEnd value is available. The backend (Relay) would drop the entire span if it contained faulty spans.
 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.requestStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, requestStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});

 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.responseStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, responseStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});
 }
}

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(browser): Make sure measure spans have valid start timestamps#12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 6 commits into

from

Jun 27, 2024
 Merged


fix(browser): Make sure measure spans have valid start timestamps
#12648
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
aba67fa

fix(browser): Make sure measure spans have valid start timestamps


AbhiPrasad Jun 25, 2024
89ea011

Update packages/browser-utils/src/metrics/browserMetrics.ts


AbhiPrasad Jun 26, 2024
1965c2c

test


AbhiPrasad Jun 26, 2024
98b0280

this too


AbhiPrasad Jun 26, 2024
ef249b9

move into template


AbhiPrasad Jun 27, 2024
045c4bb

assert on correct sets of spans


AbhiPrasad Jun 27, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


21 changes: 21 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
// Add measure before SDK initializes
const end = performance.now();
performance.measure('Next.js-before-hydration', {
 duration: 1000,
 end,
});

import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 debug: true,
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 integrations: [
 Sentry.browserTracingIntegration({
 idleTimeout: 9000,
 }),
 ],
 tracesSampleRate: 1,
});

35 changes: 35 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import { expect } from '@playwright/test';
import type { Event } from '@sentry/types';

import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';

// Validation test for https://github.com/getsentry/sentry-javascript/issues/12281
sentryTest('should add browser-related spans to pageload transaction', async ({ getLocalTestPath, page }) => {
 if (shouldSkipTracingTest()) {
 sentryTest.skip();
 }

 const url = await getLocalTestPath({ testDir: __dirname });

 const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
 const browserSpans = eventData.spans?.filter(({ op }) => op === 'browser');

 // Spans `domContentLoadedEvent`, `connect`, `cache` and `DNS` are not
 // always inside `pageload` transaction.
 expect(browserSpans?.length).toBeGreaterThanOrEqual(4);

 const requestSpan = browserSpans!.find(({ description }) => description === 'request');
 expect(requestSpan).toBeDefined();

 const measureSpan = eventData.spans?.find(({ op }) => op === 'measure');
 expect(measureSpan).toBeDefined();

 expect(requestSpan!.start_timestamp).toBeLessThanOrEqual(measureSpan!.start_timestamp);
 expect(measureSpan?.data).toEqual({
 'sentry.browser.measure_happened_before_request': true,
 'sentry.browser.measure_start_time': expect.any(Number),
 'sentry.op': 'measure',
 'sentry.origin': 'auto.resource.browser.metrics',
 });
});

66 changes: 39 additions & 27 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -342,15 +342,34 @@ export function _addMeasureSpans(
 duration: number,
 timeOrigin: number,
): number {
 const measureStartTimestamp = timeOrigin + startTime;
 const measureEndTimestamp = measureStartTimestamp + duration;
 const navEntry = getNavigationEntry();
 const requestTime = msToSec(navEntry ? navEntry.requestStart : 0);
 // Because performance.measure accepts arbitrary timestamps it can produce
 // spans that happen before the browser even makes a request for the page.
 //
 // An example of this is the automatically generated Next.js-before-hydration
 // spans created by the Next.js framework.
 //
 // To prevent this we will pin the start timestamp to the request start time
 // This does make duration inaccruate, so if this does happen, we will add
 // an attribute to the span
 const measureStartTimestamp = timeOrigin + Math.max(startTime, requestTime);
 const startTimeStamp = timeOrigin + startTime;
 const measureEndTimestamp = startTimeStamp + duration;

 const attributes: SpanAttributes = {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 };

 if (measureStartTimestamp !== startTimeStamp) {
 attributes['sentry.browser.measure_happened_before_request'] = true;
 attributes['sentry.browser.measure_start_time'] = measureStartTimestamp;
 }

 startAndEndSpan(span, measureStartTimestamp, measureEndTimestamp, {
 name: entry.name as string,
 op: entry.entryType as string,
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 },
 attributes,
 });

 return measureStartTimestamp;
Expand DownExpand Up@@ -395,36 +414,29 @@ function _addPerformanceNavigationTiming(
/** Create request and response related spans */
// eslint-disable-next-line @typescript-eslint/no-explicit-any
function _addRequest(span: Span, entry: Record<string, any>, timeOrigin: number): void {
 const requestStartTimestamp = timeOrigin + msToSec(entry.requestStart as number);
 const responseEndTimestamp = timeOrigin + msToSec(entry.responseEnd as number);
 const responseStartTimestamp = timeOrigin + msToSec(entry.responseStart as number);
 if (entry.responseEnd) {
 // It is possible that we are collecting these metrics when the page hasn't finished loading yet, for example when the HTML slowly streams in.
 // In this case, ie. when the document request hasn't finished yet, `entry.responseEnd` will be 0.
 // In order not to produce faulty spans, where the end timestamp is before the start timestamp, we will only collect
 // these spans when the responseEnd value is available. The backend (Relay) would drop the entire span if it contained faulty spans.
 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.requestStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, requestStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});

 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.responseStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, responseStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});
 }
}

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(browser): Make sure measure spans have valid start timestamps#12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 6 commits into

from

Jun 27, 2024
 Merged


fix(browser): Make sure measure spans have valid start timestamps
#12648
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
aba67fa

fix(browser): Make sure measure spans have valid start timestamps


AbhiPrasad Jun 25, 2024
89ea011

Update packages/browser-utils/src/metrics/browserMetrics.ts


AbhiPrasad Jun 26, 2024
1965c2c

test


AbhiPrasad Jun 26, 2024
98b0280

this too


AbhiPrasad Jun 26, 2024
ef249b9

move into template


AbhiPrasad Jun 27, 2024
045c4bb

assert on correct sets of spans


AbhiPrasad Jun 27, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


21 changes: 21 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
// Add measure before SDK initializes
const end = performance.now();
performance.measure('Next.js-before-hydration', {
 duration: 1000,
 end,
});

import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 debug: true,
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 integrations: [
 Sentry.browserTracingIntegration({
 idleTimeout: 9000,
 }),
 ],
 tracesSampleRate: 1,
});

35 changes: 35 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import { expect } from '@playwright/test';
import type { Event } from '@sentry/types';

import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';

// Validation test for https://github.com/getsentry/sentry-javascript/issues/12281
sentryTest('should add browser-related spans to pageload transaction', async ({ getLocalTestPath, page }) => {
 if (shouldSkipTracingTest()) {
 sentryTest.skip();
 }

 const url = await getLocalTestPath({ testDir: __dirname });

 const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
 const browserSpans = eventData.spans?.filter(({ op }) => op === 'browser');

 // Spans `domContentLoadedEvent`, `connect`, `cache` and `DNS` are not
 // always inside `pageload` transaction.
 expect(browserSpans?.length).toBeGreaterThanOrEqual(4);

 const requestSpan = browserSpans!.find(({ description }) => description === 'request');
 expect(requestSpan).toBeDefined();

 const measureSpan = eventData.spans?.find(({ op }) => op === 'measure');
 expect(measureSpan).toBeDefined();

 expect(requestSpan!.start_timestamp).toBeLessThanOrEqual(measureSpan!.start_timestamp);
 expect(measureSpan?.data).toEqual({
 'sentry.browser.measure_happened_before_request': true,
 'sentry.browser.measure_start_time': expect.any(Number),
 'sentry.op': 'measure',
 'sentry.origin': 'auto.resource.browser.metrics',
 });
});

66 changes: 39 additions & 27 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -342,15 +342,34 @@ export function _addMeasureSpans(
 duration: number,
 timeOrigin: number,
): number {
 const measureStartTimestamp = timeOrigin + startTime;
 const measureEndTimestamp = measureStartTimestamp + duration;
 const navEntry = getNavigationEntry();
 const requestTime = msToSec(navEntry ? navEntry.requestStart : 0);
 // Because performance.measure accepts arbitrary timestamps it can produce
 // spans that happen before the browser even makes a request for the page.
 //
 // An example of this is the automatically generated Next.js-before-hydration
 // spans created by the Next.js framework.
 //
 // To prevent this we will pin the start timestamp to the request start time
 // This does make duration inaccruate, so if this does happen, we will add
 // an attribute to the span
 const measureStartTimestamp = timeOrigin + Math.max(startTime, requestTime);
 const startTimeStamp = timeOrigin + startTime;
 const measureEndTimestamp = startTimeStamp + duration;

 const attributes: SpanAttributes = {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 };

 if (measureStartTimestamp !== startTimeStamp) {
 attributes['sentry.browser.measure_happened_before_request'] = true;
 attributes['sentry.browser.measure_start_time'] = measureStartTimestamp;
 }

 startAndEndSpan(span, measureStartTimestamp, measureEndTimestamp, {
 name: entry.name as string,
 op: entry.entryType as string,
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 },
 attributes,
 });

 return measureStartTimestamp;
Expand DownExpand Up@@ -395,36 +414,29 @@ function _addPerformanceNavigationTiming(
/** Create request and response related spans */
// eslint-disable-next-line @typescript-eslint/no-explicit-any
function _addRequest(span: Span, entry: Record<string, any>, timeOrigin: number): void {
 const requestStartTimestamp = timeOrigin + msToSec(entry.requestStart as number);
 const responseEndTimestamp = timeOrigin + msToSec(entry.responseEnd as number);
 const responseStartTimestamp = timeOrigin + msToSec(entry.responseStart as number);
 if (entry.responseEnd) {
 // It is possible that we are collecting these metrics when the page hasn't finished loading yet, for example when the HTML slowly streams in.
 // In this case, ie. when the document request hasn't finished yet, `entry.responseEnd` will be 0.
 // In order not to produce faulty spans, where the end timestamp is before the start timestamp, we will only collect
 // these spans when the responseEnd value is available. The backend (Relay) would drop the entire span if it contained faulty spans.
 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.requestStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, requestStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});

 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.responseStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, responseStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});
 }
}

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(browser): Make sure measure spans have valid start timestamps#12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 6 commits into

from

Jun 27, 2024
 Merged


fix(browser): Make sure measure spans have valid start timestamps
#12648
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
aba67fa

fix(browser): Make sure measure spans have valid start timestamps


AbhiPrasad Jun 25, 2024
89ea011

Update packages/browser-utils/src/metrics/browserMetrics.ts


AbhiPrasad Jun 26, 2024
1965c2c

test


AbhiPrasad Jun 26, 2024
98b0280

this too


AbhiPrasad Jun 26, 2024
ef249b9

move into template


AbhiPrasad Jun 27, 2024
045c4bb

assert on correct sets of spans


AbhiPrasad Jun 27, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


21 changes: 21 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
// Add measure before SDK initializes
const end = performance.now();
performance.measure('Next.js-before-hydration', {
 duration: 1000,
 end,
});

import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 debug: true,
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 integrations: [
 Sentry.browserTracingIntegration({
 idleTimeout: 9000,
 }),
 ],
 tracesSampleRate: 1,
});

35 changes: 35 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import { expect } from '@playwright/test';
import type { Event } from '@sentry/types';

import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';

// Validation test for https://github.com/getsentry/sentry-javascript/issues/12281
sentryTest('should add browser-related spans to pageload transaction', async ({ getLocalTestPath, page }) => {
 if (shouldSkipTracingTest()) {
 sentryTest.skip();
 }

 const url = await getLocalTestPath({ testDir: __dirname });

 const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
 const browserSpans = eventData.spans?.filter(({ op }) => op === 'browser');

 // Spans `domContentLoadedEvent`, `connect`, `cache` and `DNS` are not
 // always inside `pageload` transaction.
 expect(browserSpans?.length).toBeGreaterThanOrEqual(4);

 const requestSpan = browserSpans!.find(({ description }) => description === 'request');
 expect(requestSpan).toBeDefined();

 const measureSpan = eventData.spans?.find(({ op }) => op === 'measure');
 expect(measureSpan).toBeDefined();

 expect(requestSpan!.start_timestamp).toBeLessThanOrEqual(measureSpan!.start_timestamp);
 expect(measureSpan?.data).toEqual({
 'sentry.browser.measure_happened_before_request': true,
 'sentry.browser.measure_start_time': expect.any(Number),
 'sentry.op': 'measure',
 'sentry.origin': 'auto.resource.browser.metrics',
 });
});

66 changes: 39 additions & 27 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -342,15 +342,34 @@ export function _addMeasureSpans(
 duration: number,
 timeOrigin: number,
): number {
 const measureStartTimestamp = timeOrigin + startTime;
 const measureEndTimestamp = measureStartTimestamp + duration;
 const navEntry = getNavigationEntry();
 const requestTime = msToSec(navEntry ? navEntry.requestStart : 0);
 // Because performance.measure accepts arbitrary timestamps it can produce
 // spans that happen before the browser even makes a request for the page.
 //
 // An example of this is the automatically generated Next.js-before-hydration
 // spans created by the Next.js framework.
 //
 // To prevent this we will pin the start timestamp to the request start time
 // This does make duration inaccruate, so if this does happen, we will add
 // an attribute to the span
 const measureStartTimestamp = timeOrigin + Math.max(startTime, requestTime);
 const startTimeStamp = timeOrigin + startTime;
 const measureEndTimestamp = startTimeStamp + duration;

 const attributes: SpanAttributes = {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 };

 if (measureStartTimestamp !== startTimeStamp) {
 attributes['sentry.browser.measure_happened_before_request'] = true;
 attributes['sentry.browser.measure_start_time'] = measureStartTimestamp;
 }

 startAndEndSpan(span, measureStartTimestamp, measureEndTimestamp, {
 name: entry.name as string,
 op: entry.entryType as string,
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 },
 attributes,
 });

 return measureStartTimestamp;
Expand DownExpand Up@@ -395,36 +414,29 @@ function _addPerformanceNavigationTiming(
/** Create request and response related spans */
// eslint-disable-next-line @typescript-eslint/no-explicit-any
function _addRequest(span: Span, entry: Record<string, any>, timeOrigin: number): void {
 const requestStartTimestamp = timeOrigin + msToSec(entry.requestStart as number);
 const responseEndTimestamp = timeOrigin + msToSec(entry.responseEnd as number);
 const responseStartTimestamp = timeOrigin + msToSec(entry.responseStart as number);
 if (entry.responseEnd) {
 // It is possible that we are collecting these metrics when the page hasn't finished loading yet, for example when the HTML slowly streams in.
 // In this case, ie. when the document request hasn't finished yet, `entry.responseEnd` will be 0.
 // In order not to produce faulty spans, where the end timestamp is before the start timestamp, we will only collect
 // these spans when the responseEnd value is available. The backend (Relay) would drop the entire span if it contained faulty spans.
 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.requestStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, requestStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});

 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.responseStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, responseStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});
 }
}

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(browser): Make sure measure spans have valid start timestamps#12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 6 commits into

from

Jun 27, 2024
 Merged


fix(browser): Make sure measure spans have valid start timestamps
#12648
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
aba67fa

fix(browser): Make sure measure spans have valid start timestamps


AbhiPrasad Jun 25, 2024
89ea011

Update packages/browser-utils/src/metrics/browserMetrics.ts


AbhiPrasad Jun 26, 2024
1965c2c

test


AbhiPrasad Jun 26, 2024
98b0280

this too


AbhiPrasad Jun 26, 2024
ef249b9

move into template


AbhiPrasad Jun 27, 2024
045c4bb

assert on correct sets of spans


AbhiPrasad Jun 27, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


21 changes: 21 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
// Add measure before SDK initializes
const end = performance.now();
performance.measure('Next.js-before-hydration', {
 duration: 1000,
 end,
});

import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 debug: true,
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 integrations: [
 Sentry.browserTracingIntegration({
 idleTimeout: 9000,
 }),
 ],
 tracesSampleRate: 1,
});

35 changes: 35 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import { expect } from '@playwright/test';
import type { Event } from '@sentry/types';

import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';

// Validation test for https://github.com/getsentry/sentry-javascript/issues/12281
sentryTest('should add browser-related spans to pageload transaction', async ({ getLocalTestPath, page }) => {
 if (shouldSkipTracingTest()) {
 sentryTest.skip();
 }

 const url = await getLocalTestPath({ testDir: __dirname });

 const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
 const browserSpans = eventData.spans?.filter(({ op }) => op === 'browser');

 // Spans `domContentLoadedEvent`, `connect`, `cache` and `DNS` are not
 // always inside `pageload` transaction.
 expect(browserSpans?.length).toBeGreaterThanOrEqual(4);

 const requestSpan = browserSpans!.find(({ description }) => description === 'request');
 expect(requestSpan).toBeDefined();

 const measureSpan = eventData.spans?.find(({ op }) => op === 'measure');
 expect(measureSpan).toBeDefined();

 expect(requestSpan!.start_timestamp).toBeLessThanOrEqual(measureSpan!.start_timestamp);
 expect(measureSpan?.data).toEqual({
 'sentry.browser.measure_happened_before_request': true,
 'sentry.browser.measure_start_time': expect.any(Number),
 'sentry.op': 'measure',
 'sentry.origin': 'auto.resource.browser.metrics',
 });
});

66 changes: 39 additions & 27 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -342,15 +342,34 @@ export function _addMeasureSpans(
 duration: number,
 timeOrigin: number,
): number {
 const measureStartTimestamp = timeOrigin + startTime;
 const measureEndTimestamp = measureStartTimestamp + duration;
 const navEntry = getNavigationEntry();
 const requestTime = msToSec(navEntry ? navEntry.requestStart : 0);
 // Because performance.measure accepts arbitrary timestamps it can produce
 // spans that happen before the browser even makes a request for the page.
 //
 // An example of this is the automatically generated Next.js-before-hydration
 // spans created by the Next.js framework.
 //
 // To prevent this we will pin the start timestamp to the request start time
 // This does make duration inaccruate, so if this does happen, we will add
 // an attribute to the span
 const measureStartTimestamp = timeOrigin + Math.max(startTime, requestTime);
 const startTimeStamp = timeOrigin + startTime;
 const measureEndTimestamp = startTimeStamp + duration;

 const attributes: SpanAttributes = {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 };

 if (measureStartTimestamp !== startTimeStamp) {
 attributes['sentry.browser.measure_happened_before_request'] = true;
 attributes['sentry.browser.measure_start_time'] = measureStartTimestamp;
 }

 startAndEndSpan(span, measureStartTimestamp, measureEndTimestamp, {
 name: entry.name as string,
 op: entry.entryType as string,
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 },
 attributes,
 });

 return measureStartTimestamp;
Expand DownExpand Up@@ -395,36 +414,29 @@ function _addPerformanceNavigationTiming(
/** Create request and response related spans */
// eslint-disable-next-line @typescript-eslint/no-explicit-any
function _addRequest(span: Span, entry: Record<string, any>, timeOrigin: number): void {
 const requestStartTimestamp = timeOrigin + msToSec(entry.requestStart as number);
 const responseEndTimestamp = timeOrigin + msToSec(entry.responseEnd as number);
 const responseStartTimestamp = timeOrigin + msToSec(entry.responseStart as number);
 if (entry.responseEnd) {
 // It is possible that we are collecting these metrics when the page hasn't finished loading yet, for example when the HTML slowly streams in.
 // In this case, ie. when the document request hasn't finished yet, `entry.responseEnd` will be 0.
 // In order not to produce faulty spans, where the end timestamp is before the start timestamp, we will only collect
 // these spans when the responseEnd value is available. The backend (Relay) would drop the entire span if it contained faulty spans.
 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.requestStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, requestStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});

 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.responseStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, responseStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});
 }
}

Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(browser): Make sure measure spans have valid start timestamps#12648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

AbhiPrasad
merged 6 commits into

from

Jun 27, 2024
 Merged


fix(browser): Make sure measure spans have valid start timestamps
#12648
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
aba67fa

fix(browser): Make sure measure spans have valid start timestamps


AbhiPrasad Jun 25, 2024
89ea011

Update packages/browser-utils/src/metrics/browserMetrics.ts


AbhiPrasad Jun 26, 2024
1965c2c

test


AbhiPrasad Jun 26, 2024
98b0280

this too


AbhiPrasad Jun 26, 2024
ef249b9

move into template


AbhiPrasad Jun 27, 2024
045c4bb

assert on correct sets of spans


AbhiPrasad Jun 27, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


21 changes: 21 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/init.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
// Add measure before SDK initializes
const end = performance.now();
performance.measure('Next.js-before-hydration', {
 duration: 1000,
 end,
});

import * as Sentry from '@sentry/browser';

window.Sentry = Sentry;

Sentry.init({
 debug: true,
 dsn: 'https://public@dsn.ingest.sentry.io/1337',
 integrations: [
 Sentry.browserTracingIntegration({
 idleTimeout: 9000,
 }),
 ],
 tracesSampleRate: 1,
});

35 changes: 35 additions & 0 deletions
dev-packages/browser-integration-tests/suites/tracing/metrics/pageload-measure-spans/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
import { expect } from '@playwright/test';
import type { Event } from '@sentry/types';

import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, shouldSkipTracingTest } from '../../../../utils/helpers';

// Validation test for https://github.com/getsentry/sentry-javascript/issues/12281
sentryTest('should add browser-related spans to pageload transaction', async ({ getLocalTestPath, page }) => {
 if (shouldSkipTracingTest()) {
 sentryTest.skip();
 }

 const url = await getLocalTestPath({ testDir: __dirname });

 const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url);
 const browserSpans = eventData.spans?.filter(({ op }) => op === 'browser');

 // Spans `domContentLoadedEvent`, `connect`, `cache` and `DNS` are not
 // always inside `pageload` transaction.
 expect(browserSpans?.length).toBeGreaterThanOrEqual(4);

 const requestSpan = browserSpans!.find(({ description }) => description === 'request');
 expect(requestSpan).toBeDefined();

 const measureSpan = eventData.spans?.find(({ op }) => op === 'measure');
 expect(measureSpan).toBeDefined();

 expect(requestSpan!.start_timestamp).toBeLessThanOrEqual(measureSpan!.start_timestamp);
 expect(measureSpan?.data).toEqual({
 'sentry.browser.measure_happened_before_request': true,
 'sentry.browser.measure_start_time': expect.any(Number),
 'sentry.op': 'measure',
 'sentry.origin': 'auto.resource.browser.metrics',
 });
});

66 changes: 39 additions & 27 deletions
packages/browser-utils/src/metrics/browserMetrics.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -342,15 +342,34 @@ export function _addMeasureSpans(
 duration: number,
 timeOrigin: number,
): number {
 const measureStartTimestamp = timeOrigin + startTime;
 const measureEndTimestamp = measureStartTimestamp + duration;
 const navEntry = getNavigationEntry();
 const requestTime = msToSec(navEntry ? navEntry.requestStart : 0);
 // Because performance.measure accepts arbitrary timestamps it can produce
 // spans that happen before the browser even makes a request for the page.
 //
 // An example of this is the automatically generated Next.js-before-hydration
 // spans created by the Next.js framework.
 //
 // To prevent this we will pin the start timestamp to the request start time
 // This does make duration inaccruate, so if this does happen, we will add
 // an attribute to the span
 const measureStartTimestamp = timeOrigin + Math.max(startTime, requestTime);
 const startTimeStamp = timeOrigin + startTime;
 const measureEndTimestamp = startTimeStamp + duration;

 const attributes: SpanAttributes = {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 };

 if (measureStartTimestamp !== startTimeStamp) {
 attributes['sentry.browser.measure_happened_before_request'] = true;
 attributes['sentry.browser.measure_start_time'] = measureStartTimestamp;
 }

 startAndEndSpan(span, measureStartTimestamp, measureEndTimestamp, {
 name: entry.name as string,
 op: entry.entryType as string,
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.resource.browser.metrics',
 },
 attributes,
 });

 return measureStartTimestamp;
Expand DownExpand Up@@ -395,36 +414,29 @@ function _addPerformanceNavigationTiming(
/** Create request and response related spans */
// eslint-disable-next-line @typescript-eslint/no-explicit-any
function _addRequest(span: Span, entry: Record<string, any>, timeOrigin: number): void {
 const requestStartTimestamp = timeOrigin + msToSec(entry.requestStart as number);
 const responseEndTimestamp = timeOrigin + msToSec(entry.responseEnd as number);
 const responseStartTimestamp = timeOrigin + msToSec(entry.responseStart as number);
 if (entry.responseEnd) {
 // It is possible that we are collecting these metrics when the page hasn't finished loading yet, for example when the HTML slowly streams in.
 // In this case, ie. when the document request hasn't finished yet, `entry.responseEnd` will be 0.
 // In order not to produce faulty spans, where the end timestamp is before the start timestamp, we will only collect
 // these spans when the responseEnd value is available. The backend (Relay) would drop the entire span if it contained faulty spans.
 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.requestStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, requestStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'request',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});

 startAndEndSpan(
 span,
 timeOrigin + msToSec(entry.responseStart as number),
 timeOrigin + msToSec(entry.responseEnd as number),
 {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 startAndEndSpan(span, responseStartTimestamp, responseEndTimestamp, {
 op: 'browser',
 name: 'response',
 attributes: {
 [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.ui.browser.metrics',
 },
 );
});
 }
}

Expand Down