fix(remix): add esm export for node

[topaxi]

We are running remix in ESM mode, but the exports in package.json is pointing to the CommonJS module, which results in the SDK running in CommonJS mode instead of ESM.

This lead to the instrumentations not running/detecting properly.

[onurtemizkan]

Thanks for the PR @topaxi, I have tested this locally, which caused the server/client trace-propagation to break on E2E tests. I'll try to check what caused that.

[onurtemizkan]

@topaxi, could you please check if the update here solves your issue?

[topaxi]

@onurtemizkan no, this will still run the package in CommonJS mode.

[topaxi]

What does work for me though, is to specify the default import. I have updated the PR :)

Sadly I'm not able to install the npm dependencies locally from this repository as yarn does not succeed and playwright install tries to call apt which I do not have on my machine.

[onurtemizkan]

Thanks for the update @topaxi. Yes, I can see that specifying default under importdoes not break the current tests. But to validate that it works on tests, could you tell which instrumentations were not detected properly?

[topaxi]

This was specifically for express. The logs showed that express was not instrumented, and debug: true logged that sentry was running in CommonJS mode.

Switching sentry/remix to ESM fixed it (I assume previously, sentry instrumented only the CJS versions of the package(s), which aren't actually run in the application).

[onurtemizkan]

It doesn't seem to break anything (#12677). So it looks good to me if it resolves your issue. We'll need to revisit this when we add the worker support (For reference: #12643). But I think we can merge this in the meantime. @mydea does this make sense?

[AbhiPrasad]

shouldn't this get split into the following?

Suggested change

	"node": "./build/cjs/index.server.js"
	"node": {
	"import": "./build/esm/index.server.js",
	"require": "./build/cjs/index.server.js"
	},

[topaxi]

That was my initial change, see the first comment as to why that did not work.

[AbhiPrasad]

Thanks for the fix @topaxi!

[lforst]

This change broke our E2E tests so we'll likely revert.

[topaxi]

We are running remix in ESM mode, but the exports in package.json is pointing to the CommonJS module, which results in the SDK running in CommonJS mode instead of ESM.

This lead to the instrumentations not running/detecting properly.

[onurtemizkan]

Thanks for the PR @topaxi, I have tested this locally, which caused the server/client trace-propagation to break on E2E tests. I'll try to check what caused that.

[onurtemizkan]

@topaxi, could you please check if the update here solves your issue?

[topaxi]

@onurtemizkan no, this will still run the package in CommonJS mode.

[topaxi]

What does work for me though, is to specify the default import. I have updated the PR :)

Sadly I'm not able to install the npm dependencies locally from this repository as yarn does not succeed and playwright install tries to call apt which I do not have on my machine.

[onurtemizkan]

Thanks for the update @topaxi. Yes, I can see that specifying default under importdoes not break the current tests. But to validate that it works on tests, could you tell which instrumentations were not detected properly?

[topaxi]

This was specifically for express. The logs showed that express was not instrumented, and debug: true logged that sentry was running in CommonJS mode.

Switching sentry/remix to ESM fixed it (I assume previously, sentry instrumented only the CJS versions of the package(s), which aren't actually run in the application).

[onurtemizkan]

It doesn't seem to break anything (#12677). So it looks good to me if it resolves your issue. We'll need to revisit this when we add the worker support (For reference: #12643). But I think we can merge this in the meantime. @mydea does this make sense?

[AbhiPrasad]

shouldn't this get split into the following?

Suggested change

	"node": "./build/cjs/index.server.js"
	"node": {
	"import": "./build/esm/index.server.js",
	"require": "./build/cjs/index.server.js"
	},

[topaxi]

That was my initial change, see the first comment as to why that did not work.

[AbhiPrasad]

Thanks for the fix @topaxi!

[lforst]

This change broke our E2E tests so we'll likely revert.

[topaxi]

We are running remix in ESM mode, but the exports in package.json is pointing to the CommonJS module, which results in the SDK running in CommonJS mode instead of ESM.

This lead to the instrumentations not running/detecting properly.

[onurtemizkan]

Thanks for the PR @topaxi, I have tested this locally, which caused the server/client trace-propagation to break on E2E tests. I'll try to check what caused that.

[onurtemizkan]

@topaxi, could you please check if the update here solves your issue?

[topaxi]

@onurtemizkan no, this will still run the package in CommonJS mode.

[topaxi]

What does work for me though, is to specify the default import. I have updated the PR :)

Sadly I'm not able to install the npm dependencies locally from this repository as yarn does not succeed and playwright install tries to call apt which I do not have on my machine.

[onurtemizkan]

Thanks for the update @topaxi. Yes, I can see that specifying default under importdoes not break the current tests. But to validate that it works on tests, could you tell which instrumentations were not detected properly?

[topaxi]

This was specifically for express. The logs showed that express was not instrumented, and debug: true logged that sentry was running in CommonJS mode.

Switching sentry/remix to ESM fixed it (I assume previously, sentry instrumented only the CJS versions of the package(s), which aren't actually run in the application).

[onurtemizkan]

It doesn't seem to break anything (#12677). So it looks good to me if it resolves your issue. We'll need to revisit this when we add the worker support (For reference: #12643). But I think we can merge this in the meantime. @mydea does this make sense?

[AbhiPrasad]

shouldn't this get split into the following?

Suggested change

	"node": "./build/cjs/index.server.js"
	"node": {
	"import": "./build/esm/index.server.js",
	"require": "./build/cjs/index.server.js"
	},

[topaxi]

That was my initial change, see the first comment as to why that did not work.

[AbhiPrasad]

Thanks for the fix @topaxi!

[lforst]

This change broke our E2E tests so we'll likely revert.

[topaxi]

We are running remix in ESM mode, but the exports in package.json is pointing to the CommonJS module, which results in the SDK running in CommonJS mode instead of ESM.

This lead to the instrumentations not running/detecting properly.

[onurtemizkan]

Thanks for the PR @topaxi, I have tested this locally, which caused the server/client trace-propagation to break on E2E tests. I'll try to check what caused that.

[onurtemizkan]

@topaxi, could you please check if the update here solves your issue?

[topaxi]

@onurtemizkan no, this will still run the package in CommonJS mode.

[topaxi]

What does work for me though, is to specify the default import. I have updated the PR :)

Sadly I'm not able to install the npm dependencies locally from this repository as yarn does not succeed and playwright install tries to call apt which I do not have on my machine.

[onurtemizkan]

Thanks for the update @topaxi. Yes, I can see that specifying default under importdoes not break the current tests. But to validate that it works on tests, could you tell which instrumentations were not detected properly?

[topaxi]

This was specifically for express. The logs showed that express was not instrumented, and debug: true logged that sentry was running in CommonJS mode.

Switching sentry/remix to ESM fixed it (I assume previously, sentry instrumented only the CJS versions of the package(s), which aren't actually run in the application).

[onurtemizkan]

It doesn't seem to break anything (#12677). So it looks good to me if it resolves your issue. We'll need to revisit this when we add the worker support (For reference: #12643). But I think we can merge this in the meantime. @mydea does this make sense?

[AbhiPrasad]

shouldn't this get split into the following?

Suggested change

	"node": "./build/cjs/index.server.js"
	"node": {
	"import": "./build/esm/index.server.js",
	"require": "./build/cjs/index.server.js"
	},

[topaxi]

That was my initial change, see the first comment as to why that did not work.

[AbhiPrasad]

Thanks for the fix @topaxi!

[lforst]

This change broke our E2E tests so we'll likely revert.

[topaxi]

We are running remix in ESM mode, but the exports in package.json is pointing to the CommonJS module, which results in the SDK running in CommonJS mode instead of ESM.

This lead to the instrumentations not running/detecting properly.

[onurtemizkan]

Thanks for the PR @topaxi, I have tested this locally, which caused the server/client trace-propagation to break on E2E tests. I'll try to check what caused that.

[onurtemizkan]

@topaxi, could you please check if the update here solves your issue?

[topaxi]

@onurtemizkan no, this will still run the package in CommonJS mode.

[topaxi]

What does work for me though, is to specify the default import. I have updated the PR :)

Sadly I'm not able to install the npm dependencies locally from this repository as yarn does not succeed and playwright install tries to call apt which I do not have on my machine.

[onurtemizkan]

Thanks for the update @topaxi. Yes, I can see that specifying default under importdoes not break the current tests. But to validate that it works on tests, could you tell which instrumentations were not detected properly?

[topaxi]

This was specifically for express. The logs showed that express was not instrumented, and debug: true logged that sentry was running in CommonJS mode.

Switching sentry/remix to ESM fixed it (I assume previously, sentry instrumented only the CJS versions of the package(s), which aren't actually run in the application).

[onurtemizkan]

It doesn't seem to break anything (#12677). So it looks good to me if it resolves your issue. We'll need to revisit this when we add the worker support (For reference: #12643). But I think we can merge this in the meantime. @mydea does this make sense?

[AbhiPrasad]

shouldn't this get split into the following?

Suggested change

	"node": "./build/cjs/index.server.js"
	"node": {
	"import": "./build/esm/index.server.js",
	"require": "./build/cjs/index.server.js"
	},

[topaxi]

That was my initial change, see the first comment as to why that did not work.

[AbhiPrasad]

Thanks for the fix @topaxi!

[lforst]

This change broke our E2E tests so we'll likely revert.

[topaxi]

We are running remix in ESM mode, but the exports in package.json is pointing to the CommonJS module, which results in the SDK running in CommonJS mode instead of ESM.

This lead to the instrumentations not running/detecting properly.

[onurtemizkan]

Thanks for the PR @topaxi, I have tested this locally, which caused the server/client trace-propagation to break on E2E tests. I'll try to check what caused that.

[onurtemizkan]

@topaxi, could you please check if the update here solves your issue?

[topaxi]

@onurtemizkan no, this will still run the package in CommonJS mode.

[topaxi]

What does work for me though, is to specify the default import. I have updated the PR :)

Sadly I'm not able to install the npm dependencies locally from this repository as yarn does not succeed and playwright install tries to call apt which I do not have on my machine.

[onurtemizkan]

Thanks for the update @topaxi. Yes, I can see that specifying default under importdoes not break the current tests. But to validate that it works on tests, could you tell which instrumentations were not detected properly?

[topaxi]

This was specifically for express. The logs showed that express was not instrumented, and debug: true logged that sentry was running in CommonJS mode.

Switching sentry/remix to ESM fixed it (I assume previously, sentry instrumented only the CJS versions of the package(s), which aren't actually run in the application).

[onurtemizkan]

It doesn't seem to break anything (#12677). So it looks good to me if it resolves your issue. We'll need to revisit this when we add the worker support (For reference: #12643). But I think we can merge this in the meantime. @mydea does this make sense?

[AbhiPrasad]

shouldn't this get split into the following?

Suggested change

	"node": "./build/cjs/index.server.js"
	"node": {
	"import": "./build/esm/index.server.js",
	"require": "./build/cjs/index.server.js"
	},

[topaxi]

That was my initial change, see the first comment as to why that did not work.

[AbhiPrasad]

Thanks for the fix @topaxi!

[lforst]

This change broke our E2E tests so we'll likely revert.

[topaxi]

We are running remix in ESM mode, but the exports in package.json is pointing to the CommonJS module, which results in the SDK running in CommonJS mode instead of ESM.

This lead to the instrumentations not running/detecting properly.

[onurtemizkan]

Thanks for the PR @topaxi, I have tested this locally, which caused the server/client trace-propagation to break on E2E tests. I'll try to check what caused that.

[onurtemizkan]

@topaxi, could you please check if the update here solves your issue?

[topaxi]

@onurtemizkan no, this will still run the package in CommonJS mode.

[topaxi]

What does work for me though, is to specify the default import. I have updated the PR :)

Sadly I'm not able to install the npm dependencies locally from this repository as yarn does not succeed and playwright install tries to call apt which I do not have on my machine.

[onurtemizkan]

Thanks for the update @topaxi. Yes, I can see that specifying default under importdoes not break the current tests. But to validate that it works on tests, could you tell which instrumentations were not detected properly?

[topaxi]

This was specifically for express. The logs showed that express was not instrumented, and debug: true logged that sentry was running in CommonJS mode.

Switching sentry/remix to ESM fixed it (I assume previously, sentry instrumented only the CJS versions of the package(s), which aren't actually run in the application).

[onurtemizkan]

It doesn't seem to break anything (#12677). So it looks good to me if it resolves your issue. We'll need to revisit this when we add the worker support (For reference: #12643). But I think we can merge this in the meantime. @mydea does this make sense?

[AbhiPrasad]

shouldn't this get split into the following?

Suggested change

	"node": "./build/cjs/index.server.js"
	"node": {
	"import": "./build/esm/index.server.js",
	"require": "./build/cjs/index.server.js"
	},

[topaxi]

That was my initial change, see the first comment as to why that did not work.

[AbhiPrasad]

Thanks for the fix @topaxi!

[lforst]

This change broke our E2E tests so we'll likely revert.

[topaxi]

We are running remix in ESM mode, but the exports in package.json is pointing to the CommonJS module, which results in the SDK running in CommonJS mode instead of ESM.

This lead to the instrumentations not running/detecting properly.

[onurtemizkan]

Thanks for the PR @topaxi, I have tested this locally, which caused the server/client trace-propagation to break on E2E tests. I'll try to check what caused that.

[onurtemizkan]

@topaxi, could you please check if the update here solves your issue?

[topaxi]

@onurtemizkan no, this will still run the package in CommonJS mode.

[topaxi]

What does work for me though, is to specify the default import. I have updated the PR :)

Sadly I'm not able to install the npm dependencies locally from this repository as yarn does not succeed and playwright install tries to call apt which I do not have on my machine.

[onurtemizkan]

Thanks for the update @topaxi. Yes, I can see that specifying default under importdoes not break the current tests. But to validate that it works on tests, could you tell which instrumentations were not detected properly?

[topaxi]

This was specifically for express. The logs showed that express was not instrumented, and debug: true logged that sentry was running in CommonJS mode.

Switching sentry/remix to ESM fixed it (I assume previously, sentry instrumented only the CJS versions of the package(s), which aren't actually run in the application).

[onurtemizkan]

It doesn't seem to break anything (#12677). So it looks good to me if it resolves your issue. We'll need to revisit this when we add the worker support (For reference: #12643). But I think we can merge this in the meantime. @mydea does this make sense?

[AbhiPrasad]

shouldn't this get split into the following?

Suggested change

	"node": "./build/cjs/index.server.js"
	"node": {
	"import": "./build/esm/index.server.js",
	"require": "./build/cjs/index.server.js"
	},

[topaxi]

That was my initial change, see the first comment as to why that did not work.

[AbhiPrasad]

Thanks for the fix @topaxi!

[lforst]

This change broke our E2E tests so we'll likely revert.