feat(otel): Export & use spanTimeInputToSeconds for otel span exporter - #12699

Merged
AbhiPrasad merged 2 commits into
developfrom
onur/support-otel-number-timestamps
Jul 4, 2024
Merged

feat(otel): Export & use spanTimeInputToSeconds for otel span exporter#12699
AbhiPrasad merged 2 commits into
developfrom
onur/support-otel-number-timestamps

Conversation

@onurtemizkan

@onurtemizkanonurtemizkan commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.

Fixes: #12697 (Can't reproduce the issue but from the context of the report, this should resolve it)

@onurtemizkan
onurtemizkan requested a review from mydeaJune 28, 2024 16:16
AbhiPrasad
AbhiPrasad reviewed Jun 28, 2024
View reviewed changes

@AbhiPrasadAbhiPrasad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this? Seems really weird that this has this behaviour.

@onurtemizkan

onurtemizkan commented Jun 28, 2024

Copy link
Copy Markdown
ContributorAuthor

Yes, and I just realised that the PR is also incomplete, we need to detect if it's in milliseconds or seconds. In the issue it's in milliseconds.

@mydea

mydea commented Jul 1, 2024

Copy link
Copy Markdown
Member

Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?

@onurtemizkan

onurtemizkan commented Jul 1, 2024

Copy link
Copy Markdown
ContributorAuthor

Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?

Oh I wasn't aware of that! Updating the PR.

@onurtemizkan
onurtemizkanforce-pushed the onur/support-otel-number-timestamps branch from d73b071 to ae4a0f2CompareJuly 1, 2024 10:11
@github-actions

github-actionsBot commented Jul 1, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser22.22 KB (0%)
@sentry/browser (incl. Tracing)33.38 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.49 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.22 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.82 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.68 KB (0%)
@sentry/browser (incl. metrics)26.5 KB (0%)
@sentry/browser (incl. Feedback)38.86 KB (0%)
@sentry/browser (incl. sendFeedback)26.84 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.45 KB (0%)
@sentry/react24.97 KB (0%)
@sentry/react (incl. Tracing)36.43 KB (0%)
@sentry/vue26.33 KB (0%)
@sentry/vue (incl. Tracing)35.24 KB (0%)
@sentry/svelte22.36 KB (0%)
CDN Bundle23.42 KB (0%)
CDN Bundle (incl. Tracing)35.12 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.25 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.45 KB (0%)
CDN Bundle - uncompressed68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.82 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227 KB (0%)
@sentry/nextjs (client)36.3 KB (0%)
@sentry/sveltekit (client)34.02 KB (0%)
@sentry/node130.61 KB (-0.01% 🔽)
@sentry/node - without tracing91.62 KB (-0.03% 🔽)
@sentry/aws-serverless116.8 KB (-0.02% 🔽)

@onurtemizkan
onurtemizkanforce-pushed the onur/support-otel-number-timestamps branch from ae4a0f2 to 9da19ecCompareJuly 1, 2024 10:28
@mydeamydea changed the title feat(otel): Add support for non-tuple OTEL time.feat(otel): Export & use spanTimeInputToSeconds for otel span exporterJul 1, 2024
mydea
mydea approved these changes Jul 1, 2024
View reviewed changes

@mydeamydea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I adjusted the PR name to match what it now does :) Still weird why this is happening, as the types are pretty clear in what should happen, but does not hurt to be extra safe here...

@AbhiPrasad
AbhiPrasad merged commit b4d6469 into developJul 4, 2024
@AbhiPrasad
AbhiPrasad deleted the onur/support-otel-number-timestamps branch July 4, 2024 14:07
@q1blueq1blue mentioned this pull request Jul 27, 2024
Open
@amykapernickamykapernick mentioned this pull request Jul 27, 2024
Open
@aam-digital-ciaam-digital-ci mentioned this pull request Jul 27, 2024
Closed
This was referenced Jul 30, 2024
Open
Open
@amykapernickamykapernick mentioned this pull request Aug 1, 2024
Open
@wkylinwkylin mentioned this pull request Aug 1, 2024
Closed
@q1blueq1blue mentioned this pull request Aug 6, 2024
Open
@wkylinwkylin mentioned this pull request Aug 7, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydeamydeamydea approved these changes
+1 more reviewer
@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error on span using sentry-opentelemetry

3 participants

@onurtemizkan@mydea@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter - #12699
Merged
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Jul 4, 2024
Merged
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter#12699
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Conversation
@onurtemizkan
@onurtemizkanonurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.
Fixes: #12697 (Can't reproduce the issue but from the context of the report, this should resolve it)
@onurtemizkan
onurtemizkan
requested a review
from mydeaJune 28, 2024 16:16
AbhiPrasad
AbhiPrasad
reviewed
Jun 28, 2024
View reviewed changes
@AbhiPrasadAbhiPrasad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this? Seems really weird that this has this behaviour.
@onurtemizkan
onurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes, and I just realised that the PR is also incomplete, we need to detect if it's in milliseconds or seconds. In the issue it's in milliseconds.
@mydea
mydea
commented
Jul 1, 2024

Copy link


Copy Markdown

Member
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
@onurtemizkan
onurtemizkan
commented
Jul 1, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
Oh I wasn't aware of that! Updating the PR.
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
d73b071 to
ae4a0f2CompareJuly 1, 2024 10:11
@github-actions
github-actionsBot
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.22 KB (0%)
@sentry/browser (incl. Tracing)33.38 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.49 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.22 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.82 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.68 KB (0%)
@sentry/browser (incl. metrics)26.5 KB (0%)
@sentry/browser (incl. Feedback)38.86 KB (0%)
@sentry/browser (incl. sendFeedback)26.84 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.45 KB (0%)
@sentry/react24.97 KB (0%)
@sentry/react (incl. Tracing)36.43 KB (0%)
@sentry/vue26.33 KB (0%)
@sentry/vue (incl. Tracing)35.24 KB (0%)
@sentry/svelte22.36 KB (0%)
CDN Bundle23.42 KB (0%)
CDN Bundle (incl. Tracing)35.12 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.25 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.45 KB (0%)
CDN Bundle - uncompressed68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.82 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227 KB (0%)
@sentry/nextjs (client)36.3 KB (0%)
@sentry/sveltekit (client)34.02 KB (0%)
@sentry/node130.61 KB (-0.01% 🔽)
@sentry/node - without tracing91.62 KB (-0.03% 🔽)
@sentry/aws-serverless116.8 KB (-0.02% 🔽)
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
ae4a0f2 to
9da19ecCompareJuly 1, 2024 10:28
@mydeamydea
changed the title
feat(otel): Add support for non-tuple OTEL time.feat(otel): Export & use spanTimeInputToSeconds for otel span exporterJul 1, 2024
mydea
mydea
approved these changes
Jul 1, 2024
View reviewed changes
@mydeamydea
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I adjusted the PR name to match what it now does :) Still weird why this is happening, as the types are pretty clear in what should happen, but does not hurt to be extra safe here...
@AbhiPrasad
AbhiPrasad
merged commit b4d6469
into
developJul 4, 2024
@AbhiPrasad
AbhiPrasad
deleted the

onur/support-otel-number-timestamps

branch
July 4, 2024 14:07
@q1blueq1blue
mentioned this pull request
Jul 27, 2024
 Open

@amykapernickamykapernick
mentioned this pull request
Jul 27, 2024
 Open

@aam-digital-ciaam-digital-ci
mentioned this pull request
Jul 27, 2024
 Closed


This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

+1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Error on span using sentry-opentelemetry


3 participants

@onurtemizkan@mydea@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter - #12699
Merged
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Jul 4, 2024
Merged
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter#12699
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Conversation
@onurtemizkan
@onurtemizkanonurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.
Fixes: #12697 (Can't reproduce the issue but from the context of the report, this should resolve it)
@onurtemizkan
onurtemizkan
requested a review
from mydeaJune 28, 2024 16:16
AbhiPrasad
AbhiPrasad
reviewed
Jun 28, 2024
View reviewed changes
@AbhiPrasadAbhiPrasad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this? Seems really weird that this has this behaviour.
@onurtemizkan
onurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes, and I just realised that the PR is also incomplete, we need to detect if it's in milliseconds or seconds. In the issue it's in milliseconds.
@mydea
mydea
commented
Jul 1, 2024

Copy link


Copy Markdown

Member
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
@onurtemizkan
onurtemizkan
commented
Jul 1, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
Oh I wasn't aware of that! Updating the PR.
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
d73b071 to
ae4a0f2CompareJuly 1, 2024 10:11
@github-actions
github-actionsBot
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.22 KB (0%)
@sentry/browser (incl. Tracing)33.38 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.49 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.22 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.82 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.68 KB (0%)
@sentry/browser (incl. metrics)26.5 KB (0%)
@sentry/browser (incl. Feedback)38.86 KB (0%)
@sentry/browser (incl. sendFeedback)26.84 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.45 KB (0%)
@sentry/react24.97 KB (0%)
@sentry/react (incl. Tracing)36.43 KB (0%)
@sentry/vue26.33 KB (0%)
@sentry/vue (incl. Tracing)35.24 KB (0%)
@sentry/svelte22.36 KB (0%)
CDN Bundle23.42 KB (0%)
CDN Bundle (incl. Tracing)35.12 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.25 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.45 KB (0%)
CDN Bundle - uncompressed68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.82 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227 KB (0%)
@sentry/nextjs (client)36.3 KB (0%)
@sentry/sveltekit (client)34.02 KB (0%)
@sentry/node130.61 KB (-0.01% 🔽)
@sentry/node - without tracing91.62 KB (-0.03% 🔽)
@sentry/aws-serverless116.8 KB (-0.02% 🔽)
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
ae4a0f2 to
9da19ecCompareJuly 1, 2024 10:28
@mydeamydea
changed the title
feat(otel): Add support for non-tuple OTEL time.feat(otel): Export & use spanTimeInputToSeconds for otel span exporterJul 1, 2024
mydea
mydea
approved these changes
Jul 1, 2024
View reviewed changes
@mydeamydea
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I adjusted the PR name to match what it now does :) Still weird why this is happening, as the types are pretty clear in what should happen, but does not hurt to be extra safe here...
@AbhiPrasad
AbhiPrasad
merged commit b4d6469
into
developJul 4, 2024
@AbhiPrasad
AbhiPrasad
deleted the

onur/support-otel-number-timestamps

branch
July 4, 2024 14:07
@q1blueq1blue
mentioned this pull request
Jul 27, 2024
 Open

@amykapernickamykapernick
mentioned this pull request
Jul 27, 2024
 Open

@aam-digital-ciaam-digital-ci
mentioned this pull request
Jul 27, 2024
 Closed


This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

+1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Error on span using sentry-opentelemetry


3 participants

@onurtemizkan@mydea@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter - #12699
Merged
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Jul 4, 2024
Merged
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter#12699
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Conversation
@onurtemizkan
@onurtemizkanonurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.
Fixes: #12697 (Can't reproduce the issue but from the context of the report, this should resolve it)
@onurtemizkan
onurtemizkan
requested a review
from mydeaJune 28, 2024 16:16
AbhiPrasad
AbhiPrasad
reviewed
Jun 28, 2024
View reviewed changes
@AbhiPrasadAbhiPrasad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this? Seems really weird that this has this behaviour.
@onurtemizkan
onurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes, and I just realised that the PR is also incomplete, we need to detect if it's in milliseconds or seconds. In the issue it's in milliseconds.
@mydea
mydea
commented
Jul 1, 2024

Copy link


Copy Markdown

Member
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
@onurtemizkan
onurtemizkan
commented
Jul 1, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
Oh I wasn't aware of that! Updating the PR.
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
d73b071 to
ae4a0f2CompareJuly 1, 2024 10:11
@github-actions
github-actionsBot
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.22 KB (0%)
@sentry/browser (incl. Tracing)33.38 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.49 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.22 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.82 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.68 KB (0%)
@sentry/browser (incl. metrics)26.5 KB (0%)
@sentry/browser (incl. Feedback)38.86 KB (0%)
@sentry/browser (incl. sendFeedback)26.84 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.45 KB (0%)
@sentry/react24.97 KB (0%)
@sentry/react (incl. Tracing)36.43 KB (0%)
@sentry/vue26.33 KB (0%)
@sentry/vue (incl. Tracing)35.24 KB (0%)
@sentry/svelte22.36 KB (0%)
CDN Bundle23.42 KB (0%)
CDN Bundle (incl. Tracing)35.12 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.25 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.45 KB (0%)
CDN Bundle - uncompressed68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.82 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227 KB (0%)
@sentry/nextjs (client)36.3 KB (0%)
@sentry/sveltekit (client)34.02 KB (0%)
@sentry/node130.61 KB (-0.01% 🔽)
@sentry/node - without tracing91.62 KB (-0.03% 🔽)
@sentry/aws-serverless116.8 KB (-0.02% 🔽)
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
ae4a0f2 to
9da19ecCompareJuly 1, 2024 10:28
@mydeamydea
changed the title
feat(otel): Add support for non-tuple OTEL time.feat(otel): Export & use spanTimeInputToSeconds for otel span exporterJul 1, 2024
mydea
mydea
approved these changes
Jul 1, 2024
View reviewed changes
@mydeamydea
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I adjusted the PR name to match what it now does :) Still weird why this is happening, as the types are pretty clear in what should happen, but does not hurt to be extra safe here...
@AbhiPrasad
AbhiPrasad
merged commit b4d6469
into
developJul 4, 2024
@AbhiPrasad
AbhiPrasad
deleted the

onur/support-otel-number-timestamps

branch
July 4, 2024 14:07
@q1blueq1blue
mentioned this pull request
Jul 27, 2024
 Open

@amykapernickamykapernick
mentioned this pull request
Jul 27, 2024
 Open

@aam-digital-ciaam-digital-ci
mentioned this pull request
Jul 27, 2024
 Closed


This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

+1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Error on span using sentry-opentelemetry


3 participants

@onurtemizkan@mydea@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter - #12699
Merged
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Jul 4, 2024
Merged
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter#12699
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Conversation
@onurtemizkan
@onurtemizkanonurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.
Fixes: #12697 (Can't reproduce the issue but from the context of the report, this should resolve it)
@onurtemizkan
onurtemizkan
requested a review
from mydeaJune 28, 2024 16:16
AbhiPrasad
AbhiPrasad
reviewed
Jun 28, 2024
View reviewed changes
@AbhiPrasadAbhiPrasad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this? Seems really weird that this has this behaviour.
@onurtemizkan
onurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes, and I just realised that the PR is also incomplete, we need to detect if it's in milliseconds or seconds. In the issue it's in milliseconds.
@mydea
mydea
commented
Jul 1, 2024

Copy link


Copy Markdown

Member
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
@onurtemizkan
onurtemizkan
commented
Jul 1, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
Oh I wasn't aware of that! Updating the PR.
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
d73b071 to
ae4a0f2CompareJuly 1, 2024 10:11
@github-actions
github-actionsBot
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.22 KB (0%)
@sentry/browser (incl. Tracing)33.38 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.49 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.22 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.82 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.68 KB (0%)
@sentry/browser (incl. metrics)26.5 KB (0%)
@sentry/browser (incl. Feedback)38.86 KB (0%)
@sentry/browser (incl. sendFeedback)26.84 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.45 KB (0%)
@sentry/react24.97 KB (0%)
@sentry/react (incl. Tracing)36.43 KB (0%)
@sentry/vue26.33 KB (0%)
@sentry/vue (incl. Tracing)35.24 KB (0%)
@sentry/svelte22.36 KB (0%)
CDN Bundle23.42 KB (0%)
CDN Bundle (incl. Tracing)35.12 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.25 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.45 KB (0%)
CDN Bundle - uncompressed68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.82 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227 KB (0%)
@sentry/nextjs (client)36.3 KB (0%)
@sentry/sveltekit (client)34.02 KB (0%)
@sentry/node130.61 KB (-0.01% 🔽)
@sentry/node - without tracing91.62 KB (-0.03% 🔽)
@sentry/aws-serverless116.8 KB (-0.02% 🔽)
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
ae4a0f2 to
9da19ecCompareJuly 1, 2024 10:28
@mydeamydea
changed the title
feat(otel): Add support for non-tuple OTEL time.feat(otel): Export & use spanTimeInputToSeconds for otel span exporterJul 1, 2024
mydea
mydea
approved these changes
Jul 1, 2024
View reviewed changes
@mydeamydea
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I adjusted the PR name to match what it now does :) Still weird why this is happening, as the types are pretty clear in what should happen, but does not hurt to be extra safe here...
@AbhiPrasad
AbhiPrasad
merged commit b4d6469
into
developJul 4, 2024
@AbhiPrasad
AbhiPrasad
deleted the

onur/support-otel-number-timestamps

branch
July 4, 2024 14:07
@q1blueq1blue
mentioned this pull request
Jul 27, 2024
 Open

@amykapernickamykapernick
mentioned this pull request
Jul 27, 2024
 Open

@aam-digital-ciaam-digital-ci
mentioned this pull request
Jul 27, 2024
 Closed


This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

+1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Error on span using sentry-opentelemetry


3 participants

@onurtemizkan@mydea@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter - #12699
Merged
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Jul 4, 2024
Merged
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter#12699
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Conversation
@onurtemizkan
@onurtemizkanonurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.
Fixes: #12697 (Can't reproduce the issue but from the context of the report, this should resolve it)
@onurtemizkan
onurtemizkan
requested a review
from mydeaJune 28, 2024 16:16
AbhiPrasad
AbhiPrasad
reviewed
Jun 28, 2024
View reviewed changes
@AbhiPrasadAbhiPrasad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this? Seems really weird that this has this behaviour.
@onurtemizkan
onurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes, and I just realised that the PR is also incomplete, we need to detect if it's in milliseconds or seconds. In the issue it's in milliseconds.
@mydea
mydea
commented
Jul 1, 2024

Copy link


Copy Markdown

Member
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
@onurtemizkan
onurtemizkan
commented
Jul 1, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
Oh I wasn't aware of that! Updating the PR.
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
d73b071 to
ae4a0f2CompareJuly 1, 2024 10:11
@github-actions
github-actionsBot
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.22 KB (0%)
@sentry/browser (incl. Tracing)33.38 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.49 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.22 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.82 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.68 KB (0%)
@sentry/browser (incl. metrics)26.5 KB (0%)
@sentry/browser (incl. Feedback)38.86 KB (0%)
@sentry/browser (incl. sendFeedback)26.84 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.45 KB (0%)
@sentry/react24.97 KB (0%)
@sentry/react (incl. Tracing)36.43 KB (0%)
@sentry/vue26.33 KB (0%)
@sentry/vue (incl. Tracing)35.24 KB (0%)
@sentry/svelte22.36 KB (0%)
CDN Bundle23.42 KB (0%)
CDN Bundle (incl. Tracing)35.12 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.25 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.45 KB (0%)
CDN Bundle - uncompressed68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.82 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227 KB (0%)
@sentry/nextjs (client)36.3 KB (0%)
@sentry/sveltekit (client)34.02 KB (0%)
@sentry/node130.61 KB (-0.01% 🔽)
@sentry/node - without tracing91.62 KB (-0.03% 🔽)
@sentry/aws-serverless116.8 KB (-0.02% 🔽)
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
ae4a0f2 to
9da19ecCompareJuly 1, 2024 10:28
@mydeamydea
changed the title
feat(otel): Add support for non-tuple OTEL time.feat(otel): Export & use spanTimeInputToSeconds for otel span exporterJul 1, 2024
mydea
mydea
approved these changes
Jul 1, 2024
View reviewed changes
@mydeamydea
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I adjusted the PR name to match what it now does :) Still weird why this is happening, as the types are pretty clear in what should happen, but does not hurt to be extra safe here...
@AbhiPrasad
AbhiPrasad
merged commit b4d6469
into
developJul 4, 2024
@AbhiPrasad
AbhiPrasad
deleted the

onur/support-otel-number-timestamps

branch
July 4, 2024 14:07
@q1blueq1blue
mentioned this pull request
Jul 27, 2024
 Open

@amykapernickamykapernick
mentioned this pull request
Jul 27, 2024
 Open

@aam-digital-ciaam-digital-ci
mentioned this pull request
Jul 27, 2024
 Closed


This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

+1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Error on span using sentry-opentelemetry


3 participants

@onurtemizkan@mydea@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter - #12699
Merged
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Jul 4, 2024
Merged
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter#12699
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Conversation
@onurtemizkan
@onurtemizkanonurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.
Fixes: #12697 (Can't reproduce the issue but from the context of the report, this should resolve it)
@onurtemizkan
onurtemizkan
requested a review
from mydeaJune 28, 2024 16:16
AbhiPrasad
AbhiPrasad
reviewed
Jun 28, 2024
View reviewed changes
@AbhiPrasadAbhiPrasad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this? Seems really weird that this has this behaviour.
@onurtemizkan
onurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes, and I just realised that the PR is also incomplete, we need to detect if it's in milliseconds or seconds. In the issue it's in milliseconds.
@mydea
mydea
commented
Jul 1, 2024

Copy link


Copy Markdown

Member
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
@onurtemizkan
onurtemizkan
commented
Jul 1, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
Oh I wasn't aware of that! Updating the PR.
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
d73b071 to
ae4a0f2CompareJuly 1, 2024 10:11
@github-actions
github-actionsBot
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.22 KB (0%)
@sentry/browser (incl. Tracing)33.38 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.49 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.22 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.82 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.68 KB (0%)
@sentry/browser (incl. metrics)26.5 KB (0%)
@sentry/browser (incl. Feedback)38.86 KB (0%)
@sentry/browser (incl. sendFeedback)26.84 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.45 KB (0%)
@sentry/react24.97 KB (0%)
@sentry/react (incl. Tracing)36.43 KB (0%)
@sentry/vue26.33 KB (0%)
@sentry/vue (incl. Tracing)35.24 KB (0%)
@sentry/svelte22.36 KB (0%)
CDN Bundle23.42 KB (0%)
CDN Bundle (incl. Tracing)35.12 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.25 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.45 KB (0%)
CDN Bundle - uncompressed68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.82 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227 KB (0%)
@sentry/nextjs (client)36.3 KB (0%)
@sentry/sveltekit (client)34.02 KB (0%)
@sentry/node130.61 KB (-0.01% 🔽)
@sentry/node - without tracing91.62 KB (-0.03% 🔽)
@sentry/aws-serverless116.8 KB (-0.02% 🔽)
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
ae4a0f2 to
9da19ecCompareJuly 1, 2024 10:28
@mydeamydea
changed the title
feat(otel): Add support for non-tuple OTEL time.feat(otel): Export & use spanTimeInputToSeconds for otel span exporterJul 1, 2024
mydea
mydea
approved these changes
Jul 1, 2024
View reviewed changes
@mydeamydea
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I adjusted the PR name to match what it now does :) Still weird why this is happening, as the types are pretty clear in what should happen, but does not hurt to be extra safe here...
@AbhiPrasad
AbhiPrasad
merged commit b4d6469
into
developJul 4, 2024
@AbhiPrasad
AbhiPrasad
deleted the

onur/support-otel-number-timestamps

branch
July 4, 2024 14:07
@q1blueq1blue
mentioned this pull request
Jul 27, 2024
 Open

@amykapernickamykapernick
mentioned this pull request
Jul 27, 2024
 Open

@aam-digital-ciaam-digital-ci
mentioned this pull request
Jul 27, 2024
 Closed


This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

+1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Error on span using sentry-opentelemetry


3 participants

@onurtemizkan@mydea@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter - #12699
Merged
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Jul 4, 2024
Merged
feat(otel): Export & use spanTimeInputToSeconds for otel span exporter#12699
AbhiPrasad merged 2 commits into
developfrom 
onur/support-otel-number-timestamps
Conversation
@onurtemizkan
@onurtemizkanonurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Adds support for cases where the time from OTEL is just a number in milliseconds instead of tuples.
Fixes: #12697 (Can't reproduce the issue but from the context of the report, this should resolve it)
@onurtemizkan
onurtemizkan
requested a review
from mydeaJune 28, 2024 16:16
AbhiPrasad
AbhiPrasad
reviewed
Jun 28, 2024
View reviewed changes
@AbhiPrasadAbhiPrasad
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for this? Seems really weird that this has this behaviour.
@onurtemizkan
onurtemizkan
commented
Jun 28, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes, and I just realised that the PR is also incomplete, we need to detect if it's in milliseconds or seconds. In the issue it's in milliseconds.
@mydea
mydea
commented
Jul 1, 2024

Copy link


Copy Markdown

Member
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
@onurtemizkan
onurtemizkan
commented
Jul 1, 2024

Copy link


Copy Markdown

ContributorAuthor
Can we instead just export spanTimeInputToSeconds from @sentry/core and use this? This already has all the different scenarios and should handle them correctly?
Oh I wasn't aware of that! Updating the PR.
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
d73b071 to
ae4a0f2CompareJuly 1, 2024 10:11
@github-actions
github-actionsBot
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.22 KB (0%)
@sentry/browser (incl. Tracing)33.38 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.16 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.49 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.22 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.82 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.68 KB (0%)
@sentry/browser (incl. metrics)26.5 KB (0%)
@sentry/browser (incl. Feedback)38.86 KB (0%)
@sentry/browser (incl. sendFeedback)26.84 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.45 KB (0%)
@sentry/react24.97 KB (0%)
@sentry/react (incl. Tracing)36.43 KB (0%)
@sentry/vue26.33 KB (0%)
@sentry/vue (incl. Tracing)35.24 KB (0%)
@sentry/svelte22.36 KB (0%)
CDN Bundle23.42 KB (0%)
CDN Bundle (incl. Tracing)35.12 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.25 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.45 KB (0%)
CDN Bundle - uncompressed68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.82 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227 KB (0%)
@sentry/nextjs (client)36.3 KB (0%)
@sentry/sveltekit (client)34.02 KB (0%)
@sentry/node130.61 KB (-0.01% 🔽)
@sentry/node - without tracing91.62 KB (-0.03% 🔽)
@sentry/aws-serverless116.8 KB (-0.02% 🔽)
@onurtemizkan
onurtemizkanforce-pushed
the
onur/support-otel-number-timestamps
branch
from
ae4a0f2 to
9da19ecCompareJuly 1, 2024 10:28
@mydeamydea
changed the title
feat(otel): Add support for non-tuple OTEL time.feat(otel): Export & use spanTimeInputToSeconds for otel span exporterJul 1, 2024
mydea
mydea
approved these changes
Jul 1, 2024
View reviewed changes
@mydeamydea
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I adjusted the PR name to match what it now does :) Still weird why this is happening, as the types are pretty clear in what should happen, but does not hurt to be extra safe here...
@AbhiPrasad
AbhiPrasad
merged commit b4d6469
into
developJul 4, 2024
@AbhiPrasad
AbhiPrasad
deleted the

onur/support-otel-number-timestamps

branch
July 4, 2024 14:07
@q1blueq1blue
mentioned this pull request
Jul 27, 2024
 Open

@amykapernickamykapernick
mentioned this pull request
Jul 27, 2024
 Open

@aam-digital-ciaam-digital-ci
mentioned this pull request
Jul 27, 2024
 Closed


This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@mydeamydeamydea approved these changes

+1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Error on span using sentry-opentelemetry


3 participants

@onurtemizkan@mydea@AbhiPrasad