feat(nestjs): Add function-level span decorator to nestjs by nicohrubec · Pull Request #12721 · getsentry/sentry-javascript

nicohrubec · 2024-07-02T11:14:19Z

Adds a decorator @SentryTraced() to the nestjs sdk that can be used on functions to wrap them in a span.

Manual test from my sample application see screenshot below.

e2e test
README update with short example demonstrating how to use this feature

mydea · 2024-07-03T13:58:52Z


+## Span Decorator
+
+Use the @GetSentrySpan() decorator to gain additional performance insights for any function within your NestJS application.


l: Is GetX a pattern that is common for nest? To me it reads a bit weird, something like WrapWithSentrySpan or something along these lines would feel more explanatory to me, but no strong feelings!

SentryTraced

No, GetX is not super common in nest was just an initial idea. I like SentryTraced if everyone is happy with that

Updated to SentryTraced

lforst

I have a few things that should be adressed but otherwise looks great.

lforst · 2024-07-04T08:47:31Z

+ try {
+ return await originalMethod.apply(this, args);
+ } catch (e) {
+ captureException(e);
+ }


h: We do not want to wrap this with a try-catch-captureException. We only want to capture errors when they bubble up to an unexpected place.

lforst · 2024-07-04T08:48:11Z


 export { init } from './sdk';
+
+export * from './span-decorator';


h: In the index file, let's be specific about what we export. This is to avoid accidentally widening the API surface.

lforst · 2024-07-04T08:58:34Z

+ const originalMethod = descriptor.value as (...args: any[]) => Promise<any>;
+
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ descriptor.value = async function (...args: any[]) {


h: We should not modify the return value. Currently we are wrapping all non-promise return values in a Promise. To fix this we can just remove all async and await keywords and everything will work perfectly fine.

lforst · 2024-07-04T08:59:30Z

+ expect.objectContaining({
+ span_id: expect.any(String),
+ trace_id: expect.any(String),
+ data: expect.any(Object),


m: Let's assert on the sentry.origin and sentry.source attibutes in the data object.

I explicitly assert the data object now, there is no sentry.source property though

lforst · 2024-07-04T09:00:15Z

+ @SentryTraced('wait function')
+ async wait() {
+ return new Promise(resolve => setTimeout(resolve, 500));
+ }


l: We could add a second method that is not async and assert on it in the test.

Do you mean a second non-async function and then check whether the transaction includes spans for both?

nicohrubec · 2024-07-02T11:14:19Z

Adds a decorator @SentryTraced() to the nestjs sdk that can be used on functions to wrap them in a span.

Manual test from my sample application see screenshot below.

e2e test
README update with short example demonstrating how to use this feature

mydea · 2024-07-03T13:58:52Z


+## Span Decorator
+
+Use the @GetSentrySpan() decorator to gain additional performance insights for any function within your NestJS application.


l: Is GetX a pattern that is common for nest? To me it reads a bit weird, something like WrapWithSentrySpan or something along these lines would feel more explanatory to me, but no strong feelings!

SentryTraced

No, GetX is not super common in nest was just an initial idea. I like SentryTraced if everyone is happy with that

Updated to SentryTraced

lforst

I have a few things that should be adressed but otherwise looks great.

lforst · 2024-07-04T08:47:31Z

+ try {
+ return await originalMethod.apply(this, args);
+ } catch (e) {
+ captureException(e);
+ }


h: We do not want to wrap this with a try-catch-captureException. We only want to capture errors when they bubble up to an unexpected place.

lforst · 2024-07-04T08:48:11Z


 export { init } from './sdk';
+
+export * from './span-decorator';


h: In the index file, let's be specific about what we export. This is to avoid accidentally widening the API surface.

lforst · 2024-07-04T08:58:34Z

+ const originalMethod = descriptor.value as (...args: any[]) => Promise<any>;
+
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ descriptor.value = async function (...args: any[]) {


h: We should not modify the return value. Currently we are wrapping all non-promise return values in a Promise. To fix this we can just remove all async and await keywords and everything will work perfectly fine.

lforst · 2024-07-04T08:59:30Z

+ expect.objectContaining({
+ span_id: expect.any(String),
+ trace_id: expect.any(String),
+ data: expect.any(Object),


m: Let's assert on the sentry.origin and sentry.source attibutes in the data object.

I explicitly assert the data object now, there is no sentry.source property though

lforst · 2024-07-04T09:00:15Z

+ @SentryTraced('wait function')
+ async wait() {
+ return new Promise(resolve => setTimeout(resolve, 500));
+ }


l: We could add a second method that is not async and assert on it in the test.

Do you mean a second non-async function and then check whether the transaction includes spans for both?

nicohrubec · 2024-07-02T11:14:19Z

Adds a decorator @SentryTraced() to the nestjs sdk that can be used on functions to wrap them in a span.

Manual test from my sample application see screenshot below.

e2e test
README update with short example demonstrating how to use this feature

mydea · 2024-07-03T13:58:52Z


+## Span Decorator
+
+Use the @GetSentrySpan() decorator to gain additional performance insights for any function within your NestJS application.


l: Is GetX a pattern that is common for nest? To me it reads a bit weird, something like WrapWithSentrySpan or something along these lines would feel more explanatory to me, but no strong feelings!

SentryTraced

No, GetX is not super common in nest was just an initial idea. I like SentryTraced if everyone is happy with that

Updated to SentryTraced

lforst

I have a few things that should be adressed but otherwise looks great.

lforst · 2024-07-04T08:47:31Z

+ try {
+ return await originalMethod.apply(this, args);
+ } catch (e) {
+ captureException(e);
+ }


h: We do not want to wrap this with a try-catch-captureException. We only want to capture errors when they bubble up to an unexpected place.

lforst · 2024-07-04T08:48:11Z


 export { init } from './sdk';
+
+export * from './span-decorator';


h: In the index file, let's be specific about what we export. This is to avoid accidentally widening the API surface.

lforst · 2024-07-04T08:58:34Z

+ const originalMethod = descriptor.value as (...args: any[]) => Promise<any>;
+
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ descriptor.value = async function (...args: any[]) {


h: We should not modify the return value. Currently we are wrapping all non-promise return values in a Promise. To fix this we can just remove all async and await keywords and everything will work perfectly fine.

lforst · 2024-07-04T08:59:30Z

+ expect.objectContaining({
+ span_id: expect.any(String),
+ trace_id: expect.any(String),
+ data: expect.any(Object),


m: Let's assert on the sentry.origin and sentry.source attibutes in the data object.

I explicitly assert the data object now, there is no sentry.source property though

lforst · 2024-07-04T09:00:15Z

+ @SentryTraced('wait function')
+ async wait() {
+ return new Promise(resolve => setTimeout(resolve, 500));
+ }


l: We could add a second method that is not async and assert on it in the test.

Do you mean a second non-async function and then check whether the transaction includes spans for both?

nicohrubec · 2024-07-02T11:14:19Z

Adds a decorator @SentryTraced() to the nestjs sdk that can be used on functions to wrap them in a span.

Manual test from my sample application see screenshot below.

e2e test
README update with short example demonstrating how to use this feature

mydea · 2024-07-03T13:58:52Z


+## Span Decorator
+
+Use the @GetSentrySpan() decorator to gain additional performance insights for any function within your NestJS application.


l: Is GetX a pattern that is common for nest? To me it reads a bit weird, something like WrapWithSentrySpan or something along these lines would feel more explanatory to me, but no strong feelings!

SentryTraced

No, GetX is not super common in nest was just an initial idea. I like SentryTraced if everyone is happy with that

Updated to SentryTraced

lforst

I have a few things that should be adressed but otherwise looks great.

lforst · 2024-07-04T08:47:31Z

+ try {
+ return await originalMethod.apply(this, args);
+ } catch (e) {
+ captureException(e);
+ }


h: We do not want to wrap this with a try-catch-captureException. We only want to capture errors when they bubble up to an unexpected place.

lforst · 2024-07-04T08:48:11Z


 export { init } from './sdk';
+
+export * from './span-decorator';


h: In the index file, let's be specific about what we export. This is to avoid accidentally widening the API surface.

lforst · 2024-07-04T08:58:34Z

+ const originalMethod = descriptor.value as (...args: any[]) => Promise<any>;
+
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ descriptor.value = async function (...args: any[]) {


h: We should not modify the return value. Currently we are wrapping all non-promise return values in a Promise. To fix this we can just remove all async and await keywords and everything will work perfectly fine.

lforst · 2024-07-04T08:59:30Z

+ expect.objectContaining({
+ span_id: expect.any(String),
+ trace_id: expect.any(String),
+ data: expect.any(Object),


m: Let's assert on the sentry.origin and sentry.source attibutes in the data object.

I explicitly assert the data object now, there is no sentry.source property though

lforst · 2024-07-04T09:00:15Z

+ @SentryTraced('wait function')
+ async wait() {
+ return new Promise(resolve => setTimeout(resolve, 500));
+ }


l: We could add a second method that is not async and assert on it in the test.

Do you mean a second non-async function and then check whether the transaction includes spans for both?

nicohrubec · 2024-07-02T11:14:19Z

Adds a decorator @SentryTraced() to the nestjs sdk that can be used on functions to wrap them in a span.

Manual test from my sample application see screenshot below.

e2e test
README update with short example demonstrating how to use this feature

mydea · 2024-07-03T13:58:52Z


+## Span Decorator
+
+Use the @GetSentrySpan() decorator to gain additional performance insights for any function within your NestJS application.


l: Is GetX a pattern that is common for nest? To me it reads a bit weird, something like WrapWithSentrySpan or something along these lines would feel more explanatory to me, but no strong feelings!

SentryTraced

No, GetX is not super common in nest was just an initial idea. I like SentryTraced if everyone is happy with that

Updated to SentryTraced

lforst

I have a few things that should be adressed but otherwise looks great.

lforst · 2024-07-04T08:47:31Z

+ try {
+ return await originalMethod.apply(this, args);
+ } catch (e) {
+ captureException(e);
+ }


h: We do not want to wrap this with a try-catch-captureException. We only want to capture errors when they bubble up to an unexpected place.

lforst · 2024-07-04T08:48:11Z


 export { init } from './sdk';
+
+export * from './span-decorator';


h: In the index file, let's be specific about what we export. This is to avoid accidentally widening the API surface.

lforst · 2024-07-04T08:58:34Z

+ const originalMethod = descriptor.value as (...args: any[]) => Promise<any>;
+
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ descriptor.value = async function (...args: any[]) {


h: We should not modify the return value. Currently we are wrapping all non-promise return values in a Promise. To fix this we can just remove all async and await keywords and everything will work perfectly fine.

lforst · 2024-07-04T08:59:30Z

+ expect.objectContaining({
+ span_id: expect.any(String),
+ trace_id: expect.any(String),
+ data: expect.any(Object),


m: Let's assert on the sentry.origin and sentry.source attibutes in the data object.

I explicitly assert the data object now, there is no sentry.source property though

lforst · 2024-07-04T09:00:15Z

+ @SentryTraced('wait function')
+ async wait() {
+ return new Promise(resolve => setTimeout(resolve, 500));
+ }


l: We could add a second method that is not async and assert on it in the test.

Do you mean a second non-async function and then check whether the transaction includes spans for both?

nicohrubec · 2024-07-02T11:14:19Z

Adds a decorator @SentryTraced() to the nestjs sdk that can be used on functions to wrap them in a span.

Manual test from my sample application see screenshot below.

e2e test
README update with short example demonstrating how to use this feature

mydea · 2024-07-03T13:58:52Z


+## Span Decorator
+
+Use the @GetSentrySpan() decorator to gain additional performance insights for any function within your NestJS application.


l: Is GetX a pattern that is common for nest? To me it reads a bit weird, something like WrapWithSentrySpan or something along these lines would feel more explanatory to me, but no strong feelings!

SentryTraced

No, GetX is not super common in nest was just an initial idea. I like SentryTraced if everyone is happy with that

Updated to SentryTraced

lforst

I have a few things that should be adressed but otherwise looks great.

lforst · 2024-07-04T08:47:31Z

+ try {
+ return await originalMethod.apply(this, args);
+ } catch (e) {
+ captureException(e);
+ }


h: We do not want to wrap this with a try-catch-captureException. We only want to capture errors when they bubble up to an unexpected place.

lforst · 2024-07-04T08:48:11Z


 export { init } from './sdk';
+
+export * from './span-decorator';


h: In the index file, let's be specific about what we export. This is to avoid accidentally widening the API surface.

lforst · 2024-07-04T08:58:34Z

+ const originalMethod = descriptor.value as (...args: any[]) => Promise<any>;
+
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ descriptor.value = async function (...args: any[]) {


h: We should not modify the return value. Currently we are wrapping all non-promise return values in a Promise. To fix this we can just remove all async and await keywords and everything will work perfectly fine.

lforst · 2024-07-04T08:59:30Z

+ expect.objectContaining({
+ span_id: expect.any(String),
+ trace_id: expect.any(String),
+ data: expect.any(Object),


m: Let's assert on the sentry.origin and sentry.source attibutes in the data object.

I explicitly assert the data object now, there is no sentry.source property though

lforst · 2024-07-04T09:00:15Z

+ @SentryTraced('wait function')
+ async wait() {
+ return new Promise(resolve => setTimeout(resolve, 500));
+ }


l: We could add a second method that is not async and assert on it in the test.

Do you mean a second non-async function and then check whether the transaction includes spans for both?

nicohrubec · 2024-07-02T11:14:19Z

Adds a decorator @SentryTraced() to the nestjs sdk that can be used on functions to wrap them in a span.

Manual test from my sample application see screenshot below.

e2e test
README update with short example demonstrating how to use this feature

mydea · 2024-07-03T13:58:52Z


+## Span Decorator
+
+Use the @GetSentrySpan() decorator to gain additional performance insights for any function within your NestJS application.


l: Is GetX a pattern that is common for nest? To me it reads a bit weird, something like WrapWithSentrySpan or something along these lines would feel more explanatory to me, but no strong feelings!

SentryTraced

No, GetX is not super common in nest was just an initial idea. I like SentryTraced if everyone is happy with that

Updated to SentryTraced

lforst

I have a few things that should be adressed but otherwise looks great.

lforst · 2024-07-04T08:47:31Z

+ try {
+ return await originalMethod.apply(this, args);
+ } catch (e) {
+ captureException(e);
+ }


h: We do not want to wrap this with a try-catch-captureException. We only want to capture errors when they bubble up to an unexpected place.

lforst · 2024-07-04T08:48:11Z


 export { init } from './sdk';
+
+export * from './span-decorator';


h: In the index file, let's be specific about what we export. This is to avoid accidentally widening the API surface.

lforst · 2024-07-04T08:58:34Z

+ const originalMethod = descriptor.value as (...args: any[]) => Promise<any>;
+
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ descriptor.value = async function (...args: any[]) {


h: We should not modify the return value. Currently we are wrapping all non-promise return values in a Promise. To fix this we can just remove all async and await keywords and everything will work perfectly fine.

lforst · 2024-07-04T08:59:30Z

+ expect.objectContaining({
+ span_id: expect.any(String),
+ trace_id: expect.any(String),
+ data: expect.any(Object),


m: Let's assert on the sentry.origin and sentry.source attibutes in the data object.

I explicitly assert the data object now, there is no sentry.source property though

lforst · 2024-07-04T09:00:15Z

+ @SentryTraced('wait function')
+ async wait() {
+ return new Promise(resolve => setTimeout(resolve, 500));
+ }


l: We could add a second method that is not async and assert on it in the test.

Do you mean a second non-async function and then check whether the transaction includes spans for both?

nicohrubec · 2024-07-02T11:14:19Z

Adds a decorator @SentryTraced() to the nestjs sdk that can be used on functions to wrap them in a span.

Manual test from my sample application see screenshot below.

e2e test
README update with short example demonstrating how to use this feature

mydea · 2024-07-03T13:58:52Z


+## Span Decorator
+
+Use the @GetSentrySpan() decorator to gain additional performance insights for any function within your NestJS application.


l: Is GetX a pattern that is common for nest? To me it reads a bit weird, something like WrapWithSentrySpan or something along these lines would feel more explanatory to me, but no strong feelings!

SentryTraced

No, GetX is not super common in nest was just an initial idea. I like SentryTraced if everyone is happy with that

Updated to SentryTraced

lforst

I have a few things that should be adressed but otherwise looks great.

lforst · 2024-07-04T08:47:31Z

+ try {
+ return await originalMethod.apply(this, args);
+ } catch (e) {
+ captureException(e);
+ }


h: We do not want to wrap this with a try-catch-captureException. We only want to capture errors when they bubble up to an unexpected place.

lforst · 2024-07-04T08:48:11Z


 export { init } from './sdk';
+
+export * from './span-decorator';


h: In the index file, let's be specific about what we export. This is to avoid accidentally widening the API surface.

lforst · 2024-07-04T08:58:34Z

+ const originalMethod = descriptor.value as (...args: any[]) => Promise<any>;
+
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ descriptor.value = async function (...args: any[]) {


h: We should not modify the return value. Currently we are wrapping all non-promise return values in a Promise. To fix this we can just remove all async and await keywords and everything will work perfectly fine.

lforst · 2024-07-04T08:59:30Z

+ expect.objectContaining({
+ span_id: expect.any(String),
+ trace_id: expect.any(String),
+ data: expect.any(Object),


m: Let's assert on the sentry.origin and sentry.source attibutes in the data object.

I explicitly assert the data object now, there is no sentry.source property though

lforst · 2024-07-04T09:00:15Z

+ @SentryTraced('wait function')
+ async wait() {
+ return new Promise(resolve => setTimeout(resolve, 500));
+ }


l: We could add a second method that is not async and assert on it in the test.

Do you mean a second non-async function and then check whether the transaction includes spans for both?

nicohrubec added 6 commits July 2, 2024 13:13

Add span decorator to nestjs
dd2ef7e

Set op for decorator traces
7d802e0

Allow users to define op name
326969b

Add e2e test
9afd76f

Lint
cef0a49

Update README
b297c41

nicohrubec marked this pull request as ready for review July 3, 2024 13:55

nicohrubec requested review from andreiborza, lforst and mydea July 3, 2024 13:56

.
2b4c8b1

mydea reviewed Jul 3, 2024
View reviewed changes

nicohrubec added 5 commits July 3, 2024 16:00

Lint
b344930

Merge branch 'develop' into nh/nestjs-span-decorator
dff2bef

Rename decorator
f4c9618

.
059705a

Update README
d38d712

lforst reviewed Jul 4, 2024
View reviewed changes

nicohrubec mentioned this pull request Jul 4, 2024
NestJS SDK #12504
Closed

nicohrubec linked an issue Jul 4, 2024 that may be closed by this pull request
SentryTraced() decorator to get spans for arbitrary functions #12752
Closed

nicohrubec added 7 commits July 4, 2024 12:58

Explicit exports in index file
30f1dc3

Do not capture exceptions thrown in decorator in sentry
394b324

Explicitly check data in test
4d16c2b

rename test route
6b588cf

Add sync span decorator test
322c645

Fix e2e tests
17739bb

Check return value in async test
e4ffdfd

nicohrubec requested a review from lforst July 4, 2024 12:46

lforst approved these changes Jul 4, 2024
View reviewed changes

nicohrubec merged commit 41d946e into developJul 4, 2024

nicohrubec deleted the nh/nestjs-span-decorator branch July 4, 2024 13:50

GitSquared mentioned this pull request Jul 11, 2024
fix(nestjs): do not make SentryTraced() decorated functions async #12879
Merged
2 tasks

q1blue mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.15.0 https-quantumblockchainai-atlassian-net/ossinsight#783
Open

amykapernick mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.15.0 amykapernick/wedding#11
Open

aam-digital-ci mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/browser from 8.13.0 to 8.15.0 Aam-Digital/ndb-core#2482
Closed

nicohrubec self-assigned this Jul 30, 2024

This was referenced Jul 30, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.16.0 https-quantumblockchainai-atlassian-net/ossinsight#787
Open
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.17.0 https-quantumblockchainai-atlassian-net/ossinsight#791
Open

amykapernick mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.17.0 amykapernick/wedding#12
Open

wkylin mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.17.0 wkylin/pro-react-admin#370
Closed

q1blue mentioned this pull request Aug 6, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.18.0 https-quantumblockchainai-atlassian-net/ossinsight#799
Open

wkylin mentioned this pull request Aug 7, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.18.0 wkylin/pro-react-admin#371
Merged

nicohrubec added 6 commits July 2, 2024 13:13

Add span decorator to nestjs
dd2ef7e

Set op for decorator traces
7d802e0

Allow users to define op name
326969b

Add e2e test
9afd76f

Lint
cef0a49

Update README
b297c41

nicohrubec marked this pull request as ready for review July 3, 2024 13:55

nicohrubec requested review from andreiborza, lforst and mydea July 3, 2024 13:56

.
2b4c8b1

mydea reviewed Jul 3, 2024
View reviewed changes

nicohrubec added 5 commits July 3, 2024 16:00

Lint
b344930

Merge branch 'develop' into nh/nestjs-span-decorator
dff2bef

Rename decorator
f4c9618

.
059705a

Update README
d38d712

lforst reviewed Jul 4, 2024
View reviewed changes

nicohrubec mentioned this pull request Jul 4, 2024
NestJS SDK #12504
Closed

nicohrubec linked an issue Jul 4, 2024 that may be closed by this pull request
SentryTraced() decorator to get spans for arbitrary functions #12752
Closed

nicohrubec added 7 commits July 4, 2024 12:58

Explicit exports in index file
30f1dc3

Do not capture exceptions thrown in decorator in sentry
394b324

Explicitly check data in test
4d16c2b

rename test route
6b588cf

Add sync span decorator test
322c645

Fix e2e tests
17739bb

Check return value in async test
e4ffdfd

nicohrubec requested a review from lforst July 4, 2024 12:46

lforst approved these changes Jul 4, 2024
View reviewed changes

nicohrubec merged commit 41d946e into developJul 4, 2024

nicohrubec deleted the nh/nestjs-span-decorator branch July 4, 2024 13:50

GitSquared mentioned this pull request Jul 11, 2024
fix(nestjs): do not make SentryTraced() decorated functions async #12879
Merged
2 tasks

q1blue mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.15.0 https-quantumblockchainai-atlassian-net/ossinsight#783
Open

amykapernick mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.15.0 amykapernick/wedding#11
Open

aam-digital-ci mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/browser from 8.13.0 to 8.15.0 Aam-Digital/ndb-core#2482
Closed

nicohrubec self-assigned this Jul 30, 2024

This was referenced Jul 30, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.16.0 https-quantumblockchainai-atlassian-net/ossinsight#787
Open
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.17.0 https-quantumblockchainai-atlassian-net/ossinsight#791
Open

amykapernick mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.17.0 amykapernick/wedding#12
Open

wkylin mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.17.0 wkylin/pro-react-admin#370
Closed

q1blue mentioned this pull request Aug 6, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.18.0 https-quantumblockchainai-atlassian-net/ossinsight#799
Open

wkylin mentioned this pull request Aug 7, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.18.0 wkylin/pro-react-admin#371
Merged

nicohrubec added 6 commits July 2, 2024 13:13

Add span decorator to nestjs
dd2ef7e

Set op for decorator traces
7d802e0

Allow users to define op name
326969b

Add e2e test
9afd76f

Lint
cef0a49

Update README
b297c41

nicohrubec marked this pull request as ready for review July 3, 2024 13:55

nicohrubec requested review from andreiborza, lforst and mydea July 3, 2024 13:56

.
2b4c8b1

mydea reviewed Jul 3, 2024
View reviewed changes

nicohrubec added 5 commits July 3, 2024 16:00

Lint
b344930

Merge branch 'develop' into nh/nestjs-span-decorator
dff2bef

Rename decorator
f4c9618

.
059705a

Update README
d38d712

lforst reviewed Jul 4, 2024
View reviewed changes

nicohrubec mentioned this pull request Jul 4, 2024
NestJS SDK #12504
Closed

nicohrubec linked an issue Jul 4, 2024 that may be closed by this pull request
SentryTraced() decorator to get spans for arbitrary functions #12752
Closed

nicohrubec added 7 commits July 4, 2024 12:58

Explicit exports in index file
30f1dc3

Do not capture exceptions thrown in decorator in sentry
394b324

Explicitly check data in test
4d16c2b

rename test route
6b588cf

Add sync span decorator test
322c645

Fix e2e tests
17739bb

Check return value in async test
e4ffdfd

nicohrubec requested a review from lforst July 4, 2024 12:46

lforst approved these changes Jul 4, 2024
View reviewed changes

nicohrubec merged commit 41d946e into developJul 4, 2024

nicohrubec deleted the nh/nestjs-span-decorator branch July 4, 2024 13:50

GitSquared mentioned this pull request Jul 11, 2024
fix(nestjs): do not make SentryTraced() decorated functions async #12879
Merged
2 tasks

q1blue mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.15.0 https-quantumblockchainai-atlassian-net/ossinsight#783
Open

amykapernick mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.15.0 amykapernick/wedding#11
Open

aam-digital-ci mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/browser from 8.13.0 to 8.15.0 Aam-Digital/ndb-core#2482
Closed

nicohrubec self-assigned this Jul 30, 2024

This was referenced Jul 30, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.16.0 https-quantumblockchainai-atlassian-net/ossinsight#787
Open
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.17.0 https-quantumblockchainai-atlassian-net/ossinsight#791
Open

amykapernick mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.17.0 amykapernick/wedding#12
Open

wkylin mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.17.0 wkylin/pro-react-admin#370
Closed

q1blue mentioned this pull request Aug 6, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.18.0 https-quantumblockchainai-atlassian-net/ossinsight#799
Open

wkylin mentioned this pull request Aug 7, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.18.0 wkylin/pro-react-admin#371
Merged

nicohrubec added 6 commits July 2, 2024 13:13

Add span decorator to nestjs
dd2ef7e

Set op for decorator traces
7d802e0

Allow users to define op name
326969b

Add e2e test
9afd76f

Lint
cef0a49

Update README
b297c41

nicohrubec marked this pull request as ready for review July 3, 2024 13:55

nicohrubec requested review from andreiborza, lforst and mydea July 3, 2024 13:56

.
2b4c8b1

mydea reviewed Jul 3, 2024
View reviewed changes

nicohrubec added 5 commits July 3, 2024 16:00

Lint
b344930

Merge branch 'develop' into nh/nestjs-span-decorator
dff2bef

Rename decorator
f4c9618

.
059705a

Update README
d38d712

lforst reviewed Jul 4, 2024
View reviewed changes

nicohrubec mentioned this pull request Jul 4, 2024
NestJS SDK #12504
Closed

nicohrubec linked an issue Jul 4, 2024 that may be closed by this pull request
SentryTraced() decorator to get spans for arbitrary functions #12752
Closed

nicohrubec added 7 commits July 4, 2024 12:58

Explicit exports in index file
30f1dc3

Do not capture exceptions thrown in decorator in sentry
394b324

Explicitly check data in test
4d16c2b

rename test route
6b588cf

Add sync span decorator test
322c645

Fix e2e tests
17739bb

Check return value in async test
e4ffdfd

nicohrubec requested a review from lforst July 4, 2024 12:46

lforst approved these changes Jul 4, 2024
View reviewed changes

nicohrubec merged commit 41d946e into developJul 4, 2024

nicohrubec deleted the nh/nestjs-span-decorator branch July 4, 2024 13:50

GitSquared mentioned this pull request Jul 11, 2024
fix(nestjs): do not make SentryTraced() decorated functions async #12879
Merged
2 tasks

q1blue mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.15.0 https-quantumblockchainai-atlassian-net/ossinsight#783
Open

amykapernick mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.15.0 amykapernick/wedding#11
Open

aam-digital-ci mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/browser from 8.13.0 to 8.15.0 Aam-Digital/ndb-core#2482
Closed

nicohrubec self-assigned this Jul 30, 2024

This was referenced Jul 30, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.16.0 https-quantumblockchainai-atlassian-net/ossinsight#787
Open
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.17.0 https-quantumblockchainai-atlassian-net/ossinsight#791
Open

amykapernick mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.17.0 amykapernick/wedding#12
Open

wkylin mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.17.0 wkylin/pro-react-admin#370
Closed

q1blue mentioned this pull request Aug 6, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.18.0 https-quantumblockchainai-atlassian-net/ossinsight#799
Open

wkylin mentioned this pull request Aug 7, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.18.0 wkylin/pro-react-admin#371
Merged

nicohrubec added 6 commits July 2, 2024 13:13

Add span decorator to nestjs
dd2ef7e

Set op for decorator traces
7d802e0

Allow users to define op name
326969b

Add e2e test
9afd76f

Lint
cef0a49

Update README
b297c41

nicohrubec marked this pull request as ready for review July 3, 2024 13:55

nicohrubec requested review from andreiborza, lforst and mydea July 3, 2024 13:56

.
2b4c8b1

mydea reviewed Jul 3, 2024
View reviewed changes

nicohrubec added 5 commits July 3, 2024 16:00

Lint
b344930

Merge branch 'develop' into nh/nestjs-span-decorator
dff2bef

Rename decorator
f4c9618

.
059705a

Update README
d38d712

lforst reviewed Jul 4, 2024
View reviewed changes

nicohrubec mentioned this pull request Jul 4, 2024
NestJS SDK #12504
Closed

nicohrubec linked an issue Jul 4, 2024 that may be closed by this pull request
SentryTraced() decorator to get spans for arbitrary functions #12752
Closed

nicohrubec added 7 commits July 4, 2024 12:58

Explicit exports in index file
30f1dc3

Do not capture exceptions thrown in decorator in sentry
394b324

Explicitly check data in test
4d16c2b

rename test route
6b588cf

Add sync span decorator test
322c645

Fix e2e tests
17739bb

Check return value in async test
e4ffdfd

nicohrubec requested a review from lforst July 4, 2024 12:46

lforst approved these changes Jul 4, 2024
View reviewed changes

nicohrubec merged commit 41d946e into developJul 4, 2024

nicohrubec deleted the nh/nestjs-span-decorator branch July 4, 2024 13:50

GitSquared mentioned this pull request Jul 11, 2024
fix(nestjs): do not make SentryTraced() decorated functions async #12879
Merged
2 tasks

q1blue mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.15.0 https-quantumblockchainai-atlassian-net/ossinsight#783
Open

amykapernick mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.15.0 amykapernick/wedding#11
Open

aam-digital-ci mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/browser from 8.13.0 to 8.15.0 Aam-Digital/ndb-core#2482
Closed

nicohrubec self-assigned this Jul 30, 2024

This was referenced Jul 30, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.16.0 https-quantumblockchainai-atlassian-net/ossinsight#787
Open
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.17.0 https-quantumblockchainai-atlassian-net/ossinsight#791
Open

amykapernick mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.17.0 amykapernick/wedding#12
Open

wkylin mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.17.0 wkylin/pro-react-admin#370
Closed

q1blue mentioned this pull request Aug 6, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.18.0 https-quantumblockchainai-atlassian-net/ossinsight#799
Open

wkylin mentioned this pull request Aug 7, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.18.0 wkylin/pro-react-admin#371
Merged

nicohrubec added 6 commits July 2, 2024 13:13

Add span decorator to nestjs
dd2ef7e

Set op for decorator traces
7d802e0

Allow users to define op name
326969b

Add e2e test
9afd76f

Lint
cef0a49

Update README
b297c41

nicohrubec marked this pull request as ready for review July 3, 2024 13:55

nicohrubec requested review from andreiborza, lforst and mydea July 3, 2024 13:56

.
2b4c8b1

mydea reviewed Jul 3, 2024
View reviewed changes

nicohrubec added 5 commits July 3, 2024 16:00

Lint
b344930

Merge branch 'develop' into nh/nestjs-span-decorator
dff2bef

Rename decorator
f4c9618

.
059705a

Update README
d38d712

lforst reviewed Jul 4, 2024
View reviewed changes

nicohrubec mentioned this pull request Jul 4, 2024
NestJS SDK #12504
Closed

nicohrubec linked an issue Jul 4, 2024 that may be closed by this pull request
SentryTraced() decorator to get spans for arbitrary functions #12752
Closed

nicohrubec added 7 commits July 4, 2024 12:58

Explicit exports in index file
30f1dc3

Do not capture exceptions thrown in decorator in sentry
394b324

Explicitly check data in test
4d16c2b

rename test route
6b588cf

Add sync span decorator test
322c645

Fix e2e tests
17739bb

Check return value in async test
e4ffdfd

nicohrubec requested a review from lforst July 4, 2024 12:46

lforst approved these changes Jul 4, 2024
View reviewed changes

nicohrubec merged commit 41d946e into developJul 4, 2024

nicohrubec deleted the nh/nestjs-span-decorator branch July 4, 2024 13:50

GitSquared mentioned this pull request Jul 11, 2024
fix(nestjs): do not make SentryTraced() decorated functions async #12879
Merged
2 tasks

q1blue mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.15.0 https-quantumblockchainai-atlassian-net/ossinsight#783
Open

amykapernick mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.15.0 amykapernick/wedding#11
Open

aam-digital-ci mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/browser from 8.13.0 to 8.15.0 Aam-Digital/ndb-core#2482
Closed

nicohrubec self-assigned this Jul 30, 2024

This was referenced Jul 30, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.16.0 https-quantumblockchainai-atlassian-net/ossinsight#787
Open
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.17.0 https-quantumblockchainai-atlassian-net/ossinsight#791
Open

amykapernick mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.17.0 amykapernick/wedding#12
Open

wkylin mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.17.0 wkylin/pro-react-admin#370
Closed

q1blue mentioned this pull request Aug 6, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.18.0 https-quantumblockchainai-atlassian-net/ossinsight#799
Open

wkylin mentioned this pull request Aug 7, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.18.0 wkylin/pro-react-admin#371
Merged

nicohrubec added 6 commits July 2, 2024 13:13

Add span decorator to nestjs
dd2ef7e

Set op for decorator traces
7d802e0

Allow users to define op name
326969b

Add e2e test
9afd76f

Lint
cef0a49

Update README
b297c41

nicohrubec marked this pull request as ready for review July 3, 2024 13:55

nicohrubec requested review from andreiborza, lforst and mydea July 3, 2024 13:56

.
2b4c8b1

mydea reviewed Jul 3, 2024
View reviewed changes

nicohrubec added 5 commits July 3, 2024 16:00

Lint
b344930

Merge branch 'develop' into nh/nestjs-span-decorator
dff2bef

Rename decorator
f4c9618

.
059705a

Update README
d38d712

lforst reviewed Jul 4, 2024
View reviewed changes

nicohrubec mentioned this pull request Jul 4, 2024
NestJS SDK #12504
Closed

nicohrubec linked an issue Jul 4, 2024 that may be closed by this pull request
SentryTraced() decorator to get spans for arbitrary functions #12752
Closed

nicohrubec added 7 commits July 4, 2024 12:58

Explicit exports in index file
30f1dc3

Do not capture exceptions thrown in decorator in sentry
394b324

Explicitly check data in test
4d16c2b

rename test route
6b588cf

Add sync span decorator test
322c645

Fix e2e tests
17739bb

Check return value in async test
e4ffdfd

nicohrubec requested a review from lforst July 4, 2024 12:46

lforst approved these changes Jul 4, 2024
View reviewed changes

nicohrubec merged commit 41d946e into developJul 4, 2024

nicohrubec deleted the nh/nestjs-span-decorator branch July 4, 2024 13:50

GitSquared mentioned this pull request Jul 11, 2024
fix(nestjs): do not make SentryTraced() decorated functions async #12879
Merged
2 tasks

q1blue mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.15.0 https-quantumblockchainai-atlassian-net/ossinsight#783
Open

amykapernick mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.15.0 amykapernick/wedding#11
Open

aam-digital-ci mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/browser from 8.13.0 to 8.15.0 Aam-Digital/ndb-core#2482
Closed

nicohrubec self-assigned this Jul 30, 2024

This was referenced Jul 30, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.16.0 https-quantumblockchainai-atlassian-net/ossinsight#787
Open
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.17.0 https-quantumblockchainai-atlassian-net/ossinsight#791
Open

amykapernick mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.17.0 amykapernick/wedding#12
Open

wkylin mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.17.0 wkylin/pro-react-admin#370
Closed

q1blue mentioned this pull request Aug 6, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.18.0 https-quantumblockchainai-atlassian-net/ossinsight#799
Open

wkylin mentioned this pull request Aug 7, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.18.0 wkylin/pro-react-admin#371
Merged

nicohrubec added 6 commits July 2, 2024 13:13

Add span decorator to nestjs
dd2ef7e

Set op for decorator traces
7d802e0

Allow users to define op name
326969b

Add e2e test
9afd76f

Lint
cef0a49

Update README
b297c41

nicohrubec marked this pull request as ready for review July 3, 2024 13:55

nicohrubec requested review from andreiborza, lforst and mydea July 3, 2024 13:56

.
2b4c8b1

mydea reviewed Jul 3, 2024
View reviewed changes

nicohrubec added 5 commits July 3, 2024 16:00

Lint
b344930

Merge branch 'develop' into nh/nestjs-span-decorator
dff2bef

Rename decorator
f4c9618

.
059705a

Update README
d38d712

lforst reviewed Jul 4, 2024
View reviewed changes

nicohrubec mentioned this pull request Jul 4, 2024
NestJS SDK #12504
Closed

nicohrubec linked an issue Jul 4, 2024 that may be closed by this pull request
SentryTraced() decorator to get spans for arbitrary functions #12752
Closed

nicohrubec added 7 commits July 4, 2024 12:58

Explicit exports in index file
30f1dc3

Do not capture exceptions thrown in decorator in sentry
394b324

Explicitly check data in test
4d16c2b

rename test route
6b588cf

Add sync span decorator test
322c645

Fix e2e tests
17739bb

Check return value in async test
e4ffdfd

nicohrubec requested a review from lforst July 4, 2024 12:46

lforst approved these changes Jul 4, 2024
View reviewed changes

nicohrubec merged commit 41d946e into developJul 4, 2024

nicohrubec deleted the nh/nestjs-span-decorator branch July 4, 2024 13:50

GitSquared mentioned this pull request Jul 11, 2024
fix(nestjs): do not make SentryTraced() decorated functions async #12879
Merged
2 tasks

q1blue mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.15.0 https-quantumblockchainai-atlassian-net/ossinsight#783
Open

amykapernick mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.15.0 amykapernick/wedding#11
Open

aam-digital-ci mentioned this pull request Jul 27, 2024
[Snyk] Upgrade @sentry/browser from 8.13.0 to 8.15.0 Aam-Digital/ndb-core#2482
Closed

nicohrubec self-assigned this Jul 30, 2024

This was referenced Jul 30, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.16.0 https-quantumblockchainai-atlassian-net/ossinsight#787
Open
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.17.0 https-quantumblockchainai-atlassian-net/ossinsight#791
Open

amykapernick mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/nextjs from 8.14.0 to 8.17.0 amykapernick/wedding#12
Open

wkylin mentioned this pull request Aug 1, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.17.0 wkylin/pro-react-admin#370
Closed

q1blue mentioned this pull request Aug 6, 2024
[Snyk] Upgrade @sentry/react from 7.16.0 to 8.18.0 https-quantumblockchainai-atlassian-net/ossinsight#799
Open

wkylin mentioned this pull request Aug 7, 2024
[Snyk] Upgrade @sentry/react from 8.15.0 to 8.18.0 wkylin/pro-react-admin#371
Merged


		## Span Decorator

		Use the @GetSentrySpan() decorator to gain additional performance insights for any function within your NestJS application.


		export { init } from './sdk';

		export * from './span-decorator';

Uh oh!

Uh oh!

Conversation

nicohrubec commented Jul 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lforst left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

nicohrubec commented Jul 2, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lforst left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicohrubec commented Jul 2, 2024•
edited
Loading

nicohrubec commented Jul 2, 2024•
edited
Loading

nicohrubec commented Jul 2, 2024•
edited
Loading