fix(feedback): Add missing h import in ScreenshotEditor (#12713) - #12784

Merged
ryan953 merged 2 commits into
developfrom
ab/fix-feedback-screenshot-button
Jul 8, 2024
Merged

fix(feedback): Add missing h import in ScreenshotEditor (#12713)#12784
ryan953 merged 2 commits into
developfrom
ab/fix-feedback-screenshot-button

Conversation

@andreiborza

@andreiborzaandreiborza commented Jul 5, 2024•
edited
Loading

Copy link
Copy Markdown
Member

This broke the Add a screenshot button on the user feedback, see #12713

This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.

@andreiborza
andreiborza requested a review from a team as a code ownerJuly 5, 2024 11:42
@github-actions

github-actionsBot commented Jul 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
@sentry/browser22.28 KB (0%)
@sentry/browser (incl. Tracing)33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.84 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.71 KB (-0.03% 🔽)
@sentry/browser (incl. metrics)26.57 KB (0%)
@sentry/browser (incl. Feedback)38.93 KB (-0.02% 🔽)
@sentry/browser (incl. sendFeedback)26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.52 KB (0%)
@sentry/react25.02 KB (0%)
@sentry/react (incl. Tracing)36.46 KB (0%)
@sentry/vue26.39 KB (0%)
@sentry/vue (incl. Tracing)35.29 KB (0%)
@sentry/svelte22.41 KB (0%)
CDN Bundle23.5 KB (0%)
CDN Bundle (incl. Tracing)35.19 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.48 KB (0%)
CDN Bundle - uncompressed68.97 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.98 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.38 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227.09 KB (0%)
@sentry/nextjs (client)36.35 KB (0%)
@sentry/sveltekit (client)34.07 KB (0%)
@sentry/node130.84 KB (0%)
@sentry/node - without tracing91.86 KB (0%)
@sentry/aws-serverless117.03 KB (0%)

Lms24
Lms24 reviewed Jul 5, 2024
View reviewed changes
Comment threadpackages/feedback/src/screenshot/components/ScreenshotEditor.tsx
Comment on lines +4 to +5
// biome-ignore lint/nursery/noUnusedImports: reason
import { h } from 'preact'; // eslint-disable-line @typescript-eslint/no-unused-vars

@Lms24Lms24Jul 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a reason/additional comment as to why we need this ignore? It looks like h is destructured but unused further below which doesn't look like an unused import on first glance 🤔 is this a biome bug?

@Lms24Lms24Jul 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, I'm off here, this shouldn't require an import 😅
So I guess there's some side effect we need from importing h?

@andreiborzaandreiborzaJul 5, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with preact, but I'm guessing it's a similar factory to JSX createElement? Just taking a wild guess.

This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.

Maybe we should completely revert the injection too, but I'm waiting on @ryan953 for confirmation before going ahead here.

@Lms24Lms24Jul 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh alright sounds good to me! Sorry, I don't have much context around feedback or Preact and was a bit confused but makes sense!

@c298leec298leeJul 5, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes h is needed because it's a similar factory to JSX createElement, it's needed anytime JSX syntax is used

@andreiborza
andreiborza requested a review from ryan953July 5, 2024 11:56
@c298lee

c298lee commented Jul 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

I think we may have accidentally removed h in #12535 because the screenshot button was breaking when using feedbackAsyncIntegration, but if the screenshot button works with both feedbackSyncIntegration and feedbackAsyncIntegration now, then it looks good to me!

@andreiborzaandreiborza mentioned this pull request Jul 8, 2024
Closed
3 tasks
@ryan953ryan953 mentioned this pull request Jul 8, 2024
Closed
ryan953
ryan953 approved these changes Jul 8, 2024
View reviewed changes

@ryan953ryan953 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Lets get this merged!

@ryan953

ryan953 commented Jul 8, 2024

Copy link
Copy Markdown
Member

Looks like we need #12793. I'll merge the develop branch in

@ryan953
ryan953 merged commit 3883517 into developJul 8, 2024
@ryan953
ryan953 deleted the ab/fix-feedback-screenshot-button branch July 8, 2024 23:00
@ryan953ryan953 mentioned this pull request Jul 9, 2024
Merged
andreiborza pushed a commit that referenced this pull request Jul 9, 2024
@ryan953
ref(feedback): Let CropCorner inherit the existing h prop (#12814)
aefbfaa
I noticed this after
#12784, but the
`<CropCorner>` wasn't inside the `ScreenshotEditorFactory()` function.
So of course it wasn't getting access to the `h` ref that is passed in.
That variable is what the `<div>` gets transpiled into -> it becomes
`h.createElement('div')`.
So what i'm doing is moving `CropCorner` into a `CropCornerFactory` so
we can pass `h` in and hopefully not have the extra `import .. from
'preact';` in the 2nd bundle.
Related to #12535
This was referenced Jul 30, 2024
Open
Open
@amykapernickamykapernick mentioned this pull request Aug 1, 2024
Open
@wkylinwkylin mentioned this pull request Aug 1, 2024
Closed
@q1blueq1blue mentioned this pull request Aug 6, 2024
Open
@wkylinwkylin mentioned this pull request Aug 7, 2024
Merged
This was referenced Aug 9, 2024
Open
Open
@q1blueq1blue mentioned this pull request Aug 9, 2024
Open
@FengShangWuQiFengShangWuQi mentioned this pull request Aug 11, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24Lms24Lms24 left review comments
@ryan953ryan953ryan953 approved these changes
@chargomechargomechargome approved these changes
@mydeamydeaAwaiting requested review from mydea
+1 more reviewer
@c298leec298leec298lee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andreiborza@c298lee@ryan953@Lms24@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(feedback): Add missing h import in ScreenshotEditor (#12713) - #12784
Merged
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Jul 8, 2024
Merged
fix(feedback): Add missing h import in ScreenshotEditor (#12713)#12784
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Conversation
@andreiborza
@andreiborzaandreiborza
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This broke the Add a screenshot button on the user feedback, see #12713
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
@andreiborza
andreiborza
requested a review
from a team
as a code ownerJuly 5, 2024 11:42
@github-actions
github-actionsBot
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.28 KB (0%)
@sentry/browser (incl. Tracing)33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.84 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.71 KB (-0.03% 🔽)
@sentry/browser (incl. metrics)26.57 KB (0%)
@sentry/browser (incl. Feedback)38.93 KB (-0.02% 🔽)
@sentry/browser (incl. sendFeedback)26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.52 KB (0%)
@sentry/react25.02 KB (0%)
@sentry/react (incl. Tracing)36.46 KB (0%)
@sentry/vue26.39 KB (0%)
@sentry/vue (incl. Tracing)35.29 KB (0%)
@sentry/svelte22.41 KB (0%)
CDN Bundle23.5 KB (0%)
CDN Bundle (incl. Tracing)35.19 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.48 KB (0%)
CDN Bundle - uncompressed68.97 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.98 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.38 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227.09 KB (0%)
@sentry/nextjs (client)36.35 KB (0%)
@sentry/sveltekit (client)34.07 KB (0%)
@sentry/node130.84 KB (0%)
@sentry/node - without tracing91.86 KB (0%)
@sentry/aws-serverless117.03 KB (0%)
Lms24
Lms24
reviewed
Jul 5, 2024
View reviewed changes
Comment threadpackages/feedback/src/screenshot/components/ScreenshotEditor.tsx

Comment on lines

+4
 to 
+5

// biome-ignore lint/nursery/noUnusedImports: reason
import { h } from 'preact'; // eslint-disable-line @typescript-eslint/no-unused-vars
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a reason/additional comment as to why we need this ignore? It looks like h is destructured but unused further below which doesn't look like an unused import on first glance 🤔 is this a biome bug?
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, I'm off here, this shouldn't require an import 😅

So I guess there's some side effect we need from importing h?
@andreiborzaandreiborzaJul 5, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with preact, but I'm guessing it's a similar factory to JSX createElement? Just taking a wild guess.
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
Maybe we should completely revert the injection too, but I'm waiting on @ryan953 for confirmation before going ahead here.
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh alright sounds good to me! Sorry, I don't have much context around feedback or Preact and was a bit confused but makes sense!
@c298leec298leeJul 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes h is needed because it's a similar factory to JSX createElement, it's needed anytime JSX syntax is used
@andreiborza
andreiborza
requested a review
from ryan953July 5, 2024 11:56
@c298lee
c298lee
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I think we may have accidentally removed h in #12535 because the screenshot button was breaking when using feedbackAsyncIntegration, but if the screenshot button works with both feedbackSyncIntegration and feedbackAsyncIntegration now, then it looks good to me!
@andreiborzaandreiborza
mentioned this pull request
Jul 8, 2024

Closed

3 tasks
@ryan953ryan953
mentioned this pull request
Jul 8, 2024

Closed

ryan953
ryan953
approved these changes
Jul 8, 2024
View reviewed changes
@ryan953ryan953
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Lets get this merged!
@ryan953
ryan953
commented
Jul 8, 2024

Copy link


Copy Markdown

Member
Looks like we need #12793. I'll merge the develop branch in
@ryan953
ryan953
merged commit 3883517
into
developJul 8, 2024
@ryan953
ryan953
deleted the

ab/fix-feedback-screenshot-button

branch
July 8, 2024 23:00
@ryan953ryan953
mentioned this pull request
Jul 9, 2024
 Merged

andreiborza pushed a commit
that referenced
this pull request
Jul 9, 2024
@ryan953
ref(feedback): Let CropCorner inherit the existing h prop (#12814)
aefbfaa
I noticed this after
#12784, but the
`<CropCorner>` wasn't inside the `ScreenshotEditorFactory()` function.
So of course it wasn't getting access to the `h` ref that is passed in.
That variable is what the `<div>` gets transpiled into -> it becomes
`h.createElement('div')`.
So what i'm doing is moving `CropCorner` into a `CropCornerFactory` so
we can pass `h` in and hopefully not have the extra `import .. from
'preact';` in the 2nd bundle.
Related to #12535

This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged


This was referenced Aug 9, 2024
 Open

 Open

@q1blueq1blue
mentioned this pull request
Aug 9, 2024
 Open

@FengShangWuQiFengShangWuQi
mentioned this pull request
Aug 11, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 left review comments
@ryan953ryan953ryan953 approved these changes
@chargomechargomechargome approved these changes
@mydeamydeaAwaiting requested review from mydea

+1 more reviewer

@c298leec298leec298lee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andreiborza@c298lee@ryan953@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(feedback): Add missing h import in ScreenshotEditor (#12713) - #12784
Merged
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Jul 8, 2024
Merged
fix(feedback): Add missing h import in ScreenshotEditor (#12713)#12784
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Conversation
@andreiborza
@andreiborzaandreiborza
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This broke the Add a screenshot button on the user feedback, see #12713
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
@andreiborza
andreiborza
requested a review
from a team
as a code ownerJuly 5, 2024 11:42
@github-actions
github-actionsBot
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.28 KB (0%)
@sentry/browser (incl. Tracing)33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.84 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.71 KB (-0.03% 🔽)
@sentry/browser (incl. metrics)26.57 KB (0%)
@sentry/browser (incl. Feedback)38.93 KB (-0.02% 🔽)
@sentry/browser (incl. sendFeedback)26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.52 KB (0%)
@sentry/react25.02 KB (0%)
@sentry/react (incl. Tracing)36.46 KB (0%)
@sentry/vue26.39 KB (0%)
@sentry/vue (incl. Tracing)35.29 KB (0%)
@sentry/svelte22.41 KB (0%)
CDN Bundle23.5 KB (0%)
CDN Bundle (incl. Tracing)35.19 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.48 KB (0%)
CDN Bundle - uncompressed68.97 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.98 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.38 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227.09 KB (0%)
@sentry/nextjs (client)36.35 KB (0%)
@sentry/sveltekit (client)34.07 KB (0%)
@sentry/node130.84 KB (0%)
@sentry/node - without tracing91.86 KB (0%)
@sentry/aws-serverless117.03 KB (0%)
Lms24
Lms24
reviewed
Jul 5, 2024
View reviewed changes
Comment threadpackages/feedback/src/screenshot/components/ScreenshotEditor.tsx

Comment on lines

+4
 to 
+5

// biome-ignore lint/nursery/noUnusedImports: reason
import { h } from 'preact'; // eslint-disable-line @typescript-eslint/no-unused-vars
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a reason/additional comment as to why we need this ignore? It looks like h is destructured but unused further below which doesn't look like an unused import on first glance 🤔 is this a biome bug?
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, I'm off here, this shouldn't require an import 😅

So I guess there's some side effect we need from importing h?
@andreiborzaandreiborzaJul 5, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with preact, but I'm guessing it's a similar factory to JSX createElement? Just taking a wild guess.
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
Maybe we should completely revert the injection too, but I'm waiting on @ryan953 for confirmation before going ahead here.
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh alright sounds good to me! Sorry, I don't have much context around feedback or Preact and was a bit confused but makes sense!
@c298leec298leeJul 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes h is needed because it's a similar factory to JSX createElement, it's needed anytime JSX syntax is used
@andreiborza
andreiborza
requested a review
from ryan953July 5, 2024 11:56
@c298lee
c298lee
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I think we may have accidentally removed h in #12535 because the screenshot button was breaking when using feedbackAsyncIntegration, but if the screenshot button works with both feedbackSyncIntegration and feedbackAsyncIntegration now, then it looks good to me!
@andreiborzaandreiborza
mentioned this pull request
Jul 8, 2024

Closed

3 tasks
@ryan953ryan953
mentioned this pull request
Jul 8, 2024

Closed

ryan953
ryan953
approved these changes
Jul 8, 2024
View reviewed changes
@ryan953ryan953
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Lets get this merged!
@ryan953
ryan953
commented
Jul 8, 2024

Copy link


Copy Markdown

Member
Looks like we need #12793. I'll merge the develop branch in
@ryan953
ryan953
merged commit 3883517
into
developJul 8, 2024
@ryan953
ryan953
deleted the

ab/fix-feedback-screenshot-button

branch
July 8, 2024 23:00
@ryan953ryan953
mentioned this pull request
Jul 9, 2024
 Merged

andreiborza pushed a commit
that referenced
this pull request
Jul 9, 2024
@ryan953
ref(feedback): Let CropCorner inherit the existing h prop (#12814)
aefbfaa
I noticed this after
#12784, but the
`<CropCorner>` wasn't inside the `ScreenshotEditorFactory()` function.
So of course it wasn't getting access to the `h` ref that is passed in.
That variable is what the `<div>` gets transpiled into -> it becomes
`h.createElement('div')`.
So what i'm doing is moving `CropCorner` into a `CropCornerFactory` so
we can pass `h` in and hopefully not have the extra `import .. from
'preact';` in the 2nd bundle.
Related to #12535

This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged


This was referenced Aug 9, 2024
 Open

 Open

@q1blueq1blue
mentioned this pull request
Aug 9, 2024
 Open

@FengShangWuQiFengShangWuQi
mentioned this pull request
Aug 11, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 left review comments
@ryan953ryan953ryan953 approved these changes
@chargomechargomechargome approved these changes
@mydeamydeaAwaiting requested review from mydea

+1 more reviewer

@c298leec298leec298lee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andreiborza@c298lee@ryan953@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(feedback): Add missing h import in ScreenshotEditor (#12713) - #12784
Merged
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Jul 8, 2024
Merged
fix(feedback): Add missing h import in ScreenshotEditor (#12713)#12784
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Conversation
@andreiborza
@andreiborzaandreiborza
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This broke the Add a screenshot button on the user feedback, see #12713
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
@andreiborza
andreiborza
requested a review
from a team
as a code ownerJuly 5, 2024 11:42
@github-actions
github-actionsBot
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.28 KB (0%)
@sentry/browser (incl. Tracing)33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.84 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.71 KB (-0.03% 🔽)
@sentry/browser (incl. metrics)26.57 KB (0%)
@sentry/browser (incl. Feedback)38.93 KB (-0.02% 🔽)
@sentry/browser (incl. sendFeedback)26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.52 KB (0%)
@sentry/react25.02 KB (0%)
@sentry/react (incl. Tracing)36.46 KB (0%)
@sentry/vue26.39 KB (0%)
@sentry/vue (incl. Tracing)35.29 KB (0%)
@sentry/svelte22.41 KB (0%)
CDN Bundle23.5 KB (0%)
CDN Bundle (incl. Tracing)35.19 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.48 KB (0%)
CDN Bundle - uncompressed68.97 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.98 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.38 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227.09 KB (0%)
@sentry/nextjs (client)36.35 KB (0%)
@sentry/sveltekit (client)34.07 KB (0%)
@sentry/node130.84 KB (0%)
@sentry/node - without tracing91.86 KB (0%)
@sentry/aws-serverless117.03 KB (0%)
Lms24
Lms24
reviewed
Jul 5, 2024
View reviewed changes
Comment threadpackages/feedback/src/screenshot/components/ScreenshotEditor.tsx

Comment on lines

+4
 to 
+5

// biome-ignore lint/nursery/noUnusedImports: reason
import { h } from 'preact'; // eslint-disable-line @typescript-eslint/no-unused-vars
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a reason/additional comment as to why we need this ignore? It looks like h is destructured but unused further below which doesn't look like an unused import on first glance 🤔 is this a biome bug?
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, I'm off here, this shouldn't require an import 😅

So I guess there's some side effect we need from importing h?
@andreiborzaandreiborzaJul 5, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with preact, but I'm guessing it's a similar factory to JSX createElement? Just taking a wild guess.
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
Maybe we should completely revert the injection too, but I'm waiting on @ryan953 for confirmation before going ahead here.
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh alright sounds good to me! Sorry, I don't have much context around feedback or Preact and was a bit confused but makes sense!
@c298leec298leeJul 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes h is needed because it's a similar factory to JSX createElement, it's needed anytime JSX syntax is used
@andreiborza
andreiborza
requested a review
from ryan953July 5, 2024 11:56
@c298lee
c298lee
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I think we may have accidentally removed h in #12535 because the screenshot button was breaking when using feedbackAsyncIntegration, but if the screenshot button works with both feedbackSyncIntegration and feedbackAsyncIntegration now, then it looks good to me!
@andreiborzaandreiborza
mentioned this pull request
Jul 8, 2024

Closed

3 tasks
@ryan953ryan953
mentioned this pull request
Jul 8, 2024

Closed

ryan953
ryan953
approved these changes
Jul 8, 2024
View reviewed changes
@ryan953ryan953
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Lets get this merged!
@ryan953
ryan953
commented
Jul 8, 2024

Copy link


Copy Markdown

Member
Looks like we need #12793. I'll merge the develop branch in
@ryan953
ryan953
merged commit 3883517
into
developJul 8, 2024
@ryan953
ryan953
deleted the

ab/fix-feedback-screenshot-button

branch
July 8, 2024 23:00
@ryan953ryan953
mentioned this pull request
Jul 9, 2024
 Merged

andreiborza pushed a commit
that referenced
this pull request
Jul 9, 2024
@ryan953
ref(feedback): Let CropCorner inherit the existing h prop (#12814)
aefbfaa
I noticed this after
#12784, but the
`<CropCorner>` wasn't inside the `ScreenshotEditorFactory()` function.
So of course it wasn't getting access to the `h` ref that is passed in.
That variable is what the `<div>` gets transpiled into -> it becomes
`h.createElement('div')`.
So what i'm doing is moving `CropCorner` into a `CropCornerFactory` so
we can pass `h` in and hopefully not have the extra `import .. from
'preact';` in the 2nd bundle.
Related to #12535

This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged


This was referenced Aug 9, 2024
 Open

 Open

@q1blueq1blue
mentioned this pull request
Aug 9, 2024
 Open

@FengShangWuQiFengShangWuQi
mentioned this pull request
Aug 11, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 left review comments
@ryan953ryan953ryan953 approved these changes
@chargomechargomechargome approved these changes
@mydeamydeaAwaiting requested review from mydea

+1 more reviewer

@c298leec298leec298lee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andreiborza@c298lee@ryan953@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(feedback): Add missing h import in ScreenshotEditor (#12713) - #12784
Merged
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Jul 8, 2024
Merged
fix(feedback): Add missing h import in ScreenshotEditor (#12713)#12784
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Conversation
@andreiborza
@andreiborzaandreiborza
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This broke the Add a screenshot button on the user feedback, see #12713
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
@andreiborza
andreiborza
requested a review
from a team
as a code ownerJuly 5, 2024 11:42
@github-actions
github-actionsBot
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.28 KB (0%)
@sentry/browser (incl. Tracing)33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.84 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.71 KB (-0.03% 🔽)
@sentry/browser (incl. metrics)26.57 KB (0%)
@sentry/browser (incl. Feedback)38.93 KB (-0.02% 🔽)
@sentry/browser (incl. sendFeedback)26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.52 KB (0%)
@sentry/react25.02 KB (0%)
@sentry/react (incl. Tracing)36.46 KB (0%)
@sentry/vue26.39 KB (0%)
@sentry/vue (incl. Tracing)35.29 KB (0%)
@sentry/svelte22.41 KB (0%)
CDN Bundle23.5 KB (0%)
CDN Bundle (incl. Tracing)35.19 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.48 KB (0%)
CDN Bundle - uncompressed68.97 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.98 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.38 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227.09 KB (0%)
@sentry/nextjs (client)36.35 KB (0%)
@sentry/sveltekit (client)34.07 KB (0%)
@sentry/node130.84 KB (0%)
@sentry/node - without tracing91.86 KB (0%)
@sentry/aws-serverless117.03 KB (0%)
Lms24
Lms24
reviewed
Jul 5, 2024
View reviewed changes
Comment threadpackages/feedback/src/screenshot/components/ScreenshotEditor.tsx

Comment on lines

+4
 to 
+5

// biome-ignore lint/nursery/noUnusedImports: reason
import { h } from 'preact'; // eslint-disable-line @typescript-eslint/no-unused-vars
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a reason/additional comment as to why we need this ignore? It looks like h is destructured but unused further below which doesn't look like an unused import on first glance 🤔 is this a biome bug?
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, I'm off here, this shouldn't require an import 😅

So I guess there's some side effect we need from importing h?
@andreiborzaandreiborzaJul 5, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with preact, but I'm guessing it's a similar factory to JSX createElement? Just taking a wild guess.
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
Maybe we should completely revert the injection too, but I'm waiting on @ryan953 for confirmation before going ahead here.
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh alright sounds good to me! Sorry, I don't have much context around feedback or Preact and was a bit confused but makes sense!
@c298leec298leeJul 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes h is needed because it's a similar factory to JSX createElement, it's needed anytime JSX syntax is used
@andreiborza
andreiborza
requested a review
from ryan953July 5, 2024 11:56
@c298lee
c298lee
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I think we may have accidentally removed h in #12535 because the screenshot button was breaking when using feedbackAsyncIntegration, but if the screenshot button works with both feedbackSyncIntegration and feedbackAsyncIntegration now, then it looks good to me!
@andreiborzaandreiborza
mentioned this pull request
Jul 8, 2024

Closed

3 tasks
@ryan953ryan953
mentioned this pull request
Jul 8, 2024

Closed

ryan953
ryan953
approved these changes
Jul 8, 2024
View reviewed changes
@ryan953ryan953
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Lets get this merged!
@ryan953
ryan953
commented
Jul 8, 2024

Copy link


Copy Markdown

Member
Looks like we need #12793. I'll merge the develop branch in
@ryan953
ryan953
merged commit 3883517
into
developJul 8, 2024
@ryan953
ryan953
deleted the

ab/fix-feedback-screenshot-button

branch
July 8, 2024 23:00
@ryan953ryan953
mentioned this pull request
Jul 9, 2024
 Merged

andreiborza pushed a commit
that referenced
this pull request
Jul 9, 2024
@ryan953
ref(feedback): Let CropCorner inherit the existing h prop (#12814)
aefbfaa
I noticed this after
#12784, but the
`<CropCorner>` wasn't inside the `ScreenshotEditorFactory()` function.
So of course it wasn't getting access to the `h` ref that is passed in.
That variable is what the `<div>` gets transpiled into -> it becomes
`h.createElement('div')`.
So what i'm doing is moving `CropCorner` into a `CropCornerFactory` so
we can pass `h` in and hopefully not have the extra `import .. from
'preact';` in the 2nd bundle.
Related to #12535

This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged


This was referenced Aug 9, 2024
 Open

 Open

@q1blueq1blue
mentioned this pull request
Aug 9, 2024
 Open

@FengShangWuQiFengShangWuQi
mentioned this pull request
Aug 11, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 left review comments
@ryan953ryan953ryan953 approved these changes
@chargomechargomechargome approved these changes
@mydeamydeaAwaiting requested review from mydea

+1 more reviewer

@c298leec298leec298lee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andreiborza@c298lee@ryan953@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(feedback): Add missing h import in ScreenshotEditor (#12713) - #12784
Merged
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Jul 8, 2024
Merged
fix(feedback): Add missing h import in ScreenshotEditor (#12713)#12784
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Conversation
@andreiborza
@andreiborzaandreiborza
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This broke the Add a screenshot button on the user feedback, see #12713
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
@andreiborza
andreiborza
requested a review
from a team
as a code ownerJuly 5, 2024 11:42
@github-actions
github-actionsBot
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.28 KB (0%)
@sentry/browser (incl. Tracing)33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.84 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.71 KB (-0.03% 🔽)
@sentry/browser (incl. metrics)26.57 KB (0%)
@sentry/browser (incl. Feedback)38.93 KB (-0.02% 🔽)
@sentry/browser (incl. sendFeedback)26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.52 KB (0%)
@sentry/react25.02 KB (0%)
@sentry/react (incl. Tracing)36.46 KB (0%)
@sentry/vue26.39 KB (0%)
@sentry/vue (incl. Tracing)35.29 KB (0%)
@sentry/svelte22.41 KB (0%)
CDN Bundle23.5 KB (0%)
CDN Bundle (incl. Tracing)35.19 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.48 KB (0%)
CDN Bundle - uncompressed68.97 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.98 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.38 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227.09 KB (0%)
@sentry/nextjs (client)36.35 KB (0%)
@sentry/sveltekit (client)34.07 KB (0%)
@sentry/node130.84 KB (0%)
@sentry/node - without tracing91.86 KB (0%)
@sentry/aws-serverless117.03 KB (0%)
Lms24
Lms24
reviewed
Jul 5, 2024
View reviewed changes
Comment threadpackages/feedback/src/screenshot/components/ScreenshotEditor.tsx

Comment on lines

+4
 to 
+5

// biome-ignore lint/nursery/noUnusedImports: reason
import { h } from 'preact'; // eslint-disable-line @typescript-eslint/no-unused-vars
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a reason/additional comment as to why we need this ignore? It looks like h is destructured but unused further below which doesn't look like an unused import on first glance 🤔 is this a biome bug?
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, I'm off here, this shouldn't require an import 😅

So I guess there's some side effect we need from importing h?
@andreiborzaandreiborzaJul 5, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with preact, but I'm guessing it's a similar factory to JSX createElement? Just taking a wild guess.
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
Maybe we should completely revert the injection too, but I'm waiting on @ryan953 for confirmation before going ahead here.
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh alright sounds good to me! Sorry, I don't have much context around feedback or Preact and was a bit confused but makes sense!
@c298leec298leeJul 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes h is needed because it's a similar factory to JSX createElement, it's needed anytime JSX syntax is used
@andreiborza
andreiborza
requested a review
from ryan953July 5, 2024 11:56
@c298lee
c298lee
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I think we may have accidentally removed h in #12535 because the screenshot button was breaking when using feedbackAsyncIntegration, but if the screenshot button works with both feedbackSyncIntegration and feedbackAsyncIntegration now, then it looks good to me!
@andreiborzaandreiborza
mentioned this pull request
Jul 8, 2024

Closed

3 tasks
@ryan953ryan953
mentioned this pull request
Jul 8, 2024

Closed

ryan953
ryan953
approved these changes
Jul 8, 2024
View reviewed changes
@ryan953ryan953
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Lets get this merged!
@ryan953
ryan953
commented
Jul 8, 2024

Copy link


Copy Markdown

Member
Looks like we need #12793. I'll merge the develop branch in
@ryan953
ryan953
merged commit 3883517
into
developJul 8, 2024
@ryan953
ryan953
deleted the

ab/fix-feedback-screenshot-button

branch
July 8, 2024 23:00
@ryan953ryan953
mentioned this pull request
Jul 9, 2024
 Merged

andreiborza pushed a commit
that referenced
this pull request
Jul 9, 2024
@ryan953
ref(feedback): Let CropCorner inherit the existing h prop (#12814)
aefbfaa
I noticed this after
#12784, but the
`<CropCorner>` wasn't inside the `ScreenshotEditorFactory()` function.
So of course it wasn't getting access to the `h` ref that is passed in.
That variable is what the `<div>` gets transpiled into -> it becomes
`h.createElement('div')`.
So what i'm doing is moving `CropCorner` into a `CropCornerFactory` so
we can pass `h` in and hopefully not have the extra `import .. from
'preact';` in the 2nd bundle.
Related to #12535

This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged


This was referenced Aug 9, 2024
 Open

 Open

@q1blueq1blue
mentioned this pull request
Aug 9, 2024
 Open

@FengShangWuQiFengShangWuQi
mentioned this pull request
Aug 11, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 left review comments
@ryan953ryan953ryan953 approved these changes
@chargomechargomechargome approved these changes
@mydeamydeaAwaiting requested review from mydea

+1 more reviewer

@c298leec298leec298lee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andreiborza@c298lee@ryan953@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(feedback): Add missing h import in ScreenshotEditor (#12713) - #12784
Merged
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Jul 8, 2024
Merged
fix(feedback): Add missing h import in ScreenshotEditor (#12713)#12784
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Conversation
@andreiborza
@andreiborzaandreiborza
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This broke the Add a screenshot button on the user feedback, see #12713
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
@andreiborza
andreiborza
requested a review
from a team
as a code ownerJuly 5, 2024 11:42
@github-actions
github-actionsBot
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.28 KB (0%)
@sentry/browser (incl. Tracing)33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.84 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.71 KB (-0.03% 🔽)
@sentry/browser (incl. metrics)26.57 KB (0%)
@sentry/browser (incl. Feedback)38.93 KB (-0.02% 🔽)
@sentry/browser (incl. sendFeedback)26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.52 KB (0%)
@sentry/react25.02 KB (0%)
@sentry/react (incl. Tracing)36.46 KB (0%)
@sentry/vue26.39 KB (0%)
@sentry/vue (incl. Tracing)35.29 KB (0%)
@sentry/svelte22.41 KB (0%)
CDN Bundle23.5 KB (0%)
CDN Bundle (incl. Tracing)35.19 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.48 KB (0%)
CDN Bundle - uncompressed68.97 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.98 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.38 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227.09 KB (0%)
@sentry/nextjs (client)36.35 KB (0%)
@sentry/sveltekit (client)34.07 KB (0%)
@sentry/node130.84 KB (0%)
@sentry/node - without tracing91.86 KB (0%)
@sentry/aws-serverless117.03 KB (0%)
Lms24
Lms24
reviewed
Jul 5, 2024
View reviewed changes
Comment threadpackages/feedback/src/screenshot/components/ScreenshotEditor.tsx

Comment on lines

+4
 to 
+5

// biome-ignore lint/nursery/noUnusedImports: reason
import { h } from 'preact'; // eslint-disable-line @typescript-eslint/no-unused-vars
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a reason/additional comment as to why we need this ignore? It looks like h is destructured but unused further below which doesn't look like an unused import on first glance 🤔 is this a biome bug?
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, I'm off here, this shouldn't require an import 😅

So I guess there's some side effect we need from importing h?
@andreiborzaandreiborzaJul 5, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with preact, but I'm guessing it's a similar factory to JSX createElement? Just taking a wild guess.
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
Maybe we should completely revert the injection too, but I'm waiting on @ryan953 for confirmation before going ahead here.
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh alright sounds good to me! Sorry, I don't have much context around feedback or Preact and was a bit confused but makes sense!
@c298leec298leeJul 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes h is needed because it's a similar factory to JSX createElement, it's needed anytime JSX syntax is used
@andreiborza
andreiborza
requested a review
from ryan953July 5, 2024 11:56
@c298lee
c298lee
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I think we may have accidentally removed h in #12535 because the screenshot button was breaking when using feedbackAsyncIntegration, but if the screenshot button works with both feedbackSyncIntegration and feedbackAsyncIntegration now, then it looks good to me!
@andreiborzaandreiborza
mentioned this pull request
Jul 8, 2024

Closed

3 tasks
@ryan953ryan953
mentioned this pull request
Jul 8, 2024

Closed

ryan953
ryan953
approved these changes
Jul 8, 2024
View reviewed changes
@ryan953ryan953
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Lets get this merged!
@ryan953
ryan953
commented
Jul 8, 2024

Copy link


Copy Markdown

Member
Looks like we need #12793. I'll merge the develop branch in
@ryan953
ryan953
merged commit 3883517
into
developJul 8, 2024
@ryan953
ryan953
deleted the

ab/fix-feedback-screenshot-button

branch
July 8, 2024 23:00
@ryan953ryan953
mentioned this pull request
Jul 9, 2024
 Merged

andreiborza pushed a commit
that referenced
this pull request
Jul 9, 2024
@ryan953
ref(feedback): Let CropCorner inherit the existing h prop (#12814)
aefbfaa
I noticed this after
#12784, but the
`<CropCorner>` wasn't inside the `ScreenshotEditorFactory()` function.
So of course it wasn't getting access to the `h` ref that is passed in.
That variable is what the `<div>` gets transpiled into -> it becomes
`h.createElement('div')`.
So what i'm doing is moving `CropCorner` into a `CropCornerFactory` so
we can pass `h` in and hopefully not have the extra `import .. from
'preact';` in the 2nd bundle.
Related to #12535

This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged


This was referenced Aug 9, 2024
 Open

 Open

@q1blueq1blue
mentioned this pull request
Aug 9, 2024
 Open

@FengShangWuQiFengShangWuQi
mentioned this pull request
Aug 11, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 left review comments
@ryan953ryan953ryan953 approved these changes
@chargomechargomechargome approved these changes
@mydeamydeaAwaiting requested review from mydea

+1 more reviewer

@c298leec298leec298lee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andreiborza@c298lee@ryan953@Lms24@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(feedback): Add missing h import in ScreenshotEditor (#12713) - #12784
Merged
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Jul 8, 2024
Merged
fix(feedback): Add missing h import in ScreenshotEditor (#12713)#12784
ryan953 merged 2 commits into
developfrom 
ab/fix-feedback-screenshot-button
Conversation
@andreiborza
@andreiborzaandreiborza
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This broke the Add a screenshot button on the user feedback, see #12713
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
@andreiborza
andreiborza
requested a review
from a team
as a code ownerJuly 5, 2024 11:42
@github-actions
github-actionsBot
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize
@sentry/browser22.28 KB (0%)
@sentry/browser (incl. Tracing)33.43 KB (0%)
@sentry/browser (incl. Tracing, Replay)69.18 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.51 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas)73.24 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback)85.84 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics)87.71 KB (-0.03% 🔽)
@sentry/browser (incl. metrics)26.57 KB (0%)
@sentry/browser (incl. Feedback)38.93 KB (-0.02% 🔽)
@sentry/browser (incl. sendFeedback)26.9 KB (0%)
@sentry/browser (incl. FeedbackAsync)31.52 KB (0%)
@sentry/react25.02 KB (0%)
@sentry/react (incl. Tracing)36.46 KB (0%)
@sentry/vue26.39 KB (0%)
@sentry/vue (incl. Tracing)35.29 KB (0%)
@sentry/svelte22.41 KB (0%)
CDN Bundle23.5 KB (0%)
CDN Bundle (incl. Tracing)35.19 KB (0%)
CDN Bundle (incl. Tracing, Replay)69.29 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback)74.48 KB (0%)
CDN Bundle - uncompressed68.97 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed103.98 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed214.38 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed227.09 KB (0%)
@sentry/nextjs (client)36.35 KB (0%)
@sentry/sveltekit (client)34.07 KB (0%)
@sentry/node130.84 KB (0%)
@sentry/node - without tracing91.86 KB (0%)
@sentry/aws-serverless117.03 KB (0%)
Lms24
Lms24
reviewed
Jul 5, 2024
View reviewed changes
Comment threadpackages/feedback/src/screenshot/components/ScreenshotEditor.tsx

Comment on lines

+4
 to 
+5

// biome-ignore lint/nursery/noUnusedImports: reason
import { h } from 'preact'; // eslint-disable-line @typescript-eslint/no-unused-vars
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a reason/additional comment as to why we need this ignore? It looks like h is destructured but unused further below which doesn't look like an unused import on first glance 🤔 is this a biome bug?
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, I'm off here, this shouldn't require an import 😅

So I guess there's some side effect we need from importing h?
@andreiborzaandreiborzaJul 5, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with preact, but I'm guessing it's a similar factory to JSX createElement? Just taking a wild guess.
This has been explicitly removed in favor of injecting h in #12535 but at that point it seems to be too late to do.
Maybe we should completely revert the injection too, but I'm waiting on @ryan953 for confirmation before going ahead here.
@Lms24Lms24Jul 5, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh alright sounds good to me! Sorry, I don't have much context around feedback or Preact and was a bit confused but makes sense!
@c298leec298leeJul 5, 2024

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes h is needed because it's a similar factory to JSX createElement, it's needed anytime JSX syntax is used
@andreiborza
andreiborza
requested a review
from ryan953July 5, 2024 11:56
@c298lee
c298lee
commented
Jul 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I think we may have accidentally removed h in #12535 because the screenshot button was breaking when using feedbackAsyncIntegration, but if the screenshot button works with both feedbackSyncIntegration and feedbackAsyncIntegration now, then it looks good to me!
@andreiborzaandreiborza
mentioned this pull request
Jul 8, 2024

Closed

3 tasks
@ryan953ryan953
mentioned this pull request
Jul 8, 2024

Closed

ryan953
ryan953
approved these changes
Jul 8, 2024
View reviewed changes
@ryan953ryan953
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Lets get this merged!
@ryan953
ryan953
commented
Jul 8, 2024

Copy link


Copy Markdown

Member
Looks like we need #12793. I'll merge the develop branch in
@ryan953
ryan953
merged commit 3883517
into
developJul 8, 2024
@ryan953
ryan953
deleted the

ab/fix-feedback-screenshot-button

branch
July 8, 2024 23:00
@ryan953ryan953
mentioned this pull request
Jul 9, 2024
 Merged

andreiborza pushed a commit
that referenced
this pull request
Jul 9, 2024
@ryan953
ref(feedback): Let CropCorner inherit the existing h prop (#12814)
aefbfaa
I noticed this after
#12784, but the
`<CropCorner>` wasn't inside the `ScreenshotEditorFactory()` function.
So of course it wasn't getting access to the `h` ref that is passed in.
That variable is what the `<div>` gets transpiled into -> it becomes
`h.createElement('div')`.
So what i'm doing is moving `CropCorner` into a `CropCornerFactory` so
we can pass `h` in and hopefully not have the extra `import .. from
'preact';` in the 2nd bundle.
Related to #12535

This was referenced Jul 30, 2024
 Open

 Open

@amykapernickamykapernick
mentioned this pull request
Aug 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 1, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Aug 6, 2024
 Open

@wkylinwkylin
mentioned this pull request
Aug 7, 2024
 Merged


This was referenced Aug 9, 2024
 Open

 Open

@q1blueq1blue
mentioned this pull request
Aug 9, 2024
 Open

@FengShangWuQiFengShangWuQi
mentioned this pull request
Aug 11, 2024
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 left review comments
@ryan953ryan953ryan953 approved these changes
@chargomechargomechargome approved these changes
@mydeamydeaAwaiting requested review from mydea

+1 more reviewer

@c298leec298leec298lee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@andreiborza@c298lee@ryan953@Lms24@chargome