Uh oh!
There was an error while loading. Please reload this page.
feat(cloudflare): Add cloudflare sdk scaffolding - #12953
Merged
Merged
Conversation
AbhiPrasad
requested review from
chargome and mydea
and removed request for
a teamJuly 17, 2024 13:39
AbhiPrasadforce-pushed
the
abhi-cloudflare-errors
branch
from
July 17, 2024 13:53
16eed29 to
8241555Compare
Comment on lines
+53
to
+56
| const cachedDecision = _headersUrlMap.get(url); | ||
| if (cachedDecision !== undefined) { | ||
| return cachedDecision; | ||
| } |
Member
There was a problem hiding this comment.
l: could extract the cache decision logic into a helper function and reuse it in _shouldCreateSpan
ContributorAuthor
There was a problem hiding this comment.
Will do this in a follow-up PR
| const shouldCreateSpanForRequest = options.shouldCreateSpanForRequest; | ||
| const _createSpanUrlMap = new LRUMap<string, boolean>(100); | ||
| const _headersUrlMap = new LRUMap<string, boolean>(100); |
Member
There was a problem hiding this comment.
Just to understand it better, how did you come up with cache size 100?
ContributorAuthor
There was a problem hiding this comment.
This was arbitrary, it matches the implementation for vercel-edge fetch integration. We can always adjust this in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #12620
This PR adds basic scaffolding for the cloudflare workers SDK. Most of this is based on
@sentry/vercel-edge.This adds:
You'll notice that there is no
initmethod defined or exported from the SDK. This is on purpose!initfor cloudflare workers will work a bit differently than the other SDKs, so I wanted to address it differently on purpose. You'll see what that looks like in the next PR!