Uh oh!
There was an error while loading. Please reload this page.
ref(replay): Update CLS web vitals to align with browserTracing - #13058
Merged
Conversation
Contributor
size-limit report 📦
|
c298lee
marked this pull request as ready for review
July 29, 2024 16:02
billyvg
requested changes
Jul 29, 2024
billyvg
left a comment
Member
There was a problem hiding this comment.
Does the frontend support node being an array? We'll want to make sure it's compatible.
It would be better though if we sent it as a new property, e.g. nodes. Otherwise it can break self-hosted since the UI is not expecting an array. With a different property, old UIs will not be able to highlight the nodes, but at least it shouldn't break the app.
Comment on lines
+239
to
+240
| const nodeIds: number[] = []; | ||
| if (Array.isArray(node)) { |
Member
There was a problem hiding this comment.
This might be easier to follow and less code:
Suggested change
| constnodeIds: number[]=[]; | |
| if(Array.isArray(node)){ | |
| constnodes=Array.isArray(node) ? node :[]; | |
| constnodeIds=nodes.map(node=>record.mirror.getId(node); |
| metric: Metric, | ||
| name: string, | ||
| node: Node | undefined, | ||
| node: Node | Node[] | undefined, |
Member
There was a problem hiding this comment.
Is getWebVital a public function? It might be better to change the parameters so that it accepts Node[] | undefined.
billyvg
approved these changes
Jul 30, 2024
Comment on lines
+235
to
+236
| const nodeIds = nodes ? nodes.map(node => record.mirror.getId(node)) : undefined; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeId has been replaced with nodeIds which now accepts several nodes since CLS scores are cumulative. Also updated CLS metrics to match CLS captured from browserTracing.
Relates to getsentry/sentry#69881