Uh oh!
There was an error while loading. Please reload this page.
fix(node): Improve OTEL validation logic - #13079
Merged
Merged
Conversation
3 tasks
Lms24
approved these changes
Jul 29, 2024
Contributor
size-limit report 📦
|
andreiborza
left a comment
Member
There was a problem hiding this comment.
Could we add a test for this?
mydea
commented
Jul 29, 2024
MemberAuthor
We have tests covering that this actually works (e.g. not having span processor), it was just not nicely reflected in the warning messages. Sadly it is hard to test this properly because this runs in node on init, which makes it tricky to test this well in e.g. an e2e test. |
andreiborza
approved these changes
Jul 29, 2024
mydea
commented
Jul 29, 2024
| }); | ||
| }); | ||
| describe('validateOpenTelemetrySetup', () => { |
andreiborza
approved these changes
Jul 29, 2024
| expect(warnSpy).toHaveBeenCalledTimes(1); | ||
| expect(errorSpy).toBeCalledWith(expect.stringContaining('You have to set up the SentryContextManager.')); | ||
| expect(errorSpy).toBeCalledWith(expect.stringContaining('You have to set up the SentryPropagator.')); |
Member
There was a problem hiding this comment.
l: I think it would be good to also assert on the message we don't expect to show up as well, just relying on the number of times it has been called is error prone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the SDK without tracing, the span processor is not required - we should reflect this in our validation logic.
While at it, I also improved the warning for not using the SentrySampler.