Uh oh!
There was an error while loading. Please reload this page.
feat(meta-sdks): Remove runtime tags - #13105
Merged
Merged
Conversation
lforst
approved these changes
Jul 30, 2024
lforst
left a comment
Contributor
There was a problem hiding this comment.
I fear the tests will need updating but lgtm
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jul 30, 2024
Lms24
left a comment
Member
There was a problem hiding this comment.
Thanks for doing this! Just had a suggestion to remove some tests that specifically tested the runtime tag before.
Comment on lines
-48
to
-49
| expect(getIsolationScope().getScopeData().tags).toEqual({ runtime: 'browser' }); |
| init({ dsn: 'https://public@dsn.ingest.sentry.io/1337' }); | ||
| expect(SentryNode.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'node' }); |
| it('sets the runtime tag on the isolation scope', () => { | ||
| solidStartInit({ dsn: 'https://public@dsn.ingest.sentry.io/1337' }); | ||
| expect(SentryNode.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'node' }); |
| it('sets the runtime tag on the isolation scope', () => { | ||
| solidStartInit({ dsn: 'https://public@dsn.ingest.sentry.io/1337' }); | ||
| expect(SentrySolid.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'browser' }); |
| expect(SentryReact.getIsolationScope().getScopeData().tags).toEqual({}); | ||
| init({ dsn: 'https://public@dsn.ingest.sentry.io/1337' }); | ||
| init({ dsn: 'https://public@dsn.ingest.sentry.io/1337' }); | ||
| expect(SentryNode.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'node' }); |
| init({ dsn: 'https://public@dsn.ingest.sentry.io/1337' }); | ||
| expect(SentryReact.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'browser' }); |
Comment on lines
-46
to
-47
| expect(SentryNode.getIsolationScope().getScopeData().tags).toEqual({ runtime: 'node' }); |
Member
There was a problem hiding this comment.
l: let's delete the entire test since this was the only relevant check. I don't think we need to assert that the isolation scope has no tags at the beginning for Astro specifically.
This was referenced Aug 27, 2024
This was referenced Aug 28, 2024
This was referenced Aug 29, 2024
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime tags are already set by e.g. Relay, so the Meta-Framework SDKs do not need to set them anymore.
Comment why this change was made: #13101 (review)