Uh oh!
There was an error while loading. Please reload this page.
feat(node): Option to only wrap instrumented modules - #13139
Merged
Conversation
Contributor
size-limit report 📦
|
timfish
marked this pull request as ready for review
July 31, 2024 18:14
AbhiPrasad
self-requested a review
July 31, 2024 18:15
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
mydea
reviewed
Aug 1, 2024
| * | ||
| * Defaults to `false`. | ||
| */; | ||
| onlyIncludeInstrumentedModules?: boolean; |
Member
There was a problem hiding this comment.
m: Are we sure we want to put this option in here? The API feels a bit "clunky" to me 🤔 also, does this not conflict with include/exclude options, somehow (or do they play together?)?
What about making this a top-level option? Esp. if we think this may become a default at some point...? (no strong feelings, just want us to consider this!)
CollaboratorAuthor
There was a problem hiding this comment.
does this not conflict with include/exclude options, somehow (or do they play together?)?
include/exclude were always mutually exclusive because It doesn't make much sense to use both. You could potentially enable this new onlyIncludeInstrumentedModules option while still supplying include and this would only include instrumented modules, plus whatever the user supplied. This might be useful if a user is adding an instrumentation later.
Are we sure we want to put this option in here? What about making this a top-level option? Esp. if we think this may become a default at some point...?
Yep valid points. I don't feel that strongly either way.
lforst
commented
Aug 2, 2024
Contributor
I was a bit torn on the option because I kinda thought that it should just be the default behaviour and we shouldn't give people the option at all, because we do not define a contract anywhere (code or docs) that the Sentry SDK will provide you with an OTEL setup you can bounce off-of. Then I realized, dang we probably actually want people to be able to add random OTEL instrumentation. I still have the thought that if people jump through the hoops to add other (non-sentry-approved) OTEL instrumentation they basically must have read the paragraphs around ESM in the OTEL docs and have likely added their own hook, which would be an argument for making this the default. Regardless, we should at least write down in the PR description that this PR aims to solve that IITM is breaking random packages that are not contributing to any instrumentation. 😄 |
CollaboratorAuthor
Added some mode context to the description!
Unfortunately it has the potential to break things for too many users for it to be released default enabled as a bug fix 😭 I don't even think users adding otel instrumentations later is the biggest risk. Users might not even be using |
3 tasks
AbhiPrasad
approved these changes
Aug 7, 2024
CollaboratorAuthor
Shall I mark it as experimental? I'm now thinking the entire |
mydea
approved these changes
Aug 8, 2024
mydea
left a comment
Member
There was a problem hiding this comment.
let's ship it! I think I would still like to have a top-level option for this (esp. if we also want to put this into the default onboarding options, which I think would make sense enventually?), but IMHO we can also add this later as a kind of alias for this more in-depth option.
lforst
approved these changes
Aug 8, 2024
3 tasks
mydea
commented
Aug 13, 2024
Member
so, should we merge this? 😅 |
timfish
commented
Aug 27, 2024
CollaboratorAuthor
If we're unsure, I can mark this new option as experimental! |
mydea
commented
Aug 27, 2024
Member
As long as it's opt-in I am totally fine with adding this as is...? As users need to opt-in to it, feels safe enough? |
Xhale1
commented
Sep 4, 2024
Hello hello! Is this on the roadmap for a near-future Sentry release? I'm eager to adopt v8 at my company and wanted to wait for this PR to merge before attempting the migration again. No worries if not, thank you all for your continued contributions to the js ecosystem! |
lforst
commented
Sep 5, 2024
Contributor
I am just gonna press the button |
This was referenced Oct 1, 2024
vjousse pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
 <h3>Snyk has created this PR to upgrade @sentry/node from 8.28.0 to 8.29.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **1 version** ahead of your current version. - The recommended version was released on **22 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>@sentry/node</b></summary> <ul> <li> <b>8.29.0</b> - <a href="https://github.com/getsentry/sentry-javascript/releases/tag/8.29.0">2024-09-09</a></br><h3>Important Changes</h3> <ul> <li><strong>Beta releases of official Solid and SolidStart Sentry SDKs</strong></li> </ul> <p>This release marks the beta releases of the <code>@ sentry/solid</code> and <code>@ sentry/solidstart</code> Sentry SDKs. For details on how to<br> use them, check out the<br> <a href="https://github.com/getsentry/sentry-javascript/tree/develop/packages/solid">Sentry Solid SDK README</a> and the<br> <a href="https://github.com/getsentry/sentry-javascript/tree/develop/packages/solidstart">Sentry SolidStart SDK README</a><br> respectively. Please reach out on <a href="https://github.com/getsentry/sentry-javascript/issues/new/choose">GitHub</a> if you have<br> any feedback or concerns.</p> <ul> <li><strong>feat(node): Option to only wrap instrumented modules (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2440168322" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13139" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13139/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13139">#13139</a>)</strong></li> </ul> <p>Adds the SDK option to only wrap ES modules with <code>import-in-the-middle</code> that specifically need to be instrumented.</p> <div class="highlight highlight-source-js notranslate position-relative overflow-auto" data-snippet-clipboard-copy-content="import * as Sentry from '@ sentry/node'; Sentry.init({ dsn: '__PUBLIC_DSN__', registerEsmLoaderHooks: { onlyIncludeInstrumentedModules: true }, });"><pre><span class="pl-k">import</span> <span class="pl-c1">*</span> <span class="pl-k">as</span> <span class="pl-v">Sentry</span> <span class="pl-k">from</span> <span class="pl-s">'@ sentry/node'</span><span class="pl-kos">;</span> <span class="pl-v">Sentry</span><span class="pl-kos">.</span><span class="pl-en">init</span><span class="pl-kos">(</span><span class="pl-kos">{</span> <span class="pl-c1">dsn</span>: <span class="pl-s">'__PUBLIC_DSN__'</span><span class="pl-kos">,</span> <span class="pl-c1">registerEsmLoaderHooks</span>: <span class="pl-kos">{</span> <span class="pl-c1">onlyIncludeInstrumentedModules</span>: <span class="pl-c1">true</span> <span class="pl-kos">}</span><span class="pl-kos">,</span> <span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div> <ul> <li><strong>feat(node): Update OpenTelemetry packages to instrumentation v0.53.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2505013369" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13587" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13587/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13587">#13587</a>)</strong></li> </ul> <p>All internal OpenTelemetry instrumentation was updated to their latest version. This adds support for Mongoose v7 and v8<br> and fixes various bugs related to ESM mode.</p> <h3>Other Changes</h3> <ul> <li>feat(nextjs): Emit warning when using turbopack (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502465207" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13566" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13566/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13566">#13566</a>)</li> <li>feat(nextjs): Future-proof Next.js config options overriding (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504983381" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13586" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13586/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13586">#13586</a>)</li> <li>feat(node): Add <code>generic-pool</code> integration (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2487465522" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13465" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13465/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13465">#13465</a>)</li> <li>feat(nuxt): Upload sourcemaps generated by Nitro (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2466230992" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13382" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13382/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13382">#13382</a>)</li> <li>feat(solidstart): Add <code>browserTracingIntegration</code> by default (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2501751703" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13561" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13561/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13561">#13561</a>)</li> <li>feat(solidstart): Add <code>sentrySolidStartVite</code> plugin to simplify source maps upload (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491508245" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13493" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13493/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13493">#13493</a>)</li> <li>feat(vue): Only start UI spans if parent is available (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502667000" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13568" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13568/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13568">#13568</a>)</li> <li>fix(cloudflare): Guard <code>context.waitUntil</code> call in request handler (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2500295892" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13549" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13549/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13549">#13549</a>)</li> <li>fix(gatsby): Fix assets path for sourcemaps upload (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2507448723" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13592" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13592/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13592">#13592</a>)</li> <li>fix(nextjs): Use posix paths for sourcemap uploads (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2509567193" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13603" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13603/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13603">#13603</a>)</li> <li>fix(node-fetch): Use stringified origin url (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504749955" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13581" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13581/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13581">#13581</a>)</li> <li>fix(node): Replace dashes in <code>generic-pool</code> span origins with underscores (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504640339" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13579" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13579/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13579">#13579</a>)</li> <li>fix(replay): Fix types in WebVitalData (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2503576160" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13573" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13573/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13573">#13573</a>)</li> <li>fix(replay): Improve replay web vital types (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2508630234" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13602" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13602/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13602">#13602</a>)</li> <li>fix(utils): Keep logger on carrier (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502810517" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13570" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13570/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13570">#13570</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/Zen-cronic/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Zen-cronic">@ Zen-cronic</a>. Thank you for your contribution!</p> </li> <li> <b>8.28.0</b> - <a href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important Changes</h3> <ul> <li><strong>Beta release of official NestJS SDK</strong></li> </ul> <p>This release contains the beta version of <code>@ sentry/nestjs</code>! For details on how to use it, check out the<br> <a href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>. Any feedback/bug reports<br> are greatly appreciated, please reach out on GitHub.</p> <ul> <li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization logic (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491960592" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13502" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li> </ul> <p>This release fixes a bug in the <code>@ sentry/browser</code> package and all SDKs depending on this package (e.g. <code>@ sentry/react</code><br> or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect web vital values for the LCP, FCP and FP vitals. The SDK<br> previously incorrectly processed the original values as they were reported from the browser. When updating your SDK to<br> this version, you might experience an increase in LCP, FCP and FP values, which potentially leads to a decrease in your<br> performance score in the Web Vitals Insights module in Sentry. This is because the previously reported values were<br> smaller than the actually measured values. We apologize for the inconvenience!</p> <h3>Other Changes</h3> <ul> <li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2498873205" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13545" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li> <li>feat(nestjs): Automatic instrumentation of nestjs interceptors after route execution (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2453558373" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13264" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li> <li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build options (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2461140938" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13323" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li> <li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2500682873" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13550" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li> <li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2486658763" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13457" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li> <li>feat(profiling): Expose profiler as top level primitive (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2492896219" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13512" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li> <li>feat(replay): Add layout shift to CLS replay data (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2466359020" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13386" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li> <li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2489549947" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13483" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li> <li>fix(cdn): Do not mangle _metadata (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2473467027" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13426" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li> <li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2489085687" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13475" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li> <li>fix(nestjs): Check arguments before instrumenting with <code>@ Injectable</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2498819596" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13544" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li> <li>fix(nestjs): Ensure exception and host are correctly passed on when using @ WithSentry (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2501912092" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13564" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li> <li>fix(node): Suppress tracing for transport request execution rather than transport creation (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491355594" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13491" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li> <li>fix(replay): Consider more things as DOM mutations for dead clicks (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2493890628" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13518" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li> <li>fix(vue): Correctly obtain component name (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2490176912" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13484" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/leopoldkristjansson/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>, <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mhuggins/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/mhuggins">@ mhuggins</a> and <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/filips123/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/filips123">@ filips123</a>. Thank you for your<br> contributions!</p> </li> </ul> from <a href="https://github.com/getsentry/sentry-javascript/releases">@sentry/node GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIyZTkxMTg2ZC1hYmNlLTQ3NzItOWQ0NS0zYzJhNjExZjQzNTMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjJlOTExODZkLWFiY2UtNDc3Mi05ZDQ1LTNjMmE2MTFmNDM1MyJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg=@sentry/node&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/node","from":"8.28.0","to":"8.29.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"2e91186d-abce-4772-9d45-3c2a611f4353","prPublicId":"2e91186d-abce-4772-9d45-3c2a611f4353","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-09T08:38:44.752Z"},"vulns":[]}' Co-authored-by: snyk-bot <snyk-bot@snyk.io>
vjousse pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
 <h3>Snyk has created this PR to upgrade @sentry/profiling-node from 8.28.0 to 8.29.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **1 version** ahead of your current version. - The recommended version was released on **22 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>@sentry/profiling-node</b></summary> <ul> <li> <b>8.29.0</b> - <a href="https://github.com/getsentry/sentry-javascript/releases/tag/8.29.0">2024-09-09</a></br><h3>Important Changes</h3> <ul> <li><strong>Beta releases of official Solid and SolidStart Sentry SDKs</strong></li> </ul> <p>This release marks the beta releases of the <code>@ sentry/solid</code> and <code>@ sentry/solidstart</code> Sentry SDKs. For details on how to<br> use them, check out the<br> <a href="https://github.com/getsentry/sentry-javascript/tree/develop/packages/solid">Sentry Solid SDK README</a> and the<br> <a href="https://github.com/getsentry/sentry-javascript/tree/develop/packages/solidstart">Sentry SolidStart SDK README</a><br> respectively. Please reach out on <a href="https://github.com/getsentry/sentry-javascript/issues/new/choose">GitHub</a> if you have<br> any feedback or concerns.</p> <ul> <li><strong>feat(node): Option to only wrap instrumented modules (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2440168322" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13139" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13139/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13139">#13139</a>)</strong></li> </ul> <p>Adds the SDK option to only wrap ES modules with <code>import-in-the-middle</code> that specifically need to be instrumented.</p> <div class="highlight highlight-source-js notranslate position-relative overflow-auto" data-snippet-clipboard-copy-content="import * as Sentry from '@ sentry/node'; Sentry.init({ dsn: '__PUBLIC_DSN__', registerEsmLoaderHooks: { onlyIncludeInstrumentedModules: true }, });"><pre><span class="pl-k">import</span> <span class="pl-c1">*</span> <span class="pl-k">as</span> <span class="pl-v">Sentry</span> <span class="pl-k">from</span> <span class="pl-s">'@ sentry/node'</span><span class="pl-kos">;</span> <span class="pl-v">Sentry</span><span class="pl-kos">.</span><span class="pl-en">init</span><span class="pl-kos">(</span><span class="pl-kos">{</span> <span class="pl-c1">dsn</span>: <span class="pl-s">'__PUBLIC_DSN__'</span><span class="pl-kos">,</span> <span class="pl-c1">registerEsmLoaderHooks</span>: <span class="pl-kos">{</span> <span class="pl-c1">onlyIncludeInstrumentedModules</span>: <span class="pl-c1">true</span> <span class="pl-kos">}</span><span class="pl-kos">,</span> <span class="pl-kos">}</span><span class="pl-kos">)</span><span class="pl-kos">;</span></pre></div> <ul> <li><strong>feat(node): Update OpenTelemetry packages to instrumentation v0.53.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2505013369" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13587" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13587/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13587">#13587</a>)</strong></li> </ul> <p>All internal OpenTelemetry instrumentation was updated to their latest version. This adds support for Mongoose v7 and v8<br> and fixes various bugs related to ESM mode.</p> <h3>Other Changes</h3> <ul> <li>feat(nextjs): Emit warning when using turbopack (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502465207" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13566" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13566/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13566">#13566</a>)</li> <li>feat(nextjs): Future-proof Next.js config options overriding (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504983381" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13586" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13586/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13586">#13586</a>)</li> <li>feat(node): Add <code>generic-pool</code> integration (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2487465522" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13465" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13465/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13465">#13465</a>)</li> <li>feat(nuxt): Upload sourcemaps generated by Nitro (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2466230992" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13382" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13382/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13382">#13382</a>)</li> <li>feat(solidstart): Add <code>browserTracingIntegration</code> by default (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2501751703" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13561" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13561/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13561">#13561</a>)</li> <li>feat(solidstart): Add <code>sentrySolidStartVite</code> plugin to simplify source maps upload (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491508245" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13493" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13493/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13493">#13493</a>)</li> <li>feat(vue): Only start UI spans if parent is available (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502667000" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13568" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13568/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13568">#13568</a>)</li> <li>fix(cloudflare): Guard <code>context.waitUntil</code> call in request handler (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2500295892" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13549" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13549/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13549">#13549</a>)</li> <li>fix(gatsby): Fix assets path for sourcemaps upload (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2507448723" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13592" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13592/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13592">#13592</a>)</li> <li>fix(nextjs): Use posix paths for sourcemap uploads (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2509567193" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13603" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13603/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13603">#13603</a>)</li> <li>fix(node-fetch): Use stringified origin url (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504749955" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13581" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13581/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13581">#13581</a>)</li> <li>fix(node): Replace dashes in <code>generic-pool</code> span origins with underscores (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2504640339" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13579" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13579/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13579">#13579</a>)</li> <li>fix(replay): Fix types in WebVitalData (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2503576160" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13573" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13573/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13573">#13573</a>)</li> <li>fix(replay): Improve replay web vital types (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2508630234" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13602" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13602/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13602">#13602</a>)</li> <li>fix(utils): Keep logger on carrier (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2502810517" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13570" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13570/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13570">#13570</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/Zen-cronic/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/Zen-cronic">@ Zen-cronic</a>. Thank you for your contribution!</p> </li> <li> <b>8.28.0</b> - <a href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important Changes</h3> <ul> <li><strong>Beta release of official NestJS SDK</strong></li> </ul> <p>This release contains the beta version of <code>@ sentry/nestjs</code>! For details on how to use it, check out the<br> <a href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>. Any feedback/bug reports<br> are greatly appreciated, please reach out on GitHub.</p> <ul> <li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization logic (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491960592" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13502" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li> </ul> <p>This release fixes a bug in the <code>@ sentry/browser</code> package and all SDKs depending on this package (e.g. <code>@ sentry/react</code><br> or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect web vital values for the LCP, FCP and FP vitals. The SDK<br> previously incorrectly processed the original values as they were reported from the browser. When updating your SDK to<br> this version, you might experience an increase in LCP, FCP and FP values, which potentially leads to a decrease in your<br> performance score in the Web Vitals Insights module in Sentry. This is because the previously reported values were<br> smaller than the actually measured values. We apologize for the inconvenience!</p> <h3>Other Changes</h3> <ul> <li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2498873205" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13545" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li> <li>feat(nestjs): Automatic instrumentation of nestjs interceptors after route execution (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2453558373" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13264" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li> <li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build options (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2461140938" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13323" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li> <li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2500682873" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13550" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li> <li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2486658763" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13457" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li> <li>feat(profiling): Expose profiler as top level primitive (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2492896219" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13512" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li> <li>feat(replay): Add layout shift to CLS replay data (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2466359020" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13386" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li> <li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2489549947" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13483" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li> <li>fix(cdn): Do not mangle _metadata (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2473467027" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13426" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li> <li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2489085687" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13475" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li> <li>fix(nestjs): Check arguments before instrumenting with <code>@ Injectable</code> (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2498819596" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13544" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li> <li>fix(nestjs): Ensure exception and host are correctly passed on when using @ WithSentry (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2501912092" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13564" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li> <li>fix(node): Suppress tracing for transport request execution rather than transport creation (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2491355594" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13491" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li> <li>fix(replay): Consider more things as DOM mutations for dead clicks (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2493890628" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13518" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li> <li>fix(vue): Correctly obtain component name (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2490176912" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#13484" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard" href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/leopoldkristjansson/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>, <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/mhuggins/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/mhuggins">@ mhuggins</a> and <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/filips123/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/filips123">@ filips123</a>. Thank you for your<br> contributions!</p> </li> </ul> from <a href="https://github.com/getsentry/sentry-javascript/releases">@sentry/profiling-node GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJlZGFkYTE0Ny1jZDVmLTQ5ZDQtYWE1Ni1iZjQ0MmFmMGY5NzEiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImVkYWRhMTQ3LWNkNWYtNDlkNC1hYTU2LWJmNDQyYWYwZjk3MSJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg=@sentry/profiling-node&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/profiling-node","from":"8.28.0","to":"8.29.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"edada147-cd5f-49d4-aa56-bf442af0f971","prPublicId":"edada147-cd5f-49d4-aa56-bf442af0f971","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-09T08:38:47.485Z"},"vulns":[]}' Co-authored-by: snyk-bot <snyk-bot@snyk.io>
This was referenced Oct 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Likely closes many issues but I don't want to auto-close anything specific here. We should probably confirm the issues are closed individually.
import-in-the-middleby default wraps every ES module with a wrapping module that later allows it exports to be modified. This has issues though because the wrapping output ofimport-in-the-middleis not compatible with all modules.To help work around this I added a feature to
import-in-the-middlethat allows us to only wrap modules that we specifically need to instrument.So far I've only changed the express integration test to use this new mode.