Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(nestjs): Filter RPC exceptions#13227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
0faa467cebcd441db607fda797a7b1ac229979d7e7619e8feFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -87,10 +87,16 @@ export function setupNestErrorHandler(app: MinimalNestJsApp, baseFilter: NestJsE | ||
| const originalCatch = Reflect.get(target, prop, receiver); | ||
| return (exception: unknown, host: unknown) => { | ||
| const status_code = (exception as { status?: number }).status; | ||
| // don't report expected errors | ||
| if (status_code !== undefined) { | ||
| const exceptionIsObject = typeof exception === 'object' && exception !== null; | ||
| const exceptionStatusCode = exceptionIsObject && 'status' in exception ? exception.status : null; | ||
| const exceptionErrorProperty = exceptionIsObject && 'error' in exception ? exception.error : null; | ||
| /* | ||
| Don't report expected NestJS control flow errors | ||
| - `HttpException` errors will have a `status` property | ||
| - `RpcException` errors will have an `error` property | ||
| */ | ||
| if (exceptionStatusCode !== null || exceptionErrorProperty !== null) { | ||
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. l: I would flip the condition: We report the error if this and this condition is true. To me the early return is a weird pattern here but I'll leave it up to you. | ||
| return originalCatch.apply(target, [exception, host]); | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks NestJS projects which don't use
@nestjs/microservices.I've tried creating an issue, but couldn't submit it because GH kept showing "Something went wrong" popup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing in! I am currently working on a fix for the nest SDK and will remove the dependency again as part of that PR. ref