Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,4 +38,7 @@
<li>
<a href="components">Component Tracking</a>
</li>
<li>
<a href="/wrap-server-route">server routes</a>
</li>
</ul>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
<script lang="ts">
export let data;
</script>

<p>
Message from API: {data.myMessage}
</p>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export const load = async ({ fetch }) => {
const res = await fetch('/wrap-server-route/api');
const myMessage = await res.json();
return {
myMessage: myMessage.myMessage,
};
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
import { error } from '@sveltejs/kit';

export const GET = wrapServerRouteWithSentry(async () => {
error(500, 'error() error');
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,4 +58,37 @@ test.describe('server-side errors', () => {

expect(errorEvent.transaction).toEqual('GET /server-route-error');
});

test('captures error() thrown in server route with `wrapServerRouteWithSentry`', async ({ page }) => {
const errorEventPromise = waitForError('sveltekit-2', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === "'HttpError' captured as exception with keys: body, status";
});

await page.goto('/wrap-server-route');

expect(await errorEventPromise).toMatchObject({
exception: {
values: [
{
value: "'HttpError' captured as exception with keys: body, status",
mechanism: {
handled: false,
data: {
function: 'serverRoute',
},
},
stacktrace: { frames: expect.any(Array) },
},
],
},
extra: {
__serialized__: {
body: {
message: 'error() error',
},
status: 500,
},
},
});
});
});
40 changes: 4 additions & 36 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,21 +11,15 @@ import {
withIsolationScope,
} from '@sentry/core';
import { startSpan } from '@sentry/core';
import { captureException, continueTrace } from '@sentry/node';
import { continueTrace } from '@sentry/node';
import type { Span } from '@sentry/types';
import {
dynamicSamplingContextToSentryBaggageHeader,
logger,
objectify,
winterCGRequestToRequestData,
} from '@sentry/utils';
import { dynamicSamplingContextToSentryBaggageHeader, logger, winterCGRequestToRequestData } from '@sentry/utils';
import type { Handle, ResolveOptions } from '@sveltejs/kit';

import { getDynamicSamplingContextFromSpan } from '@sentry/opentelemetry';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless, getTracePropagationData } from './utils';
import { flushIfServerless, getTracePropagationData, sendErrorToSentry } from './utils';

export type SentryHandleOptions = {
/**
Expand DownExpand Up@@ -62,32 +56,6 @@ export type SentryHandleOptions = {
fetchProxyScriptNonce?: string;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// similarly to the `load` function, we don't want to capture 4xx errors or redirects
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'handle',
},
},
});

return objectifiedErr;
}

/**
* Exported only for testing
*/
Expand DownExpand Up@@ -225,7 +193,7 @@ async function instrumentHandle(
);
return resolveResult;
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'handle');
throw e;
} finally {
await flushIfServerless();
Expand Down
1 change: 1 addition & 0 deletions packages/sveltekit/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -128,6 +128,7 @@ export { init } from './sdk';
export { handleErrorWithSentry } from './handleError';
export { wrapLoadWithSentry, wrapServerLoadWithSentry } from './load';
export { sentryHandle } from './handle';
export { wrapServerRouteWithSentry } from './serverRoute';

/**
* Tracks the Svelte component's initialization and mounting operation as well as
Expand Down
46 changes: 5 additions & 41 deletions packages/sveltekit/src/server/load.ts
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,13 @@
import {
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
captureException,
startSpan,
} from '@sentry/node';
import { addNonEnumerableProperty, objectify } from '@sentry/utils';
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { LoadEvent, ServerLoadEvent } from '@sveltejs/kit';

import type { SentryWrappedFlag } from '../common/utils';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless } from './utils';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedLoadEvent = LoadEvent & SentryWrappedFlag;
type PatchedServerLoadEvent = ServerLoadEvent & SentryWrappedFlag;

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'load',
},
},
});

return objectifiedErr;
}

/**
* @inheritdoc
*/
Expand DownExpand Up@@ -81,7 +45,7 @@ export function wrapLoadWithSentry<T extends (...args: any) => any>(origLoad: T)
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand DownExpand Up@@ -146,7 +110,7 @@ export function wrapServerLoadWithSentry<T extends (...args: any) => any>(origSe
() => wrappingTarget.apply(thisArg, args),
);
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand Down
67 changes: 67 additions & 0 deletions packages/sveltekit/src/server/serverRoute.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedServerRouteEvent = RequestEvent & { __sentry_wrapped__?: boolean };

/**
* Wraps a server route handler for API or server routes registered in `+server.(js|js)` files.
*
* This function will automatically capture any errors that occur during the execution of the route handler
* and it will start a span for the duration of your route handler.
*
* @example
* ```js
* import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
*
* const get = async event => {
* return new Response(JSON.stringify({ message: 'hello world' }));
* }
*
* export const GET = wrapServerRouteWithSentry(get);
* ```
*
* @param originalRouteHandler your server route handler
* @param httpMethod the HTTP method of your route handler
*
* @returns a wrapped version of your server route handler
*/
export function wrapServerRouteWithSentry(
originalRouteHandler: (request: RequestEvent) => Promise<Response>,
): (requestEvent: RequestEvent) => Promise<Response> {
return new Proxy(originalRouteHandler, {
apply: async (wrappingTarget, thisArg, args) => {
const event = args[0] as PatchedServerRouteEvent;

if (event.__sentry_wrapped__) {
return wrappingTarget.apply(thisArg, args);
}

const routeId = event.route && event.route.id;
const httpMethod = event.request.method;

addNonEnumerableProperty(event as unknown as Record<string, unknown>, '__sentry_wrapped__', true);

try {
return await startSpan(
{
name: `${httpMethod} ${routeId || 'Server Route'}`,
op: `function.sveltekit.server.${httpMethod.toLowerCase()}`,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.function.sveltekit',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
},
onlyIfParent: true,
},
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e, 'serverRoute');
throw e;
} finally {
await flushIfServerless();
}
},
});
}
43 changes: 41 additions & 2 deletions packages/sveltekit/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
import { flush } from '@sentry/node';
import { logger } from '@sentry/utils';
import { captureException, flush } from '@sentry/node';
import { logger, objectify } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';

/**
* Takes a request event and extracts traceparent and DSC data
Expand DownExpand Up@@ -31,3 +32,41 @@ export async function flushIfServerless(): Promise<void> {
}
}
}

/**
* Extracts a server-side sveltekit error, filters a couple of known errors we don't want to capture
* and captures the error via `captureException`.
*
* @param e error
*
* @returns an objectified version of @param e
*/
export function sendErrorToSentry(e: unknown, handlerFn: 'handle' | 'load' | 'serverRoute'): object {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: handlerFn,
},
},
});

return objectifiedErr;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,4 +38,7 @@
<li>
<a href="components">Component Tracking</a>
</li>
<li>
<a href="/wrap-server-route">server routes</a>
</li>
</ul>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
<script lang="ts">
export let data;
</script>

<p>
Message from API: {data.myMessage}
</p>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export const load = async ({ fetch }) => {
const res = await fetch('/wrap-server-route/api');
const myMessage = await res.json();
return {
myMessage: myMessage.myMessage,
};
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
import { error } from '@sveltejs/kit';

export const GET = wrapServerRouteWithSentry(async () => {
error(500, 'error() error');
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,4 +58,37 @@ test.describe('server-side errors', () => {

expect(errorEvent.transaction).toEqual('GET /server-route-error');
});

test('captures error() thrown in server route with `wrapServerRouteWithSentry`', async ({ page }) => {
const errorEventPromise = waitForError('sveltekit-2', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === "'HttpError' captured as exception with keys: body, status";
});

await page.goto('/wrap-server-route');

expect(await errorEventPromise).toMatchObject({
exception: {
values: [
{
value: "'HttpError' captured as exception with keys: body, status",
mechanism: {
handled: false,
data: {
function: 'serverRoute',
},
},
stacktrace: { frames: expect.any(Array) },
},
],
},
extra: {
__serialized__: {
body: {
message: 'error() error',
},
status: 500,
},
},
});
});
});
40 changes: 4 additions & 36 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,21 +11,15 @@ import {
withIsolationScope,
} from '@sentry/core';
import { startSpan } from '@sentry/core';
import { captureException, continueTrace } from '@sentry/node';
import { continueTrace } from '@sentry/node';
import type { Span } from '@sentry/types';
import {
dynamicSamplingContextToSentryBaggageHeader,
logger,
objectify,
winterCGRequestToRequestData,
} from '@sentry/utils';
import { dynamicSamplingContextToSentryBaggageHeader, logger, winterCGRequestToRequestData } from '@sentry/utils';
import type { Handle, ResolveOptions } from '@sveltejs/kit';

import { getDynamicSamplingContextFromSpan } from '@sentry/opentelemetry';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless, getTracePropagationData } from './utils';
import { flushIfServerless, getTracePropagationData, sendErrorToSentry } from './utils';

export type SentryHandleOptions = {
/**
Expand DownExpand Up@@ -62,32 +56,6 @@ export type SentryHandleOptions = {
fetchProxyScriptNonce?: string;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// similarly to the `load` function, we don't want to capture 4xx errors or redirects
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'handle',
},
},
});

return objectifiedErr;
}

/**
* Exported only for testing
*/
Expand DownExpand Up@@ -225,7 +193,7 @@ async function instrumentHandle(
);
return resolveResult;
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'handle');
throw e;
} finally {
await flushIfServerless();
Expand Down
1 change: 1 addition & 0 deletions packages/sveltekit/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -128,6 +128,7 @@ export { init } from './sdk';
export { handleErrorWithSentry } from './handleError';
export { wrapLoadWithSentry, wrapServerLoadWithSentry } from './load';
export { sentryHandle } from './handle';
export { wrapServerRouteWithSentry } from './serverRoute';

/**
* Tracks the Svelte component's initialization and mounting operation as well as
Expand Down
46 changes: 5 additions & 41 deletions packages/sveltekit/src/server/load.ts
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,13 @@
import {
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
captureException,
startSpan,
} from '@sentry/node';
import { addNonEnumerableProperty, objectify } from '@sentry/utils';
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { LoadEvent, ServerLoadEvent } from '@sveltejs/kit';

import type { SentryWrappedFlag } from '../common/utils';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless } from './utils';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedLoadEvent = LoadEvent & SentryWrappedFlag;
type PatchedServerLoadEvent = ServerLoadEvent & SentryWrappedFlag;

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'load',
},
},
});

return objectifiedErr;
}

/**
* @inheritdoc
*/
Expand DownExpand Up@@ -81,7 +45,7 @@ export function wrapLoadWithSentry<T extends (...args: any) => any>(origLoad: T)
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand DownExpand Up@@ -146,7 +110,7 @@ export function wrapServerLoadWithSentry<T extends (...args: any) => any>(origSe
() => wrappingTarget.apply(thisArg, args),
);
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand Down
67 changes: 67 additions & 0 deletions packages/sveltekit/src/server/serverRoute.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedServerRouteEvent = RequestEvent & { __sentry_wrapped__?: boolean };

/**
* Wraps a server route handler for API or server routes registered in `+server.(js|js)` files.
*
* This function will automatically capture any errors that occur during the execution of the route handler
* and it will start a span for the duration of your route handler.
*
* @example
* ```js
* import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
*
* const get = async event => {
* return new Response(JSON.stringify({ message: 'hello world' }));
* }
*
* export const GET = wrapServerRouteWithSentry(get);
* ```
*
* @param originalRouteHandler your server route handler
* @param httpMethod the HTTP method of your route handler
*
* @returns a wrapped version of your server route handler
*/
export function wrapServerRouteWithSentry(
originalRouteHandler: (request: RequestEvent) => Promise<Response>,
): (requestEvent: RequestEvent) => Promise<Response> {
return new Proxy(originalRouteHandler, {
apply: async (wrappingTarget, thisArg, args) => {
const event = args[0] as PatchedServerRouteEvent;

if (event.__sentry_wrapped__) {
return wrappingTarget.apply(thisArg, args);
}

const routeId = event.route && event.route.id;
const httpMethod = event.request.method;

addNonEnumerableProperty(event as unknown as Record<string, unknown>, '__sentry_wrapped__', true);

try {
return await startSpan(
{
name: `${httpMethod} ${routeId || 'Server Route'}`,
op: `function.sveltekit.server.${httpMethod.toLowerCase()}`,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.function.sveltekit',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
},
onlyIfParent: true,
},
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e, 'serverRoute');
throw e;
} finally {
await flushIfServerless();
}
},
});
}
43 changes: 41 additions & 2 deletions packages/sveltekit/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
import { flush } from '@sentry/node';
import { logger } from '@sentry/utils';
import { captureException, flush } from '@sentry/node';
import { logger, objectify } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';

/**
* Takes a request event and extracts traceparent and DSC data
Expand DownExpand Up@@ -31,3 +32,41 @@ export async function flushIfServerless(): Promise<void> {
}
}
}

/**
* Extracts a server-side sveltekit error, filters a couple of known errors we don't want to capture
* and captures the error via `captureException`.
*
* @param e error
*
* @returns an objectified version of @param e
*/
export function sendErrorToSentry(e: unknown, handlerFn: 'handle' | 'load' | 'serverRoute'): object {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: handlerFn,
},
},
});

return objectifiedErr;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,4 +38,7 @@
<li>
<a href="components">Component Tracking</a>
</li>
<li>
<a href="/wrap-server-route">server routes</a>
</li>
</ul>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
<script lang="ts">
export let data;
</script>

<p>
Message from API: {data.myMessage}
</p>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export const load = async ({ fetch }) => {
const res = await fetch('/wrap-server-route/api');
const myMessage = await res.json();
return {
myMessage: myMessage.myMessage,
};
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
import { error } from '@sveltejs/kit';

export const GET = wrapServerRouteWithSentry(async () => {
error(500, 'error() error');
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,4 +58,37 @@ test.describe('server-side errors', () => {

expect(errorEvent.transaction).toEqual('GET /server-route-error');
});

test('captures error() thrown in server route with `wrapServerRouteWithSentry`', async ({ page }) => {
const errorEventPromise = waitForError('sveltekit-2', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === "'HttpError' captured as exception with keys: body, status";
});

await page.goto('/wrap-server-route');

expect(await errorEventPromise).toMatchObject({
exception: {
values: [
{
value: "'HttpError' captured as exception with keys: body, status",
mechanism: {
handled: false,
data: {
function: 'serverRoute',
},
},
stacktrace: { frames: expect.any(Array) },
},
],
},
extra: {
__serialized__: {
body: {
message: 'error() error',
},
status: 500,
},
},
});
});
});
40 changes: 4 additions & 36 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,21 +11,15 @@ import {
withIsolationScope,
} from '@sentry/core';
import { startSpan } from '@sentry/core';
import { captureException, continueTrace } from '@sentry/node';
import { continueTrace } from '@sentry/node';
import type { Span } from '@sentry/types';
import {
dynamicSamplingContextToSentryBaggageHeader,
logger,
objectify,
winterCGRequestToRequestData,
} from '@sentry/utils';
import { dynamicSamplingContextToSentryBaggageHeader, logger, winterCGRequestToRequestData } from '@sentry/utils';
import type { Handle, ResolveOptions } from '@sveltejs/kit';

import { getDynamicSamplingContextFromSpan } from '@sentry/opentelemetry';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless, getTracePropagationData } from './utils';
import { flushIfServerless, getTracePropagationData, sendErrorToSentry } from './utils';

export type SentryHandleOptions = {
/**
Expand DownExpand Up@@ -62,32 +56,6 @@ export type SentryHandleOptions = {
fetchProxyScriptNonce?: string;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// similarly to the `load` function, we don't want to capture 4xx errors or redirects
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'handle',
},
},
});

return objectifiedErr;
}

/**
* Exported only for testing
*/
Expand DownExpand Up@@ -225,7 +193,7 @@ async function instrumentHandle(
);
return resolveResult;
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'handle');
throw e;
} finally {
await flushIfServerless();
Expand Down
1 change: 1 addition & 0 deletions packages/sveltekit/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -128,6 +128,7 @@ export { init } from './sdk';
export { handleErrorWithSentry } from './handleError';
export { wrapLoadWithSentry, wrapServerLoadWithSentry } from './load';
export { sentryHandle } from './handle';
export { wrapServerRouteWithSentry } from './serverRoute';

/**
* Tracks the Svelte component's initialization and mounting operation as well as
Expand Down
46 changes: 5 additions & 41 deletions packages/sveltekit/src/server/load.ts
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,13 @@
import {
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
captureException,
startSpan,
} from '@sentry/node';
import { addNonEnumerableProperty, objectify } from '@sentry/utils';
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { LoadEvent, ServerLoadEvent } from '@sveltejs/kit';

import type { SentryWrappedFlag } from '../common/utils';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless } from './utils';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedLoadEvent = LoadEvent & SentryWrappedFlag;
type PatchedServerLoadEvent = ServerLoadEvent & SentryWrappedFlag;

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'load',
},
},
});

return objectifiedErr;
}

/**
* @inheritdoc
*/
Expand DownExpand Up@@ -81,7 +45,7 @@ export function wrapLoadWithSentry<T extends (...args: any) => any>(origLoad: T)
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand DownExpand Up@@ -146,7 +110,7 @@ export function wrapServerLoadWithSentry<T extends (...args: any) => any>(origSe
() => wrappingTarget.apply(thisArg, args),
);
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand Down
67 changes: 67 additions & 0 deletions packages/sveltekit/src/server/serverRoute.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedServerRouteEvent = RequestEvent & { __sentry_wrapped__?: boolean };

/**
* Wraps a server route handler for API or server routes registered in `+server.(js|js)` files.
*
* This function will automatically capture any errors that occur during the execution of the route handler
* and it will start a span for the duration of your route handler.
*
* @example
* ```js
* import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
*
* const get = async event => {
* return new Response(JSON.stringify({ message: 'hello world' }));
* }
*
* export const GET = wrapServerRouteWithSentry(get);
* ```
*
* @param originalRouteHandler your server route handler
* @param httpMethod the HTTP method of your route handler
*
* @returns a wrapped version of your server route handler
*/
export function wrapServerRouteWithSentry(
originalRouteHandler: (request: RequestEvent) => Promise<Response>,
): (requestEvent: RequestEvent) => Promise<Response> {
return new Proxy(originalRouteHandler, {
apply: async (wrappingTarget, thisArg, args) => {
const event = args[0] as PatchedServerRouteEvent;

if (event.__sentry_wrapped__) {
return wrappingTarget.apply(thisArg, args);
}

const routeId = event.route && event.route.id;
const httpMethod = event.request.method;

addNonEnumerableProperty(event as unknown as Record<string, unknown>, '__sentry_wrapped__', true);

try {
return await startSpan(
{
name: `${httpMethod} ${routeId || 'Server Route'}`,
op: `function.sveltekit.server.${httpMethod.toLowerCase()}`,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.function.sveltekit',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
},
onlyIfParent: true,
},
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e, 'serverRoute');
throw e;
} finally {
await flushIfServerless();
}
},
});
}
43 changes: 41 additions & 2 deletions packages/sveltekit/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
import { flush } from '@sentry/node';
import { logger } from '@sentry/utils';
import { captureException, flush } from '@sentry/node';
import { logger, objectify } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';

/**
* Takes a request event and extracts traceparent and DSC data
Expand DownExpand Up@@ -31,3 +32,41 @@ export async function flushIfServerless(): Promise<void> {
}
}
}

/**
* Extracts a server-side sveltekit error, filters a couple of known errors we don't want to capture
* and captures the error via `captureException`.
*
* @param e error
*
* @returns an objectified version of @param e
*/
export function sendErrorToSentry(e: unknown, handlerFn: 'handle' | 'load' | 'serverRoute'): object {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: handlerFn,
},
},
});

return objectifiedErr;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,4 +38,7 @@
<li>
<a href="components">Component Tracking</a>
</li>
<li>
<a href="/wrap-server-route">server routes</a>
</li>
</ul>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
<script lang="ts">
export let data;
</script>

<p>
Message from API: {data.myMessage}
</p>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export const load = async ({ fetch }) => {
const res = await fetch('/wrap-server-route/api');
const myMessage = await res.json();
return {
myMessage: myMessage.myMessage,
};
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
import { error } from '@sveltejs/kit';

export const GET = wrapServerRouteWithSentry(async () => {
error(500, 'error() error');
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,4 +58,37 @@ test.describe('server-side errors', () => {

expect(errorEvent.transaction).toEqual('GET /server-route-error');
});

test('captures error() thrown in server route with `wrapServerRouteWithSentry`', async ({ page }) => {
const errorEventPromise = waitForError('sveltekit-2', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === "'HttpError' captured as exception with keys: body, status";
});

await page.goto('/wrap-server-route');

expect(await errorEventPromise).toMatchObject({
exception: {
values: [
{
value: "'HttpError' captured as exception with keys: body, status",
mechanism: {
handled: false,
data: {
function: 'serverRoute',
},
},
stacktrace: { frames: expect.any(Array) },
},
],
},
extra: {
__serialized__: {
body: {
message: 'error() error',
},
status: 500,
},
},
});
});
});
40 changes: 4 additions & 36 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,21 +11,15 @@ import {
withIsolationScope,
} from '@sentry/core';
import { startSpan } from '@sentry/core';
import { captureException, continueTrace } from '@sentry/node';
import { continueTrace } from '@sentry/node';
import type { Span } from '@sentry/types';
import {
dynamicSamplingContextToSentryBaggageHeader,
logger,
objectify,
winterCGRequestToRequestData,
} from '@sentry/utils';
import { dynamicSamplingContextToSentryBaggageHeader, logger, winterCGRequestToRequestData } from '@sentry/utils';
import type { Handle, ResolveOptions } from '@sveltejs/kit';

import { getDynamicSamplingContextFromSpan } from '@sentry/opentelemetry';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless, getTracePropagationData } from './utils';
import { flushIfServerless, getTracePropagationData, sendErrorToSentry } from './utils';

export type SentryHandleOptions = {
/**
Expand DownExpand Up@@ -62,32 +56,6 @@ export type SentryHandleOptions = {
fetchProxyScriptNonce?: string;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// similarly to the `load` function, we don't want to capture 4xx errors or redirects
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'handle',
},
},
});

return objectifiedErr;
}

/**
* Exported only for testing
*/
Expand DownExpand Up@@ -225,7 +193,7 @@ async function instrumentHandle(
);
return resolveResult;
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'handle');
throw e;
} finally {
await flushIfServerless();
Expand Down
1 change: 1 addition & 0 deletions packages/sveltekit/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -128,6 +128,7 @@ export { init } from './sdk';
export { handleErrorWithSentry } from './handleError';
export { wrapLoadWithSentry, wrapServerLoadWithSentry } from './load';
export { sentryHandle } from './handle';
export { wrapServerRouteWithSentry } from './serverRoute';

/**
* Tracks the Svelte component's initialization and mounting operation as well as
Expand Down
46 changes: 5 additions & 41 deletions packages/sveltekit/src/server/load.ts
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,13 @@
import {
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
captureException,
startSpan,
} from '@sentry/node';
import { addNonEnumerableProperty, objectify } from '@sentry/utils';
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { LoadEvent, ServerLoadEvent } from '@sveltejs/kit';

import type { SentryWrappedFlag } from '../common/utils';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless } from './utils';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedLoadEvent = LoadEvent & SentryWrappedFlag;
type PatchedServerLoadEvent = ServerLoadEvent & SentryWrappedFlag;

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'load',
},
},
});

return objectifiedErr;
}

/**
* @inheritdoc
*/
Expand DownExpand Up@@ -81,7 +45,7 @@ export function wrapLoadWithSentry<T extends (...args: any) => any>(origLoad: T)
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand DownExpand Up@@ -146,7 +110,7 @@ export function wrapServerLoadWithSentry<T extends (...args: any) => any>(origSe
() => wrappingTarget.apply(thisArg, args),
);
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand Down
67 changes: 67 additions & 0 deletions packages/sveltekit/src/server/serverRoute.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedServerRouteEvent = RequestEvent & { __sentry_wrapped__?: boolean };

/**
* Wraps a server route handler for API or server routes registered in `+server.(js|js)` files.
*
* This function will automatically capture any errors that occur during the execution of the route handler
* and it will start a span for the duration of your route handler.
*
* @example
* ```js
* import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
*
* const get = async event => {
* return new Response(JSON.stringify({ message: 'hello world' }));
* }
*
* export const GET = wrapServerRouteWithSentry(get);
* ```
*
* @param originalRouteHandler your server route handler
* @param httpMethod the HTTP method of your route handler
*
* @returns a wrapped version of your server route handler
*/
export function wrapServerRouteWithSentry(
originalRouteHandler: (request: RequestEvent) => Promise<Response>,
): (requestEvent: RequestEvent) => Promise<Response> {
return new Proxy(originalRouteHandler, {
apply: async (wrappingTarget, thisArg, args) => {
const event = args[0] as PatchedServerRouteEvent;

if (event.__sentry_wrapped__) {
return wrappingTarget.apply(thisArg, args);
}

const routeId = event.route && event.route.id;
const httpMethod = event.request.method;

addNonEnumerableProperty(event as unknown as Record<string, unknown>, '__sentry_wrapped__', true);

try {
return await startSpan(
{
name: `${httpMethod} ${routeId || 'Server Route'}`,
op: `function.sveltekit.server.${httpMethod.toLowerCase()}`,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.function.sveltekit',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
},
onlyIfParent: true,
},
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e, 'serverRoute');
throw e;
} finally {
await flushIfServerless();
}
},
});
}
43 changes: 41 additions & 2 deletions packages/sveltekit/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
import { flush } from '@sentry/node';
import { logger } from '@sentry/utils';
import { captureException, flush } from '@sentry/node';
import { logger, objectify } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';

/**
* Takes a request event and extracts traceparent and DSC data
Expand DownExpand Up@@ -31,3 +32,41 @@ export async function flushIfServerless(): Promise<void> {
}
}
}

/**
* Extracts a server-side sveltekit error, filters a couple of known errors we don't want to capture
* and captures the error via `captureException`.
*
* @param e error
*
* @returns an objectified version of @param e
*/
export function sendErrorToSentry(e: unknown, handlerFn: 'handle' | 'load' | 'serverRoute'): object {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: handlerFn,
},
},
});

return objectifiedErr;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,4 +38,7 @@
<li>
<a href="components">Component Tracking</a>
</li>
<li>
<a href="/wrap-server-route">server routes</a>
</li>
</ul>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
<script lang="ts">
export let data;
</script>

<p>
Message from API: {data.myMessage}
</p>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export const load = async ({ fetch }) => {
const res = await fetch('/wrap-server-route/api');
const myMessage = await res.json();
return {
myMessage: myMessage.myMessage,
};
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
import { error } from '@sveltejs/kit';

export const GET = wrapServerRouteWithSentry(async () => {
error(500, 'error() error');
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,4 +58,37 @@ test.describe('server-side errors', () => {

expect(errorEvent.transaction).toEqual('GET /server-route-error');
});

test('captures error() thrown in server route with `wrapServerRouteWithSentry`', async ({ page }) => {
const errorEventPromise = waitForError('sveltekit-2', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === "'HttpError' captured as exception with keys: body, status";
});

await page.goto('/wrap-server-route');

expect(await errorEventPromise).toMatchObject({
exception: {
values: [
{
value: "'HttpError' captured as exception with keys: body, status",
mechanism: {
handled: false,
data: {
function: 'serverRoute',
},
},
stacktrace: { frames: expect.any(Array) },
},
],
},
extra: {
__serialized__: {
body: {
message: 'error() error',
},
status: 500,
},
},
});
});
});
40 changes: 4 additions & 36 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,21 +11,15 @@ import {
withIsolationScope,
} from '@sentry/core';
import { startSpan } from '@sentry/core';
import { captureException, continueTrace } from '@sentry/node';
import { continueTrace } from '@sentry/node';
import type { Span } from '@sentry/types';
import {
dynamicSamplingContextToSentryBaggageHeader,
logger,
objectify,
winterCGRequestToRequestData,
} from '@sentry/utils';
import { dynamicSamplingContextToSentryBaggageHeader, logger, winterCGRequestToRequestData } from '@sentry/utils';
import type { Handle, ResolveOptions } from '@sveltejs/kit';

import { getDynamicSamplingContextFromSpan } from '@sentry/opentelemetry';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless, getTracePropagationData } from './utils';
import { flushIfServerless, getTracePropagationData, sendErrorToSentry } from './utils';

export type SentryHandleOptions = {
/**
Expand DownExpand Up@@ -62,32 +56,6 @@ export type SentryHandleOptions = {
fetchProxyScriptNonce?: string;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// similarly to the `load` function, we don't want to capture 4xx errors or redirects
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'handle',
},
},
});

return objectifiedErr;
}

/**
* Exported only for testing
*/
Expand DownExpand Up@@ -225,7 +193,7 @@ async function instrumentHandle(
);
return resolveResult;
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'handle');
throw e;
} finally {
await flushIfServerless();
Expand Down
1 change: 1 addition & 0 deletions packages/sveltekit/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -128,6 +128,7 @@ export { init } from './sdk';
export { handleErrorWithSentry } from './handleError';
export { wrapLoadWithSentry, wrapServerLoadWithSentry } from './load';
export { sentryHandle } from './handle';
export { wrapServerRouteWithSentry } from './serverRoute';

/**
* Tracks the Svelte component's initialization and mounting operation as well as
Expand Down
46 changes: 5 additions & 41 deletions packages/sveltekit/src/server/load.ts
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,13 @@
import {
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
captureException,
startSpan,
} from '@sentry/node';
import { addNonEnumerableProperty, objectify } from '@sentry/utils';
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { LoadEvent, ServerLoadEvent } from '@sveltejs/kit';

import type { SentryWrappedFlag } from '../common/utils';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless } from './utils';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedLoadEvent = LoadEvent & SentryWrappedFlag;
type PatchedServerLoadEvent = ServerLoadEvent & SentryWrappedFlag;

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'load',
},
},
});

return objectifiedErr;
}

/**
* @inheritdoc
*/
Expand DownExpand Up@@ -81,7 +45,7 @@ export function wrapLoadWithSentry<T extends (...args: any) => any>(origLoad: T)
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand DownExpand Up@@ -146,7 +110,7 @@ export function wrapServerLoadWithSentry<T extends (...args: any) => any>(origSe
() => wrappingTarget.apply(thisArg, args),
);
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand Down
67 changes: 67 additions & 0 deletions packages/sveltekit/src/server/serverRoute.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedServerRouteEvent = RequestEvent & { __sentry_wrapped__?: boolean };

/**
* Wraps a server route handler for API or server routes registered in `+server.(js|js)` files.
*
* This function will automatically capture any errors that occur during the execution of the route handler
* and it will start a span for the duration of your route handler.
*
* @example
* ```js
* import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
*
* const get = async event => {
* return new Response(JSON.stringify({ message: 'hello world' }));
* }
*
* export const GET = wrapServerRouteWithSentry(get);
* ```
*
* @param originalRouteHandler your server route handler
* @param httpMethod the HTTP method of your route handler
*
* @returns a wrapped version of your server route handler
*/
export function wrapServerRouteWithSentry(
originalRouteHandler: (request: RequestEvent) => Promise<Response>,
): (requestEvent: RequestEvent) => Promise<Response> {
return new Proxy(originalRouteHandler, {
apply: async (wrappingTarget, thisArg, args) => {
const event = args[0] as PatchedServerRouteEvent;

if (event.__sentry_wrapped__) {
return wrappingTarget.apply(thisArg, args);
}

const routeId = event.route && event.route.id;
const httpMethod = event.request.method;

addNonEnumerableProperty(event as unknown as Record<string, unknown>, '__sentry_wrapped__', true);

try {
return await startSpan(
{
name: `${httpMethod} ${routeId || 'Server Route'}`,
op: `function.sveltekit.server.${httpMethod.toLowerCase()}`,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.function.sveltekit',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
},
onlyIfParent: true,
},
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e, 'serverRoute');
throw e;
} finally {
await flushIfServerless();
}
},
});
}
43 changes: 41 additions & 2 deletions packages/sveltekit/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
import { flush } from '@sentry/node';
import { logger } from '@sentry/utils';
import { captureException, flush } from '@sentry/node';
import { logger, objectify } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';

/**
* Takes a request event and extracts traceparent and DSC data
Expand DownExpand Up@@ -31,3 +32,41 @@ export async function flushIfServerless(): Promise<void> {
}
}
}

/**
* Extracts a server-side sveltekit error, filters a couple of known errors we don't want to capture
* and captures the error via `captureException`.
*
* @param e error
*
* @returns an objectified version of @param e
*/
export function sendErrorToSentry(e: unknown, handlerFn: 'handle' | 'load' | 'serverRoute'): object {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: handlerFn,
},
},
});

return objectifiedErr;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,4 +38,7 @@
<li>
<a href="components">Component Tracking</a>
</li>
<li>
<a href="/wrap-server-route">server routes</a>
</li>
</ul>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
<script lang="ts">
export let data;
</script>

<p>
Message from API: {data.myMessage}
</p>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export const load = async ({ fetch }) => {
const res = await fetch('/wrap-server-route/api');
const myMessage = await res.json();
return {
myMessage: myMessage.myMessage,
};
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
import { error } from '@sveltejs/kit';

export const GET = wrapServerRouteWithSentry(async () => {
error(500, 'error() error');
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,4 +58,37 @@ test.describe('server-side errors', () => {

expect(errorEvent.transaction).toEqual('GET /server-route-error');
});

test('captures error() thrown in server route with `wrapServerRouteWithSentry`', async ({ page }) => {
const errorEventPromise = waitForError('sveltekit-2', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === "'HttpError' captured as exception with keys: body, status";
});

await page.goto('/wrap-server-route');

expect(await errorEventPromise).toMatchObject({
exception: {
values: [
{
value: "'HttpError' captured as exception with keys: body, status",
mechanism: {
handled: false,
data: {
function: 'serverRoute',
},
},
stacktrace: { frames: expect.any(Array) },
},
],
},
extra: {
__serialized__: {
body: {
message: 'error() error',
},
status: 500,
},
},
});
});
});
40 changes: 4 additions & 36 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,21 +11,15 @@ import {
withIsolationScope,
} from '@sentry/core';
import { startSpan } from '@sentry/core';
import { captureException, continueTrace } from '@sentry/node';
import { continueTrace } from '@sentry/node';
import type { Span } from '@sentry/types';
import {
dynamicSamplingContextToSentryBaggageHeader,
logger,
objectify,
winterCGRequestToRequestData,
} from '@sentry/utils';
import { dynamicSamplingContextToSentryBaggageHeader, logger, winterCGRequestToRequestData } from '@sentry/utils';
import type { Handle, ResolveOptions } from '@sveltejs/kit';

import { getDynamicSamplingContextFromSpan } from '@sentry/opentelemetry';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless, getTracePropagationData } from './utils';
import { flushIfServerless, getTracePropagationData, sendErrorToSentry } from './utils';

export type SentryHandleOptions = {
/**
Expand DownExpand Up@@ -62,32 +56,6 @@ export type SentryHandleOptions = {
fetchProxyScriptNonce?: string;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// similarly to the `load` function, we don't want to capture 4xx errors or redirects
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'handle',
},
},
});

return objectifiedErr;
}

/**
* Exported only for testing
*/
Expand DownExpand Up@@ -225,7 +193,7 @@ async function instrumentHandle(
);
return resolveResult;
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'handle');
throw e;
} finally {
await flushIfServerless();
Expand Down
1 change: 1 addition & 0 deletions packages/sveltekit/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -128,6 +128,7 @@ export { init } from './sdk';
export { handleErrorWithSentry } from './handleError';
export { wrapLoadWithSentry, wrapServerLoadWithSentry } from './load';
export { sentryHandle } from './handle';
export { wrapServerRouteWithSentry } from './serverRoute';

/**
* Tracks the Svelte component's initialization and mounting operation as well as
Expand Down
46 changes: 5 additions & 41 deletions packages/sveltekit/src/server/load.ts
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,13 @@
import {
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
captureException,
startSpan,
} from '@sentry/node';
import { addNonEnumerableProperty, objectify } from '@sentry/utils';
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { LoadEvent, ServerLoadEvent } from '@sveltejs/kit';

import type { SentryWrappedFlag } from '../common/utils';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless } from './utils';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedLoadEvent = LoadEvent & SentryWrappedFlag;
type PatchedServerLoadEvent = ServerLoadEvent & SentryWrappedFlag;

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'load',
},
},
});

return objectifiedErr;
}

/**
* @inheritdoc
*/
Expand DownExpand Up@@ -81,7 +45,7 @@ export function wrapLoadWithSentry<T extends (...args: any) => any>(origLoad: T)
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand DownExpand Up@@ -146,7 +110,7 @@ export function wrapServerLoadWithSentry<T extends (...args: any) => any>(origSe
() => wrappingTarget.apply(thisArg, args),
);
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand Down
67 changes: 67 additions & 0 deletions packages/sveltekit/src/server/serverRoute.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedServerRouteEvent = RequestEvent & { __sentry_wrapped__?: boolean };

/**
* Wraps a server route handler for API or server routes registered in `+server.(js|js)` files.
*
* This function will automatically capture any errors that occur during the execution of the route handler
* and it will start a span for the duration of your route handler.
*
* @example
* ```js
* import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
*
* const get = async event => {
* return new Response(JSON.stringify({ message: 'hello world' }));
* }
*
* export const GET = wrapServerRouteWithSentry(get);
* ```
*
* @param originalRouteHandler your server route handler
* @param httpMethod the HTTP method of your route handler
*
* @returns a wrapped version of your server route handler
*/
export function wrapServerRouteWithSentry(
originalRouteHandler: (request: RequestEvent) => Promise<Response>,
): (requestEvent: RequestEvent) => Promise<Response> {
return new Proxy(originalRouteHandler, {
apply: async (wrappingTarget, thisArg, args) => {
const event = args[0] as PatchedServerRouteEvent;

if (event.__sentry_wrapped__) {
return wrappingTarget.apply(thisArg, args);
}

const routeId = event.route && event.route.id;
const httpMethod = event.request.method;

addNonEnumerableProperty(event as unknown as Record<string, unknown>, '__sentry_wrapped__', true);

try {
return await startSpan(
{
name: `${httpMethod} ${routeId || 'Server Route'}`,
op: `function.sveltekit.server.${httpMethod.toLowerCase()}`,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.function.sveltekit',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
},
onlyIfParent: true,
},
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e, 'serverRoute');
throw e;
} finally {
await flushIfServerless();
}
},
});
}
43 changes: 41 additions & 2 deletions packages/sveltekit/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
import { flush } from '@sentry/node';
import { logger } from '@sentry/utils';
import { captureException, flush } from '@sentry/node';
import { logger, objectify } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';

/**
* Takes a request event and extracts traceparent and DSC data
Expand DownExpand Up@@ -31,3 +32,41 @@ export async function flushIfServerless(): Promise<void> {
}
}
}

/**
* Extracts a server-side sveltekit error, filters a couple of known errors we don't want to capture
* and captures the error via `captureException`.
*
* @param e error
*
* @returns an objectified version of @param e
*/
export function sendErrorToSentry(e: unknown, handlerFn: 'handle' | 'load' | 'serverRoute'): object {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: handlerFn,
},
},
});

return objectifiedErr;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,4 +38,7 @@
<li>
<a href="components">Component Tracking</a>
</li>
<li>
<a href="/wrap-server-route">server routes</a>
</li>
</ul>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
<script lang="ts">
export let data;
</script>

<p>
Message from API: {data.myMessage}
</p>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export const load = async ({ fetch }) => {
const res = await fetch('/wrap-server-route/api');
const myMessage = await res.json();
return {
myMessage: myMessage.myMessage,
};
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
import { error } from '@sveltejs/kit';

export const GET = wrapServerRouteWithSentry(async () => {
error(500, 'error() error');
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,4 +58,37 @@ test.describe('server-side errors', () => {

expect(errorEvent.transaction).toEqual('GET /server-route-error');
});

test('captures error() thrown in server route with `wrapServerRouteWithSentry`', async ({ page }) => {
const errorEventPromise = waitForError('sveltekit-2', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === "'HttpError' captured as exception with keys: body, status";
});

await page.goto('/wrap-server-route');

expect(await errorEventPromise).toMatchObject({
exception: {
values: [
{
value: "'HttpError' captured as exception with keys: body, status",
mechanism: {
handled: false,
data: {
function: 'serverRoute',
},
},
stacktrace: { frames: expect.any(Array) },
},
],
},
extra: {
__serialized__: {
body: {
message: 'error() error',
},
status: 500,
},
},
});
});
});
40 changes: 4 additions & 36 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,21 +11,15 @@ import {
withIsolationScope,
} from '@sentry/core';
import { startSpan } from '@sentry/core';
import { captureException, continueTrace } from '@sentry/node';
import { continueTrace } from '@sentry/node';
import type { Span } from '@sentry/types';
import {
dynamicSamplingContextToSentryBaggageHeader,
logger,
objectify,
winterCGRequestToRequestData,
} from '@sentry/utils';
import { dynamicSamplingContextToSentryBaggageHeader, logger, winterCGRequestToRequestData } from '@sentry/utils';
import type { Handle, ResolveOptions } from '@sveltejs/kit';

import { getDynamicSamplingContextFromSpan } from '@sentry/opentelemetry';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless, getTracePropagationData } from './utils';
import { flushIfServerless, getTracePropagationData, sendErrorToSentry } from './utils';

export type SentryHandleOptions = {
/**
Expand DownExpand Up@@ -62,32 +56,6 @@ export type SentryHandleOptions = {
fetchProxyScriptNonce?: string;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// similarly to the `load` function, we don't want to capture 4xx errors or redirects
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'handle',
},
},
});

return objectifiedErr;
}

/**
* Exported only for testing
*/
Expand DownExpand Up@@ -225,7 +193,7 @@ async function instrumentHandle(
);
return resolveResult;
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'handle');
throw e;
} finally {
await flushIfServerless();
Expand Down
1 change: 1 addition & 0 deletions packages/sveltekit/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -128,6 +128,7 @@ export { init } from './sdk';
export { handleErrorWithSentry } from './handleError';
export { wrapLoadWithSentry, wrapServerLoadWithSentry } from './load';
export { sentryHandle } from './handle';
export { wrapServerRouteWithSentry } from './serverRoute';

/**
* Tracks the Svelte component's initialization and mounting operation as well as
Expand Down
46 changes: 5 additions & 41 deletions packages/sveltekit/src/server/load.ts
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,13 @@
import {
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
captureException,
startSpan,
} from '@sentry/node';
import { addNonEnumerableProperty, objectify } from '@sentry/utils';
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { LoadEvent, ServerLoadEvent } from '@sveltejs/kit';

import type { SentryWrappedFlag } from '../common/utils';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless } from './utils';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedLoadEvent = LoadEvent & SentryWrappedFlag;
type PatchedServerLoadEvent = ServerLoadEvent & SentryWrappedFlag;

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'load',
},
},
});

return objectifiedErr;
}

/**
* @inheritdoc
*/
Expand DownExpand Up@@ -81,7 +45,7 @@ export function wrapLoadWithSentry<T extends (...args: any) => any>(origLoad: T)
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand DownExpand Up@@ -146,7 +110,7 @@ export function wrapServerLoadWithSentry<T extends (...args: any) => any>(origSe
() => wrappingTarget.apply(thisArg, args),
);
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand Down
67 changes: 67 additions & 0 deletions packages/sveltekit/src/server/serverRoute.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedServerRouteEvent = RequestEvent & { __sentry_wrapped__?: boolean };

/**
* Wraps a server route handler for API or server routes registered in `+server.(js|js)` files.
*
* This function will automatically capture any errors that occur during the execution of the route handler
* and it will start a span for the duration of your route handler.
*
* @example
* ```js
* import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
*
* const get = async event => {
* return new Response(JSON.stringify({ message: 'hello world' }));
* }
*
* export const GET = wrapServerRouteWithSentry(get);
* ```
*
* @param originalRouteHandler your server route handler
* @param httpMethod the HTTP method of your route handler
*
* @returns a wrapped version of your server route handler
*/
export function wrapServerRouteWithSentry(
originalRouteHandler: (request: RequestEvent) => Promise<Response>,
): (requestEvent: RequestEvent) => Promise<Response> {
return new Proxy(originalRouteHandler, {
apply: async (wrappingTarget, thisArg, args) => {
const event = args[0] as PatchedServerRouteEvent;

if (event.__sentry_wrapped__) {
return wrappingTarget.apply(thisArg, args);
}

const routeId = event.route && event.route.id;
const httpMethod = event.request.method;

addNonEnumerableProperty(event as unknown as Record<string, unknown>, '__sentry_wrapped__', true);

try {
return await startSpan(
{
name: `${httpMethod} ${routeId || 'Server Route'}`,
op: `function.sveltekit.server.${httpMethod.toLowerCase()}`,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.function.sveltekit',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
},
onlyIfParent: true,
},
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e, 'serverRoute');
throw e;
} finally {
await flushIfServerless();
}
},
});
}
43 changes: 41 additions & 2 deletions packages/sveltekit/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
import { flush } from '@sentry/node';
import { logger } from '@sentry/utils';
import { captureException, flush } from '@sentry/node';
import { logger, objectify } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';

/**
* Takes a request event and extracts traceparent and DSC data
Expand DownExpand Up@@ -31,3 +32,41 @@ export async function flushIfServerless(): Promise<void> {
}
}
}

/**
* Extracts a server-side sveltekit error, filters a couple of known errors we don't want to capture
* and captures the error via `captureException`.
*
* @param e error
*
* @returns an objectified version of @param e
*/
export function sendErrorToSentry(e: unknown, handlerFn: 'handle' | 'load' | 'serverRoute'): object {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: handlerFn,
},
},
});

return objectifiedErr;
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,4 +38,7 @@
<li>
<a href="components">Component Tracking</a>
</li>
<li>
<a href="/wrap-server-route">server routes</a>
</li>
</ul>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
<script lang="ts">
export let data;
</script>

<p>
Message from API: {data.myMessage}
</p>
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
export const load = async ({ fetch }) => {
const res = await fetch('/wrap-server-route/api');
const myMessage = await res.json();
return {
myMessage: myMessage.myMessage,
};
};
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
import { error } from '@sveltejs/kit';

export const GET = wrapServerRouteWithSentry(async () => {
error(500, 'error() error');
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,4 +58,37 @@ test.describe('server-side errors', () => {

expect(errorEvent.transaction).toEqual('GET /server-route-error');
});

test('captures error() thrown in server route with `wrapServerRouteWithSentry`', async ({ page }) => {
const errorEventPromise = waitForError('sveltekit-2', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === "'HttpError' captured as exception with keys: body, status";
});

await page.goto('/wrap-server-route');

expect(await errorEventPromise).toMatchObject({
exception: {
values: [
{
value: "'HttpError' captured as exception with keys: body, status",
mechanism: {
handled: false,
data: {
function: 'serverRoute',
},
},
stacktrace: { frames: expect.any(Array) },
},
],
},
extra: {
__serialized__: {
body: {
message: 'error() error',
},
status: 500,
},
},
});
});
});
40 changes: 4 additions & 36 deletions packages/sveltekit/src/server/handle.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,21 +11,15 @@ import {
withIsolationScope,
} from '@sentry/core';
import { startSpan } from '@sentry/core';
import { captureException, continueTrace } from '@sentry/node';
import { continueTrace } from '@sentry/node';
import type { Span } from '@sentry/types';
import {
dynamicSamplingContextToSentryBaggageHeader,
logger,
objectify,
winterCGRequestToRequestData,
} from '@sentry/utils';
import { dynamicSamplingContextToSentryBaggageHeader, logger, winterCGRequestToRequestData } from '@sentry/utils';
import type { Handle, ResolveOptions } from '@sveltejs/kit';

import { getDynamicSamplingContextFromSpan } from '@sentry/opentelemetry';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless, getTracePropagationData } from './utils';
import { flushIfServerless, getTracePropagationData, sendErrorToSentry } from './utils';

export type SentryHandleOptions = {
/**
Expand DownExpand Up@@ -62,32 +56,6 @@ export type SentryHandleOptions = {
fetchProxyScriptNonce?: string;
};

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// similarly to the `load` function, we don't want to capture 4xx errors or redirects
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'handle',
},
},
});

return objectifiedErr;
}

/**
* Exported only for testing
*/
Expand DownExpand Up@@ -225,7 +193,7 @@ async function instrumentHandle(
);
return resolveResult;
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'handle');
throw e;
} finally {
await flushIfServerless();
Expand Down
1 change: 1 addition & 0 deletions packages/sveltekit/src/server/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -128,6 +128,7 @@ export { init } from './sdk';
export { handleErrorWithSentry } from './handleError';
export { wrapLoadWithSentry, wrapServerLoadWithSentry } from './load';
export { sentryHandle } from './handle';
export { wrapServerRouteWithSentry } from './serverRoute';

/**
* Tracks the Svelte component's initialization and mounting operation as well as
Expand Down
46 changes: 5 additions & 41 deletions packages/sveltekit/src/server/load.ts
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,13 @@
import {
SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN,
SEMANTIC_ATTRIBUTE_SENTRY_SOURCE,
captureException,
startSpan,
} from '@sentry/node';
import { addNonEnumerableProperty, objectify } from '@sentry/utils';
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { LoadEvent, ServerLoadEvent } from '@sveltejs/kit';

import type { SentryWrappedFlag } from '../common/utils';
import { isHttpError, isRedirect } from '../common/utils';
import { flushIfServerless } from './utils';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedLoadEvent = LoadEvent & SentryWrappedFlag;
type PatchedServerLoadEvent = ServerLoadEvent & SentryWrappedFlag;

function sendErrorToSentry(e: unknown): unknown {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: 'load',
},
},
});

return objectifiedErr;
}

/**
* @inheritdoc
*/
Expand DownExpand Up@@ -81,7 +45,7 @@ export function wrapLoadWithSentry<T extends (...args: any) => any>(origLoad: T)
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand DownExpand Up@@ -146,7 +110,7 @@ export function wrapServerLoadWithSentry<T extends (...args: any) => any>(origSe
() => wrappingTarget.apply(thisArg, args),
);
} catch (e: unknown) {
sendErrorToSentry(e);
sendErrorToSentry(e, 'load');
throw e;
} finally {
await flushIfServerless();
Expand Down
67 changes: 67 additions & 0 deletions packages/sveltekit/src/server/serverRoute.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,67 @@
import { SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN, SEMANTIC_ATTRIBUTE_SENTRY_SOURCE, startSpan } from '@sentry/node';
import { addNonEnumerableProperty } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';
import { flushIfServerless, sendErrorToSentry } from './utils';

type PatchedServerRouteEvent = RequestEvent & { __sentry_wrapped__?: boolean };

/**
* Wraps a server route handler for API or server routes registered in `+server.(js|js)` files.
*
* This function will automatically capture any errors that occur during the execution of the route handler
* and it will start a span for the duration of your route handler.
*
* @example
* ```js
* import { wrapServerRouteWithSentry } from '@sentry/sveltekit';
*
* const get = async event => {
* return new Response(JSON.stringify({ message: 'hello world' }));
* }
*
* export const GET = wrapServerRouteWithSentry(get);
* ```
*
* @param originalRouteHandler your server route handler
* @param httpMethod the HTTP method of your route handler
*
* @returns a wrapped version of your server route handler
*/
export function wrapServerRouteWithSentry(
originalRouteHandler: (request: RequestEvent) => Promise<Response>,
): (requestEvent: RequestEvent) => Promise<Response> {
return new Proxy(originalRouteHandler, {
apply: async (wrappingTarget, thisArg, args) => {
const event = args[0] as PatchedServerRouteEvent;

if (event.__sentry_wrapped__) {
return wrappingTarget.apply(thisArg, args);
}

const routeId = event.route && event.route.id;
const httpMethod = event.request.method;

addNonEnumerableProperty(event as unknown as Record<string, unknown>, '__sentry_wrapped__', true);

try {
return await startSpan(
{
name: `${httpMethod} ${routeId || 'Server Route'}`,
op: `function.sveltekit.server.${httpMethod.toLowerCase()}`,
attributes: {
[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.function.sveltekit',
[SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'route',
},
onlyIfParent: true,
},
() => wrappingTarget.apply(thisArg, args),
);
} catch (e) {
sendErrorToSentry(e, 'serverRoute');
throw e;
} finally {
await flushIfServerless();
}
},
});
}
43 changes: 41 additions & 2 deletions packages/sveltekit/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
import { flush } from '@sentry/node';
import { logger } from '@sentry/utils';
import { captureException, flush } from '@sentry/node';
import { logger, objectify } from '@sentry/utils';
import type { RequestEvent } from '@sveltejs/kit';

import { DEBUG_BUILD } from '../common/debug-build';
import { isHttpError, isRedirect } from '../common/utils';

/**
* Takes a request event and extracts traceparent and DSC data
Expand DownExpand Up@@ -31,3 +32,41 @@ export async function flushIfServerless(): Promise<void> {
}
}
}

/**
* Extracts a server-side sveltekit error, filters a couple of known errors we don't want to capture
* and captures the error via `captureException`.
*
* @param e error
*
* @returns an objectified version of @param e
*/
export function sendErrorToSentry(e: unknown, handlerFn: 'handle' | 'load' | 'serverRoute'): object {
// In case we have a primitive, wrap it in the equivalent wrapper class (string -> String, etc.) so that we can
// store a seen flag on it.
const objectifiedErr = objectify(e);

// The error() helper is commonly used to throw errors in load functions: https://kit.svelte.dev/docs/modules#sveltejs-kit-error
// If we detect a thrown error that is an instance of HttpError, we don't want to capture 4xx errors as they
// could be noisy.
// Also the `redirect(...)` helper is used to redirect users from one page to another. We don't want to capture thrown
// `Redirect`s as they're not errors but expected behaviour
if (
isRedirect(objectifiedErr) ||
(isHttpError(objectifiedErr) && objectifiedErr.status < 500 && objectifiedErr.status >= 400)
) {
return objectifiedErr;
}

captureException(objectifiedErr, {
mechanism: {
type: 'sveltekit',
handled: false,
data: {
function: handlerFn,
},
},
});

return objectifiedErr;
}
Loading