Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(node): Add fsInstrumentation#13291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3 dev-packages/node-integration-tests/suites/fs-instrumentation/fixtures/.gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| some-file.txt.* | ||
| some-file-promises.txt.* | ||
| some-file-promisify.txt.* |
8 changes: 8 additions & 0 deletions
8 ...packages/node-integration-tests/suites/fs-instrumentation/fixtures/some-file-promises.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| _____________________________ | ||
| < gimme some fs instrumentation > | ||
| ----------------------------- | ||
| \ ^__^ | ||
| \ (oo)\_______ | ||
| (__)\ )\/\\ | ||
| ||----w | | ||
| || || |
8 changes: 8 additions & 0 deletions
8 ...ackages/node-integration-tests/suites/fs-instrumentation/fixtures/some-file-promisify.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| _____________________________ | ||
| < gimme some fs instrumentation > | ||
| ----------------------------- | ||
| \ ^__^ | ||
| \ (oo)\_______ | ||
| (__)\ )\/\\ | ||
| ||----w | | ||
| || || |
8 changes: 8 additions & 0 deletions
8 dev-packages/node-integration-tests/suites/fs-instrumentation/fixtures/some-file.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| _____________________________ | ||
| < gimme some fs instrumentation > | ||
| ----------------------------- | ||
| \ ^__^ | ||
| \ (oo)\_______ | ||
| (__)\ )\/\\ | ||
| ||----w | | ||
| || || |
137 changes: 137 additions & 0 deletions
137 dev-packages/node-integration-tests/suites/fs-instrumentation/server.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,137 @@ | ||
| import { loggingTransport } from '@sentry-internal/node-integration-tests'; | ||
| import * as Sentry from '@sentry/node'; | ||
| Sentry.init({ | ||
| dsn: 'https://public@dsn.ingest.sentry.io/1337', | ||
| release: '1.0', | ||
| transport: loggingTransport, | ||
| tracesSampleRate: 1, | ||
| integrations: [ | ||
| Sentry.fsIntegration({ | ||
| recordFilePaths: true, | ||
| recordErrorMessagesAsSpanAttributes: true, | ||
| }), | ||
| ], | ||
| }); | ||
| import * as fs from 'fs'; | ||
| import * as os from 'os'; | ||
| import * as path from 'path'; | ||
| import * as util from 'util'; | ||
| import { startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests'; | ||
| import express from 'express'; | ||
| const app = express(); | ||
| app.get('/readFile-error', async (_, res) => { | ||
| try { | ||
| await fs.promises.readFile(path.join(__dirname, 'fixtures', 'some-file-that-doesnt-exist.txt'), 'utf-8'); | ||
| } catch { | ||
| // noop | ||
| } | ||
| res.send('done'); | ||
| }); | ||
| app.get('/readFile', async (_, res) => { | ||
| await new Promise<void>(resolve => { | ||
| fs.readFile(path.join(__dirname, 'fixtures', 'some-file.txt'), 'utf-8', () => { | ||
| resolve(); | ||
| }); | ||
| }); | ||
| await fs.promises.readFile(path.join(__dirname, 'fixtures', 'some-file-promises.txt'), 'utf-8'); | ||
| await util.promisify(fs.readFile)(path.join(__dirname, 'fixtures', 'some-file-promisify.txt'), 'utf-8'); | ||
| res.send('done'); | ||
| }); | ||
| app.get('/copyFile', async (_, res) => { | ||
| await new Promise<void>(resolve => { | ||
| fs.copyFile( | ||
| path.join(__dirname, 'fixtures', 'some-file.txt'), | ||
| path.join(__dirname, 'fixtures', 'some-file.txt.copy'), | ||
| () => { | ||
| resolve(); | ||
| }, | ||
| ); | ||
| }); | ||
| await fs.promises.copyFile( | ||
| path.join(__dirname, 'fixtures', 'some-file-promises.txt'), | ||
| path.join(__dirname, 'fixtures', 'some-file-promises.txt.copy'), | ||
| ); | ||
| await util.promisify(fs.copyFile)( | ||
| path.join(__dirname, 'fixtures', 'some-file-promisify.txt'), | ||
| path.join(__dirname, 'fixtures', 'some-file-promisify.txt.copy'), | ||
| ); | ||
| res.send('done'); | ||
| }); | ||
Comment on lines
+46
to
+65
Check failureCode scanning / CodeQL Missing rate limiting
This route handler performs [a file system access](1), but is not rate-limited.
This route handler performs [a file system access](2), but is not rate-limited.
| ||
| app.get('/link', async (_, res) => { | ||
| await new Promise<void>(resolve => { | ||
| fs.link( | ||
| path.join(__dirname, 'fixtures', 'some-file.txt'), | ||
| path.join(__dirname, 'fixtures', 'some-file.txt.link'), | ||
| () => { | ||
| resolve(); | ||
| }, | ||
| ); | ||
| }); | ||
| await fs.promises.link( | ||
| path.join(__dirname, 'fixtures', 'some-file-promises.txt'), | ||
| path.join(__dirname, 'fixtures', 'some-file-promises.txt.link'), | ||
| ); | ||
| await util.promisify(fs.link)( | ||
| path.join(__dirname, 'fixtures', 'some-file-promisify.txt'), | ||
| path.join(__dirname, 'fixtures', 'some-file-promisify.txt.link'), | ||
| ); | ||
| await Promise.all([ | ||
| fs.promises.unlink(path.join(__dirname, 'fixtures', 'some-file.txt.link')), | ||
| fs.promises.unlink(path.join(__dirname, 'fixtures', 'some-file-promises.txt.link')), | ||
| fs.promises.unlink(path.join(__dirname, 'fixtures', 'some-file-promisify.txt.link')), | ||
| ]); | ||
| res.send('done'); | ||
| }); | ||
Comment on lines
+67
to
+93
Check failureCode scanning / CodeQL Missing rate limiting
This route handler performs [a file system access](1), but is not rate-limited.
This route handler performs [a file system access](2), but is not rate-limited.
This route handler performs [a file system access](3), but is not rate-limited.
This route handler performs [a file system access](4), but is not rate-limited.
This route handler performs [a file system access](5), but is not rate-limited.
| ||
| app.get('/mkdtemp', async (_, res) => { | ||
| await new Promise<void>(resolve => { | ||
| fs.mkdtemp(path.join(os.tmpdir(), 'foo-'), () => { | ||
| resolve(); | ||
| }); | ||
| }); | ||
| await fs.promises.mkdtemp(path.join(os.tmpdir(), 'foo-')); | ||
| await util.promisify(fs.mkdtemp)(path.join(os.tmpdir(), 'foo-')); | ||
| res.send('done'); | ||
| }); | ||
Comment on lines
+95
to
+105
Check failureCode scanning / CodeQL Missing rate limiting
This route handler performs [a file system access](1), but is not rate-limited.
This route handler performs [a file system access](2), but is not rate-limited.
| ||
| app.get('/symlink', async (_, res) => { | ||
| await new Promise<void>(resolve => { | ||
| fs.symlink( | ||
| path.join(__dirname, 'fixtures', 'some-file.txt'), | ||
| path.join(__dirname, 'fixtures', 'some-file.txt.symlink'), | ||
| () => { | ||
| resolve(); | ||
| }, | ||
| ); | ||
| }); | ||
| await fs.promises.symlink( | ||
| path.join(__dirname, 'fixtures', 'some-file-promises.txt'), | ||
| path.join(__dirname, 'fixtures', 'some-file-promises.txt.symlink'), | ||
| ); | ||
| await util.promisify(fs.symlink)( | ||
| path.join(__dirname, 'fixtures', 'some-file-promisify.txt'), | ||
| path.join(__dirname, 'fixtures', 'some-file-promisify.txt.symlink'), | ||
| ); | ||
| await Promise.all([ | ||
| fs.promises.unlink(path.join(__dirname, 'fixtures', 'some-file.txt.symlink')), | ||
| fs.promises.unlink(path.join(__dirname, 'fixtures', 'some-file-promises.txt.symlink')), | ||
| fs.promises.unlink(path.join(__dirname, 'fixtures', 'some-file-promisify.txt.symlink')), | ||
| ]); | ||
| res.send('done'); | ||
| }); | ||
Comment on lines
+107
to
+133
Check failureCode scanning / CodeQL Missing rate limiting
This route handler performs [a file system access](1), but is not rate-limited.
This route handler performs [a file system access](2), but is not rate-limited.
This route handler performs [a file system access](3), but is not rate-limited.
This route handler performs [a file system access](4), but is not rate-limited.
This route handler performs [a file system access](5), but is not rate-limited.
| ||
| Sentry.setupExpressErrorHandler(app); | ||
| startExpressServerAndSendPortToRunner(app); | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check failure
Code scanning / CodeQL
Missing rate limiting