feat: Add support for SENTRY_SPOTLIGHT env var in Node - #13325

Merged
Lms24 merged 10 commits into
getsentry:developfrom
BYK:byk/feat/SENTRY_SPOTLIGHT
Aug 13, 2024
Merged

feat: Add support for SENTRY_SPOTLIGHT env var in Node#13325
Lms24 merged 10 commits into
getsentry:developfrom
BYK:byk/feat/SENTRY_SPOTLIGHT

Conversation

@BYK

@BYKBYK commented Aug 12, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Lms24
Lms24 reviewed Aug 13, 2024
View reviewed changes

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's just be consistent with env variable values and then this is good to go!

Comment threadpackages/node/src/sdk/index.ts Outdated
@Lms24

Lms24 commented Aug 13, 2024

Copy link
Copy Markdown
Member

Also, please update the PR description with the motivation for this change. You and I know it but let's make sure others have the context as well :)

@BYK
BYK requested a review from Lms24August 13, 2024 12:23
Lms24
Lms24 reviewed Aug 13, 2024
View reviewed changes
Comment threadpackages/node/src/sdk/index.ts
Comment threadpackages/node/src/utils/envToBool.ts
Lms24
Lms24 approved these changes Aug 13, 2024
View reviewed changes

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!

Comment threadpackages/node/test/utils/envToBool.test.ts
@Lms24
Lms24 merged commit 55220cf into getsentry:developAug 13, 2024
@BYK
BYK deleted the byk/feat/SENTRY_SPOTLIGHT branch August 13, 2024 15:00
@bagulm123bagulm123 mentioned this pull request Sep 18, 2024
Open
@onsailsonsails mentioned this pull request Sep 18, 2024
Open
@mohamed-helmy22020mohamed-helmy22020 mentioned this pull request Sep 18, 2024
Open
@gokulk16gokulk16 mentioned this pull request Sep 23, 2024
Closed
@q1blueq1blue mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Closed
Closed
@wkylinwkylin mentioned this pull request Sep 25, 2024
Closed
@FengShangWuQiFengShangWuQi mentioned this pull request Sep 27, 2024
Closed
@q1blueq1blue mentioned this pull request Sep 27, 2024
Open
@tristanroberttristanrobert mentioned this pull request Sep 28, 2024
Merged
@q1blueq1blue mentioned this pull request Sep 30, 2024
Open
@wkylinwkylin mentioned this pull request Oct 1, 2024
Closed
@bagulm123bagulm123 mentioned this pull request Oct 1, 2024
Open
vjousse pushed a commit to MTES-MCT/ecobalyse that referenced this pull request Oct 1, 2024
@tristanrobert@snyk-bot
chore(Snyk): Upgrade @sentry/browser from 8.27.0 to 8.28.0 (#775)
cea4b83
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
<h3>Snyk has created this PR to upgrade @sentry/browser from 8.27.0 to
8.28.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released on **25 days ago**.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>8.28.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Beta release of official NestJS SDK</strong></li>
</ul>
<p>This release contains the beta version of <code>@
sentry/nestjs</code>! For details on how to use it, check out the<br>
<a
href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>.
Any feedback/bug reports<br>
are greatly appreciated, please reach out on GitHub.</p>
<ul>
<li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization
logic (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2491960592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13502"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li>
</ul>
<p>This release fixes a bug in the <code>@ sentry/browser</code> package
and all SDKs depending on this package (e.g. <code>@
sentry/react</code><br>
or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect
web vital values for the LCP, FCP and FP vitals. The SDK<br>
previously incorrectly processed the original values as they were
reported from the browser. When updating your SDK to<br>
this version, you might experience an increase in LCP, FCP and FP
values, which potentially leads to a decrease in your<br>
performance score in the Web Vitals Insights module in Sentry. This is
because the previously reported values were<br>
smaller than the actually measured values. We apologize for the
inconvenience!</p>
<h3>Other Changes</h3>
<ul>
<li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2498873205" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13545"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li>
<li>feat(nestjs): Automatic instrumentation of nestjs interceptors after
route execution (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2453558373"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13264"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li>
<li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build
options (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2461140938" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13323"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li>
<li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2500682873" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13550"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li>
<li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2486658763" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li>
<li>feat(profiling): Expose profiler as top level primitive (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2492896219" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13512"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li>
<li>feat(replay): Add layout shift to CLS replay data (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2466359020" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13386"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li>
<li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489549947" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13483"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li>
<li>fix(cdn): Do not mangle _metadata (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2473467027" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13426"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li>
<li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489085687" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li>
<li>fix(nestjs): Check arguments before instrumenting with <code>@
Injectable</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2498819596"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13544"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li>
<li>fix(nestjs): Ensure exception and host are correctly passed on when
using @ WithSentry (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2501912092"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13564"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li>
<li>fix(node): Suppress tracing for transport request execution rather
than transport creation (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2491355594"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13491"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li>
<li>fix(replay): Consider more things as DOM mutations for dead clicks
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2493890628" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13518"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li>
<li>fix(vue): Correctly obtain component name (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2490176912" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13484"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/leopoldkristjansson/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>,
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mhuggins/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/mhuggins">@ mhuggins</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/filips123/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/filips123">@ filips123</a>. Thank you for
your<br>
contributions!</p>
</li>
<li>
<b>8.27.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.27.0">2024-08-27</a></br><h3>Important
Changes</h3>
<ul>
<li>
<p><strong>fix(nestjs): Exception filters in main app module are not
being executed (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2455715839"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13278"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13278/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13278">#13278</a>)</strong></p>
<p>With this release nestjs error monitoring is no longer automatically
set up after adding the <code>SentryModule</code> to your<br>
application, which led to issues in certain scenarios. You will now have
to either add the <code>SentryGlobalFilter</code> to<br>
your main module providers or decorate the <code>catch()</code> method
in your existing global exception filters with the newly<br>
released <code>@ WithSentry()</code> decorator. See the <a
href="https://docs.sentry.io/platforms/javascript/guides/nestjs/"
rel="nofollow">docs</a> for<br>
more details.</p>
</li>
</ul>
<h3>Other Changes</h3>
<ul>
<li>feat: Add options for passing nonces to feedback integration (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2463099308" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13347"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13347/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13347">#13347</a>)</li>
<li>feat: Add support for SENTRY_SPOTLIGHT env var in Node (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461216903" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13325"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13325/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13325">#13325</a>)</li>
<li>feat(deps): bump @ prisma/instrumentation from 5.17.0 to 5.18.0 (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461290821" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13327"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13327/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13327">#13327</a>)</li>
<li>feat(feedback): Improve error message for 403 errors (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2476011686" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13441"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13441/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13441">#13441</a>)</li>
<li>fix(deno): Don't rely on <code>Deno.permissions.querySync</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2465617012" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13378"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13378/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13378">#13378</a>)</li>
<li>fix(replay): Ensure we publish replay CDN bundles (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2475611875" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13437/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13437">#13437</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/charpeni/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/charpeni">@ charpeni</a>. Thank you for your
contribution!</p>
</li>
</ul>
from <a
href="https://github.com/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
---
> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.
---
**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._
**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODVjYTllMS0yOGRmLTRmMmQtOWViYi02MmYzMjcwMDQ3OWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4NWNhOWUxLTI4ZGYtNGYyZC05ZWJiLTYyZjMyNzAwNDc5ZSJ9fQ=="
width="0" height="0"/>
> - 🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"8.27.0","to":"8.28.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","prPublicId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-03T10:33:13.421Z"},"vulns":[]}'
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@q1blueq1blue mentioned this pull request Oct 1, 2024
Open
@wkylinwkylin mentioned this pull request Oct 2, 2024
Closed
@KeeghanMKeeghanM mentioned this pull request Oct 3, 2024
Merged
@BYKBYK mentioned this pull request Nov 13, 2025
Merged
BYK added a commit that referenced this pull request Nov 13, 2025
@BYK@cursoragent
fix(node): Fix Spotlight configuration precedence to match specificat…
c8ca286
…ion (#18195)
## Problem
The Spotlight configuration logic had a precedence bug where when
`spotlight: true` was set in config AND the `SENTRY_SPOTLIGHT`
environment variable contained a URL string, the SDK would incorrectly
use `true` instead of the URL from the environment variable.
According to the [Spotlight
specification](https://raw.githubusercontent.com/getsentry/sentry-docs/b38e3b307f900665a348f855559ac1d1c58914cc/develop-docs/sdk/expected-features/spotlight.mdx),
when `spotlight: true` is set and the env var contains a URL, the URL
from the env var should be used to allow developers to override the
Spotlight URL via environment variables.
**Previous behavior:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = true ❌ (incorrect)
```
**Expected behavior per spec:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = "http://custom:3000/stream" ✅ (correct)
```
## Solution
Fixed the precedence logic in `getClientOptions()` to properly implement
the specification:
1. `spotlight: false` → Always disabled (overrides env var)
2. `spotlight: string` → Uses the config URL (ignores env var)
3. `spotlight: true` + env var URL → **Uses the env var URL** (the bug
fix)
4. `spotlight: true` + env var truthy → Uses default URL
5. No config + env var → Parses and uses env var
The implementation reuses the existing `envToBool()` utility to avoid
code duplication.
## Changes
- Fixed Spotlight precedence logic in
`packages/node-core/src/sdk/index.ts`
- Added 12 comprehensive test cases covering all precedence scenarios in
`packages/node-core/test/sdk/init.test.ts`
- Updated CHANGELOG.md
## Test Coverage
The new tests cover:
- ✅ Env var only: truthy values, falsy values, URL strings
- ✅ Config only: `true`, `false`, URL string
- ✅ Precedence: config `false` overrides env var (URL, truthy, falsy)
- ✅ Precedence: config URL overrides env var
- ✅ Precedence: config `true` + env var URL uses env var URL (the fix)
- ✅ Precedence: config `true` + env var truthy uses default URL
## Related
- Original Spotlight implementation: #13325
- Spotlight specification: https://spotlightjs.com/
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BYK@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: Add support for SENTRY_SPOTLIGHT env var in Node - #13325
Merged
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Aug 13, 2024
Merged
feat: Add support for SENTRY_SPOTLIGHT env var in Node#13325
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Conversation
@BYK
@BYKBYK
commented
Aug 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's just be consistent with env variable values and then this is good to go!
Comment threadpackages/node/src/sdk/index.ts
Outdated

@Lms24
Lms24
commented
Aug 13, 2024

Copy link


Copy Markdown

Member
Also, please update the PR description with the motivation for this change. You and I know it but let's make sure others have the context as well :)
@BYK
BYK
requested a review
from Lms24August 13, 2024 12:23
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
Comment threadpackages/node/src/sdk/index.ts
Comment threadpackages/node/src/utils/envToBool.ts
Lms24
Lms24
approved these changes
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!
Comment threadpackages/node/test/utils/envToBool.test.ts
@Lms24
Lms24
merged commit 55220cf
into
getsentry:developAug 13, 2024
@BYK
BYK
deleted the

byk/feat/SENTRY_SPOTLIGHT

branch
August 13, 2024 15:00
@bagulm123bagulm123
mentioned this pull request
Sep 18, 2024
 Open

@onsailsonsails
mentioned this pull request
Sep 18, 2024
 Open

@mohamed-helmy22020mohamed-helmy22020
mentioned this pull request
Sep 18, 2024
 Open

@gokulk16gokulk16
mentioned this pull request
Sep 23, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 24, 2024
 Open


This was referenced Sep 24, 2024
 Closed

 Closed

@wkylinwkylin
mentioned this pull request
Sep 25, 2024
 Closed

@FengShangWuQiFengShangWuQi
mentioned this pull request
Sep 27, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 27, 2024
 Open

@tristanroberttristanrobert
mentioned this pull request
Sep 28, 2024
 Merged

@q1blueq1blue
mentioned this pull request
Sep 30, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 1, 2024
 Closed

@bagulm123bagulm123
mentioned this pull request
Oct 1, 2024
 Open

vjousse pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
@tristanrobert@snyk-bot
chore(Snyk): Upgrade @sentry/browser from 8.27.0 to 8.28.0 (#775)
cea4b83
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
<h3>Snyk has created this PR to upgrade @sentry/browser from 8.27.0 to
8.28.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released on **25 days ago**.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>8.28.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Beta release of official NestJS SDK</strong></li>
</ul>
<p>This release contains the beta version of <code>@
sentry/nestjs</code>! For details on how to use it, check out the<br>
<a
href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>.
Any feedback/bug reports<br>
are greatly appreciated, please reach out on GitHub.</p>
<ul>
<li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization
logic (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2491960592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13502"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li>
</ul>
<p>This release fixes a bug in the <code>@ sentry/browser</code> package
and all SDKs depending on this package (e.g. <code>@
sentry/react</code><br>
or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect
web vital values for the LCP, FCP and FP vitals. The SDK<br>
previously incorrectly processed the original values as they were
reported from the browser. When updating your SDK to<br>
this version, you might experience an increase in LCP, FCP and FP
values, which potentially leads to a decrease in your<br>
performance score in the Web Vitals Insights module in Sentry. This is
because the previously reported values were<br>
smaller than the actually measured values. We apologize for the
inconvenience!</p>
<h3>Other Changes</h3>
<ul>
<li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2498873205" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13545"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li>
<li>feat(nestjs): Automatic instrumentation of nestjs interceptors after
route execution (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2453558373"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13264"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li>
<li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build
options (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2461140938" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13323"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li>
<li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2500682873" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13550"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li>
<li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2486658763" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li>
<li>feat(profiling): Expose profiler as top level primitive (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2492896219" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13512"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li>
<li>feat(replay): Add layout shift to CLS replay data (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2466359020" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13386"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li>
<li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489549947" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13483"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li>
<li>fix(cdn): Do not mangle _metadata (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2473467027" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13426"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li>
<li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489085687" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li>
<li>fix(nestjs): Check arguments before instrumenting with <code>@
Injectable</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2498819596"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13544"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li>
<li>fix(nestjs): Ensure exception and host are correctly passed on when
using @ WithSentry (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2501912092"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13564"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li>
<li>fix(node): Suppress tracing for transport request execution rather
than transport creation (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2491355594"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13491"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li>
<li>fix(replay): Consider more things as DOM mutations for dead clicks
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2493890628" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13518"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li>
<li>fix(vue): Correctly obtain component name (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2490176912" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13484"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/leopoldkristjansson/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>,
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mhuggins/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/mhuggins">@ mhuggins</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/filips123/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/filips123">@ filips123</a>. Thank you for
your<br>
contributions!</p>
</li>
<li>
<b>8.27.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.27.0">2024-08-27</a></br><h3>Important
Changes</h3>
<ul>
<li>
<p><strong>fix(nestjs): Exception filters in main app module are not
being executed (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2455715839"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13278"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13278/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13278">#13278</a>)</strong></p>
<p>With this release nestjs error monitoring is no longer automatically
set up after adding the <code>SentryModule</code> to your<br>
application, which led to issues in certain scenarios. You will now have
to either add the <code>SentryGlobalFilter</code> to<br>
your main module providers or decorate the <code>catch()</code> method
in your existing global exception filters with the newly<br>
released <code>@ WithSentry()</code> decorator. See the <a
href="https://docs.sentry.io/platforms/javascript/guides/nestjs/"
rel="nofollow">docs</a> for<br>
more details.</p>
</li>
</ul>
<h3>Other Changes</h3>
<ul>
<li>feat: Add options for passing nonces to feedback integration (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2463099308" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13347"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13347/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13347">#13347</a>)</li>
<li>feat: Add support for SENTRY_SPOTLIGHT env var in Node (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461216903" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13325"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13325/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13325">#13325</a>)</li>
<li>feat(deps): bump @ prisma/instrumentation from 5.17.0 to 5.18.0 (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461290821" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13327"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13327/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13327">#13327</a>)</li>
<li>feat(feedback): Improve error message for 403 errors (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2476011686" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13441"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13441/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13441">#13441</a>)</li>
<li>fix(deno): Don't rely on <code>Deno.permissions.querySync</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2465617012" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13378"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13378/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13378">#13378</a>)</li>
<li>fix(replay): Ensure we publish replay CDN bundles (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2475611875" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13437/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13437">#13437</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/charpeni/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/charpeni">@ charpeni</a>. Thank you for your
contribution!</p>
</li>
</ul>
from <a
href="https://github.com/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
---
> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.
---
**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._
**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODVjYTllMS0yOGRmLTRmMmQtOWViYi02MmYzMjcwMDQ3OWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4NWNhOWUxLTI4ZGYtNGYyZC05ZWJiLTYyZjMyNzAwNDc5ZSJ9fQ=="
width="0" height="0"/>
> - 🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"8.27.0","to":"8.28.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","prPublicId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-03T10:33:13.421Z"},"vulns":[]}'
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@q1blueq1blue
mentioned this pull request
Oct 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 2, 2024
 Closed

@KeeghanMKeeghanM
mentioned this pull request
Oct 3, 2024
 Merged

@BYKBYK
mentioned this pull request
Nov 13, 2025
 Merged

BYK added a commit
that referenced
this pull request
Nov 13, 2025
@BYK@cursoragent
fix(node): Fix Spotlight configuration precedence to match specificat…
c8ca286
…ion (#18195)
## Problem
The Spotlight configuration logic had a precedence bug where when
`spotlight: true` was set in config AND the `SENTRY_SPOTLIGHT`
environment variable contained a URL string, the SDK would incorrectly
use `true` instead of the URL from the environment variable.
According to the [Spotlight
specification](https://raw.githubusercontent.com/getsentry/sentry-docs/b38e3b307f900665a348f855559ac1d1c58914cc/develop-docs/sdk/expected-features/spotlight.mdx),
when `spotlight: true` is set and the env var contains a URL, the URL
from the env var should be used to allow developers to override the
Spotlight URL via environment variables.
**Previous behavior:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = true ❌ (incorrect)
```
**Expected behavior per spec:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = "http://custom:3000/stream" ✅ (correct)
```
## Solution
Fixed the precedence logic in `getClientOptions()` to properly implement
the specification:
1. `spotlight: false` → Always disabled (overrides env var)
2. `spotlight: string` → Uses the config URL (ignores env var)
3. `spotlight: true` + env var URL → **Uses the env var URL** (the bug
fix)
4. `spotlight: true` + env var truthy → Uses default URL
5. No config + env var → Parses and uses env var
The implementation reuses the existing `envToBool()` utility to avoid
code duplication.
## Changes
- Fixed Spotlight precedence logic in
`packages/node-core/src/sdk/index.ts`
- Added 12 comprehensive test cases covering all precedence scenarios in
`packages/node-core/test/sdk/init.test.ts`
- Updated CHANGELOG.md
## Test Coverage
The new tests cover:
- ✅ Env var only: truthy values, falsy values, URL strings
- ✅ Config only: `true`, `false`, URL string
- ✅ Precedence: config `false` overrides env var (URL, truthy, falsy)
- ✅ Precedence: config URL overrides env var
- ✅ Precedence: config `true` + env var URL uses env var URL (the fix)
- ✅ Precedence: config `true` + env var truthy uses default URL
## Related
- Original Spotlight implementation: #13325
- Spotlight specification: https://spotlightjs.com/
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@BYK@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Add support for SENTRY_SPOTLIGHT env var in Node - #13325
Merged
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Aug 13, 2024
Merged
feat: Add support for SENTRY_SPOTLIGHT env var in Node#13325
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Conversation
@BYK
@BYKBYK
commented
Aug 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's just be consistent with env variable values and then this is good to go!
Comment threadpackages/node/src/sdk/index.ts
Outdated

@Lms24
Lms24
commented
Aug 13, 2024

Copy link


Copy Markdown

Member
Also, please update the PR description with the motivation for this change. You and I know it but let's make sure others have the context as well :)
@BYK
BYK
requested a review
from Lms24August 13, 2024 12:23
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
Comment threadpackages/node/src/sdk/index.ts
Comment threadpackages/node/src/utils/envToBool.ts
Lms24
Lms24
approved these changes
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!
Comment threadpackages/node/test/utils/envToBool.test.ts
@Lms24
Lms24
merged commit 55220cf
into
getsentry:developAug 13, 2024
@BYK
BYK
deleted the

byk/feat/SENTRY_SPOTLIGHT

branch
August 13, 2024 15:00
@bagulm123bagulm123
mentioned this pull request
Sep 18, 2024
 Open

@onsailsonsails
mentioned this pull request
Sep 18, 2024
 Open

@mohamed-helmy22020mohamed-helmy22020
mentioned this pull request
Sep 18, 2024
 Open

@gokulk16gokulk16
mentioned this pull request
Sep 23, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 24, 2024
 Open


This was referenced Sep 24, 2024
 Closed

 Closed

@wkylinwkylin
mentioned this pull request
Sep 25, 2024
 Closed

@FengShangWuQiFengShangWuQi
mentioned this pull request
Sep 27, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 27, 2024
 Open

@tristanroberttristanrobert
mentioned this pull request
Sep 28, 2024
 Merged

@q1blueq1blue
mentioned this pull request
Sep 30, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 1, 2024
 Closed

@bagulm123bagulm123
mentioned this pull request
Oct 1, 2024
 Open

vjousse pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
@tristanrobert@snyk-bot
chore(Snyk): Upgrade @sentry/browser from 8.27.0 to 8.28.0 (#775)
cea4b83
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
<h3>Snyk has created this PR to upgrade @sentry/browser from 8.27.0 to
8.28.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released on **25 days ago**.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>8.28.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Beta release of official NestJS SDK</strong></li>
</ul>
<p>This release contains the beta version of <code>@
sentry/nestjs</code>! For details on how to use it, check out the<br>
<a
href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>.
Any feedback/bug reports<br>
are greatly appreciated, please reach out on GitHub.</p>
<ul>
<li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization
logic (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2491960592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13502"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li>
</ul>
<p>This release fixes a bug in the <code>@ sentry/browser</code> package
and all SDKs depending on this package (e.g. <code>@
sentry/react</code><br>
or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect
web vital values for the LCP, FCP and FP vitals. The SDK<br>
previously incorrectly processed the original values as they were
reported from the browser. When updating your SDK to<br>
this version, you might experience an increase in LCP, FCP and FP
values, which potentially leads to a decrease in your<br>
performance score in the Web Vitals Insights module in Sentry. This is
because the previously reported values were<br>
smaller than the actually measured values. We apologize for the
inconvenience!</p>
<h3>Other Changes</h3>
<ul>
<li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2498873205" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13545"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li>
<li>feat(nestjs): Automatic instrumentation of nestjs interceptors after
route execution (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2453558373"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13264"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li>
<li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build
options (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2461140938" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13323"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li>
<li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2500682873" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13550"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li>
<li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2486658763" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li>
<li>feat(profiling): Expose profiler as top level primitive (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2492896219" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13512"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li>
<li>feat(replay): Add layout shift to CLS replay data (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2466359020" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13386"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li>
<li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489549947" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13483"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li>
<li>fix(cdn): Do not mangle _metadata (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2473467027" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13426"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li>
<li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489085687" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li>
<li>fix(nestjs): Check arguments before instrumenting with <code>@
Injectable</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2498819596"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13544"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li>
<li>fix(nestjs): Ensure exception and host are correctly passed on when
using @ WithSentry (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2501912092"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13564"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li>
<li>fix(node): Suppress tracing for transport request execution rather
than transport creation (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2491355594"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13491"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li>
<li>fix(replay): Consider more things as DOM mutations for dead clicks
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2493890628" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13518"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li>
<li>fix(vue): Correctly obtain component name (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2490176912" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13484"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/leopoldkristjansson/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>,
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mhuggins/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/mhuggins">@ mhuggins</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/filips123/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/filips123">@ filips123</a>. Thank you for
your<br>
contributions!</p>
</li>
<li>
<b>8.27.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.27.0">2024-08-27</a></br><h3>Important
Changes</h3>
<ul>
<li>
<p><strong>fix(nestjs): Exception filters in main app module are not
being executed (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2455715839"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13278"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13278/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13278">#13278</a>)</strong></p>
<p>With this release nestjs error monitoring is no longer automatically
set up after adding the <code>SentryModule</code> to your<br>
application, which led to issues in certain scenarios. You will now have
to either add the <code>SentryGlobalFilter</code> to<br>
your main module providers or decorate the <code>catch()</code> method
in your existing global exception filters with the newly<br>
released <code>@ WithSentry()</code> decorator. See the <a
href="https://docs.sentry.io/platforms/javascript/guides/nestjs/"
rel="nofollow">docs</a> for<br>
more details.</p>
</li>
</ul>
<h3>Other Changes</h3>
<ul>
<li>feat: Add options for passing nonces to feedback integration (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2463099308" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13347"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13347/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13347">#13347</a>)</li>
<li>feat: Add support for SENTRY_SPOTLIGHT env var in Node (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461216903" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13325"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13325/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13325">#13325</a>)</li>
<li>feat(deps): bump @ prisma/instrumentation from 5.17.0 to 5.18.0 (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461290821" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13327"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13327/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13327">#13327</a>)</li>
<li>feat(feedback): Improve error message for 403 errors (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2476011686" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13441"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13441/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13441">#13441</a>)</li>
<li>fix(deno): Don't rely on <code>Deno.permissions.querySync</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2465617012" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13378"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13378/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13378">#13378</a>)</li>
<li>fix(replay): Ensure we publish replay CDN bundles (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2475611875" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13437/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13437">#13437</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/charpeni/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/charpeni">@ charpeni</a>. Thank you for your
contribution!</p>
</li>
</ul>
from <a
href="https://github.com/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
---
> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.
---
**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._
**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODVjYTllMS0yOGRmLTRmMmQtOWViYi02MmYzMjcwMDQ3OWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4NWNhOWUxLTI4ZGYtNGYyZC05ZWJiLTYyZjMyNzAwNDc5ZSJ9fQ=="
width="0" height="0"/>
> - 🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"8.27.0","to":"8.28.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","prPublicId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-03T10:33:13.421Z"},"vulns":[]}'
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@q1blueq1blue
mentioned this pull request
Oct 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 2, 2024
 Closed

@KeeghanMKeeghanM
mentioned this pull request
Oct 3, 2024
 Merged

@BYKBYK
mentioned this pull request
Nov 13, 2025
 Merged

BYK added a commit
that referenced
this pull request
Nov 13, 2025
@BYK@cursoragent
fix(node): Fix Spotlight configuration precedence to match specificat…
c8ca286
…ion (#18195)
## Problem
The Spotlight configuration logic had a precedence bug where when
`spotlight: true` was set in config AND the `SENTRY_SPOTLIGHT`
environment variable contained a URL string, the SDK would incorrectly
use `true` instead of the URL from the environment variable.
According to the [Spotlight
specification](https://raw.githubusercontent.com/getsentry/sentry-docs/b38e3b307f900665a348f855559ac1d1c58914cc/develop-docs/sdk/expected-features/spotlight.mdx),
when `spotlight: true` is set and the env var contains a URL, the URL
from the env var should be used to allow developers to override the
Spotlight URL via environment variables.
**Previous behavior:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = true ❌ (incorrect)
```
**Expected behavior per spec:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = "http://custom:3000/stream" ✅ (correct)
```
## Solution
Fixed the precedence logic in `getClientOptions()` to properly implement
the specification:
1. `spotlight: false` → Always disabled (overrides env var)
2. `spotlight: string` → Uses the config URL (ignores env var)
3. `spotlight: true` + env var URL → **Uses the env var URL** (the bug
fix)
4. `spotlight: true` + env var truthy → Uses default URL
5. No config + env var → Parses and uses env var
The implementation reuses the existing `envToBool()` utility to avoid
code duplication.
## Changes
- Fixed Spotlight precedence logic in
`packages/node-core/src/sdk/index.ts`
- Added 12 comprehensive test cases covering all precedence scenarios in
`packages/node-core/test/sdk/init.test.ts`
- Updated CHANGELOG.md
## Test Coverage
The new tests cover:
- ✅ Env var only: truthy values, falsy values, URL strings
- ✅ Config only: `true`, `false`, URL string
- ✅ Precedence: config `false` overrides env var (URL, truthy, falsy)
- ✅ Precedence: config URL overrides env var
- ✅ Precedence: config `true` + env var URL uses env var URL (the fix)
- ✅ Precedence: config `true` + env var truthy uses default URL
## Related
- Original Spotlight implementation: #13325
- Spotlight specification: https://spotlightjs.com/
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@BYK@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Add support for SENTRY_SPOTLIGHT env var in Node - #13325
Merged
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Aug 13, 2024
Merged
feat: Add support for SENTRY_SPOTLIGHT env var in Node#13325
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Conversation
@BYK
@BYKBYK
commented
Aug 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's just be consistent with env variable values and then this is good to go!
Comment threadpackages/node/src/sdk/index.ts
Outdated

@Lms24
Lms24
commented
Aug 13, 2024

Copy link


Copy Markdown

Member
Also, please update the PR description with the motivation for this change. You and I know it but let's make sure others have the context as well :)
@BYK
BYK
requested a review
from Lms24August 13, 2024 12:23
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
Comment threadpackages/node/src/sdk/index.ts
Comment threadpackages/node/src/utils/envToBool.ts
Lms24
Lms24
approved these changes
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!
Comment threadpackages/node/test/utils/envToBool.test.ts
@Lms24
Lms24
merged commit 55220cf
into
getsentry:developAug 13, 2024
@BYK
BYK
deleted the

byk/feat/SENTRY_SPOTLIGHT

branch
August 13, 2024 15:00
@bagulm123bagulm123
mentioned this pull request
Sep 18, 2024
 Open

@onsailsonsails
mentioned this pull request
Sep 18, 2024
 Open

@mohamed-helmy22020mohamed-helmy22020
mentioned this pull request
Sep 18, 2024
 Open

@gokulk16gokulk16
mentioned this pull request
Sep 23, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 24, 2024
 Open


This was referenced Sep 24, 2024
 Closed

 Closed

@wkylinwkylin
mentioned this pull request
Sep 25, 2024
 Closed

@FengShangWuQiFengShangWuQi
mentioned this pull request
Sep 27, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 27, 2024
 Open

@tristanroberttristanrobert
mentioned this pull request
Sep 28, 2024
 Merged

@q1blueq1blue
mentioned this pull request
Sep 30, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 1, 2024
 Closed

@bagulm123bagulm123
mentioned this pull request
Oct 1, 2024
 Open

vjousse pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
@tristanrobert@snyk-bot
chore(Snyk): Upgrade @sentry/browser from 8.27.0 to 8.28.0 (#775)
cea4b83
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
<h3>Snyk has created this PR to upgrade @sentry/browser from 8.27.0 to
8.28.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released on **25 days ago**.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>8.28.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Beta release of official NestJS SDK</strong></li>
</ul>
<p>This release contains the beta version of <code>@
sentry/nestjs</code>! For details on how to use it, check out the<br>
<a
href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>.
Any feedback/bug reports<br>
are greatly appreciated, please reach out on GitHub.</p>
<ul>
<li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization
logic (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2491960592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13502"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li>
</ul>
<p>This release fixes a bug in the <code>@ sentry/browser</code> package
and all SDKs depending on this package (e.g. <code>@
sentry/react</code><br>
or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect
web vital values for the LCP, FCP and FP vitals. The SDK<br>
previously incorrectly processed the original values as they were
reported from the browser. When updating your SDK to<br>
this version, you might experience an increase in LCP, FCP and FP
values, which potentially leads to a decrease in your<br>
performance score in the Web Vitals Insights module in Sentry. This is
because the previously reported values were<br>
smaller than the actually measured values. We apologize for the
inconvenience!</p>
<h3>Other Changes</h3>
<ul>
<li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2498873205" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13545"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li>
<li>feat(nestjs): Automatic instrumentation of nestjs interceptors after
route execution (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2453558373"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13264"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li>
<li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build
options (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2461140938" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13323"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li>
<li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2500682873" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13550"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li>
<li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2486658763" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li>
<li>feat(profiling): Expose profiler as top level primitive (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2492896219" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13512"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li>
<li>feat(replay): Add layout shift to CLS replay data (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2466359020" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13386"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li>
<li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489549947" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13483"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li>
<li>fix(cdn): Do not mangle _metadata (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2473467027" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13426"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li>
<li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489085687" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li>
<li>fix(nestjs): Check arguments before instrumenting with <code>@
Injectable</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2498819596"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13544"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li>
<li>fix(nestjs): Ensure exception and host are correctly passed on when
using @ WithSentry (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2501912092"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13564"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li>
<li>fix(node): Suppress tracing for transport request execution rather
than transport creation (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2491355594"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13491"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li>
<li>fix(replay): Consider more things as DOM mutations for dead clicks
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2493890628" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13518"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li>
<li>fix(vue): Correctly obtain component name (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2490176912" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13484"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/leopoldkristjansson/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>,
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mhuggins/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/mhuggins">@ mhuggins</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/filips123/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/filips123">@ filips123</a>. Thank you for
your<br>
contributions!</p>
</li>
<li>
<b>8.27.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.27.0">2024-08-27</a></br><h3>Important
Changes</h3>
<ul>
<li>
<p><strong>fix(nestjs): Exception filters in main app module are not
being executed (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2455715839"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13278"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13278/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13278">#13278</a>)</strong></p>
<p>With this release nestjs error monitoring is no longer automatically
set up after adding the <code>SentryModule</code> to your<br>
application, which led to issues in certain scenarios. You will now have
to either add the <code>SentryGlobalFilter</code> to<br>
your main module providers or decorate the <code>catch()</code> method
in your existing global exception filters with the newly<br>
released <code>@ WithSentry()</code> decorator. See the <a
href="https://docs.sentry.io/platforms/javascript/guides/nestjs/"
rel="nofollow">docs</a> for<br>
more details.</p>
</li>
</ul>
<h3>Other Changes</h3>
<ul>
<li>feat: Add options for passing nonces to feedback integration (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2463099308" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13347"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13347/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13347">#13347</a>)</li>
<li>feat: Add support for SENTRY_SPOTLIGHT env var in Node (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461216903" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13325"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13325/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13325">#13325</a>)</li>
<li>feat(deps): bump @ prisma/instrumentation from 5.17.0 to 5.18.0 (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461290821" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13327"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13327/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13327">#13327</a>)</li>
<li>feat(feedback): Improve error message for 403 errors (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2476011686" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13441"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13441/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13441">#13441</a>)</li>
<li>fix(deno): Don't rely on <code>Deno.permissions.querySync</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2465617012" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13378"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13378/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13378">#13378</a>)</li>
<li>fix(replay): Ensure we publish replay CDN bundles (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2475611875" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13437/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13437">#13437</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/charpeni/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/charpeni">@ charpeni</a>. Thank you for your
contribution!</p>
</li>
</ul>
from <a
href="https://github.com/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
---
> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.
---
**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._
**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODVjYTllMS0yOGRmLTRmMmQtOWViYi02MmYzMjcwMDQ3OWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4NWNhOWUxLTI4ZGYtNGYyZC05ZWJiLTYyZjMyNzAwNDc5ZSJ9fQ=="
width="0" height="0"/>
> - 🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"8.27.0","to":"8.28.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","prPublicId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-03T10:33:13.421Z"},"vulns":[]}'
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@q1blueq1blue
mentioned this pull request
Oct 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 2, 2024
 Closed

@KeeghanMKeeghanM
mentioned this pull request
Oct 3, 2024
 Merged

@BYKBYK
mentioned this pull request
Nov 13, 2025
 Merged

BYK added a commit
that referenced
this pull request
Nov 13, 2025
@BYK@cursoragent
fix(node): Fix Spotlight configuration precedence to match specificat…
c8ca286
…ion (#18195)
## Problem
The Spotlight configuration logic had a precedence bug where when
`spotlight: true` was set in config AND the `SENTRY_SPOTLIGHT`
environment variable contained a URL string, the SDK would incorrectly
use `true` instead of the URL from the environment variable.
According to the [Spotlight
specification](https://raw.githubusercontent.com/getsentry/sentry-docs/b38e3b307f900665a348f855559ac1d1c58914cc/develop-docs/sdk/expected-features/spotlight.mdx),
when `spotlight: true` is set and the env var contains a URL, the URL
from the env var should be used to allow developers to override the
Spotlight URL via environment variables.
**Previous behavior:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = true ❌ (incorrect)
```
**Expected behavior per spec:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = "http://custom:3000/stream" ✅ (correct)
```
## Solution
Fixed the precedence logic in `getClientOptions()` to properly implement
the specification:
1. `spotlight: false` → Always disabled (overrides env var)
2. `spotlight: string` → Uses the config URL (ignores env var)
3. `spotlight: true` + env var URL → **Uses the env var URL** (the bug
fix)
4. `spotlight: true` + env var truthy → Uses default URL
5. No config + env var → Parses and uses env var
The implementation reuses the existing `envToBool()` utility to avoid
code duplication.
## Changes
- Fixed Spotlight precedence logic in
`packages/node-core/src/sdk/index.ts`
- Added 12 comprehensive test cases covering all precedence scenarios in
`packages/node-core/test/sdk/init.test.ts`
- Updated CHANGELOG.md
## Test Coverage
The new tests cover:
- ✅ Env var only: truthy values, falsy values, URL strings
- ✅ Config only: `true`, `false`, URL string
- ✅ Precedence: config `false` overrides env var (URL, truthy, falsy)
- ✅ Precedence: config URL overrides env var
- ✅ Precedence: config `true` + env var URL uses env var URL (the fix)
- ✅ Precedence: config `true` + env var truthy uses default URL
## Related
- Original Spotlight implementation: #13325
- Spotlight specification: https://spotlightjs.com/
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@BYK@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: Add support for SENTRY_SPOTLIGHT env var in Node - #13325
Merged
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Aug 13, 2024
Merged
feat: Add support for SENTRY_SPOTLIGHT env var in Node#13325
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Conversation
@BYK
@BYKBYK
commented
Aug 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's just be consistent with env variable values and then this is good to go!
Comment threadpackages/node/src/sdk/index.ts
Outdated

@Lms24
Lms24
commented
Aug 13, 2024

Copy link


Copy Markdown

Member
Also, please update the PR description with the motivation for this change. You and I know it but let's make sure others have the context as well :)
@BYK
BYK
requested a review
from Lms24August 13, 2024 12:23
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
Comment threadpackages/node/src/sdk/index.ts
Comment threadpackages/node/src/utils/envToBool.ts
Lms24
Lms24
approved these changes
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!
Comment threadpackages/node/test/utils/envToBool.test.ts
@Lms24
Lms24
merged commit 55220cf
into
getsentry:developAug 13, 2024
@BYK
BYK
deleted the

byk/feat/SENTRY_SPOTLIGHT

branch
August 13, 2024 15:00
@bagulm123bagulm123
mentioned this pull request
Sep 18, 2024
 Open

@onsailsonsails
mentioned this pull request
Sep 18, 2024
 Open

@mohamed-helmy22020mohamed-helmy22020
mentioned this pull request
Sep 18, 2024
 Open

@gokulk16gokulk16
mentioned this pull request
Sep 23, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 24, 2024
 Open


This was referenced Sep 24, 2024
 Closed

 Closed

@wkylinwkylin
mentioned this pull request
Sep 25, 2024
 Closed

@FengShangWuQiFengShangWuQi
mentioned this pull request
Sep 27, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 27, 2024
 Open

@tristanroberttristanrobert
mentioned this pull request
Sep 28, 2024
 Merged

@q1blueq1blue
mentioned this pull request
Sep 30, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 1, 2024
 Closed

@bagulm123bagulm123
mentioned this pull request
Oct 1, 2024
 Open

vjousse pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
@tristanrobert@snyk-bot
chore(Snyk): Upgrade @sentry/browser from 8.27.0 to 8.28.0 (#775)
cea4b83
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
<h3>Snyk has created this PR to upgrade @sentry/browser from 8.27.0 to
8.28.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released on **25 days ago**.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>8.28.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Beta release of official NestJS SDK</strong></li>
</ul>
<p>This release contains the beta version of <code>@
sentry/nestjs</code>! For details on how to use it, check out the<br>
<a
href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>.
Any feedback/bug reports<br>
are greatly appreciated, please reach out on GitHub.</p>
<ul>
<li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization
logic (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2491960592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13502"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li>
</ul>
<p>This release fixes a bug in the <code>@ sentry/browser</code> package
and all SDKs depending on this package (e.g. <code>@
sentry/react</code><br>
or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect
web vital values for the LCP, FCP and FP vitals. The SDK<br>
previously incorrectly processed the original values as they were
reported from the browser. When updating your SDK to<br>
this version, you might experience an increase in LCP, FCP and FP
values, which potentially leads to a decrease in your<br>
performance score in the Web Vitals Insights module in Sentry. This is
because the previously reported values were<br>
smaller than the actually measured values. We apologize for the
inconvenience!</p>
<h3>Other Changes</h3>
<ul>
<li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2498873205" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13545"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li>
<li>feat(nestjs): Automatic instrumentation of nestjs interceptors after
route execution (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2453558373"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13264"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li>
<li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build
options (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2461140938" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13323"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li>
<li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2500682873" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13550"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li>
<li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2486658763" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li>
<li>feat(profiling): Expose profiler as top level primitive (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2492896219" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13512"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li>
<li>feat(replay): Add layout shift to CLS replay data (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2466359020" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13386"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li>
<li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489549947" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13483"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li>
<li>fix(cdn): Do not mangle _metadata (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2473467027" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13426"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li>
<li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489085687" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li>
<li>fix(nestjs): Check arguments before instrumenting with <code>@
Injectable</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2498819596"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13544"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li>
<li>fix(nestjs): Ensure exception and host are correctly passed on when
using @ WithSentry (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2501912092"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13564"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li>
<li>fix(node): Suppress tracing for transport request execution rather
than transport creation (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2491355594"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13491"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li>
<li>fix(replay): Consider more things as DOM mutations for dead clicks
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2493890628" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13518"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li>
<li>fix(vue): Correctly obtain component name (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2490176912" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13484"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/leopoldkristjansson/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>,
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mhuggins/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/mhuggins">@ mhuggins</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/filips123/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/filips123">@ filips123</a>. Thank you for
your<br>
contributions!</p>
</li>
<li>
<b>8.27.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.27.0">2024-08-27</a></br><h3>Important
Changes</h3>
<ul>
<li>
<p><strong>fix(nestjs): Exception filters in main app module are not
being executed (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2455715839"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13278"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13278/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13278">#13278</a>)</strong></p>
<p>With this release nestjs error monitoring is no longer automatically
set up after adding the <code>SentryModule</code> to your<br>
application, which led to issues in certain scenarios. You will now have
to either add the <code>SentryGlobalFilter</code> to<br>
your main module providers or decorate the <code>catch()</code> method
in your existing global exception filters with the newly<br>
released <code>@ WithSentry()</code> decorator. See the <a
href="https://docs.sentry.io/platforms/javascript/guides/nestjs/"
rel="nofollow">docs</a> for<br>
more details.</p>
</li>
</ul>
<h3>Other Changes</h3>
<ul>
<li>feat: Add options for passing nonces to feedback integration (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2463099308" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13347"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13347/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13347">#13347</a>)</li>
<li>feat: Add support for SENTRY_SPOTLIGHT env var in Node (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461216903" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13325"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13325/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13325">#13325</a>)</li>
<li>feat(deps): bump @ prisma/instrumentation from 5.17.0 to 5.18.0 (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461290821" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13327"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13327/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13327">#13327</a>)</li>
<li>feat(feedback): Improve error message for 403 errors (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2476011686" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13441"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13441/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13441">#13441</a>)</li>
<li>fix(deno): Don't rely on <code>Deno.permissions.querySync</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2465617012" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13378"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13378/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13378">#13378</a>)</li>
<li>fix(replay): Ensure we publish replay CDN bundles (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2475611875" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13437/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13437">#13437</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/charpeni/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/charpeni">@ charpeni</a>. Thank you for your
contribution!</p>
</li>
</ul>
from <a
href="https://github.com/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
---
> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.
---
**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._
**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODVjYTllMS0yOGRmLTRmMmQtOWViYi02MmYzMjcwMDQ3OWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4NWNhOWUxLTI4ZGYtNGYyZC05ZWJiLTYyZjMyNzAwNDc5ZSJ9fQ=="
width="0" height="0"/>
> - 🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"8.27.0","to":"8.28.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","prPublicId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-03T10:33:13.421Z"},"vulns":[]}'
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@q1blueq1blue
mentioned this pull request
Oct 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 2, 2024
 Closed

@KeeghanMKeeghanM
mentioned this pull request
Oct 3, 2024
 Merged

@BYKBYK
mentioned this pull request
Nov 13, 2025
 Merged

BYK added a commit
that referenced
this pull request
Nov 13, 2025
@BYK@cursoragent
fix(node): Fix Spotlight configuration precedence to match specificat…
c8ca286
…ion (#18195)
## Problem
The Spotlight configuration logic had a precedence bug where when
`spotlight: true` was set in config AND the `SENTRY_SPOTLIGHT`
environment variable contained a URL string, the SDK would incorrectly
use `true` instead of the URL from the environment variable.
According to the [Spotlight
specification](https://raw.githubusercontent.com/getsentry/sentry-docs/b38e3b307f900665a348f855559ac1d1c58914cc/develop-docs/sdk/expected-features/spotlight.mdx),
when `spotlight: true` is set and the env var contains a URL, the URL
from the env var should be used to allow developers to override the
Spotlight URL via environment variables.
**Previous behavior:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = true ❌ (incorrect)
```
**Expected behavior per spec:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = "http://custom:3000/stream" ✅ (correct)
```
## Solution
Fixed the precedence logic in `getClientOptions()` to properly implement
the specification:
1. `spotlight: false` → Always disabled (overrides env var)
2. `spotlight: string` → Uses the config URL (ignores env var)
3. `spotlight: true` + env var URL → **Uses the env var URL** (the bug
fix)
4. `spotlight: true` + env var truthy → Uses default URL
5. No config + env var → Parses and uses env var
The implementation reuses the existing `envToBool()` utility to avoid
code duplication.
## Changes
- Fixed Spotlight precedence logic in
`packages/node-core/src/sdk/index.ts`
- Added 12 comprehensive test cases covering all precedence scenarios in
`packages/node-core/test/sdk/init.test.ts`
- Updated CHANGELOG.md
## Test Coverage
The new tests cover:
- ✅ Env var only: truthy values, falsy values, URL strings
- ✅ Config only: `true`, `false`, URL string
- ✅ Precedence: config `false` overrides env var (URL, truthy, falsy)
- ✅ Precedence: config URL overrides env var
- ✅ Precedence: config `true` + env var URL uses env var URL (the fix)
- ✅ Precedence: config `true` + env var truthy uses default URL
## Related
- Original Spotlight implementation: #13325
- Spotlight specification: https://spotlightjs.com/
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@BYK@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Add support for SENTRY_SPOTLIGHT env var in Node - #13325
Merged
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Aug 13, 2024
Merged
feat: Add support for SENTRY_SPOTLIGHT env var in Node#13325
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Conversation
@BYK
@BYKBYK
commented
Aug 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's just be consistent with env variable values and then this is good to go!
Comment threadpackages/node/src/sdk/index.ts
Outdated

@Lms24
Lms24
commented
Aug 13, 2024

Copy link


Copy Markdown

Member
Also, please update the PR description with the motivation for this change. You and I know it but let's make sure others have the context as well :)
@BYK
BYK
requested a review
from Lms24August 13, 2024 12:23
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
Comment threadpackages/node/src/sdk/index.ts
Comment threadpackages/node/src/utils/envToBool.ts
Lms24
Lms24
approved these changes
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!
Comment threadpackages/node/test/utils/envToBool.test.ts
@Lms24
Lms24
merged commit 55220cf
into
getsentry:developAug 13, 2024
@BYK
BYK
deleted the

byk/feat/SENTRY_SPOTLIGHT

branch
August 13, 2024 15:00
@bagulm123bagulm123
mentioned this pull request
Sep 18, 2024
 Open

@onsailsonsails
mentioned this pull request
Sep 18, 2024
 Open

@mohamed-helmy22020mohamed-helmy22020
mentioned this pull request
Sep 18, 2024
 Open

@gokulk16gokulk16
mentioned this pull request
Sep 23, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 24, 2024
 Open


This was referenced Sep 24, 2024
 Closed

 Closed

@wkylinwkylin
mentioned this pull request
Sep 25, 2024
 Closed

@FengShangWuQiFengShangWuQi
mentioned this pull request
Sep 27, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 27, 2024
 Open

@tristanroberttristanrobert
mentioned this pull request
Sep 28, 2024
 Merged

@q1blueq1blue
mentioned this pull request
Sep 30, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 1, 2024
 Closed

@bagulm123bagulm123
mentioned this pull request
Oct 1, 2024
 Open

vjousse pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
@tristanrobert@snyk-bot
chore(Snyk): Upgrade @sentry/browser from 8.27.0 to 8.28.0 (#775)
cea4b83
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
<h3>Snyk has created this PR to upgrade @sentry/browser from 8.27.0 to
8.28.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released on **25 days ago**.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>8.28.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Beta release of official NestJS SDK</strong></li>
</ul>
<p>This release contains the beta version of <code>@
sentry/nestjs</code>! For details on how to use it, check out the<br>
<a
href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>.
Any feedback/bug reports<br>
are greatly appreciated, please reach out on GitHub.</p>
<ul>
<li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization
logic (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2491960592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13502"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li>
</ul>
<p>This release fixes a bug in the <code>@ sentry/browser</code> package
and all SDKs depending on this package (e.g. <code>@
sentry/react</code><br>
or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect
web vital values for the LCP, FCP and FP vitals. The SDK<br>
previously incorrectly processed the original values as they were
reported from the browser. When updating your SDK to<br>
this version, you might experience an increase in LCP, FCP and FP
values, which potentially leads to a decrease in your<br>
performance score in the Web Vitals Insights module in Sentry. This is
because the previously reported values were<br>
smaller than the actually measured values. We apologize for the
inconvenience!</p>
<h3>Other Changes</h3>
<ul>
<li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2498873205" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13545"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li>
<li>feat(nestjs): Automatic instrumentation of nestjs interceptors after
route execution (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2453558373"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13264"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li>
<li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build
options (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2461140938" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13323"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li>
<li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2500682873" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13550"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li>
<li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2486658763" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li>
<li>feat(profiling): Expose profiler as top level primitive (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2492896219" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13512"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li>
<li>feat(replay): Add layout shift to CLS replay data (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2466359020" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13386"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li>
<li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489549947" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13483"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li>
<li>fix(cdn): Do not mangle _metadata (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2473467027" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13426"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li>
<li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489085687" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li>
<li>fix(nestjs): Check arguments before instrumenting with <code>@
Injectable</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2498819596"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13544"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li>
<li>fix(nestjs): Ensure exception and host are correctly passed on when
using @ WithSentry (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2501912092"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13564"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li>
<li>fix(node): Suppress tracing for transport request execution rather
than transport creation (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2491355594"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13491"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li>
<li>fix(replay): Consider more things as DOM mutations for dead clicks
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2493890628" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13518"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li>
<li>fix(vue): Correctly obtain component name (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2490176912" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13484"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/leopoldkristjansson/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>,
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mhuggins/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/mhuggins">@ mhuggins</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/filips123/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/filips123">@ filips123</a>. Thank you for
your<br>
contributions!</p>
</li>
<li>
<b>8.27.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.27.0">2024-08-27</a></br><h3>Important
Changes</h3>
<ul>
<li>
<p><strong>fix(nestjs): Exception filters in main app module are not
being executed (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2455715839"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13278"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13278/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13278">#13278</a>)</strong></p>
<p>With this release nestjs error monitoring is no longer automatically
set up after adding the <code>SentryModule</code> to your<br>
application, which led to issues in certain scenarios. You will now have
to either add the <code>SentryGlobalFilter</code> to<br>
your main module providers or decorate the <code>catch()</code> method
in your existing global exception filters with the newly<br>
released <code>@ WithSentry()</code> decorator. See the <a
href="https://docs.sentry.io/platforms/javascript/guides/nestjs/"
rel="nofollow">docs</a> for<br>
more details.</p>
</li>
</ul>
<h3>Other Changes</h3>
<ul>
<li>feat: Add options for passing nonces to feedback integration (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2463099308" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13347"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13347/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13347">#13347</a>)</li>
<li>feat: Add support for SENTRY_SPOTLIGHT env var in Node (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461216903" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13325"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13325/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13325">#13325</a>)</li>
<li>feat(deps): bump @ prisma/instrumentation from 5.17.0 to 5.18.0 (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461290821" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13327"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13327/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13327">#13327</a>)</li>
<li>feat(feedback): Improve error message for 403 errors (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2476011686" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13441"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13441/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13441">#13441</a>)</li>
<li>fix(deno): Don't rely on <code>Deno.permissions.querySync</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2465617012" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13378"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13378/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13378">#13378</a>)</li>
<li>fix(replay): Ensure we publish replay CDN bundles (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2475611875" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13437/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13437">#13437</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/charpeni/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/charpeni">@ charpeni</a>. Thank you for your
contribution!</p>
</li>
</ul>
from <a
href="https://github.com/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
---
> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.
---
**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._
**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODVjYTllMS0yOGRmLTRmMmQtOWViYi02MmYzMjcwMDQ3OWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4NWNhOWUxLTI4ZGYtNGYyZC05ZWJiLTYyZjMyNzAwNDc5ZSJ9fQ=="
width="0" height="0"/>
> - 🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"8.27.0","to":"8.28.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","prPublicId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-03T10:33:13.421Z"},"vulns":[]}'
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@q1blueq1blue
mentioned this pull request
Oct 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 2, 2024
 Closed

@KeeghanMKeeghanM
mentioned this pull request
Oct 3, 2024
 Merged

@BYKBYK
mentioned this pull request
Nov 13, 2025
 Merged

BYK added a commit
that referenced
this pull request
Nov 13, 2025
@BYK@cursoragent
fix(node): Fix Spotlight configuration precedence to match specificat…
c8ca286
…ion (#18195)
## Problem
The Spotlight configuration logic had a precedence bug where when
`spotlight: true` was set in config AND the `SENTRY_SPOTLIGHT`
environment variable contained a URL string, the SDK would incorrectly
use `true` instead of the URL from the environment variable.
According to the [Spotlight
specification](https://raw.githubusercontent.com/getsentry/sentry-docs/b38e3b307f900665a348f855559ac1d1c58914cc/develop-docs/sdk/expected-features/spotlight.mdx),
when `spotlight: true` is set and the env var contains a URL, the URL
from the env var should be used to allow developers to override the
Spotlight URL via environment variables.
**Previous behavior:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = true ❌ (incorrect)
```
**Expected behavior per spec:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = "http://custom:3000/stream" ✅ (correct)
```
## Solution
Fixed the precedence logic in `getClientOptions()` to properly implement
the specification:
1. `spotlight: false` → Always disabled (overrides env var)
2. `spotlight: string` → Uses the config URL (ignores env var)
3. `spotlight: true` + env var URL → **Uses the env var URL** (the bug
fix)
4. `spotlight: true` + env var truthy → Uses default URL
5. No config + env var → Parses and uses env var
The implementation reuses the existing `envToBool()` utility to avoid
code duplication.
## Changes
- Fixed Spotlight precedence logic in
`packages/node-core/src/sdk/index.ts`
- Added 12 comprehensive test cases covering all precedence scenarios in
`packages/node-core/test/sdk/init.test.ts`
- Updated CHANGELOG.md
## Test Coverage
The new tests cover:
- ✅ Env var only: truthy values, falsy values, URL strings
- ✅ Config only: `true`, `false`, URL string
- ✅ Precedence: config `false` overrides env var (URL, truthy, falsy)
- ✅ Precedence: config URL overrides env var
- ✅ Precedence: config `true` + env var URL uses env var URL (the fix)
- ✅ Precedence: config `true` + env var truthy uses default URL
## Related
- Original Spotlight implementation: #13325
- Spotlight specification: https://spotlightjs.com/
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@BYK@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Add support for SENTRY_SPOTLIGHT env var in Node - #13325
Merged
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Aug 13, 2024
Merged
feat: Add support for SENTRY_SPOTLIGHT env var in Node#13325
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Conversation
@BYK
@BYKBYK
commented
Aug 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's just be consistent with env variable values and then this is good to go!
Comment threadpackages/node/src/sdk/index.ts
Outdated

@Lms24
Lms24
commented
Aug 13, 2024

Copy link


Copy Markdown

Member
Also, please update the PR description with the motivation for this change. You and I know it but let's make sure others have the context as well :)
@BYK
BYK
requested a review
from Lms24August 13, 2024 12:23
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
Comment threadpackages/node/src/sdk/index.ts
Comment threadpackages/node/src/utils/envToBool.ts
Lms24
Lms24
approved these changes
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!
Comment threadpackages/node/test/utils/envToBool.test.ts
@Lms24
Lms24
merged commit 55220cf
into
getsentry:developAug 13, 2024
@BYK
BYK
deleted the

byk/feat/SENTRY_SPOTLIGHT

branch
August 13, 2024 15:00
@bagulm123bagulm123
mentioned this pull request
Sep 18, 2024
 Open

@onsailsonsails
mentioned this pull request
Sep 18, 2024
 Open

@mohamed-helmy22020mohamed-helmy22020
mentioned this pull request
Sep 18, 2024
 Open

@gokulk16gokulk16
mentioned this pull request
Sep 23, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 24, 2024
 Open


This was referenced Sep 24, 2024
 Closed

 Closed

@wkylinwkylin
mentioned this pull request
Sep 25, 2024
 Closed

@FengShangWuQiFengShangWuQi
mentioned this pull request
Sep 27, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 27, 2024
 Open

@tristanroberttristanrobert
mentioned this pull request
Sep 28, 2024
 Merged

@q1blueq1blue
mentioned this pull request
Sep 30, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 1, 2024
 Closed

@bagulm123bagulm123
mentioned this pull request
Oct 1, 2024
 Open

vjousse pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
@tristanrobert@snyk-bot
chore(Snyk): Upgrade @sentry/browser from 8.27.0 to 8.28.0 (#775)
cea4b83
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
<h3>Snyk has created this PR to upgrade @sentry/browser from 8.27.0 to
8.28.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released on **25 days ago**.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>8.28.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Beta release of official NestJS SDK</strong></li>
</ul>
<p>This release contains the beta version of <code>@
sentry/nestjs</code>! For details on how to use it, check out the<br>
<a
href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>.
Any feedback/bug reports<br>
are greatly appreciated, please reach out on GitHub.</p>
<ul>
<li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization
logic (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2491960592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13502"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li>
</ul>
<p>This release fixes a bug in the <code>@ sentry/browser</code> package
and all SDKs depending on this package (e.g. <code>@
sentry/react</code><br>
or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect
web vital values for the LCP, FCP and FP vitals. The SDK<br>
previously incorrectly processed the original values as they were
reported from the browser. When updating your SDK to<br>
this version, you might experience an increase in LCP, FCP and FP
values, which potentially leads to a decrease in your<br>
performance score in the Web Vitals Insights module in Sentry. This is
because the previously reported values were<br>
smaller than the actually measured values. We apologize for the
inconvenience!</p>
<h3>Other Changes</h3>
<ul>
<li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2498873205" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13545"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li>
<li>feat(nestjs): Automatic instrumentation of nestjs interceptors after
route execution (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2453558373"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13264"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li>
<li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build
options (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2461140938" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13323"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li>
<li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2500682873" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13550"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li>
<li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2486658763" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li>
<li>feat(profiling): Expose profiler as top level primitive (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2492896219" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13512"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li>
<li>feat(replay): Add layout shift to CLS replay data (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2466359020" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13386"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li>
<li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489549947" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13483"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li>
<li>fix(cdn): Do not mangle _metadata (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2473467027" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13426"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li>
<li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489085687" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li>
<li>fix(nestjs): Check arguments before instrumenting with <code>@
Injectable</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2498819596"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13544"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li>
<li>fix(nestjs): Ensure exception and host are correctly passed on when
using @ WithSentry (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2501912092"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13564"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li>
<li>fix(node): Suppress tracing for transport request execution rather
than transport creation (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2491355594"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13491"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li>
<li>fix(replay): Consider more things as DOM mutations for dead clicks
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2493890628" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13518"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li>
<li>fix(vue): Correctly obtain component name (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2490176912" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13484"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/leopoldkristjansson/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>,
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mhuggins/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/mhuggins">@ mhuggins</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/filips123/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/filips123">@ filips123</a>. Thank you for
your<br>
contributions!</p>
</li>
<li>
<b>8.27.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.27.0">2024-08-27</a></br><h3>Important
Changes</h3>
<ul>
<li>
<p><strong>fix(nestjs): Exception filters in main app module are not
being executed (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2455715839"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13278"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13278/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13278">#13278</a>)</strong></p>
<p>With this release nestjs error monitoring is no longer automatically
set up after adding the <code>SentryModule</code> to your<br>
application, which led to issues in certain scenarios. You will now have
to either add the <code>SentryGlobalFilter</code> to<br>
your main module providers or decorate the <code>catch()</code> method
in your existing global exception filters with the newly<br>
released <code>@ WithSentry()</code> decorator. See the <a
href="https://docs.sentry.io/platforms/javascript/guides/nestjs/"
rel="nofollow">docs</a> for<br>
more details.</p>
</li>
</ul>
<h3>Other Changes</h3>
<ul>
<li>feat: Add options for passing nonces to feedback integration (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2463099308" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13347"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13347/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13347">#13347</a>)</li>
<li>feat: Add support for SENTRY_SPOTLIGHT env var in Node (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461216903" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13325"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13325/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13325">#13325</a>)</li>
<li>feat(deps): bump @ prisma/instrumentation from 5.17.0 to 5.18.0 (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461290821" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13327"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13327/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13327">#13327</a>)</li>
<li>feat(feedback): Improve error message for 403 errors (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2476011686" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13441"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13441/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13441">#13441</a>)</li>
<li>fix(deno): Don't rely on <code>Deno.permissions.querySync</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2465617012" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13378"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13378/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13378">#13378</a>)</li>
<li>fix(replay): Ensure we publish replay CDN bundles (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2475611875" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13437/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13437">#13437</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/charpeni/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/charpeni">@ charpeni</a>. Thank you for your
contribution!</p>
</li>
</ul>
from <a
href="https://github.com/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
---
> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.
---
**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._
**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODVjYTllMS0yOGRmLTRmMmQtOWViYi02MmYzMjcwMDQ3OWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4NWNhOWUxLTI4ZGYtNGYyZC05ZWJiLTYyZjMyNzAwNDc5ZSJ9fQ=="
width="0" height="0"/>
> - 🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"8.27.0","to":"8.28.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","prPublicId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-03T10:33:13.421Z"},"vulns":[]}'
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@q1blueq1blue
mentioned this pull request
Oct 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 2, 2024
 Closed

@KeeghanMKeeghanM
mentioned this pull request
Oct 3, 2024
 Merged

@BYKBYK
mentioned this pull request
Nov 13, 2025
 Merged

BYK added a commit
that referenced
this pull request
Nov 13, 2025
@BYK@cursoragent
fix(node): Fix Spotlight configuration precedence to match specificat…
c8ca286
…ion (#18195)
## Problem
The Spotlight configuration logic had a precedence bug where when
`spotlight: true` was set in config AND the `SENTRY_SPOTLIGHT`
environment variable contained a URL string, the SDK would incorrectly
use `true` instead of the URL from the environment variable.
According to the [Spotlight
specification](https://raw.githubusercontent.com/getsentry/sentry-docs/b38e3b307f900665a348f855559ac1d1c58914cc/develop-docs/sdk/expected-features/spotlight.mdx),
when `spotlight: true` is set and the env var contains a URL, the URL
from the env var should be used to allow developers to override the
Spotlight URL via environment variables.
**Previous behavior:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = true ❌ (incorrect)
```
**Expected behavior per spec:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = "http://custom:3000/stream" ✅ (correct)
```
## Solution
Fixed the precedence logic in `getClientOptions()` to properly implement
the specification:
1. `spotlight: false` → Always disabled (overrides env var)
2. `spotlight: string` → Uses the config URL (ignores env var)
3. `spotlight: true` + env var URL → **Uses the env var URL** (the bug
fix)
4. `spotlight: true` + env var truthy → Uses default URL
5. No config + env var → Parses and uses env var
The implementation reuses the existing `envToBool()` utility to avoid
code duplication.
## Changes
- Fixed Spotlight precedence logic in
`packages/node-core/src/sdk/index.ts`
- Added 12 comprehensive test cases covering all precedence scenarios in
`packages/node-core/test/sdk/init.test.ts`
- Updated CHANGELOG.md
## Test Coverage
The new tests cover:
- ✅ Env var only: truthy values, falsy values, URL strings
- ✅ Config only: `true`, `false`, URL string
- ✅ Precedence: config `false` overrides env var (URL, truthy, falsy)
- ✅ Precedence: config URL overrides env var
- ✅ Precedence: config `true` + env var URL uses env var URL (the fix)
- ✅ Precedence: config `true` + env var truthy uses default URL
## Related
- Original Spotlight implementation: #13325
- Spotlight specification: https://spotlightjs.com/
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@BYK@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: Add support for SENTRY_SPOTLIGHT env var in Node - #13325
Merged
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Aug 13, 2024
Merged
feat: Add support for SENTRY_SPOTLIGHT env var in Node#13325
Lms24 merged 10 commits into
getsentry:developfrom 
BYK:byk/feat/SENTRY_SPOTLIGHT
Conversation
@BYK
@BYKBYK
commented
Aug 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's just be consistent with env variable values and then this is good to go!
Comment threadpackages/node/src/sdk/index.ts
Outdated

@Lms24
Lms24
commented
Aug 13, 2024

Copy link


Copy Markdown

Member
Also, please update the PR description with the motivation for this change. You and I know it but let's make sure others have the context as well :)
@BYK
BYK
requested a review
from Lms24August 13, 2024 12:23
Lms24
Lms24
reviewed
Aug 13, 2024
View reviewed changes
Comment threadpackages/node/src/sdk/index.ts
Comment threadpackages/node/src/utils/envToBool.ts
Lms24
Lms24
approved these changes
Aug 13, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!
Comment threadpackages/node/test/utils/envToBool.test.ts
@Lms24
Lms24
merged commit 55220cf
into
getsentry:developAug 13, 2024
@BYK
BYK
deleted the

byk/feat/SENTRY_SPOTLIGHT

branch
August 13, 2024 15:00
@bagulm123bagulm123
mentioned this pull request
Sep 18, 2024
 Open

@onsailsonsails
mentioned this pull request
Sep 18, 2024
 Open

@mohamed-helmy22020mohamed-helmy22020
mentioned this pull request
Sep 18, 2024
 Open

@gokulk16gokulk16
mentioned this pull request
Sep 23, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 24, 2024
 Open


This was referenced Sep 24, 2024
 Closed

 Closed

@wkylinwkylin
mentioned this pull request
Sep 25, 2024
 Closed

@FengShangWuQiFengShangWuQi
mentioned this pull request
Sep 27, 2024
 Closed

@q1blueq1blue
mentioned this pull request
Sep 27, 2024
 Open

@tristanroberttristanrobert
mentioned this pull request
Sep 28, 2024
 Merged

@q1blueq1blue
mentioned this pull request
Sep 30, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 1, 2024
 Closed

@bagulm123bagulm123
mentioned this pull request
Oct 1, 2024
 Open

vjousse pushed a commit
to MTES-MCT/ecobalyse
that referenced
this pull request
Oct 1, 2024
@tristanrobert@snyk-bot
chore(Snyk): Upgrade @sentry/browser from 8.27.0 to 8.28.0 (#775)
cea4b83
![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)
<h3>Snyk has created this PR to upgrade @sentry/browser from 8.27.0 to
8.28.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released on **25 days ago**.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>@sentry/browser</b></summary>
<ul>
<li>
<b>8.28.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.28.0">2024-09-03</a></br><h3>Important
Changes</h3>
<ul>
<li><strong>Beta release of official NestJS SDK</strong></li>
</ul>
<p>This release contains the beta version of <code>@
sentry/nestjs</code>! For details on how to use it, check out the<br>
<a
href="https://github.com/getsentry/sentry-javascript/blob/master/packages/nestjs/README.md">README</a>.
Any feedback/bug reports<br>
are greatly appreciated, please reach out on GitHub.</p>
<ul>
<li><strong>fix(browser): Remove faulty LCP, FCP and FP normalization
logic (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2491960592" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13502"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13502/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13502">#13502</a>)</strong></li>
</ul>
<p>This release fixes a bug in the <code>@ sentry/browser</code> package
and all SDKs depending on this package (e.g. <code>@
sentry/react</code><br>
or <code>@ sentry/nextjs</code>) that caused the SDK to send incorrect
web vital values for the LCP, FCP and FP vitals. The SDK<br>
previously incorrectly processed the original values as they were
reported from the browser. When updating your SDK to<br>
this version, you might experience an increase in LCP, FCP and FP
values, which potentially leads to a decrease in your<br>
performance score in the Web Vitals Insights module in Sentry. This is
because the previously reported values were<br>
smaller than the actually measured values. We apologize for the
inconvenience!</p>
<h3>Other Changes</h3>
<ul>
<li>feat(nestjs): Add <code>SentryGlobalGraphQLFilter</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2498873205" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13545"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13545/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13545">#13545</a>)</li>
<li>feat(nestjs): Automatic instrumentation of nestjs interceptors after
route execution (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2453558373"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13264"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13264/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13264">#13264</a>)</li>
<li>feat(nextjs): Add <code>bundleSizeOptimizations</code> to build
options (<a class="issue-link js-issue-link" data-error-text="Failed to
load title" data-id="2461140938" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13323"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13323/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13323">#13323</a>)</li>
<li>feat(nextjs): Stabilize <code>captureRequestError</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2500682873" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13550"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13550/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13550">#13550</a>)</li>
<li>feat(nuxt): Wrap config in nuxt context (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2486658763" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13457"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13457/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13457">#13457</a>)</li>
<li>feat(profiling): Expose profiler as top level primitive (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2492896219" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13512"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13512/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13512">#13512</a>)</li>
<li>feat(replay): Add layout shift to CLS replay data (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2466359020" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13386"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13386/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13386">#13386</a>)</li>
<li>feat(replay): Upgrade rrweb packages to 2.26.0 (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489549947" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13483"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13483/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13483">#13483</a>)</li>
<li>fix(cdn): Do not mangle _metadata (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2473467027" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13426"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13426/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13426">#13426</a>)</li>
<li>fix(cdn): Fix SDK source for CDN bundles (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2489085687" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13475"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13475/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13475">#13475</a>)</li>
<li>fix(nestjs): Check arguments before instrumenting with <code>@
Injectable</code> (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2498819596"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13544"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13544/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13544">#13544</a>)</li>
<li>fix(nestjs): Ensure exception and host are correctly passed on when
using @ WithSentry (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2501912092"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13564"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13564/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13564">#13564</a>)</li>
<li>fix(node): Suppress tracing for transport request execution rather
than transport creation (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2491355594"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13491"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13491/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13491">#13491</a>)</li>
<li>fix(replay): Consider more things as DOM mutations for dead clicks
(<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="2493890628" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13518"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13518/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13518">#13518</a>)</li>
<li>fix(vue): Correctly obtain component name (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="2490176912" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13484"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13484/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13484">#13484</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/leopoldkristjansson/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/leopoldkristjansson">@ leopoldkristjansson</a>,
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mhuggins/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/mhuggins">@ mhuggins</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/filips123/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/filips123">@ filips123</a>. Thank you for
your<br>
contributions!</p>
</li>
<li>
<b>8.27.0</b> - <a
href="https://github.com/getsentry/sentry-javascript/releases/tag/8.27.0">2024-08-27</a></br><h3>Important
Changes</h3>
<ul>
<li>
<p><strong>fix(nestjs): Exception filters in main app module are not
being executed (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="2455715839"
data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13278"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13278/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13278">#13278</a>)</strong></p>
<p>With this release nestjs error monitoring is no longer automatically
set up after adding the <code>SentryModule</code> to your<br>
application, which led to issues in certain scenarios. You will now have
to either add the <code>SentryGlobalFilter</code> to<br>
your main module providers or decorate the <code>catch()</code> method
in your existing global exception filters with the newly<br>
released <code>@ WithSentry()</code> decorator. See the <a
href="https://docs.sentry.io/platforms/javascript/guides/nestjs/"
rel="nofollow">docs</a> for<br>
more details.</p>
</li>
</ul>
<h3>Other Changes</h3>
<ul>
<li>feat: Add options for passing nonces to feedback integration (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2463099308" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13347"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13347/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13347">#13347</a>)</li>
<li>feat: Add support for SENTRY_SPOTLIGHT env var in Node (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461216903" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13325"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13325/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13325">#13325</a>)</li>
<li>feat(deps): bump @ prisma/instrumentation from 5.17.0 to 5.18.0 (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2461290821" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13327"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13327/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13327">#13327</a>)</li>
<li>feat(feedback): Improve error message for 403 errors (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2476011686" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13441"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13441/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13441">#13441</a>)</li>
<li>fix(deno): Don't rely on <code>Deno.permissions.querySync</code> (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2465617012" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13378"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13378/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13378">#13378</a>)</li>
<li>fix(replay): Ensure we publish replay CDN bundles (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="2475611875" data-permission-text="Title is private"
data-url="getsentry/sentry-javascript#13437"
data-hovercard-type="pull_request"
data-hovercard-url="/getsentry/sentry-javascript/pull/13437/hovercard"
href="https://github.com/getsentry/sentry-javascript/pull/13437">#13437</a>)</li>
</ul>
<p>Work in this release was contributed by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/charpeni/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://github.com/charpeni">@ charpeni</a>. Thank you for your
contribution!</p>
</li>
</ul>
from <a
href="https://github.com/getsentry/sentry-javascript/releases">@sentry/browser
GitHub release notes</a>
</details>
</details>
---
> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.
---
**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._
**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODVjYTllMS0yOGRmLTRmMmQtOWViYi02MmYzMjcwMDQ3OWUiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4NWNhOWUxLTI4ZGYtNGYyZC05ZWJiLTYyZjMyNzAwNDc5ZSJ9fQ=="
width="0" height="0"/>
> - 🧐 [View latest project
report](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6/settings/integration?pkg&#x3D;@sentry/browser&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)
[//]: #
'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"8.27.0","to":"8.28.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","prPublicId":"d85ca9e1-28df-4f2d-9ebb-62f32700479e","packageManager":"npm","priorityScoreList":[],"projectPublicId":"8a1190df-0364-4a9a-93bd-a9f28b54daf6","projectUrl":"https://app.snyk.io/org/mtes-mct/project/8a1190df-0364-4a9a-93bd-a9f28b54daf6?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2024-09-03T10:33:13.421Z"},"vulns":[]}'
Co-authored-by: snyk-bot <snyk-bot@snyk.io>
@q1blueq1blue
mentioned this pull request
Oct 1, 2024
 Open

@wkylinwkylin
mentioned this pull request
Oct 2, 2024
 Closed

@KeeghanMKeeghanM
mentioned this pull request
Oct 3, 2024
 Merged

@BYKBYK
mentioned this pull request
Nov 13, 2025
 Merged

BYK added a commit
that referenced
this pull request
Nov 13, 2025
@BYK@cursoragent
fix(node): Fix Spotlight configuration precedence to match specificat…
c8ca286
…ion (#18195)
## Problem
The Spotlight configuration logic had a precedence bug where when
`spotlight: true` was set in config AND the `SENTRY_SPOTLIGHT`
environment variable contained a URL string, the SDK would incorrectly
use `true` instead of the URL from the environment variable.
According to the [Spotlight
specification](https://raw.githubusercontent.com/getsentry/sentry-docs/b38e3b307f900665a348f855559ac1d1c58914cc/develop-docs/sdk/expected-features/spotlight.mdx),
when `spotlight: true` is set and the env var contains a URL, the URL
from the env var should be used to allow developers to override the
Spotlight URL via environment variables.
**Previous behavior:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = true ❌ (incorrect)
```
**Expected behavior per spec:**
```typescript
// Config: spotlight: true
// Env: SENTRY_SPOTLIGHT=http://custom:3000/stream
// Result: spotlight = "http://custom:3000/stream" ✅ (correct)
```
## Solution
Fixed the precedence logic in `getClientOptions()` to properly implement
the specification:
1. `spotlight: false` → Always disabled (overrides env var)
2. `spotlight: string` → Uses the config URL (ignores env var)
3. `spotlight: true` + env var URL → **Uses the env var URL** (the bug
fix)
4. `spotlight: true` + env var truthy → Uses default URL
5. No config + env var → Parses and uses env var
The implementation reuses the existing `envToBool()` utility to avoid
code duplication.
## Changes
- Fixed Spotlight precedence logic in
`packages/node-core/src/sdk/index.ts`
- Added 12 comprehensive test cases covering all precedence scenarios in
`packages/node-core/test/sdk/init.test.ts`
- Updated CHANGELOG.md
## Test Coverage
The new tests cover:
- ✅ Env var only: truthy values, falsy values, URL strings
- ✅ Config only: `true`, `false`, URL string
- ✅ Precedence: config `false` overrides env var (URL, truthy, falsy)
- ✅ Precedence: config URL overrides env var
- ✅ Precedence: config `true` + env var URL uses env var URL (the fix)
- ✅ Precedence: config `true` + env var truthy uses default URL
## Related
- Original Spotlight implementation: #13325
- Spotlight specification: https://spotlightjs.com/
---------
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@BYK@Lms24