Uh oh!
There was an error while loading. Please reload this page.
test: Ensure browser-integration-tests cannot conflict due to build - #13338
Merged
Conversation
Contributor
size-limit report 📦
|
mydeaforce-pushed
the
fn/flaky-test-streamline
branch
from
August 13, 2024 09:31
9e8f487 to
702d505Comparechargome
approved these changes
Aug 13, 2024
chargome
left a comment
Member
There was a problem hiding this comment.
LGTM, would it be worth to put the base url in a const though in case we need to update it again at some point?
mydea
commented
Aug 13, 2024
MemberAuthor
the base url is really pretty arbitrary, in most cases it does not matter, IMHO it is just clearer to have it with a name like this vs some localhost name where it is not clear if this comes from somewhere important or not 😅 |
billyvg
approved these changes
Aug 13, 2024
billyvg
left a comment
Member
There was a problem hiding this comment.
LGTM -- should we remove these try/catches so that if these error, they should break the build? (this shouldn't error anymore anyway)
mydeaforce-pushed
the
fn/flaky-test-streamline
branch
from
August 14, 2024 08:14
702d505 to
d87049dCompareThis streamlines some stuff in our browser integration tests, to fix some flakiness (hopefully). The biggest change is that instead of always building into `dist` for each test file, each test will now build into a random subfolder, e.g. `dist/abc`. This way, multiple tests in a single file will never conflict with each other.
mydeaforce-pushed
the
fn/flaky-test-streamline
branch
from
August 14, 2024 09:59
d87049d to
d35b73bCompareZen-cronic pushed a commit
to Zen-cronic/sentry-javascript
that referenced
this pull request
Aug 26, 2024
…etsentry#13338) This streamlines some stuff in our browser integration tests, to fix some flakiness (hopefully). The biggest change is that instead of always building into `dist` for each test file, each test will now build into a random subfolder, e.g. `dist/abc`. This way, multiple tests in a single file will never conflict with each other. Additionally it also streamlines some of the tests I encountered while looking at stuff, hopefully reducing flakes further. Closesgetsentry#13321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This streamlines some stuff in our browser integration tests, to fix some flakiness (hopefully).
The biggest change is that instead of always building into
distfor each test file, each test will now build into a random subfolder, e.g.dist/abc. This way, multiple tests in a single file will never conflict with each other.Additionally it also streamlines some of the tests I encountered while looking at stuff, hopefully reducing flakes further.
Closes#13321