feat(gatsby): Add optional deleteSourcemapsAfterUpload

[julianCast]

Related #13582
This work adds the deleteSourcemapsAfterUpload option to the Gatsby plugin, allowing it to be passed to the Webpack plugin to set the sourceMapFilesToDeleteAfterUpload without exposing the API.

This simplifies our workflow by eliminating the need to apply a Yarn patch to modify the package whenever we want to use filesToDeleteAfterUpload.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[AbhiPrasad]

@getsentry/team-web-sdk-frontend what does everything think about exposing the API like this?

[s1gr1d]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

[lforst]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

I actually think the way we have structured this is suboptimal. Gave the same feedback here: #13493

sourcemaps as a key inside sourceMapsUploadOptions makes little sense. I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

All other options should be accessible over an experimental_webpackPluginOptions option or something like that.

[julianCast]

I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

I could pass deleteSourcemapsAfterUpload as boolean option, that would be consistent with the existent option enableClientWebpackPlugin

[julianCast]

I've modified this work by using a boolean deleteSourcemapsAfterUpload option to avoid API exposing.

[lforst]

Thanks!

[AbhiPrasad]

This was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.31.0 - thanks for the PR @julianCast!

[julianCast]

Related #13582
This work adds the deleteSourcemapsAfterUpload option to the Gatsby plugin, allowing it to be passed to the Webpack plugin to set the sourceMapFilesToDeleteAfterUpload without exposing the API.

This simplifies our workflow by eliminating the need to apply a Yarn patch to modify the package whenever we want to use filesToDeleteAfterUpload.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[AbhiPrasad]

@getsentry/team-web-sdk-frontend what does everything think about exposing the API like this?

[s1gr1d]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

[lforst]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

I actually think the way we have structured this is suboptimal. Gave the same feedback here: #13493

sourcemaps as a key inside sourceMapsUploadOptions makes little sense. I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

All other options should be accessible over an experimental_webpackPluginOptions option or something like that.

[julianCast]

I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

I could pass deleteSourcemapsAfterUpload as boolean option, that would be consistent with the existent option enableClientWebpackPlugin

[julianCast]

I've modified this work by using a boolean deleteSourcemapsAfterUpload option to avoid API exposing.

[lforst]

Thanks!

[AbhiPrasad]

This was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.31.0 - thanks for the PR @julianCast!

[julianCast]

Related #13582
This work adds the deleteSourcemapsAfterUpload option to the Gatsby plugin, allowing it to be passed to the Webpack plugin to set the sourceMapFilesToDeleteAfterUpload without exposing the API.

This simplifies our workflow by eliminating the need to apply a Yarn patch to modify the package whenever we want to use filesToDeleteAfterUpload.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[AbhiPrasad]

@getsentry/team-web-sdk-frontend what does everything think about exposing the API like this?

[s1gr1d]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

[lforst]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

I actually think the way we have structured this is suboptimal. Gave the same feedback here: #13493

sourcemaps as a key inside sourceMapsUploadOptions makes little sense. I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

All other options should be accessible over an experimental_webpackPluginOptions option or something like that.

[julianCast]

I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

I could pass deleteSourcemapsAfterUpload as boolean option, that would be consistent with the existent option enableClientWebpackPlugin

[julianCast]

I've modified this work by using a boolean deleteSourcemapsAfterUpload option to avoid API exposing.

[lforst]

Thanks!

[AbhiPrasad]

This was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.31.0 - thanks for the PR @julianCast!

[julianCast]

Related #13582
This work adds the deleteSourcemapsAfterUpload option to the Gatsby plugin, allowing it to be passed to the Webpack plugin to set the sourceMapFilesToDeleteAfterUpload without exposing the API.

This simplifies our workflow by eliminating the need to apply a Yarn patch to modify the package whenever we want to use filesToDeleteAfterUpload.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[AbhiPrasad]

@getsentry/team-web-sdk-frontend what does everything think about exposing the API like this?

[s1gr1d]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

[lforst]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

I actually think the way we have structured this is suboptimal. Gave the same feedback here: #13493

sourcemaps as a key inside sourceMapsUploadOptions makes little sense. I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

All other options should be accessible over an experimental_webpackPluginOptions option or something like that.

[julianCast]

I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

I could pass deleteSourcemapsAfterUpload as boolean option, that would be consistent with the existent option enableClientWebpackPlugin

[julianCast]

I've modified this work by using a boolean deleteSourcemapsAfterUpload option to avoid API exposing.

[lforst]

Thanks!

[AbhiPrasad]

This was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.31.0 - thanks for the PR @julianCast!

[julianCast]

Related #13582
This work adds the deleteSourcemapsAfterUpload option to the Gatsby plugin, allowing it to be passed to the Webpack plugin to set the sourceMapFilesToDeleteAfterUpload without exposing the API.

This simplifies our workflow by eliminating the need to apply a Yarn patch to modify the package whenever we want to use filesToDeleteAfterUpload.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[AbhiPrasad]

@getsentry/team-web-sdk-frontend what does everything think about exposing the API like this?

[s1gr1d]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

[lforst]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

I actually think the way we have structured this is suboptimal. Gave the same feedback here: #13493

sourcemaps as a key inside sourceMapsUploadOptions makes little sense. I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

All other options should be accessible over an experimental_webpackPluginOptions option or something like that.

[julianCast]

I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

I could pass deleteSourcemapsAfterUpload as boolean option, that would be consistent with the existent option enableClientWebpackPlugin

[julianCast]

I've modified this work by using a boolean deleteSourcemapsAfterUpload option to avoid API exposing.

[lforst]

Thanks!

[AbhiPrasad]

This was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.31.0 - thanks for the PR @julianCast!

[julianCast]

Related #13582
This work adds the deleteSourcemapsAfterUpload option to the Gatsby plugin, allowing it to be passed to the Webpack plugin to set the sourceMapFilesToDeleteAfterUpload without exposing the API.

This simplifies our workflow by eliminating the need to apply a Yarn patch to modify the package whenever we want to use filesToDeleteAfterUpload.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[AbhiPrasad]

@getsentry/team-web-sdk-frontend what does everything think about exposing the API like this?

[s1gr1d]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

[lforst]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

I actually think the way we have structured this is suboptimal. Gave the same feedback here: #13493

sourcemaps as a key inside sourceMapsUploadOptions makes little sense. I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

All other options should be accessible over an experimental_webpackPluginOptions option or something like that.

[julianCast]

I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

I could pass deleteSourcemapsAfterUpload as boolean option, that would be consistent with the existent option enableClientWebpackPlugin

[julianCast]

I've modified this work by using a boolean deleteSourcemapsAfterUpload option to avoid API exposing.

[lforst]

Thanks!

[AbhiPrasad]

This was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.31.0 - thanks for the PR @julianCast!

[julianCast]

Related #13582
This work adds the deleteSourcemapsAfterUpload option to the Gatsby plugin, allowing it to be passed to the Webpack plugin to set the sourceMapFilesToDeleteAfterUpload without exposing the API.

This simplifies our workflow by eliminating the need to apply a Yarn patch to modify the package whenever we want to use filesToDeleteAfterUpload.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[AbhiPrasad]

@getsentry/team-web-sdk-frontend what does everything think about exposing the API like this?

[s1gr1d]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

[lforst]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

I actually think the way we have structured this is suboptimal. Gave the same feedback here: #13493

sourcemaps as a key inside sourceMapsUploadOptions makes little sense. I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

All other options should be accessible over an experimental_webpackPluginOptions option or something like that.

[julianCast]

I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

I could pass deleteSourcemapsAfterUpload as boolean option, that would be consistent with the existent option enableClientWebpackPlugin

[julianCast]

I've modified this work by using a boolean deleteSourcemapsAfterUpload option to avoid API exposing.

[lforst]

Thanks!

[AbhiPrasad]

This was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.31.0 - thanks for the PR @julianCast!

[julianCast]

Related #13582
This work adds the deleteSourcemapsAfterUpload option to the Gatsby plugin, allowing it to be passed to the Webpack plugin to set the sourceMapFilesToDeleteAfterUpload without exposing the API.

This simplifies our workflow by eliminating the need to apply a Yarn patch to modify the package whenever we want to use filesToDeleteAfterUpload.

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[AbhiPrasad]

@getsentry/team-web-sdk-frontend what does everything think about exposing the API like this?

[s1gr1d]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

[lforst]

I would align the API with the other SDKs. The other SDKs have it mostly like this:

sourceMapsUploadOptions: {sourcemaps: {assets: ['foo/*.js'],ignore: ['bar/*.js'],filesToDeleteAfterUpload: ['baz/*.js'],},},

I actually think the way we have structured this is suboptimal. Gave the same feedback here: #13493

sourcemaps as a key inside sourceMapsUploadOptions makes little sense. I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

All other options should be accessible over an experimental_webpackPluginOptions option or something like that.

[julianCast]

I would generally try to avoid exposing the API at all when the framework gives a default (like in the case of Gatsby) and then have a simple boolean deleteSourcemapsAfterUpload: true as a top-level option instead.

I could pass deleteSourcemapsAfterUpload as boolean option, that would be consistent with the existent option enableClientWebpackPlugin

[julianCast]

I've modified this work by using a boolean deleteSourcemapsAfterUpload option to avoid API exposing.

[lforst]

Thanks!

[AbhiPrasad]

This was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.31.0 - thanks for the PR @julianCast!