Uh oh!
There was an error while loading. Please reload this page.
feat(otel): Upgrade @opentelemetry/semantic-conventions to 1.26.0 - #13631
Merged
Conversation
AbhiPrasad
requested review from
stephanie-anderson
and removed request for
a teamSeptember 9, 2024 11:50
AbhiPrasad
commented
Sep 9, 2024
| SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD, | ||
| SEMANTIC_ATTRIBUTE_SENTRY_OP, | ||
| SEMANTIC_ATTRIBUTE_SENTRY_SAMPLE_RATE, | ||
| SEMANTIC_ATTRIBUTE_URL_FULL, |
ContributorAuthor
There was a problem hiding this comment.
I can't totally remove SEMANTIC_ATTRIBUTE_URL_FULL from core export because non-otel SDKs also use it, but maybe we should just hardcode the string?
Collaborator
There was a problem hiding this comment.
I have no strong opinions either way!
AbhiPrasadforce-pushed
the
abhi-bump-otel-conventions-1.26.0
branch
from
September 9, 2024 12:54
7885d49 to
c74742cCompareAbhiPrasad
commented
Sep 9, 2024
| ATTR_HTTP_METHOD, | ||
| ATTR_HTTP_REQUEST_METHOD, | ||
| ATTR_HTTP_TARGET, | ||
| } from '@opentelemetry/semantic-conventions/incubating'; |
ContributorAuthor
There was a problem hiding this comment.
I'm a little nervous about adding these subpath imports here.
Will this break bundling?
Collaborator
There was a problem hiding this comment.
It shouldn't. Is this in their package exports? Do the cjs tests pass for older node versions?
ContributorAuthor
There was a problem hiding this comment.
yeah so this seems to break the jest tests hmm. Let me dig into why this is.
timfish
approved these changes
Sep 9, 2024
In 1.26.0 otel-js has updated the deprecations for the attributes based on the new changes to semantic conventions. They also changed the name of some exports, for example: `SEMATTRS_HTTP_ROUTE` -> `ATTR_HTTP_ROUTE`. Some exports names were not able to be changed because they are imported from a subpath export @opentelemetry/semantic-conventions/incubating. This subpath breaks some bundling setups, so we are unable to use it.
AbhiPrasadforce-pushed
the
abhi-bump-otel-conventions-1.26.0
branch
from
September 10, 2024 09:04
c74742c to
899e6e6CompareAbhiPrasad
commented
Sep 10, 2024
ContributorAuthor
I ended up changing this PR to remove the subpath exports. The change is less crazy now, so I'll merge in after CI passes. |
Contributor
size-limit report 📦
|
This was referenced Oct 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves#13627
In 1.26.0 otel-js has updated the deprecations for the attributes based on the new changes to semantic conventions.
They also changed the name of some exports, for example:
SEMATTRS_HTTP_ROUTE->ATTR_HTTP_ROUTE. Some exports names were not able to be changed because they are imported from a subpath export @opentelemetry/semantic-conventions/incubating. This subpath breaks some bundling setups, so we are unable to use it.