feat(vue): Apply stateTransformer to attachments in createSentryPiniaPlugin

[sircharlo]

This PR modifies the createSentryPiniaPlugin to apply the stateTransformer to attachments, in addition to the context.

Why?

Attachments can quickly become large when the full store.$state is included, especially if there are items that do not need to be reported to Sentry. By applying the stateTransformer, developers can reduce the size of attachments, avoid unnecessary data uploads, and stay within their Sentry usage limits.

Changes

• Moved some code around to transform store.$state using the stateTransformer (if provided) before including it in the attachments as well as the context.

Benefits

• Reduces the size of attachments.
• Prevents unnecessary data from being sent to Sentry.
• Helps avoid hitting monthly usage caps prematurely.

Let me know if further adjustments are needed!

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[onurtemizkan]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

[sircharlo]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

[mydea]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

As far as I see we only have pinia tests in the vue-3 and nuxt-4 E2E test apps, so adding tests to one of these (probably vue-3?) sounds reasonable to me! Not sure if others (cc @onurtemizkan or @s1gr1d ) have other ideas for this.

[onurtemizkan]

@mydea, yes I also think that's reasonable (and easier) to add cases to e2e tests.

IMHO a new case here will be enough for this PR.

@sircharlo, please let me know if you have any issues running the E2E tests.

[sircharlo]

@onurtemizkan Thanks for the feedback! Ok, I'll continue where I had left off in that file then, as that's where I had started writing a test.

Would this be the correct way to access an attachment from the current scope? I couldn't find an easy way to access the global scope from the error.

constscopeData=error?.sdkProcessingMetadata?.capturedSpanScope?.getScopeData();conststateAttachment=scopeData?.attachments?.find(attachment=>attachment.filename.includes('pinia_state_'));

[mydea]

You can wait for an attachment envelope item like this:

functionwaitForAttachment(proxyServerName: string,callback: (attachment: AttachmentItem[1])=>Promise<boolean>|boolean,): Promise<AttachmentItem[1]>{consttimestamp=getNanosecondTimestamp();returnnewPromise((resolve,reject)=>{waitForEnvelopeItem(proxyServerName,asyncenvelopeItem=>{if(envelopeItem[0].type==='attachment'){constattachmentItem=envelopeItem[1]asAttachmentItem[1];if(awaitcallback(attachmentItem)){resolve(attachmentItem);returntrue;}}returnfalse;},timestamp,).catch(reject);});}

And then use it like this:

consterrorPromise=waitForError('vue-3',asyncerrorEvent=>{returnerrorEvent?.exception?.values?.[0].value==='This is an error';});constattachmentPromise=waitForAttachment('vue-3',asyncattachment=>{returnattachment='...';});awaitpage.locator('#throw-error').click();consterror=awaiterrorPromise;constattachment=awaitattachmentPromise;expect(attachment).toEqual(...);

[tryforceful]

Is there any update on this PR? 🙏🏼

[s1gr1d]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

[sircharlo]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

Hey there; I'm sorry I've been absolutely swamped. I'm afraid I don't have the bandwidth for this at the moment. if someone else could take over, I’d be grateful.

[s1gr1d]

Closing this in favor of this PR: #16034

[sircharlo]

This PR modifies the createSentryPiniaPlugin to apply the stateTransformer to attachments, in addition to the context.

Why?

Attachments can quickly become large when the full store.$state is included, especially if there are items that do not need to be reported to Sentry. By applying the stateTransformer, developers can reduce the size of attachments, avoid unnecessary data uploads, and stay within their Sentry usage limits.

Changes

• Moved some code around to transform store.$state using the stateTransformer (if provided) before including it in the attachments as well as the context.

Benefits

• Reduces the size of attachments.
• Prevents unnecessary data from being sent to Sentry.
• Helps avoid hitting monthly usage caps prematurely.

Let me know if further adjustments are needed!

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[onurtemizkan]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

[sircharlo]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

[mydea]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

As far as I see we only have pinia tests in the vue-3 and nuxt-4 E2E test apps, so adding tests to one of these (probably vue-3?) sounds reasonable to me! Not sure if others (cc @onurtemizkan or @s1gr1d ) have other ideas for this.

[onurtemizkan]

@mydea, yes I also think that's reasonable (and easier) to add cases to e2e tests.

IMHO a new case here will be enough for this PR.

@sircharlo, please let me know if you have any issues running the E2E tests.

[sircharlo]

@onurtemizkan Thanks for the feedback! Ok, I'll continue where I had left off in that file then, as that's where I had started writing a test.

Would this be the correct way to access an attachment from the current scope? I couldn't find an easy way to access the global scope from the error.

constscopeData=error?.sdkProcessingMetadata?.capturedSpanScope?.getScopeData();conststateAttachment=scopeData?.attachments?.find(attachment=>attachment.filename.includes('pinia_state_'));

[mydea]

You can wait for an attachment envelope item like this:

functionwaitForAttachment(proxyServerName: string,callback: (attachment: AttachmentItem[1])=>Promise<boolean>|boolean,): Promise<AttachmentItem[1]>{consttimestamp=getNanosecondTimestamp();returnnewPromise((resolve,reject)=>{waitForEnvelopeItem(proxyServerName,asyncenvelopeItem=>{if(envelopeItem[0].type==='attachment'){constattachmentItem=envelopeItem[1]asAttachmentItem[1];if(awaitcallback(attachmentItem)){resolve(attachmentItem);returntrue;}}returnfalse;},timestamp,).catch(reject);});}

And then use it like this:

consterrorPromise=waitForError('vue-3',asyncerrorEvent=>{returnerrorEvent?.exception?.values?.[0].value==='This is an error';});constattachmentPromise=waitForAttachment('vue-3',asyncattachment=>{returnattachment='...';});awaitpage.locator('#throw-error').click();consterror=awaiterrorPromise;constattachment=awaitattachmentPromise;expect(attachment).toEqual(...);

[tryforceful]

Is there any update on this PR? 🙏🏼

[s1gr1d]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

[sircharlo]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

Hey there; I'm sorry I've been absolutely swamped. I'm afraid I don't have the bandwidth for this at the moment. if someone else could take over, I’d be grateful.

[s1gr1d]

Closing this in favor of this PR: #16034

[sircharlo]

This PR modifies the createSentryPiniaPlugin to apply the stateTransformer to attachments, in addition to the context.

Why?

Attachments can quickly become large when the full store.$state is included, especially if there are items that do not need to be reported to Sentry. By applying the stateTransformer, developers can reduce the size of attachments, avoid unnecessary data uploads, and stay within their Sentry usage limits.

Changes

• Moved some code around to transform store.$state using the stateTransformer (if provided) before including it in the attachments as well as the context.

Benefits

• Reduces the size of attachments.
• Prevents unnecessary data from being sent to Sentry.
• Helps avoid hitting monthly usage caps prematurely.

Let me know if further adjustments are needed!

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[onurtemizkan]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

[sircharlo]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

[mydea]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

As far as I see we only have pinia tests in the vue-3 and nuxt-4 E2E test apps, so adding tests to one of these (probably vue-3?) sounds reasonable to me! Not sure if others (cc @onurtemizkan or @s1gr1d ) have other ideas for this.

[onurtemizkan]

@mydea, yes I also think that's reasonable (and easier) to add cases to e2e tests.

IMHO a new case here will be enough for this PR.

@sircharlo, please let me know if you have any issues running the E2E tests.

[sircharlo]

@onurtemizkan Thanks for the feedback! Ok, I'll continue where I had left off in that file then, as that's where I had started writing a test.

Would this be the correct way to access an attachment from the current scope? I couldn't find an easy way to access the global scope from the error.

constscopeData=error?.sdkProcessingMetadata?.capturedSpanScope?.getScopeData();conststateAttachment=scopeData?.attachments?.find(attachment=>attachment.filename.includes('pinia_state_'));

[mydea]

You can wait for an attachment envelope item like this:

functionwaitForAttachment(proxyServerName: string,callback: (attachment: AttachmentItem[1])=>Promise<boolean>|boolean,): Promise<AttachmentItem[1]>{consttimestamp=getNanosecondTimestamp();returnnewPromise((resolve,reject)=>{waitForEnvelopeItem(proxyServerName,asyncenvelopeItem=>{if(envelopeItem[0].type==='attachment'){constattachmentItem=envelopeItem[1]asAttachmentItem[1];if(awaitcallback(attachmentItem)){resolve(attachmentItem);returntrue;}}returnfalse;},timestamp,).catch(reject);});}

And then use it like this:

consterrorPromise=waitForError('vue-3',asyncerrorEvent=>{returnerrorEvent?.exception?.values?.[0].value==='This is an error';});constattachmentPromise=waitForAttachment('vue-3',asyncattachment=>{returnattachment='...';});awaitpage.locator('#throw-error').click();consterror=awaiterrorPromise;constattachment=awaitattachmentPromise;expect(attachment).toEqual(...);

[tryforceful]

Is there any update on this PR? 🙏🏼

[s1gr1d]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

[sircharlo]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

Hey there; I'm sorry I've been absolutely swamped. I'm afraid I don't have the bandwidth for this at the moment. if someone else could take over, I’d be grateful.

[s1gr1d]

Closing this in favor of this PR: #16034

[sircharlo]

This PR modifies the createSentryPiniaPlugin to apply the stateTransformer to attachments, in addition to the context.

Why?

Attachments can quickly become large when the full store.$state is included, especially if there are items that do not need to be reported to Sentry. By applying the stateTransformer, developers can reduce the size of attachments, avoid unnecessary data uploads, and stay within their Sentry usage limits.

Changes

• Moved some code around to transform store.$state using the stateTransformer (if provided) before including it in the attachments as well as the context.

Benefits

• Reduces the size of attachments.
• Prevents unnecessary data from being sent to Sentry.
• Helps avoid hitting monthly usage caps prematurely.

Let me know if further adjustments are needed!

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[onurtemizkan]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

[sircharlo]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

[mydea]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

As far as I see we only have pinia tests in the vue-3 and nuxt-4 E2E test apps, so adding tests to one of these (probably vue-3?) sounds reasonable to me! Not sure if others (cc @onurtemizkan or @s1gr1d ) have other ideas for this.

[onurtemizkan]

@mydea, yes I also think that's reasonable (and easier) to add cases to e2e tests.

IMHO a new case here will be enough for this PR.

@sircharlo, please let me know if you have any issues running the E2E tests.

[sircharlo]

@onurtemizkan Thanks for the feedback! Ok, I'll continue where I had left off in that file then, as that's where I had started writing a test.

Would this be the correct way to access an attachment from the current scope? I couldn't find an easy way to access the global scope from the error.

constscopeData=error?.sdkProcessingMetadata?.capturedSpanScope?.getScopeData();conststateAttachment=scopeData?.attachments?.find(attachment=>attachment.filename.includes('pinia_state_'));

[mydea]

You can wait for an attachment envelope item like this:

functionwaitForAttachment(proxyServerName: string,callback: (attachment: AttachmentItem[1])=>Promise<boolean>|boolean,): Promise<AttachmentItem[1]>{consttimestamp=getNanosecondTimestamp();returnnewPromise((resolve,reject)=>{waitForEnvelopeItem(proxyServerName,asyncenvelopeItem=>{if(envelopeItem[0].type==='attachment'){constattachmentItem=envelopeItem[1]asAttachmentItem[1];if(awaitcallback(attachmentItem)){resolve(attachmentItem);returntrue;}}returnfalse;},timestamp,).catch(reject);});}

And then use it like this:

consterrorPromise=waitForError('vue-3',asyncerrorEvent=>{returnerrorEvent?.exception?.values?.[0].value==='This is an error';});constattachmentPromise=waitForAttachment('vue-3',asyncattachment=>{returnattachment='...';});awaitpage.locator('#throw-error').click();consterror=awaiterrorPromise;constattachment=awaitattachmentPromise;expect(attachment).toEqual(...);

[tryforceful]

Is there any update on this PR? 🙏🏼

[s1gr1d]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

[sircharlo]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

Hey there; I'm sorry I've been absolutely swamped. I'm afraid I don't have the bandwidth for this at the moment. if someone else could take over, I’d be grateful.

[s1gr1d]

Closing this in favor of this PR: #16034

[sircharlo]

This PR modifies the createSentryPiniaPlugin to apply the stateTransformer to attachments, in addition to the context.

Why?

Attachments can quickly become large when the full store.$state is included, especially if there are items that do not need to be reported to Sentry. By applying the stateTransformer, developers can reduce the size of attachments, avoid unnecessary data uploads, and stay within their Sentry usage limits.

Changes

• Moved some code around to transform store.$state using the stateTransformer (if provided) before including it in the attachments as well as the context.

Benefits

• Reduces the size of attachments.
• Prevents unnecessary data from being sent to Sentry.
• Helps avoid hitting monthly usage caps prematurely.

Let me know if further adjustments are needed!

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[onurtemizkan]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

[sircharlo]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

[mydea]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

As far as I see we only have pinia tests in the vue-3 and nuxt-4 E2E test apps, so adding tests to one of these (probably vue-3?) sounds reasonable to me! Not sure if others (cc @onurtemizkan or @s1gr1d ) have other ideas for this.

[onurtemizkan]

@mydea, yes I also think that's reasonable (and easier) to add cases to e2e tests.

IMHO a new case here will be enough for this PR.

@sircharlo, please let me know if you have any issues running the E2E tests.

[sircharlo]

@onurtemizkan Thanks for the feedback! Ok, I'll continue where I had left off in that file then, as that's where I had started writing a test.

Would this be the correct way to access an attachment from the current scope? I couldn't find an easy way to access the global scope from the error.

constscopeData=error?.sdkProcessingMetadata?.capturedSpanScope?.getScopeData();conststateAttachment=scopeData?.attachments?.find(attachment=>attachment.filename.includes('pinia_state_'));

[mydea]

You can wait for an attachment envelope item like this:

functionwaitForAttachment(proxyServerName: string,callback: (attachment: AttachmentItem[1])=>Promise<boolean>|boolean,): Promise<AttachmentItem[1]>{consttimestamp=getNanosecondTimestamp();returnnewPromise((resolve,reject)=>{waitForEnvelopeItem(proxyServerName,asyncenvelopeItem=>{if(envelopeItem[0].type==='attachment'){constattachmentItem=envelopeItem[1]asAttachmentItem[1];if(awaitcallback(attachmentItem)){resolve(attachmentItem);returntrue;}}returnfalse;},timestamp,).catch(reject);});}

And then use it like this:

consterrorPromise=waitForError('vue-3',asyncerrorEvent=>{returnerrorEvent?.exception?.values?.[0].value==='This is an error';});constattachmentPromise=waitForAttachment('vue-3',asyncattachment=>{returnattachment='...';});awaitpage.locator('#throw-error').click();consterror=awaiterrorPromise;constattachment=awaitattachmentPromise;expect(attachment).toEqual(...);

[tryforceful]

Is there any update on this PR? 🙏🏼

[s1gr1d]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

[sircharlo]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

Hey there; I'm sorry I've been absolutely swamped. I'm afraid I don't have the bandwidth for this at the moment. if someone else could take over, I’d be grateful.

[s1gr1d]

Closing this in favor of this PR: #16034

[sircharlo]

This PR modifies the createSentryPiniaPlugin to apply the stateTransformer to attachments, in addition to the context.

Why?

Attachments can quickly become large when the full store.$state is included, especially if there are items that do not need to be reported to Sentry. By applying the stateTransformer, developers can reduce the size of attachments, avoid unnecessary data uploads, and stay within their Sentry usage limits.

Changes

• Moved some code around to transform store.$state using the stateTransformer (if provided) before including it in the attachments as well as the context.

Benefits

• Reduces the size of attachments.
• Prevents unnecessary data from being sent to Sentry.
• Helps avoid hitting monthly usage caps prematurely.

Let me know if further adjustments are needed!

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[onurtemizkan]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

[sircharlo]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

[mydea]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

As far as I see we only have pinia tests in the vue-3 and nuxt-4 E2E test apps, so adding tests to one of these (probably vue-3?) sounds reasonable to me! Not sure if others (cc @onurtemizkan or @s1gr1d ) have other ideas for this.

[onurtemizkan]

@mydea, yes I also think that's reasonable (and easier) to add cases to e2e tests.

IMHO a new case here will be enough for this PR.

@sircharlo, please let me know if you have any issues running the E2E tests.

[sircharlo]

@onurtemizkan Thanks for the feedback! Ok, I'll continue where I had left off in that file then, as that's where I had started writing a test.

Would this be the correct way to access an attachment from the current scope? I couldn't find an easy way to access the global scope from the error.

constscopeData=error?.sdkProcessingMetadata?.capturedSpanScope?.getScopeData();conststateAttachment=scopeData?.attachments?.find(attachment=>attachment.filename.includes('pinia_state_'));

[mydea]

You can wait for an attachment envelope item like this:

functionwaitForAttachment(proxyServerName: string,callback: (attachment: AttachmentItem[1])=>Promise<boolean>|boolean,): Promise<AttachmentItem[1]>{consttimestamp=getNanosecondTimestamp();returnnewPromise((resolve,reject)=>{waitForEnvelopeItem(proxyServerName,asyncenvelopeItem=>{if(envelopeItem[0].type==='attachment'){constattachmentItem=envelopeItem[1]asAttachmentItem[1];if(awaitcallback(attachmentItem)){resolve(attachmentItem);returntrue;}}returnfalse;},timestamp,).catch(reject);});}

And then use it like this:

consterrorPromise=waitForError('vue-3',asyncerrorEvent=>{returnerrorEvent?.exception?.values?.[0].value==='This is an error';});constattachmentPromise=waitForAttachment('vue-3',asyncattachment=>{returnattachment='...';});awaitpage.locator('#throw-error').click();consterror=awaiterrorPromise;constattachment=awaitattachmentPromise;expect(attachment).toEqual(...);

[tryforceful]

Is there any update on this PR? 🙏🏼

[s1gr1d]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

[sircharlo]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

Hey there; I'm sorry I've been absolutely swamped. I'm afraid I don't have the bandwidth for this at the moment. if someone else could take over, I’d be grateful.

[s1gr1d]

Closing this in favor of this PR: #16034

[sircharlo]

This PR modifies the createSentryPiniaPlugin to apply the stateTransformer to attachments, in addition to the context.

Why?

Attachments can quickly become large when the full store.$state is included, especially if there are items that do not need to be reported to Sentry. By applying the stateTransformer, developers can reduce the size of attachments, avoid unnecessary data uploads, and stay within their Sentry usage limits.

Changes

• Moved some code around to transform store.$state using the stateTransformer (if provided) before including it in the attachments as well as the context.

Benefits

• Reduces the size of attachments.
• Prevents unnecessary data from being sent to Sentry.
• Helps avoid hitting monthly usage caps prematurely.

Let me know if further adjustments are needed!

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[onurtemizkan]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

[sircharlo]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

[mydea]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

As far as I see we only have pinia tests in the vue-3 and nuxt-4 E2E test apps, so adding tests to one of these (probably vue-3?) sounds reasonable to me! Not sure if others (cc @onurtemizkan or @s1gr1d ) have other ideas for this.

[onurtemizkan]

@mydea, yes I also think that's reasonable (and easier) to add cases to e2e tests.

IMHO a new case here will be enough for this PR.

@sircharlo, please let me know if you have any issues running the E2E tests.

[sircharlo]

@onurtemizkan Thanks for the feedback! Ok, I'll continue where I had left off in that file then, as that's where I had started writing a test.

Would this be the correct way to access an attachment from the current scope? I couldn't find an easy way to access the global scope from the error.

constscopeData=error?.sdkProcessingMetadata?.capturedSpanScope?.getScopeData();conststateAttachment=scopeData?.attachments?.find(attachment=>attachment.filename.includes('pinia_state_'));

[mydea]

You can wait for an attachment envelope item like this:

functionwaitForAttachment(proxyServerName: string,callback: (attachment: AttachmentItem[1])=>Promise<boolean>|boolean,): Promise<AttachmentItem[1]>{consttimestamp=getNanosecondTimestamp();returnnewPromise((resolve,reject)=>{waitForEnvelopeItem(proxyServerName,asyncenvelopeItem=>{if(envelopeItem[0].type==='attachment'){constattachmentItem=envelopeItem[1]asAttachmentItem[1];if(awaitcallback(attachmentItem)){resolve(attachmentItem);returntrue;}}returnfalse;},timestamp,).catch(reject);});}

And then use it like this:

consterrorPromise=waitForError('vue-3',asyncerrorEvent=>{returnerrorEvent?.exception?.values?.[0].value==='This is an error';});constattachmentPromise=waitForAttachment('vue-3',asyncattachment=>{returnattachment='...';});awaitpage.locator('#throw-error').click();consterror=awaiterrorPromise;constattachment=awaitattachmentPromise;expect(attachment).toEqual(...);

[tryforceful]

Is there any update on this PR? 🙏🏼

[s1gr1d]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

[sircharlo]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

Hey there; I'm sorry I've been absolutely swamped. I'm afraid I don't have the bandwidth for this at the moment. if someone else could take over, I’d be grateful.

[s1gr1d]

Closing this in favor of this PR: #16034

[sircharlo]

This PR modifies the createSentryPiniaPlugin to apply the stateTransformer to attachments, in addition to the context.

Why?

Attachments can quickly become large when the full store.$state is included, especially if there are items that do not need to be reported to Sentry. By applying the stateTransformer, developers can reduce the size of attachments, avoid unnecessary data uploads, and stay within their Sentry usage limits.

Changes

• Moved some code around to transform store.$state using the stateTransformer (if provided) before including it in the attachments as well as the context.

Benefits

• Reduces the size of attachments.
• Prevents unnecessary data from being sent to Sentry.
• Helps avoid hitting monthly usage caps prematurely.

Let me know if further adjustments are needed!

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[onurtemizkan]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

[sircharlo]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

[mydea]

Thanks for the PR @sircharlo. Implementation looks good to me, could you also add a test for this?

Erm I can try. Not sure, I had started adding something in e2e but in the Discord I was told that was the wrong place for it.

As far as I see we only have pinia tests in the vue-3 and nuxt-4 E2E test apps, so adding tests to one of these (probably vue-3?) sounds reasonable to me! Not sure if others (cc @onurtemizkan or @s1gr1d ) have other ideas for this.

[onurtemizkan]

@mydea, yes I also think that's reasonable (and easier) to add cases to e2e tests.

IMHO a new case here will be enough for this PR.

@sircharlo, please let me know if you have any issues running the E2E tests.

[sircharlo]

@onurtemizkan Thanks for the feedback! Ok, I'll continue where I had left off in that file then, as that's where I had started writing a test.

Would this be the correct way to access an attachment from the current scope? I couldn't find an easy way to access the global scope from the error.

constscopeData=error?.sdkProcessingMetadata?.capturedSpanScope?.getScopeData();conststateAttachment=scopeData?.attachments?.find(attachment=>attachment.filename.includes('pinia_state_'));

[mydea]

You can wait for an attachment envelope item like this:

functionwaitForAttachment(proxyServerName: string,callback: (attachment: AttachmentItem[1])=>Promise<boolean>|boolean,): Promise<AttachmentItem[1]>{consttimestamp=getNanosecondTimestamp();returnnewPromise((resolve,reject)=>{waitForEnvelopeItem(proxyServerName,asyncenvelopeItem=>{if(envelopeItem[0].type==='attachment'){constattachmentItem=envelopeItem[1]asAttachmentItem[1];if(awaitcallback(attachmentItem)){resolve(attachmentItem);returntrue;}}returnfalse;},timestamp,).catch(reject);});}

And then use it like this:

consterrorPromise=waitForError('vue-3',asyncerrorEvent=>{returnerrorEvent?.exception?.values?.[0].value==='This is an error';});constattachmentPromise=waitForAttachment('vue-3',asyncattachment=>{returnattachment='...';});awaitpage.locator('#throw-error').click();consterror=awaiterrorPromise;constattachment=awaitattachmentPromise;expect(attachment).toEqual(...);

[tryforceful]

Is there any update on this PR? 🙏🏼

[s1gr1d]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

[sircharlo]

The tests in the PR are still missing. @sircharlo do you want to add them? Otherwise, @onurtemizkan or me can take the PR over.

Hey there; I'm sorry I've been absolutely swamped. I'm afraid I don't have the bandwidth for this at the moment. if someone else could take over, I’d be grateful.

[s1gr1d]

Closing this in favor of this PR: #16034