Uh oh!
There was an error while loading. Please reload this page.
feat(browser): Attach virtual stack traces to HttpClient events. - #14515
Merged
Conversation
Contributor
size-limit report 📦
|
onurtemizkanforce-pushed
the
onur/httpclient-fingerprints
branch
2 times, most recently
from
November 27, 2024 18:43
252e544 to
7597e64Compare❌ 29 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
onurtemizkanforce-pushed
the
onur/httpclient-fingerprints
branch
3 times, most recently
from
November 27, 2024 20:04
ed1f24d to
21169f8Compareonurtemizkan
marked this pull request as ready for review
November 27, 2024 20:04
onurtemizkanforce-pushed
the
onur/httpclient-fingerprints
branch
from
November 28, 2024 03:08
21169f8 to
d58da1cComparemydea
reviewed
Nov 28, 2024
| endTimestamp: timestampInSeconds() * 1000, | ||
| startTimestamp, | ||
| xhr: xhrOpenThisArg, | ||
| error: httpClientInstrumented ? virtualError : undefined, |
Member
There was a problem hiding this comment.
m: Can we just directly attach the stackframe here, instead of passing the error around? then we can maybe just ignore these checks and simply always attach this here 🤔
ContributorAuthor
There was a problem hiding this comment.
Yes, this made it work with ESM builds. Thanks!
onurtemizkanforce-pushed
the
onur/httpclient-fingerprints
branch
from
November 28, 2024 11:54
05e3351 to
c0b864aComparelforst
reviewed
Nov 29, 2024
Comment on lines
+58
to
+59
| const virtualError = new Error(); | ||
| const virtualStackTrace = virtualError.stack; |
Contributor
There was a problem hiding this comment.
It is relatively expensive for engines to compute stack traces. I wonder if we could change this a bit so we don't create stack traces every time fetch is called but only when we actually need it.
ContributorAuthor
There was a problem hiding this comment.
Ok, passing a boolean whether the fetch/xhr instrumentations are triggered by HttpClient was flaky because of maybeInstrument, so passing the error itself in handler data under virtualError key (not to conflict with other integrations like Breadcrumbs that use error key) and creating the stacks inside HttpClient will hopefully give us a slight performance improvement. a7b89bc
onurtemizkanforce-pushed
the
onur/httpclient-fingerprints
branch
from
November 29, 2024 15:23
c0b864a to
8929cd3Compareonurtemizkanforce-pushed
the
onur/httpclient-fingerprints
branch
from
November 29, 2024 15:57
8929cd3 to
a7b89bcCompareharry-gocity
commented
Dec 13, 2024
thank you! |
3 tasks
mergifyBot
added a commit
to reisene/HulajDusza-serwis
that referenced
this pull request
Jan 23, 2025
 <h3>Snyk has created this PR to upgrade @sentry/profiling-node from 8.43.0 to 8.47.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **5 versions** ahead of your current version. - The recommended version was released **a month ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>@sentry/profiling-node</b></summary> <ul> <li> <b>8.47.0</b> - <a href="https://redirect.github.com/getsentry/sentry-javascript/releases/tag/8.47.0">2024-12-18</a></br><ul> <li>feat(v8/core): Add <code>updateSpanName</code> helper function (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2742710163" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#14736" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14736/hovercard" href="https://redirect.github.com/getsentry/sentry-javascript/pull/14736">#14736</a>)</li> <li>feat(v8/node): Do not overwrite prisma <code>db.system</code> in newer Prisma versions (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2747169540" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#14772" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14772/hovercard" href="https://redirect.github.com/getsentry/sentry-javascript/pull/14772">#14772</a>)</li> <li>feat(v8/node/deps): Bump @ prisma/instrumentation from 5.19.1 to 5.22.0 (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2744850994" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#14755" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14755/hovercard" href="https://redirect.github.com/getsentry/sentry-javascript/pull/14755">#14755</a>)</li> <li>feat(v8/replay): Mask srcdoc iframe contents per default (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2747500508" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#14779" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14779/hovercard" href="https://redirect.github.com/getsentry/sentry-javascript/pull/14779">#14779</a>)</li> <li>ref(v8/nextjs): Fix typo in source maps deletion warning (<a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2747300057" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#14776" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14776/hovercard" href="https://redirect.github.com/getsentry/sentry-javascript/pull/14776">#14776</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/aloisklink/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/aloisklink">@ aloisklink</a> and <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/benjick/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/benjick">@ benjick</a>. Thank you for your contributions!</p> <h2>Bundle size 📦</h2> <table> <thead> <tr> <th>Path</th> <th>Size</th> </tr> </thead> <tbody> <tr> <td>@ sentry/browser</td> <td>23.29 KB</td> </tr> <tr> <td>@ sentry/browser - with treeshaking flags</td> <td>21.96 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing)</td> <td>35.81 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay)</td> <td>73.06 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay) - with treeshaking flags</td> <td>63.45 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay with Canvas)</td> <td>77.37 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay, Feedback)</td> <td>89.85 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Feedback)</td> <td>40.04 KB</td> </tr> <tr> <td>@ sentry/browser (incl. sendFeedback)</td> <td>27.89 KB</td> </tr> <tr> <td>@ sentry/browser (incl. FeedbackAsync)</td> <td>32.68 KB</td> </tr> <tr> <td>@ sentry/react</td> <td>25.96 KB</td> </tr> <tr> <td>@ sentry/react (incl. Tracing)</td> <td>38.64 KB</td> </tr> <tr> <td>@ sentry/vue</td> <td>27.52 KB</td> </tr> <tr> <td>@ sentry/vue (incl. Tracing)</td> <td>37.67 KB</td> </tr> <tr> <td>@ sentry/svelte</td> <td>23.45 KB</td> </tr> <tr> <td>CDN Bundle</td> <td>24.47 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing)</td> <td>37.51 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay)</td> <td>72.71 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback)</td> <td>78.1 KB</td> </tr> <tr> <td>CDN Bundle - uncompressed</td> <td>71.85 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing) - uncompressed</td> <td>111.23 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay) - uncompressed</td> <td>225.3 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed</td> <td>238.52 KB</td> </tr> <tr> <td>@ sentry/nextjs (client)</td> <td>38.9 KB</td> </tr> <tr> <td>@ sentry/sveltekit (client)</td> <td>36.32 KB</td> </tr> <tr> <td>@ sentry/node</td> <td>162.7 KB</td> </tr> <tr> <td>@ sentry/node - without tracing</td> <td>98.87 KB</td> </tr> <tr> <td>@ sentry/aws-serverless</td> <td>126.53 KB</td> </tr> </tbody> </table> </li> <li> <b>8.46.0</b> - <a href="https://redirect.github.com/getsentry/sentry-javascript/releases/tag/8.46.0">2024-12-17</a></br><ul> <li>feat: Allow capture of more than 1 ANR event [v8] (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14713" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14713/hovercard">#14713</a>)</li> <li>feat(node): Detect Railway release name [v8] (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14714" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14714/hovercard">#14714</a>)</li> <li>fix: Normalise ANR debug image file paths if appRoot was supplied [v8] (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14709" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14709/hovercard">#14709</a>)</li> <li>fix(nuxt): Remove build config from tsconfig (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14737" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14737/hovercard">#14737</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/conor-ob/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/conor-ob">@ conor-ob</a>. Thank you for your contribution!</p> <h2>Bundle size 📦</h2> <table> <thead> <tr> <th>Path</th> <th>Size</th> </tr> </thead> <tbody> <tr> <td>@ sentry/browser</td> <td>23.29 KB</td> </tr> <tr> <td>@ sentry/browser - with treeshaking flags</td> <td>21.96 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing)</td> <td>35.79 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay)</td> <td>73.01 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay) - with treeshaking flags</td> <td>63.41 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay with Canvas)</td> <td>77.32 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay, Feedback)</td> <td>89.81 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Feedback)</td> <td>40.04 KB</td> </tr> <tr> <td>@ sentry/browser (incl. sendFeedback)</td> <td>27.89 KB</td> </tr> <tr> <td>@ sentry/browser (incl. FeedbackAsync)</td> <td>32.68 KB</td> </tr> <tr> <td>@ sentry/react</td> <td>25.96 KB</td> </tr> <tr> <td>@ sentry/react (incl. Tracing)</td> <td>38.6 KB</td> </tr> <tr> <td>@ sentry/vue</td> <td>27.49 KB</td> </tr> <tr> <td>@ sentry/vue (incl. Tracing)</td> <td>37.63 KB</td> </tr> <tr> <td>@ sentry/svelte</td> <td>23.45 KB</td> </tr> <tr> <td>CDN Bundle</td> <td>24.43 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing)</td> <td>37.46 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay)</td> <td>72.64 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback)</td> <td>78.01 KB</td> </tr> <tr> <td>CDN Bundle - uncompressed</td> <td>71.74 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing) - uncompressed</td> <td>111.05 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay) - uncompressed</td> <td>225.1 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed</td> <td>238.32 KB</td> </tr> <tr> <td>@ sentry/nextjs (client)</td> <td>38.88 KB</td> </tr> <tr> <td>@ sentry/sveltekit (client)</td> <td>36.29 KB</td> </tr> <tr> <td>@ sentry/node</td> <td>162.53 KB</td> </tr> <tr> <td>@ sentry/node - without tracing</td> <td>98.72 KB</td> </tr> <tr> <td>@ sentry/aws-serverless</td> <td>126.4 KB</td> </tr> </tbody> </table> </li> <li> <b>8.45.1</b> - <a href="https://redirect.github.com/getsentry/sentry-javascript/releases/tag/8.45.1">2024-12-16</a></br><ul> <li>fix(feedback): Return when the <code>sendFeedback</code> promise resolves (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14683" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14683/hovercard">#14683</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/antonis/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/antonis">@ antonis</a>. Thank you for your contribution!</p> <h2>Bundle size 📦</h2> <table> <thead> <tr> <th>Path</th> <th>Size</th> </tr> </thead> <tbody> <tr> <td>@ sentry/browser</td> <td>23.29 KB</td> </tr> <tr> <td>@ sentry/browser - with treeshaking flags</td> <td>21.96 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing)</td> <td>35.79 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay)</td> <td>73.01 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay) - with treeshaking flags</td> <td>63.41 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay with Canvas)</td> <td>77.32 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay, Feedback)</td> <td>89.81 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Feedback)</td> <td>40.04 KB</td> </tr> <tr> <td>@ sentry/browser (incl. sendFeedback)</td> <td>27.89 KB</td> </tr> <tr> <td>@ sentry/browser (incl. FeedbackAsync)</td> <td>32.68 KB</td> </tr> <tr> <td>@ sentry/react</td> <td>25.96 KB</td> </tr> <tr> <td>@ sentry/react (incl. Tracing)</td> <td>38.6 KB</td> </tr> <tr> <td>@ sentry/vue</td> <td>27.49 KB</td> </tr> <tr> <td>@ sentry/vue (incl. Tracing)</td> <td>37.63 KB</td> </tr> <tr> <td>@ sentry/svelte</td> <td>23.45 KB</td> </tr> <tr> <td>CDN Bundle</td> <td>24.43 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing)</td> <td>37.46 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay)</td> <td>72.64 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback)</td> <td>78.01 KB</td> </tr> <tr> <td>CDN Bundle - uncompressed</td> <td>71.74 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing) - uncompressed</td> <td>111.05 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay) - uncompressed</td> <td>225.1 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed</td> <td>238.32 KB</td> </tr> <tr> <td>@ sentry/nextjs (client)</td> <td>38.88 KB</td> </tr> <tr> <td>@ sentry/sveltekit (client)</td> <td>36.29 KB</td> </tr> <tr> <td>@ sentry/node</td> <td>162.52 KB</td> </tr> <tr> <td>@ sentry/node - without tracing</td> <td>98.71 KB</td> </tr> <tr> <td>@ sentry/aws-serverless</td> <td>126.39 KB</td> </tr> </tbody> </table> </li> <li> <b>8.45.0</b> - <a href="https://redirect.github.com/getsentry/sentry-javascript/releases/tag/8.45.0">2024-12-13</a></br><ul> <li>feat(core): Add <code>handled</code> option to <code>captureConsoleIntegration</code> (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14664" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14664/hovercard">#14664</a>)</li> <li>feat(browser): Attach virtual stack traces to <code>HttpClient</code> events (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14515" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14515/hovercard">#14515</a>)</li> <li>feat(replay): Upgrade rrweb packages to 2.31.0 (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14689" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14689/hovercard">#14689</a>)</li> <li>fix(aws-serverless): Remove v8 layer as it overwrites the current layer for docs (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14679" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14679/hovercard">#14679</a>)</li> <li>fix(browser): Mark stack trace from <code>captureMessage</code> with <code>attachStacktrace: true</code> as synthetic (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14668" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14668/hovercard">#14668</a>)</li> <li>fix(core): Mark stack trace from <code>captureMessage</code> with <code>attatchStackTrace: true</code> as synthetic (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14670" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14670/hovercard">#14670</a>)</li> <li>fix(core): Set <code>level</code> in server runtime <code>captureException</code> (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/10587" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/10587/hovercard">#10587</a>)</li> <li>fix(profiling-node): Guard invocation of native profiling methods (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14676" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14676/hovercard">#14676</a>)</li> <li>fix(nuxt): Inline nitro-utils function (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14680" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14680/hovercard">#14680</a>)</li> <li>fix(profiling-node): Ensure profileId is added to transaction event (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14681" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14681/hovercard">#14681</a>)</li> <li>fix(react): Add React Router Descendant Routes support (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14304" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14304/hovercard">#14304</a>)</li> <li>fix: Disable ANR and Local Variables if debugger is enabled via CLI args (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/14643" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/14643/hovercard">#14643</a>)</li> </ul> <p>Work in this release was contributed by <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/anonrig/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/anonrig">@ anonrig</a> and <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/Zih0/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://redirect.github.com/Zih0">@ Zih0</a>. Thank you for your contributions!</p> <h2>Bundle size 📦</h2> <table> <thead> <tr> <th>Path</th> <th>Size</th> </tr> </thead> <tbody> <tr> <td>@ sentry/browser</td> <td>23.29 KB</td> </tr> <tr> <td>@ sentry/browser - with treeshaking flags</td> <td>21.96 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing)</td> <td>35.79 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay)</td> <td>73.01 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay) - with treeshaking flags</td> <td>63.41 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay with Canvas)</td> <td>77.32 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay, Feedback)</td> <td>89.81 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Feedback)</td> <td>40.04 KB</td> </tr> <tr> <td>@ sentry/browser (incl. sendFeedback)</td> <td>27.89 KB</td> </tr> <tr> <td>@ sentry/browser (incl. FeedbackAsync)</td> <td>32.69 KB</td> </tr> <tr> <td>@ sentry/react</td> <td>25.96 KB</td> </tr> <tr> <td>@ sentry/react (incl. Tracing)</td> <td>38.6 KB</td> </tr> <tr> <td>@ sentry/vue</td> <td>27.49 KB</td> </tr> <tr> <td>@ sentry/vue (incl. Tracing)</td> <td>37.63 KB</td> </tr> <tr> <td>@ sentry/svelte</td> <td>23.45 KB</td> </tr> <tr> <td>CDN Bundle</td> <td>24.43 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing)</td> <td>37.46 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay)</td> <td>72.64 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback)</td> <td>78.01 KB</td> </tr> <tr> <td>CDN Bundle - uncompressed</td> <td>71.74 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing) - uncompressed</td> <td>111.05 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay) - uncompressed</td> <td>225.1 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed</td> <td>238.32 KB</td> </tr> <tr> <td>@ sentry/nextjs (client)</td> <td>38.89 KB</td> </tr> <tr> <td>@ sentry/sveltekit (client)</td> <td>36.29 KB</td> </tr> <tr> <td>@ sentry/node</td> <td>162.52 KB</td> </tr> <tr> <td>@ sentry/node - without tracing</td> <td>98.71 KB</td> </tr> <tr> <td>@ sentry/aws-serverless</td> <td>126.38 KB</td> </tr> </tbody> </table> </li> <li> <b>8.44.0</b> - 2024-12-12 </li> <li> <b>8.43.0</b> - 2024-12-10 </li> </ul> from <a href="https://redirect.github.com/getsentry/sentry-javascript/releases">@sentry/profiling-node GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkODM5YmMwYi00ZGY4LTQ5ZTctYjAyZS0wMjJmNTIxYjc2NGYiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImQ4MzliYzBiLTRkZjgtNDllNy1iMDJlLTAyMmY1MjFiNzY0ZiJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/reisene/project/55e114f8-489e-4f14-b900-20574b041e59?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/reisene/project/55e114f8-489e-4f14-b900-20574b041e59/settings/integration?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/reisene/project/55e114f8-489e-4f14-b900-20574b041e59/settings/integration?pkg=@sentry/profiling-node&utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/profiling-node","from":"8.43.0","to":"8.47.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"d839bc0b-4df8-49e7-b02e-022f521b764f","prPublicId":"d839bc0b-4df8-49e7-b02e-022f521b764f","packageManager":"npm","priorityScoreList":[],"projectPublicId":"55e114f8-489e-4f14-b900-20574b041e59","projectUrl":"https://app.snyk.io/org/reisene/project/55e114f8-489e-4f14-b900-20574b041e59?utm_source=github-cloud-app&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":5,"publishedDate":"2024-12-18T16:01:56.517Z"},"vulns":[]}' ## Podsumowanie przez Sourcery Aktualizacja @sentry/profiling-node z wersji 8.43.0 do 8.47.0. <details> <summary>Original summary in English</summary> ## Summary by Sourcery Upgrade @sentry/profiling-node from 8.43.0 to 8.47.0. </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #8353
Updated
fetchandxhrwrappers to pass virtual errors to theHttpClientintegration so we can group the events with the stack traces.It seems we can't create the virtual errors inside the
HttpClientintegration, as we're losing the non-Sentry frames.Sampled fetch event - Link
Sampled XHR event - Link