feat(browser): Add browserSessionIntegration - #14551

Merged
lforst merged 7 commits into
developfrom
lforst-expose-browser-session-integration
Dec 4, 2024
Merged

feat(browser): Add browserSessionIntegration#14551
lforst merged 7 commits into
developfrom
lforst-expose-browser-session-integration

Conversation

@lforst

@lforstlforst commented Dec 3, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Ref: #14550

Adds a browserSessionIntegration that is exported from all browser SDKs which is added when autoSessionTracking: true, and entails the exact same functionality as autoSessionTracking does today.

In v9 this integration will become more fleshed out and completely replace autoSessionTracking in the browser SDKs.

@lforstlforst mentioned this pull request Dec 3, 2024
Closed
4 tasks
@codecov

codecovBot commented Dec 3, 2024•
edited
Loading

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completedFailedPassedSkipped
5371536151
View the top 1 failed tests by shortest run time
public-api/debug/test.tslogsdebugmessagescorrectly
Stack Traces | 0.178s run time
test.ts:7:11logsdebugmessagescorrectly

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@github-actions

github-actionsBot commented Dec 3, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser23.17 KB+0.19%+44 B 🔺
@sentry/browser - with treeshaking flags21.85 KB-0.01%-2 B 🔽
@sentry/browser (incl. Tracing)35.66 KB+0.16%+58 B 🔺
@sentry/browser (incl. Tracing, Replay)72.57 KB+0.13%+96 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.99 KB+0.04%+24 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)76.88 KB+0.11%+82 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)89.36 KB+0.09%+78 B 🔺
@sentry/browser (incl. Feedback)39.93 KB+0.13%+51 B 🔺
@sentry/browser (incl. sendFeedback)27.78 KB+0.15%+41 B 🔺
@sentry/browser (incl. FeedbackAsync)32.57 KB+0.07%+21 B 🔺
@sentry/react25.84 KB+0.13%+34 B 🔺
@sentry/react (incl. Tracing)38.47 KB-0.06%-20 B 🔽
@sentry/vue27.37 KB+0.41%+112 B 🔺
@sentry/vue (incl. Tracing)37.49 KB+0.27%+101 B 🔺
@sentry/svelte23.33 KB+0.27%+64 B 🔺
CDN Bundle24.33 KB+0.04%+8 B 🔺
CDN Bundle (incl. Tracing)37.32 KB+0.05%+16 B 🔺
CDN Bundle (incl. Tracing, Replay)72.19 KB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.53 KB+0.03%+21 B 🔺
CDN Bundle - uncompressed71.5 KB+0.07%+51 B 🔺
CDN Bundle (incl. Tracing) - uncompressed110.78 KB+0.05%+51 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed223.85 KB+0.03%+51 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed237.07 KB+0.03%+51 B 🔺
@sentry/nextjs (client)38.77 KB-0.05%-19 B 🔽
@sentry/sveltekit (client)36.15 KB+0.03%+10 B 🔺
@sentry/node134.83 KB+0.01%+1 B 🔺
@sentry/node - without tracing96.84 KB+0.01%+1 B 🔺
@sentry/aws-serverless109.17 KB-0.01%-1 B 🔽

View base workflow run

@lforst
lforst marked this pull request as ready for review December 3, 2024 11:43
@lforst
lforst requested a review from a team as a code ownerDecember 3, 2024 11:43
mydea
mydea reviewed Dec 3, 2024
View reviewed changes
Comment threadpackages/browser/src/integrations/browsersession.ts
// concept that can be used as a metric.
// Automatically captured sessions are akin to page views, and thus we
// discard their duration.
startSession({ ignoreDuration: true });

@mydeamydeaDec 3, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we adjust the startSession syntax to allow to optionally pass a client directly, and run all of this on setup(client) instead of setupOnce()? 🤔

Then again all of this is kind of global, so maybe this does not help anyhow 🤔

@lforstlforstDec 3, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thoughts. I am actually extremely unsure on how to proceed. It all depends on how we would want sessions to work. If we want there to be multiple at once, it would make sense, however I would err towards the exact opposite.

I think always only having one session active per page makes the most sense. Even in MFEs. I would even go so far to lock down the API down even more in v9, simply because it makes wrapping your head around the concept easier.

All of this is just thinking out loud though. In general I didn't want this PR to be behaviorally significant. That's why I chose this route.

@mydeamydeaDec 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me!

@Lms24Lms24Dec 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's leave it at one "global" session per page.

Lms24
Lms24 approved these changes Dec 4, 2024
View reviewed changes

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment threaddev-packages/browser-integration-tests/suites/replay/captureReplay/test.ts
environment: 'production',
sdk: {
integrations: [
integrations: expect.arrayContaining([

@Lms24Lms24Dec 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: any reason to loosen the assertions?

@lforstlforstDec 4, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally found it to be very annoying that the ordering needed to be exact. Lmk if you want me to change it back.

@Lms24Lms24Dec 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, the ordering is annoying, agreed. Though these tests wouldn't fail additionally added integrations, unless I'm completely missing something. So that opens the test up to more behaviour change than previously. I don't think this is the end of the world but it'd be good to have at least one test that fails if we add a new integration by default. We should be aware of stuff like this.

@lforst
lforst merged commit 7f36772 into developDec 4, 2024
@lforst
lforst deleted the lforst-expose-browser-session-integration branch December 4, 2024 15:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeamydea approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lforst@mydea@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(browser): Add browserSessionIntegration - #14551
Merged
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Dec 4, 2024
Merged
feat(browser): Add browserSessionIntegration#14551
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Conversation
@lforst
@lforstlforst
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Ref: #14550
Adds a browserSessionIntegration that is exported from all browser SDKs which is added when autoSessionTracking: true, and entails the exact same functionality as autoSessionTracking does today.
In v9 this integration will become more fleshed out and completely replace autoSessionTracking in the browser SDKs.
@lforstlforst
mentioned this pull request
Dec 3, 2024

Closed

4 tasks
@codecov
codecovBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
5371536151
View the top 1 failed tests by shortest run time
public-api/debug/test.tslogsdebugmessagescorrectly
Stack Traces | 0.178s run time
test.ts:7:11logsdebugmessagescorrectly
To view more test analytics, go to the Test Analytics Dashboard

📢 Thoughts on this report? Let us know!
@github-actions
github-actionsBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.17 KB+0.19%+44 B 🔺
@sentry/browser - with treeshaking flags21.85 KB-0.01%-2 B 🔽
@sentry/browser (incl. Tracing)35.66 KB+0.16%+58 B 🔺
@sentry/browser (incl. Tracing, Replay)72.57 KB+0.13%+96 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.99 KB+0.04%+24 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)76.88 KB+0.11%+82 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)89.36 KB+0.09%+78 B 🔺
@sentry/browser (incl. Feedback)39.93 KB+0.13%+51 B 🔺
@sentry/browser (incl. sendFeedback)27.78 KB+0.15%+41 B 🔺
@sentry/browser (incl. FeedbackAsync)32.57 KB+0.07%+21 B 🔺
@sentry/react25.84 KB+0.13%+34 B 🔺
@sentry/react (incl. Tracing)38.47 KB-0.06%-20 B 🔽
@sentry/vue27.37 KB+0.41%+112 B 🔺
@sentry/vue (incl. Tracing)37.49 KB+0.27%+101 B 🔺
@sentry/svelte23.33 KB+0.27%+64 B 🔺
CDN Bundle24.33 KB+0.04%+8 B 🔺
CDN Bundle (incl. Tracing)37.32 KB+0.05%+16 B 🔺
CDN Bundle (incl. Tracing, Replay)72.19 KB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.53 KB+0.03%+21 B 🔺
CDN Bundle - uncompressed71.5 KB+0.07%+51 B 🔺
CDN Bundle (incl. Tracing) - uncompressed110.78 KB+0.05%+51 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed223.85 KB+0.03%+51 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed237.07 KB+0.03%+51 B 🔺
@sentry/nextjs (client)38.77 KB-0.05%-19 B 🔽
@sentry/sveltekit (client)36.15 KB+0.03%+10 B 🔺
@sentry/node134.83 KB+0.01%+1 B 🔺
@sentry/node - without tracing96.84 KB+0.01%+1 B 🔺
@sentry/aws-serverless109.17 KB-0.01%-1 B 🔽
View base workflow run
@lforst
lforst
marked this pull request as ready for review
December 3, 2024 11:43
@lforst
lforst
requested a review
from a team
as a code ownerDecember 3, 2024 11:43
mydea
mydea
reviewed
Dec 3, 2024
View reviewed changes
Comment threadpackages/browser/src/integrations/browsersession.ts
 // concept that can be used as a metric.
 // Automatically captured sessions are akin to page views, and thus we
 // discard their duration.
 startSession({ ignoreDuration: true });
@mydeamydeaDec 3, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we adjust the startSession syntax to allow to optionally pass a client directly, and run all of this on setup(client) instead of setupOnce()? 🤔
Then again all of this is kind of global, so maybe this does not help anyhow 🤔
@lforstlforstDec 3, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thoughts. I am actually extremely unsure on how to proceed. It all depends on how we would want sessions to work. If we want there to be multiple at once, it would make sense, however I would err towards the exact opposite.
I think always only having one session active per page makes the most sense. Even in MFEs. I would even go so far to lock down the API down even more in v9, simply because it makes wrapping your head around the concept easier.
All of this is just thinking out loud though. In general I didn't want this PR to be behaviorally significant. That's why I chose this route.
@mydeamydeaDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me!
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's leave it at one "global" session per page.
Lms24
Lms24
approved these changes
Dec 4, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Comment threaddev-packages/browser-integration-tests/suites/replay/captureReplay/test.ts
 environment: 'production',
 sdk: {
 integrations: [
 integrations: expect.arrayContaining([
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: any reason to loosen the assertions?
@lforstlforstDec 4, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally found it to be very annoying that the ordering needed to be exact. Lmk if you want me to change it back.
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, the ordering is annoying, agreed. Though these tests wouldn't fail additionally added integrations, unless I'm completely missing something. So that opens the test up to more behaviour change than previously. I don't think this is the end of the world but it'd be good to have at least one test that fails if we add a new integration by default. We should be aware of stuff like this.
@lforst
lforst
merged commit 7f36772
into
developDec 4, 2024
@lforst
lforst
deleted the

lforst-expose-browser-session-integration

branch
December 4, 2024 15:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeamydea approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lforst@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(browser): Add browserSessionIntegration - #14551
Merged
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Dec 4, 2024
Merged
feat(browser): Add browserSessionIntegration#14551
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Conversation
@lforst
@lforstlforst
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Ref: #14550
Adds a browserSessionIntegration that is exported from all browser SDKs which is added when autoSessionTracking: true, and entails the exact same functionality as autoSessionTracking does today.
In v9 this integration will become more fleshed out and completely replace autoSessionTracking in the browser SDKs.
@lforstlforst
mentioned this pull request
Dec 3, 2024

Closed

4 tasks
@codecov
codecovBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
5371536151
View the top 1 failed tests by shortest run time
public-api/debug/test.tslogsdebugmessagescorrectly
Stack Traces | 0.178s run time
test.ts:7:11logsdebugmessagescorrectly
To view more test analytics, go to the Test Analytics Dashboard

📢 Thoughts on this report? Let us know!
@github-actions
github-actionsBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.17 KB+0.19%+44 B 🔺
@sentry/browser - with treeshaking flags21.85 KB-0.01%-2 B 🔽
@sentry/browser (incl. Tracing)35.66 KB+0.16%+58 B 🔺
@sentry/browser (incl. Tracing, Replay)72.57 KB+0.13%+96 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.99 KB+0.04%+24 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)76.88 KB+0.11%+82 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)89.36 KB+0.09%+78 B 🔺
@sentry/browser (incl. Feedback)39.93 KB+0.13%+51 B 🔺
@sentry/browser (incl. sendFeedback)27.78 KB+0.15%+41 B 🔺
@sentry/browser (incl. FeedbackAsync)32.57 KB+0.07%+21 B 🔺
@sentry/react25.84 KB+0.13%+34 B 🔺
@sentry/react (incl. Tracing)38.47 KB-0.06%-20 B 🔽
@sentry/vue27.37 KB+0.41%+112 B 🔺
@sentry/vue (incl. Tracing)37.49 KB+0.27%+101 B 🔺
@sentry/svelte23.33 KB+0.27%+64 B 🔺
CDN Bundle24.33 KB+0.04%+8 B 🔺
CDN Bundle (incl. Tracing)37.32 KB+0.05%+16 B 🔺
CDN Bundle (incl. Tracing, Replay)72.19 KB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.53 KB+0.03%+21 B 🔺
CDN Bundle - uncompressed71.5 KB+0.07%+51 B 🔺
CDN Bundle (incl. Tracing) - uncompressed110.78 KB+0.05%+51 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed223.85 KB+0.03%+51 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed237.07 KB+0.03%+51 B 🔺
@sentry/nextjs (client)38.77 KB-0.05%-19 B 🔽
@sentry/sveltekit (client)36.15 KB+0.03%+10 B 🔺
@sentry/node134.83 KB+0.01%+1 B 🔺
@sentry/node - without tracing96.84 KB+0.01%+1 B 🔺
@sentry/aws-serverless109.17 KB-0.01%-1 B 🔽
View base workflow run
@lforst
lforst
marked this pull request as ready for review
December 3, 2024 11:43
@lforst
lforst
requested a review
from a team
as a code ownerDecember 3, 2024 11:43
mydea
mydea
reviewed
Dec 3, 2024
View reviewed changes
Comment threadpackages/browser/src/integrations/browsersession.ts
 // concept that can be used as a metric.
 // Automatically captured sessions are akin to page views, and thus we
 // discard their duration.
 startSession({ ignoreDuration: true });
@mydeamydeaDec 3, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we adjust the startSession syntax to allow to optionally pass a client directly, and run all of this on setup(client) instead of setupOnce()? 🤔
Then again all of this is kind of global, so maybe this does not help anyhow 🤔
@lforstlforstDec 3, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thoughts. I am actually extremely unsure on how to proceed. It all depends on how we would want sessions to work. If we want there to be multiple at once, it would make sense, however I would err towards the exact opposite.
I think always only having one session active per page makes the most sense. Even in MFEs. I would even go so far to lock down the API down even more in v9, simply because it makes wrapping your head around the concept easier.
All of this is just thinking out loud though. In general I didn't want this PR to be behaviorally significant. That's why I chose this route.
@mydeamydeaDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me!
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's leave it at one "global" session per page.
Lms24
Lms24
approved these changes
Dec 4, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Comment threaddev-packages/browser-integration-tests/suites/replay/captureReplay/test.ts
 environment: 'production',
 sdk: {
 integrations: [
 integrations: expect.arrayContaining([
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: any reason to loosen the assertions?
@lforstlforstDec 4, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally found it to be very annoying that the ordering needed to be exact. Lmk if you want me to change it back.
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, the ordering is annoying, agreed. Though these tests wouldn't fail additionally added integrations, unless I'm completely missing something. So that opens the test up to more behaviour change than previously. I don't think this is the end of the world but it'd be good to have at least one test that fails if we add a new integration by default. We should be aware of stuff like this.
@lforst
lforst
merged commit 7f36772
into
developDec 4, 2024
@lforst
lforst
deleted the

lforst-expose-browser-session-integration

branch
December 4, 2024 15:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeamydea approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lforst@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(browser): Add browserSessionIntegration - #14551
Merged
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Dec 4, 2024
Merged
feat(browser): Add browserSessionIntegration#14551
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Conversation
@lforst
@lforstlforst
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Ref: #14550
Adds a browserSessionIntegration that is exported from all browser SDKs which is added when autoSessionTracking: true, and entails the exact same functionality as autoSessionTracking does today.
In v9 this integration will become more fleshed out and completely replace autoSessionTracking in the browser SDKs.
@lforstlforst
mentioned this pull request
Dec 3, 2024

Closed

4 tasks
@codecov
codecovBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
5371536151
View the top 1 failed tests by shortest run time
public-api/debug/test.tslogsdebugmessagescorrectly
Stack Traces | 0.178s run time
test.ts:7:11logsdebugmessagescorrectly
To view more test analytics, go to the Test Analytics Dashboard

📢 Thoughts on this report? Let us know!
@github-actions
github-actionsBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.17 KB+0.19%+44 B 🔺
@sentry/browser - with treeshaking flags21.85 KB-0.01%-2 B 🔽
@sentry/browser (incl. Tracing)35.66 KB+0.16%+58 B 🔺
@sentry/browser (incl. Tracing, Replay)72.57 KB+0.13%+96 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.99 KB+0.04%+24 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)76.88 KB+0.11%+82 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)89.36 KB+0.09%+78 B 🔺
@sentry/browser (incl. Feedback)39.93 KB+0.13%+51 B 🔺
@sentry/browser (incl. sendFeedback)27.78 KB+0.15%+41 B 🔺
@sentry/browser (incl. FeedbackAsync)32.57 KB+0.07%+21 B 🔺
@sentry/react25.84 KB+0.13%+34 B 🔺
@sentry/react (incl. Tracing)38.47 KB-0.06%-20 B 🔽
@sentry/vue27.37 KB+0.41%+112 B 🔺
@sentry/vue (incl. Tracing)37.49 KB+0.27%+101 B 🔺
@sentry/svelte23.33 KB+0.27%+64 B 🔺
CDN Bundle24.33 KB+0.04%+8 B 🔺
CDN Bundle (incl. Tracing)37.32 KB+0.05%+16 B 🔺
CDN Bundle (incl. Tracing, Replay)72.19 KB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.53 KB+0.03%+21 B 🔺
CDN Bundle - uncompressed71.5 KB+0.07%+51 B 🔺
CDN Bundle (incl. Tracing) - uncompressed110.78 KB+0.05%+51 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed223.85 KB+0.03%+51 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed237.07 KB+0.03%+51 B 🔺
@sentry/nextjs (client)38.77 KB-0.05%-19 B 🔽
@sentry/sveltekit (client)36.15 KB+0.03%+10 B 🔺
@sentry/node134.83 KB+0.01%+1 B 🔺
@sentry/node - without tracing96.84 KB+0.01%+1 B 🔺
@sentry/aws-serverless109.17 KB-0.01%-1 B 🔽
View base workflow run
@lforst
lforst
marked this pull request as ready for review
December 3, 2024 11:43
@lforst
lforst
requested a review
from a team
as a code ownerDecember 3, 2024 11:43
mydea
mydea
reviewed
Dec 3, 2024
View reviewed changes
Comment threadpackages/browser/src/integrations/browsersession.ts
 // concept that can be used as a metric.
 // Automatically captured sessions are akin to page views, and thus we
 // discard their duration.
 startSession({ ignoreDuration: true });
@mydeamydeaDec 3, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we adjust the startSession syntax to allow to optionally pass a client directly, and run all of this on setup(client) instead of setupOnce()? 🤔
Then again all of this is kind of global, so maybe this does not help anyhow 🤔
@lforstlforstDec 3, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thoughts. I am actually extremely unsure on how to proceed. It all depends on how we would want sessions to work. If we want there to be multiple at once, it would make sense, however I would err towards the exact opposite.
I think always only having one session active per page makes the most sense. Even in MFEs. I would even go so far to lock down the API down even more in v9, simply because it makes wrapping your head around the concept easier.
All of this is just thinking out loud though. In general I didn't want this PR to be behaviorally significant. That's why I chose this route.
@mydeamydeaDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me!
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's leave it at one "global" session per page.
Lms24
Lms24
approved these changes
Dec 4, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Comment threaddev-packages/browser-integration-tests/suites/replay/captureReplay/test.ts
 environment: 'production',
 sdk: {
 integrations: [
 integrations: expect.arrayContaining([
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: any reason to loosen the assertions?
@lforstlforstDec 4, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally found it to be very annoying that the ordering needed to be exact. Lmk if you want me to change it back.
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, the ordering is annoying, agreed. Though these tests wouldn't fail additionally added integrations, unless I'm completely missing something. So that opens the test up to more behaviour change than previously. I don't think this is the end of the world but it'd be good to have at least one test that fails if we add a new integration by default. We should be aware of stuff like this.
@lforst
lforst
merged commit 7f36772
into
developDec 4, 2024
@lforst
lforst
deleted the

lforst-expose-browser-session-integration

branch
December 4, 2024 15:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeamydea approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lforst@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(browser): Add browserSessionIntegration - #14551
Merged
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Dec 4, 2024
Merged
feat(browser): Add browserSessionIntegration#14551
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Conversation
@lforst
@lforstlforst
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Ref: #14550
Adds a browserSessionIntegration that is exported from all browser SDKs which is added when autoSessionTracking: true, and entails the exact same functionality as autoSessionTracking does today.
In v9 this integration will become more fleshed out and completely replace autoSessionTracking in the browser SDKs.
@lforstlforst
mentioned this pull request
Dec 3, 2024

Closed

4 tasks
@codecov
codecovBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
5371536151
View the top 1 failed tests by shortest run time
public-api/debug/test.tslogsdebugmessagescorrectly
Stack Traces | 0.178s run time
test.ts:7:11logsdebugmessagescorrectly
To view more test analytics, go to the Test Analytics Dashboard

📢 Thoughts on this report? Let us know!
@github-actions
github-actionsBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.17 KB+0.19%+44 B 🔺
@sentry/browser - with treeshaking flags21.85 KB-0.01%-2 B 🔽
@sentry/browser (incl. Tracing)35.66 KB+0.16%+58 B 🔺
@sentry/browser (incl. Tracing, Replay)72.57 KB+0.13%+96 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.99 KB+0.04%+24 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)76.88 KB+0.11%+82 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)89.36 KB+0.09%+78 B 🔺
@sentry/browser (incl. Feedback)39.93 KB+0.13%+51 B 🔺
@sentry/browser (incl. sendFeedback)27.78 KB+0.15%+41 B 🔺
@sentry/browser (incl. FeedbackAsync)32.57 KB+0.07%+21 B 🔺
@sentry/react25.84 KB+0.13%+34 B 🔺
@sentry/react (incl. Tracing)38.47 KB-0.06%-20 B 🔽
@sentry/vue27.37 KB+0.41%+112 B 🔺
@sentry/vue (incl. Tracing)37.49 KB+0.27%+101 B 🔺
@sentry/svelte23.33 KB+0.27%+64 B 🔺
CDN Bundle24.33 KB+0.04%+8 B 🔺
CDN Bundle (incl. Tracing)37.32 KB+0.05%+16 B 🔺
CDN Bundle (incl. Tracing, Replay)72.19 KB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.53 KB+0.03%+21 B 🔺
CDN Bundle - uncompressed71.5 KB+0.07%+51 B 🔺
CDN Bundle (incl. Tracing) - uncompressed110.78 KB+0.05%+51 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed223.85 KB+0.03%+51 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed237.07 KB+0.03%+51 B 🔺
@sentry/nextjs (client)38.77 KB-0.05%-19 B 🔽
@sentry/sveltekit (client)36.15 KB+0.03%+10 B 🔺
@sentry/node134.83 KB+0.01%+1 B 🔺
@sentry/node - without tracing96.84 KB+0.01%+1 B 🔺
@sentry/aws-serverless109.17 KB-0.01%-1 B 🔽
View base workflow run
@lforst
lforst
marked this pull request as ready for review
December 3, 2024 11:43
@lforst
lforst
requested a review
from a team
as a code ownerDecember 3, 2024 11:43
mydea
mydea
reviewed
Dec 3, 2024
View reviewed changes
Comment threadpackages/browser/src/integrations/browsersession.ts
 // concept that can be used as a metric.
 // Automatically captured sessions are akin to page views, and thus we
 // discard their duration.
 startSession({ ignoreDuration: true });
@mydeamydeaDec 3, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we adjust the startSession syntax to allow to optionally pass a client directly, and run all of this on setup(client) instead of setupOnce()? 🤔
Then again all of this is kind of global, so maybe this does not help anyhow 🤔
@lforstlforstDec 3, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thoughts. I am actually extremely unsure on how to proceed. It all depends on how we would want sessions to work. If we want there to be multiple at once, it would make sense, however I would err towards the exact opposite.
I think always only having one session active per page makes the most sense. Even in MFEs. I would even go so far to lock down the API down even more in v9, simply because it makes wrapping your head around the concept easier.
All of this is just thinking out loud though. In general I didn't want this PR to be behaviorally significant. That's why I chose this route.
@mydeamydeaDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me!
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's leave it at one "global" session per page.
Lms24
Lms24
approved these changes
Dec 4, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Comment threaddev-packages/browser-integration-tests/suites/replay/captureReplay/test.ts
 environment: 'production',
 sdk: {
 integrations: [
 integrations: expect.arrayContaining([
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: any reason to loosen the assertions?
@lforstlforstDec 4, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally found it to be very annoying that the ordering needed to be exact. Lmk if you want me to change it back.
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, the ordering is annoying, agreed. Though these tests wouldn't fail additionally added integrations, unless I'm completely missing something. So that opens the test up to more behaviour change than previously. I don't think this is the end of the world but it'd be good to have at least one test that fails if we add a new integration by default. We should be aware of stuff like this.
@lforst
lforst
merged commit 7f36772
into
developDec 4, 2024
@lforst
lforst
deleted the

lforst-expose-browser-session-integration

branch
December 4, 2024 15:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeamydea approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lforst@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(browser): Add browserSessionIntegration - #14551
Merged
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Dec 4, 2024
Merged
feat(browser): Add browserSessionIntegration#14551
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Conversation
@lforst
@lforstlforst
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Ref: #14550
Adds a browserSessionIntegration that is exported from all browser SDKs which is added when autoSessionTracking: true, and entails the exact same functionality as autoSessionTracking does today.
In v9 this integration will become more fleshed out and completely replace autoSessionTracking in the browser SDKs.
@lforstlforst
mentioned this pull request
Dec 3, 2024

Closed

4 tasks
@codecov
codecovBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
5371536151
View the top 1 failed tests by shortest run time
public-api/debug/test.tslogsdebugmessagescorrectly
Stack Traces | 0.178s run time
test.ts:7:11logsdebugmessagescorrectly
To view more test analytics, go to the Test Analytics Dashboard

📢 Thoughts on this report? Let us know!
@github-actions
github-actionsBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.17 KB+0.19%+44 B 🔺
@sentry/browser - with treeshaking flags21.85 KB-0.01%-2 B 🔽
@sentry/browser (incl. Tracing)35.66 KB+0.16%+58 B 🔺
@sentry/browser (incl. Tracing, Replay)72.57 KB+0.13%+96 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.99 KB+0.04%+24 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)76.88 KB+0.11%+82 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)89.36 KB+0.09%+78 B 🔺
@sentry/browser (incl. Feedback)39.93 KB+0.13%+51 B 🔺
@sentry/browser (incl. sendFeedback)27.78 KB+0.15%+41 B 🔺
@sentry/browser (incl. FeedbackAsync)32.57 KB+0.07%+21 B 🔺
@sentry/react25.84 KB+0.13%+34 B 🔺
@sentry/react (incl. Tracing)38.47 KB-0.06%-20 B 🔽
@sentry/vue27.37 KB+0.41%+112 B 🔺
@sentry/vue (incl. Tracing)37.49 KB+0.27%+101 B 🔺
@sentry/svelte23.33 KB+0.27%+64 B 🔺
CDN Bundle24.33 KB+0.04%+8 B 🔺
CDN Bundle (incl. Tracing)37.32 KB+0.05%+16 B 🔺
CDN Bundle (incl. Tracing, Replay)72.19 KB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.53 KB+0.03%+21 B 🔺
CDN Bundle - uncompressed71.5 KB+0.07%+51 B 🔺
CDN Bundle (incl. Tracing) - uncompressed110.78 KB+0.05%+51 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed223.85 KB+0.03%+51 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed237.07 KB+0.03%+51 B 🔺
@sentry/nextjs (client)38.77 KB-0.05%-19 B 🔽
@sentry/sveltekit (client)36.15 KB+0.03%+10 B 🔺
@sentry/node134.83 KB+0.01%+1 B 🔺
@sentry/node - without tracing96.84 KB+0.01%+1 B 🔺
@sentry/aws-serverless109.17 KB-0.01%-1 B 🔽
View base workflow run
@lforst
lforst
marked this pull request as ready for review
December 3, 2024 11:43
@lforst
lforst
requested a review
from a team
as a code ownerDecember 3, 2024 11:43
mydea
mydea
reviewed
Dec 3, 2024
View reviewed changes
Comment threadpackages/browser/src/integrations/browsersession.ts
 // concept that can be used as a metric.
 // Automatically captured sessions are akin to page views, and thus we
 // discard their duration.
 startSession({ ignoreDuration: true });
@mydeamydeaDec 3, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we adjust the startSession syntax to allow to optionally pass a client directly, and run all of this on setup(client) instead of setupOnce()? 🤔
Then again all of this is kind of global, so maybe this does not help anyhow 🤔
@lforstlforstDec 3, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thoughts. I am actually extremely unsure on how to proceed. It all depends on how we would want sessions to work. If we want there to be multiple at once, it would make sense, however I would err towards the exact opposite.
I think always only having one session active per page makes the most sense. Even in MFEs. I would even go so far to lock down the API down even more in v9, simply because it makes wrapping your head around the concept easier.
All of this is just thinking out loud though. In general I didn't want this PR to be behaviorally significant. That's why I chose this route.
@mydeamydeaDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me!
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's leave it at one "global" session per page.
Lms24
Lms24
approved these changes
Dec 4, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Comment threaddev-packages/browser-integration-tests/suites/replay/captureReplay/test.ts
 environment: 'production',
 sdk: {
 integrations: [
 integrations: expect.arrayContaining([
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: any reason to loosen the assertions?
@lforstlforstDec 4, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally found it to be very annoying that the ordering needed to be exact. Lmk if you want me to change it back.
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, the ordering is annoying, agreed. Though these tests wouldn't fail additionally added integrations, unless I'm completely missing something. So that opens the test up to more behaviour change than previously. I don't think this is the end of the world but it'd be good to have at least one test that fails if we add a new integration by default. We should be aware of stuff like this.
@lforst
lforst
merged commit 7f36772
into
developDec 4, 2024
@lforst
lforst
deleted the

lforst-expose-browser-session-integration

branch
December 4, 2024 15:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeamydea approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lforst@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(browser): Add browserSessionIntegration - #14551
Merged
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Dec 4, 2024
Merged
feat(browser): Add browserSessionIntegration#14551
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Conversation
@lforst
@lforstlforst
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Ref: #14550
Adds a browserSessionIntegration that is exported from all browser SDKs which is added when autoSessionTracking: true, and entails the exact same functionality as autoSessionTracking does today.
In v9 this integration will become more fleshed out and completely replace autoSessionTracking in the browser SDKs.
@lforstlforst
mentioned this pull request
Dec 3, 2024

Closed

4 tasks
@codecov
codecovBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
5371536151
View the top 1 failed tests by shortest run time
public-api/debug/test.tslogsdebugmessagescorrectly
Stack Traces | 0.178s run time
test.ts:7:11logsdebugmessagescorrectly
To view more test analytics, go to the Test Analytics Dashboard

📢 Thoughts on this report? Let us know!
@github-actions
github-actionsBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.17 KB+0.19%+44 B 🔺
@sentry/browser - with treeshaking flags21.85 KB-0.01%-2 B 🔽
@sentry/browser (incl. Tracing)35.66 KB+0.16%+58 B 🔺
@sentry/browser (incl. Tracing, Replay)72.57 KB+0.13%+96 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.99 KB+0.04%+24 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)76.88 KB+0.11%+82 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)89.36 KB+0.09%+78 B 🔺
@sentry/browser (incl. Feedback)39.93 KB+0.13%+51 B 🔺
@sentry/browser (incl. sendFeedback)27.78 KB+0.15%+41 B 🔺
@sentry/browser (incl. FeedbackAsync)32.57 KB+0.07%+21 B 🔺
@sentry/react25.84 KB+0.13%+34 B 🔺
@sentry/react (incl. Tracing)38.47 KB-0.06%-20 B 🔽
@sentry/vue27.37 KB+0.41%+112 B 🔺
@sentry/vue (incl. Tracing)37.49 KB+0.27%+101 B 🔺
@sentry/svelte23.33 KB+0.27%+64 B 🔺
CDN Bundle24.33 KB+0.04%+8 B 🔺
CDN Bundle (incl. Tracing)37.32 KB+0.05%+16 B 🔺
CDN Bundle (incl. Tracing, Replay)72.19 KB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.53 KB+0.03%+21 B 🔺
CDN Bundle - uncompressed71.5 KB+0.07%+51 B 🔺
CDN Bundle (incl. Tracing) - uncompressed110.78 KB+0.05%+51 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed223.85 KB+0.03%+51 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed237.07 KB+0.03%+51 B 🔺
@sentry/nextjs (client)38.77 KB-0.05%-19 B 🔽
@sentry/sveltekit (client)36.15 KB+0.03%+10 B 🔺
@sentry/node134.83 KB+0.01%+1 B 🔺
@sentry/node - without tracing96.84 KB+0.01%+1 B 🔺
@sentry/aws-serverless109.17 KB-0.01%-1 B 🔽
View base workflow run
@lforst
lforst
marked this pull request as ready for review
December 3, 2024 11:43
@lforst
lforst
requested a review
from a team
as a code ownerDecember 3, 2024 11:43
mydea
mydea
reviewed
Dec 3, 2024
View reviewed changes
Comment threadpackages/browser/src/integrations/browsersession.ts
 // concept that can be used as a metric.
 // Automatically captured sessions are akin to page views, and thus we
 // discard their duration.
 startSession({ ignoreDuration: true });
@mydeamydeaDec 3, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we adjust the startSession syntax to allow to optionally pass a client directly, and run all of this on setup(client) instead of setupOnce()? 🤔
Then again all of this is kind of global, so maybe this does not help anyhow 🤔
@lforstlforstDec 3, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thoughts. I am actually extremely unsure on how to proceed. It all depends on how we would want sessions to work. If we want there to be multiple at once, it would make sense, however I would err towards the exact opposite.
I think always only having one session active per page makes the most sense. Even in MFEs. I would even go so far to lock down the API down even more in v9, simply because it makes wrapping your head around the concept easier.
All of this is just thinking out loud though. In general I didn't want this PR to be behaviorally significant. That's why I chose this route.
@mydeamydeaDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me!
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's leave it at one "global" session per page.
Lms24
Lms24
approved these changes
Dec 4, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Comment threaddev-packages/browser-integration-tests/suites/replay/captureReplay/test.ts
 environment: 'production',
 sdk: {
 integrations: [
 integrations: expect.arrayContaining([
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: any reason to loosen the assertions?
@lforstlforstDec 4, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally found it to be very annoying that the ordering needed to be exact. Lmk if you want me to change it back.
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, the ordering is annoying, agreed. Though these tests wouldn't fail additionally added integrations, unless I'm completely missing something. So that opens the test up to more behaviour change than previously. I don't think this is the end of the world but it'd be good to have at least one test that fails if we add a new integration by default. We should be aware of stuff like this.
@lforst
lforst
merged commit 7f36772
into
developDec 4, 2024
@lforst
lforst
deleted the

lforst-expose-browser-session-integration

branch
December 4, 2024 15:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeamydea approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lforst@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(browser): Add browserSessionIntegration - #14551
Merged
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Dec 4, 2024
Merged
feat(browser): Add browserSessionIntegration#14551
lforst merged 7 commits into
developfrom 
lforst-expose-browser-session-integration
Conversation
@lforst
@lforstlforst
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Ref: #14550
Adds a browserSessionIntegration that is exported from all browser SDKs which is added when autoSessionTracking: true, and entails the exact same functionality as autoSessionTracking does today.
In v9 this integration will become more fleshed out and completely replace autoSessionTracking in the browser SDKs.
@lforstlforst
mentioned this pull request
Dec 3, 2024

Closed

4 tasks
@codecov
codecovBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
5371536151
View the top 1 failed tests by shortest run time
public-api/debug/test.tslogsdebugmessagescorrectly
Stack Traces | 0.178s run time
test.ts:7:11logsdebugmessagescorrectly
To view more test analytics, go to the Test Analytics Dashboard

📢 Thoughts on this report? Let us know!
@github-actions
github-actionsBot
commented
Dec 3, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.17 KB+0.19%+44 B 🔺
@sentry/browser - with treeshaking flags21.85 KB-0.01%-2 B 🔽
@sentry/browser (incl. Tracing)35.66 KB+0.16%+58 B 🔺
@sentry/browser (incl. Tracing, Replay)72.57 KB+0.13%+96 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags62.99 KB+0.04%+24 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)76.88 KB+0.11%+82 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)89.36 KB+0.09%+78 B 🔺
@sentry/browser (incl. Feedback)39.93 KB+0.13%+51 B 🔺
@sentry/browser (incl. sendFeedback)27.78 KB+0.15%+41 B 🔺
@sentry/browser (incl. FeedbackAsync)32.57 KB+0.07%+21 B 🔺
@sentry/react25.84 KB+0.13%+34 B 🔺
@sentry/react (incl. Tracing)38.47 KB-0.06%-20 B 🔽
@sentry/vue27.37 KB+0.41%+112 B 🔺
@sentry/vue (incl. Tracing)37.49 KB+0.27%+101 B 🔺
@sentry/svelte23.33 KB+0.27%+64 B 🔺
CDN Bundle24.33 KB+0.04%+8 B 🔺
CDN Bundle (incl. Tracing)37.32 KB+0.05%+16 B 🔺
CDN Bundle (incl. Tracing, Replay)72.19 KB+0.04%+24 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.53 KB+0.03%+21 B 🔺
CDN Bundle - uncompressed71.5 KB+0.07%+51 B 🔺
CDN Bundle (incl. Tracing) - uncompressed110.78 KB+0.05%+51 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed223.85 KB+0.03%+51 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed237.07 KB+0.03%+51 B 🔺
@sentry/nextjs (client)38.77 KB-0.05%-19 B 🔽
@sentry/sveltekit (client)36.15 KB+0.03%+10 B 🔺
@sentry/node134.83 KB+0.01%+1 B 🔺
@sentry/node - without tracing96.84 KB+0.01%+1 B 🔺
@sentry/aws-serverless109.17 KB-0.01%-1 B 🔽
View base workflow run
@lforst
lforst
marked this pull request as ready for review
December 3, 2024 11:43
@lforst
lforst
requested a review
from a team
as a code ownerDecember 3, 2024 11:43
mydea
mydea
reviewed
Dec 3, 2024
View reviewed changes
Comment threadpackages/browser/src/integrations/browsersession.ts
 // concept that can be used as a metric.
 // Automatically captured sessions are akin to page views, and thus we
 // discard their duration.
 startSession({ ignoreDuration: true });
@mydeamydeaDec 3, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we adjust the startSession syntax to allow to optionally pass a client directly, and run all of this on setup(client) instead of setupOnce()? 🤔
Then again all of this is kind of global, so maybe this does not help anyhow 🤔
@lforstlforstDec 3, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the same thoughts. I am actually extremely unsure on how to proceed. It all depends on how we would want sessions to work. If we want there to be multiple at once, it would make sense, however I would err towards the exact opposite.
I think always only having one session active per page makes the most sense. Even in MFEs. I would even go so far to lock down the API down even more in v9, simply because it makes wrapping your head around the concept easier.
All of this is just thinking out loud though. In general I didn't want this PR to be behaviorally significant. That's why I chose this route.
@mydeamydeaDec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me!
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, let's leave it at one "global" session per page.
Lms24
Lms24
approved these changes
Dec 4, 2024
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Comment threaddev-packages/browser-integration-tests/suites/replay/captureReplay/test.ts
 environment: 'production',
 sdk: {
 integrations: [
 integrations: expect.arrayContaining([
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: any reason to loosen the assertions?
@lforstlforstDec 4, 2024

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally found it to be very annoying that the ordering needed to be exact. Lmk if you want me to change it back.
@Lms24Lms24Dec 4, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah I see, the ordering is annoying, agreed. Though these tests wouldn't fail additionally added integrations, unless I'm completely missing something. So that opens the test up to more behaviour change than previously. I don't think this is the end of the world but it'd be good to have at least one test that fails if we add a new integration by default. We should be aware of stuff like this.
@lforst
lforst
merged commit 7f36772
into
developDec 4, 2024
@lforst
lforst
deleted the

lforst-expose-browser-session-integration

branch
December 4, 2024 15:16
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeamydea approved these changes
@AbhiPrasadAbhiPrasadAwaiting requested review from AbhiPrasad

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@lforst@mydea@Lms24