Uh oh!
There was an error while loading. Please reload this page.
feat(nuxt): Improve serverless event flushing and scope isolation - #14605
Conversation
size-limit report 📦
|
andreiborza
left a comment
There was a problem hiding this comment.
Can we add an e2e test for the isolation scope testing?
| async function flushWithTimeout(): Promise<void> { | ||
| const sentryClient = getClient(); | ||
| const isDebug = sentryClient ? sentryClient.getOptions().debug : false; |
There was a problem hiding this comment.
q: why aren't we using DEBUG_BUILD here?
There was a problem hiding this comment.
Because this is in the runtime folder of the Nuxt module and it's not possible to use it there because it's a different build context :(
| // In environments where we cannot make use of OTel httpInstrumentation, e.g. when just importing the Sentry server config at | ||
| // the top level instead of `--import` or dynamic import like on Vercel, we still need to ensure requests are properly isolated | ||
| const isolationScope = getIsolationScope(); | ||
| const newIsolationScope = isolationScope === getDefaultIsolationScope() ? isolationScope.clone() : isolationScope; |
There was a problem hiding this comment.
maybe let's add a comment here that describes what/why we are doing here:
If otel instrumentation works, this will already be isolated at this point by the SentryHttpInstrumentation. We can identify this by comparing the current isolation scope to the default one. If that is the case, all good, we do not need to do anything. else, we fork the isolation scope here :)
| const isolationScope = getIsolationScope(); | ||
| const newIsolationScope = isolationScope === getDefaultIsolationScope() ? isolationScope.clone() : isolationScope; | ||
| consoleSandbox(() => { |
There was a problem hiding this comment.
no strong feelings, but do we need to always log this, or is logger.log not enough here? 🤔
e77d345 to
790f765Compare
Adds serverless (e.g. Vercel, Netlify) improvements:
waitUntilfor waiting on Sentry events to send before shutting down the function