Skip to content

feat(nextjs)!: Remove experimental_captureRequestError - #14607

Merged
lforst merged 2 commits into
v9from
lforst-rm-exp-cre
Dec 10, 2024
Merged

feat(nextjs)!: Remove experimental_captureRequestError#14607
lforst merged 2 commits into
v9from
lforst-rm-exp-cre

Conversation

@lforst

Copy link
Copy Markdown
Contributor

Fixes#14302

@github-actions

github-actionsBot commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser23.19 KB--
@sentry/browser - with treeshaking flags21.87 KB--
@sentry/browser (incl. Tracing)35.68 KB--
@sentry/browser (incl. Tracing, Replay)72.59 KB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags63.02 KB--
@sentry/browser (incl. Tracing, Replay with Canvas)76.9 KB--
@sentry/browser (incl. Tracing, Replay, Feedback)89.39 KB--
@sentry/browser (incl. Feedback)39.95 KB--
@sentry/browser (incl. sendFeedback)27.81 KB--
@sentry/browser (incl. FeedbackAsync)32.6 KB--
@sentry/react25.87 KB--
@sentry/react (incl. Tracing)38.5 KB--
@sentry/vue27.4 KB--
@sentry/vue (incl. Tracing)37.52 KB--
@sentry/svelte23.36 KB--
CDN Bundle24.36 KB--
CDN Bundle (incl. Tracing)37.34 KB--
CDN Bundle (incl. Tracing, Replay)72.21 KB--
CDN Bundle (incl. Tracing, Replay, Feedback)77.56 KB--
CDN Bundle - uncompressed71.56 KB--
CDN Bundle (incl. Tracing) - uncompressed110.85 KB--
CDN Bundle (incl. Tracing, Replay) - uncompressed223.92 KB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed237.13 KB--
@sentry/nextjs (client)38.79 KB--
@sentry/sveltekit (client)36.18 KB--
@sentry/node162.93 KB--
@sentry/node - without tracing99.81 KB-0.01%-1 B 🔽
@sentry/aws-serverless127.3 KB--

View base workflow run

@kevva

kevva commented Dec 9, 2024

Copy link
Copy Markdown

Can I ask a sort of unrelated question? How is this meant to be used? We're currently using both this and withServerActionInstrumentation but with autoInstrumentMiddleware and autoInstrumentServerFunctions turned off. But since captureRequestError also catches server action errors, doesn't it make withServerActionInstrumentation sort of unneeded? This isn't really documented anywhere so not sure what the benefit is of using one over the other.

@lforst

lforst commented Dec 10, 2024

Copy link
Copy Markdown
ContributorAuthor

@kevvawithServerActionInstrumentation also tracks duration via spans and allows you to track form inputs. You should likely use both.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@lforst@kevva@mydea@AbhiPrasad