test: Skip double installing playwright in E2E tests#14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 4 commits into from
Dec 10, 2024
Merged

test: Skip double installing playwright in E2E tests #14633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ccbc735
test: Skip installing playwright in E2E tests all the time
mydea Dec 10, 2024
556d9d5
reorder & fix...?
mydea Dec 10, 2024
e831674
fix it
mydea Dec 10, 2024
54b5ac4
one more thing
mydea Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/actions/install-playwright/action.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,9 @@ inputs:
browsers:
description: 'What browsers to install.'
default: 'chromium webkit firefox'
cwd:
description: 'The working directory to run Playwright in.'
default: '.'

runs:
using: "composite"
Expand All@@ -12,6 +15,8 @@ runs:
id: playwright-version
run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> $GITHUB_OUTPUT
shell: bash
working-directory: ${{ inputs.cwd }}


- name: Restore cached playwright binaries
uses: actions/cache/restore@v4
Expand All@@ -26,11 +31,13 @@ runs:
run: npx playwright install chromium webkit firefox --with-deps
if: steps.playwright-cache.outputs.cache-hit != 'true'
shell: bash
working-directory: ${{ inputs.cwd }}

- name: Install Playwright system dependencies only (cached)
run: npx playwright install-deps ${{ inputs.browsers || 'chromium webkit firefox' }}
if: steps.playwright-cache.outputs.cache-hit == 'true'
shell: bash
working-directory: ${{ inputs.cwd }}

# Only store cache on develop branch
- name: Store cached playwright binaries
Expand Down
24 changes: 13 additions & 11 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -920,11 +920,6 @@ jobs:
if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
run: yarn build:tarball

- name: Install Playwright
uses: ./.github/actions/install-playwright
with:
browsers: chromium

- name: Get node version
id: versions
run: |
Expand All@@ -945,6 +940,12 @@ jobs:
timeout-minutes: 7
run: pnpm ${{ matrix.build-command || 'test:build' }}

- name: Install Playwright
uses: ./.github/actions/install-playwright
with:
browsers: chromium
cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

- name: Run E2E test
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
timeout-minutes: 10
Expand DownExpand Up@@ -984,7 +985,7 @@ jobs:

# - We skip optional tests on release branches
job_optional_e2e_tests:
name: E2E ${{ matrix.label || matrix.test-application }} Test
name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)

@mydeamydeaDec 10, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also took this opportunity to name this clearer!

# We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
# We need to add the `always()` check here because the previous step has this as well :(
# See: https://github.com/actions/runner/issues/2205
Expand DownExpand Up@@ -1039,11 +1040,6 @@ jobs:
if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
run: yarn build:tarball

- name: Install Playwright
uses: ./.github/actions/install-playwright
with:
browsers: chromium

- name: Get node version
id: versions
run: |
Expand All@@ -1064,6 +1060,12 @@ jobs:
timeout-minutes: 7
run: pnpm ${{ matrix.build-command || 'test:build' }}

- name: Install Playwright
uses: ./.github/actions/install-playwright
with:
browsers: chromium
cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

- name: Run E2E test
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
timeout-minutes: 10
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/angular-17/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
"build": "ng build",
"watch": "ng build --watch --configuration development",
"test": "playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "playwright test",
"clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
},
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/angular-18/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
"build": "ng build",
"watch": "ng build --watch --configuration development",
"test": "playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "playwright test",
"clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
},
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/angular-19/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
"build": "ng build",
"watch": "ng build --watch --configuration development",
"test": "playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "playwright test",
"clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
},
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/astro-4/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
"build": "astro check && astro build",
"preview": "astro preview",
"astro": "astro",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "TEST_ENV=production playwright test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/astro-5/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
"build": "astro build",
"preview": "astro preview",
"astro": "astro",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "TEST_ENV=production playwright test"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/create-next-app/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,8 +7,8 @@
"clean": "npx rimraf node_modules pnpm-lock.yaml .next",
"test:prod": "TEST_ENV=prod playwright test",
"test:dev": "TEST_ENV=dev playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
"test:assert": "pnpm test:prod && pnpm test:dev"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/create-remix-app-express-legacy/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
"start": "cross-env NODE_ENV=production node ./server.mjs",
"typecheck": "tsc",
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm playwright test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
"start": "cross-env NODE_ENV=production node ./server.mjs",
"typecheck": "tsc",
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm playwright test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/create-remix-app-express/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
"start": "cross-env NODE_ENV=production node ./server.mjs",
"typecheck": "tsc",
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm playwright test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
"start": "remix-serve build",
"typecheck": "tsc",
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm playwright test",
"test:assert-sourcemaps": "pnpm upload-sourcemaps"
},
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/create-remix-app-v2-legacy/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
"start": "remix-serve build/index.js",
"typecheck": "tsc",
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm playwright test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/create-remix-app-v2/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
"start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build/index.js",
"typecheck": "tsc",
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm playwright test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/create-remix-app/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
"start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build",
"typecheck": "tsc",
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm playwright test",
"test:assert-sourcemaps": "pnpm upload-sourcemaps"
},
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/default-browser/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
"build": "node build.mjs",
"test": "playwright test",
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm test"
},
"browserslist": {
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/ember-classic/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
"build": "ember build --environment=production",
"start": "ember serve --prod",
"test": "playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
"test:assert": "playwright test",
"clean": "npx rimraf node_modules pnpm-lock.yaml dist"
},
Expand Down
4 changes: 2 additions & 2 deletions dev-packages/e2e-tests/test-applications/ember-embroider/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
"build": "ember build --environment=production",
"start": "ember serve --prod",
"test": "playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
"test:assert": "playwright test",
"clean": "npx rimraf node_modules pnpm-lock.yaml dist"
},
Expand Down
6 changes: 3 additions & 3 deletions dev-packages/e2e-tests/test-applications/nextjs-13/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
"clean": "npx rimraf node_modules pnpm-lock.yaml .next",
"test:prod": "TEST_ENV=production playwright test",
"test:dev": "TEST_ENV=development playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
"test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
"test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
"test:assert": "pnpm test:prod && pnpm test:dev"
},
"dependencies": {
Expand Down
6 changes: 3 additions & 3 deletions dev-packages/e2e-tests/test-applications/nextjs-14/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:prod": "TEST_ENV=production playwright test",
"test:dev": "TEST_ENV=development playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
"test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
"test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
"test:assert": "pnpm test:prod && pnpm test:dev"
},
"dependencies": {
Expand Down
6 changes: 3 additions & 3 deletions dev-packages/e2e-tests/test-applications/nextjs-15/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,10 @@
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:prod": "TEST_ENV=production playwright test",
"test:dev": "TEST_ENV=development playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
"//": "15.0.0-canary.194 is the canary release attached to Next.js RC 1. We need to use the canary version instead of the RC because PPR will not work without. The specific react version is also attached to RC 1.",
"test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && npx playwright install && pnpm build",
"test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && pnpm build",
"test:assert": "pnpm test:prod && pnpm test:dev"
},
"dependencies": {
Expand Down
8 changes: 4 additions & 4 deletions dev-packages/e2e-tests/test-applications/nextjs-app-dir/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,11 +7,11 @@
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:prod": "TEST_ENV=production playwright test",
"test:dev": "TEST_ENV=development playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:test-build": "pnpm ts-node --script-mode assert-build.ts",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
"test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
"test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
"test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
"test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
"test:assert": "pnpm test:test-build && pnpm test:prod && pnpm test:dev"
},
"dependencies": {
Expand Down
6 changes: 3 additions & 3 deletions dev-packages/e2e-tests/test-applications/nextjs-t3/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,9 +8,9 @@
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:prod": "TEST_ENV=production playwright test",
"test:dev": "TEST_ENV=development playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
"test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
"test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
"test:assert": "pnpm test:prod && pnpm test:dev"
},
"dependencies": {
Expand Down
6 changes: 3 additions & 3 deletions dev-packages/e2e-tests/test-applications/nextjs-turbo/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:prod": "TEST_ENV=production playwright test",
"test:dev": "TEST_ENV=development playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && npx playwright install && pnpm build",
"test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && pnpm build",
"test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && pnpm build",
"test:assert": "pnpm test:prod && pnpm test:dev"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/nuxt-3-dynamic-import/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
"start": "node .output/server/index.mjs",
"clean": "npx nuxi cleanup",
"test": "playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/nuxt-3-min/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
"start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
"clean": "npx nuxi cleanup",
"test": "playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/nuxt-3-top-level-import/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
"start": "node .output/server/index.mjs",
"clean": "npx nuxi cleanup",
"test": "playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/nuxt-3/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
"start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
"clean": "npx nuxi cleanup",
"test": "playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm test"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/nuxt-4/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
"start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
"clean": "npx nuxi cleanup",
"test": "playwright test",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm test"
},
"dependencies": {
Expand Down
6 changes: 3 additions & 3 deletions dev-packages/e2e-tests/test-applications/react-17/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@
"start": "serve -s build",
"test": "playwright test",
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
"test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
"test:assert": "pnpm test"
},
"eslintConfig": {
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/e2e-tests/test-applications/react-19/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@
"start": "serve -s build",
"test": "playwright test",
"clean": "npx rimraf node_modules pnpm-lock.yaml",
"test:build": "pnpm install && npx playwright install && pnpm build",
"test:build": "pnpm install && pnpm build",
"test:assert": "pnpm test"
},
"eslintConfig": {
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
test: Skip double installing playwright in E2E tests#14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 4 commits into

from

Dec 10, 2024
 Merged


test: Skip double installing playwright in E2E tests
#14633
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
ccbc735

test: Skip installing playwright in E2E tests all the time


mydea Dec 10, 2024
556d9d5

reorder & fix...?


mydea Dec 10, 2024
e831674

fix it


mydea Dec 10, 2024
54b5ac4

one more thing


mydea Dec 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.github/actions/install-playwright/action.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,9 @@ inputs:
 browsers:
 description: 'What browsers to install.'
 default: 'chromium webkit firefox'
 cwd:
 description: 'The working directory to run Playwright in.'
 default: '.'

runs:
 using: "composite"
Expand All@@ -12,6 +15,8 @@ runs:
 id: playwright-version
 run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> $GITHUB_OUTPUT
 shell: bash
 working-directory: ${{ inputs.cwd }}


 - name: Restore cached playwright binaries
 uses: actions/cache/restore@v4
Expand All@@ -26,11 +31,13 @@ runs:
 run: npx playwright install chromium webkit firefox --with-deps
 if: steps.playwright-cache.outputs.cache-hit != 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 - name: Install Playwright system dependencies only (cached)
 run: npx playwright install-deps ${{ inputs.browsers || 'chromium webkit firefox' }}
 if: steps.playwright-cache.outputs.cache-hit == 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 # Only store cache on develop branch
 - name: Store cached playwright binaries
Expand Down

24 changes: 13 additions & 11 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -920,11 +920,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -945,6 +940,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand DownExpand Up@@ -984,7 +985,7 @@ jobs:

 # - We skip optional tests on release branches
 job_optional_e2e_tests:
 name: E2E ${{ matrix.label || matrix.test-application }} Test
 name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
@mydeamydeaDec 10, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also took this opportunity to name this clearer!
 # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
 # We need to add the `always()` check here because the previous step has this as well :(
 # See: https://github.com/actions/runner/issues/2205
Expand DownExpand Up@@ -1039,11 +1040,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -1064,6 +1060,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-18/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "build": "astro check && astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-5/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "build": "astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/create-next-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,8 +7,8 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=prod playwright test",
 "test:dev": "TEST_ENV=dev playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/default-browser/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "build": "node build.mjs",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "browserslist": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-classic/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-embroider/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-13/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-14/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-15/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,10 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "//": "15.0.0-canary.194 is the canary release attached to Next.js RC 1. We need to use the canary version instead of the RC because PPR will not work without. The specific react version is also attached to RC 1.",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

8 changes: 4 additions & 4 deletions
dev-packages/e2e-tests/test-applications/nextjs-app-dir/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,11 +7,11 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:test-build": "pnpm ts-node --script-mode assert-build.ts",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:test-build && pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-t3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,9 +8,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-turbo/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-dynamic-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-min/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-top-level-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/react-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/react-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: Skip double installing playwright in E2E tests#14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 4 commits into

from

Dec 10, 2024
 Merged


test: Skip double installing playwright in E2E tests
#14633
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
ccbc735

test: Skip installing playwright in E2E tests all the time


mydea Dec 10, 2024
556d9d5

reorder & fix...?


mydea Dec 10, 2024
e831674

fix it


mydea Dec 10, 2024
54b5ac4

one more thing


mydea Dec 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.github/actions/install-playwright/action.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,9 @@ inputs:
 browsers:
 description: 'What browsers to install.'
 default: 'chromium webkit firefox'
 cwd:
 description: 'The working directory to run Playwright in.'
 default: '.'

runs:
 using: "composite"
Expand All@@ -12,6 +15,8 @@ runs:
 id: playwright-version
 run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> $GITHUB_OUTPUT
 shell: bash
 working-directory: ${{ inputs.cwd }}


 - name: Restore cached playwright binaries
 uses: actions/cache/restore@v4
Expand All@@ -26,11 +31,13 @@ runs:
 run: npx playwright install chromium webkit firefox --with-deps
 if: steps.playwright-cache.outputs.cache-hit != 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 - name: Install Playwright system dependencies only (cached)
 run: npx playwright install-deps ${{ inputs.browsers || 'chromium webkit firefox' }}
 if: steps.playwright-cache.outputs.cache-hit == 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 # Only store cache on develop branch
 - name: Store cached playwright binaries
Expand Down

24 changes: 13 additions & 11 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -920,11 +920,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -945,6 +940,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand DownExpand Up@@ -984,7 +985,7 @@ jobs:

 # - We skip optional tests on release branches
 job_optional_e2e_tests:
 name: E2E ${{ matrix.label || matrix.test-application }} Test
 name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
@mydeamydeaDec 10, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also took this opportunity to name this clearer!
 # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
 # We need to add the `always()` check here because the previous step has this as well :(
 # See: https://github.com/actions/runner/issues/2205
Expand DownExpand Up@@ -1039,11 +1040,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -1064,6 +1060,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-18/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "build": "astro check && astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-5/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "build": "astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/create-next-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,8 +7,8 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=prod playwright test",
 "test:dev": "TEST_ENV=dev playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/default-browser/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "build": "node build.mjs",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "browserslist": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-classic/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-embroider/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-13/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-14/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-15/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,10 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "//": "15.0.0-canary.194 is the canary release attached to Next.js RC 1. We need to use the canary version instead of the RC because PPR will not work without. The specific react version is also attached to RC 1.",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

8 changes: 4 additions & 4 deletions
dev-packages/e2e-tests/test-applications/nextjs-app-dir/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,11 +7,11 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:test-build": "pnpm ts-node --script-mode assert-build.ts",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:test-build && pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-t3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,9 +8,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-turbo/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-dynamic-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-min/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-top-level-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/react-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/react-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: Skip double installing playwright in E2E tests#14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 4 commits into

from

Dec 10, 2024
 Merged


test: Skip double installing playwright in E2E tests
#14633
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
ccbc735

test: Skip installing playwright in E2E tests all the time


mydea Dec 10, 2024
556d9d5

reorder & fix...?


mydea Dec 10, 2024
e831674

fix it


mydea Dec 10, 2024
54b5ac4

one more thing


mydea Dec 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.github/actions/install-playwright/action.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,9 @@ inputs:
 browsers:
 description: 'What browsers to install.'
 default: 'chromium webkit firefox'
 cwd:
 description: 'The working directory to run Playwright in.'
 default: '.'

runs:
 using: "composite"
Expand All@@ -12,6 +15,8 @@ runs:
 id: playwright-version
 run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> $GITHUB_OUTPUT
 shell: bash
 working-directory: ${{ inputs.cwd }}


 - name: Restore cached playwright binaries
 uses: actions/cache/restore@v4
Expand All@@ -26,11 +31,13 @@ runs:
 run: npx playwright install chromium webkit firefox --with-deps
 if: steps.playwright-cache.outputs.cache-hit != 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 - name: Install Playwright system dependencies only (cached)
 run: npx playwright install-deps ${{ inputs.browsers || 'chromium webkit firefox' }}
 if: steps.playwright-cache.outputs.cache-hit == 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 # Only store cache on develop branch
 - name: Store cached playwright binaries
Expand Down

24 changes: 13 additions & 11 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -920,11 +920,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -945,6 +940,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand DownExpand Up@@ -984,7 +985,7 @@ jobs:

 # - We skip optional tests on release branches
 job_optional_e2e_tests:
 name: E2E ${{ matrix.label || matrix.test-application }} Test
 name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
@mydeamydeaDec 10, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also took this opportunity to name this clearer!
 # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
 # We need to add the `always()` check here because the previous step has this as well :(
 # See: https://github.com/actions/runner/issues/2205
Expand DownExpand Up@@ -1039,11 +1040,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -1064,6 +1060,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-18/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "build": "astro check && astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-5/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "build": "astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/create-next-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,8 +7,8 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=prod playwright test",
 "test:dev": "TEST_ENV=dev playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/default-browser/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "build": "node build.mjs",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "browserslist": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-classic/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-embroider/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-13/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-14/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-15/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,10 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "//": "15.0.0-canary.194 is the canary release attached to Next.js RC 1. We need to use the canary version instead of the RC because PPR will not work without. The specific react version is also attached to RC 1.",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

8 changes: 4 additions & 4 deletions
dev-packages/e2e-tests/test-applications/nextjs-app-dir/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,11 +7,11 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:test-build": "pnpm ts-node --script-mode assert-build.ts",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:test-build && pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-t3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,9 +8,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-turbo/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-dynamic-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-min/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-top-level-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/react-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/react-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
test: Skip double installing playwright in E2E tests#14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 4 commits into

from

Dec 10, 2024
 Merged


test: Skip double installing playwright in E2E tests
#14633
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
ccbc735

test: Skip installing playwright in E2E tests all the time


mydea Dec 10, 2024
556d9d5

reorder & fix...?


mydea Dec 10, 2024
e831674

fix it


mydea Dec 10, 2024
54b5ac4

one more thing


mydea Dec 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.github/actions/install-playwright/action.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,9 @@ inputs:
 browsers:
 description: 'What browsers to install.'
 default: 'chromium webkit firefox'
 cwd:
 description: 'The working directory to run Playwright in.'
 default: '.'

runs:
 using: "composite"
Expand All@@ -12,6 +15,8 @@ runs:
 id: playwright-version
 run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> $GITHUB_OUTPUT
 shell: bash
 working-directory: ${{ inputs.cwd }}


 - name: Restore cached playwright binaries
 uses: actions/cache/restore@v4
Expand All@@ -26,11 +31,13 @@ runs:
 run: npx playwright install chromium webkit firefox --with-deps
 if: steps.playwright-cache.outputs.cache-hit != 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 - name: Install Playwright system dependencies only (cached)
 run: npx playwright install-deps ${{ inputs.browsers || 'chromium webkit firefox' }}
 if: steps.playwright-cache.outputs.cache-hit == 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 # Only store cache on develop branch
 - name: Store cached playwright binaries
Expand Down

24 changes: 13 additions & 11 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -920,11 +920,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -945,6 +940,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand DownExpand Up@@ -984,7 +985,7 @@ jobs:

 # - We skip optional tests on release branches
 job_optional_e2e_tests:
 name: E2E ${{ matrix.label || matrix.test-application }} Test
 name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
@mydeamydeaDec 10, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also took this opportunity to name this clearer!
 # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
 # We need to add the `always()` check here because the previous step has this as well :(
 # See: https://github.com/actions/runner/issues/2205
Expand DownExpand Up@@ -1039,11 +1040,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -1064,6 +1060,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-18/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "build": "astro check && astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-5/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "build": "astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/create-next-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,8 +7,8 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=prod playwright test",
 "test:dev": "TEST_ENV=dev playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/default-browser/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "build": "node build.mjs",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "browserslist": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-classic/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-embroider/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-13/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-14/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-15/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,10 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "//": "15.0.0-canary.194 is the canary release attached to Next.js RC 1. We need to use the canary version instead of the RC because PPR will not work without. The specific react version is also attached to RC 1.",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

8 changes: 4 additions & 4 deletions
dev-packages/e2e-tests/test-applications/nextjs-app-dir/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,11 +7,11 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:test-build": "pnpm ts-node --script-mode assert-build.ts",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:test-build && pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-t3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,9 +8,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-turbo/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-dynamic-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-min/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-top-level-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/react-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/react-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: Skip double installing playwright in E2E tests#14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 4 commits into

from

Dec 10, 2024
 Merged


test: Skip double installing playwright in E2E tests
#14633
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
ccbc735

test: Skip installing playwright in E2E tests all the time


mydea Dec 10, 2024
556d9d5

reorder & fix...?


mydea Dec 10, 2024
e831674

fix it


mydea Dec 10, 2024
54b5ac4

one more thing


mydea Dec 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.github/actions/install-playwright/action.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,9 @@ inputs:
 browsers:
 description: 'What browsers to install.'
 default: 'chromium webkit firefox'
 cwd:
 description: 'The working directory to run Playwright in.'
 default: '.'

runs:
 using: "composite"
Expand All@@ -12,6 +15,8 @@ runs:
 id: playwright-version
 run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> $GITHUB_OUTPUT
 shell: bash
 working-directory: ${{ inputs.cwd }}


 - name: Restore cached playwright binaries
 uses: actions/cache/restore@v4
Expand All@@ -26,11 +31,13 @@ runs:
 run: npx playwright install chromium webkit firefox --with-deps
 if: steps.playwright-cache.outputs.cache-hit != 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 - name: Install Playwright system dependencies only (cached)
 run: npx playwright install-deps ${{ inputs.browsers || 'chromium webkit firefox' }}
 if: steps.playwright-cache.outputs.cache-hit == 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 # Only store cache on develop branch
 - name: Store cached playwright binaries
Expand Down

24 changes: 13 additions & 11 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -920,11 +920,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -945,6 +940,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand DownExpand Up@@ -984,7 +985,7 @@ jobs:

 # - We skip optional tests on release branches
 job_optional_e2e_tests:
 name: E2E ${{ matrix.label || matrix.test-application }} Test
 name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
@mydeamydeaDec 10, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also took this opportunity to name this clearer!
 # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
 # We need to add the `always()` check here because the previous step has this as well :(
 # See: https://github.com/actions/runner/issues/2205
Expand DownExpand Up@@ -1039,11 +1040,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -1064,6 +1060,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-18/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "build": "astro check && astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-5/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "build": "astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/create-next-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,8 +7,8 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=prod playwright test",
 "test:dev": "TEST_ENV=dev playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/default-browser/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "build": "node build.mjs",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "browserslist": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-classic/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-embroider/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-13/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-14/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-15/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,10 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "//": "15.0.0-canary.194 is the canary release attached to Next.js RC 1. We need to use the canary version instead of the RC because PPR will not work without. The specific react version is also attached to RC 1.",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

8 changes: 4 additions & 4 deletions
dev-packages/e2e-tests/test-applications/nextjs-app-dir/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,11 +7,11 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:test-build": "pnpm ts-node --script-mode assert-build.ts",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:test-build && pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-t3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,9 +8,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-turbo/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-dynamic-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-min/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-top-level-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/react-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/react-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
test: Skip double installing playwright in E2E tests#14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 4 commits into

from

Dec 10, 2024
 Merged


test: Skip double installing playwright in E2E tests
#14633
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
ccbc735

test: Skip installing playwright in E2E tests all the time


mydea Dec 10, 2024
556d9d5

reorder & fix...?


mydea Dec 10, 2024
e831674

fix it


mydea Dec 10, 2024
54b5ac4

one more thing


mydea Dec 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.github/actions/install-playwright/action.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,9 @@ inputs:
 browsers:
 description: 'What browsers to install.'
 default: 'chromium webkit firefox'
 cwd:
 description: 'The working directory to run Playwright in.'
 default: '.'

runs:
 using: "composite"
Expand All@@ -12,6 +15,8 @@ runs:
 id: playwright-version
 run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> $GITHUB_OUTPUT
 shell: bash
 working-directory: ${{ inputs.cwd }}


 - name: Restore cached playwright binaries
 uses: actions/cache/restore@v4
Expand All@@ -26,11 +31,13 @@ runs:
 run: npx playwright install chromium webkit firefox --with-deps
 if: steps.playwright-cache.outputs.cache-hit != 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 - name: Install Playwright system dependencies only (cached)
 run: npx playwright install-deps ${{ inputs.browsers || 'chromium webkit firefox' }}
 if: steps.playwright-cache.outputs.cache-hit == 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 # Only store cache on develop branch
 - name: Store cached playwright binaries
Expand Down

24 changes: 13 additions & 11 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -920,11 +920,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -945,6 +940,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand DownExpand Up@@ -984,7 +985,7 @@ jobs:

 # - We skip optional tests on release branches
 job_optional_e2e_tests:
 name: E2E ${{ matrix.label || matrix.test-application }} Test
 name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
@mydeamydeaDec 10, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also took this opportunity to name this clearer!
 # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
 # We need to add the `always()` check here because the previous step has this as well :(
 # See: https://github.com/actions/runner/issues/2205
Expand DownExpand Up@@ -1039,11 +1040,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -1064,6 +1060,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-18/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "build": "astro check && astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-5/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "build": "astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/create-next-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,8 +7,8 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=prod playwright test",
 "test:dev": "TEST_ENV=dev playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/default-browser/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "build": "node build.mjs",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "browserslist": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-classic/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-embroider/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-13/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-14/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-15/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,10 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "//": "15.0.0-canary.194 is the canary release attached to Next.js RC 1. We need to use the canary version instead of the RC because PPR will not work without. The specific react version is also attached to RC 1.",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

8 changes: 4 additions & 4 deletions
dev-packages/e2e-tests/test-applications/nextjs-app-dir/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,11 +7,11 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:test-build": "pnpm ts-node --script-mode assert-build.ts",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:test-build && pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-t3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,9 +8,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-turbo/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-dynamic-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-min/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-top-level-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/react-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/react-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
test: Skip double installing playwright in E2E tests#14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 4 commits into

from

Dec 10, 2024
 Merged


test: Skip double installing playwright in E2E tests
#14633
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
ccbc735

test: Skip installing playwright in E2E tests all the time


mydea Dec 10, 2024
556d9d5

reorder & fix...?


mydea Dec 10, 2024
e831674

fix it


mydea Dec 10, 2024
54b5ac4

one more thing


mydea Dec 10, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 7 additions & 0 deletions
.github/actions/install-playwright/action.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,9 @@ inputs:
 browsers:
 description: 'What browsers to install.'
 default: 'chromium webkit firefox'
 cwd:
 description: 'The working directory to run Playwright in.'
 default: '.'

runs:
 using: "composite"
Expand All@@ -12,6 +15,8 @@ runs:
 id: playwright-version
 run: echo "version=$(node -p "require('@playwright/test/package.json').version")" >> $GITHUB_OUTPUT
 shell: bash
 working-directory: ${{ inputs.cwd }}


 - name: Restore cached playwright binaries
 uses: actions/cache/restore@v4
Expand All@@ -26,11 +31,13 @@ runs:
 run: npx playwright install chromium webkit firefox --with-deps
 if: steps.playwright-cache.outputs.cache-hit != 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 - name: Install Playwright system dependencies only (cached)
 run: npx playwright install-deps ${{ inputs.browsers || 'chromium webkit firefox' }}
 if: steps.playwright-cache.outputs.cache-hit == 'true'
 shell: bash
 working-directory: ${{ inputs.cwd }}

 # Only store cache on develop branch
 - name: Store cached playwright binaries
Expand Down

24 changes: 13 additions & 11 deletions
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -920,11 +920,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -945,6 +940,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand DownExpand Up@@ -984,7 +985,7 @@ jobs:

 # - We skip optional tests on release branches
 job_optional_e2e_tests:
 name: E2E ${{ matrix.label || matrix.test-application }} Test
 name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
@mydeamydeaDec 10, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also took this opportunity to name this clearer!
 # We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
 # We need to add the `always()` check here because the previous step has this as well :(
 # See: https://github.com/actions/runner/issues/2205
Expand DownExpand Up@@ -1039,11 +1040,6 @@ jobs:
 if: steps.restore-tarball-cache.outputs.cache-hit != 'true'
 run: yarn build:tarball

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium

 - name: Get node version
 id: versions
 run: |
Expand All@@ -1064,6 +1060,12 @@ jobs:
 timeout-minutes: 7
 run: pnpm ${{ matrix.build-command || 'test:build' }}

 - name: Install Playwright
 uses: ./.github/actions/install-playwright
 with:
 browsers: chromium
 cwd: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}

 - name: Run E2E test
 working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
 timeout-minutes: 10
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-18/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/angular-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "build": "ng build",
 "watch": "ng build --watch --configuration development",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf .angular node_modules pnpm-lock.yaml dist"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "build": "astro check && astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/astro-5/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "build": "astro build",
 "preview": "astro preview",
 "astro": "astro",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "TEST_ENV=production playwright test"
 },
 "dependencies": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/create-next-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,8 +7,8 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=prod playwright test",
 "test:dev": "TEST_ENV=dev playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express-vite-dev/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-express/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,7 @@
 "start": "cross-env NODE_ENV=production node ./server.mjs",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2-legacy/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app-v2/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build/index.js",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/create-remix-app/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,7 @@
 "start": "NODE_OPTIONS='--require=./instrument.server.cjs' remix-serve build",
 "typecheck": "tsc",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm playwright test",
 "test:assert-sourcemaps": "pnpm upload-sourcemaps"
 },
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/default-browser/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "build": "node build.mjs",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "browserslist": {
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-classic/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

4 changes: 2 additions & 2 deletions
dev-packages/e2e-tests/test-applications/ember-embroider/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -15,8 +15,8 @@
 "build": "ember build --environment=production",
 "start": "ember serve --prod",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add ember-source@latest && pnpm build",
 "test:assert": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml dist"
 },
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-13/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml .next",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-14/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-15/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,10 +7,10 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "//": "15.0.0-canary.194 is the canary release attached to Next.js RC 1. We need to use the canary version instead of the RC because PPR will not work without. The specific react version is also attached to RC 1.",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@15.0.0-canary.194 && pnpm add react@19.0.0-rc-cd22717c-20241013 && pnpm add react-dom@19.0.0-rc-cd22717c-20241013 && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

8 changes: 4 additions & 4 deletions
dev-packages/e2e-tests/test-applications/nextjs-app-dir/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,11 +7,11 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:test-build": "pnpm ts-node --script-mode assert-build.ts",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && npx playwright install && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm build",
 "test:build-13": "pnpm install && pnpm add next@13.4.19 && pnpm build",
 "test:assert": "pnpm test:test-build && pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-t3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -8,9 +8,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@rc && pnpm add react@beta && pnpm add react-dom@beta && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/nextjs-turbo/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,9 +7,9 @@
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:prod": "TEST_ENV=production playwright test",
 "test:dev": "TEST_ENV=development playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && npx playwright install && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add next@canary && pnpm add react@canary && pnpm add react-dom@canary && pnpm build",
 "test:build-latest": "pnpm install && pnpm add next@latest && pnpm add react@rc && pnpm add react-dom@rc && pnpm build",
 "test:assert": "pnpm test:prod && pnpm test:dev"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-dynamic-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-min/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3-top-level-import/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@
 "start": "node .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-3/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/nuxt-4/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@
 "start:import": "node --import ./.output/server/sentry.server.config.mjs .output/server/index.mjs",
 "clean": "npx nuxi cleanup",
 "test": "playwright test",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "dependencies": {
Expand Down

6 changes: 3 additions & 3 deletions
dev-packages/e2e-tests/test-applications/react-17/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,9 +18,9 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && npx playwright install && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:build-ts3.8": "pnpm install && pnpm add typescript@3.8 && pnpm build",
 "test:build-canary": "pnpm install && pnpm add react@canary react-dom@canary && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down

2 changes: 1 addition & 1 deletion
dev-packages/e2e-tests/test-applications/react-19/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -20,7 +20,7 @@
 "start": "serve -s build",
 "test": "playwright test",
 "clean": "npx rimraf node_modules pnpm-lock.yaml",
 "test:build": "pnpm install && npx playwright install && pnpm build",
 "test:build": "pnpm install && pnpm build",
 "test:assert": "pnpm test"
 },
 "eslintConfig": {
Expand Down
Loading