feat(node/deps): Bump @prisma/instrumentation from 5.19.1 to 5.22.0

[aloisklink]

Bump @prisma/instrumentation from 5.19.1 to 5.22.0.

See https://github.com/prisma/prisma/releases/tag/5.22.0 for release notes.

This is to take advantage of the following change in 5.22.0:

In our ongoing effort to stabilize the tracing Preview feature, we’ve made our spans compliant with OpenTelemetry Semantic Conventions for Database Client Calls. This should lead to better compatibility with tools such as DataDog and Sentry [emphasis added by me].

There's also this change in 5.21.0:

The tracing Preview feature now has full support for MongoDB with previously missing functionality now implemented. This is a part of the ongoing effort to stabilize this Preview feature and release it in General Availability.

The @dependabot PR for @prisma/instrumentation updates this to 6.0.0, which unfortunately drops Node.JS v18 support, so it isn't suitable for Sentry v8: #14624

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • I'm getting a bunch of errors when I run yarn lint && yarn test, but I think they seem to be unrelated to this PR, since this is just a simple dependency update.

[mydea]

thank you, that makes a lot of sense! We'll release this for v8, on the upcoming v9 release we'll probably bump this further to v6.x!

[aloisklink]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

[mydea]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

Ah, thanks for raising this. It's a good question what we expect there 🤔 I'll check in with the team and the folks that work on the performance insights!

[mydea]

Opened a PR here: #14771

[aloisklink]

Bump @prisma/instrumentation from 5.19.1 to 5.22.0.

See https://github.com/prisma/prisma/releases/tag/5.22.0 for release notes.

This is to take advantage of the following change in 5.22.0:

In our ongoing effort to stabilize the tracing Preview feature, we’ve made our spans compliant with OpenTelemetry Semantic Conventions for Database Client Calls. This should lead to better compatibility with tools such as DataDog and Sentry [emphasis added by me].

There's also this change in 5.21.0:

The tracing Preview feature now has full support for MongoDB with previously missing functionality now implemented. This is a part of the ongoing effort to stabilize this Preview feature and release it in General Availability.

The @dependabot PR for @prisma/instrumentation updates this to 6.0.0, which unfortunately drops Node.JS v18 support, so it isn't suitable for Sentry v8: #14624

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • I'm getting a bunch of errors when I run yarn lint && yarn test, but I think they seem to be unrelated to this PR, since this is just a simple dependency update.

[mydea]

thank you, that makes a lot of sense! We'll release this for v8, on the upcoming v9 release we'll probably bump this further to v6.x!

[aloisklink]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

[mydea]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

Ah, thanks for raising this. It's a good question what we expect there 🤔 I'll check in with the team and the folks that work on the performance insights!

[mydea]

Opened a PR here: #14771

[aloisklink]

Bump @prisma/instrumentation from 5.19.1 to 5.22.0.

See https://github.com/prisma/prisma/releases/tag/5.22.0 for release notes.

This is to take advantage of the following change in 5.22.0:

In our ongoing effort to stabilize the tracing Preview feature, we’ve made our spans compliant with OpenTelemetry Semantic Conventions for Database Client Calls. This should lead to better compatibility with tools such as DataDog and Sentry [emphasis added by me].

There's also this change in 5.21.0:

The tracing Preview feature now has full support for MongoDB with previously missing functionality now implemented. This is a part of the ongoing effort to stabilize this Preview feature and release it in General Availability.

The @dependabot PR for @prisma/instrumentation updates this to 6.0.0, which unfortunately drops Node.JS v18 support, so it isn't suitable for Sentry v8: #14624

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • I'm getting a bunch of errors when I run yarn lint && yarn test, but I think they seem to be unrelated to this PR, since this is just a simple dependency update.

[mydea]

thank you, that makes a lot of sense! We'll release this for v8, on the upcoming v9 release we'll probably bump this further to v6.x!

[aloisklink]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

[mydea]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

Ah, thanks for raising this. It's a good question what we expect there 🤔 I'll check in with the team and the folks that work on the performance insights!

[mydea]

Opened a PR here: #14771

[aloisklink]

Bump @prisma/instrumentation from 5.19.1 to 5.22.0.

See https://github.com/prisma/prisma/releases/tag/5.22.0 for release notes.

This is to take advantage of the following change in 5.22.0:

In our ongoing effort to stabilize the tracing Preview feature, we’ve made our spans compliant with OpenTelemetry Semantic Conventions for Database Client Calls. This should lead to better compatibility with tools such as DataDog and Sentry [emphasis added by me].

There's also this change in 5.21.0:

The tracing Preview feature now has full support for MongoDB with previously missing functionality now implemented. This is a part of the ongoing effort to stabilize this Preview feature and release it in General Availability.

The @dependabot PR for @prisma/instrumentation updates this to 6.0.0, which unfortunately drops Node.JS v18 support, so it isn't suitable for Sentry v8: #14624

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • I'm getting a bunch of errors when I run yarn lint && yarn test, but I think they seem to be unrelated to this PR, since this is just a simple dependency update.

[mydea]

thank you, that makes a lot of sense! We'll release this for v8, on the upcoming v9 release we'll probably bump this further to v6.x!

[aloisklink]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

[mydea]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

Ah, thanks for raising this. It's a good question what we expect there 🤔 I'll check in with the team and the folks that work on the performance insights!

[mydea]

Opened a PR here: #14771

[aloisklink]

Bump @prisma/instrumentation from 5.19.1 to 5.22.0.

See https://github.com/prisma/prisma/releases/tag/5.22.0 for release notes.

This is to take advantage of the following change in 5.22.0:

In our ongoing effort to stabilize the tracing Preview feature, we’ve made our spans compliant with OpenTelemetry Semantic Conventions for Database Client Calls. This should lead to better compatibility with tools such as DataDog and Sentry [emphasis added by me].

There's also this change in 5.21.0:

The tracing Preview feature now has full support for MongoDB with previously missing functionality now implemented. This is a part of the ongoing effort to stabilize this Preview feature and release it in General Availability.

The @dependabot PR for @prisma/instrumentation updates this to 6.0.0, which unfortunately drops Node.JS v18 support, so it isn't suitable for Sentry v8: #14624

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • I'm getting a bunch of errors when I run yarn lint && yarn test, but I think they seem to be unrelated to this PR, since this is just a simple dependency update.

[mydea]

thank you, that makes a lot of sense! We'll release this for v8, on the upcoming v9 release we'll probably bump this further to v6.x!

[aloisklink]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

[mydea]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

Ah, thanks for raising this. It's a good question what we expect there 🤔 I'll check in with the team and the folks that work on the performance insights!

[mydea]

Opened a PR here: #14771

[aloisklink]

Bump @prisma/instrumentation from 5.19.1 to 5.22.0.

See https://github.com/prisma/prisma/releases/tag/5.22.0 for release notes.

This is to take advantage of the following change in 5.22.0:

In our ongoing effort to stabilize the tracing Preview feature, we’ve made our spans compliant with OpenTelemetry Semantic Conventions for Database Client Calls. This should lead to better compatibility with tools such as DataDog and Sentry [emphasis added by me].

There's also this change in 5.21.0:

The tracing Preview feature now has full support for MongoDB with previously missing functionality now implemented. This is a part of the ongoing effort to stabilize this Preview feature and release it in General Availability.

The @dependabot PR for @prisma/instrumentation updates this to 6.0.0, which unfortunately drops Node.JS v18 support, so it isn't suitable for Sentry v8: #14624

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • I'm getting a bunch of errors when I run yarn lint && yarn test, but I think they seem to be unrelated to this PR, since this is just a simple dependency update.

[mydea]

thank you, that makes a lot of sense! We'll release this for v8, on the upcoming v9 release we'll probably bump this further to v6.x!

[aloisklink]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

[mydea]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

Ah, thanks for raising this. It's a good question what we expect there 🤔 I'll check in with the team and the folks that work on the performance insights!

[mydea]

Opened a PR here: #14771

[aloisklink]

Bump @prisma/instrumentation from 5.19.1 to 5.22.0.

See https://github.com/prisma/prisma/releases/tag/5.22.0 for release notes.

This is to take advantage of the following change in 5.22.0:

In our ongoing effort to stabilize the tracing Preview feature, we’ve made our spans compliant with OpenTelemetry Semantic Conventions for Database Client Calls. This should lead to better compatibility with tools such as DataDog and Sentry [emphasis added by me].

There's also this change in 5.21.0:

The tracing Preview feature now has full support for MongoDB with previously missing functionality now implemented. This is a part of the ongoing effort to stabilize this Preview feature and release it in General Availability.

The @dependabot PR for @prisma/instrumentation updates this to 6.0.0, which unfortunately drops Node.JS v18 support, so it isn't suitable for Sentry v8: #14624

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • I'm getting a bunch of errors when I run yarn lint && yarn test, but I think they seem to be unrelated to this PR, since this is just a simple dependency update.

[mydea]

thank you, that makes a lot of sense! We'll release this for v8, on the upcoming v9 release we'll probably bump this further to v6.x!

[aloisklink]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

[mydea]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

Ah, thanks for raising this. It's a good question what we expect there 🤔 I'll check in with the team and the folks that work on the performance insights!

[mydea]

Opened a PR here: #14771

[aloisklink]

Bump @prisma/instrumentation from 5.19.1 to 5.22.0.

See https://github.com/prisma/prisma/releases/tag/5.22.0 for release notes.

This is to take advantage of the following change in 5.22.0:

In our ongoing effort to stabilize the tracing Preview feature, we’ve made our spans compliant with OpenTelemetry Semantic Conventions for Database Client Calls. This should lead to better compatibility with tools such as DataDog and Sentry [emphasis added by me].

There's also this change in 5.21.0:

The tracing Preview feature now has full support for MongoDB with previously missing functionality now implemented. This is a part of the ongoing effort to stabilize this Preview feature and release it in General Availability.

The @dependabot PR for @prisma/instrumentation updates this to 6.0.0, which unfortunately drops Node.JS v18 support, so it isn't suitable for Sentry v8: #14624

---

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • I'm getting a bunch of errors when I run yarn lint && yarn test, but I think they seem to be unrelated to this PR, since this is just a simple dependency update.

[mydea]

thank you, that makes a lot of sense! We'll release this for v8, on the upcoming v9 release we'll probably bump this further to v6.x!

[aloisklink]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

[mydea]

One thing I also just noticed!

It looks like @prisma/instrumentation now sets the db.system attribute automatically: prisma/prisma-engines#5019

This means we might be able to delete the following lines of code which seems to be overriding it:

sentry-javascript/packages/node/src/integrations/tracing/prisma.ts

Lines 31 to 34 in ea49d5c

	if(spanJSON.description==='prisma:engine:db_query'){
	span.setAttribute('db.system','prisma');
	}

However, they set the value to the underlying DB, e.g. if you're using Prisma with a sqlite DB, they'll set db.system = "sqlite", so there is a difference in behavior.

Ah, thanks for raising this. It's a good question what we expect there 🤔 I'll check in with the team and the folks that work on the performance insights!

[mydea]

Opened a PR here: #14771