Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 1.8k
feat!: Bump typescript to ~5.0.0#14758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -29,7 +29,7 @@ | ||
| } | ||
| }, | ||
| "typesVersions": { | ||
| "<4.9": { | ||
| "<5.0": { | ||
| "build/types/index.d.ts": [ | ||
| "build/types-ts3.8/index.d.ts" | ||
| ] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -29,7 +29,7 @@ | ||
| } | ||
| }, | ||
| "typesVersions": { | ||
| "<4.9": { | ||
| "<5.0": { | ||
| "build/types/index.d.ts": [ | ||
| "build/types-ts3.8/index.d.ts" | ||
| ] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -29,7 +29,7 @@ | ||
| } | ||
| }, | ||
| "typesVersions": { | ||
| "<4.9": { | ||
| "<5.0": { | ||
| "build/types/index.d.ts": [ | ||
| "build/types-ts3.8/index.d.ts" | ||
| ] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -29,7 +29,7 @@ | ||
| } | ||
| }, | ||
| "typesVersions": { | ||
| "<4.9": { | ||
| "<5.0": { | ||
| "build/types/index.d.ts": [ | ||
| "build/types-ts3.8/index.d.ts" | ||
| ] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -426,7 +426,8 @@ describe('markFunctionWrapped', () => { | ||
| const wrappedFunc = jest.fn(); | ||
| markFunctionWrapped(wrappedFunc, originalFunc); | ||
| expect((wrappedFunc as WrappedFunction).__sentry_original__).toBe(originalFunc); | ||
| // cannot wrap because it is frozen, but we do not error! | ||
MemberAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. huh, why did this test pass before? 😅 some ts bug or so? The new behavior is def. the actual expected behavior! | ||
| expect((wrappedFunc as WrappedFunction).__sentry_original__).toBe(undefined); | ||
| wrappedFunc(); | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this note, not 100% sure if this makes sense? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah that feels reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No hard opinions but personally if a sentence effectively says nothing, which is the case for this one I believe, I would not write it down.