Skip to content

chore(deps): Deduplicate yarn.lock - #14968

Merged
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate
Jan 20, 2025
Merged

chore(deps): Deduplicate yarn.lock#14968
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate

Conversation

@nwalters512

Copy link
Copy Markdown
Contributor

I'm splitting this out of #14967 since it was getting a little out of hand in that other PR.

Tests are currently failing, seemingly related to ampproject/remapping#193. It seems like this may only have been fixed in vitest v2? So that might be a blocker for these changes.

There's another strange failure in the packages/browser test:

 FAIL test/eventbuilder.test.ts > extractMessage > should extract message from a WebAssembly.Exception object
AssertionError: expected 'No error message' to be 'wasm exception' // Object.is equality
- Expected
+ Received
- wasm exception
+ No error message
❯ test/eventbuilder.test.ts:188:21
186| 187| const message = extractMessage(wasmException);
188| expect(message).toBe('wasm exception');
| ^
189| });
190| 

However, this also fails for me on the develop branch, so this may not be related to these changes.

@nwalters512
nwalters512 marked this pull request as ready for review January 13, 2025 16:16
@nwalters512

nwalters512 commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@mydea I'm unable to reproduce the integration test failures (https://github.com/getsentry/sentry-javascript/actions/runs/12751414906/job/35538905465?pr=14968) locally. I'm frankly not sure why integration tests seem to be performing type checking in the first place. Can you offer any guidance here? Maybe this is related to dependency caching in CI? Thanks!

Edit: I see now that it's testing against TS 3.8, and that I need to run node ./scripts/use-ts-3_8.js locally to reproduce this.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

It looks like the type errors are occurring because @types/express-serve-static-core uses modern TypeScript features that aren't supported by TypeScript 3.8, e.g.:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c55a1e4fd5c048683bfd7c55340c78193124d11b/types/express-serve-static-core/index.d.ts#L105

Support for this was only introduced in TypeScript 4.1: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html

This was introduced to those types 4 years ago: DefinitelyTyped/DefinitelyTyped#51262

And as of 2 years ago, TypeScript <=4.0 is no longer supported by DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#62240

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

In 30b8213 I updated the TypeScript 3.8 script to use resolutions in package.json to pin the Express types to older versions, which worked for me locally.

@AbhiPrasad
AbhiPrasad self-requested a review January 14, 2025 04:32
@AbhiPrasad

Copy link
Copy Markdown
Contributor

Marking myself as a reviewer, will take a look ASAP!

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

Because we want to be as a compatible with many users as possible. We said we would support 3.8+ with our 8.x major version, so we need to test to make sure we support it. We often hold support for things much longer than typical LTS for most JS libraries: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king

@AbhiPrasadAbhiPrasad self-assigned this Jan 14, 2025
@nwalters512

Copy link
Copy Markdown
ContributorAuthor

I'm not sure why things are failing after getting up to date with develop 😢 I'll poke at this tomorrow.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

Looks like the failing tests were fixed in #15001.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

If y'all want to check for a maximally-deduped lockfile in CI (I'd strongly advise this), you can add a npx yarn-deduplicate --check step to CI. Let me know if this is desired and I can add it.

Once you're using Yarn v4, this is built in via yarn dedupe/yarn dedupe --check.

AbhiPrasad pushed a commit that referenced this pull request Jan 17, 2025
Backport of #14971 to v8. This is a prerequisite for an eventual
backport of #14968, which will itself will make applying/backporting
#14967 much easier.
I ran `yarn build` and `yarn test` locally. Building succeeded, and all
but 2 test suites passed. The two that failed also failed for me on `v8`
(without any of my changes), so I'm assuming it's something to do with
my environment.
@AbhiPrasad
AbhiPrasad merged commit 82adfbb into getsentry:developJan 20, 2025
@nwalters512
nwalters512 deleted the yarn-deduplicate branch January 21, 2025 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nwalters512@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore(deps): Deduplicate yarn.lock by nwalters512 · Pull Request #14968 · getsentry/sentry-javascript · GitHub
Skip to content

chore(deps): Deduplicate yarn.lock - #14968

Merged
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate
Jan 20, 2025
Merged

chore(deps): Deduplicate yarn.lock#14968
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate

Conversation

@nwalters512

Copy link
Copy Markdown
Contributor

I'm splitting this out of #14967 since it was getting a little out of hand in that other PR.

Tests are currently failing, seemingly related to ampproject/remapping#193. It seems like this may only have been fixed in vitest v2? So that might be a blocker for these changes.

There's another strange failure in the packages/browser test:

 FAIL test/eventbuilder.test.ts > extractMessage > should extract message from a WebAssembly.Exception object
AssertionError: expected 'No error message' to be 'wasm exception' // Object.is equality
- Expected
+ Received
- wasm exception
+ No error message
❯ test/eventbuilder.test.ts:188:21
186| 187| const message = extractMessage(wasmException);
188| expect(message).toBe('wasm exception');
| ^
189| });
190| 

However, this also fails for me on the develop branch, so this may not be related to these changes.

@nwalters512
nwalters512 marked this pull request as ready for review January 13, 2025 16:16
@nwalters512

nwalters512 commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@mydea I'm unable to reproduce the integration test failures (https://github.com/getsentry/sentry-javascript/actions/runs/12751414906/job/35538905465?pr=14968) locally. I'm frankly not sure why integration tests seem to be performing type checking in the first place. Can you offer any guidance here? Maybe this is related to dependency caching in CI? Thanks!

Edit: I see now that it's testing against TS 3.8, and that I need to run node ./scripts/use-ts-3_8.js locally to reproduce this.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

It looks like the type errors are occurring because @types/express-serve-static-core uses modern TypeScript features that aren't supported by TypeScript 3.8, e.g.:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c55a1e4fd5c048683bfd7c55340c78193124d11b/types/express-serve-static-core/index.d.ts#L105

Support for this was only introduced in TypeScript 4.1: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html

This was introduced to those types 4 years ago: DefinitelyTyped/DefinitelyTyped#51262

And as of 2 years ago, TypeScript <=4.0 is no longer supported by DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#62240

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

In 30b8213 I updated the TypeScript 3.8 script to use resolutions in package.json to pin the Express types to older versions, which worked for me locally.

@AbhiPrasad
AbhiPrasad self-requested a review January 14, 2025 04:32
@AbhiPrasad

Copy link
Copy Markdown
Contributor

Marking myself as a reviewer, will take a look ASAP!

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

Because we want to be as a compatible with many users as possible. We said we would support 3.8+ with our 8.x major version, so we need to test to make sure we support it. We often hold support for things much longer than typical LTS for most JS libraries: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king

@AbhiPrasadAbhiPrasad self-assigned this Jan 14, 2025
@nwalters512

Copy link
Copy Markdown
ContributorAuthor

I'm not sure why things are failing after getting up to date with develop 😢 I'll poke at this tomorrow.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

Looks like the failing tests were fixed in #15001.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

If y'all want to check for a maximally-deduped lockfile in CI (I'd strongly advise this), you can add a npx yarn-deduplicate --check step to CI. Let me know if this is desired and I can add it.

Once you're using Yarn v4, this is built in via yarn dedupe/yarn dedupe --check.

AbhiPrasad pushed a commit that referenced this pull request Jan 17, 2025
Backport of #14971 to v8. This is a prerequisite for an eventual
backport of #14968, which will itself will make applying/backporting
#14967 much easier.
I ran `yarn build` and `yarn test` locally. Building succeeded, and all
but 2 test suites passed. The two that failed also failed for me on `v8`
(without any of my changes), so I'm assuming it's something to do with
my environment.
@AbhiPrasad
AbhiPrasad merged commit 82adfbb into getsentry:developJan 20, 2025
@nwalters512
nwalters512 deleted the yarn-deduplicate branch January 21, 2025 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nwalters512@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(deps): Deduplicate yarn.lock by nwalters512 · Pull Request #14968 · getsentry/sentry-javascript · GitHub
Skip to content

chore(deps): Deduplicate yarn.lock - #14968

Merged
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate
Jan 20, 2025
Merged

chore(deps): Deduplicate yarn.lock#14968
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate

Conversation

@nwalters512

Copy link
Copy Markdown
Contributor

I'm splitting this out of #14967 since it was getting a little out of hand in that other PR.

Tests are currently failing, seemingly related to ampproject/remapping#193. It seems like this may only have been fixed in vitest v2? So that might be a blocker for these changes.

There's another strange failure in the packages/browser test:

 FAIL test/eventbuilder.test.ts > extractMessage > should extract message from a WebAssembly.Exception object
AssertionError: expected 'No error message' to be 'wasm exception' // Object.is equality
- Expected
+ Received
- wasm exception
+ No error message
❯ test/eventbuilder.test.ts:188:21
186| 187| const message = extractMessage(wasmException);
188| expect(message).toBe('wasm exception');
| ^
189| });
190| 

However, this also fails for me on the develop branch, so this may not be related to these changes.

@nwalters512
nwalters512 marked this pull request as ready for review January 13, 2025 16:16
@nwalters512

nwalters512 commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@mydea I'm unable to reproduce the integration test failures (https://github.com/getsentry/sentry-javascript/actions/runs/12751414906/job/35538905465?pr=14968) locally. I'm frankly not sure why integration tests seem to be performing type checking in the first place. Can you offer any guidance here? Maybe this is related to dependency caching in CI? Thanks!

Edit: I see now that it's testing against TS 3.8, and that I need to run node ./scripts/use-ts-3_8.js locally to reproduce this.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

It looks like the type errors are occurring because @types/express-serve-static-core uses modern TypeScript features that aren't supported by TypeScript 3.8, e.g.:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c55a1e4fd5c048683bfd7c55340c78193124d11b/types/express-serve-static-core/index.d.ts#L105

Support for this was only introduced in TypeScript 4.1: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html

This was introduced to those types 4 years ago: DefinitelyTyped/DefinitelyTyped#51262

And as of 2 years ago, TypeScript <=4.0 is no longer supported by DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#62240

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

In 30b8213 I updated the TypeScript 3.8 script to use resolutions in package.json to pin the Express types to older versions, which worked for me locally.

@AbhiPrasad
AbhiPrasad self-requested a review January 14, 2025 04:32
@AbhiPrasad

Copy link
Copy Markdown
Contributor

Marking myself as a reviewer, will take a look ASAP!

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

Because we want to be as a compatible with many users as possible. We said we would support 3.8+ with our 8.x major version, so we need to test to make sure we support it. We often hold support for things much longer than typical LTS for most JS libraries: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king

@AbhiPrasadAbhiPrasad self-assigned this Jan 14, 2025
@nwalters512

Copy link
Copy Markdown
ContributorAuthor

I'm not sure why things are failing after getting up to date with develop 😢 I'll poke at this tomorrow.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

Looks like the failing tests were fixed in #15001.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

If y'all want to check for a maximally-deduped lockfile in CI (I'd strongly advise this), you can add a npx yarn-deduplicate --check step to CI. Let me know if this is desired and I can add it.

Once you're using Yarn v4, this is built in via yarn dedupe/yarn dedupe --check.

AbhiPrasad pushed a commit that referenced this pull request Jan 17, 2025
Backport of #14971 to v8. This is a prerequisite for an eventual
backport of #14968, which will itself will make applying/backporting
#14967 much easier.
I ran `yarn build` and `yarn test` locally. Building succeeded, and all
but 2 test suites passed. The two that failed also failed for me on `v8`
(without any of my changes), so I'm assuming it's something to do with
my environment.
@AbhiPrasad
AbhiPrasad merged commit 82adfbb into getsentry:developJan 20, 2025
@nwalters512
nwalters512 deleted the yarn-deduplicate branch January 21, 2025 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nwalters512@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(deps): Deduplicate yarn.lock by nwalters512 · Pull Request #14968 · getsentry/sentry-javascript · GitHub
Skip to content

chore(deps): Deduplicate yarn.lock - #14968

Merged
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate
Jan 20, 2025
Merged

chore(deps): Deduplicate yarn.lock#14968
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate

Conversation

@nwalters512

Copy link
Copy Markdown
Contributor

I'm splitting this out of #14967 since it was getting a little out of hand in that other PR.

Tests are currently failing, seemingly related to ampproject/remapping#193. It seems like this may only have been fixed in vitest v2? So that might be a blocker for these changes.

There's another strange failure in the packages/browser test:

 FAIL test/eventbuilder.test.ts > extractMessage > should extract message from a WebAssembly.Exception object
AssertionError: expected 'No error message' to be 'wasm exception' // Object.is equality
- Expected
+ Received
- wasm exception
+ No error message
❯ test/eventbuilder.test.ts:188:21
186| 187| const message = extractMessage(wasmException);
188| expect(message).toBe('wasm exception');
| ^
189| });
190| 

However, this also fails for me on the develop branch, so this may not be related to these changes.

@nwalters512
nwalters512 marked this pull request as ready for review January 13, 2025 16:16
@nwalters512

nwalters512 commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@mydea I'm unable to reproduce the integration test failures (https://github.com/getsentry/sentry-javascript/actions/runs/12751414906/job/35538905465?pr=14968) locally. I'm frankly not sure why integration tests seem to be performing type checking in the first place. Can you offer any guidance here? Maybe this is related to dependency caching in CI? Thanks!

Edit: I see now that it's testing against TS 3.8, and that I need to run node ./scripts/use-ts-3_8.js locally to reproduce this.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

It looks like the type errors are occurring because @types/express-serve-static-core uses modern TypeScript features that aren't supported by TypeScript 3.8, e.g.:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c55a1e4fd5c048683bfd7c55340c78193124d11b/types/express-serve-static-core/index.d.ts#L105

Support for this was only introduced in TypeScript 4.1: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html

This was introduced to those types 4 years ago: DefinitelyTyped/DefinitelyTyped#51262

And as of 2 years ago, TypeScript <=4.0 is no longer supported by DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#62240

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

In 30b8213 I updated the TypeScript 3.8 script to use resolutions in package.json to pin the Express types to older versions, which worked for me locally.

@AbhiPrasad
AbhiPrasad self-requested a review January 14, 2025 04:32
@AbhiPrasad

Copy link
Copy Markdown
Contributor

Marking myself as a reviewer, will take a look ASAP!

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

Because we want to be as a compatible with many users as possible. We said we would support 3.8+ with our 8.x major version, so we need to test to make sure we support it. We often hold support for things much longer than typical LTS for most JS libraries: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king

@AbhiPrasadAbhiPrasad self-assigned this Jan 14, 2025
@nwalters512

Copy link
Copy Markdown
ContributorAuthor

I'm not sure why things are failing after getting up to date with develop 😢 I'll poke at this tomorrow.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

Looks like the failing tests were fixed in #15001.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

If y'all want to check for a maximally-deduped lockfile in CI (I'd strongly advise this), you can add a npx yarn-deduplicate --check step to CI. Let me know if this is desired and I can add it.

Once you're using Yarn v4, this is built in via yarn dedupe/yarn dedupe --check.

AbhiPrasad pushed a commit that referenced this pull request Jan 17, 2025
Backport of #14971 to v8. This is a prerequisite for an eventual
backport of #14968, which will itself will make applying/backporting
#14967 much easier.
I ran `yarn build` and `yarn test` locally. Building succeeded, and all
but 2 test suites passed. The two that failed also failed for me on `v8`
(without any of my changes), so I'm assuming it's something to do with
my environment.
@AbhiPrasad
AbhiPrasad merged commit 82adfbb into getsentry:developJan 20, 2025
@nwalters512
nwalters512 deleted the yarn-deduplicate branch January 21, 2025 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nwalters512@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' chore(deps): Deduplicate yarn.lock by nwalters512 · Pull Request #14968 · getsentry/sentry-javascript · GitHub
Skip to content

chore(deps): Deduplicate yarn.lock - #14968

Merged
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate
Jan 20, 2025
Merged

chore(deps): Deduplicate yarn.lock#14968
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate

Conversation

@nwalters512

Copy link
Copy Markdown
Contributor

I'm splitting this out of #14967 since it was getting a little out of hand in that other PR.

Tests are currently failing, seemingly related to ampproject/remapping#193. It seems like this may only have been fixed in vitest v2? So that might be a blocker for these changes.

There's another strange failure in the packages/browser test:

 FAIL test/eventbuilder.test.ts > extractMessage > should extract message from a WebAssembly.Exception object
AssertionError: expected 'No error message' to be 'wasm exception' // Object.is equality
- Expected
+ Received
- wasm exception
+ No error message
❯ test/eventbuilder.test.ts:188:21
186| 187| const message = extractMessage(wasmException);
188| expect(message).toBe('wasm exception');
| ^
189| });
190| 

However, this also fails for me on the develop branch, so this may not be related to these changes.

@nwalters512
nwalters512 marked this pull request as ready for review January 13, 2025 16:16
@nwalters512

nwalters512 commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@mydea I'm unable to reproduce the integration test failures (https://github.com/getsentry/sentry-javascript/actions/runs/12751414906/job/35538905465?pr=14968) locally. I'm frankly not sure why integration tests seem to be performing type checking in the first place. Can you offer any guidance here? Maybe this is related to dependency caching in CI? Thanks!

Edit: I see now that it's testing against TS 3.8, and that I need to run node ./scripts/use-ts-3_8.js locally to reproduce this.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

It looks like the type errors are occurring because @types/express-serve-static-core uses modern TypeScript features that aren't supported by TypeScript 3.8, e.g.:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c55a1e4fd5c048683bfd7c55340c78193124d11b/types/express-serve-static-core/index.d.ts#L105

Support for this was only introduced in TypeScript 4.1: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html

This was introduced to those types 4 years ago: DefinitelyTyped/DefinitelyTyped#51262

And as of 2 years ago, TypeScript <=4.0 is no longer supported by DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#62240

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

In 30b8213 I updated the TypeScript 3.8 script to use resolutions in package.json to pin the Express types to older versions, which worked for me locally.

@AbhiPrasad
AbhiPrasad self-requested a review January 14, 2025 04:32
@AbhiPrasad

Copy link
Copy Markdown
Contributor

Marking myself as a reviewer, will take a look ASAP!

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

Because we want to be as a compatible with many users as possible. We said we would support 3.8+ with our 8.x major version, so we need to test to make sure we support it. We often hold support for things much longer than typical LTS for most JS libraries: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king

@AbhiPrasadAbhiPrasad self-assigned this Jan 14, 2025
@nwalters512

Copy link
Copy Markdown
ContributorAuthor

I'm not sure why things are failing after getting up to date with develop 😢 I'll poke at this tomorrow.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

Looks like the failing tests were fixed in #15001.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

If y'all want to check for a maximally-deduped lockfile in CI (I'd strongly advise this), you can add a npx yarn-deduplicate --check step to CI. Let me know if this is desired and I can add it.

Once you're using Yarn v4, this is built in via yarn dedupe/yarn dedupe --check.

AbhiPrasad pushed a commit that referenced this pull request Jan 17, 2025
Backport of #14971 to v8. This is a prerequisite for an eventual
backport of #14968, which will itself will make applying/backporting
#14967 much easier.
I ran `yarn build` and `yarn test` locally. Building succeeded, and all
but 2 test suites passed. The two that failed also failed for me on `v8`
(without any of my changes), so I'm assuming it's something to do with
my environment.
@AbhiPrasad
AbhiPrasad merged commit 82adfbb into getsentry:developJan 20, 2025
@nwalters512
nwalters512 deleted the yarn-deduplicate branch January 21, 2025 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nwalters512@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(deps): Deduplicate yarn.lock by nwalters512 · Pull Request #14968 · getsentry/sentry-javascript · GitHub
Skip to content

chore(deps): Deduplicate yarn.lock - #14968

Merged
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate
Jan 20, 2025
Merged

chore(deps): Deduplicate yarn.lock#14968
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate

Conversation

@nwalters512

Copy link
Copy Markdown
Contributor

I'm splitting this out of #14967 since it was getting a little out of hand in that other PR.

Tests are currently failing, seemingly related to ampproject/remapping#193. It seems like this may only have been fixed in vitest v2? So that might be a blocker for these changes.

There's another strange failure in the packages/browser test:

 FAIL test/eventbuilder.test.ts > extractMessage > should extract message from a WebAssembly.Exception object
AssertionError: expected 'No error message' to be 'wasm exception' // Object.is equality
- Expected
+ Received
- wasm exception
+ No error message
❯ test/eventbuilder.test.ts:188:21
186| 187| const message = extractMessage(wasmException);
188| expect(message).toBe('wasm exception');
| ^
189| });
190| 

However, this also fails for me on the develop branch, so this may not be related to these changes.

@nwalters512
nwalters512 marked this pull request as ready for review January 13, 2025 16:16
@nwalters512

nwalters512 commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@mydea I'm unable to reproduce the integration test failures (https://github.com/getsentry/sentry-javascript/actions/runs/12751414906/job/35538905465?pr=14968) locally. I'm frankly not sure why integration tests seem to be performing type checking in the first place. Can you offer any guidance here? Maybe this is related to dependency caching in CI? Thanks!

Edit: I see now that it's testing against TS 3.8, and that I need to run node ./scripts/use-ts-3_8.js locally to reproduce this.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

It looks like the type errors are occurring because @types/express-serve-static-core uses modern TypeScript features that aren't supported by TypeScript 3.8, e.g.:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c55a1e4fd5c048683bfd7c55340c78193124d11b/types/express-serve-static-core/index.d.ts#L105

Support for this was only introduced in TypeScript 4.1: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html

This was introduced to those types 4 years ago: DefinitelyTyped/DefinitelyTyped#51262

And as of 2 years ago, TypeScript <=4.0 is no longer supported by DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#62240

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

In 30b8213 I updated the TypeScript 3.8 script to use resolutions in package.json to pin the Express types to older versions, which worked for me locally.

@AbhiPrasad
AbhiPrasad self-requested a review January 14, 2025 04:32
@AbhiPrasad

Copy link
Copy Markdown
Contributor

Marking myself as a reviewer, will take a look ASAP!

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

Because we want to be as a compatible with many users as possible. We said we would support 3.8+ with our 8.x major version, so we need to test to make sure we support it. We often hold support for things much longer than typical LTS for most JS libraries: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king

@AbhiPrasadAbhiPrasad self-assigned this Jan 14, 2025
@nwalters512

Copy link
Copy Markdown
ContributorAuthor

I'm not sure why things are failing after getting up to date with develop 😢 I'll poke at this tomorrow.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

Looks like the failing tests were fixed in #15001.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

If y'all want to check for a maximally-deduped lockfile in CI (I'd strongly advise this), you can add a npx yarn-deduplicate --check step to CI. Let me know if this is desired and I can add it.

Once you're using Yarn v4, this is built in via yarn dedupe/yarn dedupe --check.

AbhiPrasad pushed a commit that referenced this pull request Jan 17, 2025
Backport of #14971 to v8. This is a prerequisite for an eventual
backport of #14968, which will itself will make applying/backporting
#14967 much easier.
I ran `yarn build` and `yarn test` locally. Building succeeded, and all
but 2 test suites passed. The two that failed also failed for me on `v8`
(without any of my changes), so I'm assuming it's something to do with
my environment.
@AbhiPrasad
AbhiPrasad merged commit 82adfbb into getsentry:developJan 20, 2025
@nwalters512
nwalters512 deleted the yarn-deduplicate branch January 21, 2025 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nwalters512@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(deps): Deduplicate yarn.lock by nwalters512 · Pull Request #14968 · getsentry/sentry-javascript · GitHub
Skip to content

chore(deps): Deduplicate yarn.lock - #14968

Merged
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate
Jan 20, 2025
Merged

chore(deps): Deduplicate yarn.lock#14968
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate

Conversation

@nwalters512

Copy link
Copy Markdown
Contributor

I'm splitting this out of #14967 since it was getting a little out of hand in that other PR.

Tests are currently failing, seemingly related to ampproject/remapping#193. It seems like this may only have been fixed in vitest v2? So that might be a blocker for these changes.

There's another strange failure in the packages/browser test:

 FAIL test/eventbuilder.test.ts > extractMessage > should extract message from a WebAssembly.Exception object
AssertionError: expected 'No error message' to be 'wasm exception' // Object.is equality
- Expected
+ Received
- wasm exception
+ No error message
❯ test/eventbuilder.test.ts:188:21
186| 187| const message = extractMessage(wasmException);
188| expect(message).toBe('wasm exception');
| ^
189| });
190| 

However, this also fails for me on the develop branch, so this may not be related to these changes.

@nwalters512
nwalters512 marked this pull request as ready for review January 13, 2025 16:16
@nwalters512

nwalters512 commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@mydea I'm unable to reproduce the integration test failures (https://github.com/getsentry/sentry-javascript/actions/runs/12751414906/job/35538905465?pr=14968) locally. I'm frankly not sure why integration tests seem to be performing type checking in the first place. Can you offer any guidance here? Maybe this is related to dependency caching in CI? Thanks!

Edit: I see now that it's testing against TS 3.8, and that I need to run node ./scripts/use-ts-3_8.js locally to reproduce this.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

It looks like the type errors are occurring because @types/express-serve-static-core uses modern TypeScript features that aren't supported by TypeScript 3.8, e.g.:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c55a1e4fd5c048683bfd7c55340c78193124d11b/types/express-serve-static-core/index.d.ts#L105

Support for this was only introduced in TypeScript 4.1: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html

This was introduced to those types 4 years ago: DefinitelyTyped/DefinitelyTyped#51262

And as of 2 years ago, TypeScript <=4.0 is no longer supported by DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#62240

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

In 30b8213 I updated the TypeScript 3.8 script to use resolutions in package.json to pin the Express types to older versions, which worked for me locally.

@AbhiPrasad
AbhiPrasad self-requested a review January 14, 2025 04:32
@AbhiPrasad

Copy link
Copy Markdown
Contributor

Marking myself as a reviewer, will take a look ASAP!

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

Because we want to be as a compatible with many users as possible. We said we would support 3.8+ with our 8.x major version, so we need to test to make sure we support it. We often hold support for things much longer than typical LTS for most JS libraries: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king

@AbhiPrasadAbhiPrasad self-assigned this Jan 14, 2025
@nwalters512

Copy link
Copy Markdown
ContributorAuthor

I'm not sure why things are failing after getting up to date with develop 😢 I'll poke at this tomorrow.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

Looks like the failing tests were fixed in #15001.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

If y'all want to check for a maximally-deduped lockfile in CI (I'd strongly advise this), you can add a npx yarn-deduplicate --check step to CI. Let me know if this is desired and I can add it.

Once you're using Yarn v4, this is built in via yarn dedupe/yarn dedupe --check.

AbhiPrasad pushed a commit that referenced this pull request Jan 17, 2025
Backport of #14971 to v8. This is a prerequisite for an eventual
backport of #14968, which will itself will make applying/backporting
#14967 much easier.
I ran `yarn build` and `yarn test` locally. Building succeeded, and all
but 2 test suites passed. The two that failed also failed for me on `v8`
(without any of my changes), so I'm assuming it's something to do with
my environment.
@AbhiPrasad
AbhiPrasad merged commit 82adfbb into getsentry:developJan 20, 2025
@nwalters512
nwalters512 deleted the yarn-deduplicate branch January 21, 2025 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nwalters512@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); chore(deps): Deduplicate yarn.lock by nwalters512 · Pull Request #14968 · getsentry/sentry-javascript · GitHub
Skip to content

chore(deps): Deduplicate yarn.lock - #14968

Merged
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate
Jan 20, 2025
Merged

chore(deps): Deduplicate yarn.lock#14968
AbhiPrasad merged 13 commits into
getsentry:developfrom
nwalters512:yarn-deduplicate

Conversation

@nwalters512

Copy link
Copy Markdown
Contributor

I'm splitting this out of #14967 since it was getting a little out of hand in that other PR.

Tests are currently failing, seemingly related to ampproject/remapping#193. It seems like this may only have been fixed in vitest v2? So that might be a blocker for these changes.

There's another strange failure in the packages/browser test:

 FAIL test/eventbuilder.test.ts > extractMessage > should extract message from a WebAssembly.Exception object
AssertionError: expected 'No error message' to be 'wasm exception' // Object.is equality
- Expected
+ Received
- wasm exception
+ No error message
❯ test/eventbuilder.test.ts:188:21
186| 187| const message = extractMessage(wasmException);
188| expect(message).toBe('wasm exception');
| ^
189| });
190| 

However, this also fails for me on the develop branch, so this may not be related to these changes.

@nwalters512
nwalters512 marked this pull request as ready for review January 13, 2025 16:16
@nwalters512

nwalters512 commented Jan 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@mydea I'm unable to reproduce the integration test failures (https://github.com/getsentry/sentry-javascript/actions/runs/12751414906/job/35538905465?pr=14968) locally. I'm frankly not sure why integration tests seem to be performing type checking in the first place. Can you offer any guidance here? Maybe this is related to dependency caching in CI? Thanks!

Edit: I see now that it's testing against TS 3.8, and that I need to run node ./scripts/use-ts-3_8.js locally to reproduce this.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

It looks like the type errors are occurring because @types/express-serve-static-core uses modern TypeScript features that aren't supported by TypeScript 3.8, e.g.:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/c55a1e4fd5c048683bfd7c55340c78193124d11b/types/express-serve-static-core/index.d.ts#L105

Support for this was only introduced in TypeScript 4.1: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-1.html

This was introduced to those types 4 years ago: DefinitelyTyped/DefinitelyTyped#51262

And as of 2 years ago, TypeScript <=4.0 is no longer supported by DefinitelyTyped: DefinitelyTyped/DefinitelyTyped#62240

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

In 30b8213 I updated the TypeScript 3.8 script to use resolutions in package.json to pin the Express types to older versions, which worked for me locally.

@AbhiPrasad
AbhiPrasad self-requested a review January 14, 2025 04:32
@AbhiPrasad

Copy link
Copy Markdown
Contributor

Marking myself as a reviewer, will take a look ASAP!

Why is Sentry testing against TypeScript 3.8? This version hasn't been supported for a long time, and @types/* packages are no longer guaranteed to be compatible with it.

Because we want to be as a compatible with many users as possible. We said we would support 3.8+ with our 8.x major version, so we need to test to make sure we support it. We often hold support for things much longer than typical LTS for most JS libraries: https://develop.sentry.dev/sdk/philosophy/#compatibility-is-king

@AbhiPrasadAbhiPrasad self-assigned this Jan 14, 2025
@nwalters512

Copy link
Copy Markdown
ContributorAuthor

I'm not sure why things are failing after getting up to date with develop 😢 I'll poke at this tomorrow.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

Looks like the failing tests were fixed in #15001.

@nwalters512

Copy link
Copy Markdown
ContributorAuthor

If y'all want to check for a maximally-deduped lockfile in CI (I'd strongly advise this), you can add a npx yarn-deduplicate --check step to CI. Let me know if this is desired and I can add it.

Once you're using Yarn v4, this is built in via yarn dedupe/yarn dedupe --check.

AbhiPrasad pushed a commit that referenced this pull request Jan 17, 2025
Backport of #14971 to v8. This is a prerequisite for an eventual
backport of #14968, which will itself will make applying/backporting
#14967 much easier.
I ran `yarn build` and `yarn test` locally. Building succeeded, and all
but 2 test suites passed. The two that failed also failed for me on `v8`
(without any of my changes), so I'm assuming it's something to do with
my environment.
@AbhiPrasad
AbhiPrasad merged commit 82adfbb into getsentry:developJan 20, 2025
@nwalters512
nwalters512 deleted the yarn-deduplicate branch January 21, 2025 18:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nwalters512@AbhiPrasad