fix(profiling): Make esbuild detect node binaries with CJS require

[s1gr1d]

Attempt to fix#15026

esbuild only loads the node binaries when they are loaded with require() in CJS and import() in ESM. By adding a build-time replacement string for rollup, we can either add require or import depending on the build output.

The first approach did not work as the the Node binaries were added to the build output but import() cannot load node binaries (only JS modules). Now, the returned value from createRequire is renamed to require to make it more obvious to e.g. esbuild. However, currently there is no support for createRequire in esbuild: evanw/esbuild#1828

For CJS, the native require is used and not the returned value from createRequire, as this variable would get renamed during build (e.g. require$1) which causes esbuild to ignore the node binaries as well.

[s1gr1d]

Closing this in favor of this: #15208

[s1gr1d]

Attempt to fix#15026

esbuild only loads the node binaries when they are loaded with require() in CJS and import() in ESM. By adding a build-time replacement string for rollup, we can either add require or import depending on the build output.

The first approach did not work as the the Node binaries were added to the build output but import() cannot load node binaries (only JS modules). Now, the returned value from createRequire is renamed to require to make it more obvious to e.g. esbuild. However, currently there is no support for createRequire in esbuild: evanw/esbuild#1828

For CJS, the native require is used and not the returned value from createRequire, as this variable would get renamed during build (e.g. require$1) which causes esbuild to ignore the node binaries as well.

[s1gr1d]

Closing this in favor of this: #15208

[s1gr1d]

Attempt to fix#15026

esbuild only loads the node binaries when they are loaded with require() in CJS and import() in ESM. By adding a build-time replacement string for rollup, we can either add require or import depending on the build output.

The first approach did not work as the the Node binaries were added to the build output but import() cannot load node binaries (only JS modules). Now, the returned value from createRequire is renamed to require to make it more obvious to e.g. esbuild. However, currently there is no support for createRequire in esbuild: evanw/esbuild#1828

For CJS, the native require is used and not the returned value from createRequire, as this variable would get renamed during build (e.g. require$1) which causes esbuild to ignore the node binaries as well.

[s1gr1d]

Closing this in favor of this: #15208

[s1gr1d]

Attempt to fix#15026

esbuild only loads the node binaries when they are loaded with require() in CJS and import() in ESM. By adding a build-time replacement string for rollup, we can either add require or import depending on the build output.

The first approach did not work as the the Node binaries were added to the build output but import() cannot load node binaries (only JS modules). Now, the returned value from createRequire is renamed to require to make it more obvious to e.g. esbuild. However, currently there is no support for createRequire in esbuild: evanw/esbuild#1828

For CJS, the native require is used and not the returned value from createRequire, as this variable would get renamed during build (e.g. require$1) which causes esbuild to ignore the node binaries as well.

[s1gr1d]

Closing this in favor of this: #15208

[s1gr1d]

Attempt to fix#15026

esbuild only loads the node binaries when they are loaded with require() in CJS and import() in ESM. By adding a build-time replacement string for rollup, we can either add require or import depending on the build output.

The first approach did not work as the the Node binaries were added to the build output but import() cannot load node binaries (only JS modules). Now, the returned value from createRequire is renamed to require to make it more obvious to e.g. esbuild. However, currently there is no support for createRequire in esbuild: evanw/esbuild#1828

For CJS, the native require is used and not the returned value from createRequire, as this variable would get renamed during build (e.g. require$1) which causes esbuild to ignore the node binaries as well.

[s1gr1d]

Closing this in favor of this: #15208

[s1gr1d]

Attempt to fix#15026

esbuild only loads the node binaries when they are loaded with require() in CJS and import() in ESM. By adding a build-time replacement string for rollup, we can either add require or import depending on the build output.

The first approach did not work as the the Node binaries were added to the build output but import() cannot load node binaries (only JS modules). Now, the returned value from createRequire is renamed to require to make it more obvious to e.g. esbuild. However, currently there is no support for createRequire in esbuild: evanw/esbuild#1828

For CJS, the native require is used and not the returned value from createRequire, as this variable would get renamed during build (e.g. require$1) which causes esbuild to ignore the node binaries as well.

[s1gr1d]

Closing this in favor of this: #15208

[s1gr1d]

Attempt to fix#15026

esbuild only loads the node binaries when they are loaded with require() in CJS and import() in ESM. By adding a build-time replacement string for rollup, we can either add require or import depending on the build output.

The first approach did not work as the the Node binaries were added to the build output but import() cannot load node binaries (only JS modules). Now, the returned value from createRequire is renamed to require to make it more obvious to e.g. esbuild. However, currently there is no support for createRequire in esbuild: evanw/esbuild#1828

For CJS, the native require is used and not the returned value from createRequire, as this variable would get renamed during build (e.g. require$1) which causes esbuild to ignore the node binaries as well.

[s1gr1d]

Closing this in favor of this: #15208

[s1gr1d]

Attempt to fix#15026

esbuild only loads the node binaries when they are loaded with require() in CJS and import() in ESM. By adding a build-time replacement string for rollup, we can either add require or import depending on the build output.

The first approach did not work as the the Node binaries were added to the build output but import() cannot load node binaries (only JS modules). Now, the returned value from createRequire is renamed to require to make it more obvious to e.g. esbuild. However, currently there is no support for createRequire in esbuild: evanw/esbuild#1828

For CJS, the native require is used and not the returned value from createRequire, as this variable would get renamed during build (e.g. require$1) which causes esbuild to ignore the node binaries as well.

[s1gr1d]

Closing this in favor of this: #15208