Uh oh!
There was an error while loading. Please reload this page.
feat(user feedback): Adds draw tool for UF screenshot annotations - #15062
Conversation
size-limit report 📦
|
billyvg
left a comment
There was a problem hiding this comment.
Have you tested different combinations of mouse events inside and outside of the canvas?
This generally LGTM -- I would say it needs the feature flag + an icon before merging.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Yes! When the pen tool is on, it only starts drawing when you press down in the canvas, you can't draw if you press down outside of the canvas and drag your mouse into the canvas. The drawing state persists as long as your mouse is still down, even if you go outside of the canvas, but the lines are only visible on the canvas. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ryan Albrecht <ryan.albrecht@sentry.io>
Adds a proper pen tool button. The icon for the button is from the hackweek project Unselected: <img width="1192" alt="image" src="https://github.com/user-attachments/assets/4d8ba719-ff93-4108-98a4-560296ef5890" /> Selected: <img width="1192" alt="image" src="https://github.com/user-attachments/assets/7bd24ef2-6877-47a3-bcf1-e871caa4f91b" /> Relates to #15064
_experiments: {annotations: true}Screen.Recording.2025-01-17.at.5.38.33.PM.mov
Closes#15064