chore(deps): Update playwright to 1.50.0#15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 13 commits into from
Jan 28, 2025
Merged

chore(deps): Update playwright to 1.50.0 #15164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5d910a8
chore(deps): Update playwright to 1.50.0
mydea Jan 27, 2025
f29ffed
fix test
mydea Jan 27, 2025
ca2cdfb
fix tests
mydea Jan 27, 2025
96ca4fd
update snapshots ??
mydea Jan 27, 2025
f4b07f1
remove package stuff
mydea Jan 27, 2025
a7d87d6
small ref
mydea Jan 27, 2025
8001258
fix ci
mydea Jan 27, 2025
a74f633
FIXES
mydea Jan 27, 2025
3889554
fix it
mydea Jan 27, 2025
7aa9685
fix keepalive
mydea Jan 27, 2025
6cc0402
fix remaining firefox tests
mydea Jan 27, 2025
01bf194
merge tests
mydea Jan 27, 2025
aaac579
fix flaky test detector
mydea Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -600,7 +600,7 @@ jobs:
env:
PW_BUNDLE: ${{ matrix.bundle }}
working-directory: dev-packages/browser-integration-tests
run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}
run: yarn test:all${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}

- name: Upload Playwright Traces
uses: actions/upload-artifact@v4
Expand Down
3 changes: 1 addition & 2 deletions dev-packages/browser-integration-tests/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -35,13 +35,12 @@
"test:loader:replay_buffer": "PW_BUNDLE=loader_replay_buffer yarn test:loader",
"test:loader:full": "PW_BUNDLE=loader_tracing_replay yarn test:loader",
"test:loader:debug": "PW_BUNDLE=loader_debug yarn test:loader",
"test:ci": "yarn test:all",
"test:update-snapshots": "yarn test:all --update-snapshots",
"test:detect-flaky": "ts-node scripts/detectFlakyTests.ts"
},
"dependencies": {
"@babel/preset-typescript": "^7.16.7",
"@playwright/test": "^1.44.1",
"@playwright/test": "~1.50.0",
"@sentry-internal/rrweb": "2.31.0",
"@sentry/browser": "9.0.0-alpha.0",
"axios": "1.7.7",
Expand Down
49 changes: 10 additions & 39 deletions dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,14 +4,9 @@ import * as path from 'path';
import * as glob from 'glob';

/**
* The number of browsers we run the tests in.
* Assume that each test runs for 3s.
*/
const NUM_BROWSERS = 3;

/**
* Assume that each test runs for 2s.
*/
const ASSUMED_TEST_DURATION_SECONDS = 2;
const ASSUMED_TEST_DURATION_SECONDS = 3;

/**
* We keep the runtime of the detector if possible under 30min.
Expand DownExpand Up@@ -51,22 +46,12 @@ ${changedPaths.join('\n')}
try {
await new Promise<void>((resolve, reject) => {
const cp = childProcess.spawn(
`npx playwright test ${
testPaths.length ? testPaths.join(' ') : './suites'
} --reporter='line' --repeat-each ${repeatEachCount}`,
{ shell: true, cwd },
`npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount}`,
{ shell: true, cwd, stdio: 'inherit' },
);

let error: Error | undefined;

cp.stdout.on('data', data => {
console.log(data ? (data as object).toString() : '');
});

cp.stderr.on('data', data => {
console.log(data ? (data as object).toString() : '');
});

cp.on('error', e => {
console.error(e);
error = e;
Expand DownExpand Up@@ -107,15 +92,16 @@ function getPerTestRunCount(testPaths: string[]) {
const estimatedNumberOfTests = testPaths.map(getApproximateNumberOfTests).reduce((a, b) => a + b);
console.log(`Estimated number of tests: ${estimatedNumberOfTests}`);

// tests are usually run against all browsers we test with, so let's assume this
const testRunCount = estimatedNumberOfTests * NUM_BROWSERS;
const testRunCount = estimatedNumberOfTests;
console.log(`Estimated test runs for one round: ${testRunCount}`);

const estimatedTestRuntime = testRunCount * ASSUMED_TEST_DURATION_SECONDS;
console.log(`Estimated test runtime: ${estimatedTestRuntime}s`);

const expectedPerTestRunCount = Math.floor(MAX_TARGET_TEST_RUNTIME_SECONDS / estimatedTestRuntime);
console.log(`Expected per-test run count: ${expectedPerTestRunCount}`);
console.log(
`Calculated # of repetitions: ${expectedPerTestRunCount} (min ${MIN_PER_TEST_RUN_COUNT}, max ${MAX_PER_TEST_RUN_COUNT})`,
);

return Math.min(MAX_PER_TEST_RUN_COUNT, Math.max(expectedPerTestRunCount, MIN_PER_TEST_RUN_COUNT));
}
Expand All@@ -128,22 +114,7 @@ function getTestPaths(): string[] {
cwd: path.join(__dirname, '../'),
});

return paths.map(p => path.dirname(p));
}

function logError(error: unknown) {

@mydeamydeaJan 28, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not used

if (process.env.CI) {
console.log('::group::Test failed');
} else {
console.error(' ⚠️ Test failed:');
}

console.log((error as any).stdout);
console.log((error as any).stderr);

if (process.env.CI) {
console.log('::endgroup::');
}
return paths.map(p => `${path.dirname(p)}/`);

@mydeamydeaJan 28, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bit buggy - e.g. if one dirname was suites/tracing/metrics/web-vitals/test.ts, it would have made it to suites/tracing/metrics/web-vitals, which then in turn also matches e.g. web-vitals-cls etc. dirs. Now, it should be stricter in that regard.

}

/**
Expand All@@ -156,7 +127,7 @@ function logError(error: unknown) {
function getApproximateNumberOfTests(testPath: string): number {
try {
const content = fs.readFileSync(path.join(process.cwd(), testPath, 'test.ts'), 'utf-8');
const matches = content.match(/it\(|test\(|sentryTest\(/g);
const matches = content.match(/sentryTest\(/g);

@mydeamydeaJan 28, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always use sentryTest, so no need to check others here IMHO

return Math.max(matches ? matches.length : 1, 1);
} catch (e) {
console.error(`Could not read file ${testPath}`);
Expand Down
2 changes: 1 addition & 1 deletion ...browser-integration-tests/suites/public-api/instrumentation/onError/syntax-errors/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ sentryTest('should catch syntax errors', async ({ getLocalTestUrl, page, browser
expect(eventData.exception?.values).toHaveLength(1);
expect(eventData.exception?.values?.[0]).toMatchObject({
type: 'SyntaxError',
value: "Unexpected token '{'",
value: "Failed to execute 'appendChild' on 'Node': Unexpected token '{'",
mechanism: {
type: 'onerror',
handled: false,
Expand Down
113 changes: 0 additions & 113 deletions .../browser-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-0-snap-full
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions ...r-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions ...tion-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental-chromium
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
"type": 1,
"id": 9,
"x": 41.810001373291016,
"y": 18.479999542236328
"y": 18.5
},
"timestamp": [timestamp]
},
Expand All@@ -26,7 +26,7 @@
"type": 0,
"id": 9,
"x": 41.810001373291016,
"y": 18.479999542236328
"y": 18.5
},
"timestamp": [timestamp]
},
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore(deps): Update playwright to 1.50.0#15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 13 commits into

from

Jan 28, 2025
 Merged


chore(deps): Update playwright to 1.50.0
#15164
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
5d910a8

chore(deps): Update playwright to 1.50.0


mydea Jan 27, 2025
f29ffed

fix test


mydea Jan 27, 2025
ca2cdfb

fix tests


mydea Jan 27, 2025
96ca4fd

update snapshots ??


mydea Jan 27, 2025
f4b07f1

remove package stuff


mydea Jan 27, 2025
a7d87d6

small ref


mydea Jan 27, 2025
8001258

fix ci


mydea Jan 27, 2025
a74f633

FIXES


mydea Jan 27, 2025
3889554

fix it


mydea Jan 27, 2025
7aa9685

fix keepalive


mydea Jan 27, 2025
6cc0402

fix remaining firefox tests


mydea Jan 27, 2025
01bf194

merge tests


mydea Jan 27, 2025
aaac579

fix flaky test detector


mydea Jan 28, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -600,7 +600,7 @@ jobs:
 env:
 PW_BUNDLE: ${{ matrix.bundle }}
 working-directory: dev-packages/browser-integration-tests
 run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}
 run: yarn test:all${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}

 - name: Upload Playwright Traces
 uses: actions/upload-artifact@v4
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,13 +35,12 @@
 "test:loader:replay_buffer": "PW_BUNDLE=loader_replay_buffer yarn test:loader",
 "test:loader:full": "PW_BUNDLE=loader_tracing_replay yarn test:loader",
 "test:loader:debug": "PW_BUNDLE=loader_debug yarn test:loader",
 "test:ci": "yarn test:all",
 "test:update-snapshots": "yarn test:all --update-snapshots",
 "test:detect-flaky": "ts-node scripts/detectFlakyTests.ts"
 },
 "dependencies": {
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "^1.44.1",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.31.0",
 "@sentry/browser": "9.0.0-alpha.0",
 "axios": "1.7.7",
Expand Down

49 changes: 10 additions & 39 deletions
dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,14 +4,9 @@ import * as path from 'path';
import * as glob from 'glob';

/**
 * The number of browsers we run the tests in.
 * Assume that each test runs for 3s.
 */
const NUM_BROWSERS = 3;

/**
 * Assume that each test runs for 2s.
 */
const ASSUMED_TEST_DURATION_SECONDS = 2;
const ASSUMED_TEST_DURATION_SECONDS = 3;

/**
 * We keep the runtime of the detector if possible under 30min.
Expand DownExpand Up@@ -51,22 +46,12 @@ ${changedPaths.join('\n')}
 try {
 await new Promise<void>((resolve, reject) => {
 const cp = childProcess.spawn(
 `npx playwright test ${
 testPaths.length ? testPaths.join(' ') : './suites'
 } --reporter='line' --repeat-each ${repeatEachCount}`,
 { shell: true, cwd },
 `npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount}`,
 { shell: true, cwd, stdio: 'inherit' },
 );

 let error: Error | undefined;

 cp.stdout.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.stderr.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.on('error', e => {
 console.error(e);
 error = e;
Expand DownExpand Up@@ -107,15 +92,16 @@ function getPerTestRunCount(testPaths: string[]) {
 const estimatedNumberOfTests = testPaths.map(getApproximateNumberOfTests).reduce((a, b) => a + b);
 console.log(`Estimated number of tests: ${estimatedNumberOfTests}`);

 // tests are usually run against all browsers we test with, so let's assume this
 const testRunCount = estimatedNumberOfTests * NUM_BROWSERS;
 const testRunCount = estimatedNumberOfTests;
 console.log(`Estimated test runs for one round: ${testRunCount}`);

 const estimatedTestRuntime = testRunCount * ASSUMED_TEST_DURATION_SECONDS;
 console.log(`Estimated test runtime: ${estimatedTestRuntime}s`);

 const expectedPerTestRunCount = Math.floor(MAX_TARGET_TEST_RUNTIME_SECONDS / estimatedTestRuntime);
 console.log(`Expected per-test run count: ${expectedPerTestRunCount}`);
 console.log(
 `Calculated # of repetitions: ${expectedPerTestRunCount} (min ${MIN_PER_TEST_RUN_COUNT}, max ${MAX_PER_TEST_RUN_COUNT})`,
 );

 return Math.min(MAX_PER_TEST_RUN_COUNT, Math.max(expectedPerTestRunCount, MIN_PER_TEST_RUN_COUNT));
 }
Expand All@@ -128,22 +114,7 @@ function getTestPaths(): string[] {
 cwd: path.join(__dirname, '../'),
 });

 return paths.map(p => path.dirname(p));
}

function logError(error: unknown) {
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not used
 if (process.env.CI) {
 console.log('::group::Test failed');
 } else {
 console.error(' ⚠️ Test failed:');
 }

 console.log((error as any).stdout);
 console.log((error as any).stderr);

 if (process.env.CI) {
 console.log('::endgroup::');
 }
 return paths.map(p => `${path.dirname(p)}/`);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bit buggy - e.g. if one dirname was suites/tracing/metrics/web-vitals/test.ts, it would have made it to suites/tracing/metrics/web-vitals, which then in turn also matches e.g. web-vitals-cls etc. dirs. Now, it should be stricter in that regard.
}

/**
Expand All@@ -156,7 +127,7 @@ function logError(error: unknown) {
function getApproximateNumberOfTests(testPath: string): number {
 try {
 const content = fs.readFileSync(path.join(process.cwd(), testPath, 'test.ts'), 'utf-8');
 const matches = content.match(/it\(|test\(|sentryTest\(/g);
 const matches = content.match(/sentryTest\(/g);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always use sentryTest, so no need to check others here IMHO
 return Math.max(matches ? matches.length : 1, 1);
 } catch (e) {
 console.error(`Could not read file ${testPath}`);
Expand Down

2 changes: 1 addition & 1 deletion
...browser-integration-tests/suites/public-api/instrumentation/onError/syntax-errors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ sentryTest('should catch syntax errors', async ({ getLocalTestUrl, page, browser
 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'SyntaxError',
 value: "Unexpected token '{'",
 value: "Failed to execute 'appendChild' on 'Node': Unexpected token '{'",
 mechanism: {
 type: 'onerror',
 handled: false,
Expand Down

113 changes: 0 additions & 113 deletions
.../browser-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-0-snap-full

View file


Open in desktop


This file was deleted.


45 changes: 0 additions & 45 deletions
...r-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental

View file


Open in desktop


This file was deleted.


4 changes: 2 additions & 2 deletions
...tion-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental-chromium

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 "type": 1,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand All@@ -26,7 +26,7 @@
 "type": 0,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(deps): Update playwright to 1.50.0#15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 13 commits into

from

Jan 28, 2025
 Merged


chore(deps): Update playwright to 1.50.0
#15164
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
5d910a8

chore(deps): Update playwright to 1.50.0


mydea Jan 27, 2025
f29ffed

fix test


mydea Jan 27, 2025
ca2cdfb

fix tests


mydea Jan 27, 2025
96ca4fd

update snapshots ??


mydea Jan 27, 2025
f4b07f1

remove package stuff


mydea Jan 27, 2025
a7d87d6

small ref


mydea Jan 27, 2025
8001258

fix ci


mydea Jan 27, 2025
a74f633

FIXES


mydea Jan 27, 2025
3889554

fix it


mydea Jan 27, 2025
7aa9685

fix keepalive


mydea Jan 27, 2025
6cc0402

fix remaining firefox tests


mydea Jan 27, 2025
01bf194

merge tests


mydea Jan 27, 2025
aaac579

fix flaky test detector


mydea Jan 28, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -600,7 +600,7 @@ jobs:
 env:
 PW_BUNDLE: ${{ matrix.bundle }}
 working-directory: dev-packages/browser-integration-tests
 run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}
 run: yarn test:all${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}

 - name: Upload Playwright Traces
 uses: actions/upload-artifact@v4
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,13 +35,12 @@
 "test:loader:replay_buffer": "PW_BUNDLE=loader_replay_buffer yarn test:loader",
 "test:loader:full": "PW_BUNDLE=loader_tracing_replay yarn test:loader",
 "test:loader:debug": "PW_BUNDLE=loader_debug yarn test:loader",
 "test:ci": "yarn test:all",
 "test:update-snapshots": "yarn test:all --update-snapshots",
 "test:detect-flaky": "ts-node scripts/detectFlakyTests.ts"
 },
 "dependencies": {
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "^1.44.1",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.31.0",
 "@sentry/browser": "9.0.0-alpha.0",
 "axios": "1.7.7",
Expand Down

49 changes: 10 additions & 39 deletions
dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,14 +4,9 @@ import * as path from 'path';
import * as glob from 'glob';

/**
 * The number of browsers we run the tests in.
 * Assume that each test runs for 3s.
 */
const NUM_BROWSERS = 3;

/**
 * Assume that each test runs for 2s.
 */
const ASSUMED_TEST_DURATION_SECONDS = 2;
const ASSUMED_TEST_DURATION_SECONDS = 3;

/**
 * We keep the runtime of the detector if possible under 30min.
Expand DownExpand Up@@ -51,22 +46,12 @@ ${changedPaths.join('\n')}
 try {
 await new Promise<void>((resolve, reject) => {
 const cp = childProcess.spawn(
 `npx playwright test ${
 testPaths.length ? testPaths.join(' ') : './suites'
 } --reporter='line' --repeat-each ${repeatEachCount}`,
 { shell: true, cwd },
 `npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount}`,
 { shell: true, cwd, stdio: 'inherit' },
 );

 let error: Error | undefined;

 cp.stdout.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.stderr.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.on('error', e => {
 console.error(e);
 error = e;
Expand DownExpand Up@@ -107,15 +92,16 @@ function getPerTestRunCount(testPaths: string[]) {
 const estimatedNumberOfTests = testPaths.map(getApproximateNumberOfTests).reduce((a, b) => a + b);
 console.log(`Estimated number of tests: ${estimatedNumberOfTests}`);

 // tests are usually run against all browsers we test with, so let's assume this
 const testRunCount = estimatedNumberOfTests * NUM_BROWSERS;
 const testRunCount = estimatedNumberOfTests;
 console.log(`Estimated test runs for one round: ${testRunCount}`);

 const estimatedTestRuntime = testRunCount * ASSUMED_TEST_DURATION_SECONDS;
 console.log(`Estimated test runtime: ${estimatedTestRuntime}s`);

 const expectedPerTestRunCount = Math.floor(MAX_TARGET_TEST_RUNTIME_SECONDS / estimatedTestRuntime);
 console.log(`Expected per-test run count: ${expectedPerTestRunCount}`);
 console.log(
 `Calculated # of repetitions: ${expectedPerTestRunCount} (min ${MIN_PER_TEST_RUN_COUNT}, max ${MAX_PER_TEST_RUN_COUNT})`,
 );

 return Math.min(MAX_PER_TEST_RUN_COUNT, Math.max(expectedPerTestRunCount, MIN_PER_TEST_RUN_COUNT));
 }
Expand All@@ -128,22 +114,7 @@ function getTestPaths(): string[] {
 cwd: path.join(__dirname, '../'),
 });

 return paths.map(p => path.dirname(p));
}

function logError(error: unknown) {
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not used
 if (process.env.CI) {
 console.log('::group::Test failed');
 } else {
 console.error(' ⚠️ Test failed:');
 }

 console.log((error as any).stdout);
 console.log((error as any).stderr);

 if (process.env.CI) {
 console.log('::endgroup::');
 }
 return paths.map(p => `${path.dirname(p)}/`);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bit buggy - e.g. if one dirname was suites/tracing/metrics/web-vitals/test.ts, it would have made it to suites/tracing/metrics/web-vitals, which then in turn also matches e.g. web-vitals-cls etc. dirs. Now, it should be stricter in that regard.
}

/**
Expand All@@ -156,7 +127,7 @@ function logError(error: unknown) {
function getApproximateNumberOfTests(testPath: string): number {
 try {
 const content = fs.readFileSync(path.join(process.cwd(), testPath, 'test.ts'), 'utf-8');
 const matches = content.match(/it\(|test\(|sentryTest\(/g);
 const matches = content.match(/sentryTest\(/g);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always use sentryTest, so no need to check others here IMHO
 return Math.max(matches ? matches.length : 1, 1);
 } catch (e) {
 console.error(`Could not read file ${testPath}`);
Expand Down

2 changes: 1 addition & 1 deletion
...browser-integration-tests/suites/public-api/instrumentation/onError/syntax-errors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ sentryTest('should catch syntax errors', async ({ getLocalTestUrl, page, browser
 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'SyntaxError',
 value: "Unexpected token '{'",
 value: "Failed to execute 'appendChild' on 'Node': Unexpected token '{'",
 mechanism: {
 type: 'onerror',
 handled: false,
Expand Down

113 changes: 0 additions & 113 deletions
.../browser-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-0-snap-full

View file


Open in desktop


This file was deleted.


45 changes: 0 additions & 45 deletions
...r-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental

View file


Open in desktop


This file was deleted.


4 changes: 2 additions & 2 deletions
...tion-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental-chromium

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 "type": 1,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand All@@ -26,7 +26,7 @@
 "type": 0,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(deps): Update playwright to 1.50.0#15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 13 commits into

from

Jan 28, 2025
 Merged


chore(deps): Update playwright to 1.50.0
#15164
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
5d910a8

chore(deps): Update playwright to 1.50.0


mydea Jan 27, 2025
f29ffed

fix test


mydea Jan 27, 2025
ca2cdfb

fix tests


mydea Jan 27, 2025
96ca4fd

update snapshots ??


mydea Jan 27, 2025
f4b07f1

remove package stuff


mydea Jan 27, 2025
a7d87d6

small ref


mydea Jan 27, 2025
8001258

fix ci


mydea Jan 27, 2025
a74f633

FIXES


mydea Jan 27, 2025
3889554

fix it


mydea Jan 27, 2025
7aa9685

fix keepalive


mydea Jan 27, 2025
6cc0402

fix remaining firefox tests


mydea Jan 27, 2025
01bf194

merge tests


mydea Jan 27, 2025
aaac579

fix flaky test detector


mydea Jan 28, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -600,7 +600,7 @@ jobs:
 env:
 PW_BUNDLE: ${{ matrix.bundle }}
 working-directory: dev-packages/browser-integration-tests
 run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}
 run: yarn test:all${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}

 - name: Upload Playwright Traces
 uses: actions/upload-artifact@v4
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,13 +35,12 @@
 "test:loader:replay_buffer": "PW_BUNDLE=loader_replay_buffer yarn test:loader",
 "test:loader:full": "PW_BUNDLE=loader_tracing_replay yarn test:loader",
 "test:loader:debug": "PW_BUNDLE=loader_debug yarn test:loader",
 "test:ci": "yarn test:all",
 "test:update-snapshots": "yarn test:all --update-snapshots",
 "test:detect-flaky": "ts-node scripts/detectFlakyTests.ts"
 },
 "dependencies": {
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "^1.44.1",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.31.0",
 "@sentry/browser": "9.0.0-alpha.0",
 "axios": "1.7.7",
Expand Down

49 changes: 10 additions & 39 deletions
dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,14 +4,9 @@ import * as path from 'path';
import * as glob from 'glob';

/**
 * The number of browsers we run the tests in.
 * Assume that each test runs for 3s.
 */
const NUM_BROWSERS = 3;

/**
 * Assume that each test runs for 2s.
 */
const ASSUMED_TEST_DURATION_SECONDS = 2;
const ASSUMED_TEST_DURATION_SECONDS = 3;

/**
 * We keep the runtime of the detector if possible under 30min.
Expand DownExpand Up@@ -51,22 +46,12 @@ ${changedPaths.join('\n')}
 try {
 await new Promise<void>((resolve, reject) => {
 const cp = childProcess.spawn(
 `npx playwright test ${
 testPaths.length ? testPaths.join(' ') : './suites'
 } --reporter='line' --repeat-each ${repeatEachCount}`,
 { shell: true, cwd },
 `npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount}`,
 { shell: true, cwd, stdio: 'inherit' },
 );

 let error: Error | undefined;

 cp.stdout.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.stderr.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.on('error', e => {
 console.error(e);
 error = e;
Expand DownExpand Up@@ -107,15 +92,16 @@ function getPerTestRunCount(testPaths: string[]) {
 const estimatedNumberOfTests = testPaths.map(getApproximateNumberOfTests).reduce((a, b) => a + b);
 console.log(`Estimated number of tests: ${estimatedNumberOfTests}`);

 // tests are usually run against all browsers we test with, so let's assume this
 const testRunCount = estimatedNumberOfTests * NUM_BROWSERS;
 const testRunCount = estimatedNumberOfTests;
 console.log(`Estimated test runs for one round: ${testRunCount}`);

 const estimatedTestRuntime = testRunCount * ASSUMED_TEST_DURATION_SECONDS;
 console.log(`Estimated test runtime: ${estimatedTestRuntime}s`);

 const expectedPerTestRunCount = Math.floor(MAX_TARGET_TEST_RUNTIME_SECONDS / estimatedTestRuntime);
 console.log(`Expected per-test run count: ${expectedPerTestRunCount}`);
 console.log(
 `Calculated # of repetitions: ${expectedPerTestRunCount} (min ${MIN_PER_TEST_RUN_COUNT}, max ${MAX_PER_TEST_RUN_COUNT})`,
 );

 return Math.min(MAX_PER_TEST_RUN_COUNT, Math.max(expectedPerTestRunCount, MIN_PER_TEST_RUN_COUNT));
 }
Expand All@@ -128,22 +114,7 @@ function getTestPaths(): string[] {
 cwd: path.join(__dirname, '../'),
 });

 return paths.map(p => path.dirname(p));
}

function logError(error: unknown) {
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not used
 if (process.env.CI) {
 console.log('::group::Test failed');
 } else {
 console.error(' ⚠️ Test failed:');
 }

 console.log((error as any).stdout);
 console.log((error as any).stderr);

 if (process.env.CI) {
 console.log('::endgroup::');
 }
 return paths.map(p => `${path.dirname(p)}/`);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bit buggy - e.g. if one dirname was suites/tracing/metrics/web-vitals/test.ts, it would have made it to suites/tracing/metrics/web-vitals, which then in turn also matches e.g. web-vitals-cls etc. dirs. Now, it should be stricter in that regard.
}

/**
Expand All@@ -156,7 +127,7 @@ function logError(error: unknown) {
function getApproximateNumberOfTests(testPath: string): number {
 try {
 const content = fs.readFileSync(path.join(process.cwd(), testPath, 'test.ts'), 'utf-8');
 const matches = content.match(/it\(|test\(|sentryTest\(/g);
 const matches = content.match(/sentryTest\(/g);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always use sentryTest, so no need to check others here IMHO
 return Math.max(matches ? matches.length : 1, 1);
 } catch (e) {
 console.error(`Could not read file ${testPath}`);
Expand Down

2 changes: 1 addition & 1 deletion
...browser-integration-tests/suites/public-api/instrumentation/onError/syntax-errors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ sentryTest('should catch syntax errors', async ({ getLocalTestUrl, page, browser
 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'SyntaxError',
 value: "Unexpected token '{'",
 value: "Failed to execute 'appendChild' on 'Node': Unexpected token '{'",
 mechanism: {
 type: 'onerror',
 handled: false,
Expand Down

113 changes: 0 additions & 113 deletions
.../browser-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-0-snap-full

View file


Open in desktop


This file was deleted.


45 changes: 0 additions & 45 deletions
...r-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental

View file


Open in desktop


This file was deleted.


4 changes: 2 additions & 2 deletions
...tion-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental-chromium

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 "type": 1,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand All@@ -26,7 +26,7 @@
 "type": 0,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore(deps): Update playwright to 1.50.0#15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 13 commits into

from

Jan 28, 2025
 Merged


chore(deps): Update playwright to 1.50.0
#15164
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
5d910a8

chore(deps): Update playwright to 1.50.0


mydea Jan 27, 2025
f29ffed

fix test


mydea Jan 27, 2025
ca2cdfb

fix tests


mydea Jan 27, 2025
96ca4fd

update snapshots ??


mydea Jan 27, 2025
f4b07f1

remove package stuff


mydea Jan 27, 2025
a7d87d6

small ref


mydea Jan 27, 2025
8001258

fix ci


mydea Jan 27, 2025
a74f633

FIXES


mydea Jan 27, 2025
3889554

fix it


mydea Jan 27, 2025
7aa9685

fix keepalive


mydea Jan 27, 2025
6cc0402

fix remaining firefox tests


mydea Jan 27, 2025
01bf194

merge tests


mydea Jan 27, 2025
aaac579

fix flaky test detector


mydea Jan 28, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -600,7 +600,7 @@ jobs:
 env:
 PW_BUNDLE: ${{ matrix.bundle }}
 working-directory: dev-packages/browser-integration-tests
 run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}
 run: yarn test:all${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}

 - name: Upload Playwright Traces
 uses: actions/upload-artifact@v4
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,13 +35,12 @@
 "test:loader:replay_buffer": "PW_BUNDLE=loader_replay_buffer yarn test:loader",
 "test:loader:full": "PW_BUNDLE=loader_tracing_replay yarn test:loader",
 "test:loader:debug": "PW_BUNDLE=loader_debug yarn test:loader",
 "test:ci": "yarn test:all",
 "test:update-snapshots": "yarn test:all --update-snapshots",
 "test:detect-flaky": "ts-node scripts/detectFlakyTests.ts"
 },
 "dependencies": {
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "^1.44.1",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.31.0",
 "@sentry/browser": "9.0.0-alpha.0",
 "axios": "1.7.7",
Expand Down

49 changes: 10 additions & 39 deletions
dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,14 +4,9 @@ import * as path from 'path';
import * as glob from 'glob';

/**
 * The number of browsers we run the tests in.
 * Assume that each test runs for 3s.
 */
const NUM_BROWSERS = 3;

/**
 * Assume that each test runs for 2s.
 */
const ASSUMED_TEST_DURATION_SECONDS = 2;
const ASSUMED_TEST_DURATION_SECONDS = 3;

/**
 * We keep the runtime of the detector if possible under 30min.
Expand DownExpand Up@@ -51,22 +46,12 @@ ${changedPaths.join('\n')}
 try {
 await new Promise<void>((resolve, reject) => {
 const cp = childProcess.spawn(
 `npx playwright test ${
 testPaths.length ? testPaths.join(' ') : './suites'
 } --reporter='line' --repeat-each ${repeatEachCount}`,
 { shell: true, cwd },
 `npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount}`,
 { shell: true, cwd, stdio: 'inherit' },
 );

 let error: Error | undefined;

 cp.stdout.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.stderr.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.on('error', e => {
 console.error(e);
 error = e;
Expand DownExpand Up@@ -107,15 +92,16 @@ function getPerTestRunCount(testPaths: string[]) {
 const estimatedNumberOfTests = testPaths.map(getApproximateNumberOfTests).reduce((a, b) => a + b);
 console.log(`Estimated number of tests: ${estimatedNumberOfTests}`);

 // tests are usually run against all browsers we test with, so let's assume this
 const testRunCount = estimatedNumberOfTests * NUM_BROWSERS;
 const testRunCount = estimatedNumberOfTests;
 console.log(`Estimated test runs for one round: ${testRunCount}`);

 const estimatedTestRuntime = testRunCount * ASSUMED_TEST_DURATION_SECONDS;
 console.log(`Estimated test runtime: ${estimatedTestRuntime}s`);

 const expectedPerTestRunCount = Math.floor(MAX_TARGET_TEST_RUNTIME_SECONDS / estimatedTestRuntime);
 console.log(`Expected per-test run count: ${expectedPerTestRunCount}`);
 console.log(
 `Calculated # of repetitions: ${expectedPerTestRunCount} (min ${MIN_PER_TEST_RUN_COUNT}, max ${MAX_PER_TEST_RUN_COUNT})`,
 );

 return Math.min(MAX_PER_TEST_RUN_COUNT, Math.max(expectedPerTestRunCount, MIN_PER_TEST_RUN_COUNT));
 }
Expand All@@ -128,22 +114,7 @@ function getTestPaths(): string[] {
 cwd: path.join(__dirname, '../'),
 });

 return paths.map(p => path.dirname(p));
}

function logError(error: unknown) {
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not used
 if (process.env.CI) {
 console.log('::group::Test failed');
 } else {
 console.error(' ⚠️ Test failed:');
 }

 console.log((error as any).stdout);
 console.log((error as any).stderr);

 if (process.env.CI) {
 console.log('::endgroup::');
 }
 return paths.map(p => `${path.dirname(p)}/`);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bit buggy - e.g. if one dirname was suites/tracing/metrics/web-vitals/test.ts, it would have made it to suites/tracing/metrics/web-vitals, which then in turn also matches e.g. web-vitals-cls etc. dirs. Now, it should be stricter in that regard.
}

/**
Expand All@@ -156,7 +127,7 @@ function logError(error: unknown) {
function getApproximateNumberOfTests(testPath: string): number {
 try {
 const content = fs.readFileSync(path.join(process.cwd(), testPath, 'test.ts'), 'utf-8');
 const matches = content.match(/it\(|test\(|sentryTest\(/g);
 const matches = content.match(/sentryTest\(/g);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always use sentryTest, so no need to check others here IMHO
 return Math.max(matches ? matches.length : 1, 1);
 } catch (e) {
 console.error(`Could not read file ${testPath}`);
Expand Down

2 changes: 1 addition & 1 deletion
...browser-integration-tests/suites/public-api/instrumentation/onError/syntax-errors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ sentryTest('should catch syntax errors', async ({ getLocalTestUrl, page, browser
 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'SyntaxError',
 value: "Unexpected token '{'",
 value: "Failed to execute 'appendChild' on 'Node': Unexpected token '{'",
 mechanism: {
 type: 'onerror',
 handled: false,
Expand Down

113 changes: 0 additions & 113 deletions
.../browser-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-0-snap-full

View file


Open in desktop


This file was deleted.


45 changes: 0 additions & 45 deletions
...r-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental

View file


Open in desktop


This file was deleted.


4 changes: 2 additions & 2 deletions
...tion-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental-chromium

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 "type": 1,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand All@@ -26,7 +26,7 @@
 "type": 0,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(deps): Update playwright to 1.50.0#15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 13 commits into

from

Jan 28, 2025
 Merged


chore(deps): Update playwright to 1.50.0
#15164
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
5d910a8

chore(deps): Update playwright to 1.50.0


mydea Jan 27, 2025
f29ffed

fix test


mydea Jan 27, 2025
ca2cdfb

fix tests


mydea Jan 27, 2025
96ca4fd

update snapshots ??


mydea Jan 27, 2025
f4b07f1

remove package stuff


mydea Jan 27, 2025
a7d87d6

small ref


mydea Jan 27, 2025
8001258

fix ci


mydea Jan 27, 2025
a74f633

FIXES


mydea Jan 27, 2025
3889554

fix it


mydea Jan 27, 2025
7aa9685

fix keepalive


mydea Jan 27, 2025
6cc0402

fix remaining firefox tests


mydea Jan 27, 2025
01bf194

merge tests


mydea Jan 27, 2025
aaac579

fix flaky test detector


mydea Jan 28, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -600,7 +600,7 @@ jobs:
 env:
 PW_BUNDLE: ${{ matrix.bundle }}
 working-directory: dev-packages/browser-integration-tests
 run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}
 run: yarn test:all${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}

 - name: Upload Playwright Traces
 uses: actions/upload-artifact@v4
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,13 +35,12 @@
 "test:loader:replay_buffer": "PW_BUNDLE=loader_replay_buffer yarn test:loader",
 "test:loader:full": "PW_BUNDLE=loader_tracing_replay yarn test:loader",
 "test:loader:debug": "PW_BUNDLE=loader_debug yarn test:loader",
 "test:ci": "yarn test:all",
 "test:update-snapshots": "yarn test:all --update-snapshots",
 "test:detect-flaky": "ts-node scripts/detectFlakyTests.ts"
 },
 "dependencies": {
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "^1.44.1",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.31.0",
 "@sentry/browser": "9.0.0-alpha.0",
 "axios": "1.7.7",
Expand Down

49 changes: 10 additions & 39 deletions
dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,14 +4,9 @@ import * as path from 'path';
import * as glob from 'glob';

/**
 * The number of browsers we run the tests in.
 * Assume that each test runs for 3s.
 */
const NUM_BROWSERS = 3;

/**
 * Assume that each test runs for 2s.
 */
const ASSUMED_TEST_DURATION_SECONDS = 2;
const ASSUMED_TEST_DURATION_SECONDS = 3;

/**
 * We keep the runtime of the detector if possible under 30min.
Expand DownExpand Up@@ -51,22 +46,12 @@ ${changedPaths.join('\n')}
 try {
 await new Promise<void>((resolve, reject) => {
 const cp = childProcess.spawn(
 `npx playwright test ${
 testPaths.length ? testPaths.join(' ') : './suites'
 } --reporter='line' --repeat-each ${repeatEachCount}`,
 { shell: true, cwd },
 `npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount}`,
 { shell: true, cwd, stdio: 'inherit' },
 );

 let error: Error | undefined;

 cp.stdout.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.stderr.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.on('error', e => {
 console.error(e);
 error = e;
Expand DownExpand Up@@ -107,15 +92,16 @@ function getPerTestRunCount(testPaths: string[]) {
 const estimatedNumberOfTests = testPaths.map(getApproximateNumberOfTests).reduce((a, b) => a + b);
 console.log(`Estimated number of tests: ${estimatedNumberOfTests}`);

 // tests are usually run against all browsers we test with, so let's assume this
 const testRunCount = estimatedNumberOfTests * NUM_BROWSERS;
 const testRunCount = estimatedNumberOfTests;
 console.log(`Estimated test runs for one round: ${testRunCount}`);

 const estimatedTestRuntime = testRunCount * ASSUMED_TEST_DURATION_SECONDS;
 console.log(`Estimated test runtime: ${estimatedTestRuntime}s`);

 const expectedPerTestRunCount = Math.floor(MAX_TARGET_TEST_RUNTIME_SECONDS / estimatedTestRuntime);
 console.log(`Expected per-test run count: ${expectedPerTestRunCount}`);
 console.log(
 `Calculated # of repetitions: ${expectedPerTestRunCount} (min ${MIN_PER_TEST_RUN_COUNT}, max ${MAX_PER_TEST_RUN_COUNT})`,
 );

 return Math.min(MAX_PER_TEST_RUN_COUNT, Math.max(expectedPerTestRunCount, MIN_PER_TEST_RUN_COUNT));
 }
Expand All@@ -128,22 +114,7 @@ function getTestPaths(): string[] {
 cwd: path.join(__dirname, '../'),
 });

 return paths.map(p => path.dirname(p));
}

function logError(error: unknown) {
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not used
 if (process.env.CI) {
 console.log('::group::Test failed');
 } else {
 console.error(' ⚠️ Test failed:');
 }

 console.log((error as any).stdout);
 console.log((error as any).stderr);

 if (process.env.CI) {
 console.log('::endgroup::');
 }
 return paths.map(p => `${path.dirname(p)}/`);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bit buggy - e.g. if one dirname was suites/tracing/metrics/web-vitals/test.ts, it would have made it to suites/tracing/metrics/web-vitals, which then in turn also matches e.g. web-vitals-cls etc. dirs. Now, it should be stricter in that regard.
}

/**
Expand All@@ -156,7 +127,7 @@ function logError(error: unknown) {
function getApproximateNumberOfTests(testPath: string): number {
 try {
 const content = fs.readFileSync(path.join(process.cwd(), testPath, 'test.ts'), 'utf-8');
 const matches = content.match(/it\(|test\(|sentryTest\(/g);
 const matches = content.match(/sentryTest\(/g);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always use sentryTest, so no need to check others here IMHO
 return Math.max(matches ? matches.length : 1, 1);
 } catch (e) {
 console.error(`Could not read file ${testPath}`);
Expand Down

2 changes: 1 addition & 1 deletion
...browser-integration-tests/suites/public-api/instrumentation/onError/syntax-errors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ sentryTest('should catch syntax errors', async ({ getLocalTestUrl, page, browser
 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'SyntaxError',
 value: "Unexpected token '{'",
 value: "Failed to execute 'appendChild' on 'Node': Unexpected token '{'",
 mechanism: {
 type: 'onerror',
 handled: false,
Expand Down

113 changes: 0 additions & 113 deletions
.../browser-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-0-snap-full

View file


Open in desktop


This file was deleted.


45 changes: 0 additions & 45 deletions
...r-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental

View file


Open in desktop


This file was deleted.


4 changes: 2 additions & 2 deletions
...tion-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental-chromium

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 "type": 1,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand All@@ -26,7 +26,7 @@
 "type": 0,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(deps): Update playwright to 1.50.0#15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 13 commits into

from

Jan 28, 2025
 Merged


chore(deps): Update playwright to 1.50.0
#15164
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
5d910a8

chore(deps): Update playwright to 1.50.0


mydea Jan 27, 2025
f29ffed

fix test


mydea Jan 27, 2025
ca2cdfb

fix tests


mydea Jan 27, 2025
96ca4fd

update snapshots ??


mydea Jan 27, 2025
f4b07f1

remove package stuff


mydea Jan 27, 2025
a7d87d6

small ref


mydea Jan 27, 2025
8001258

fix ci


mydea Jan 27, 2025
a74f633

FIXES


mydea Jan 27, 2025
3889554

fix it


mydea Jan 27, 2025
7aa9685

fix keepalive


mydea Jan 27, 2025
6cc0402

fix remaining firefox tests


mydea Jan 27, 2025
01bf194

merge tests


mydea Jan 27, 2025
aaac579

fix flaky test detector


mydea Jan 28, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -600,7 +600,7 @@ jobs:
 env:
 PW_BUNDLE: ${{ matrix.bundle }}
 working-directory: dev-packages/browser-integration-tests
 run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}
 run: yarn test:all${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}

 - name: Upload Playwright Traces
 uses: actions/upload-artifact@v4
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,13 +35,12 @@
 "test:loader:replay_buffer": "PW_BUNDLE=loader_replay_buffer yarn test:loader",
 "test:loader:full": "PW_BUNDLE=loader_tracing_replay yarn test:loader",
 "test:loader:debug": "PW_BUNDLE=loader_debug yarn test:loader",
 "test:ci": "yarn test:all",
 "test:update-snapshots": "yarn test:all --update-snapshots",
 "test:detect-flaky": "ts-node scripts/detectFlakyTests.ts"
 },
 "dependencies": {
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "^1.44.1",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.31.0",
 "@sentry/browser": "9.0.0-alpha.0",
 "axios": "1.7.7",
Expand Down

49 changes: 10 additions & 39 deletions
dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,14 +4,9 @@ import * as path from 'path';
import * as glob from 'glob';

/**
 * The number of browsers we run the tests in.
 * Assume that each test runs for 3s.
 */
const NUM_BROWSERS = 3;

/**
 * Assume that each test runs for 2s.
 */
const ASSUMED_TEST_DURATION_SECONDS = 2;
const ASSUMED_TEST_DURATION_SECONDS = 3;

/**
 * We keep the runtime of the detector if possible under 30min.
Expand DownExpand Up@@ -51,22 +46,12 @@ ${changedPaths.join('\n')}
 try {
 await new Promise<void>((resolve, reject) => {
 const cp = childProcess.spawn(
 `npx playwright test ${
 testPaths.length ? testPaths.join(' ') : './suites'
 } --reporter='line' --repeat-each ${repeatEachCount}`,
 { shell: true, cwd },
 `npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount}`,
 { shell: true, cwd, stdio: 'inherit' },
 );

 let error: Error | undefined;

 cp.stdout.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.stderr.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.on('error', e => {
 console.error(e);
 error = e;
Expand DownExpand Up@@ -107,15 +92,16 @@ function getPerTestRunCount(testPaths: string[]) {
 const estimatedNumberOfTests = testPaths.map(getApproximateNumberOfTests).reduce((a, b) => a + b);
 console.log(`Estimated number of tests: ${estimatedNumberOfTests}`);

 // tests are usually run against all browsers we test with, so let's assume this
 const testRunCount = estimatedNumberOfTests * NUM_BROWSERS;
 const testRunCount = estimatedNumberOfTests;
 console.log(`Estimated test runs for one round: ${testRunCount}`);

 const estimatedTestRuntime = testRunCount * ASSUMED_TEST_DURATION_SECONDS;
 console.log(`Estimated test runtime: ${estimatedTestRuntime}s`);

 const expectedPerTestRunCount = Math.floor(MAX_TARGET_TEST_RUNTIME_SECONDS / estimatedTestRuntime);
 console.log(`Expected per-test run count: ${expectedPerTestRunCount}`);
 console.log(
 `Calculated # of repetitions: ${expectedPerTestRunCount} (min ${MIN_PER_TEST_RUN_COUNT}, max ${MAX_PER_TEST_RUN_COUNT})`,
 );

 return Math.min(MAX_PER_TEST_RUN_COUNT, Math.max(expectedPerTestRunCount, MIN_PER_TEST_RUN_COUNT));
 }
Expand All@@ -128,22 +114,7 @@ function getTestPaths(): string[] {
 cwd: path.join(__dirname, '../'),
 });

 return paths.map(p => path.dirname(p));
}

function logError(error: unknown) {
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not used
 if (process.env.CI) {
 console.log('::group::Test failed');
 } else {
 console.error(' ⚠️ Test failed:');
 }

 console.log((error as any).stdout);
 console.log((error as any).stderr);

 if (process.env.CI) {
 console.log('::endgroup::');
 }
 return paths.map(p => `${path.dirname(p)}/`);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bit buggy - e.g. if one dirname was suites/tracing/metrics/web-vitals/test.ts, it would have made it to suites/tracing/metrics/web-vitals, which then in turn also matches e.g. web-vitals-cls etc. dirs. Now, it should be stricter in that regard.
}

/**
Expand All@@ -156,7 +127,7 @@ function logError(error: unknown) {
function getApproximateNumberOfTests(testPath: string): number {
 try {
 const content = fs.readFileSync(path.join(process.cwd(), testPath, 'test.ts'), 'utf-8');
 const matches = content.match(/it\(|test\(|sentryTest\(/g);
 const matches = content.match(/sentryTest\(/g);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always use sentryTest, so no need to check others here IMHO
 return Math.max(matches ? matches.length : 1, 1);
 } catch (e) {
 console.error(`Could not read file ${testPath}`);
Expand Down

2 changes: 1 addition & 1 deletion
...browser-integration-tests/suites/public-api/instrumentation/onError/syntax-errors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ sentryTest('should catch syntax errors', async ({ getLocalTestUrl, page, browser
 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'SyntaxError',
 value: "Unexpected token '{'",
 value: "Failed to execute 'appendChild' on 'Node': Unexpected token '{'",
 mechanism: {
 type: 'onerror',
 handled: false,
Expand Down

113 changes: 0 additions & 113 deletions
.../browser-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-0-snap-full

View file


Open in desktop


This file was deleted.


45 changes: 0 additions & 45 deletions
...r-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental

View file


Open in desktop


This file was deleted.


4 changes: 2 additions & 2 deletions
...tion-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental-chromium

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 "type": 1,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand All@@ -26,7 +26,7 @@
 "type": 0,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore(deps): Update playwright to 1.50.0#15164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

mydea
merged 13 commits into

from

Jan 28, 2025
 Merged


chore(deps): Update playwright to 1.50.0
#15164
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


13 commits


Select commit
Hold shift + click to select a range
5d910a8

chore(deps): Update playwright to 1.50.0


mydea Jan 27, 2025
f29ffed

fix test


mydea Jan 27, 2025
ca2cdfb

fix tests


mydea Jan 27, 2025
96ca4fd

update snapshots ??


mydea Jan 27, 2025
f4b07f1

remove package stuff


mydea Jan 27, 2025
a7d87d6

small ref


mydea Jan 27, 2025
8001258

fix ci


mydea Jan 27, 2025
a74f633

FIXES


mydea Jan 27, 2025
3889554

fix it


mydea Jan 27, 2025
7aa9685

fix keepalive


mydea Jan 27, 2025
6cc0402

fix remaining firefox tests


mydea Jan 27, 2025
01bf194

merge tests


mydea Jan 27, 2025
aaac579

fix flaky test detector


mydea Jan 28, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.github/workflows/build.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -600,7 +600,7 @@ jobs:
 env:
 PW_BUNDLE: ${{ matrix.bundle }}
 working-directory: dev-packages/browser-integration-tests
 run: yarn test:ci${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}
 run: yarn test:all${{ matrix.project && format(' --project={0}', matrix.project) || '' }}${{ matrix.shard && format(' --shard={0}/{1}', matrix.shard, matrix.shards) || '' }}

 - name: Upload Playwright Traces
 uses: actions/upload-artifact@v4
Expand Down

3 changes: 1 addition & 2 deletions
dev-packages/browser-integration-tests/package.json

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -35,13 +35,12 @@
 "test:loader:replay_buffer": "PW_BUNDLE=loader_replay_buffer yarn test:loader",
 "test:loader:full": "PW_BUNDLE=loader_tracing_replay yarn test:loader",
 "test:loader:debug": "PW_BUNDLE=loader_debug yarn test:loader",
 "test:ci": "yarn test:all",
 "test:update-snapshots": "yarn test:all --update-snapshots",
 "test:detect-flaky": "ts-node scripts/detectFlakyTests.ts"
 },
 "dependencies": {
 "@babel/preset-typescript": "^7.16.7",
 "@playwright/test": "^1.44.1",
 "@playwright/test": "~1.50.0",
 "@sentry-internal/rrweb": "2.31.0",
 "@sentry/browser": "9.0.0-alpha.0",
 "axios": "1.7.7",
Expand Down

49 changes: 10 additions & 39 deletions
dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,14 +4,9 @@ import * as path from 'path';
import * as glob from 'glob';

/**
 * The number of browsers we run the tests in.
 * Assume that each test runs for 3s.
 */
const NUM_BROWSERS = 3;

/**
 * Assume that each test runs for 2s.
 */
const ASSUMED_TEST_DURATION_SECONDS = 2;
const ASSUMED_TEST_DURATION_SECONDS = 3;

/**
 * We keep the runtime of the detector if possible under 30min.
Expand DownExpand Up@@ -51,22 +46,12 @@ ${changedPaths.join('\n')}
 try {
 await new Promise<void>((resolve, reject) => {
 const cp = childProcess.spawn(
 `npx playwright test ${
 testPaths.length ? testPaths.join(' ') : './suites'
 } --reporter='line' --repeat-each ${repeatEachCount}`,
 { shell: true, cwd },
 `npx playwright test ${testPaths.length ? testPaths.join(' ') : './suites'} --repeat-each ${repeatEachCount}`,
 { shell: true, cwd, stdio: 'inherit' },
 );

 let error: Error | undefined;

 cp.stdout.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.stderr.on('data', data => {
 console.log(data ? (data as object).toString() : '');
 });

 cp.on('error', e => {
 console.error(e);
 error = e;
Expand DownExpand Up@@ -107,15 +92,16 @@ function getPerTestRunCount(testPaths: string[]) {
 const estimatedNumberOfTests = testPaths.map(getApproximateNumberOfTests).reduce((a, b) => a + b);
 console.log(`Estimated number of tests: ${estimatedNumberOfTests}`);

 // tests are usually run against all browsers we test with, so let's assume this
 const testRunCount = estimatedNumberOfTests * NUM_BROWSERS;
 const testRunCount = estimatedNumberOfTests;
 console.log(`Estimated test runs for one round: ${testRunCount}`);

 const estimatedTestRuntime = testRunCount * ASSUMED_TEST_DURATION_SECONDS;
 console.log(`Estimated test runtime: ${estimatedTestRuntime}s`);

 const expectedPerTestRunCount = Math.floor(MAX_TARGET_TEST_RUNTIME_SECONDS / estimatedTestRuntime);
 console.log(`Expected per-test run count: ${expectedPerTestRunCount}`);
 console.log(
 `Calculated # of repetitions: ${expectedPerTestRunCount} (min ${MIN_PER_TEST_RUN_COUNT}, max ${MAX_PER_TEST_RUN_COUNT})`,
 );

 return Math.min(MAX_PER_TEST_RUN_COUNT, Math.max(expectedPerTestRunCount, MIN_PER_TEST_RUN_COUNT));
 }
Expand All@@ -128,22 +114,7 @@ function getTestPaths(): string[] {
 cwd: path.join(__dirname, '../'),
 });

 return paths.map(p => path.dirname(p));
}

function logError(error: unknown) {
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was not used
 if (process.env.CI) {
 console.log('::group::Test failed');
 } else {
 console.error(' ⚠️ Test failed:');
 }

 console.log((error as any).stdout);
 console.log((error as any).stderr);

 if (process.env.CI) {
 console.log('::endgroup::');
 }
 return paths.map(p => `${path.dirname(p)}/`);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bit buggy - e.g. if one dirname was suites/tracing/metrics/web-vitals/test.ts, it would have made it to suites/tracing/metrics/web-vitals, which then in turn also matches e.g. web-vitals-cls etc. dirs. Now, it should be stricter in that regard.
}

/**
Expand All@@ -156,7 +127,7 @@ function logError(error: unknown) {
function getApproximateNumberOfTests(testPath: string): number {
 try {
 const content = fs.readFileSync(path.join(process.cwd(), testPath, 'test.ts'), 'utf-8');
 const matches = content.match(/it\(|test\(|sentryTest\(/g);
 const matches = content.match(/sentryTest\(/g);
@mydeamydeaJan 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always use sentryTest, so no need to check others here IMHO
 return Math.max(matches ? matches.length : 1, 1);
 } catch (e) {
 console.error(`Could not read file ${testPath}`);
Expand Down

2 changes: 1 addition & 1 deletion
...browser-integration-tests/suites/public-api/instrumentation/onError/syntax-errors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ sentryTest('should catch syntax errors', async ({ getLocalTestUrl, page, browser
 expect(eventData.exception?.values).toHaveLength(1);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'SyntaxError',
 value: "Unexpected token '{'",
 value: "Failed to execute 'appendChild' on 'Node': Unexpected token '{'",
 mechanism: {
 type: 'onerror',
 handled: false,
Expand Down

113 changes: 0 additions & 113 deletions
.../browser-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-0-snap-full

View file


Open in desktop


This file was deleted.


45 changes: 0 additions & 45 deletions
...r-integration-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental

View file


Open in desktop


This file was deleted.


4 changes: 2 additions & 2 deletions
...tion-tests/suites/replay/multiple-pages/test.ts-snapshots/seg-1-snap-incremental-chromium

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6,7 +6,7 @@
 "type": 1,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand All@@ -26,7 +26,7 @@
 "type": 0,
 "id": 9,
 "x": 41.810001373291016,
 "y": 18.479999542236328
 "y": 18.5
 },
 "timestamp": [timestamp]
 },
Expand Down
Loading