Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -381,6 +381,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
Comment thread
billyvg marked this conversation as resolved.
continue-on-error: true
Comment thread
billyvg marked this conversation as resolved.
uses: codecov/test-results-action@v1
with:
Comment thread
billyvg marked this conversation as resolved.
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_bun_unit_tests:
name: Bun Unit Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -484,6 +492,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

Comment thread
billyvg marked this conversation as resolved.
- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_browser_playwright_tests:
name: Playwright ${{ matrix.bundle }}${{ matrix.project && matrix.project != 'chromium' && format(' {0}', matrix.project) || ''}}${{ matrix.shard && format(' ({0}/{1})', matrix.shard, matrix.shards) || ''}} Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -701,6 +717,14 @@ jobs:
working-directory: dev-packages/node-integration-tests
run: yarn test
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: dev-packages/node-integration-tests

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_remix_integration_tests:
name: Remix (Node ${{ matrix.node }}) Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -737,6 +761,14 @@ jobs:
cd packages/remix
yarn test:integration:ci
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: packages/remix

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_e2e_prepare:
name: Prepare E2E tests
# We want to run this if:
Expand Down
10 changes: 10 additions & 0 deletions jest/jest.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,16 @@ module.exports = {
...(process.env.CI
? {
coverageReporters: ['json', 'lcov', 'clover'],
reporters: [
'default',
[
Comment thread
billyvg marked this conversation as resolved.
'jest-junit',
{
Comment thread
billyvg marked this conversation as resolved.
outputName: 'jest.junit.xml',
classNameTemplate: '{filepath}',
},
],
],
}
: {}),
};
1 change: 1 addition & 0 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@
"eslint": "7.32.0",
"jest": "^27.5.1",
"jest-environment-node": "^27.5.1",
"jest-junit": "^16.0.0",
Comment thread
billyvg marked this conversation as resolved.
Comment thread
billyvg marked this conversation as resolved.
"jsdom": "^21.1.2",
"lerna": "7.1.1",
"madge": "7.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/angular/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ export default defineConfig({
coverage: {},
globals: true,
setupFiles: ['./setup-test.ts'],
reporters: ['default'],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'default' reporter was removed from some vitest configurations, but it might be beneficial to leave this for local development. If you're aiming to use Junit reporter on CI and default reporter locally, you might want to consider a conditionally loaded configuration based on the environment (development vs CI).

environment: 'jsdom',
},
});
1 change: 0 additions & 1 deletion packages/replay-internal/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,5 @@ export default defineConfig({
test: {
...baseConfig.test,
setupFiles: ['./test.setup.ts'],
reporters: ['default'],
},
});
4 changes: 4 additions & 0 deletions vite/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,10 @@ export default defineConfig({
enabled: true,
reportsDirectory: './coverage',
},
reporters: ['default', ...(process.env.CI ? [['junit', { classnameTemplate: '{filepath}' }]] : [])],
outputFile: {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the jest configurations and make sure that outputFile is a valid configuration option, as it's not recognized in the base jest configuration.

junit: 'vitest.junit.xml',
},
typecheck: {
tsconfig: './tsconfig.test.json',
},
Expand Down
15 changes: 15 additions & 0 deletions yarn.lock
Original file line numberDiff line numberDiff line change
Expand Up@@ -19066,6 +19066,16 @@ jest-jasmine2@^27.5.1:
pretty-format "^27.5.1"
throat "^6.0.1"

jest-junit@^16.0.0:
version "16.0.0"
resolved "https://registry.yarnpkg.com/jest-junit/-/jest-junit-16.0.0.tgz#d838e8c561cf9fdd7eb54f63020777eee4136785"
integrity sha512-A94mmw6NfJab4Fg/BlvVOUXzXgF0XIH6EmTgJ5NDPp4xoKq0Kr7sErb+4Xs9nZvu58pJojz5RFGpqnZYJTrRfQ==
dependencies:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the jest-junit package has introduced several new dependencies. Make sure these new dependancies do not cause conflicts with existing code or other packages.

mkdirp "^1.0.4"
strip-ansi "^6.0.1"
uuid "^8.3.2"
xml "^1.0.1"

jest-leak-detector@^27.5.1:
version "27.5.1"
resolved "https://registry.yarnpkg.com/jest-leak-detector/-/jest-leak-detector-27.5.1.tgz#6ec9d54c3579dd6e3e66d70e3498adf80fde3fb8"
Expand DownExpand Up@@ -30490,6 +30500,11 @@ xml-name-validator@^4.0.0:
resolved "https://registry.yarnpkg.com/xml-name-validator/-/xml-name-validator-4.0.0.tgz#79a006e2e63149a8600f15430f0a4725d1524835"
integrity sha512-ICP2e+jsHvAj2E2lIHxa5tjXRlKDJo4IdvPvCXbXQGdzSfmSpNVyIKMvoZHjDY9DP0zV17iI85o90vRFXNccRw==

xml@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/xml/-/xml-1.0.1.tgz#78ba72020029c5bc87b8a81a3cfcd74b4a2fc1e5"
integrity sha512-huCv9IH9Tcf95zuYCsQraZtWnJvBtLVE0QHMOs8bWyZAFZNDcYjsPq1nEx8jKA9y+Beo9v+7OBPRisQTjinQMw==

xmlchars@^2.2.0:
version "2.2.0"
resolved "https://registry.yarnpkg.com/xmlchars/-/xmlchars-2.2.0.tgz#060fe1bcb7f9c76fe2a17db86a9bc3ab894210cb"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -381,6 +381,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
Comment thread
billyvg marked this conversation as resolved.
continue-on-error: true
Comment thread
billyvg marked this conversation as resolved.
uses: codecov/test-results-action@v1
with:
Comment thread
billyvg marked this conversation as resolved.
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_bun_unit_tests:
name: Bun Unit Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -484,6 +492,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

Comment thread
billyvg marked this conversation as resolved.
- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_browser_playwright_tests:
name: Playwright ${{ matrix.bundle }}${{ matrix.project && matrix.project != 'chromium' && format(' {0}', matrix.project) || ''}}${{ matrix.shard && format(' ({0}/{1})', matrix.shard, matrix.shards) || ''}} Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -701,6 +717,14 @@ jobs:
working-directory: dev-packages/node-integration-tests
run: yarn test
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: dev-packages/node-integration-tests

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_remix_integration_tests:
name: Remix (Node ${{ matrix.node }}) Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -737,6 +761,14 @@ jobs:
cd packages/remix
yarn test:integration:ci
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: packages/remix

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_e2e_prepare:
name: Prepare E2E tests
# We want to run this if:
Expand Down
10 changes: 10 additions & 0 deletions jest/jest.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,16 @@ module.exports = {
...(process.env.CI
? {
coverageReporters: ['json', 'lcov', 'clover'],
reporters: [
'default',
[
Comment thread
billyvg marked this conversation as resolved.
'jest-junit',
{
Comment thread
billyvg marked this conversation as resolved.
outputName: 'jest.junit.xml',
classNameTemplate: '{filepath}',
},
],
],
}
: {}),
};
1 change: 1 addition & 0 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@
"eslint": "7.32.0",
"jest": "^27.5.1",
"jest-environment-node": "^27.5.1",
"jest-junit": "^16.0.0",
Comment thread
billyvg marked this conversation as resolved.
Comment thread
billyvg marked this conversation as resolved.
"jsdom": "^21.1.2",
"lerna": "7.1.1",
"madge": "7.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/angular/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ export default defineConfig({
coverage: {},
globals: true,
setupFiles: ['./setup-test.ts'],
reporters: ['default'],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'default' reporter was removed from some vitest configurations, but it might be beneficial to leave this for local development. If you're aiming to use Junit reporter on CI and default reporter locally, you might want to consider a conditionally loaded configuration based on the environment (development vs CI).

environment: 'jsdom',
},
});
1 change: 0 additions & 1 deletion packages/replay-internal/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,5 @@ export default defineConfig({
test: {
...baseConfig.test,
setupFiles: ['./test.setup.ts'],
reporters: ['default'],
},
});
4 changes: 4 additions & 0 deletions vite/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,10 @@ export default defineConfig({
enabled: true,
reportsDirectory: './coverage',
},
reporters: ['default', ...(process.env.CI ? [['junit', { classnameTemplate: '{filepath}' }]] : [])],
outputFile: {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the jest configurations and make sure that outputFile is a valid configuration option, as it's not recognized in the base jest configuration.

junit: 'vitest.junit.xml',
},
typecheck: {
tsconfig: './tsconfig.test.json',
},
Expand Down
15 changes: 15 additions & 0 deletions yarn.lock
Original file line numberDiff line numberDiff line change
Expand Up@@ -19066,6 +19066,16 @@ jest-jasmine2@^27.5.1:
pretty-format "^27.5.1"
throat "^6.0.1"

jest-junit@^16.0.0:
version "16.0.0"
resolved "https://registry.yarnpkg.com/jest-junit/-/jest-junit-16.0.0.tgz#d838e8c561cf9fdd7eb54f63020777eee4136785"
integrity sha512-A94mmw6NfJab4Fg/BlvVOUXzXgF0XIH6EmTgJ5NDPp4xoKq0Kr7sErb+4Xs9nZvu58pJojz5RFGpqnZYJTrRfQ==
dependencies:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the jest-junit package has introduced several new dependencies. Make sure these new dependancies do not cause conflicts with existing code or other packages.

mkdirp "^1.0.4"
strip-ansi "^6.0.1"
uuid "^8.3.2"
xml "^1.0.1"

jest-leak-detector@^27.5.1:
version "27.5.1"
resolved "https://registry.yarnpkg.com/jest-leak-detector/-/jest-leak-detector-27.5.1.tgz#6ec9d54c3579dd6e3e66d70e3498adf80fde3fb8"
Expand DownExpand Up@@ -30490,6 +30500,11 @@ xml-name-validator@^4.0.0:
resolved "https://registry.yarnpkg.com/xml-name-validator/-/xml-name-validator-4.0.0.tgz#79a006e2e63149a8600f15430f0a4725d1524835"
integrity sha512-ICP2e+jsHvAj2E2lIHxa5tjXRlKDJo4IdvPvCXbXQGdzSfmSpNVyIKMvoZHjDY9DP0zV17iI85o90vRFXNccRw==

xml@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/xml/-/xml-1.0.1.tgz#78ba72020029c5bc87b8a81a3cfcd74b4a2fc1e5"
integrity sha512-huCv9IH9Tcf95zuYCsQraZtWnJvBtLVE0QHMOs8bWyZAFZNDcYjsPq1nEx8jKA9y+Beo9v+7OBPRisQTjinQMw==

xmlchars@^2.2.0:
version "2.2.0"
resolved "https://registry.yarnpkg.com/xmlchars/-/xmlchars-2.2.0.tgz#060fe1bcb7f9c76fe2a17db86a9bc3ab894210cb"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -381,6 +381,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
Comment thread
billyvg marked this conversation as resolved.
continue-on-error: true
Comment thread
billyvg marked this conversation as resolved.
uses: codecov/test-results-action@v1
with:
Comment thread
billyvg marked this conversation as resolved.
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_bun_unit_tests:
name: Bun Unit Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -484,6 +492,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

Comment thread
billyvg marked this conversation as resolved.
- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_browser_playwright_tests:
name: Playwright ${{ matrix.bundle }}${{ matrix.project && matrix.project != 'chromium' && format(' {0}', matrix.project) || ''}}${{ matrix.shard && format(' ({0}/{1})', matrix.shard, matrix.shards) || ''}} Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -701,6 +717,14 @@ jobs:
working-directory: dev-packages/node-integration-tests
run: yarn test
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: dev-packages/node-integration-tests

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_remix_integration_tests:
name: Remix (Node ${{ matrix.node }}) Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -737,6 +761,14 @@ jobs:
cd packages/remix
yarn test:integration:ci
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: packages/remix

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_e2e_prepare:
name: Prepare E2E tests
# We want to run this if:
Expand Down
10 changes: 10 additions & 0 deletions jest/jest.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,16 @@ module.exports = {
...(process.env.CI
? {
coverageReporters: ['json', 'lcov', 'clover'],
reporters: [
'default',
[
Comment thread
billyvg marked this conversation as resolved.
'jest-junit',
{
Comment thread
billyvg marked this conversation as resolved.
outputName: 'jest.junit.xml',
classNameTemplate: '{filepath}',
},
],
],
}
: {}),
};
1 change: 1 addition & 0 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@
"eslint": "7.32.0",
"jest": "^27.5.1",
"jest-environment-node": "^27.5.1",
"jest-junit": "^16.0.0",
Comment thread
billyvg marked this conversation as resolved.
Comment thread
billyvg marked this conversation as resolved.
"jsdom": "^21.1.2",
"lerna": "7.1.1",
"madge": "7.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/angular/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ export default defineConfig({
coverage: {},
globals: true,
setupFiles: ['./setup-test.ts'],
reporters: ['default'],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'default' reporter was removed from some vitest configurations, but it might be beneficial to leave this for local development. If you're aiming to use Junit reporter on CI and default reporter locally, you might want to consider a conditionally loaded configuration based on the environment (development vs CI).

environment: 'jsdom',
},
});
1 change: 0 additions & 1 deletion packages/replay-internal/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,5 @@ export default defineConfig({
test: {
...baseConfig.test,
setupFiles: ['./test.setup.ts'],
reporters: ['default'],
},
});
4 changes: 4 additions & 0 deletions vite/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,10 @@ export default defineConfig({
enabled: true,
reportsDirectory: './coverage',
},
reporters: ['default', ...(process.env.CI ? [['junit', { classnameTemplate: '{filepath}' }]] : [])],
outputFile: {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the jest configurations and make sure that outputFile is a valid configuration option, as it's not recognized in the base jest configuration.

junit: 'vitest.junit.xml',
},
typecheck: {
tsconfig: './tsconfig.test.json',
},
Expand Down
15 changes: 15 additions & 0 deletions yarn.lock
Original file line numberDiff line numberDiff line change
Expand Up@@ -19066,6 +19066,16 @@ jest-jasmine2@^27.5.1:
pretty-format "^27.5.1"
throat "^6.0.1"

jest-junit@^16.0.0:
version "16.0.0"
resolved "https://registry.yarnpkg.com/jest-junit/-/jest-junit-16.0.0.tgz#d838e8c561cf9fdd7eb54f63020777eee4136785"
integrity sha512-A94mmw6NfJab4Fg/BlvVOUXzXgF0XIH6EmTgJ5NDPp4xoKq0Kr7sErb+4Xs9nZvu58pJojz5RFGpqnZYJTrRfQ==
dependencies:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the jest-junit package has introduced several new dependencies. Make sure these new dependancies do not cause conflicts with existing code or other packages.

mkdirp "^1.0.4"
strip-ansi "^6.0.1"
uuid "^8.3.2"
xml "^1.0.1"

jest-leak-detector@^27.5.1:
version "27.5.1"
resolved "https://registry.yarnpkg.com/jest-leak-detector/-/jest-leak-detector-27.5.1.tgz#6ec9d54c3579dd6e3e66d70e3498adf80fde3fb8"
Expand DownExpand Up@@ -30490,6 +30500,11 @@ xml-name-validator@^4.0.0:
resolved "https://registry.yarnpkg.com/xml-name-validator/-/xml-name-validator-4.0.0.tgz#79a006e2e63149a8600f15430f0a4725d1524835"
integrity sha512-ICP2e+jsHvAj2E2lIHxa5tjXRlKDJo4IdvPvCXbXQGdzSfmSpNVyIKMvoZHjDY9DP0zV17iI85o90vRFXNccRw==

xml@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/xml/-/xml-1.0.1.tgz#78ba72020029c5bc87b8a81a3cfcd74b4a2fc1e5"
integrity sha512-huCv9IH9Tcf95zuYCsQraZtWnJvBtLVE0QHMOs8bWyZAFZNDcYjsPq1nEx8jKA9y+Beo9v+7OBPRisQTjinQMw==

xmlchars@^2.2.0:
version "2.2.0"
resolved "https://registry.yarnpkg.com/xmlchars/-/xmlchars-2.2.0.tgz#060fe1bcb7f9c76fe2a17db86a9bc3ab894210cb"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -381,6 +381,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
Comment thread
billyvg marked this conversation as resolved.
continue-on-error: true
Comment thread
billyvg marked this conversation as resolved.
uses: codecov/test-results-action@v1
with:
Comment thread
billyvg marked this conversation as resolved.
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_bun_unit_tests:
name: Bun Unit Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -484,6 +492,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

Comment thread
billyvg marked this conversation as resolved.
- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_browser_playwright_tests:
name: Playwright ${{ matrix.bundle }}${{ matrix.project && matrix.project != 'chromium' && format(' {0}', matrix.project) || ''}}${{ matrix.shard && format(' ({0}/{1})', matrix.shard, matrix.shards) || ''}} Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -701,6 +717,14 @@ jobs:
working-directory: dev-packages/node-integration-tests
run: yarn test
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: dev-packages/node-integration-tests

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_remix_integration_tests:
name: Remix (Node ${{ matrix.node }}) Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -737,6 +761,14 @@ jobs:
cd packages/remix
yarn test:integration:ci
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: packages/remix

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_e2e_prepare:
name: Prepare E2E tests
# We want to run this if:
Expand Down
10 changes: 10 additions & 0 deletions jest/jest.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,16 @@ module.exports = {
...(process.env.CI
? {
coverageReporters: ['json', 'lcov', 'clover'],
reporters: [
'default',
[
Comment thread
billyvg marked this conversation as resolved.
'jest-junit',
{
Comment thread
billyvg marked this conversation as resolved.
outputName: 'jest.junit.xml',
classNameTemplate: '{filepath}',
},
],
],
}
: {}),
};
1 change: 1 addition & 0 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@
"eslint": "7.32.0",
"jest": "^27.5.1",
"jest-environment-node": "^27.5.1",
"jest-junit": "^16.0.0",
Comment thread
billyvg marked this conversation as resolved.
Comment thread
billyvg marked this conversation as resolved.
"jsdom": "^21.1.2",
"lerna": "7.1.1",
"madge": "7.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/angular/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ export default defineConfig({
coverage: {},
globals: true,
setupFiles: ['./setup-test.ts'],
reporters: ['default'],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'default' reporter was removed from some vitest configurations, but it might be beneficial to leave this for local development. If you're aiming to use Junit reporter on CI and default reporter locally, you might want to consider a conditionally loaded configuration based on the environment (development vs CI).

environment: 'jsdom',
},
});
1 change: 0 additions & 1 deletion packages/replay-internal/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,5 @@ export default defineConfig({
test: {
...baseConfig.test,
setupFiles: ['./test.setup.ts'],
reporters: ['default'],
},
});
4 changes: 4 additions & 0 deletions vite/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,10 @@ export default defineConfig({
enabled: true,
reportsDirectory: './coverage',
},
reporters: ['default', ...(process.env.CI ? [['junit', { classnameTemplate: '{filepath}' }]] : [])],
outputFile: {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the jest configurations and make sure that outputFile is a valid configuration option, as it's not recognized in the base jest configuration.

junit: 'vitest.junit.xml',
},
typecheck: {
tsconfig: './tsconfig.test.json',
},
Expand Down
15 changes: 15 additions & 0 deletions yarn.lock
Original file line numberDiff line numberDiff line change
Expand Up@@ -19066,6 +19066,16 @@ jest-jasmine2@^27.5.1:
pretty-format "^27.5.1"
throat "^6.0.1"

jest-junit@^16.0.0:
version "16.0.0"
resolved "https://registry.yarnpkg.com/jest-junit/-/jest-junit-16.0.0.tgz#d838e8c561cf9fdd7eb54f63020777eee4136785"
integrity sha512-A94mmw6NfJab4Fg/BlvVOUXzXgF0XIH6EmTgJ5NDPp4xoKq0Kr7sErb+4Xs9nZvu58pJojz5RFGpqnZYJTrRfQ==
dependencies:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the jest-junit package has introduced several new dependencies. Make sure these new dependancies do not cause conflicts with existing code or other packages.

mkdirp "^1.0.4"
strip-ansi "^6.0.1"
uuid "^8.3.2"
xml "^1.0.1"

jest-leak-detector@^27.5.1:
version "27.5.1"
resolved "https://registry.yarnpkg.com/jest-leak-detector/-/jest-leak-detector-27.5.1.tgz#6ec9d54c3579dd6e3e66d70e3498adf80fde3fb8"
Expand DownExpand Up@@ -30490,6 +30500,11 @@ xml-name-validator@^4.0.0:
resolved "https://registry.yarnpkg.com/xml-name-validator/-/xml-name-validator-4.0.0.tgz#79a006e2e63149a8600f15430f0a4725d1524835"
integrity sha512-ICP2e+jsHvAj2E2lIHxa5tjXRlKDJo4IdvPvCXbXQGdzSfmSpNVyIKMvoZHjDY9DP0zV17iI85o90vRFXNccRw==

xml@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/xml/-/xml-1.0.1.tgz#78ba72020029c5bc87b8a81a3cfcd74b4a2fc1e5"
integrity sha512-huCv9IH9Tcf95zuYCsQraZtWnJvBtLVE0QHMOs8bWyZAFZNDcYjsPq1nEx8jKA9y+Beo9v+7OBPRisQTjinQMw==

xmlchars@^2.2.0:
version "2.2.0"
resolved "https://registry.yarnpkg.com/xmlchars/-/xmlchars-2.2.0.tgz#060fe1bcb7f9c76fe2a17db86a9bc3ab894210cb"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -381,6 +381,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
Comment thread
billyvg marked this conversation as resolved.
continue-on-error: true
Comment thread
billyvg marked this conversation as resolved.
uses: codecov/test-results-action@v1
with:
Comment thread
billyvg marked this conversation as resolved.
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_bun_unit_tests:
name: Bun Unit Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -484,6 +492,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

Comment thread
billyvg marked this conversation as resolved.
- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_browser_playwright_tests:
name: Playwright ${{ matrix.bundle }}${{ matrix.project && matrix.project != 'chromium' && format(' {0}', matrix.project) || ''}}${{ matrix.shard && format(' ({0}/{1})', matrix.shard, matrix.shards) || ''}} Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -701,6 +717,14 @@ jobs:
working-directory: dev-packages/node-integration-tests
run: yarn test
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: dev-packages/node-integration-tests

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_remix_integration_tests:
name: Remix (Node ${{ matrix.node }}) Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -737,6 +761,14 @@ jobs:
cd packages/remix
yarn test:integration:ci
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: packages/remix

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_e2e_prepare:
name: Prepare E2E tests
# We want to run this if:
Expand Down
10 changes: 10 additions & 0 deletions jest/jest.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,16 @@ module.exports = {
...(process.env.CI
? {
coverageReporters: ['json', 'lcov', 'clover'],
reporters: [
'default',
[
Comment thread
billyvg marked this conversation as resolved.
'jest-junit',
{
Comment thread
billyvg marked this conversation as resolved.
outputName: 'jest.junit.xml',
classNameTemplate: '{filepath}',
},
],
],
}
: {}),
};
1 change: 1 addition & 0 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@
"eslint": "7.32.0",
"jest": "^27.5.1",
"jest-environment-node": "^27.5.1",
"jest-junit": "^16.0.0",
Comment thread
billyvg marked this conversation as resolved.
Comment thread
billyvg marked this conversation as resolved.
"jsdom": "^21.1.2",
"lerna": "7.1.1",
"madge": "7.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/angular/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ export default defineConfig({
coverage: {},
globals: true,
setupFiles: ['./setup-test.ts'],
reporters: ['default'],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'default' reporter was removed from some vitest configurations, but it might be beneficial to leave this for local development. If you're aiming to use Junit reporter on CI and default reporter locally, you might want to consider a conditionally loaded configuration based on the environment (development vs CI).

environment: 'jsdom',
},
});
1 change: 0 additions & 1 deletion packages/replay-internal/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,5 @@ export default defineConfig({
test: {
...baseConfig.test,
setupFiles: ['./test.setup.ts'],
reporters: ['default'],
},
});
4 changes: 4 additions & 0 deletions vite/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,10 @@ export default defineConfig({
enabled: true,
reportsDirectory: './coverage',
},
reporters: ['default', ...(process.env.CI ? [['junit', { classnameTemplate: '{filepath}' }]] : [])],
outputFile: {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the jest configurations and make sure that outputFile is a valid configuration option, as it's not recognized in the base jest configuration.

junit: 'vitest.junit.xml',
},
typecheck: {
tsconfig: './tsconfig.test.json',
},
Expand Down
15 changes: 15 additions & 0 deletions yarn.lock
Original file line numberDiff line numberDiff line change
Expand Up@@ -19066,6 +19066,16 @@ jest-jasmine2@^27.5.1:
pretty-format "^27.5.1"
throat "^6.0.1"

jest-junit@^16.0.0:
version "16.0.0"
resolved "https://registry.yarnpkg.com/jest-junit/-/jest-junit-16.0.0.tgz#d838e8c561cf9fdd7eb54f63020777eee4136785"
integrity sha512-A94mmw6NfJab4Fg/BlvVOUXzXgF0XIH6EmTgJ5NDPp4xoKq0Kr7sErb+4Xs9nZvu58pJojz5RFGpqnZYJTrRfQ==
dependencies:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the jest-junit package has introduced several new dependencies. Make sure these new dependancies do not cause conflicts with existing code or other packages.

mkdirp "^1.0.4"
strip-ansi "^6.0.1"
uuid "^8.3.2"
xml "^1.0.1"

jest-leak-detector@^27.5.1:
version "27.5.1"
resolved "https://registry.yarnpkg.com/jest-leak-detector/-/jest-leak-detector-27.5.1.tgz#6ec9d54c3579dd6e3e66d70e3498adf80fde3fb8"
Expand DownExpand Up@@ -30490,6 +30500,11 @@ xml-name-validator@^4.0.0:
resolved "https://registry.yarnpkg.com/xml-name-validator/-/xml-name-validator-4.0.0.tgz#79a006e2e63149a8600f15430f0a4725d1524835"
integrity sha512-ICP2e+jsHvAj2E2lIHxa5tjXRlKDJo4IdvPvCXbXQGdzSfmSpNVyIKMvoZHjDY9DP0zV17iI85o90vRFXNccRw==

xml@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/xml/-/xml-1.0.1.tgz#78ba72020029c5bc87b8a81a3cfcd74b4a2fc1e5"
integrity sha512-huCv9IH9Tcf95zuYCsQraZtWnJvBtLVE0QHMOs8bWyZAFZNDcYjsPq1nEx8jKA9y+Beo9v+7OBPRisQTjinQMw==

xmlchars@^2.2.0:
version "2.2.0"
resolved "https://registry.yarnpkg.com/xmlchars/-/xmlchars-2.2.0.tgz#060fe1bcb7f9c76fe2a17db86a9bc3ab894210cb"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -381,6 +381,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
Comment thread
billyvg marked this conversation as resolved.
continue-on-error: true
Comment thread
billyvg marked this conversation as resolved.
uses: codecov/test-results-action@v1
with:
Comment thread
billyvg marked this conversation as resolved.
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_bun_unit_tests:
name: Bun Unit Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -484,6 +492,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

Comment thread
billyvg marked this conversation as resolved.
- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_browser_playwright_tests:
name: Playwright ${{ matrix.bundle }}${{ matrix.project && matrix.project != 'chromium' && format(' {0}', matrix.project) || ''}}${{ matrix.shard && format(' ({0}/{1})', matrix.shard, matrix.shards) || ''}} Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -701,6 +717,14 @@ jobs:
working-directory: dev-packages/node-integration-tests
run: yarn test
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: dev-packages/node-integration-tests

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_remix_integration_tests:
name: Remix (Node ${{ matrix.node }}) Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -737,6 +761,14 @@ jobs:
cd packages/remix
yarn test:integration:ci
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: packages/remix

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_e2e_prepare:
name: Prepare E2E tests
# We want to run this if:
Expand Down
10 changes: 10 additions & 0 deletions jest/jest.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,16 @@ module.exports = {
...(process.env.CI
? {
coverageReporters: ['json', 'lcov', 'clover'],
reporters: [
'default',
[
Comment thread
billyvg marked this conversation as resolved.
'jest-junit',
{
Comment thread
billyvg marked this conversation as resolved.
outputName: 'jest.junit.xml',
classNameTemplate: '{filepath}',
},
],
],
}
: {}),
};
1 change: 1 addition & 0 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@
"eslint": "7.32.0",
"jest": "^27.5.1",
"jest-environment-node": "^27.5.1",
"jest-junit": "^16.0.0",
Comment thread
billyvg marked this conversation as resolved.
Comment thread
billyvg marked this conversation as resolved.
"jsdom": "^21.1.2",
"lerna": "7.1.1",
"madge": "7.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/angular/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ export default defineConfig({
coverage: {},
globals: true,
setupFiles: ['./setup-test.ts'],
reporters: ['default'],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'default' reporter was removed from some vitest configurations, but it might be beneficial to leave this for local development. If you're aiming to use Junit reporter on CI and default reporter locally, you might want to consider a conditionally loaded configuration based on the environment (development vs CI).

environment: 'jsdom',
},
});
1 change: 0 additions & 1 deletion packages/replay-internal/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,5 @@ export default defineConfig({
test: {
...baseConfig.test,
setupFiles: ['./test.setup.ts'],
reporters: ['default'],
},
});
4 changes: 4 additions & 0 deletions vite/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,10 @@ export default defineConfig({
enabled: true,
reportsDirectory: './coverage',
},
reporters: ['default', ...(process.env.CI ? [['junit', { classnameTemplate: '{filepath}' }]] : [])],
outputFile: {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the jest configurations and make sure that outputFile is a valid configuration option, as it's not recognized in the base jest configuration.

junit: 'vitest.junit.xml',
},
typecheck: {
tsconfig: './tsconfig.test.json',
},
Expand Down
15 changes: 15 additions & 0 deletions yarn.lock
Original file line numberDiff line numberDiff line change
Expand Up@@ -19066,6 +19066,16 @@ jest-jasmine2@^27.5.1:
pretty-format "^27.5.1"
throat "^6.0.1"

jest-junit@^16.0.0:
version "16.0.0"
resolved "https://registry.yarnpkg.com/jest-junit/-/jest-junit-16.0.0.tgz#d838e8c561cf9fdd7eb54f63020777eee4136785"
integrity sha512-A94mmw6NfJab4Fg/BlvVOUXzXgF0XIH6EmTgJ5NDPp4xoKq0Kr7sErb+4Xs9nZvu58pJojz5RFGpqnZYJTrRfQ==
dependencies:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the jest-junit package has introduced several new dependencies. Make sure these new dependancies do not cause conflicts with existing code or other packages.

mkdirp "^1.0.4"
strip-ansi "^6.0.1"
uuid "^8.3.2"
xml "^1.0.1"

jest-leak-detector@^27.5.1:
version "27.5.1"
resolved "https://registry.yarnpkg.com/jest-leak-detector/-/jest-leak-detector-27.5.1.tgz#6ec9d54c3579dd6e3e66d70e3498adf80fde3fb8"
Expand DownExpand Up@@ -30490,6 +30500,11 @@ xml-name-validator@^4.0.0:
resolved "https://registry.yarnpkg.com/xml-name-validator/-/xml-name-validator-4.0.0.tgz#79a006e2e63149a8600f15430f0a4725d1524835"
integrity sha512-ICP2e+jsHvAj2E2lIHxa5tjXRlKDJo4IdvPvCXbXQGdzSfmSpNVyIKMvoZHjDY9DP0zV17iI85o90vRFXNccRw==

xml@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/xml/-/xml-1.0.1.tgz#78ba72020029c5bc87b8a81a3cfcd74b4a2fc1e5"
integrity sha512-huCv9IH9Tcf95zuYCsQraZtWnJvBtLVE0QHMOs8bWyZAFZNDcYjsPq1nEx8jKA9y+Beo9v+7OBPRisQTjinQMw==

xmlchars@^2.2.0:
version "2.2.0"
resolved "https://registry.yarnpkg.com/xmlchars/-/xmlchars-2.2.0.tgz#060fe1bcb7f9c76fe2a17db86a9bc3ab894210cb"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -381,6 +381,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
Comment thread
billyvg marked this conversation as resolved.
continue-on-error: true
Comment thread
billyvg marked this conversation as resolved.
uses: codecov/test-results-action@v1
with:
Comment thread
billyvg marked this conversation as resolved.
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_bun_unit_tests:
name: Bun Unit Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -484,6 +492,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

Comment thread
billyvg marked this conversation as resolved.
- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_browser_playwright_tests:
name: Playwright ${{ matrix.bundle }}${{ matrix.project && matrix.project != 'chromium' && format(' {0}', matrix.project) || ''}}${{ matrix.shard && format(' ({0}/{1})', matrix.shard, matrix.shards) || ''}} Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -701,6 +717,14 @@ jobs:
working-directory: dev-packages/node-integration-tests
run: yarn test
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: dev-packages/node-integration-tests

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_remix_integration_tests:
name: Remix (Node ${{ matrix.node }}) Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -737,6 +761,14 @@ jobs:
cd packages/remix
yarn test:integration:ci
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: packages/remix

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_e2e_prepare:
name: Prepare E2E tests
# We want to run this if:
Expand Down
10 changes: 10 additions & 0 deletions jest/jest.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,16 @@ module.exports = {
...(process.env.CI
? {
coverageReporters: ['json', 'lcov', 'clover'],
reporters: [
'default',
[
Comment thread
billyvg marked this conversation as resolved.
'jest-junit',
{
Comment thread
billyvg marked this conversation as resolved.
outputName: 'jest.junit.xml',
classNameTemplate: '{filepath}',
},
],
],
}
: {}),
};
1 change: 1 addition & 0 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@
"eslint": "7.32.0",
"jest": "^27.5.1",
"jest-environment-node": "^27.5.1",
"jest-junit": "^16.0.0",
Comment thread
billyvg marked this conversation as resolved.
Comment thread
billyvg marked this conversation as resolved.
"jsdom": "^21.1.2",
"lerna": "7.1.1",
"madge": "7.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/angular/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ export default defineConfig({
coverage: {},
globals: true,
setupFiles: ['./setup-test.ts'],
reporters: ['default'],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'default' reporter was removed from some vitest configurations, but it might be beneficial to leave this for local development. If you're aiming to use Junit reporter on CI and default reporter locally, you might want to consider a conditionally loaded configuration based on the environment (development vs CI).

environment: 'jsdom',
},
});
1 change: 0 additions & 1 deletion packages/replay-internal/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,5 @@ export default defineConfig({
test: {
...baseConfig.test,
setupFiles: ['./test.setup.ts'],
reporters: ['default'],
},
});
4 changes: 4 additions & 0 deletions vite/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,10 @@ export default defineConfig({
enabled: true,
reportsDirectory: './coverage',
},
reporters: ['default', ...(process.env.CI ? [['junit', { classnameTemplate: '{filepath}' }]] : [])],
outputFile: {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the jest configurations and make sure that outputFile is a valid configuration option, as it's not recognized in the base jest configuration.

junit: 'vitest.junit.xml',
},
typecheck: {
tsconfig: './tsconfig.test.json',
},
Expand Down
15 changes: 15 additions & 0 deletions yarn.lock
Original file line numberDiff line numberDiff line change
Expand Up@@ -19066,6 +19066,16 @@ jest-jasmine2@^27.5.1:
pretty-format "^27.5.1"
throat "^6.0.1"

jest-junit@^16.0.0:
version "16.0.0"
resolved "https://registry.yarnpkg.com/jest-junit/-/jest-junit-16.0.0.tgz#d838e8c561cf9fdd7eb54f63020777eee4136785"
integrity sha512-A94mmw6NfJab4Fg/BlvVOUXzXgF0XIH6EmTgJ5NDPp4xoKq0Kr7sErb+4Xs9nZvu58pJojz5RFGpqnZYJTrRfQ==
dependencies:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the jest-junit package has introduced several new dependencies. Make sure these new dependancies do not cause conflicts with existing code or other packages.

mkdirp "^1.0.4"
strip-ansi "^6.0.1"
uuid "^8.3.2"
xml "^1.0.1"

jest-leak-detector@^27.5.1:
version "27.5.1"
resolved "https://registry.yarnpkg.com/jest-leak-detector/-/jest-leak-detector-27.5.1.tgz#6ec9d54c3579dd6e3e66d70e3498adf80fde3fb8"
Expand DownExpand Up@@ -30490,6 +30500,11 @@ xml-name-validator@^4.0.0:
resolved "https://registry.yarnpkg.com/xml-name-validator/-/xml-name-validator-4.0.0.tgz#79a006e2e63149a8600f15430f0a4725d1524835"
integrity sha512-ICP2e+jsHvAj2E2lIHxa5tjXRlKDJo4IdvPvCXbXQGdzSfmSpNVyIKMvoZHjDY9DP0zV17iI85o90vRFXNccRw==

xml@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/xml/-/xml-1.0.1.tgz#78ba72020029c5bc87b8a81a3cfcd74b4a2fc1e5"
integrity sha512-huCv9IH9Tcf95zuYCsQraZtWnJvBtLVE0QHMOs8bWyZAFZNDcYjsPq1nEx8jKA9y+Beo9v+7OBPRisQTjinQMw==

xmlchars@^2.2.0:
version "2.2.0"
resolved "https://registry.yarnpkg.com/xmlchars/-/xmlchars-2.2.0.tgz#060fe1bcb7f9c76fe2a17db86a9bc3ab894210cb"
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/build.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -381,6 +381,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
Comment thread
billyvg marked this conversation as resolved.
continue-on-error: true
Comment thread
billyvg marked this conversation as resolved.
uses: codecov/test-results-action@v1
with:
Comment thread
billyvg marked this conversation as resolved.
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_bun_unit_tests:
name: Bun Unit Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -484,6 +492,14 @@ jobs:
with:
token: ${{ secrets.CODECOV_TOKEN }}

Comment thread
billyvg marked this conversation as resolved.
- name: Upload test results to Codecov
Comment thread
billyvg marked this conversation as resolved.
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
files: packages/**/*.junit.xml

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_browser_playwright_tests:
name: Playwright ${{ matrix.bundle }}${{ matrix.project && matrix.project != 'chromium' && format(' {0}', matrix.project) || ''}}${{ matrix.shard && format(' ({0}/{1})', matrix.shard, matrix.shards) || ''}} Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -701,6 +717,14 @@ jobs:
working-directory: dev-packages/node-integration-tests
run: yarn test
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: dev-packages/node-integration-tests

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_remix_integration_tests:
name: Remix (Node ${{ matrix.node }}) Tests
needs: [job_get_metadata, job_build]
Expand DownExpand Up@@ -737,6 +761,14 @@ jobs:
cd packages/remix
yarn test:integration:ci
Comment thread
billyvg marked this conversation as resolved.

- name: Upload test results to Codecov
if: cancelled() == false
continue-on-error: true
uses: codecov/test-results-action@v1
with:
directory: packages/remix

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token: ${{ secrets.CODECOV_TOKEN }}

job_e2e_prepare:
name: Prepare E2E tests
# We want to run this if:
Expand Down
10 changes: 10 additions & 0 deletions jest/jest.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,16 @@ module.exports = {
...(process.env.CI
? {
coverageReporters: ['json', 'lcov', 'clover'],
reporters: [
'default',
[
Comment thread
billyvg marked this conversation as resolved.
'jest-junit',
{
Comment thread
billyvg marked this conversation as resolved.
outputName: 'jest.junit.xml',
classNameTemplate: '{filepath}',
},
],
],
}
: {}),
};
1 change: 1 addition & 0 deletions package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,7 @@
"eslint": "7.32.0",
"jest": "^27.5.1",
"jest-environment-node": "^27.5.1",
"jest-junit": "^16.0.0",
Comment thread
billyvg marked this conversation as resolved.
Comment thread
billyvg marked this conversation as resolved.
"jsdom": "^21.1.2",
"lerna": "7.1.1",
"madge": "7.0.0",
Expand Down
1 change: 0 additions & 1 deletion packages/angular/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ export default defineConfig({
coverage: {},
globals: true,
setupFiles: ['./setup-test.ts'],
reporters: ['default'],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'default' reporter was removed from some vitest configurations, but it might be beneficial to leave this for local development. If you're aiming to use Junit reporter on CI and default reporter locally, you might want to consider a conditionally loaded configuration based on the environment (development vs CI).

environment: 'jsdom',
},
});
1 change: 0 additions & 1 deletion packages/replay-internal/vitest.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,6 +7,5 @@ export default defineConfig({
test: {
...baseConfig.test,
setupFiles: ['./test.setup.ts'],
reporters: ['default'],
},
});
4 changes: 4 additions & 0 deletions vite/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,10 @@ export default defineConfig({
enabled: true,
reportsDirectory: './coverage',
},
reporters: ['default', ...(process.env.CI ? [['junit', { classnameTemplate: '{filepath}' }]] : [])],
outputFile: {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check the jest configurations and make sure that outputFile is a valid configuration option, as it's not recognized in the base jest configuration.

junit: 'vitest.junit.xml',
},
typecheck: {
tsconfig: './tsconfig.test.json',
},
Expand Down
15 changes: 15 additions & 0 deletions yarn.lock
Original file line numberDiff line numberDiff line change
Expand Up@@ -19066,6 +19066,16 @@ jest-jasmine2@^27.5.1:
pretty-format "^27.5.1"
throat "^6.0.1"

jest-junit@^16.0.0:
version "16.0.0"
resolved "https://registry.yarnpkg.com/jest-junit/-/jest-junit-16.0.0.tgz#d838e8c561cf9fdd7eb54f63020777eee4136785"
integrity sha512-A94mmw6NfJab4Fg/BlvVOUXzXgF0XIH6EmTgJ5NDPp4xoKq0Kr7sErb+4Xs9nZvu58pJojz5RFGpqnZYJTrRfQ==
dependencies:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of the jest-junit package has introduced several new dependencies. Make sure these new dependancies do not cause conflicts with existing code or other packages.

mkdirp "^1.0.4"
strip-ansi "^6.0.1"
uuid "^8.3.2"
xml "^1.0.1"

jest-leak-detector@^27.5.1:
version "27.5.1"
resolved "https://registry.yarnpkg.com/jest-leak-detector/-/jest-leak-detector-27.5.1.tgz#6ec9d54c3579dd6e3e66d70e3498adf80fde3fb8"
Expand DownExpand Up@@ -30490,6 +30500,11 @@ xml-name-validator@^4.0.0:
resolved "https://registry.yarnpkg.com/xml-name-validator/-/xml-name-validator-4.0.0.tgz#79a006e2e63149a8600f15430f0a4725d1524835"
integrity sha512-ICP2e+jsHvAj2E2lIHxa5tjXRlKDJo4IdvPvCXbXQGdzSfmSpNVyIKMvoZHjDY9DP0zV17iI85o90vRFXNccRw==

xml@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/xml/-/xml-1.0.1.tgz#78ba72020029c5bc87b8a81a3cfcd74b4a2fc1e5"
integrity sha512-huCv9IH9Tcf95zuYCsQraZtWnJvBtLVE0QHMOs8bWyZAFZNDcYjsPq1nEx8jKA9y+Beo9v+7OBPRisQTjinQMw==

xmlchars@^2.2.0:
version "2.2.0"
resolved "https://registry.yarnpkg.com/xmlchars/-/xmlchars-2.2.0.tgz#060fe1bcb7f9c76fe2a17db86a9bc3ab894210cb"
Expand Down