feat(node): Support Express v5 - #15380

Merged
AbhiPrasad merged 6 commits into
developfrom
timfish/feat/express-v5
Feb 20, 2025
Merged

feat(node): Support Express v5#15380
AbhiPrasad merged 6 commits into
developfrom
timfish/feat/express-v5

Conversation

@timfish

@timfishtimfish commented Feb 12, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

The goal is for Express to eventually support publishing events to diagnostics_channel (#15107) so that Open Telemetry can instrument it without monkey-patching internal code. However, this might take a while and it would be great to support Express v5 now. This PR is a stop-gap solution until that work is complete and published.

This PR vendors the code added in my otel PR:

@lforst
lforst self-requested a review February 12, 2025 10:23
@codecov

codecovBot commented Feb 12, 2025•
edited
Loading

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completedFailedPassedSkipped
15271152618
View the top 1 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.tsshouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
Stack Traces | 4.11s run time
root-loader.test.ts:165:1shouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions

github-actionsBot commented Feb 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser22.95 KB--
@sentry/browser - with treeshaking flags22.73 KB--
@sentry/browser (incl. Tracing)35.89 KB--
@sentry/browser (incl. Tracing, Replay)72.88 KB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags66.39 KB--
@sentry/browser (incl. Tracing, Replay with Canvas)77.13 KB--
@sentry/browser (incl. Tracing, Replay, Feedback)90.09 KB--
@sentry/browser (incl. Feedback)40.1 KB--
@sentry/browser (incl. sendFeedback)27.58 KB--
@sentry/browser (incl. FeedbackAsync)32.38 KB--
@sentry/react24.78 KB--
@sentry/react (incl. Tracing)37.78 KB--
@sentry/vue27.14 KB--
@sentry/vue (incl. Tracing)37.6 KB--
@sentry/svelte22.99 KB--
CDN Bundle24.17 KB--
CDN Bundle (incl. Tracing)35.93 KB--
CDN Bundle (incl. Tracing, Replay)70.75 KB--
CDN Bundle (incl. Tracing, Replay, Feedback)75.91 KB--
CDN Bundle - uncompressed70.64 KB--
CDN Bundle (incl. Tracing) - uncompressed106.74 KB--
CDN Bundle (incl. Tracing, Replay) - uncompressed217.95 KB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed230.52 KB--
@sentry/nextjs (client)38.76 KB--
@sentry/sveltekit (client)36.32 KB--
@sentry/node129.13 KB+1.2%+1.52 KB 🔺
@sentry/node - without tracing97.9 KB--
@sentry/aws-serverless107.34 KB-0.01%-1 B 🔽

View base workflow run

@timfish
timfish marked this pull request as ready for review February 12, 2025 21:30
@AbhiPrasad
AbhiPrasad merged commit 1aa5bbe into developFeb 20, 2025
@AbhiPrasad
AbhiPrasad deleted the timfish/feat/express-v5 branch February 20, 2025 16:50
@github-actionsgithub-actionsBot mentioned this pull request Feb 24, 2025
Closed
@Burgov

Burgov commented Apr 4, 2025

Copy link
Copy Markdown

Should the documentation be updated? https://docs.sentry.io/platforms/javascript/guides/express/ still mentions limited support

@AbhiPrasad

AbhiPrasad commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

@Burgov good catch! I made a PR to fix this in the docs: getsentry/sentry-docs#13240

@timfishtimfish mentioned this pull request Apr 11, 2025
Closed
@mohan82mohan82 mentioned this pull request Apr 24, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lforstlforstAwaiting requested review from lforst
@chargomechargomeAwaiting requested review from chargome
1 more reviewer
@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Express v5

3 participants

@timfish@Burgov@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(node): Support Express v5 - #15380
Merged
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Feb 20, 2025
Merged
feat(node): Support Express v5#15380
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Conversation
@timfish
@timfishtimfish
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
The goal is for Express to eventually support publishing events to diagnostics_channel (#15107) so that Open Telemetry can instrument it without monkey-patching internal code. However, this might take a while and it would be great to support Express v5 now. This PR is a stop-gap solution until that work is complete and published.
This PR vendors the code added in my otel PR:
@lforst
lforst
self-requested a review
February 12, 2025 10:23
@codecov
codecovBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
15271152618
View the top 1 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.tsshouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
Stack Traces | 4.11s run time
root-loader.test.ts:165:1shouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
@github-actions
github-actionsBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser22.95 KB--
@sentry/browser - with treeshaking flags22.73 KB--
@sentry/browser (incl. Tracing)35.89 KB--
@sentry/browser (incl. Tracing, Replay)72.88 KB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags66.39 KB--
@sentry/browser (incl. Tracing, Replay with Canvas)77.13 KB--
@sentry/browser (incl. Tracing, Replay, Feedback)90.09 KB--
@sentry/browser (incl. Feedback)40.1 KB--
@sentry/browser (incl. sendFeedback)27.58 KB--
@sentry/browser (incl. FeedbackAsync)32.38 KB--
@sentry/react24.78 KB--
@sentry/react (incl. Tracing)37.78 KB--
@sentry/vue27.14 KB--
@sentry/vue (incl. Tracing)37.6 KB--
@sentry/svelte22.99 KB--
CDN Bundle24.17 KB--
CDN Bundle (incl. Tracing)35.93 KB--
CDN Bundle (incl. Tracing, Replay)70.75 KB--
CDN Bundle (incl. Tracing, Replay, Feedback)75.91 KB--
CDN Bundle - uncompressed70.64 KB--
CDN Bundle (incl. Tracing) - uncompressed106.74 KB--
CDN Bundle (incl. Tracing, Replay) - uncompressed217.95 KB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed230.52 KB--
@sentry/nextjs (client)38.76 KB--
@sentry/sveltekit (client)36.32 KB--
@sentry/node129.13 KB+1.2%+1.52 KB 🔺
@sentry/node - without tracing97.9 KB--
@sentry/aws-serverless107.34 KB-0.01%-1 B 🔽
View base workflow run
@timfish
timfish
marked this pull request as ready for review
February 12, 2025 21:30
@AbhiPrasad
AbhiPrasad
merged commit 1aa5bbe
into
developFeb 20, 2025
@AbhiPrasad
AbhiPrasad
deleted the

timfish/feat/express-v5

branch
February 20, 2025 16:50
@github-actionsgithub-actionsBot
mentioned this pull request
Feb 24, 2025

Closed

@Burgov
Burgov
commented
Apr 4, 2025

Copy link


Copy Markdown

Should the documentation be updated? https://docs.sentry.io/platforms/javascript/guides/express/ still mentions limited support
@AbhiPrasad
AbhiPrasad
commented
Apr 4, 2025

Copy link


Copy Markdown

Contributor
@Burgov good catch! I made a PR to fix this in the docs: getsentry/sentry-docs#13240
@timfishtimfish
mentioned this pull request
Apr 11, 2025
 Closed

@mohan82mohan82
mentioned this pull request
Apr 24, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lforstlforstAwaiting requested review from lforst
@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support Express v5


3 participants

@timfish@Burgov@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(node): Support Express v5 - #15380
Merged
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Feb 20, 2025
Merged
feat(node): Support Express v5#15380
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Conversation
@timfish
@timfishtimfish
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
The goal is for Express to eventually support publishing events to diagnostics_channel (#15107) so that Open Telemetry can instrument it without monkey-patching internal code. However, this might take a while and it would be great to support Express v5 now. This PR is a stop-gap solution until that work is complete and published.
This PR vendors the code added in my otel PR:
@lforst
lforst
self-requested a review
February 12, 2025 10:23
@codecov
codecovBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
15271152618
View the top 1 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.tsshouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
Stack Traces | 4.11s run time
root-loader.test.ts:165:1shouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
@github-actions
github-actionsBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser22.95 KB--
@sentry/browser - with treeshaking flags22.73 KB--
@sentry/browser (incl. Tracing)35.89 KB--
@sentry/browser (incl. Tracing, Replay)72.88 KB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags66.39 KB--
@sentry/browser (incl. Tracing, Replay with Canvas)77.13 KB--
@sentry/browser (incl. Tracing, Replay, Feedback)90.09 KB--
@sentry/browser (incl. Feedback)40.1 KB--
@sentry/browser (incl. sendFeedback)27.58 KB--
@sentry/browser (incl. FeedbackAsync)32.38 KB--
@sentry/react24.78 KB--
@sentry/react (incl. Tracing)37.78 KB--
@sentry/vue27.14 KB--
@sentry/vue (incl. Tracing)37.6 KB--
@sentry/svelte22.99 KB--
CDN Bundle24.17 KB--
CDN Bundle (incl. Tracing)35.93 KB--
CDN Bundle (incl. Tracing, Replay)70.75 KB--
CDN Bundle (incl. Tracing, Replay, Feedback)75.91 KB--
CDN Bundle - uncompressed70.64 KB--
CDN Bundle (incl. Tracing) - uncompressed106.74 KB--
CDN Bundle (incl. Tracing, Replay) - uncompressed217.95 KB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed230.52 KB--
@sentry/nextjs (client)38.76 KB--
@sentry/sveltekit (client)36.32 KB--
@sentry/node129.13 KB+1.2%+1.52 KB 🔺
@sentry/node - without tracing97.9 KB--
@sentry/aws-serverless107.34 KB-0.01%-1 B 🔽
View base workflow run
@timfish
timfish
marked this pull request as ready for review
February 12, 2025 21:30
@AbhiPrasad
AbhiPrasad
merged commit 1aa5bbe
into
developFeb 20, 2025
@AbhiPrasad
AbhiPrasad
deleted the

timfish/feat/express-v5

branch
February 20, 2025 16:50
@github-actionsgithub-actionsBot
mentioned this pull request
Feb 24, 2025

Closed

@Burgov
Burgov
commented
Apr 4, 2025

Copy link


Copy Markdown

Should the documentation be updated? https://docs.sentry.io/platforms/javascript/guides/express/ still mentions limited support
@AbhiPrasad
AbhiPrasad
commented
Apr 4, 2025

Copy link


Copy Markdown

Contributor
@Burgov good catch! I made a PR to fix this in the docs: getsentry/sentry-docs#13240
@timfishtimfish
mentioned this pull request
Apr 11, 2025
 Closed

@mohan82mohan82
mentioned this pull request
Apr 24, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lforstlforstAwaiting requested review from lforst
@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support Express v5


3 participants

@timfish@Burgov@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(node): Support Express v5 - #15380
Merged
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Feb 20, 2025
Merged
feat(node): Support Express v5#15380
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Conversation
@timfish
@timfishtimfish
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
The goal is for Express to eventually support publishing events to diagnostics_channel (#15107) so that Open Telemetry can instrument it without monkey-patching internal code. However, this might take a while and it would be great to support Express v5 now. This PR is a stop-gap solution until that work is complete and published.
This PR vendors the code added in my otel PR:
@lforst
lforst
self-requested a review
February 12, 2025 10:23
@codecov
codecovBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
15271152618
View the top 1 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.tsshouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
Stack Traces | 4.11s run time
root-loader.test.ts:165:1shouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
@github-actions
github-actionsBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser22.95 KB--
@sentry/browser - with treeshaking flags22.73 KB--
@sentry/browser (incl. Tracing)35.89 KB--
@sentry/browser (incl. Tracing, Replay)72.88 KB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags66.39 KB--
@sentry/browser (incl. Tracing, Replay with Canvas)77.13 KB--
@sentry/browser (incl. Tracing, Replay, Feedback)90.09 KB--
@sentry/browser (incl. Feedback)40.1 KB--
@sentry/browser (incl. sendFeedback)27.58 KB--
@sentry/browser (incl. FeedbackAsync)32.38 KB--
@sentry/react24.78 KB--
@sentry/react (incl. Tracing)37.78 KB--
@sentry/vue27.14 KB--
@sentry/vue (incl. Tracing)37.6 KB--
@sentry/svelte22.99 KB--
CDN Bundle24.17 KB--
CDN Bundle (incl. Tracing)35.93 KB--
CDN Bundle (incl. Tracing, Replay)70.75 KB--
CDN Bundle (incl. Tracing, Replay, Feedback)75.91 KB--
CDN Bundle - uncompressed70.64 KB--
CDN Bundle (incl. Tracing) - uncompressed106.74 KB--
CDN Bundle (incl. Tracing, Replay) - uncompressed217.95 KB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed230.52 KB--
@sentry/nextjs (client)38.76 KB--
@sentry/sveltekit (client)36.32 KB--
@sentry/node129.13 KB+1.2%+1.52 KB 🔺
@sentry/node - without tracing97.9 KB--
@sentry/aws-serverless107.34 KB-0.01%-1 B 🔽
View base workflow run
@timfish
timfish
marked this pull request as ready for review
February 12, 2025 21:30
@AbhiPrasad
AbhiPrasad
merged commit 1aa5bbe
into
developFeb 20, 2025
@AbhiPrasad
AbhiPrasad
deleted the

timfish/feat/express-v5

branch
February 20, 2025 16:50
@github-actionsgithub-actionsBot
mentioned this pull request
Feb 24, 2025

Closed

@Burgov
Burgov
commented
Apr 4, 2025

Copy link


Copy Markdown

Should the documentation be updated? https://docs.sentry.io/platforms/javascript/guides/express/ still mentions limited support
@AbhiPrasad
AbhiPrasad
commented
Apr 4, 2025

Copy link


Copy Markdown

Contributor
@Burgov good catch! I made a PR to fix this in the docs: getsentry/sentry-docs#13240
@timfishtimfish
mentioned this pull request
Apr 11, 2025
 Closed

@mohan82mohan82
mentioned this pull request
Apr 24, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lforstlforstAwaiting requested review from lforst
@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support Express v5


3 participants

@timfish@Burgov@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(node): Support Express v5 - #15380
Merged
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Feb 20, 2025
Merged
feat(node): Support Express v5#15380
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Conversation
@timfish
@timfishtimfish
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
The goal is for Express to eventually support publishing events to diagnostics_channel (#15107) so that Open Telemetry can instrument it without monkey-patching internal code. However, this might take a while and it would be great to support Express v5 now. This PR is a stop-gap solution until that work is complete and published.
This PR vendors the code added in my otel PR:
@lforst
lforst
self-requested a review
February 12, 2025 10:23
@codecov
codecovBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
15271152618
View the top 1 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.tsshouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
Stack Traces | 4.11s run time
root-loader.test.ts:165:1shouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
@github-actions
github-actionsBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser22.95 KB--
@sentry/browser - with treeshaking flags22.73 KB--
@sentry/browser (incl. Tracing)35.89 KB--
@sentry/browser (incl. Tracing, Replay)72.88 KB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags66.39 KB--
@sentry/browser (incl. Tracing, Replay with Canvas)77.13 KB--
@sentry/browser (incl. Tracing, Replay, Feedback)90.09 KB--
@sentry/browser (incl. Feedback)40.1 KB--
@sentry/browser (incl. sendFeedback)27.58 KB--
@sentry/browser (incl. FeedbackAsync)32.38 KB--
@sentry/react24.78 KB--
@sentry/react (incl. Tracing)37.78 KB--
@sentry/vue27.14 KB--
@sentry/vue (incl. Tracing)37.6 KB--
@sentry/svelte22.99 KB--
CDN Bundle24.17 KB--
CDN Bundle (incl. Tracing)35.93 KB--
CDN Bundle (incl. Tracing, Replay)70.75 KB--
CDN Bundle (incl. Tracing, Replay, Feedback)75.91 KB--
CDN Bundle - uncompressed70.64 KB--
CDN Bundle (incl. Tracing) - uncompressed106.74 KB--
CDN Bundle (incl. Tracing, Replay) - uncompressed217.95 KB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed230.52 KB--
@sentry/nextjs (client)38.76 KB--
@sentry/sveltekit (client)36.32 KB--
@sentry/node129.13 KB+1.2%+1.52 KB 🔺
@sentry/node - without tracing97.9 KB--
@sentry/aws-serverless107.34 KB-0.01%-1 B 🔽
View base workflow run
@timfish
timfish
marked this pull request as ready for review
February 12, 2025 21:30
@AbhiPrasad
AbhiPrasad
merged commit 1aa5bbe
into
developFeb 20, 2025
@AbhiPrasad
AbhiPrasad
deleted the

timfish/feat/express-v5

branch
February 20, 2025 16:50
@github-actionsgithub-actionsBot
mentioned this pull request
Feb 24, 2025

Closed

@Burgov
Burgov
commented
Apr 4, 2025

Copy link


Copy Markdown

Should the documentation be updated? https://docs.sentry.io/platforms/javascript/guides/express/ still mentions limited support
@AbhiPrasad
AbhiPrasad
commented
Apr 4, 2025

Copy link


Copy Markdown

Contributor
@Burgov good catch! I made a PR to fix this in the docs: getsentry/sentry-docs#13240
@timfishtimfish
mentioned this pull request
Apr 11, 2025
 Closed

@mohan82mohan82
mentioned this pull request
Apr 24, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lforstlforstAwaiting requested review from lforst
@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support Express v5


3 participants

@timfish@Burgov@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(node): Support Express v5 - #15380
Merged
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Feb 20, 2025
Merged
feat(node): Support Express v5#15380
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Conversation
@timfish
@timfishtimfish
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
The goal is for Express to eventually support publishing events to diagnostics_channel (#15107) so that Open Telemetry can instrument it without monkey-patching internal code. However, this might take a while and it would be great to support Express v5 now. This PR is a stop-gap solution until that work is complete and published.
This PR vendors the code added in my otel PR:
@lforst
lforst
self-requested a review
February 12, 2025 10:23
@codecov
codecovBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
15271152618
View the top 1 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.tsshouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
Stack Traces | 4.11s run time
root-loader.test.ts:165:1shouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
@github-actions
github-actionsBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser22.95 KB--
@sentry/browser - with treeshaking flags22.73 KB--
@sentry/browser (incl. Tracing)35.89 KB--
@sentry/browser (incl. Tracing, Replay)72.88 KB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags66.39 KB--
@sentry/browser (incl. Tracing, Replay with Canvas)77.13 KB--
@sentry/browser (incl. Tracing, Replay, Feedback)90.09 KB--
@sentry/browser (incl. Feedback)40.1 KB--
@sentry/browser (incl. sendFeedback)27.58 KB--
@sentry/browser (incl. FeedbackAsync)32.38 KB--
@sentry/react24.78 KB--
@sentry/react (incl. Tracing)37.78 KB--
@sentry/vue27.14 KB--
@sentry/vue (incl. Tracing)37.6 KB--
@sentry/svelte22.99 KB--
CDN Bundle24.17 KB--
CDN Bundle (incl. Tracing)35.93 KB--
CDN Bundle (incl. Tracing, Replay)70.75 KB--
CDN Bundle (incl. Tracing, Replay, Feedback)75.91 KB--
CDN Bundle - uncompressed70.64 KB--
CDN Bundle (incl. Tracing) - uncompressed106.74 KB--
CDN Bundle (incl. Tracing, Replay) - uncompressed217.95 KB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed230.52 KB--
@sentry/nextjs (client)38.76 KB--
@sentry/sveltekit (client)36.32 KB--
@sentry/node129.13 KB+1.2%+1.52 KB 🔺
@sentry/node - without tracing97.9 KB--
@sentry/aws-serverless107.34 KB-0.01%-1 B 🔽
View base workflow run
@timfish
timfish
marked this pull request as ready for review
February 12, 2025 21:30
@AbhiPrasad
AbhiPrasad
merged commit 1aa5bbe
into
developFeb 20, 2025
@AbhiPrasad
AbhiPrasad
deleted the

timfish/feat/express-v5

branch
February 20, 2025 16:50
@github-actionsgithub-actionsBot
mentioned this pull request
Feb 24, 2025

Closed

@Burgov
Burgov
commented
Apr 4, 2025

Copy link


Copy Markdown

Should the documentation be updated? https://docs.sentry.io/platforms/javascript/guides/express/ still mentions limited support
@AbhiPrasad
AbhiPrasad
commented
Apr 4, 2025

Copy link


Copy Markdown

Contributor
@Burgov good catch! I made a PR to fix this in the docs: getsentry/sentry-docs#13240
@timfishtimfish
mentioned this pull request
Apr 11, 2025
 Closed

@mohan82mohan82
mentioned this pull request
Apr 24, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lforstlforstAwaiting requested review from lforst
@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support Express v5


3 participants

@timfish@Burgov@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(node): Support Express v5 - #15380
Merged
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Feb 20, 2025
Merged
feat(node): Support Express v5#15380
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Conversation
@timfish
@timfishtimfish
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
The goal is for Express to eventually support publishing events to diagnostics_channel (#15107) so that Open Telemetry can instrument it without monkey-patching internal code. However, this might take a while and it would be great to support Express v5 now. This PR is a stop-gap solution until that work is complete and published.
This PR vendors the code added in my otel PR:
@lforst
lforst
self-requested a review
February 12, 2025 10:23
@codecov
codecovBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
15271152618
View the top 1 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.tsshouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
Stack Traces | 4.11s run time
root-loader.test.ts:165:1shouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
@github-actions
github-actionsBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser22.95 KB--
@sentry/browser - with treeshaking flags22.73 KB--
@sentry/browser (incl. Tracing)35.89 KB--
@sentry/browser (incl. Tracing, Replay)72.88 KB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags66.39 KB--
@sentry/browser (incl. Tracing, Replay with Canvas)77.13 KB--
@sentry/browser (incl. Tracing, Replay, Feedback)90.09 KB--
@sentry/browser (incl. Feedback)40.1 KB--
@sentry/browser (incl. sendFeedback)27.58 KB--
@sentry/browser (incl. FeedbackAsync)32.38 KB--
@sentry/react24.78 KB--
@sentry/react (incl. Tracing)37.78 KB--
@sentry/vue27.14 KB--
@sentry/vue (incl. Tracing)37.6 KB--
@sentry/svelte22.99 KB--
CDN Bundle24.17 KB--
CDN Bundle (incl. Tracing)35.93 KB--
CDN Bundle (incl. Tracing, Replay)70.75 KB--
CDN Bundle (incl. Tracing, Replay, Feedback)75.91 KB--
CDN Bundle - uncompressed70.64 KB--
CDN Bundle (incl. Tracing) - uncompressed106.74 KB--
CDN Bundle (incl. Tracing, Replay) - uncompressed217.95 KB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed230.52 KB--
@sentry/nextjs (client)38.76 KB--
@sentry/sveltekit (client)36.32 KB--
@sentry/node129.13 KB+1.2%+1.52 KB 🔺
@sentry/node - without tracing97.9 KB--
@sentry/aws-serverless107.34 KB-0.01%-1 B 🔽
View base workflow run
@timfish
timfish
marked this pull request as ready for review
February 12, 2025 21:30
@AbhiPrasad
AbhiPrasad
merged commit 1aa5bbe
into
developFeb 20, 2025
@AbhiPrasad
AbhiPrasad
deleted the

timfish/feat/express-v5

branch
February 20, 2025 16:50
@github-actionsgithub-actionsBot
mentioned this pull request
Feb 24, 2025

Closed

@Burgov
Burgov
commented
Apr 4, 2025

Copy link


Copy Markdown

Should the documentation be updated? https://docs.sentry.io/platforms/javascript/guides/express/ still mentions limited support
@AbhiPrasad
AbhiPrasad
commented
Apr 4, 2025

Copy link


Copy Markdown

Contributor
@Burgov good catch! I made a PR to fix this in the docs: getsentry/sentry-docs#13240
@timfishtimfish
mentioned this pull request
Apr 11, 2025
 Closed

@mohan82mohan82
mentioned this pull request
Apr 24, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lforstlforstAwaiting requested review from lforst
@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support Express v5


3 participants

@timfish@Burgov@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(node): Support Express v5 - #15380
Merged
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Feb 20, 2025
Merged
feat(node): Support Express v5#15380
AbhiPrasad merged 6 commits into
developfrom 
timfish/feat/express-v5
Conversation
@timfish
@timfishtimfish
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Collaborator
The goal is for Express to eventually support publishing events to diagnostics_channel (#15107) so that Open Telemetry can instrument it without monkey-patching internal code. However, this might take a while and it would be great to support Express v5 now. This PR is a stop-gap solution until that work is complete and published.
This PR vendors the code added in my otel PR:
@lforst
lforst
self-requested a review
February 12, 2025 10:23
@codecov
codecovBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

❌ 1 Tests Failed:
Tests completedFailedPassedSkipped
15271152618
View the top 1 failed test(s) by shortest run time
test/integration/test/client/root-loader.test.tsshouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
Stack Traces | 4.11s run time
root-loader.test.ts:165:1shouldreturnredirecttoanexternalpathwithnobaggageandtraceinjected.
To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.
@github-actions
github-actionsBot
commented
Feb 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser22.95 KB--
@sentry/browser - with treeshaking flags22.73 KB--
@sentry/browser (incl. Tracing)35.89 KB--
@sentry/browser (incl. Tracing, Replay)72.88 KB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags66.39 KB--
@sentry/browser (incl. Tracing, Replay with Canvas)77.13 KB--
@sentry/browser (incl. Tracing, Replay, Feedback)90.09 KB--
@sentry/browser (incl. Feedback)40.1 KB--
@sentry/browser (incl. sendFeedback)27.58 KB--
@sentry/browser (incl. FeedbackAsync)32.38 KB--
@sentry/react24.78 KB--
@sentry/react (incl. Tracing)37.78 KB--
@sentry/vue27.14 KB--
@sentry/vue (incl. Tracing)37.6 KB--
@sentry/svelte22.99 KB--
CDN Bundle24.17 KB--
CDN Bundle (incl. Tracing)35.93 KB--
CDN Bundle (incl. Tracing, Replay)70.75 KB--
CDN Bundle (incl. Tracing, Replay, Feedback)75.91 KB--
CDN Bundle - uncompressed70.64 KB--
CDN Bundle (incl. Tracing) - uncompressed106.74 KB--
CDN Bundle (incl. Tracing, Replay) - uncompressed217.95 KB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed230.52 KB--
@sentry/nextjs (client)38.76 KB--
@sentry/sveltekit (client)36.32 KB--
@sentry/node129.13 KB+1.2%+1.52 KB 🔺
@sentry/node - without tracing97.9 KB--
@sentry/aws-serverless107.34 KB-0.01%-1 B 🔽
View base workflow run
@timfish
timfish
marked this pull request as ready for review
February 12, 2025 21:30
@AbhiPrasad
AbhiPrasad
merged commit 1aa5bbe
into
developFeb 20, 2025
@AbhiPrasad
AbhiPrasad
deleted the

timfish/feat/express-v5

branch
February 20, 2025 16:50
@github-actionsgithub-actionsBot
mentioned this pull request
Feb 24, 2025

Closed

@Burgov
Burgov
commented
Apr 4, 2025

Copy link


Copy Markdown

Should the documentation be updated? https://docs.sentry.io/platforms/javascript/guides/express/ still mentions limited support
@AbhiPrasad
AbhiPrasad
commented
Apr 4, 2025

Copy link


Copy Markdown

Contributor
@Burgov good catch! I made a PR to fix this in the docs: getsentry/sentry-docs#13240
@timfishtimfish
mentioned this pull request
Apr 11, 2025
 Closed

@mohan82mohan82
mentioned this pull request
Apr 24, 2025

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lforstlforstAwaiting requested review from lforst
@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Support Express v5


3 participants

@timfish@Burgov@AbhiPrasad