Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '68 KB',
limit: '70 KB',
modifyWebpackConfig: function (config) {
const webpack = require('webpack');
const TerserPlugin = require('terser-webpack-plugin');
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
childSpan1.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan1.end();
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.2' }, async childSpan2 => {
childSpan2.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan2.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({
context: span1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child2.1' }, async childSpan2 => {
childSpan2.addLinks([
{ context: parentSpan1.spanContext() },
{
context: childSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);

childSpan2.end();
});

childSpan1.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

const span2 = Sentry.startInactiveSpan({ name: 'span2' });
span2.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLinks([
{ context: span1.spanContext() },
{
context: span2.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);
});
157 changes: 157 additions & 0 deletions dev-packages/node-integration-tests/suites/tracing/linking/test.ts
Comment thread
Lms24 marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,157 @@
import { createRunner } from '../../../utils/runner';

describe('span links', () => {
test('should link spans with addLink() in trace context', done => {
let span1_traceId: string, span1_spanId: string;

createRunner(__dirname, 'scenario-addLink.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in trace context', done => {
let span1_traceId: string, span1_spanId: string, span2_traceId: string, span2_spanId: string;

createRunner(__dirname, 'scenario-addLinks.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('span2');

span2_traceId = event.contexts?.trace?.trace_id as string;
span2_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(span2_traceId),
span_id: expect.stringMatching(span2_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLink() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLink-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child1_2 = spans.find(span => span.description === 'child1.2');

expect(child1_1).toBeDefined();
expect(child1_1?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);

expect(child1_2).toBeDefined();
expect(child1_2?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLinks-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child2_1 = spans.find(span => span.description === 'child2.1');

expect(child1_1).toBeDefined();

expect(child2_1).toBeDefined();

expect(child2_1?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(child1_1?.trace_id || 'non-existent-id-fallback'),
span_id: expect.stringMatching(child1_1?.span_id || 'non-existent-id-fallback'),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});
});
2 changes: 2 additions & 0 deletions packages/core/src/types-hoist/context.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { FeatureFlag } from '../featureFlags';
import type { SpanLinkJSON } from './link';
import type { Primitive } from './misc';
import type { SpanOrigin } from './span';

Expand DownExpand Up@@ -106,6 +107,7 @@ export interface TraceContext extends Record<string, unknown> {
tags?: { [key: string]: Primitive };
trace_id: string;
origin?: SpanOrigin;
links?: SpanLinkJSON[];
}

export interface CloudResourceContext extends Record<string, unknown> {
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/utils/spanUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,7 +144,7 @@ export function spanToJSON(span: Span): SpanJSON {

// Handle a span from @opentelemetry/sdk-base-trace's `Span` class
if (spanIsOpenTelemetrySdkTraceBaseSpan(span)) {
const { attributes, startTime, name, endTime, parentSpanId, status } = span;
const { attributes, startTime, name, endTime, parentSpanId, status, links } = span;

return dropUndefinedKeys({
span_id,
Expand All@@ -158,6 +158,7 @@ export function spanToJSON(span: Span): SpanJSON {
status: getStatusMessage(status),
op: attributes[SEMANTIC_ATTRIBUTE_SENTRY_OP],
origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
links: convertSpanLinksForEnvelope(links),
});
}

Expand All@@ -184,6 +185,7 @@ export interface OpenTelemetrySdkTraceBaseSpan extends Span {
status: SpanStatus;
endTime: SpanTimeInput;
parentSpanId?: string;
links?: SpanLink[];
}

/**
Expand Down
6 changes: 5 additions & 1 deletion packages/opentelemetry/src/spanExporter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import type {
TransactionEvent,
TransactionSource,
} from '@sentry/core';
import { convertSpanLinksForEnvelope } from '@sentry/core';
import {
SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
Expand DownExpand Up@@ -247,6 +248,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
...removeSentryAttributes(span.attributes),
});

const { links } = span;
const { traceId: trace_id, spanId: span_id } = span.spanContext();

// If parentSpanIdFromTraceState is defined at all, we want it to take precedence
Expand All@@ -266,6 +268,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
origin,
op,
status: getStatusMessage(status), // As per protocol, span status is allowed to be undefined
links: convertSpanLinksForEnvelope(links),
});

const statusCode = attributes[ATTR_HTTP_RESPONSE_STATUS_CODE];
Expand DownExpand Up@@ -322,7 +325,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
const span_id = span.spanContext().spanId;
const trace_id = span.spanContext().traceId;

const { attributes, startTime, endTime, parentSpanId } = span;
const { attributes, startTime, endTime, parentSpanId, links } = span;

const { op, description, data, origin = 'manual' } = getSpanData(span);
const allData = dropUndefinedKeys({
Expand All@@ -347,6 +350,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
op,
origin,
measurements: timedEventsToMeasurements(span.events),
links: convertSpanLinksForEnvelope(links),
});

spans.push(spanJSON);
Expand Down
29 changes: 28 additions & 1 deletion packages/opentelemetry/test/spanExporter.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { ATTR_HTTP_RESPONSE_STATUS_CODE } from '@opentelemetry/semantic-conventions';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan } from '@sentry/core';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan, startSpanManual } from '@sentry/core';
import { createTransactionForOtelSpan } from '../src/spanExporter';
import { cleanupOtel, mockSdkInit } from './helpers/mockSdkInit';

Expand DownExpand Up@@ -108,4 +108,31 @@ describe('createTransactionForOtelSpan', () => {
transaction_info: { source: 'custom' },
});
});

it('adds span link to the trace context when adding with addLink()', () => {
const span = startInactiveSpan({ name: 'parent1' });
span.end();

startSpanManual({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({ context: span.spanContext(), attributes: { 'sentry.link.type': 'previous_trace' } });
rootSpan.end();

const prevTraceId = span.spanContext().traceId;
const prevSpanId = span.spanContext().spanId;
const event = createTransactionForOtelSpan(rootSpan as any);

expect(event.contexts?.trace).toEqual(
expect.objectContaining({
links: [
expect.objectContaining({
attributes: { 'sentry.link.type': 'previous_trace' },
sampled: true,
trace_id: expect.stringMatching(prevTraceId),
span_id: expect.stringMatching(prevSpanId),
}),
],
}),
);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '68 KB',
limit: '70 KB',
modifyWebpackConfig: function (config) {
const webpack = require('webpack');
const TerserPlugin = require('terser-webpack-plugin');
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
childSpan1.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan1.end();
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.2' }, async childSpan2 => {
childSpan2.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan2.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({
context: span1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child2.1' }, async childSpan2 => {
childSpan2.addLinks([
{ context: parentSpan1.spanContext() },
{
context: childSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);

childSpan2.end();
});

childSpan1.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

const span2 = Sentry.startInactiveSpan({ name: 'span2' });
span2.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLinks([
{ context: span1.spanContext() },
{
context: span2.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);
});
157 changes: 157 additions & 0 deletions dev-packages/node-integration-tests/suites/tracing/linking/test.ts
Comment thread
Lms24 marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,157 @@
import { createRunner } from '../../../utils/runner';

describe('span links', () => {
test('should link spans with addLink() in trace context', done => {
let span1_traceId: string, span1_spanId: string;

createRunner(__dirname, 'scenario-addLink.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in trace context', done => {
let span1_traceId: string, span1_spanId: string, span2_traceId: string, span2_spanId: string;

createRunner(__dirname, 'scenario-addLinks.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('span2');

span2_traceId = event.contexts?.trace?.trace_id as string;
span2_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(span2_traceId),
span_id: expect.stringMatching(span2_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLink() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLink-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child1_2 = spans.find(span => span.description === 'child1.2');

expect(child1_1).toBeDefined();
expect(child1_1?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);

expect(child1_2).toBeDefined();
expect(child1_2?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLinks-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child2_1 = spans.find(span => span.description === 'child2.1');

expect(child1_1).toBeDefined();

expect(child2_1).toBeDefined();

expect(child2_1?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(child1_1?.trace_id || 'non-existent-id-fallback'),
span_id: expect.stringMatching(child1_1?.span_id || 'non-existent-id-fallback'),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});
});
2 changes: 2 additions & 0 deletions packages/core/src/types-hoist/context.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { FeatureFlag } from '../featureFlags';
import type { SpanLinkJSON } from './link';
import type { Primitive } from './misc';
import type { SpanOrigin } from './span';

Expand DownExpand Up@@ -106,6 +107,7 @@ export interface TraceContext extends Record<string, unknown> {
tags?: { [key: string]: Primitive };
trace_id: string;
origin?: SpanOrigin;
links?: SpanLinkJSON[];
}

export interface CloudResourceContext extends Record<string, unknown> {
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/utils/spanUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,7 +144,7 @@ export function spanToJSON(span: Span): SpanJSON {

// Handle a span from @opentelemetry/sdk-base-trace's `Span` class
if (spanIsOpenTelemetrySdkTraceBaseSpan(span)) {
const { attributes, startTime, name, endTime, parentSpanId, status } = span;
const { attributes, startTime, name, endTime, parentSpanId, status, links } = span;

return dropUndefinedKeys({
span_id,
Expand All@@ -158,6 +158,7 @@ export function spanToJSON(span: Span): SpanJSON {
status: getStatusMessage(status),
op: attributes[SEMANTIC_ATTRIBUTE_SENTRY_OP],
origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
links: convertSpanLinksForEnvelope(links),
});
}

Expand All@@ -184,6 +185,7 @@ export interface OpenTelemetrySdkTraceBaseSpan extends Span {
status: SpanStatus;
endTime: SpanTimeInput;
parentSpanId?: string;
links?: SpanLink[];
}

/**
Expand Down
6 changes: 5 additions & 1 deletion packages/opentelemetry/src/spanExporter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import type {
TransactionEvent,
TransactionSource,
} from '@sentry/core';
import { convertSpanLinksForEnvelope } from '@sentry/core';
import {
SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
Expand DownExpand Up@@ -247,6 +248,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
...removeSentryAttributes(span.attributes),
});

const { links } = span;
const { traceId: trace_id, spanId: span_id } = span.spanContext();

// If parentSpanIdFromTraceState is defined at all, we want it to take precedence
Expand All@@ -266,6 +268,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
origin,
op,
status: getStatusMessage(status), // As per protocol, span status is allowed to be undefined
links: convertSpanLinksForEnvelope(links),
});

const statusCode = attributes[ATTR_HTTP_RESPONSE_STATUS_CODE];
Expand DownExpand Up@@ -322,7 +325,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
const span_id = span.spanContext().spanId;
const trace_id = span.spanContext().traceId;

const { attributes, startTime, endTime, parentSpanId } = span;
const { attributes, startTime, endTime, parentSpanId, links } = span;

const { op, description, data, origin = 'manual' } = getSpanData(span);
const allData = dropUndefinedKeys({
Expand All@@ -347,6 +350,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
op,
origin,
measurements: timedEventsToMeasurements(span.events),
links: convertSpanLinksForEnvelope(links),
});

spans.push(spanJSON);
Expand Down
29 changes: 28 additions & 1 deletion packages/opentelemetry/test/spanExporter.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { ATTR_HTTP_RESPONSE_STATUS_CODE } from '@opentelemetry/semantic-conventions';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan } from '@sentry/core';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan, startSpanManual } from '@sentry/core';
import { createTransactionForOtelSpan } from '../src/spanExporter';
import { cleanupOtel, mockSdkInit } from './helpers/mockSdkInit';

Expand DownExpand Up@@ -108,4 +108,31 @@ describe('createTransactionForOtelSpan', () => {
transaction_info: { source: 'custom' },
});
});

it('adds span link to the trace context when adding with addLink()', () => {
const span = startInactiveSpan({ name: 'parent1' });
span.end();

startSpanManual({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({ context: span.spanContext(), attributes: { 'sentry.link.type': 'previous_trace' } });
rootSpan.end();

const prevTraceId = span.spanContext().traceId;
const prevSpanId = span.spanContext().spanId;
const event = createTransactionForOtelSpan(rootSpan as any);

expect(event.contexts?.trace).toEqual(
expect.objectContaining({
links: [
expect.objectContaining({
attributes: { 'sentry.link.type': 'previous_trace' },
sampled: true,
trace_id: expect.stringMatching(prevTraceId),
span_id: expect.stringMatching(prevSpanId),
}),
],
}),
);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '68 KB',
limit: '70 KB',
modifyWebpackConfig: function (config) {
const webpack = require('webpack');
const TerserPlugin = require('terser-webpack-plugin');
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
childSpan1.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan1.end();
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.2' }, async childSpan2 => {
childSpan2.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan2.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({
context: span1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child2.1' }, async childSpan2 => {
childSpan2.addLinks([
{ context: parentSpan1.spanContext() },
{
context: childSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);

childSpan2.end();
});

childSpan1.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

const span2 = Sentry.startInactiveSpan({ name: 'span2' });
span2.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLinks([
{ context: span1.spanContext() },
{
context: span2.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);
});
157 changes: 157 additions & 0 deletions dev-packages/node-integration-tests/suites/tracing/linking/test.ts
Comment thread
Lms24 marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,157 @@
import { createRunner } from '../../../utils/runner';

describe('span links', () => {
test('should link spans with addLink() in trace context', done => {
let span1_traceId: string, span1_spanId: string;

createRunner(__dirname, 'scenario-addLink.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in trace context', done => {
let span1_traceId: string, span1_spanId: string, span2_traceId: string, span2_spanId: string;

createRunner(__dirname, 'scenario-addLinks.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('span2');

span2_traceId = event.contexts?.trace?.trace_id as string;
span2_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(span2_traceId),
span_id: expect.stringMatching(span2_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLink() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLink-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child1_2 = spans.find(span => span.description === 'child1.2');

expect(child1_1).toBeDefined();
expect(child1_1?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);

expect(child1_2).toBeDefined();
expect(child1_2?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLinks-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child2_1 = spans.find(span => span.description === 'child2.1');

expect(child1_1).toBeDefined();

expect(child2_1).toBeDefined();

expect(child2_1?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(child1_1?.trace_id || 'non-existent-id-fallback'),
span_id: expect.stringMatching(child1_1?.span_id || 'non-existent-id-fallback'),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});
});
2 changes: 2 additions & 0 deletions packages/core/src/types-hoist/context.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { FeatureFlag } from '../featureFlags';
import type { SpanLinkJSON } from './link';
import type { Primitive } from './misc';
import type { SpanOrigin } from './span';

Expand DownExpand Up@@ -106,6 +107,7 @@ export interface TraceContext extends Record<string, unknown> {
tags?: { [key: string]: Primitive };
trace_id: string;
origin?: SpanOrigin;
links?: SpanLinkJSON[];
}

export interface CloudResourceContext extends Record<string, unknown> {
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/utils/spanUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,7 +144,7 @@ export function spanToJSON(span: Span): SpanJSON {

// Handle a span from @opentelemetry/sdk-base-trace's `Span` class
if (spanIsOpenTelemetrySdkTraceBaseSpan(span)) {
const { attributes, startTime, name, endTime, parentSpanId, status } = span;
const { attributes, startTime, name, endTime, parentSpanId, status, links } = span;

return dropUndefinedKeys({
span_id,
Expand All@@ -158,6 +158,7 @@ export function spanToJSON(span: Span): SpanJSON {
status: getStatusMessage(status),
op: attributes[SEMANTIC_ATTRIBUTE_SENTRY_OP],
origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
links: convertSpanLinksForEnvelope(links),
});
}

Expand All@@ -184,6 +185,7 @@ export interface OpenTelemetrySdkTraceBaseSpan extends Span {
status: SpanStatus;
endTime: SpanTimeInput;
parentSpanId?: string;
links?: SpanLink[];
}

/**
Expand Down
6 changes: 5 additions & 1 deletion packages/opentelemetry/src/spanExporter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import type {
TransactionEvent,
TransactionSource,
} from '@sentry/core';
import { convertSpanLinksForEnvelope } from '@sentry/core';
import {
SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
Expand DownExpand Up@@ -247,6 +248,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
...removeSentryAttributes(span.attributes),
});

const { links } = span;
const { traceId: trace_id, spanId: span_id } = span.spanContext();

// If parentSpanIdFromTraceState is defined at all, we want it to take precedence
Expand All@@ -266,6 +268,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
origin,
op,
status: getStatusMessage(status), // As per protocol, span status is allowed to be undefined
links: convertSpanLinksForEnvelope(links),
});

const statusCode = attributes[ATTR_HTTP_RESPONSE_STATUS_CODE];
Expand DownExpand Up@@ -322,7 +325,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
const span_id = span.spanContext().spanId;
const trace_id = span.spanContext().traceId;

const { attributes, startTime, endTime, parentSpanId } = span;
const { attributes, startTime, endTime, parentSpanId, links } = span;

const { op, description, data, origin = 'manual' } = getSpanData(span);
const allData = dropUndefinedKeys({
Expand All@@ -347,6 +350,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
op,
origin,
measurements: timedEventsToMeasurements(span.events),
links: convertSpanLinksForEnvelope(links),
});

spans.push(spanJSON);
Expand Down
29 changes: 28 additions & 1 deletion packages/opentelemetry/test/spanExporter.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { ATTR_HTTP_RESPONSE_STATUS_CODE } from '@opentelemetry/semantic-conventions';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan } from '@sentry/core';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan, startSpanManual } from '@sentry/core';
import { createTransactionForOtelSpan } from '../src/spanExporter';
import { cleanupOtel, mockSdkInit } from './helpers/mockSdkInit';

Expand DownExpand Up@@ -108,4 +108,31 @@ describe('createTransactionForOtelSpan', () => {
transaction_info: { source: 'custom' },
});
});

it('adds span link to the trace context when adding with addLink()', () => {
const span = startInactiveSpan({ name: 'parent1' });
span.end();

startSpanManual({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({ context: span.spanContext(), attributes: { 'sentry.link.type': 'previous_trace' } });
rootSpan.end();

const prevTraceId = span.spanContext().traceId;
const prevSpanId = span.spanContext().spanId;
const event = createTransactionForOtelSpan(rootSpan as any);

expect(event.contexts?.trace).toEqual(
expect.objectContaining({
links: [
expect.objectContaining({
attributes: { 'sentry.link.type': 'previous_trace' },
sampled: true,
trace_id: expect.stringMatching(prevTraceId),
span_id: expect.stringMatching(prevSpanId),
}),
],
}),
);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '68 KB',
limit: '70 KB',
modifyWebpackConfig: function (config) {
const webpack = require('webpack');
const TerserPlugin = require('terser-webpack-plugin');
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
childSpan1.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan1.end();
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.2' }, async childSpan2 => {
childSpan2.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan2.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({
context: span1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child2.1' }, async childSpan2 => {
childSpan2.addLinks([
{ context: parentSpan1.spanContext() },
{
context: childSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);

childSpan2.end();
});

childSpan1.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

const span2 = Sentry.startInactiveSpan({ name: 'span2' });
span2.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLinks([
{ context: span1.spanContext() },
{
context: span2.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);
});
157 changes: 157 additions & 0 deletions dev-packages/node-integration-tests/suites/tracing/linking/test.ts
Comment thread
Lms24 marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,157 @@
import { createRunner } from '../../../utils/runner';

describe('span links', () => {
test('should link spans with addLink() in trace context', done => {
let span1_traceId: string, span1_spanId: string;

createRunner(__dirname, 'scenario-addLink.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in trace context', done => {
let span1_traceId: string, span1_spanId: string, span2_traceId: string, span2_spanId: string;

createRunner(__dirname, 'scenario-addLinks.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('span2');

span2_traceId = event.contexts?.trace?.trace_id as string;
span2_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(span2_traceId),
span_id: expect.stringMatching(span2_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLink() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLink-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child1_2 = spans.find(span => span.description === 'child1.2');

expect(child1_1).toBeDefined();
expect(child1_1?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);

expect(child1_2).toBeDefined();
expect(child1_2?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLinks-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child2_1 = spans.find(span => span.description === 'child2.1');

expect(child1_1).toBeDefined();

expect(child2_1).toBeDefined();

expect(child2_1?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(child1_1?.trace_id || 'non-existent-id-fallback'),
span_id: expect.stringMatching(child1_1?.span_id || 'non-existent-id-fallback'),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});
});
2 changes: 2 additions & 0 deletions packages/core/src/types-hoist/context.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { FeatureFlag } from '../featureFlags';
import type { SpanLinkJSON } from './link';
import type { Primitive } from './misc';
import type { SpanOrigin } from './span';

Expand DownExpand Up@@ -106,6 +107,7 @@ export interface TraceContext extends Record<string, unknown> {
tags?: { [key: string]: Primitive };
trace_id: string;
origin?: SpanOrigin;
links?: SpanLinkJSON[];
}

export interface CloudResourceContext extends Record<string, unknown> {
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/utils/spanUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,7 +144,7 @@ export function spanToJSON(span: Span): SpanJSON {

// Handle a span from @opentelemetry/sdk-base-trace's `Span` class
if (spanIsOpenTelemetrySdkTraceBaseSpan(span)) {
const { attributes, startTime, name, endTime, parentSpanId, status } = span;
const { attributes, startTime, name, endTime, parentSpanId, status, links } = span;

return dropUndefinedKeys({
span_id,
Expand All@@ -158,6 +158,7 @@ export function spanToJSON(span: Span): SpanJSON {
status: getStatusMessage(status),
op: attributes[SEMANTIC_ATTRIBUTE_SENTRY_OP],
origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
links: convertSpanLinksForEnvelope(links),
});
}

Expand All@@ -184,6 +185,7 @@ export interface OpenTelemetrySdkTraceBaseSpan extends Span {
status: SpanStatus;
endTime: SpanTimeInput;
parentSpanId?: string;
links?: SpanLink[];
}

/**
Expand Down
6 changes: 5 additions & 1 deletion packages/opentelemetry/src/spanExporter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import type {
TransactionEvent,
TransactionSource,
} from '@sentry/core';
import { convertSpanLinksForEnvelope } from '@sentry/core';
import {
SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
Expand DownExpand Up@@ -247,6 +248,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
...removeSentryAttributes(span.attributes),
});

const { links } = span;
const { traceId: trace_id, spanId: span_id } = span.spanContext();

// If parentSpanIdFromTraceState is defined at all, we want it to take precedence
Expand All@@ -266,6 +268,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
origin,
op,
status: getStatusMessage(status), // As per protocol, span status is allowed to be undefined
links: convertSpanLinksForEnvelope(links),
});

const statusCode = attributes[ATTR_HTTP_RESPONSE_STATUS_CODE];
Expand DownExpand Up@@ -322,7 +325,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
const span_id = span.spanContext().spanId;
const trace_id = span.spanContext().traceId;

const { attributes, startTime, endTime, parentSpanId } = span;
const { attributes, startTime, endTime, parentSpanId, links } = span;

const { op, description, data, origin = 'manual' } = getSpanData(span);
const allData = dropUndefinedKeys({
Expand All@@ -347,6 +350,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
op,
origin,
measurements: timedEventsToMeasurements(span.events),
links: convertSpanLinksForEnvelope(links),
});

spans.push(spanJSON);
Expand Down
29 changes: 28 additions & 1 deletion packages/opentelemetry/test/spanExporter.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { ATTR_HTTP_RESPONSE_STATUS_CODE } from '@opentelemetry/semantic-conventions';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan } from '@sentry/core';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan, startSpanManual } from '@sentry/core';
import { createTransactionForOtelSpan } from '../src/spanExporter';
import { cleanupOtel, mockSdkInit } from './helpers/mockSdkInit';

Expand DownExpand Up@@ -108,4 +108,31 @@ describe('createTransactionForOtelSpan', () => {
transaction_info: { source: 'custom' },
});
});

it('adds span link to the trace context when adding with addLink()', () => {
const span = startInactiveSpan({ name: 'parent1' });
span.end();

startSpanManual({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({ context: span.spanContext(), attributes: { 'sentry.link.type': 'previous_trace' } });
rootSpan.end();

const prevTraceId = span.spanContext().traceId;
const prevSpanId = span.spanContext().spanId;
const event = createTransactionForOtelSpan(rootSpan as any);

expect(event.contexts?.trace).toEqual(
expect.objectContaining({
links: [
expect.objectContaining({
attributes: { 'sentry.link.type': 'previous_trace' },
sampled: true,
trace_id: expect.stringMatching(prevTraceId),
span_id: expect.stringMatching(prevSpanId),
}),
],
}),
);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '68 KB',
limit: '70 KB',
modifyWebpackConfig: function (config) {
const webpack = require('webpack');
const TerserPlugin = require('terser-webpack-plugin');
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
childSpan1.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan1.end();
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.2' }, async childSpan2 => {
childSpan2.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan2.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({
context: span1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child2.1' }, async childSpan2 => {
childSpan2.addLinks([
{ context: parentSpan1.spanContext() },
{
context: childSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);

childSpan2.end();
});

childSpan1.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

const span2 = Sentry.startInactiveSpan({ name: 'span2' });
span2.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLinks([
{ context: span1.spanContext() },
{
context: span2.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);
});
157 changes: 157 additions & 0 deletions dev-packages/node-integration-tests/suites/tracing/linking/test.ts
Comment thread
Lms24 marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,157 @@
import { createRunner } from '../../../utils/runner';

describe('span links', () => {
test('should link spans with addLink() in trace context', done => {
let span1_traceId: string, span1_spanId: string;

createRunner(__dirname, 'scenario-addLink.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in trace context', done => {
let span1_traceId: string, span1_spanId: string, span2_traceId: string, span2_spanId: string;

createRunner(__dirname, 'scenario-addLinks.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('span2');

span2_traceId = event.contexts?.trace?.trace_id as string;
span2_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(span2_traceId),
span_id: expect.stringMatching(span2_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLink() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLink-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child1_2 = spans.find(span => span.description === 'child1.2');

expect(child1_1).toBeDefined();
expect(child1_1?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);

expect(child1_2).toBeDefined();
expect(child1_2?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLinks-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child2_1 = spans.find(span => span.description === 'child2.1');

expect(child1_1).toBeDefined();

expect(child2_1).toBeDefined();

expect(child2_1?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(child1_1?.trace_id || 'non-existent-id-fallback'),
span_id: expect.stringMatching(child1_1?.span_id || 'non-existent-id-fallback'),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});
});
2 changes: 2 additions & 0 deletions packages/core/src/types-hoist/context.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { FeatureFlag } from '../featureFlags';
import type { SpanLinkJSON } from './link';
import type { Primitive } from './misc';
import type { SpanOrigin } from './span';

Expand DownExpand Up@@ -106,6 +107,7 @@ export interface TraceContext extends Record<string, unknown> {
tags?: { [key: string]: Primitive };
trace_id: string;
origin?: SpanOrigin;
links?: SpanLinkJSON[];
}

export interface CloudResourceContext extends Record<string, unknown> {
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/utils/spanUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,7 +144,7 @@ export function spanToJSON(span: Span): SpanJSON {

// Handle a span from @opentelemetry/sdk-base-trace's `Span` class
if (spanIsOpenTelemetrySdkTraceBaseSpan(span)) {
const { attributes, startTime, name, endTime, parentSpanId, status } = span;
const { attributes, startTime, name, endTime, parentSpanId, status, links } = span;

return dropUndefinedKeys({
span_id,
Expand All@@ -158,6 +158,7 @@ export function spanToJSON(span: Span): SpanJSON {
status: getStatusMessage(status),
op: attributes[SEMANTIC_ATTRIBUTE_SENTRY_OP],
origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
links: convertSpanLinksForEnvelope(links),
});
}

Expand All@@ -184,6 +185,7 @@ export interface OpenTelemetrySdkTraceBaseSpan extends Span {
status: SpanStatus;
endTime: SpanTimeInput;
parentSpanId?: string;
links?: SpanLink[];
}

/**
Expand Down
6 changes: 5 additions & 1 deletion packages/opentelemetry/src/spanExporter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import type {
TransactionEvent,
TransactionSource,
} from '@sentry/core';
import { convertSpanLinksForEnvelope } from '@sentry/core';
import {
SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
Expand DownExpand Up@@ -247,6 +248,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
...removeSentryAttributes(span.attributes),
});

const { links } = span;
const { traceId: trace_id, spanId: span_id } = span.spanContext();

// If parentSpanIdFromTraceState is defined at all, we want it to take precedence
Expand All@@ -266,6 +268,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
origin,
op,
status: getStatusMessage(status), // As per protocol, span status is allowed to be undefined
links: convertSpanLinksForEnvelope(links),
});

const statusCode = attributes[ATTR_HTTP_RESPONSE_STATUS_CODE];
Expand DownExpand Up@@ -322,7 +325,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
const span_id = span.spanContext().spanId;
const trace_id = span.spanContext().traceId;

const { attributes, startTime, endTime, parentSpanId } = span;
const { attributes, startTime, endTime, parentSpanId, links } = span;

const { op, description, data, origin = 'manual' } = getSpanData(span);
const allData = dropUndefinedKeys({
Expand All@@ -347,6 +350,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
op,
origin,
measurements: timedEventsToMeasurements(span.events),
links: convertSpanLinksForEnvelope(links),
});

spans.push(spanJSON);
Expand Down
29 changes: 28 additions & 1 deletion packages/opentelemetry/test/spanExporter.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { ATTR_HTTP_RESPONSE_STATUS_CODE } from '@opentelemetry/semantic-conventions';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan } from '@sentry/core';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan, startSpanManual } from '@sentry/core';
import { createTransactionForOtelSpan } from '../src/spanExporter';
import { cleanupOtel, mockSdkInit } from './helpers/mockSdkInit';

Expand DownExpand Up@@ -108,4 +108,31 @@ describe('createTransactionForOtelSpan', () => {
transaction_info: { source: 'custom' },
});
});

it('adds span link to the trace context when adding with addLink()', () => {
const span = startInactiveSpan({ name: 'parent1' });
span.end();

startSpanManual({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({ context: span.spanContext(), attributes: { 'sentry.link.type': 'previous_trace' } });
rootSpan.end();

const prevTraceId = span.spanContext().traceId;
const prevSpanId = span.spanContext().spanId;
const event = createTransactionForOtelSpan(rootSpan as any);

expect(event.contexts?.trace).toEqual(
expect.objectContaining({
links: [
expect.objectContaining({
attributes: { 'sentry.link.type': 'previous_trace' },
sampled: true,
trace_id: expect.stringMatching(prevTraceId),
span_id: expect.stringMatching(prevSpanId),
}),
],
}),
);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '68 KB',
limit: '70 KB',
modifyWebpackConfig: function (config) {
const webpack = require('webpack');
const TerserPlugin = require('terser-webpack-plugin');
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
childSpan1.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan1.end();
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.2' }, async childSpan2 => {
childSpan2.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan2.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({
context: span1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child2.1' }, async childSpan2 => {
childSpan2.addLinks([
{ context: parentSpan1.spanContext() },
{
context: childSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);

childSpan2.end();
});

childSpan1.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

const span2 = Sentry.startInactiveSpan({ name: 'span2' });
span2.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLinks([
{ context: span1.spanContext() },
{
context: span2.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);
});
157 changes: 157 additions & 0 deletions dev-packages/node-integration-tests/suites/tracing/linking/test.ts
Comment thread
Lms24 marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,157 @@
import { createRunner } from '../../../utils/runner';

describe('span links', () => {
test('should link spans with addLink() in trace context', done => {
let span1_traceId: string, span1_spanId: string;

createRunner(__dirname, 'scenario-addLink.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in trace context', done => {
let span1_traceId: string, span1_spanId: string, span2_traceId: string, span2_spanId: string;

createRunner(__dirname, 'scenario-addLinks.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('span2');

span2_traceId = event.contexts?.trace?.trace_id as string;
span2_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(span2_traceId),
span_id: expect.stringMatching(span2_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLink() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLink-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child1_2 = spans.find(span => span.description === 'child1.2');

expect(child1_1).toBeDefined();
expect(child1_1?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);

expect(child1_2).toBeDefined();
expect(child1_2?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLinks-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child2_1 = spans.find(span => span.description === 'child2.1');

expect(child1_1).toBeDefined();

expect(child2_1).toBeDefined();

expect(child2_1?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(child1_1?.trace_id || 'non-existent-id-fallback'),
span_id: expect.stringMatching(child1_1?.span_id || 'non-existent-id-fallback'),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});
});
2 changes: 2 additions & 0 deletions packages/core/src/types-hoist/context.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { FeatureFlag } from '../featureFlags';
import type { SpanLinkJSON } from './link';
import type { Primitive } from './misc';
import type { SpanOrigin } from './span';

Expand DownExpand Up@@ -106,6 +107,7 @@ export interface TraceContext extends Record<string, unknown> {
tags?: { [key: string]: Primitive };
trace_id: string;
origin?: SpanOrigin;
links?: SpanLinkJSON[];
}

export interface CloudResourceContext extends Record<string, unknown> {
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/utils/spanUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,7 +144,7 @@ export function spanToJSON(span: Span): SpanJSON {

// Handle a span from @opentelemetry/sdk-base-trace's `Span` class
if (spanIsOpenTelemetrySdkTraceBaseSpan(span)) {
const { attributes, startTime, name, endTime, parentSpanId, status } = span;
const { attributes, startTime, name, endTime, parentSpanId, status, links } = span;

return dropUndefinedKeys({
span_id,
Expand All@@ -158,6 +158,7 @@ export function spanToJSON(span: Span): SpanJSON {
status: getStatusMessage(status),
op: attributes[SEMANTIC_ATTRIBUTE_SENTRY_OP],
origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
links: convertSpanLinksForEnvelope(links),
});
}

Expand All@@ -184,6 +185,7 @@ export interface OpenTelemetrySdkTraceBaseSpan extends Span {
status: SpanStatus;
endTime: SpanTimeInput;
parentSpanId?: string;
links?: SpanLink[];
}

/**
Expand Down
6 changes: 5 additions & 1 deletion packages/opentelemetry/src/spanExporter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import type {
TransactionEvent,
TransactionSource,
} from '@sentry/core';
import { convertSpanLinksForEnvelope } from '@sentry/core';
import {
SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
Expand DownExpand Up@@ -247,6 +248,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
...removeSentryAttributes(span.attributes),
});

const { links } = span;
const { traceId: trace_id, spanId: span_id } = span.spanContext();

// If parentSpanIdFromTraceState is defined at all, we want it to take precedence
Expand All@@ -266,6 +268,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
origin,
op,
status: getStatusMessage(status), // As per protocol, span status is allowed to be undefined
links: convertSpanLinksForEnvelope(links),
});

const statusCode = attributes[ATTR_HTTP_RESPONSE_STATUS_CODE];
Expand DownExpand Up@@ -322,7 +325,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
const span_id = span.spanContext().spanId;
const trace_id = span.spanContext().traceId;

const { attributes, startTime, endTime, parentSpanId } = span;
const { attributes, startTime, endTime, parentSpanId, links } = span;

const { op, description, data, origin = 'manual' } = getSpanData(span);
const allData = dropUndefinedKeys({
Expand All@@ -347,6 +350,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
op,
origin,
measurements: timedEventsToMeasurements(span.events),
links: convertSpanLinksForEnvelope(links),
});

spans.push(spanJSON);
Expand Down
29 changes: 28 additions & 1 deletion packages/opentelemetry/test/spanExporter.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { ATTR_HTTP_RESPONSE_STATUS_CODE } from '@opentelemetry/semantic-conventions';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan } from '@sentry/core';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan, startSpanManual } from '@sentry/core';
import { createTransactionForOtelSpan } from '../src/spanExporter';
import { cleanupOtel, mockSdkInit } from './helpers/mockSdkInit';

Expand DownExpand Up@@ -108,4 +108,31 @@ describe('createTransactionForOtelSpan', () => {
transaction_info: { source: 'custom' },
});
});

it('adds span link to the trace context when adding with addLink()', () => {
const span = startInactiveSpan({ name: 'parent1' });
span.end();

startSpanManual({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({ context: span.spanContext(), attributes: { 'sentry.link.type': 'previous_trace' } });
rootSpan.end();

const prevTraceId = span.spanContext().traceId;
const prevSpanId = span.spanContext().spanId;
const event = createTransactionForOtelSpan(rootSpan as any);

expect(event.contexts?.trace).toEqual(
expect.objectContaining({
links: [
expect.objectContaining({
attributes: { 'sentry.link.type': 'previous_trace' },
sampled: true,
trace_id: expect.stringMatching(prevTraceId),
span_id: expect.stringMatching(prevSpanId),
}),
],
}),
);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '68 KB',
limit: '70 KB',
modifyWebpackConfig: function (config) {
const webpack = require('webpack');
const TerserPlugin = require('terser-webpack-plugin');
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
childSpan1.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan1.end();
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.2' }, async childSpan2 => {
childSpan2.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan2.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({
context: span1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child2.1' }, async childSpan2 => {
childSpan2.addLinks([
{ context: parentSpan1.spanContext() },
{
context: childSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);

childSpan2.end();
});

childSpan1.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

const span2 = Sentry.startInactiveSpan({ name: 'span2' });
span2.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLinks([
{ context: span1.spanContext() },
{
context: span2.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);
});
157 changes: 157 additions & 0 deletions dev-packages/node-integration-tests/suites/tracing/linking/test.ts
Comment thread
Lms24 marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,157 @@
import { createRunner } from '../../../utils/runner';

describe('span links', () => {
test('should link spans with addLink() in trace context', done => {
let span1_traceId: string, span1_spanId: string;

createRunner(__dirname, 'scenario-addLink.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in trace context', done => {
let span1_traceId: string, span1_spanId: string, span2_traceId: string, span2_spanId: string;

createRunner(__dirname, 'scenario-addLinks.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('span2');

span2_traceId = event.contexts?.trace?.trace_id as string;
span2_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(span2_traceId),
span_id: expect.stringMatching(span2_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLink() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLink-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child1_2 = spans.find(span => span.description === 'child1.2');

expect(child1_1).toBeDefined();
expect(child1_1?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);

expect(child1_2).toBeDefined();
expect(child1_2?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLinks-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child2_1 = spans.find(span => span.description === 'child2.1');

expect(child1_1).toBeDefined();

expect(child2_1).toBeDefined();

expect(child2_1?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(child1_1?.trace_id || 'non-existent-id-fallback'),
span_id: expect.stringMatching(child1_1?.span_id || 'non-existent-id-fallback'),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});
});
2 changes: 2 additions & 0 deletions packages/core/src/types-hoist/context.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { FeatureFlag } from '../featureFlags';
import type { SpanLinkJSON } from './link';
import type { Primitive } from './misc';
import type { SpanOrigin } from './span';

Expand DownExpand Up@@ -106,6 +107,7 @@ export interface TraceContext extends Record<string, unknown> {
tags?: { [key: string]: Primitive };
trace_id: string;
origin?: SpanOrigin;
links?: SpanLinkJSON[];
}

export interface CloudResourceContext extends Record<string, unknown> {
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/utils/spanUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,7 +144,7 @@ export function spanToJSON(span: Span): SpanJSON {

// Handle a span from @opentelemetry/sdk-base-trace's `Span` class
if (spanIsOpenTelemetrySdkTraceBaseSpan(span)) {
const { attributes, startTime, name, endTime, parentSpanId, status } = span;
const { attributes, startTime, name, endTime, parentSpanId, status, links } = span;

return dropUndefinedKeys({
span_id,
Expand All@@ -158,6 +158,7 @@ export function spanToJSON(span: Span): SpanJSON {
status: getStatusMessage(status),
op: attributes[SEMANTIC_ATTRIBUTE_SENTRY_OP],
origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
links: convertSpanLinksForEnvelope(links),
});
}

Expand All@@ -184,6 +185,7 @@ export interface OpenTelemetrySdkTraceBaseSpan extends Span {
status: SpanStatus;
endTime: SpanTimeInput;
parentSpanId?: string;
links?: SpanLink[];
}

/**
Expand Down
6 changes: 5 additions & 1 deletion packages/opentelemetry/src/spanExporter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import type {
TransactionEvent,
TransactionSource,
} from '@sentry/core';
import { convertSpanLinksForEnvelope } from '@sentry/core';
import {
SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
Expand DownExpand Up@@ -247,6 +248,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
...removeSentryAttributes(span.attributes),
});

const { links } = span;
const { traceId: trace_id, spanId: span_id } = span.spanContext();

// If parentSpanIdFromTraceState is defined at all, we want it to take precedence
Expand All@@ -266,6 +268,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
origin,
op,
status: getStatusMessage(status), // As per protocol, span status is allowed to be undefined
links: convertSpanLinksForEnvelope(links),
});

const statusCode = attributes[ATTR_HTTP_RESPONSE_STATUS_CODE];
Expand DownExpand Up@@ -322,7 +325,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
const span_id = span.spanContext().spanId;
const trace_id = span.spanContext().traceId;

const { attributes, startTime, endTime, parentSpanId } = span;
const { attributes, startTime, endTime, parentSpanId, links } = span;

const { op, description, data, origin = 'manual' } = getSpanData(span);
const allData = dropUndefinedKeys({
Expand All@@ -347,6 +350,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
op,
origin,
measurements: timedEventsToMeasurements(span.events),
links: convertSpanLinksForEnvelope(links),
});

spans.push(spanJSON);
Expand Down
29 changes: 28 additions & 1 deletion packages/opentelemetry/test/spanExporter.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { ATTR_HTTP_RESPONSE_STATUS_CODE } from '@opentelemetry/semantic-conventions';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan } from '@sentry/core';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan, startSpanManual } from '@sentry/core';
import { createTransactionForOtelSpan } from '../src/spanExporter';
import { cleanupOtel, mockSdkInit } from './helpers/mockSdkInit';

Expand DownExpand Up@@ -108,4 +108,31 @@ describe('createTransactionForOtelSpan', () => {
transaction_info: { source: 'custom' },
});
});

it('adds span link to the trace context when adding with addLink()', () => {
const span = startInactiveSpan({ name: 'parent1' });
span.end();

startSpanManual({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({ context: span.spanContext(), attributes: { 'sentry.link.type': 'previous_trace' } });
rootSpan.end();

const prevTraceId = span.spanContext().traceId;
const prevSpanId = span.spanContext().spanId;
const event = createTransactionForOtelSpan(rootSpan as any);

expect(event.contexts?.trace).toEqual(
expect.objectContaining({
links: [
expect.objectContaining({
attributes: { 'sentry.link.type': 'previous_trace' },
sampled: true,
trace_id: expect.stringMatching(prevTraceId),
span_id: expect.stringMatching(prevSpanId),
}),
],
}),
);
});
});
});
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -54,7 +54,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '68 KB',
limit: '70 KB',
modifyWebpackConfig: function (config) {
const webpack = require('webpack');
const TerserPlugin = require('terser-webpack-plugin');
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
childSpan1.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan1.end();
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.2' }, async childSpan2 => {
childSpan2.addLink({
context: parentSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});

childSpan2.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({
context: span1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'parent1' }, async parentSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child1.1' }, async childSpan1 => {
// eslint-disable-next-line @typescript-eslint/no-floating-promises
Sentry.startSpan({ name: 'child2.1' }, async childSpan2 => {
childSpan2.addLinks([
{ context: parentSpan1.spanContext() },
{
context: childSpan1.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);

childSpan2.end();
});

childSpan1.end();
});
});
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
tracesSampleRate: 1.0,
integrations: [],
transport: loggingTransport,
});

const span1 = Sentry.startInactiveSpan({ name: 'span1' });
span1.end();

const span2 = Sentry.startInactiveSpan({ name: 'span2' });
span2.end();

Sentry.startSpan({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLinks([
{ context: span1.spanContext() },
{
context: span2.spanContext(),
attributes: { 'sentry.link.type': 'previous_trace' },
},
]);
});
157 changes: 157 additions & 0 deletions dev-packages/node-integration-tests/suites/tracing/linking/test.ts
Comment thread
Lms24 marked this conversation as resolved.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,157 @@
import { createRunner } from '../../../utils/runner';

describe('span links', () => {
test('should link spans with addLink() in trace context', done => {
let span1_traceId: string, span1_spanId: string;

createRunner(__dirname, 'scenario-addLink.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in trace context', done => {
let span1_traceId: string, span1_spanId: string, span2_traceId: string, span2_spanId: string;

createRunner(__dirname, 'scenario-addLinks.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('span1');

span1_traceId = event.contexts?.trace?.trace_id as string;
span1_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('span2');

span2_traceId = event.contexts?.trace?.trace_id as string;
span2_spanId = event.contexts?.trace?.span_id as string;

expect(event.spans).toEqual([]);
},
})
.expect({
transaction: event => {
expect(event.transaction).toBe('rootSpan');

expect(event.contexts?.trace?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(span1_traceId),
span_id: expect.stringMatching(span1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(span2_traceId),
span_id: expect.stringMatching(span2_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLink() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLink-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child1_2 = spans.find(span => span.description === 'child1.2');

expect(child1_1).toBeDefined();
expect(child1_1?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);

expect(child1_2).toBeDefined();
expect(child1_2?.links).toEqual([
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});

test('should link spans with addLinks() in nested startSpan() calls', done => {
createRunner(__dirname, 'scenario-addLinks-nested.ts')
.expect({
transaction: event => {
expect(event.transaction).toBe('parent1');

const parent1_traceId = event.contexts?.trace?.trace_id as string;
const parent1_spanId = event.contexts?.trace?.span_id as string;

const spans = event.spans || [];
const child1_1 = spans.find(span => span.description === 'child1.1');
const child2_1 = spans.find(span => span.description === 'child2.1');

expect(child1_1).toBeDefined();

expect(child2_1).toBeDefined();

expect(child2_1?.links).toEqual([
expect.not.objectContaining({ attributes: expect.anything() }) &&
expect.objectContaining({
trace_id: expect.stringMatching(parent1_traceId),
span_id: expect.stringMatching(parent1_spanId),
}),
expect.objectContaining({
trace_id: expect.stringMatching(child1_1?.trace_id || 'non-existent-id-fallback'),
span_id: expect.stringMatching(child1_1?.span_id || 'non-existent-id-fallback'),
attributes: expect.objectContaining({
'sentry.link.type': 'previous_trace',
}),
}),
]);
},
})
.start(done);
});
});
2 changes: 2 additions & 0 deletions packages/core/src/types-hoist/context.ts
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
import type { FeatureFlag } from '../featureFlags';
import type { SpanLinkJSON } from './link';
import type { Primitive } from './misc';
import type { SpanOrigin } from './span';

Expand DownExpand Up@@ -106,6 +107,7 @@ export interface TraceContext extends Record<string, unknown> {
tags?: { [key: string]: Primitive };
trace_id: string;
origin?: SpanOrigin;
links?: SpanLinkJSON[];
}

export interface CloudResourceContext extends Record<string, unknown> {
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/utils/spanUtils.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,7 +144,7 @@ export function spanToJSON(span: Span): SpanJSON {

// Handle a span from @opentelemetry/sdk-base-trace's `Span` class
if (spanIsOpenTelemetrySdkTraceBaseSpan(span)) {
const { attributes, startTime, name, endTime, parentSpanId, status } = span;
const { attributes, startTime, name, endTime, parentSpanId, status, links } = span;

return dropUndefinedKeys({
span_id,
Expand All@@ -158,6 +158,7 @@ export function spanToJSON(span: Span): SpanJSON {
status: getStatusMessage(status),
op: attributes[SEMANTIC_ATTRIBUTE_SENTRY_OP],
origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
links: convertSpanLinksForEnvelope(links),
});
}

Expand All@@ -184,6 +185,7 @@ export interface OpenTelemetrySdkTraceBaseSpan extends Span {
status: SpanStatus;
endTime: SpanTimeInput;
parentSpanId?: string;
links?: SpanLink[];
}

/**
Expand Down
6 changes: 5 additions & 1 deletion packages/opentelemetry/src/spanExporter.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,6 +11,7 @@ import type {
TransactionEvent,
TransactionSource,
} from '@sentry/core';
import { convertSpanLinksForEnvelope } from '@sentry/core';
import {
SEMANTIC_ATTRIBUTE_SENTRY_CUSTOM_SPAN_NAME,
SEMANTIC_ATTRIBUTE_SENTRY_OP,
Expand DownExpand Up@@ -247,6 +248,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
...removeSentryAttributes(span.attributes),
});

const { links } = span;
const { traceId: trace_id, spanId: span_id } = span.spanContext();

// If parentSpanIdFromTraceState is defined at all, we want it to take precedence
Expand All@@ -266,6 +268,7 @@ export function createTransactionForOtelSpan(span: ReadableSpan): TransactionEve
origin,
op,
status: getStatusMessage(status), // As per protocol, span status is allowed to be undefined
links: convertSpanLinksForEnvelope(links),
});

const statusCode = attributes[ATTR_HTTP_RESPONSE_STATUS_CODE];
Expand DownExpand Up@@ -322,7 +325,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
const span_id = span.spanContext().spanId;
const trace_id = span.spanContext().traceId;

const { attributes, startTime, endTime, parentSpanId } = span;
const { attributes, startTime, endTime, parentSpanId, links } = span;

const { op, description, data, origin = 'manual' } = getSpanData(span);
const allData = dropUndefinedKeys({
Expand All@@ -347,6 +350,7 @@ function createAndFinishSpanForOtelSpan(node: SpanNode, spans: SpanJSON[], sentS
op,
origin,
measurements: timedEventsToMeasurements(span.events),
links: convertSpanLinksForEnvelope(links),
});

spans.push(spanJSON);
Expand Down
29 changes: 28 additions & 1 deletion packages/opentelemetry/test/spanExporter.test.ts
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
import { ATTR_HTTP_RESPONSE_STATUS_CODE } from '@opentelemetry/semantic-conventions';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan } from '@sentry/core';
import { SDK_VERSION, SEMANTIC_ATTRIBUTE_SENTRY_OP, startInactiveSpan, startSpanManual } from '@sentry/core';
import { createTransactionForOtelSpan } from '../src/spanExporter';
import { cleanupOtel, mockSdkInit } from './helpers/mockSdkInit';

Expand DownExpand Up@@ -108,4 +108,31 @@ describe('createTransactionForOtelSpan', () => {
transaction_info: { source: 'custom' },
});
});

it('adds span link to the trace context when adding with addLink()', () => {
const span = startInactiveSpan({ name: 'parent1' });
span.end();

startSpanManual({ name: 'rootSpan' }, rootSpan => {
rootSpan.addLink({ context: span.spanContext(), attributes: { 'sentry.link.type': 'previous_trace' } });
rootSpan.end();

const prevTraceId = span.spanContext().traceId;
const prevSpanId = span.spanContext().spanId;
const event = createTransactionForOtelSpan(rootSpan as any);

expect(event.contexts?.trace).toEqual(
expect.objectContaining({
links: [
expect.objectContaining({
attributes: { 'sentry.link.type': 'previous_trace' },
sampled: true,
trace_id: expect.stringMatching(prevTraceId),
span_id: expect.stringMatching(prevSpanId),
}),
],
}),
);
});
});
});
Loading