Uh oh!
There was an error while loading. Please reload this page.
feat(feedback): Disable Feedback submit & cancel buttons while submitting - #15408
Merged
Conversation
Contributor
size-limit report 📦
|
ryan953
commented
Feb 13, 2025
MemberAuthor
actually, i'm going to see if i can easily disable the whole form, or all the controls inside it instead of only 2 buttons. |
billyvg
reviewed
Feb 13, 2025
Comment on lines
+123
to
+124
| await waitForSec(5); | ||
c298lee
reviewed
Feb 13, 2025
| ) : null} | ||
| <div class="form__right" data-sentry-feedback={true}> | ||
| <fieldset class="form__right" data-sentry-feedback={true} disabled={isSubmitting}> |
MemberAuthor
There was a problem hiding this comment.
it's a container for form controls. it's got some default padding&margin and a border too.
the reason that i brought it in is because it supports disabled which will prevent the text boxes from accepting input.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset#attributes
It's not applying to our <button> inside the form tho, so i had to do those manually. I suspect, but didn't test, that it would automatically disable <input type="button"> or ` if we were using those instead. But i don't wanna change it all over.
c298lee
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While submitting feedback the Submit and Cancel buttons previously remained active. So you could smash that submit many times and submit many duplicate feedbacks.
This disabled the buttons while the network request is being fired off.
The disabled buttons are slightly grayed out by the browser. So it depends on what custom color you've picked:
