Uh oh!
There was an error while loading. Please reload this page.
feat(nextjs): Do not strip origin information from different origin stack frames - #15418
Merged
Conversation
chargomeforce-pushed
the
lforst-improve-diff-origin-stack-frames
branch
from
February 19, 2025 13:02
72c5969 to
c38281aCompareContributor
size-limit report 📦
|
11 tasks
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
s1gr1d
reviewed
Feb 24, 2025
s1gr1d
left a comment
Member
There was a problem hiding this comment.
I think it would be good to use this option in an E2E test to test it.
Comment on lines
+48
to
+49
| const { origin } = new URL(frame.filename as string); | ||
| frame.filename = frame.filename?.replace(origin, 'app://').replace(rewriteFramesAssetPrefixPath, ''); |
Member
There was a problem hiding this comment.
L: That's a minor code-style comment - I would move this logic (which is shorter) upward to improve readability.
chargome
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT(cg): Moved this functionality behind
an _experimental.thirdPartyOriginStackFramesconfig flagThis change should drastically improve transparency on stack frames that come from third party origins while keeping existing sourcemapping functionality.
Example:
https://plausible.io/js/script.jswas always turned intoapp:///js/script.js, leading the user to believe "wtf is this".By not stripping scripts on different origins from their origin in the stack trace, it should be way more transparent where errors originate from, potentially even improving sourcemaps via scraping if these scripts have propper source mapping urls/debug IDs.
Additionally, we should no longer strip js-in-html stack frames, also making those more transparent.
Considerations: