Uh oh!
There was an error while loading. Please reload this page.
feat(remix): Add support for Hydrogen - #15450
Merged
Merged
Conversation
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
onurtemizkanforce-pushed
the
onur/remix-hydrogen
branch
from
February 20, 2025 11:51
9559d6c to
6b1e7b6Compareonurtemizkan
marked this pull request as ready for review
February 24, 2025 17:11
| if: always() && needs.job_e2e_prepare.result == 'success' && needs.job_e2e_prepare.outputs.matrix != '{"include":[]}' | ||
| needs: [job_get_metadata, job_build, job_e2e_prepare] | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-22.04 |
ContributorAuthor
There was a problem hiding this comment.
The reason for this: cloudflare/workerd#3411
s1gr1d
approved these changes
Feb 25, 2025
| const wrappedEntry = { ...build.entry, module: { ...build.entry.module } }; | ||
| // Add warning? |
Member
There was a problem hiding this comment.
Is this supposed to be a permanent comment or is this left from developing?
In case it is permanent, maybe explain which warning you mean here.
ContributorAuthor
There was a problem hiding this comment.
That's a leftover from development. Removed it 👍
AbhiPrasad
approved these changes
Feb 25, 2025
AbhiPrasad
left a comment
Contributor
There was a problem hiding this comment.
Thanks @onurtemizkan!
Mind opening a docs PR for this as well? We should update https://docs.sentry.io/platforms/javascript/guides/remix/frameworks/hydrogen/
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Shopify Hydrogen applications running on MiniOxygen runtime.
Resolves: #5610
What's updated
Issue with
node:async_hooks(#5610 (comment))@sentry/cloudflarehas a new export path called./requestto import only the request wrapper without involvingasync.tswhich importsnode:async_hooks. That fixes the build problems on the MiniOxygen environment.Issue with imported empty modules on MiniOxygen (Related: vitejs/vite#10612)
@sentry/remixhas a new export path called./cloudflareto fix empty methods in the imported modules. The problem there seemed to be the re-exports that are somehow not resolved. So with this, I also updated the file structure of Remix SDK to separate the client/server/cloudflare code with their own per-folderindexfiles.Issue having
loaderandactionspanscloudflareenvironments on the auto-instrumented flow. To support them, I re-introduced the span creation flow we were using before migration. That's a step back from feat(remix)!: RemoveautoInstrumentRemixoption #15074, but by default this logic is disabled. It's enabled by default wheninsturmentBuildis imported from@sentry/remix/cloudflare.The root server spans are not parameterised
That's because we don't have the Remix routes information on
@sentry/cloudflare's request wrapper. I have tried updating the root span's name inside@sentry/remix/cloudflare's logic and it works. But I have left it out for now, not to make this PR even more difficult to review.