Uh oh!
There was an error while loading. Please reload this page.
feat(core): Add addLink(s) to Sentry span - #15452
Conversation
size-limit report 📦
|
Lms24
left a comment
There was a problem hiding this comment.
Thanks! Implementation looks great, just had a couple of comments regarding the tests. But feel free to merge anytime once they're addressed!
| } | ||
| const url = await getLocalTestUrl({ testDir: __dirname }); | ||
| const [rootSpan1, rootSpan2] = await getMultipleSentryEnvelopeRequests<Event>(page, 3, { url }); |
There was a problem hiding this comment.
if we need to wait for 3 events here (do we?) but only want 2, my gut feeling tells me that there's room for flakes. Let's use the waitForTransactionRequest helper instead and check for the correct transaction (or some other identifier). This should be safer for flakes and makes things more explicit.
(side note: I think we should generally use this helper more often, as it works out really well in our e2e tests. But obviously, no action required, we can do this iteratively and over time)
| } | ||
| const url = await getLocalTestUrl({ testDir: __dirname }); | ||
| const [rootSpan1, rootSpan2, rootSpan3] = await getMultipleSentryEnvelopeRequests<Event>(page, 3, { url }); |
There was a problem hiding this comment.
If I understand this test correctly, we're sending 4 transaction events here, right? waiting on 3 then also introduces a potential flake as we depend on events being sent in the correct order.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
part of #14991