Uh oh!
There was an error while loading. Please reload this page.
chore: Bump otel 2.x - #15518
Closed
andreiborza wants to merge 11 commits into
Closed
Conversation
andreiborzaforce-pushed
the
ab/otel-2.0.0
branch
from
February 26, 2025 19:26
8d2fad2 to
1a1fbdfCompareContributor
size-limit report 📦
|
❌ 18 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
AbhiPrasad
left a comment
Contributor
There was a problem hiding this comment.
Looks like the unit test failures are mainly due to imports that have changed (for ex. because they are now types instead of classes) or fields that no longer exist on certain objects.
The pattern I see in E2E tests, and that is in a couple of unit tests, is that parent_span_id seems to not be set anymore. I think this is because of this change: open-telemetry/opentelemetry-js#5450.
span.parentSpanId -> span.parentSpanContext?.spanId
| public constructor(config: SentryNodeFetchInstrumentationOptions = {}) { | ||
| super('@sentry/instrumentation-node-fetch', VERSION, config); | ||
| super('@sentry/instrumentation-node-fetch', '2.0.0-dev.0', config); |
Contributor
There was a problem hiding this comment.
considering this is using @sentry/X I think it's reasonable enough to set our own SDK version here.
MemberAuthor
There was a problem hiding this comment.
Yea was thinking the same. Will update.
timfish
commented
Mar 3, 2025
Collaborator
Would this update be considered a breaking change? I guess this could break compatibility with all otel integrations customers might be using? |
This was referenced Mar 17, 2025
andreiborzaforce-pushed
the
ab/otel-2.0.0
branch
5 times, most recently
from
March 19, 2025 05:32
86ef801 to
dd500bdCompareandreiborza
commented
May 13, 2025
MemberAuthor
Closing this as it was experimental and we have more structured work coming up to support Otel v2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rough draft to bump Otel to the first pre-release version of 2.0.0. Tests are failing partly due to api changes and removed exports. I wasn't sure how to best tackle these and lack the knowledge to migrate some of these.
Followed migration guide: https://github.com/trentm/opentelemetry-js/blob/tm-sdk2-migration-docs-take2/doc/upgrade-to-2.x.md
Things to note:
registerfunction to register a propagator and context manager. I replacedBasicTracerProviderwithNodeTracerProviderof@opentelemetry/sdk-trace-nodeprivatepreviously)activeSpanProcessorwith no provided alternatives. I opted to callforceFlushon the provider instead which maps through the span processors and flushes them.@opentelemetry/core, for now I hardcoded the version where it was needed to pass into instrumentations. Maybe we should use our own versions here?provider.addSpanProcessor()sentry-docs#13011 - BasicTracerProvider#addSpanProcessor(...) was removed. We use the NodeTracerProvider#addSpanProcessor in the docs for combining existing otel setups with sentry: https://docs.sentry.io/platforms/javascript/guides/node/opentelemetry/custom-setup/