test: Log out envelope item for failing node integration tests - #15532

Merged
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious
Feb 27, 2025
Merged

test: Log out envelope item for failing node integration tests#15532
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Contributor

While trying to debug the tedious integration, I figured it would be nice to internals of the envelope item when receiving mismatched envelope items. This PR adds the the serialized envelope item to the error being thrown.

@AbhiPrasad
AbhiPrasad requested a review from a teamFebruary 27, 2025 21:10
@AbhiPrasadAbhiPrasad self-assigned this Feb 27, 2025
@AbhiPrasad
AbhiPrasad requested review from mydea and s1gr1d and removed request for a teamFebruary 27, 2025 21:10
@AbhiPrasad
AbhiPrasad merged commit e9d2295 into developFeb 27, 2025
@AbhiPrasad
AbhiPrasad deleted the abhi-better-envelope-logging-tedious branch February 27, 2025 22:02
@AbhiPrasad

Copy link
Copy Markdown
ContributorAuthor

Success!

https://github.com/getsentry/sentry-javascript/actions/runs/13575927930/job/37952099013?pr=15532

 FAIL suites/tracing/tedious/test.ts > tedious auto instrumentation > should auto-instrument `tedious` package
Error: Expected envelope item type 'transaction' but got 'event'. Item: [{"type":"event"},{"exception":{"values":[{"type":"Error","value":"Login failed for user 'sa'.","stacktrace":{"frames":[{"filename":"node:internal/process/task_queues","module":"task_queues","function":"process.processTicksAndRejections","lineno":95,"colno":5,"in_app":false},{"filename":"node:internal/streams/from","module":"from","function":"next","lineno":98,"colno":31,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"Readable.push","lineno":278,"colno":10,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"readableAddChunk","lineno":341,"colno":9,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"addChunk","lineno":368,"colno":12,"in_app":false},{"filename":"node:events","module":"node:events","function":"Readable.emit","lineno":517,"colno":28,"in_app":false},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js","module":"tedious.lib.token:token-stream-parser","function":"Readable.?","lineno":19,"colno":33,"in_app":false,"pre_context":[" constructor(message, debug, handler, options) {"," super();"," this.debug = debug;"," this.options = options;"," this.parser = _stream.Readable.from(_streamParser.default.parseTokens(message, this.debug, this.options));"," this.parser.on('data', token => {"," debug.token(token);"],"context_line":" handler[token.handlerName](token);","post_context":[" });"," this.parser.on('drain', () => {"," this.emit('drain');"," });"," this.parser.on('end', () => {"," this.emit('end');"," });"]},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/handler.js","module":"tedious.lib.token:handler","function":"Login7TokenHandler.onErrorMessage","lineno":186,"colno":19,"in_app":false,"pre_context":[" this.connection = connection;"," }"," onInfoMessage(token) {"," this.connection.emit('infoMessage', token);"," }"," onErrorMessage(token) {"," this.connection.emit('errorMessage', token);"],"context_line":" const error = new _errors.ConnectionError(token.message, 'ELOGIN');","post_context":[" const isLoginErrorTransient = this.connection.transientErrorLookup.isTransientError(token.number);"," if (isLoginErrorTransient && this.connection.curTransientRetryCount !== this.connection.config.options.maxRetriesOnTransientErrors) {"," error.isTransient = true;"," }"," this.connection.loginError = error;"," }"," onSSPI(token) {"]}]},"mechanism":{"type":"onuncaughtexception","handled":false}}]},"event_id":"3f2c0f09bec345f8972a9ab81c093bbe","level":"fatal","platform":"node","contexts":{"trace":{"trace_id":"bbbd82ae0d674bf690f3f86e85c7f603","span_id":"904855caf7484af9"},"runtime":{"name":"node","version":"v18.20.5"},"app":{"app_start_time":"2025-02-27T21:14:58.550Z","app_memory":104890368},"os":{"kernel_version":"5.15.0-1079-azure","name":"Ubuntu Linux","version":"20.04"},"device":{"boot_time":"2025-02-27T21:00:39.435Z","arch":"x64","memory_size":16768323584,"free_memory":14061731840,"processor_count":4,"cpu_description":"AMD EPYC 7763 64-Core Processor","processor_frequency":3242},"culture":{"locale":"en-US","timezone":"UTC"},"cloud_resource":{}},"server_name":"fv-az1150-349","timestamp":1740690899.488,"environment":"production","release":"1.0","sdk":{"integrations":["InboundFilters","FunctionToString","LinkedErrors","RequestData","Console","Http","NodeFetch","OnUncaughtException","OnUnhandledRejection","ContextLines","LocalVariables","Context","ChildProcess","ProcessSession","Modules","Express","Fastify","Graphql","Mongo","Mongoose","Mysql","Mysql2","Redis","Postgres","Hapi","Koa","Connect","Tedious","GenericPool","Kafka","Amqplib","LruMemoizer","VercelAI"],"name":"sentry.javascript.node","version":"9.2.0","packages":[{"name":"npm:@sentry/node","version":"9.2.0"}]},"modules":{"semver":"7.6.3","shimmer":"1.2.1","require-in-the-middle":"7.2.0","resolve":"1.22.8","is-core-module":"2.13.0","has":"1.0.3","function-bind":"1.1.2","debug":"4.4.0","supports-color":"7.2.0","has-flag":"4.0.0","ms":"2.1.3","module-details-from-path":"1.0.3","import-in-the-middle":"1.13.0","forwarded-parse":"2.1.2","tedious":"18.6.1","tslib":"2.8.1","uuid":"8.3.2","jsonwebtoken":"9.0.2","safe-buffer":"5.2.1","buffer-equal-constant-time":"1.0.1","ecdsa-sig-formatter":"1.0.11","lodash.includes":"4.3.0","lodash.isboolean":"3.0.3","lodash.isinteger":"4.0.4","lodash.isnumber":"3.0.3","lodash.isplainobject":"4.0.6","lodash.isstring":"4.0.1","lodash.once":"4.1.1","open":"8.4.2","is-wsl":"2.2.0","is-docker":"2.2.1","define-lazy-prop":"2.0.0","sprintf-js":"1.1.3","js-md4":"0.3.2","native-duplexpair":"1.0.0","process":"0.11.10","inherits":"2.0.4","iconv-lite":"0.6.3","safer-buffer":"2.1.2"}}]

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

test: Log out envelope item for failing node integration tests - #15532

Merged
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious
Feb 27, 2025
Merged

test: Log out envelope item for failing node integration tests#15532
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Contributor

While trying to debug the tedious integration, I figured it would be nice to internals of the envelope item when receiving mismatched envelope items. This PR adds the the serialized envelope item to the error being thrown.

@AbhiPrasad
AbhiPrasad requested a review from a teamFebruary 27, 2025 21:10
@AbhiPrasadAbhiPrasad self-assigned this Feb 27, 2025
@AbhiPrasad
AbhiPrasad requested review from mydea and s1gr1d and removed request for a teamFebruary 27, 2025 21:10
@AbhiPrasad
AbhiPrasad merged commit e9d2295 into developFeb 27, 2025
@AbhiPrasad
AbhiPrasad deleted the abhi-better-envelope-logging-tedious branch February 27, 2025 22:02
@AbhiPrasad

Copy link
Copy Markdown
ContributorAuthor

Success!

https://github.com/getsentry/sentry-javascript/actions/runs/13575927930/job/37952099013?pr=15532

 FAIL suites/tracing/tedious/test.ts > tedious auto instrumentation > should auto-instrument `tedious` package
Error: Expected envelope item type 'transaction' but got 'event'. Item: [{"type":"event"},{"exception":{"values":[{"type":"Error","value":"Login failed for user 'sa'.","stacktrace":{"frames":[{"filename":"node:internal/process/task_queues","module":"task_queues","function":"process.processTicksAndRejections","lineno":95,"colno":5,"in_app":false},{"filename":"node:internal/streams/from","module":"from","function":"next","lineno":98,"colno":31,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"Readable.push","lineno":278,"colno":10,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"readableAddChunk","lineno":341,"colno":9,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"addChunk","lineno":368,"colno":12,"in_app":false},{"filename":"node:events","module":"node:events","function":"Readable.emit","lineno":517,"colno":28,"in_app":false},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js","module":"tedious.lib.token:token-stream-parser","function":"Readable.?","lineno":19,"colno":33,"in_app":false,"pre_context":[" constructor(message, debug, handler, options) {"," super();"," this.debug = debug;"," this.options = options;"," this.parser = _stream.Readable.from(_streamParser.default.parseTokens(message, this.debug, this.options));"," this.parser.on('data', token => {"," debug.token(token);"],"context_line":" handler[token.handlerName](token);","post_context":[" });"," this.parser.on('drain', () => {"," this.emit('drain');"," });"," this.parser.on('end', () => {"," this.emit('end');"," });"]},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/handler.js","module":"tedious.lib.token:handler","function":"Login7TokenHandler.onErrorMessage","lineno":186,"colno":19,"in_app":false,"pre_context":[" this.connection = connection;"," }"," onInfoMessage(token) {"," this.connection.emit('infoMessage', token);"," }"," onErrorMessage(token) {"," this.connection.emit('errorMessage', token);"],"context_line":" const error = new _errors.ConnectionError(token.message, 'ELOGIN');","post_context":[" const isLoginErrorTransient = this.connection.transientErrorLookup.isTransientError(token.number);"," if (isLoginErrorTransient && this.connection.curTransientRetryCount !== this.connection.config.options.maxRetriesOnTransientErrors) {"," error.isTransient = true;"," }"," this.connection.loginError = error;"," }"," onSSPI(token) {"]}]},"mechanism":{"type":"onuncaughtexception","handled":false}}]},"event_id":"3f2c0f09bec345f8972a9ab81c093bbe","level":"fatal","platform":"node","contexts":{"trace":{"trace_id":"bbbd82ae0d674bf690f3f86e85c7f603","span_id":"904855caf7484af9"},"runtime":{"name":"node","version":"v18.20.5"},"app":{"app_start_time":"2025-02-27T21:14:58.550Z","app_memory":104890368},"os":{"kernel_version":"5.15.0-1079-azure","name":"Ubuntu Linux","version":"20.04"},"device":{"boot_time":"2025-02-27T21:00:39.435Z","arch":"x64","memory_size":16768323584,"free_memory":14061731840,"processor_count":4,"cpu_description":"AMD EPYC 7763 64-Core Processor","processor_frequency":3242},"culture":{"locale":"en-US","timezone":"UTC"},"cloud_resource":{}},"server_name":"fv-az1150-349","timestamp":1740690899.488,"environment":"production","release":"1.0","sdk":{"integrations":["InboundFilters","FunctionToString","LinkedErrors","RequestData","Console","Http","NodeFetch","OnUncaughtException","OnUnhandledRejection","ContextLines","LocalVariables","Context","ChildProcess","ProcessSession","Modules","Express","Fastify","Graphql","Mongo","Mongoose","Mysql","Mysql2","Redis","Postgres","Hapi","Koa","Connect","Tedious","GenericPool","Kafka","Amqplib","LruMemoizer","VercelAI"],"name":"sentry.javascript.node","version":"9.2.0","packages":[{"name":"npm:@sentry/node","version":"9.2.0"}]},"modules":{"semver":"7.6.3","shimmer":"1.2.1","require-in-the-middle":"7.2.0","resolve":"1.22.8","is-core-module":"2.13.0","has":"1.0.3","function-bind":"1.1.2","debug":"4.4.0","supports-color":"7.2.0","has-flag":"4.0.0","ms":"2.1.3","module-details-from-path":"1.0.3","import-in-the-middle":"1.13.0","forwarded-parse":"2.1.2","tedious":"18.6.1","tslib":"2.8.1","uuid":"8.3.2","jsonwebtoken":"9.0.2","safe-buffer":"5.2.1","buffer-equal-constant-time":"1.0.1","ecdsa-sig-formatter":"1.0.11","lodash.includes":"4.3.0","lodash.isboolean":"3.0.3","lodash.isinteger":"4.0.4","lodash.isnumber":"3.0.3","lodash.isplainobject":"4.0.6","lodash.isstring":"4.0.1","lodash.once":"4.1.1","open":"8.4.2","is-wsl":"2.2.0","is-docker":"2.2.1","define-lazy-prop":"2.0.0","sprintf-js":"1.1.3","js-md4":"0.3.2","native-duplexpair":"1.0.0","process":"0.11.10","inherits":"2.0.4","iconv-lite":"0.6.3","safer-buffer":"2.1.2"}}]

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test: Log out envelope item for failing node integration tests - #15532

Merged
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious
Feb 27, 2025
Merged

test: Log out envelope item for failing node integration tests#15532
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Contributor

While trying to debug the tedious integration, I figured it would be nice to internals of the envelope item when receiving mismatched envelope items. This PR adds the the serialized envelope item to the error being thrown.

@AbhiPrasad
AbhiPrasad requested a review from a teamFebruary 27, 2025 21:10
@AbhiPrasadAbhiPrasad self-assigned this Feb 27, 2025
@AbhiPrasad
AbhiPrasad requested review from mydea and s1gr1d and removed request for a teamFebruary 27, 2025 21:10
@AbhiPrasad
AbhiPrasad merged commit e9d2295 into developFeb 27, 2025
@AbhiPrasad
AbhiPrasad deleted the abhi-better-envelope-logging-tedious branch February 27, 2025 22:02
@AbhiPrasad

Copy link
Copy Markdown
ContributorAuthor

Success!

https://github.com/getsentry/sentry-javascript/actions/runs/13575927930/job/37952099013?pr=15532

 FAIL suites/tracing/tedious/test.ts > tedious auto instrumentation > should auto-instrument `tedious` package
Error: Expected envelope item type 'transaction' but got 'event'. Item: [{"type":"event"},{"exception":{"values":[{"type":"Error","value":"Login failed for user 'sa'.","stacktrace":{"frames":[{"filename":"node:internal/process/task_queues","module":"task_queues","function":"process.processTicksAndRejections","lineno":95,"colno":5,"in_app":false},{"filename":"node:internal/streams/from","module":"from","function":"next","lineno":98,"colno":31,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"Readable.push","lineno":278,"colno":10,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"readableAddChunk","lineno":341,"colno":9,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"addChunk","lineno":368,"colno":12,"in_app":false},{"filename":"node:events","module":"node:events","function":"Readable.emit","lineno":517,"colno":28,"in_app":false},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js","module":"tedious.lib.token:token-stream-parser","function":"Readable.?","lineno":19,"colno":33,"in_app":false,"pre_context":[" constructor(message, debug, handler, options) {"," super();"," this.debug = debug;"," this.options = options;"," this.parser = _stream.Readable.from(_streamParser.default.parseTokens(message, this.debug, this.options));"," this.parser.on('data', token => {"," debug.token(token);"],"context_line":" handler[token.handlerName](token);","post_context":[" });"," this.parser.on('drain', () => {"," this.emit('drain');"," });"," this.parser.on('end', () => {"," this.emit('end');"," });"]},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/handler.js","module":"tedious.lib.token:handler","function":"Login7TokenHandler.onErrorMessage","lineno":186,"colno":19,"in_app":false,"pre_context":[" this.connection = connection;"," }"," onInfoMessage(token) {"," this.connection.emit('infoMessage', token);"," }"," onErrorMessage(token) {"," this.connection.emit('errorMessage', token);"],"context_line":" const error = new _errors.ConnectionError(token.message, 'ELOGIN');","post_context":[" const isLoginErrorTransient = this.connection.transientErrorLookup.isTransientError(token.number);"," if (isLoginErrorTransient && this.connection.curTransientRetryCount !== this.connection.config.options.maxRetriesOnTransientErrors) {"," error.isTransient = true;"," }"," this.connection.loginError = error;"," }"," onSSPI(token) {"]}]},"mechanism":{"type":"onuncaughtexception","handled":false}}]},"event_id":"3f2c0f09bec345f8972a9ab81c093bbe","level":"fatal","platform":"node","contexts":{"trace":{"trace_id":"bbbd82ae0d674bf690f3f86e85c7f603","span_id":"904855caf7484af9"},"runtime":{"name":"node","version":"v18.20.5"},"app":{"app_start_time":"2025-02-27T21:14:58.550Z","app_memory":104890368},"os":{"kernel_version":"5.15.0-1079-azure","name":"Ubuntu Linux","version":"20.04"},"device":{"boot_time":"2025-02-27T21:00:39.435Z","arch":"x64","memory_size":16768323584,"free_memory":14061731840,"processor_count":4,"cpu_description":"AMD EPYC 7763 64-Core Processor","processor_frequency":3242},"culture":{"locale":"en-US","timezone":"UTC"},"cloud_resource":{}},"server_name":"fv-az1150-349","timestamp":1740690899.488,"environment":"production","release":"1.0","sdk":{"integrations":["InboundFilters","FunctionToString","LinkedErrors","RequestData","Console","Http","NodeFetch","OnUncaughtException","OnUnhandledRejection","ContextLines","LocalVariables","Context","ChildProcess","ProcessSession","Modules","Express","Fastify","Graphql","Mongo","Mongoose","Mysql","Mysql2","Redis","Postgres","Hapi","Koa","Connect","Tedious","GenericPool","Kafka","Amqplib","LruMemoizer","VercelAI"],"name":"sentry.javascript.node","version":"9.2.0","packages":[{"name":"npm:@sentry/node","version":"9.2.0"}]},"modules":{"semver":"7.6.3","shimmer":"1.2.1","require-in-the-middle":"7.2.0","resolve":"1.22.8","is-core-module":"2.13.0","has":"1.0.3","function-bind":"1.1.2","debug":"4.4.0","supports-color":"7.2.0","has-flag":"4.0.0","ms":"2.1.3","module-details-from-path":"1.0.3","import-in-the-middle":"1.13.0","forwarded-parse":"2.1.2","tedious":"18.6.1","tslib":"2.8.1","uuid":"8.3.2","jsonwebtoken":"9.0.2","safe-buffer":"5.2.1","buffer-equal-constant-time":"1.0.1","ecdsa-sig-formatter":"1.0.11","lodash.includes":"4.3.0","lodash.isboolean":"3.0.3","lodash.isinteger":"4.0.4","lodash.isnumber":"3.0.3","lodash.isplainobject":"4.0.6","lodash.isstring":"4.0.1","lodash.once":"4.1.1","open":"8.4.2","is-wsl":"2.2.0","is-docker":"2.2.1","define-lazy-prop":"2.0.0","sprintf-js":"1.1.3","js-md4":"0.3.2","native-duplexpair":"1.0.0","process":"0.11.10","inherits":"2.0.4","iconv-lite":"0.6.3","safer-buffer":"2.1.2"}}]

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test: Log out envelope item for failing node integration tests - #15532

Merged
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious
Feb 27, 2025
Merged

test: Log out envelope item for failing node integration tests#15532
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Contributor

While trying to debug the tedious integration, I figured it would be nice to internals of the envelope item when receiving mismatched envelope items. This PR adds the the serialized envelope item to the error being thrown.

@AbhiPrasad
AbhiPrasad requested a review from a teamFebruary 27, 2025 21:10
@AbhiPrasadAbhiPrasad self-assigned this Feb 27, 2025
@AbhiPrasad
AbhiPrasad requested review from mydea and s1gr1d and removed request for a teamFebruary 27, 2025 21:10
@AbhiPrasad
AbhiPrasad merged commit e9d2295 into developFeb 27, 2025
@AbhiPrasad
AbhiPrasad deleted the abhi-better-envelope-logging-tedious branch February 27, 2025 22:02
@AbhiPrasad

Copy link
Copy Markdown
ContributorAuthor

Success!

https://github.com/getsentry/sentry-javascript/actions/runs/13575927930/job/37952099013?pr=15532

 FAIL suites/tracing/tedious/test.ts > tedious auto instrumentation > should auto-instrument `tedious` package
Error: Expected envelope item type 'transaction' but got 'event'. Item: [{"type":"event"},{"exception":{"values":[{"type":"Error","value":"Login failed for user 'sa'.","stacktrace":{"frames":[{"filename":"node:internal/process/task_queues","module":"task_queues","function":"process.processTicksAndRejections","lineno":95,"colno":5,"in_app":false},{"filename":"node:internal/streams/from","module":"from","function":"next","lineno":98,"colno":31,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"Readable.push","lineno":278,"colno":10,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"readableAddChunk","lineno":341,"colno":9,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"addChunk","lineno":368,"colno":12,"in_app":false},{"filename":"node:events","module":"node:events","function":"Readable.emit","lineno":517,"colno":28,"in_app":false},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js","module":"tedious.lib.token:token-stream-parser","function":"Readable.?","lineno":19,"colno":33,"in_app":false,"pre_context":[" constructor(message, debug, handler, options) {"," super();"," this.debug = debug;"," this.options = options;"," this.parser = _stream.Readable.from(_streamParser.default.parseTokens(message, this.debug, this.options));"," this.parser.on('data', token => {"," debug.token(token);"],"context_line":" handler[token.handlerName](token);","post_context":[" });"," this.parser.on('drain', () => {"," this.emit('drain');"," });"," this.parser.on('end', () => {"," this.emit('end');"," });"]},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/handler.js","module":"tedious.lib.token:handler","function":"Login7TokenHandler.onErrorMessage","lineno":186,"colno":19,"in_app":false,"pre_context":[" this.connection = connection;"," }"," onInfoMessage(token) {"," this.connection.emit('infoMessage', token);"," }"," onErrorMessage(token) {"," this.connection.emit('errorMessage', token);"],"context_line":" const error = new _errors.ConnectionError(token.message, 'ELOGIN');","post_context":[" const isLoginErrorTransient = this.connection.transientErrorLookup.isTransientError(token.number);"," if (isLoginErrorTransient && this.connection.curTransientRetryCount !== this.connection.config.options.maxRetriesOnTransientErrors) {"," error.isTransient = true;"," }"," this.connection.loginError = error;"," }"," onSSPI(token) {"]}]},"mechanism":{"type":"onuncaughtexception","handled":false}}]},"event_id":"3f2c0f09bec345f8972a9ab81c093bbe","level":"fatal","platform":"node","contexts":{"trace":{"trace_id":"bbbd82ae0d674bf690f3f86e85c7f603","span_id":"904855caf7484af9"},"runtime":{"name":"node","version":"v18.20.5"},"app":{"app_start_time":"2025-02-27T21:14:58.550Z","app_memory":104890368},"os":{"kernel_version":"5.15.0-1079-azure","name":"Ubuntu Linux","version":"20.04"},"device":{"boot_time":"2025-02-27T21:00:39.435Z","arch":"x64","memory_size":16768323584,"free_memory":14061731840,"processor_count":4,"cpu_description":"AMD EPYC 7763 64-Core Processor","processor_frequency":3242},"culture":{"locale":"en-US","timezone":"UTC"},"cloud_resource":{}},"server_name":"fv-az1150-349","timestamp":1740690899.488,"environment":"production","release":"1.0","sdk":{"integrations":["InboundFilters","FunctionToString","LinkedErrors","RequestData","Console","Http","NodeFetch","OnUncaughtException","OnUnhandledRejection","ContextLines","LocalVariables","Context","ChildProcess","ProcessSession","Modules","Express","Fastify","Graphql","Mongo","Mongoose","Mysql","Mysql2","Redis","Postgres","Hapi","Koa","Connect","Tedious","GenericPool","Kafka","Amqplib","LruMemoizer","VercelAI"],"name":"sentry.javascript.node","version":"9.2.0","packages":[{"name":"npm:@sentry/node","version":"9.2.0"}]},"modules":{"semver":"7.6.3","shimmer":"1.2.1","require-in-the-middle":"7.2.0","resolve":"1.22.8","is-core-module":"2.13.0","has":"1.0.3","function-bind":"1.1.2","debug":"4.4.0","supports-color":"7.2.0","has-flag":"4.0.0","ms":"2.1.3","module-details-from-path":"1.0.3","import-in-the-middle":"1.13.0","forwarded-parse":"2.1.2","tedious":"18.6.1","tslib":"2.8.1","uuid":"8.3.2","jsonwebtoken":"9.0.2","safe-buffer":"5.2.1","buffer-equal-constant-time":"1.0.1","ecdsa-sig-formatter":"1.0.11","lodash.includes":"4.3.0","lodash.isboolean":"3.0.3","lodash.isinteger":"4.0.4","lodash.isnumber":"3.0.3","lodash.isplainobject":"4.0.6","lodash.isstring":"4.0.1","lodash.once":"4.1.1","open":"8.4.2","is-wsl":"2.2.0","is-docker":"2.2.1","define-lazy-prop":"2.0.0","sprintf-js":"1.1.3","js-md4":"0.3.2","native-duplexpair":"1.0.0","process":"0.11.10","inherits":"2.0.4","iconv-lite":"0.6.3","safer-buffer":"2.1.2"}}]

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

test: Log out envelope item for failing node integration tests - #15532

Merged
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious
Feb 27, 2025
Merged

test: Log out envelope item for failing node integration tests#15532
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Contributor

While trying to debug the tedious integration, I figured it would be nice to internals of the envelope item when receiving mismatched envelope items. This PR adds the the serialized envelope item to the error being thrown.

@AbhiPrasad
AbhiPrasad requested a review from a teamFebruary 27, 2025 21:10
@AbhiPrasadAbhiPrasad self-assigned this Feb 27, 2025
@AbhiPrasad
AbhiPrasad requested review from mydea and s1gr1d and removed request for a teamFebruary 27, 2025 21:10
@AbhiPrasad
AbhiPrasad merged commit e9d2295 into developFeb 27, 2025
@AbhiPrasad
AbhiPrasad deleted the abhi-better-envelope-logging-tedious branch February 27, 2025 22:02
@AbhiPrasad

Copy link
Copy Markdown
ContributorAuthor

Success!

https://github.com/getsentry/sentry-javascript/actions/runs/13575927930/job/37952099013?pr=15532

 FAIL suites/tracing/tedious/test.ts > tedious auto instrumentation > should auto-instrument `tedious` package
Error: Expected envelope item type 'transaction' but got 'event'. Item: [{"type":"event"},{"exception":{"values":[{"type":"Error","value":"Login failed for user 'sa'.","stacktrace":{"frames":[{"filename":"node:internal/process/task_queues","module":"task_queues","function":"process.processTicksAndRejections","lineno":95,"colno":5,"in_app":false},{"filename":"node:internal/streams/from","module":"from","function":"next","lineno":98,"colno":31,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"Readable.push","lineno":278,"colno":10,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"readableAddChunk","lineno":341,"colno":9,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"addChunk","lineno":368,"colno":12,"in_app":false},{"filename":"node:events","module":"node:events","function":"Readable.emit","lineno":517,"colno":28,"in_app":false},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js","module":"tedious.lib.token:token-stream-parser","function":"Readable.?","lineno":19,"colno":33,"in_app":false,"pre_context":[" constructor(message, debug, handler, options) {"," super();"," this.debug = debug;"," this.options = options;"," this.parser = _stream.Readable.from(_streamParser.default.parseTokens(message, this.debug, this.options));"," this.parser.on('data', token => {"," debug.token(token);"],"context_line":" handler[token.handlerName](token);","post_context":[" });"," this.parser.on('drain', () => {"," this.emit('drain');"," });"," this.parser.on('end', () => {"," this.emit('end');"," });"]},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/handler.js","module":"tedious.lib.token:handler","function":"Login7TokenHandler.onErrorMessage","lineno":186,"colno":19,"in_app":false,"pre_context":[" this.connection = connection;"," }"," onInfoMessage(token) {"," this.connection.emit('infoMessage', token);"," }"," onErrorMessage(token) {"," this.connection.emit('errorMessage', token);"],"context_line":" const error = new _errors.ConnectionError(token.message, 'ELOGIN');","post_context":[" const isLoginErrorTransient = this.connection.transientErrorLookup.isTransientError(token.number);"," if (isLoginErrorTransient && this.connection.curTransientRetryCount !== this.connection.config.options.maxRetriesOnTransientErrors) {"," error.isTransient = true;"," }"," this.connection.loginError = error;"," }"," onSSPI(token) {"]}]},"mechanism":{"type":"onuncaughtexception","handled":false}}]},"event_id":"3f2c0f09bec345f8972a9ab81c093bbe","level":"fatal","platform":"node","contexts":{"trace":{"trace_id":"bbbd82ae0d674bf690f3f86e85c7f603","span_id":"904855caf7484af9"},"runtime":{"name":"node","version":"v18.20.5"},"app":{"app_start_time":"2025-02-27T21:14:58.550Z","app_memory":104890368},"os":{"kernel_version":"5.15.0-1079-azure","name":"Ubuntu Linux","version":"20.04"},"device":{"boot_time":"2025-02-27T21:00:39.435Z","arch":"x64","memory_size":16768323584,"free_memory":14061731840,"processor_count":4,"cpu_description":"AMD EPYC 7763 64-Core Processor","processor_frequency":3242},"culture":{"locale":"en-US","timezone":"UTC"},"cloud_resource":{}},"server_name":"fv-az1150-349","timestamp":1740690899.488,"environment":"production","release":"1.0","sdk":{"integrations":["InboundFilters","FunctionToString","LinkedErrors","RequestData","Console","Http","NodeFetch","OnUncaughtException","OnUnhandledRejection","ContextLines","LocalVariables","Context","ChildProcess","ProcessSession","Modules","Express","Fastify","Graphql","Mongo","Mongoose","Mysql","Mysql2","Redis","Postgres","Hapi","Koa","Connect","Tedious","GenericPool","Kafka","Amqplib","LruMemoizer","VercelAI"],"name":"sentry.javascript.node","version":"9.2.0","packages":[{"name":"npm:@sentry/node","version":"9.2.0"}]},"modules":{"semver":"7.6.3","shimmer":"1.2.1","require-in-the-middle":"7.2.0","resolve":"1.22.8","is-core-module":"2.13.0","has":"1.0.3","function-bind":"1.1.2","debug":"4.4.0","supports-color":"7.2.0","has-flag":"4.0.0","ms":"2.1.3","module-details-from-path":"1.0.3","import-in-the-middle":"1.13.0","forwarded-parse":"2.1.2","tedious":"18.6.1","tslib":"2.8.1","uuid":"8.3.2","jsonwebtoken":"9.0.2","safe-buffer":"5.2.1","buffer-equal-constant-time":"1.0.1","ecdsa-sig-formatter":"1.0.11","lodash.includes":"4.3.0","lodash.isboolean":"3.0.3","lodash.isinteger":"4.0.4","lodash.isnumber":"3.0.3","lodash.isplainobject":"4.0.6","lodash.isstring":"4.0.1","lodash.once":"4.1.1","open":"8.4.2","is-wsl":"2.2.0","is-docker":"2.2.1","define-lazy-prop":"2.0.0","sprintf-js":"1.1.3","js-md4":"0.3.2","native-duplexpair":"1.0.0","process":"0.11.10","inherits":"2.0.4","iconv-lite":"0.6.3","safer-buffer":"2.1.2"}}]

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test: Log out envelope item for failing node integration tests - #15532

Merged
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious
Feb 27, 2025
Merged

test: Log out envelope item for failing node integration tests#15532
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Contributor

While trying to debug the tedious integration, I figured it would be nice to internals of the envelope item when receiving mismatched envelope items. This PR adds the the serialized envelope item to the error being thrown.

@AbhiPrasad
AbhiPrasad requested a review from a teamFebruary 27, 2025 21:10
@AbhiPrasadAbhiPrasad self-assigned this Feb 27, 2025
@AbhiPrasad
AbhiPrasad requested review from mydea and s1gr1d and removed request for a teamFebruary 27, 2025 21:10
@AbhiPrasad
AbhiPrasad merged commit e9d2295 into developFeb 27, 2025
@AbhiPrasad
AbhiPrasad deleted the abhi-better-envelope-logging-tedious branch February 27, 2025 22:02
@AbhiPrasad

Copy link
Copy Markdown
ContributorAuthor

Success!

https://github.com/getsentry/sentry-javascript/actions/runs/13575927930/job/37952099013?pr=15532

 FAIL suites/tracing/tedious/test.ts > tedious auto instrumentation > should auto-instrument `tedious` package
Error: Expected envelope item type 'transaction' but got 'event'. Item: [{"type":"event"},{"exception":{"values":[{"type":"Error","value":"Login failed for user 'sa'.","stacktrace":{"frames":[{"filename":"node:internal/process/task_queues","module":"task_queues","function":"process.processTicksAndRejections","lineno":95,"colno":5,"in_app":false},{"filename":"node:internal/streams/from","module":"from","function":"next","lineno":98,"colno":31,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"Readable.push","lineno":278,"colno":10,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"readableAddChunk","lineno":341,"colno":9,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"addChunk","lineno":368,"colno":12,"in_app":false},{"filename":"node:events","module":"node:events","function":"Readable.emit","lineno":517,"colno":28,"in_app":false},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js","module":"tedious.lib.token:token-stream-parser","function":"Readable.?","lineno":19,"colno":33,"in_app":false,"pre_context":[" constructor(message, debug, handler, options) {"," super();"," this.debug = debug;"," this.options = options;"," this.parser = _stream.Readable.from(_streamParser.default.parseTokens(message, this.debug, this.options));"," this.parser.on('data', token => {"," debug.token(token);"],"context_line":" handler[token.handlerName](token);","post_context":[" });"," this.parser.on('drain', () => {"," this.emit('drain');"," });"," this.parser.on('end', () => {"," this.emit('end');"," });"]},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/handler.js","module":"tedious.lib.token:handler","function":"Login7TokenHandler.onErrorMessage","lineno":186,"colno":19,"in_app":false,"pre_context":[" this.connection = connection;"," }"," onInfoMessage(token) {"," this.connection.emit('infoMessage', token);"," }"," onErrorMessage(token) {"," this.connection.emit('errorMessage', token);"],"context_line":" const error = new _errors.ConnectionError(token.message, 'ELOGIN');","post_context":[" const isLoginErrorTransient = this.connection.transientErrorLookup.isTransientError(token.number);"," if (isLoginErrorTransient && this.connection.curTransientRetryCount !== this.connection.config.options.maxRetriesOnTransientErrors) {"," error.isTransient = true;"," }"," this.connection.loginError = error;"," }"," onSSPI(token) {"]}]},"mechanism":{"type":"onuncaughtexception","handled":false}}]},"event_id":"3f2c0f09bec345f8972a9ab81c093bbe","level":"fatal","platform":"node","contexts":{"trace":{"trace_id":"bbbd82ae0d674bf690f3f86e85c7f603","span_id":"904855caf7484af9"},"runtime":{"name":"node","version":"v18.20.5"},"app":{"app_start_time":"2025-02-27T21:14:58.550Z","app_memory":104890368},"os":{"kernel_version":"5.15.0-1079-azure","name":"Ubuntu Linux","version":"20.04"},"device":{"boot_time":"2025-02-27T21:00:39.435Z","arch":"x64","memory_size":16768323584,"free_memory":14061731840,"processor_count":4,"cpu_description":"AMD EPYC 7763 64-Core Processor","processor_frequency":3242},"culture":{"locale":"en-US","timezone":"UTC"},"cloud_resource":{}},"server_name":"fv-az1150-349","timestamp":1740690899.488,"environment":"production","release":"1.0","sdk":{"integrations":["InboundFilters","FunctionToString","LinkedErrors","RequestData","Console","Http","NodeFetch","OnUncaughtException","OnUnhandledRejection","ContextLines","LocalVariables","Context","ChildProcess","ProcessSession","Modules","Express","Fastify","Graphql","Mongo","Mongoose","Mysql","Mysql2","Redis","Postgres","Hapi","Koa","Connect","Tedious","GenericPool","Kafka","Amqplib","LruMemoizer","VercelAI"],"name":"sentry.javascript.node","version":"9.2.0","packages":[{"name":"npm:@sentry/node","version":"9.2.0"}]},"modules":{"semver":"7.6.3","shimmer":"1.2.1","require-in-the-middle":"7.2.0","resolve":"1.22.8","is-core-module":"2.13.0","has":"1.0.3","function-bind":"1.1.2","debug":"4.4.0","supports-color":"7.2.0","has-flag":"4.0.0","ms":"2.1.3","module-details-from-path":"1.0.3","import-in-the-middle":"1.13.0","forwarded-parse":"2.1.2","tedious":"18.6.1","tslib":"2.8.1","uuid":"8.3.2","jsonwebtoken":"9.0.2","safe-buffer":"5.2.1","buffer-equal-constant-time":"1.0.1","ecdsa-sig-formatter":"1.0.11","lodash.includes":"4.3.0","lodash.isboolean":"3.0.3","lodash.isinteger":"4.0.4","lodash.isnumber":"3.0.3","lodash.isplainobject":"4.0.6","lodash.isstring":"4.0.1","lodash.once":"4.1.1","open":"8.4.2","is-wsl":"2.2.0","is-docker":"2.2.1","define-lazy-prop":"2.0.0","sprintf-js":"1.1.3","js-md4":"0.3.2","native-duplexpair":"1.0.0","process":"0.11.10","inherits":"2.0.4","iconv-lite":"0.6.3","safer-buffer":"2.1.2"}}]

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test: Log out envelope item for failing node integration tests - #15532

Merged
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious
Feb 27, 2025
Merged

test: Log out envelope item for failing node integration tests#15532
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Contributor

While trying to debug the tedious integration, I figured it would be nice to internals of the envelope item when receiving mismatched envelope items. This PR adds the the serialized envelope item to the error being thrown.

@AbhiPrasad
AbhiPrasad requested a review from a teamFebruary 27, 2025 21:10
@AbhiPrasadAbhiPrasad self-assigned this Feb 27, 2025
@AbhiPrasad
AbhiPrasad requested review from mydea and s1gr1d and removed request for a teamFebruary 27, 2025 21:10
@AbhiPrasad
AbhiPrasad merged commit e9d2295 into developFeb 27, 2025
@AbhiPrasad
AbhiPrasad deleted the abhi-better-envelope-logging-tedious branch February 27, 2025 22:02
@AbhiPrasad

Copy link
Copy Markdown
ContributorAuthor

Success!

https://github.com/getsentry/sentry-javascript/actions/runs/13575927930/job/37952099013?pr=15532

 FAIL suites/tracing/tedious/test.ts > tedious auto instrumentation > should auto-instrument `tedious` package
Error: Expected envelope item type 'transaction' but got 'event'. Item: [{"type":"event"},{"exception":{"values":[{"type":"Error","value":"Login failed for user 'sa'.","stacktrace":{"frames":[{"filename":"node:internal/process/task_queues","module":"task_queues","function":"process.processTicksAndRejections","lineno":95,"colno":5,"in_app":false},{"filename":"node:internal/streams/from","module":"from","function":"next","lineno":98,"colno":31,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"Readable.push","lineno":278,"colno":10,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"readableAddChunk","lineno":341,"colno":9,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"addChunk","lineno":368,"colno":12,"in_app":false},{"filename":"node:events","module":"node:events","function":"Readable.emit","lineno":517,"colno":28,"in_app":false},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js","module":"tedious.lib.token:token-stream-parser","function":"Readable.?","lineno":19,"colno":33,"in_app":false,"pre_context":[" constructor(message, debug, handler, options) {"," super();"," this.debug = debug;"," this.options = options;"," this.parser = _stream.Readable.from(_streamParser.default.parseTokens(message, this.debug, this.options));"," this.parser.on('data', token => {"," debug.token(token);"],"context_line":" handler[token.handlerName](token);","post_context":[" });"," this.parser.on('drain', () => {"," this.emit('drain');"," });"," this.parser.on('end', () => {"," this.emit('end');"," });"]},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/handler.js","module":"tedious.lib.token:handler","function":"Login7TokenHandler.onErrorMessage","lineno":186,"colno":19,"in_app":false,"pre_context":[" this.connection = connection;"," }"," onInfoMessage(token) {"," this.connection.emit('infoMessage', token);"," }"," onErrorMessage(token) {"," this.connection.emit('errorMessage', token);"],"context_line":" const error = new _errors.ConnectionError(token.message, 'ELOGIN');","post_context":[" const isLoginErrorTransient = this.connection.transientErrorLookup.isTransientError(token.number);"," if (isLoginErrorTransient && this.connection.curTransientRetryCount !== this.connection.config.options.maxRetriesOnTransientErrors) {"," error.isTransient = true;"," }"," this.connection.loginError = error;"," }"," onSSPI(token) {"]}]},"mechanism":{"type":"onuncaughtexception","handled":false}}]},"event_id":"3f2c0f09bec345f8972a9ab81c093bbe","level":"fatal","platform":"node","contexts":{"trace":{"trace_id":"bbbd82ae0d674bf690f3f86e85c7f603","span_id":"904855caf7484af9"},"runtime":{"name":"node","version":"v18.20.5"},"app":{"app_start_time":"2025-02-27T21:14:58.550Z","app_memory":104890368},"os":{"kernel_version":"5.15.0-1079-azure","name":"Ubuntu Linux","version":"20.04"},"device":{"boot_time":"2025-02-27T21:00:39.435Z","arch":"x64","memory_size":16768323584,"free_memory":14061731840,"processor_count":4,"cpu_description":"AMD EPYC 7763 64-Core Processor","processor_frequency":3242},"culture":{"locale":"en-US","timezone":"UTC"},"cloud_resource":{}},"server_name":"fv-az1150-349","timestamp":1740690899.488,"environment":"production","release":"1.0","sdk":{"integrations":["InboundFilters","FunctionToString","LinkedErrors","RequestData","Console","Http","NodeFetch","OnUncaughtException","OnUnhandledRejection","ContextLines","LocalVariables","Context","ChildProcess","ProcessSession","Modules","Express","Fastify","Graphql","Mongo","Mongoose","Mysql","Mysql2","Redis","Postgres","Hapi","Koa","Connect","Tedious","GenericPool","Kafka","Amqplib","LruMemoizer","VercelAI"],"name":"sentry.javascript.node","version":"9.2.0","packages":[{"name":"npm:@sentry/node","version":"9.2.0"}]},"modules":{"semver":"7.6.3","shimmer":"1.2.1","require-in-the-middle":"7.2.0","resolve":"1.22.8","is-core-module":"2.13.0","has":"1.0.3","function-bind":"1.1.2","debug":"4.4.0","supports-color":"7.2.0","has-flag":"4.0.0","ms":"2.1.3","module-details-from-path":"1.0.3","import-in-the-middle":"1.13.0","forwarded-parse":"2.1.2","tedious":"18.6.1","tslib":"2.8.1","uuid":"8.3.2","jsonwebtoken":"9.0.2","safe-buffer":"5.2.1","buffer-equal-constant-time":"1.0.1","ecdsa-sig-formatter":"1.0.11","lodash.includes":"4.3.0","lodash.isboolean":"3.0.3","lodash.isinteger":"4.0.4","lodash.isnumber":"3.0.3","lodash.isplainobject":"4.0.6","lodash.isstring":"4.0.1","lodash.once":"4.1.1","open":"8.4.2","is-wsl":"2.2.0","is-docker":"2.2.1","define-lazy-prop":"2.0.0","sprintf-js":"1.1.3","js-md4":"0.3.2","native-duplexpair":"1.0.0","process":"0.11.10","inherits":"2.0.4","iconv-lite":"0.6.3","safer-buffer":"2.1.2"}}]

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@andreiborza
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

test: Log out envelope item for failing node integration tests - #15532

Merged
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious
Feb 27, 2025
Merged

test: Log out envelope item for failing node integration tests#15532
AbhiPrasad merged 1 commit into
developfrom
abhi-better-envelope-logging-tedious

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Contributor

While trying to debug the tedious integration, I figured it would be nice to internals of the envelope item when receiving mismatched envelope items. This PR adds the the serialized envelope item to the error being thrown.

@AbhiPrasad
AbhiPrasad requested a review from a teamFebruary 27, 2025 21:10
@AbhiPrasadAbhiPrasad self-assigned this Feb 27, 2025
@AbhiPrasad
AbhiPrasad requested review from mydea and s1gr1d and removed request for a teamFebruary 27, 2025 21:10
@AbhiPrasad
AbhiPrasad merged commit e9d2295 into developFeb 27, 2025
@AbhiPrasad
AbhiPrasad deleted the abhi-better-envelope-logging-tedious branch February 27, 2025 22:02
@AbhiPrasad

Copy link
Copy Markdown
ContributorAuthor

Success!

https://github.com/getsentry/sentry-javascript/actions/runs/13575927930/job/37952099013?pr=15532

 FAIL suites/tracing/tedious/test.ts > tedious auto instrumentation > should auto-instrument `tedious` package
Error: Expected envelope item type 'transaction' but got 'event'. Item: [{"type":"event"},{"exception":{"values":[{"type":"Error","value":"Login failed for user 'sa'.","stacktrace":{"frames":[{"filename":"node:internal/process/task_queues","module":"task_queues","function":"process.processTicksAndRejections","lineno":95,"colno":5,"in_app":false},{"filename":"node:internal/streams/from","module":"from","function":"next","lineno":98,"colno":31,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"Readable.push","lineno":278,"colno":10,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"readableAddChunk","lineno":341,"colno":9,"in_app":false},{"filename":"node:internal/streams/readable","module":"readable","function":"addChunk","lineno":368,"colno":12,"in_app":false},{"filename":"node:events","module":"node:events","function":"Readable.emit","lineno":517,"colno":28,"in_app":false},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/token-stream-parser.js","module":"tedious.lib.token:token-stream-parser","function":"Readable.?","lineno":19,"colno":33,"in_app":false,"pre_context":[" constructor(message, debug, handler, options) {"," super();"," this.debug = debug;"," this.options = options;"," this.parser = _stream.Readable.from(_streamParser.default.parseTokens(message, this.debug, this.options));"," this.parser.on('data', token => {"," debug.token(token);"],"context_line":" handler[token.handlerName](token);","post_context":[" });"," this.parser.on('drain', () => {"," this.emit('drain');"," });"," this.parser.on('end', () => {"," this.emit('end');"," });"]},{"filename":"/home/runner/work/sentry-javascript/sentry-javascript/node_modules/tedious/lib/token/handler.js","module":"tedious.lib.token:handler","function":"Login7TokenHandler.onErrorMessage","lineno":186,"colno":19,"in_app":false,"pre_context":[" this.connection = connection;"," }"," onInfoMessage(token) {"," this.connection.emit('infoMessage', token);"," }"," onErrorMessage(token) {"," this.connection.emit('errorMessage', token);"],"context_line":" const error = new _errors.ConnectionError(token.message, 'ELOGIN');","post_context":[" const isLoginErrorTransient = this.connection.transientErrorLookup.isTransientError(token.number);"," if (isLoginErrorTransient && this.connection.curTransientRetryCount !== this.connection.config.options.maxRetriesOnTransientErrors) {"," error.isTransient = true;"," }"," this.connection.loginError = error;"," }"," onSSPI(token) {"]}]},"mechanism":{"type":"onuncaughtexception","handled":false}}]},"event_id":"3f2c0f09bec345f8972a9ab81c093bbe","level":"fatal","platform":"node","contexts":{"trace":{"trace_id":"bbbd82ae0d674bf690f3f86e85c7f603","span_id":"904855caf7484af9"},"runtime":{"name":"node","version":"v18.20.5"},"app":{"app_start_time":"2025-02-27T21:14:58.550Z","app_memory":104890368},"os":{"kernel_version":"5.15.0-1079-azure","name":"Ubuntu Linux","version":"20.04"},"device":{"boot_time":"2025-02-27T21:00:39.435Z","arch":"x64","memory_size":16768323584,"free_memory":14061731840,"processor_count":4,"cpu_description":"AMD EPYC 7763 64-Core Processor","processor_frequency":3242},"culture":{"locale":"en-US","timezone":"UTC"},"cloud_resource":{}},"server_name":"fv-az1150-349","timestamp":1740690899.488,"environment":"production","release":"1.0","sdk":{"integrations":["InboundFilters","FunctionToString","LinkedErrors","RequestData","Console","Http","NodeFetch","OnUncaughtException","OnUnhandledRejection","ContextLines","LocalVariables","Context","ChildProcess","ProcessSession","Modules","Express","Fastify","Graphql","Mongo","Mongoose","Mysql","Mysql2","Redis","Postgres","Hapi","Koa","Connect","Tedious","GenericPool","Kafka","Amqplib","LruMemoizer","VercelAI"],"name":"sentry.javascript.node","version":"9.2.0","packages":[{"name":"npm:@sentry/node","version":"9.2.0"}]},"modules":{"semver":"7.6.3","shimmer":"1.2.1","require-in-the-middle":"7.2.0","resolve":"1.22.8","is-core-module":"2.13.0","has":"1.0.3","function-bind":"1.1.2","debug":"4.4.0","supports-color":"7.2.0","has-flag":"4.0.0","ms":"2.1.3","module-details-from-path":"1.0.3","import-in-the-middle":"1.13.0","forwarded-parse":"2.1.2","tedious":"18.6.1","tslib":"2.8.1","uuid":"8.3.2","jsonwebtoken":"9.0.2","safe-buffer":"5.2.1","buffer-equal-constant-time":"1.0.1","ecdsa-sig-formatter":"1.0.11","lodash.includes":"4.3.0","lodash.isboolean":"3.0.3","lodash.isinteger":"4.0.4","lodash.isnumber":"3.0.3","lodash.isplainobject":"4.0.6","lodash.isstring":"4.0.1","lodash.once":"4.1.1","open":"8.4.2","is-wsl":"2.2.0","is-docker":"2.2.1","define-lazy-prop":"2.0.0","sprintf-js":"1.1.3","js-md4":"0.3.2","native-duplexpair":"1.0.0","process":"0.11.10","inherits":"2.0.4","iconv-lite":"0.6.3","safer-buffer":"2.1.2"}}]

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AbhiPrasad@andreiborza