Skip to content

feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled - #15730

Merged
mydea merged 1 commit into
developfrom
fn/skip-http-spans-without-performance
May 21, 2025
Merged

feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled#15730
mydea merged 1 commit into
developfrom
fn/skip-http-spans-without-performance

Conversation

@mydea

@mydeamydea commented Mar 19, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Part of #15725, this PR stops adding the HttpInstrumentation / UndiciInstrumentation if tracing is not enabled.

I think this should not really be breaking, as the integrations should not do anything else, if tracing is disabled 🤔

This only skips the http instrumentation without spans on node 22+, as only there our own diagnostics-channel based instrumentation can cover everything we need.

@mydeamydea self-assigned this Mar 19, 2025
@mydeamydea mentioned this pull request Mar 19, 2025
Merged
mydea added a commit that referenced this pull request Mar 19, 2025
@mydea
fix(node): Ensure incoming traces are propagated without HttpInstrume…
fa8e043
…ntation (#15732)
Part of #15730
Noticed that this is not really happening otherwise, so if we are not
adding the `HttpInstrumentation` we now make sure to extract incoming
traces ourselves! This will unlock us not adding that instrumentation
when tracing is disabled.
Also includes #15731
as a side effect.
mydea added a commit that referenced this pull request Mar 19, 2025
@mydea
fix(node): Ensure httpIntegration propagates traces
20a9060
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydeamydea mentioned this pull request Mar 19, 2025
Closed
chargome pushed a commit that referenced this pull request Mar 19, 2025
@mydea@chargome
fix(node): Ensure httpIntegration propagates traces
ce13e76
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydea
mydeaforce-pushed the fn/skip-http-spans-without-performance branch from 259f829 to 34f5b2aCompareMay 20, 2025 12:40
@github-actions

github-actionsBot commented May 20, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser23.95 kB--
@sentry/browser - with treeshaking flags23.71 kB--
@sentry/browser (incl. Tracing)38.36 kB--
@sentry/browser (incl. Tracing, Replay)76.47 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.58 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)81.25 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)93.35 kB--
@sentry/browser (incl. Feedback)40.72 kB--
@sentry/browser (incl. sendFeedback)28.67 kB--
@sentry/browser (incl. FeedbackAsync)33.56 kB--
@sentry/react25.73 kB--
@sentry/react (incl. Tracing)40.34 kB--
@sentry/vue28.34 kB--
@sentry/vue (incl. Tracing)40.19 kB--
@sentry/svelte23.97 kB--
CDN Bundle25.23 kB--
CDN Bundle (incl. Tracing)38.52 kB--
CDN Bundle (incl. Tracing, Replay)74.3 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)79.75 kB--
CDN Bundle - uncompressed73.63 kB--
CDN Bundle (incl. Tracing) - uncompressed114.03 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed228 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed240.82 kB--
@sentry/nextjs (client)41.99 kB--
@sentry/sveltekit (client)38.84 kB--
@sentry/node149.5 kB+0.03%+38 B 🔺
@sentry/node - without tracing98.12 kB+0.02%+18 B 🔺
@sentry/aws-serverless123.46 kB+0.03%+27 B 🔺

View base workflow run

@mydea
mydeaforce-pushed the fn/skip-http-spans-without-performance branch from 34f5b2a to f6f52ffCompareMay 20, 2025 13:27
@mydea
mydea requested review from Lms24 and chargomeMay 20, 2025 13:27
@mydea
mydea marked this pull request as ready for review May 20, 2025 13:27
chargome
chargome approved these changes May 21, 2025
View reviewed changes

@chargomechargome left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mydea
mydea merged commit b4bd21f into developMay 21, 2025
@mydea
mydea deleted the fn/skip-http-spans-without-performance branch May 21, 2025 14:38
@andreiborzaandreiborza mentioned this pull request Jun 3, 2025
Closed
3 tasks
This was referenced Sep 29, 2025
Closed
Closed
This was referenced Oct 7, 2025
Closed
Closed
This was referenced Oct 15, 2025
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@mydeamydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@chargome
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled by mydea · Pull Request #15730 · getsentry/sentry-javascript · GitHub
Skip to content
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled - #15730
Merged
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
May 21, 2025
Merged
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled#15730
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
Conversation
@mydea
@mydeamydea
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Part of #15725, this PR stops adding the HttpInstrumentation / UndiciInstrumentation if tracing is not enabled.
I think this should not really be breaking, as the integrations should not do anything else, if tracing is disabled 🤔
This only skips the http instrumentation without spans on node 22+, as only there our own diagnostics-channel based instrumentation can cover everything we need.
@mydeamydea
self-assigned this
Mar 19, 2025
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Merged

mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure incoming traces are propagated without HttpInstrume…
fa8e043
…ntation (#15732)
Part of #15730
Noticed that this is not really happening otherwise, so if we are not
adding the `HttpInstrumentation` we now make sure to extract incoming
traces ourselves! This will unlock us not adding that instrumentation
when tracing is disabled.
Also includes #15731
as a side effect.
mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure httpIntegration propagates traces
20a9060
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Closed

chargome pushed a commit
that referenced
this pull request
Mar 19, 2025
@mydea@chargome
fix(node): Ensure httpIntegration propagates traces
ce13e76
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
259f829 to
34f5b2aCompareMay 20, 2025 12:40
@github-actions
github-actionsBot
commented
May 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.95 kB--
@sentry/browser - with treeshaking flags23.71 kB--
@sentry/browser (incl. Tracing)38.36 kB--
@sentry/browser (incl. Tracing, Replay)76.47 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.58 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)81.25 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)93.35 kB--
@sentry/browser (incl. Feedback)40.72 kB--
@sentry/browser (incl. sendFeedback)28.67 kB--
@sentry/browser (incl. FeedbackAsync)33.56 kB--
@sentry/react25.73 kB--
@sentry/react (incl. Tracing)40.34 kB--
@sentry/vue28.34 kB--
@sentry/vue (incl. Tracing)40.19 kB--
@sentry/svelte23.97 kB--
CDN Bundle25.23 kB--
CDN Bundle (incl. Tracing)38.52 kB--
CDN Bundle (incl. Tracing, Replay)74.3 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)79.75 kB--
CDN Bundle - uncompressed73.63 kB--
CDN Bundle (incl. Tracing) - uncompressed114.03 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed228 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed240.82 kB--
@sentry/nextjs (client)41.99 kB--
@sentry/sveltekit (client)38.84 kB--
@sentry/node149.5 kB+0.03%+38 B 🔺
@sentry/node - without tracing98.12 kB+0.02%+18 B 🔺
@sentry/aws-serverless123.46 kB+0.03%+27 B 🔺
View base workflow run
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
34f5b2a to
f6f52ffCompareMay 20, 2025 13:27
@mydea
mydea
requested review from
Lms24 and chargomeMay 20, 2025 13:27
@mydea
mydea
marked this pull request as ready for review
May 20, 2025 13:27
chargome
chargome
approved these changes
May 21, 2025
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@mydea
mydea
merged commit b4bd21f
into
developMay 21, 2025
@mydea
mydea
deleted the

fn/skip-http-spans-without-performance

branch
May 21, 2025 14:38
@andreiborzaandreiborza
mentioned this pull request
Jun 3, 2025

Closed

3 tasks

This was referenced Sep 29, 2025
 Closed

 Closed


This was referenced Oct 7, 2025
 Closed

 Closed


This was referenced Oct 15, 2025
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled by mydea · Pull Request #15730 · getsentry/sentry-javascript · GitHub
Skip to content
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled - #15730
Merged
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
May 21, 2025
Merged
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled#15730
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
Conversation
@mydea
@mydeamydea
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Part of #15725, this PR stops adding the HttpInstrumentation / UndiciInstrumentation if tracing is not enabled.
I think this should not really be breaking, as the integrations should not do anything else, if tracing is disabled 🤔
This only skips the http instrumentation without spans on node 22+, as only there our own diagnostics-channel based instrumentation can cover everything we need.
@mydeamydea
self-assigned this
Mar 19, 2025
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Merged

mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure incoming traces are propagated without HttpInstrume…
fa8e043
…ntation (#15732)
Part of #15730
Noticed that this is not really happening otherwise, so if we are not
adding the `HttpInstrumentation` we now make sure to extract incoming
traces ourselves! This will unlock us not adding that instrumentation
when tracing is disabled.
Also includes #15731
as a side effect.
mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure httpIntegration propagates traces
20a9060
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Closed

chargome pushed a commit
that referenced
this pull request
Mar 19, 2025
@mydea@chargome
fix(node): Ensure httpIntegration propagates traces
ce13e76
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
259f829 to
34f5b2aCompareMay 20, 2025 12:40
@github-actions
github-actionsBot
commented
May 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.95 kB--
@sentry/browser - with treeshaking flags23.71 kB--
@sentry/browser (incl. Tracing)38.36 kB--
@sentry/browser (incl. Tracing, Replay)76.47 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.58 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)81.25 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)93.35 kB--
@sentry/browser (incl. Feedback)40.72 kB--
@sentry/browser (incl. sendFeedback)28.67 kB--
@sentry/browser (incl. FeedbackAsync)33.56 kB--
@sentry/react25.73 kB--
@sentry/react (incl. Tracing)40.34 kB--
@sentry/vue28.34 kB--
@sentry/vue (incl. Tracing)40.19 kB--
@sentry/svelte23.97 kB--
CDN Bundle25.23 kB--
CDN Bundle (incl. Tracing)38.52 kB--
CDN Bundle (incl. Tracing, Replay)74.3 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)79.75 kB--
CDN Bundle - uncompressed73.63 kB--
CDN Bundle (incl. Tracing) - uncompressed114.03 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed228 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed240.82 kB--
@sentry/nextjs (client)41.99 kB--
@sentry/sveltekit (client)38.84 kB--
@sentry/node149.5 kB+0.03%+38 B 🔺
@sentry/node - without tracing98.12 kB+0.02%+18 B 🔺
@sentry/aws-serverless123.46 kB+0.03%+27 B 🔺
View base workflow run
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
34f5b2a to
f6f52ffCompareMay 20, 2025 13:27
@mydea
mydea
requested review from
Lms24 and chargomeMay 20, 2025 13:27
@mydea
mydea
marked this pull request as ready for review
May 20, 2025 13:27
chargome
chargome
approved these changes
May 21, 2025
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@mydea
mydea
merged commit b4bd21f
into
developMay 21, 2025
@mydea
mydea
deleted the

fn/skip-http-spans-without-performance

branch
May 21, 2025 14:38
@andreiborzaandreiborza
mentioned this pull request
Jun 3, 2025

Closed

3 tasks

This was referenced Sep 29, 2025
 Closed

 Closed


This was referenced Oct 7, 2025
 Closed

 Closed


This was referenced Oct 15, 2025
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled by mydea · Pull Request #15730 · getsentry/sentry-javascript · GitHub
Skip to content
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled - #15730
Merged
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
May 21, 2025
Merged
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled#15730
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
Conversation
@mydea
@mydeamydea
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Part of #15725, this PR stops adding the HttpInstrumentation / UndiciInstrumentation if tracing is not enabled.
I think this should not really be breaking, as the integrations should not do anything else, if tracing is disabled 🤔
This only skips the http instrumentation without spans on node 22+, as only there our own diagnostics-channel based instrumentation can cover everything we need.
@mydeamydea
self-assigned this
Mar 19, 2025
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Merged

mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure incoming traces are propagated without HttpInstrume…
fa8e043
…ntation (#15732)
Part of #15730
Noticed that this is not really happening otherwise, so if we are not
adding the `HttpInstrumentation` we now make sure to extract incoming
traces ourselves! This will unlock us not adding that instrumentation
when tracing is disabled.
Also includes #15731
as a side effect.
mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure httpIntegration propagates traces
20a9060
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Closed

chargome pushed a commit
that referenced
this pull request
Mar 19, 2025
@mydea@chargome
fix(node): Ensure httpIntegration propagates traces
ce13e76
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
259f829 to
34f5b2aCompareMay 20, 2025 12:40
@github-actions
github-actionsBot
commented
May 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.95 kB--
@sentry/browser - with treeshaking flags23.71 kB--
@sentry/browser (incl. Tracing)38.36 kB--
@sentry/browser (incl. Tracing, Replay)76.47 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.58 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)81.25 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)93.35 kB--
@sentry/browser (incl. Feedback)40.72 kB--
@sentry/browser (incl. sendFeedback)28.67 kB--
@sentry/browser (incl. FeedbackAsync)33.56 kB--
@sentry/react25.73 kB--
@sentry/react (incl. Tracing)40.34 kB--
@sentry/vue28.34 kB--
@sentry/vue (incl. Tracing)40.19 kB--
@sentry/svelte23.97 kB--
CDN Bundle25.23 kB--
CDN Bundle (incl. Tracing)38.52 kB--
CDN Bundle (incl. Tracing, Replay)74.3 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)79.75 kB--
CDN Bundle - uncompressed73.63 kB--
CDN Bundle (incl. Tracing) - uncompressed114.03 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed228 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed240.82 kB--
@sentry/nextjs (client)41.99 kB--
@sentry/sveltekit (client)38.84 kB--
@sentry/node149.5 kB+0.03%+38 B 🔺
@sentry/node - without tracing98.12 kB+0.02%+18 B 🔺
@sentry/aws-serverless123.46 kB+0.03%+27 B 🔺
View base workflow run
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
34f5b2a to
f6f52ffCompareMay 20, 2025 13:27
@mydea
mydea
requested review from
Lms24 and chargomeMay 20, 2025 13:27
@mydea
mydea
marked this pull request as ready for review
May 20, 2025 13:27
chargome
chargome
approved these changes
May 21, 2025
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@mydea
mydea
merged commit b4bd21f
into
developMay 21, 2025
@mydea
mydea
deleted the

fn/skip-http-spans-without-performance

branch
May 21, 2025 14:38
@andreiborzaandreiborza
mentioned this pull request
Jun 3, 2025

Closed

3 tasks

This was referenced Sep 29, 2025
 Closed

 Closed


This was referenced Oct 7, 2025
 Closed

 Closed


This was referenced Oct 15, 2025
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled by mydea · Pull Request #15730 · getsentry/sentry-javascript · GitHub
Skip to content
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled - #15730
Merged
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
May 21, 2025
Merged
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled#15730
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
Conversation
@mydea
@mydeamydea
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Part of #15725, this PR stops adding the HttpInstrumentation / UndiciInstrumentation if tracing is not enabled.
I think this should not really be breaking, as the integrations should not do anything else, if tracing is disabled 🤔
This only skips the http instrumentation without spans on node 22+, as only there our own diagnostics-channel based instrumentation can cover everything we need.
@mydeamydea
self-assigned this
Mar 19, 2025
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Merged

mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure incoming traces are propagated without HttpInstrume…
fa8e043
…ntation (#15732)
Part of #15730
Noticed that this is not really happening otherwise, so if we are not
adding the `HttpInstrumentation` we now make sure to extract incoming
traces ourselves! This will unlock us not adding that instrumentation
when tracing is disabled.
Also includes #15731
as a side effect.
mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure httpIntegration propagates traces
20a9060
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Closed

chargome pushed a commit
that referenced
this pull request
Mar 19, 2025
@mydea@chargome
fix(node): Ensure httpIntegration propagates traces
ce13e76
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
259f829 to
34f5b2aCompareMay 20, 2025 12:40
@github-actions
github-actionsBot
commented
May 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.95 kB--
@sentry/browser - with treeshaking flags23.71 kB--
@sentry/browser (incl. Tracing)38.36 kB--
@sentry/browser (incl. Tracing, Replay)76.47 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.58 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)81.25 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)93.35 kB--
@sentry/browser (incl. Feedback)40.72 kB--
@sentry/browser (incl. sendFeedback)28.67 kB--
@sentry/browser (incl. FeedbackAsync)33.56 kB--
@sentry/react25.73 kB--
@sentry/react (incl. Tracing)40.34 kB--
@sentry/vue28.34 kB--
@sentry/vue (incl. Tracing)40.19 kB--
@sentry/svelte23.97 kB--
CDN Bundle25.23 kB--
CDN Bundle (incl. Tracing)38.52 kB--
CDN Bundle (incl. Tracing, Replay)74.3 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)79.75 kB--
CDN Bundle - uncompressed73.63 kB--
CDN Bundle (incl. Tracing) - uncompressed114.03 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed228 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed240.82 kB--
@sentry/nextjs (client)41.99 kB--
@sentry/sveltekit (client)38.84 kB--
@sentry/node149.5 kB+0.03%+38 B 🔺
@sentry/node - without tracing98.12 kB+0.02%+18 B 🔺
@sentry/aws-serverless123.46 kB+0.03%+27 B 🔺
View base workflow run
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
34f5b2a to
f6f52ffCompareMay 20, 2025 13:27
@mydea
mydea
requested review from
Lms24 and chargomeMay 20, 2025 13:27
@mydea
mydea
marked this pull request as ready for review
May 20, 2025 13:27
chargome
chargome
approved these changes
May 21, 2025
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@mydea
mydea
merged commit b4bd21f
into
developMay 21, 2025
@mydea
mydea
deleted the

fn/skip-http-spans-without-performance

branch
May 21, 2025 14:38
@andreiborzaandreiborza
mentioned this pull request
Jun 3, 2025

Closed

3 tasks

This was referenced Sep 29, 2025
 Closed

 Closed


This was referenced Oct 7, 2025
 Closed

 Closed


This was referenced Oct 15, 2025
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled by mydea · Pull Request #15730 · getsentry/sentry-javascript · GitHub
Skip to content
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled - #15730
Merged
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
May 21, 2025
Merged
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled#15730
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
Conversation
@mydea
@mydeamydea
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Part of #15725, this PR stops adding the HttpInstrumentation / UndiciInstrumentation if tracing is not enabled.
I think this should not really be breaking, as the integrations should not do anything else, if tracing is disabled 🤔
This only skips the http instrumentation without spans on node 22+, as only there our own diagnostics-channel based instrumentation can cover everything we need.
@mydeamydea
self-assigned this
Mar 19, 2025
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Merged

mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure incoming traces are propagated without HttpInstrume…
fa8e043
…ntation (#15732)
Part of #15730
Noticed that this is not really happening otherwise, so if we are not
adding the `HttpInstrumentation` we now make sure to extract incoming
traces ourselves! This will unlock us not adding that instrumentation
when tracing is disabled.
Also includes #15731
as a side effect.
mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure httpIntegration propagates traces
20a9060
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Closed

chargome pushed a commit
that referenced
this pull request
Mar 19, 2025
@mydea@chargome
fix(node): Ensure httpIntegration propagates traces
ce13e76
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
259f829 to
34f5b2aCompareMay 20, 2025 12:40
@github-actions
github-actionsBot
commented
May 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.95 kB--
@sentry/browser - with treeshaking flags23.71 kB--
@sentry/browser (incl. Tracing)38.36 kB--
@sentry/browser (incl. Tracing, Replay)76.47 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.58 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)81.25 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)93.35 kB--
@sentry/browser (incl. Feedback)40.72 kB--
@sentry/browser (incl. sendFeedback)28.67 kB--
@sentry/browser (incl. FeedbackAsync)33.56 kB--
@sentry/react25.73 kB--
@sentry/react (incl. Tracing)40.34 kB--
@sentry/vue28.34 kB--
@sentry/vue (incl. Tracing)40.19 kB--
@sentry/svelte23.97 kB--
CDN Bundle25.23 kB--
CDN Bundle (incl. Tracing)38.52 kB--
CDN Bundle (incl. Tracing, Replay)74.3 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)79.75 kB--
CDN Bundle - uncompressed73.63 kB--
CDN Bundle (incl. Tracing) - uncompressed114.03 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed228 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed240.82 kB--
@sentry/nextjs (client)41.99 kB--
@sentry/sveltekit (client)38.84 kB--
@sentry/node149.5 kB+0.03%+38 B 🔺
@sentry/node - without tracing98.12 kB+0.02%+18 B 🔺
@sentry/aws-serverless123.46 kB+0.03%+27 B 🔺
View base workflow run
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
34f5b2a to
f6f52ffCompareMay 20, 2025 13:27
@mydea
mydea
requested review from
Lms24 and chargomeMay 20, 2025 13:27
@mydea
mydea
marked this pull request as ready for review
May 20, 2025 13:27
chargome
chargome
approved these changes
May 21, 2025
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@mydea
mydea
merged commit b4bd21f
into
developMay 21, 2025
@mydea
mydea
deleted the

fn/skip-http-spans-without-performance

branch
May 21, 2025 14:38
@andreiborzaandreiborza
mentioned this pull request
Jun 3, 2025

Closed

3 tasks

This was referenced Sep 29, 2025
 Closed

 Closed


This was referenced Oct 7, 2025
 Closed

 Closed


This was referenced Oct 15, 2025
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled by mydea · Pull Request #15730 · getsentry/sentry-javascript · GitHub
Skip to content
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled - #15730
Merged
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
May 21, 2025
Merged
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled#15730
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
Conversation
@mydea
@mydeamydea
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Part of #15725, this PR stops adding the HttpInstrumentation / UndiciInstrumentation if tracing is not enabled.
I think this should not really be breaking, as the integrations should not do anything else, if tracing is disabled 🤔
This only skips the http instrumentation without spans on node 22+, as only there our own diagnostics-channel based instrumentation can cover everything we need.
@mydeamydea
self-assigned this
Mar 19, 2025
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Merged

mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure incoming traces are propagated without HttpInstrume…
fa8e043
…ntation (#15732)
Part of #15730
Noticed that this is not really happening otherwise, so if we are not
adding the `HttpInstrumentation` we now make sure to extract incoming
traces ourselves! This will unlock us not adding that instrumentation
when tracing is disabled.
Also includes #15731
as a side effect.
mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure httpIntegration propagates traces
20a9060
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Closed

chargome pushed a commit
that referenced
this pull request
Mar 19, 2025
@mydea@chargome
fix(node): Ensure httpIntegration propagates traces
ce13e76
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
259f829 to
34f5b2aCompareMay 20, 2025 12:40
@github-actions
github-actionsBot
commented
May 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.95 kB--
@sentry/browser - with treeshaking flags23.71 kB--
@sentry/browser (incl. Tracing)38.36 kB--
@sentry/browser (incl. Tracing, Replay)76.47 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.58 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)81.25 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)93.35 kB--
@sentry/browser (incl. Feedback)40.72 kB--
@sentry/browser (incl. sendFeedback)28.67 kB--
@sentry/browser (incl. FeedbackAsync)33.56 kB--
@sentry/react25.73 kB--
@sentry/react (incl. Tracing)40.34 kB--
@sentry/vue28.34 kB--
@sentry/vue (incl. Tracing)40.19 kB--
@sentry/svelte23.97 kB--
CDN Bundle25.23 kB--
CDN Bundle (incl. Tracing)38.52 kB--
CDN Bundle (incl. Tracing, Replay)74.3 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)79.75 kB--
CDN Bundle - uncompressed73.63 kB--
CDN Bundle (incl. Tracing) - uncompressed114.03 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed228 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed240.82 kB--
@sentry/nextjs (client)41.99 kB--
@sentry/sveltekit (client)38.84 kB--
@sentry/node149.5 kB+0.03%+38 B 🔺
@sentry/node - without tracing98.12 kB+0.02%+18 B 🔺
@sentry/aws-serverless123.46 kB+0.03%+27 B 🔺
View base workflow run
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
34f5b2a to
f6f52ffCompareMay 20, 2025 13:27
@mydea
mydea
requested review from
Lms24 and chargomeMay 20, 2025 13:27
@mydea
mydea
marked this pull request as ready for review
May 20, 2025 13:27
chargome
chargome
approved these changes
May 21, 2025
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@mydea
mydea
merged commit b4bd21f
into
developMay 21, 2025
@mydea
mydea
deleted the

fn/skip-http-spans-without-performance

branch
May 21, 2025 14:38
@andreiborzaandreiborza
mentioned this pull request
Jun 3, 2025

Closed

3 tasks

This was referenced Sep 29, 2025
 Closed

 Closed


This was referenced Oct 7, 2025
 Closed

 Closed


This was referenced Oct 15, 2025
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@chargome

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled by mydea · Pull Request #15730 · getsentry/sentry-javascript · GitHub
Skip to content
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled - #15730
Merged
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
May 21, 2025
Merged
feat(node): Do not add HTTP & fetch span instrumentation if tracing is disabled#15730
mydea merged 1 commit into
developfrom 
fn/skip-http-spans-without-performance
Conversation
@mydea
@mydeamydea
commented
Mar 19, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Part of #15725, this PR stops adding the HttpInstrumentation / UndiciInstrumentation if tracing is not enabled.
I think this should not really be breaking, as the integrations should not do anything else, if tracing is disabled 🤔
This only skips the http instrumentation without spans on node 22+, as only there our own diagnostics-channel based instrumentation can cover everything we need.
@mydeamydea
self-assigned this
Mar 19, 2025
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Merged

mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure incoming traces are propagated without HttpInstrume…
fa8e043
…ntation (#15732)
Part of #15730
Noticed that this is not really happening otherwise, so if we are not
adding the `HttpInstrumentation` we now make sure to extract incoming
traces ourselves! This will unlock us not adding that instrumentation
when tracing is disabled.
Also includes #15731
as a side effect.
mydea added a commit
that referenced
this pull request
Mar 19, 2025
@mydea
fix(node): Ensure httpIntegration propagates traces
20a9060
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydeamydea
mentioned this pull request
Mar 19, 2025
 Closed

chargome pushed a commit
that referenced
this pull request
Mar 19, 2025
@mydea@chargome
fix(node): Ensure httpIntegration propagates traces
ce13e76
This is another stab at #15233, which was reverted here: #15354, with a different implementation. It is required to make #15730 work.
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
259f829 to
34f5b2aCompareMay 20, 2025 12:40
@github-actions
github-actionsBot
commented
May 20, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.95 kB--
@sentry/browser - with treeshaking flags23.71 kB--
@sentry/browser (incl. Tracing)38.36 kB--
@sentry/browser (incl. Tracing, Replay)76.47 kB--
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags69.58 kB--
@sentry/browser (incl. Tracing, Replay with Canvas)81.25 kB--
@sentry/browser (incl. Tracing, Replay, Feedback)93.35 kB--
@sentry/browser (incl. Feedback)40.72 kB--
@sentry/browser (incl. sendFeedback)28.67 kB--
@sentry/browser (incl. FeedbackAsync)33.56 kB--
@sentry/react25.73 kB--
@sentry/react (incl. Tracing)40.34 kB--
@sentry/vue28.34 kB--
@sentry/vue (incl. Tracing)40.19 kB--
@sentry/svelte23.97 kB--
CDN Bundle25.23 kB--
CDN Bundle (incl. Tracing)38.52 kB--
CDN Bundle (incl. Tracing, Replay)74.3 kB--
CDN Bundle (incl. Tracing, Replay, Feedback)79.75 kB--
CDN Bundle - uncompressed73.63 kB--
CDN Bundle (incl. Tracing) - uncompressed114.03 kB--
CDN Bundle (incl. Tracing, Replay) - uncompressed228 kB--
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed240.82 kB--
@sentry/nextjs (client)41.99 kB--
@sentry/sveltekit (client)38.84 kB--
@sentry/node149.5 kB+0.03%+38 B 🔺
@sentry/node - without tracing98.12 kB+0.02%+18 B 🔺
@sentry/aws-serverless123.46 kB+0.03%+27 B 🔺
View base workflow run
@mydea
mydeaforce-pushed
the
fn/skip-http-spans-without-performance
branch
from
34f5b2a to
f6f52ffCompareMay 20, 2025 13:27
@mydea
mydea
requested review from
Lms24 and chargomeMay 20, 2025 13:27
@mydea
mydea
marked this pull request as ready for review
May 20, 2025 13:27
chargome
chargome
approved these changes
May 21, 2025
View reviewed changes
@chargomechargome
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@mydea
mydea
merged commit b4bd21f
into
developMay 21, 2025
@mydea
mydea
deleted the

fn/skip-http-spans-without-performance

branch
May 21, 2025 14:38
@andreiborzaandreiborza
mentioned this pull request
Jun 3, 2025

Closed

3 tasks

This was referenced Sep 29, 2025
 Closed

 Closed


This was referenced Oct 7, 2025
 Closed

 Closed


This was referenced Oct 15, 2025
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomechargome approved these changes
@Lms24Lms24Awaiting requested review from Lms24

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@chargome