Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '75.2 KB',
limit: '75.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand DownExpand Up@@ -79,7 +79,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration', 'replayCanvasIntegration'),
gzip: true,
limit: '80 KB',
limit: '80.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay, Feedback)',
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,15 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0

- feat(core): Add `captureLog` method ([#15717](https://github.com/getsentry/sentry-javascript/pull/15717))
- feat(remix/cloudflare): Export `sentryHandleError` ([#15726](https://github.com/getsentry/sentry-javascript/pull/15726))
- fix(node): Always flush on Vercel before Lambda freeze ([#15602](https://github.com/getsentry/sentry-javascript/pull/15602))
- fix(node): Ensure incoming traces are propagated without HttpInstrumentation ([#15732](https://github.com/getsentry/sentry-javascript/pull/15732))
- fix(node): Use `fatal` level for unhandled rejections in `strict` mode ([#15720](https://github.com/getsentry/sentry-javascript/pull/15720))
- fix(nuxt): Delete Nuxt server template injection ([#15749](https://github.com/getsentry/sentry-javascript/pull/15749))

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'none' })],
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

setTimeout(() => {
// should not be called
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject(new Error('test rejection'));
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
import * as childProcess from 'child_process';
import * as path from 'path';
import { afterAll, describe, expect, test } from 'vitest';
import { cleanupChildProcesses } from '../../../utils/runner';
import { createRunner } from '../../../utils/runner';

describe('onUnhandledRejectionIntegration', () => {
afterAll(() => {
cleanupChildProcesses();
});

test('should show string-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-string.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr.trim())
.toBe(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should show error-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-error.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: test rejection
at Object.<anonymous>`);
done();
});
}));

test('should not close process on unhandled rejection in strict mode', () =>
new Promise<void>(done => {
expect.assertions(4);

const testScriptPath = path.resolve(__dirname, 'mode-strict.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).not.toBeNull();
expect(err?.code).toBe(1);
expect(stdout).not.toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should not close process or warn on unhandled rejection in none mode', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-none.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr).toBe('');
done();
});
}));

test('captures exceptions for unhandled rejections', async () => {
await createRunner(__dirname, 'scenario-warn.ts')
.expect({
event: {
level: 'error',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});

test('captures exceptions for unhandled rejections in strict mode', async () => {
await createRunner(__dirname, 'scenario-strict.ts')
.expect({
event: {
level: 'fatal',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});
});
10 changes: 5 additions & 5 deletions docs/publishing-a-release.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,9 +20,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
[@getsentry/releases-approvers](https://github.com/orgs/getsentry/teams/release-approvers) to approve the release. a.
Once the release is completed, a sync from `master` ->` develop` will be automatically triggered

## Publishing a release for previous majors
## Publishing a release for previous majors or prerelease (alpha, beta) versions

1. Run `yarn changelog` on a previous major branch (e.g. `v8`) and determine what version will be released (we use
1. Run `yarn changelog` on a previous major branch (e.g. `v8` or `9.7.0-alpha`) and determine what version will be released (we use
[semver](https://semver.org))
2. Create a branch, e.g. `changelog-8.45.1`, off a previous major branch (e.g. `v8`)
3. Update `CHANGELOG.md` to add an entry for the next release number and a list of changes since the
Expand All@@ -32,9 +32,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
(as the commits already exist on this branch).
6. Once the PR is merged, open the [Prepare Release workflow](https://github.com/getsentry/sentry-javascript/actions/workflows/release.yml) and
fill in ![run-release-workflow.png](./assets/run-release-workflow.png)
1. The major branch you want to release for, e.g. `v8`
2. The version you want to release, e.g. `8.45.1`
3. The major branch to merge into, e.g. `v8`
1. The major branch you want to release for, e.g. `v8` or `9.7.0-alpha`
2. The version you want to release, e.g. `8.45.1` `9.7.0-alpha.1`
3. The major branch to merge into, e.g. `v8` `9.7.0-alpha`
7. Run the release workflow

## Updating the Changelog
Expand Down
4 changes: 4 additions & 0 deletions packages/browser/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
addAutoIpAddressToUser,
applySdkMetadata,
getSDKSource,
_INTERNAL_flushLogsBuffer,
} from '@sentry/core';
import { eventFromException, eventFromMessage } from './eventbuilder';
import { WINDOW } from './helpers';
Expand DownExpand Up@@ -85,6 +86,9 @@ export class BrowserClient extends Client<BrowserClientOptions> {
WINDOW.document.addEventListener('visibilitychange', () => {
if (WINDOW.document.visibilityState === 'hidden') {
this._flushOutcomes();
if (this._options._experiments?.enableLogs) {
_INTERNAL_flushLogsBuffer(this);
}
}
});
}
Expand Down
28 changes: 25 additions & 3 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ import type {
SpanContextData,
SpanJSON,
StartSpanOptions,
TraceContext,
TransactionEvent,
Transport,
TransportMakeRequestResponse,
Expand All@@ -44,7 +45,10 @@ import { afterSetupIntegrations } from './integration';
import { setupIntegration, setupIntegrations } from './integration';
import type { Scope } from './scope';
import { updateSession } from './session';
import { getDynamicSamplingContextFromScope } from './tracing/dynamicSamplingContext';
import {
getDynamicSamplingContextFromScope,
getDynamicSamplingContextFromSpan,
} from './tracing/dynamicSamplingContext';
import { createClientReportEnvelope } from './utils-hoist/clientreport';
import { dsnToString, makeDsn } from './utils-hoist/dsn';
import { addItemToEnvelope, createAttachmentEnvelopeItem } from './utils-hoist/envelope';
Expand All@@ -57,8 +61,9 @@ import { getPossibleEventMessages } from './utils/eventUtils';
import { merge } from './utils/merge';
import { parseSampleRate } from './utils/parseSampleRate';
import { prepareEvent } from './utils/prepareEvent';
import { showSpanDropWarning } from './utils/spanUtils';
import { showSpanDropWarning, spanToTraceContext } from './utils/spanUtils';
import { convertSpanJsonToTransactionEvent, convertTransactionEventToSpanJson } from './utils/transactionEvent';
import { _getSpanForScope } from './utils/spanOnScope';

const ALREADY_SEEN_ERROR = "Not capturing exception because it's already been captured.";
const MISSING_RELEASE_FOR_SESSION_ERROR = 'Discarded session because of missing or non-string release';
Expand DownExpand Up@@ -617,7 +622,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
public on(hook: 'close', callback: () => void): () => void;

/**
* Register a hook oin this client.
* Register a hook on this client.
*/
public on(hook: string, callback: unknown): () => void {
const hooks = (this._hooks[hook] = this._hooks[hook] || []);
Expand DownExpand Up@@ -1256,3 +1261,20 @@ function isErrorEvent(event: Event): event is ErrorEvent {
function isTransactionEvent(event: Event): event is TransactionEvent {
return event.type === 'transaction';
}

/** Extract trace information from scope */
export function _getTraceInfoFromScope(
client: Client,
scope: Scope | undefined,
): [dynamicSamplingContext: Partial<DynamicSamplingContext> | undefined, traceContext: TraceContext | undefined] {
if (!scope) {
return [undefined, undefined];
}

const span = _getSpanForScope(scope);
const traceContext = span ? spanToTraceContext(span) : getTraceContextFromScope(scope);
const dynamicSamplingContext = span
? getDynamicSamplingContextFromSpan(span)
: getDynamicSamplingContextFromScope(client, scope);
return [dynamicSamplingContext, traceContext];
}
1 change: 1 addition & 0 deletions packages/core/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -113,6 +113,7 @@ export { instrumentFetchRequest } from './fetch';
export { trpcMiddleware } from './trpc';
export { captureFeedback } from './feedback';
export type { ReportDialogOptions } from './report-dialog';
export { _INTERNAL_flushLogsBuffer } from './logs';

// TODO: Make this structure pretty again and don't do "export *"
export * from './utils-hoist/index';
Expand Down
15 changes: 15 additions & 0 deletions packages/core/src/logs/constants.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import type { LogSeverityLevel } from '../types-hoist';

/**
* Maps a log severity level to a log severity number.
*
* @see LogSeverityLevel
*/
export const SEVERITY_TEXT_TO_SEVERITY_NUMBER: Partial<Record<LogSeverityLevel, number>> = {
trace: 1,
debug: 5,
info: 9,
warn: 13,
error: 17,
fatal: 21,
};
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '75.2 KB',
limit: '75.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand DownExpand Up@@ -79,7 +79,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration', 'replayCanvasIntegration'),
gzip: true,
limit: '80 KB',
limit: '80.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay, Feedback)',
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,15 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0

- feat(core): Add `captureLog` method ([#15717](https://github.com/getsentry/sentry-javascript/pull/15717))
- feat(remix/cloudflare): Export `sentryHandleError` ([#15726](https://github.com/getsentry/sentry-javascript/pull/15726))
- fix(node): Always flush on Vercel before Lambda freeze ([#15602](https://github.com/getsentry/sentry-javascript/pull/15602))
- fix(node): Ensure incoming traces are propagated without HttpInstrumentation ([#15732](https://github.com/getsentry/sentry-javascript/pull/15732))
- fix(node): Use `fatal` level for unhandled rejections in `strict` mode ([#15720](https://github.com/getsentry/sentry-javascript/pull/15720))
- fix(nuxt): Delete Nuxt server template injection ([#15749](https://github.com/getsentry/sentry-javascript/pull/15749))

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'none' })],
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

setTimeout(() => {
// should not be called
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject(new Error('test rejection'));
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
import * as childProcess from 'child_process';
import * as path from 'path';
import { afterAll, describe, expect, test } from 'vitest';
import { cleanupChildProcesses } from '../../../utils/runner';
import { createRunner } from '../../../utils/runner';

describe('onUnhandledRejectionIntegration', () => {
afterAll(() => {
cleanupChildProcesses();
});

test('should show string-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-string.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr.trim())
.toBe(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should show error-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-error.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: test rejection
at Object.<anonymous>`);
done();
});
}));

test('should not close process on unhandled rejection in strict mode', () =>
new Promise<void>(done => {
expect.assertions(4);

const testScriptPath = path.resolve(__dirname, 'mode-strict.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).not.toBeNull();
expect(err?.code).toBe(1);
expect(stdout).not.toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should not close process or warn on unhandled rejection in none mode', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-none.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr).toBe('');
done();
});
}));

test('captures exceptions for unhandled rejections', async () => {
await createRunner(__dirname, 'scenario-warn.ts')
.expect({
event: {
level: 'error',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});

test('captures exceptions for unhandled rejections in strict mode', async () => {
await createRunner(__dirname, 'scenario-strict.ts')
.expect({
event: {
level: 'fatal',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});
});
10 changes: 5 additions & 5 deletions docs/publishing-a-release.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,9 +20,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
[@getsentry/releases-approvers](https://github.com/orgs/getsentry/teams/release-approvers) to approve the release. a.
Once the release is completed, a sync from `master` ->` develop` will be automatically triggered

## Publishing a release for previous majors
## Publishing a release for previous majors or prerelease (alpha, beta) versions

1. Run `yarn changelog` on a previous major branch (e.g. `v8`) and determine what version will be released (we use
1. Run `yarn changelog` on a previous major branch (e.g. `v8` or `9.7.0-alpha`) and determine what version will be released (we use
[semver](https://semver.org))
2. Create a branch, e.g. `changelog-8.45.1`, off a previous major branch (e.g. `v8`)
3. Update `CHANGELOG.md` to add an entry for the next release number and a list of changes since the
Expand All@@ -32,9 +32,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
(as the commits already exist on this branch).
6. Once the PR is merged, open the [Prepare Release workflow](https://github.com/getsentry/sentry-javascript/actions/workflows/release.yml) and
fill in ![run-release-workflow.png](./assets/run-release-workflow.png)
1. The major branch you want to release for, e.g. `v8`
2. The version you want to release, e.g. `8.45.1`
3. The major branch to merge into, e.g. `v8`
1. The major branch you want to release for, e.g. `v8` or `9.7.0-alpha`
2. The version you want to release, e.g. `8.45.1` `9.7.0-alpha.1`
3. The major branch to merge into, e.g. `v8` `9.7.0-alpha`
7. Run the release workflow

## Updating the Changelog
Expand Down
4 changes: 4 additions & 0 deletions packages/browser/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
addAutoIpAddressToUser,
applySdkMetadata,
getSDKSource,
_INTERNAL_flushLogsBuffer,
} from '@sentry/core';
import { eventFromException, eventFromMessage } from './eventbuilder';
import { WINDOW } from './helpers';
Expand DownExpand Up@@ -85,6 +86,9 @@ export class BrowserClient extends Client<BrowserClientOptions> {
WINDOW.document.addEventListener('visibilitychange', () => {
if (WINDOW.document.visibilityState === 'hidden') {
this._flushOutcomes();
if (this._options._experiments?.enableLogs) {
_INTERNAL_flushLogsBuffer(this);
}
}
});
}
Expand Down
28 changes: 25 additions & 3 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ import type {
SpanContextData,
SpanJSON,
StartSpanOptions,
TraceContext,
TransactionEvent,
Transport,
TransportMakeRequestResponse,
Expand All@@ -44,7 +45,10 @@ import { afterSetupIntegrations } from './integration';
import { setupIntegration, setupIntegrations } from './integration';
import type { Scope } from './scope';
import { updateSession } from './session';
import { getDynamicSamplingContextFromScope } from './tracing/dynamicSamplingContext';
import {
getDynamicSamplingContextFromScope,
getDynamicSamplingContextFromSpan,
} from './tracing/dynamicSamplingContext';
import { createClientReportEnvelope } from './utils-hoist/clientreport';
import { dsnToString, makeDsn } from './utils-hoist/dsn';
import { addItemToEnvelope, createAttachmentEnvelopeItem } from './utils-hoist/envelope';
Expand All@@ -57,8 +61,9 @@ import { getPossibleEventMessages } from './utils/eventUtils';
import { merge } from './utils/merge';
import { parseSampleRate } from './utils/parseSampleRate';
import { prepareEvent } from './utils/prepareEvent';
import { showSpanDropWarning } from './utils/spanUtils';
import { showSpanDropWarning, spanToTraceContext } from './utils/spanUtils';
import { convertSpanJsonToTransactionEvent, convertTransactionEventToSpanJson } from './utils/transactionEvent';
import { _getSpanForScope } from './utils/spanOnScope';

const ALREADY_SEEN_ERROR = "Not capturing exception because it's already been captured.";
const MISSING_RELEASE_FOR_SESSION_ERROR = 'Discarded session because of missing or non-string release';
Expand DownExpand Up@@ -617,7 +622,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
public on(hook: 'close', callback: () => void): () => void;

/**
* Register a hook oin this client.
* Register a hook on this client.
*/
public on(hook: string, callback: unknown): () => void {
const hooks = (this._hooks[hook] = this._hooks[hook] || []);
Expand DownExpand Up@@ -1256,3 +1261,20 @@ function isErrorEvent(event: Event): event is ErrorEvent {
function isTransactionEvent(event: Event): event is TransactionEvent {
return event.type === 'transaction';
}

/** Extract trace information from scope */
export function _getTraceInfoFromScope(
client: Client,
scope: Scope | undefined,
): [dynamicSamplingContext: Partial<DynamicSamplingContext> | undefined, traceContext: TraceContext | undefined] {
if (!scope) {
return [undefined, undefined];
}

const span = _getSpanForScope(scope);
const traceContext = span ? spanToTraceContext(span) : getTraceContextFromScope(scope);
const dynamicSamplingContext = span
? getDynamicSamplingContextFromSpan(span)
: getDynamicSamplingContextFromScope(client, scope);
return [dynamicSamplingContext, traceContext];
}
1 change: 1 addition & 0 deletions packages/core/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -113,6 +113,7 @@ export { instrumentFetchRequest } from './fetch';
export { trpcMiddleware } from './trpc';
export { captureFeedback } from './feedback';
export type { ReportDialogOptions } from './report-dialog';
export { _INTERNAL_flushLogsBuffer } from './logs';

// TODO: Make this structure pretty again and don't do "export *"
export * from './utils-hoist/index';
Expand Down
15 changes: 15 additions & 0 deletions packages/core/src/logs/constants.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import type { LogSeverityLevel } from '../types-hoist';

/**
* Maps a log severity level to a log severity number.
*
* @see LogSeverityLevel
*/
export const SEVERITY_TEXT_TO_SEVERITY_NUMBER: Partial<Record<LogSeverityLevel, number>> = {
trace: 1,
debug: 5,
info: 9,
warn: 13,
error: 17,
fatal: 21,
};
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '75.2 KB',
limit: '75.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand DownExpand Up@@ -79,7 +79,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration', 'replayCanvasIntegration'),
gzip: true,
limit: '80 KB',
limit: '80.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay, Feedback)',
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,15 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0

- feat(core): Add `captureLog` method ([#15717](https://github.com/getsentry/sentry-javascript/pull/15717))
- feat(remix/cloudflare): Export `sentryHandleError` ([#15726](https://github.com/getsentry/sentry-javascript/pull/15726))
- fix(node): Always flush on Vercel before Lambda freeze ([#15602](https://github.com/getsentry/sentry-javascript/pull/15602))
- fix(node): Ensure incoming traces are propagated without HttpInstrumentation ([#15732](https://github.com/getsentry/sentry-javascript/pull/15732))
- fix(node): Use `fatal` level for unhandled rejections in `strict` mode ([#15720](https://github.com/getsentry/sentry-javascript/pull/15720))
- fix(nuxt): Delete Nuxt server template injection ([#15749](https://github.com/getsentry/sentry-javascript/pull/15749))

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'none' })],
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

setTimeout(() => {
// should not be called
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject(new Error('test rejection'));
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
import * as childProcess from 'child_process';
import * as path from 'path';
import { afterAll, describe, expect, test } from 'vitest';
import { cleanupChildProcesses } from '../../../utils/runner';
import { createRunner } from '../../../utils/runner';

describe('onUnhandledRejectionIntegration', () => {
afterAll(() => {
cleanupChildProcesses();
});

test('should show string-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-string.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr.trim())
.toBe(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should show error-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-error.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: test rejection
at Object.<anonymous>`);
done();
});
}));

test('should not close process on unhandled rejection in strict mode', () =>
new Promise<void>(done => {
expect.assertions(4);

const testScriptPath = path.resolve(__dirname, 'mode-strict.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).not.toBeNull();
expect(err?.code).toBe(1);
expect(stdout).not.toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should not close process or warn on unhandled rejection in none mode', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-none.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr).toBe('');
done();
});
}));

test('captures exceptions for unhandled rejections', async () => {
await createRunner(__dirname, 'scenario-warn.ts')
.expect({
event: {
level: 'error',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});

test('captures exceptions for unhandled rejections in strict mode', async () => {
await createRunner(__dirname, 'scenario-strict.ts')
.expect({
event: {
level: 'fatal',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});
});
10 changes: 5 additions & 5 deletions docs/publishing-a-release.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,9 +20,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
[@getsentry/releases-approvers](https://github.com/orgs/getsentry/teams/release-approvers) to approve the release. a.
Once the release is completed, a sync from `master` ->` develop` will be automatically triggered

## Publishing a release for previous majors
## Publishing a release for previous majors or prerelease (alpha, beta) versions

1. Run `yarn changelog` on a previous major branch (e.g. `v8`) and determine what version will be released (we use
1. Run `yarn changelog` on a previous major branch (e.g. `v8` or `9.7.0-alpha`) and determine what version will be released (we use
[semver](https://semver.org))
2. Create a branch, e.g. `changelog-8.45.1`, off a previous major branch (e.g. `v8`)
3. Update `CHANGELOG.md` to add an entry for the next release number and a list of changes since the
Expand All@@ -32,9 +32,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
(as the commits already exist on this branch).
6. Once the PR is merged, open the [Prepare Release workflow](https://github.com/getsentry/sentry-javascript/actions/workflows/release.yml) and
fill in ![run-release-workflow.png](./assets/run-release-workflow.png)
1. The major branch you want to release for, e.g. `v8`
2. The version you want to release, e.g. `8.45.1`
3. The major branch to merge into, e.g. `v8`
1. The major branch you want to release for, e.g. `v8` or `9.7.0-alpha`
2. The version you want to release, e.g. `8.45.1` `9.7.0-alpha.1`
3. The major branch to merge into, e.g. `v8` `9.7.0-alpha`
7. Run the release workflow

## Updating the Changelog
Expand Down
4 changes: 4 additions & 0 deletions packages/browser/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
addAutoIpAddressToUser,
applySdkMetadata,
getSDKSource,
_INTERNAL_flushLogsBuffer,
} from '@sentry/core';
import { eventFromException, eventFromMessage } from './eventbuilder';
import { WINDOW } from './helpers';
Expand DownExpand Up@@ -85,6 +86,9 @@ export class BrowserClient extends Client<BrowserClientOptions> {
WINDOW.document.addEventListener('visibilitychange', () => {
if (WINDOW.document.visibilityState === 'hidden') {
this._flushOutcomes();
if (this._options._experiments?.enableLogs) {
_INTERNAL_flushLogsBuffer(this);
}
}
});
}
Expand Down
28 changes: 25 additions & 3 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ import type {
SpanContextData,
SpanJSON,
StartSpanOptions,
TraceContext,
TransactionEvent,
Transport,
TransportMakeRequestResponse,
Expand All@@ -44,7 +45,10 @@ import { afterSetupIntegrations } from './integration';
import { setupIntegration, setupIntegrations } from './integration';
import type { Scope } from './scope';
import { updateSession } from './session';
import { getDynamicSamplingContextFromScope } from './tracing/dynamicSamplingContext';
import {
getDynamicSamplingContextFromScope,
getDynamicSamplingContextFromSpan,
} from './tracing/dynamicSamplingContext';
import { createClientReportEnvelope } from './utils-hoist/clientreport';
import { dsnToString, makeDsn } from './utils-hoist/dsn';
import { addItemToEnvelope, createAttachmentEnvelopeItem } from './utils-hoist/envelope';
Expand All@@ -57,8 +61,9 @@ import { getPossibleEventMessages } from './utils/eventUtils';
import { merge } from './utils/merge';
import { parseSampleRate } from './utils/parseSampleRate';
import { prepareEvent } from './utils/prepareEvent';
import { showSpanDropWarning } from './utils/spanUtils';
import { showSpanDropWarning, spanToTraceContext } from './utils/spanUtils';
import { convertSpanJsonToTransactionEvent, convertTransactionEventToSpanJson } from './utils/transactionEvent';
import { _getSpanForScope } from './utils/spanOnScope';

const ALREADY_SEEN_ERROR = "Not capturing exception because it's already been captured.";
const MISSING_RELEASE_FOR_SESSION_ERROR = 'Discarded session because of missing or non-string release';
Expand DownExpand Up@@ -617,7 +622,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
public on(hook: 'close', callback: () => void): () => void;

/**
* Register a hook oin this client.
* Register a hook on this client.
*/
public on(hook: string, callback: unknown): () => void {
const hooks = (this._hooks[hook] = this._hooks[hook] || []);
Expand DownExpand Up@@ -1256,3 +1261,20 @@ function isErrorEvent(event: Event): event is ErrorEvent {
function isTransactionEvent(event: Event): event is TransactionEvent {
return event.type === 'transaction';
}

/** Extract trace information from scope */
export function _getTraceInfoFromScope(
client: Client,
scope: Scope | undefined,
): [dynamicSamplingContext: Partial<DynamicSamplingContext> | undefined, traceContext: TraceContext | undefined] {
if (!scope) {
return [undefined, undefined];
}

const span = _getSpanForScope(scope);
const traceContext = span ? spanToTraceContext(span) : getTraceContextFromScope(scope);
const dynamicSamplingContext = span
? getDynamicSamplingContextFromSpan(span)
: getDynamicSamplingContextFromScope(client, scope);
return [dynamicSamplingContext, traceContext];
}
1 change: 1 addition & 0 deletions packages/core/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -113,6 +113,7 @@ export { instrumentFetchRequest } from './fetch';
export { trpcMiddleware } from './trpc';
export { captureFeedback } from './feedback';
export type { ReportDialogOptions } from './report-dialog';
export { _INTERNAL_flushLogsBuffer } from './logs';

// TODO: Make this structure pretty again and don't do "export *"
export * from './utils-hoist/index';
Expand Down
15 changes: 15 additions & 0 deletions packages/core/src/logs/constants.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import type { LogSeverityLevel } from '../types-hoist';

/**
* Maps a log severity level to a log severity number.
*
* @see LogSeverityLevel
*/
export const SEVERITY_TEXT_TO_SEVERITY_NUMBER: Partial<Record<LogSeverityLevel, number>> = {
trace: 1,
debug: 5,
info: 9,
warn: 13,
error: 17,
fatal: 21,
};
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '75.2 KB',
limit: '75.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand DownExpand Up@@ -79,7 +79,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration', 'replayCanvasIntegration'),
gzip: true,
limit: '80 KB',
limit: '80.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay, Feedback)',
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,15 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0

- feat(core): Add `captureLog` method ([#15717](https://github.com/getsentry/sentry-javascript/pull/15717))
- feat(remix/cloudflare): Export `sentryHandleError` ([#15726](https://github.com/getsentry/sentry-javascript/pull/15726))
- fix(node): Always flush on Vercel before Lambda freeze ([#15602](https://github.com/getsentry/sentry-javascript/pull/15602))
- fix(node): Ensure incoming traces are propagated without HttpInstrumentation ([#15732](https://github.com/getsentry/sentry-javascript/pull/15732))
- fix(node): Use `fatal` level for unhandled rejections in `strict` mode ([#15720](https://github.com/getsentry/sentry-javascript/pull/15720))
- fix(nuxt): Delete Nuxt server template injection ([#15749](https://github.com/getsentry/sentry-javascript/pull/15749))

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'none' })],
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

setTimeout(() => {
// should not be called
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject(new Error('test rejection'));
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
import * as childProcess from 'child_process';
import * as path from 'path';
import { afterAll, describe, expect, test } from 'vitest';
import { cleanupChildProcesses } from '../../../utils/runner';
import { createRunner } from '../../../utils/runner';

describe('onUnhandledRejectionIntegration', () => {
afterAll(() => {
cleanupChildProcesses();
});

test('should show string-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-string.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr.trim())
.toBe(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should show error-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-error.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: test rejection
at Object.<anonymous>`);
done();
});
}));

test('should not close process on unhandled rejection in strict mode', () =>
new Promise<void>(done => {
expect.assertions(4);

const testScriptPath = path.resolve(__dirname, 'mode-strict.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).not.toBeNull();
expect(err?.code).toBe(1);
expect(stdout).not.toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should not close process or warn on unhandled rejection in none mode', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-none.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr).toBe('');
done();
});
}));

test('captures exceptions for unhandled rejections', async () => {
await createRunner(__dirname, 'scenario-warn.ts')
.expect({
event: {
level: 'error',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});

test('captures exceptions for unhandled rejections in strict mode', async () => {
await createRunner(__dirname, 'scenario-strict.ts')
.expect({
event: {
level: 'fatal',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});
});
10 changes: 5 additions & 5 deletions docs/publishing-a-release.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,9 +20,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
[@getsentry/releases-approvers](https://github.com/orgs/getsentry/teams/release-approvers) to approve the release. a.
Once the release is completed, a sync from `master` ->` develop` will be automatically triggered

## Publishing a release for previous majors
## Publishing a release for previous majors or prerelease (alpha, beta) versions

1. Run `yarn changelog` on a previous major branch (e.g. `v8`) and determine what version will be released (we use
1. Run `yarn changelog` on a previous major branch (e.g. `v8` or `9.7.0-alpha`) and determine what version will be released (we use
[semver](https://semver.org))
2. Create a branch, e.g. `changelog-8.45.1`, off a previous major branch (e.g. `v8`)
3. Update `CHANGELOG.md` to add an entry for the next release number and a list of changes since the
Expand All@@ -32,9 +32,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
(as the commits already exist on this branch).
6. Once the PR is merged, open the [Prepare Release workflow](https://github.com/getsentry/sentry-javascript/actions/workflows/release.yml) and
fill in ![run-release-workflow.png](./assets/run-release-workflow.png)
1. The major branch you want to release for, e.g. `v8`
2. The version you want to release, e.g. `8.45.1`
3. The major branch to merge into, e.g. `v8`
1. The major branch you want to release for, e.g. `v8` or `9.7.0-alpha`
2. The version you want to release, e.g. `8.45.1` `9.7.0-alpha.1`
3. The major branch to merge into, e.g. `v8` `9.7.0-alpha`
7. Run the release workflow

## Updating the Changelog
Expand Down
4 changes: 4 additions & 0 deletions packages/browser/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
addAutoIpAddressToUser,
applySdkMetadata,
getSDKSource,
_INTERNAL_flushLogsBuffer,
} from '@sentry/core';
import { eventFromException, eventFromMessage } from './eventbuilder';
import { WINDOW } from './helpers';
Expand DownExpand Up@@ -85,6 +86,9 @@ export class BrowserClient extends Client<BrowserClientOptions> {
WINDOW.document.addEventListener('visibilitychange', () => {
if (WINDOW.document.visibilityState === 'hidden') {
this._flushOutcomes();
if (this._options._experiments?.enableLogs) {
_INTERNAL_flushLogsBuffer(this);
}
}
});
}
Expand Down
28 changes: 25 additions & 3 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ import type {
SpanContextData,
SpanJSON,
StartSpanOptions,
TraceContext,
TransactionEvent,
Transport,
TransportMakeRequestResponse,
Expand All@@ -44,7 +45,10 @@ import { afterSetupIntegrations } from './integration';
import { setupIntegration, setupIntegrations } from './integration';
import type { Scope } from './scope';
import { updateSession } from './session';
import { getDynamicSamplingContextFromScope } from './tracing/dynamicSamplingContext';
import {
getDynamicSamplingContextFromScope,
getDynamicSamplingContextFromSpan,
} from './tracing/dynamicSamplingContext';
import { createClientReportEnvelope } from './utils-hoist/clientreport';
import { dsnToString, makeDsn } from './utils-hoist/dsn';
import { addItemToEnvelope, createAttachmentEnvelopeItem } from './utils-hoist/envelope';
Expand All@@ -57,8 +61,9 @@ import { getPossibleEventMessages } from './utils/eventUtils';
import { merge } from './utils/merge';
import { parseSampleRate } from './utils/parseSampleRate';
import { prepareEvent } from './utils/prepareEvent';
import { showSpanDropWarning } from './utils/spanUtils';
import { showSpanDropWarning, spanToTraceContext } from './utils/spanUtils';
import { convertSpanJsonToTransactionEvent, convertTransactionEventToSpanJson } from './utils/transactionEvent';
import { _getSpanForScope } from './utils/spanOnScope';

const ALREADY_SEEN_ERROR = "Not capturing exception because it's already been captured.";
const MISSING_RELEASE_FOR_SESSION_ERROR = 'Discarded session because of missing or non-string release';
Expand DownExpand Up@@ -617,7 +622,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
public on(hook: 'close', callback: () => void): () => void;

/**
* Register a hook oin this client.
* Register a hook on this client.
*/
public on(hook: string, callback: unknown): () => void {
const hooks = (this._hooks[hook] = this._hooks[hook] || []);
Expand DownExpand Up@@ -1256,3 +1261,20 @@ function isErrorEvent(event: Event): event is ErrorEvent {
function isTransactionEvent(event: Event): event is TransactionEvent {
return event.type === 'transaction';
}

/** Extract trace information from scope */
export function _getTraceInfoFromScope(
client: Client,
scope: Scope | undefined,
): [dynamicSamplingContext: Partial<DynamicSamplingContext> | undefined, traceContext: TraceContext | undefined] {
if (!scope) {
return [undefined, undefined];
}

const span = _getSpanForScope(scope);
const traceContext = span ? spanToTraceContext(span) : getTraceContextFromScope(scope);
const dynamicSamplingContext = span
? getDynamicSamplingContextFromSpan(span)
: getDynamicSamplingContextFromScope(client, scope);
return [dynamicSamplingContext, traceContext];
}
1 change: 1 addition & 0 deletions packages/core/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -113,6 +113,7 @@ export { instrumentFetchRequest } from './fetch';
export { trpcMiddleware } from './trpc';
export { captureFeedback } from './feedback';
export type { ReportDialogOptions } from './report-dialog';
export { _INTERNAL_flushLogsBuffer } from './logs';

// TODO: Make this structure pretty again and don't do "export *"
export * from './utils-hoist/index';
Expand Down
15 changes: 15 additions & 0 deletions packages/core/src/logs/constants.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import type { LogSeverityLevel } from '../types-hoist';

/**
* Maps a log severity level to a log severity number.
*
* @see LogSeverityLevel
*/
export const SEVERITY_TEXT_TO_SEVERITY_NUMBER: Partial<Record<LogSeverityLevel, number>> = {
trace: 1,
debug: 5,
info: 9,
warn: 13,
error: 17,
fatal: 21,
};
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '75.2 KB',
limit: '75.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand DownExpand Up@@ -79,7 +79,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration', 'replayCanvasIntegration'),
gzip: true,
limit: '80 KB',
limit: '80.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay, Feedback)',
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,15 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0

- feat(core): Add `captureLog` method ([#15717](https://github.com/getsentry/sentry-javascript/pull/15717))
- feat(remix/cloudflare): Export `sentryHandleError` ([#15726](https://github.com/getsentry/sentry-javascript/pull/15726))
- fix(node): Always flush on Vercel before Lambda freeze ([#15602](https://github.com/getsentry/sentry-javascript/pull/15602))
- fix(node): Ensure incoming traces are propagated without HttpInstrumentation ([#15732](https://github.com/getsentry/sentry-javascript/pull/15732))
- fix(node): Use `fatal` level for unhandled rejections in `strict` mode ([#15720](https://github.com/getsentry/sentry-javascript/pull/15720))
- fix(nuxt): Delete Nuxt server template injection ([#15749](https://github.com/getsentry/sentry-javascript/pull/15749))

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'none' })],
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

setTimeout(() => {
// should not be called
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject(new Error('test rejection'));
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
import * as childProcess from 'child_process';
import * as path from 'path';
import { afterAll, describe, expect, test } from 'vitest';
import { cleanupChildProcesses } from '../../../utils/runner';
import { createRunner } from '../../../utils/runner';

describe('onUnhandledRejectionIntegration', () => {
afterAll(() => {
cleanupChildProcesses();
});

test('should show string-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-string.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr.trim())
.toBe(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should show error-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-error.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: test rejection
at Object.<anonymous>`);
done();
});
}));

test('should not close process on unhandled rejection in strict mode', () =>
new Promise<void>(done => {
expect.assertions(4);

const testScriptPath = path.resolve(__dirname, 'mode-strict.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).not.toBeNull();
expect(err?.code).toBe(1);
expect(stdout).not.toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should not close process or warn on unhandled rejection in none mode', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-none.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr).toBe('');
done();
});
}));

test('captures exceptions for unhandled rejections', async () => {
await createRunner(__dirname, 'scenario-warn.ts')
.expect({
event: {
level: 'error',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});

test('captures exceptions for unhandled rejections in strict mode', async () => {
await createRunner(__dirname, 'scenario-strict.ts')
.expect({
event: {
level: 'fatal',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});
});
10 changes: 5 additions & 5 deletions docs/publishing-a-release.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,9 +20,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
[@getsentry/releases-approvers](https://github.com/orgs/getsentry/teams/release-approvers) to approve the release. a.
Once the release is completed, a sync from `master` ->` develop` will be automatically triggered

## Publishing a release for previous majors
## Publishing a release for previous majors or prerelease (alpha, beta) versions

1. Run `yarn changelog` on a previous major branch (e.g. `v8`) and determine what version will be released (we use
1. Run `yarn changelog` on a previous major branch (e.g. `v8` or `9.7.0-alpha`) and determine what version will be released (we use
[semver](https://semver.org))
2. Create a branch, e.g. `changelog-8.45.1`, off a previous major branch (e.g. `v8`)
3. Update `CHANGELOG.md` to add an entry for the next release number and a list of changes since the
Expand All@@ -32,9 +32,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
(as the commits already exist on this branch).
6. Once the PR is merged, open the [Prepare Release workflow](https://github.com/getsentry/sentry-javascript/actions/workflows/release.yml) and
fill in ![run-release-workflow.png](./assets/run-release-workflow.png)
1. The major branch you want to release for, e.g. `v8`
2. The version you want to release, e.g. `8.45.1`
3. The major branch to merge into, e.g. `v8`
1. The major branch you want to release for, e.g. `v8` or `9.7.0-alpha`
2. The version you want to release, e.g. `8.45.1` `9.7.0-alpha.1`
3. The major branch to merge into, e.g. `v8` `9.7.0-alpha`
7. Run the release workflow

## Updating the Changelog
Expand Down
4 changes: 4 additions & 0 deletions packages/browser/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
addAutoIpAddressToUser,
applySdkMetadata,
getSDKSource,
_INTERNAL_flushLogsBuffer,
} from '@sentry/core';
import { eventFromException, eventFromMessage } from './eventbuilder';
import { WINDOW } from './helpers';
Expand DownExpand Up@@ -85,6 +86,9 @@ export class BrowserClient extends Client<BrowserClientOptions> {
WINDOW.document.addEventListener('visibilitychange', () => {
if (WINDOW.document.visibilityState === 'hidden') {
this._flushOutcomes();
if (this._options._experiments?.enableLogs) {
_INTERNAL_flushLogsBuffer(this);
}
}
});
}
Expand Down
28 changes: 25 additions & 3 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ import type {
SpanContextData,
SpanJSON,
StartSpanOptions,
TraceContext,
TransactionEvent,
Transport,
TransportMakeRequestResponse,
Expand All@@ -44,7 +45,10 @@ import { afterSetupIntegrations } from './integration';
import { setupIntegration, setupIntegrations } from './integration';
import type { Scope } from './scope';
import { updateSession } from './session';
import { getDynamicSamplingContextFromScope } from './tracing/dynamicSamplingContext';
import {
getDynamicSamplingContextFromScope,
getDynamicSamplingContextFromSpan,
} from './tracing/dynamicSamplingContext';
import { createClientReportEnvelope } from './utils-hoist/clientreport';
import { dsnToString, makeDsn } from './utils-hoist/dsn';
import { addItemToEnvelope, createAttachmentEnvelopeItem } from './utils-hoist/envelope';
Expand All@@ -57,8 +61,9 @@ import { getPossibleEventMessages } from './utils/eventUtils';
import { merge } from './utils/merge';
import { parseSampleRate } from './utils/parseSampleRate';
import { prepareEvent } from './utils/prepareEvent';
import { showSpanDropWarning } from './utils/spanUtils';
import { showSpanDropWarning, spanToTraceContext } from './utils/spanUtils';
import { convertSpanJsonToTransactionEvent, convertTransactionEventToSpanJson } from './utils/transactionEvent';
import { _getSpanForScope } from './utils/spanOnScope';

const ALREADY_SEEN_ERROR = "Not capturing exception because it's already been captured.";
const MISSING_RELEASE_FOR_SESSION_ERROR = 'Discarded session because of missing or non-string release';
Expand DownExpand Up@@ -617,7 +622,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
public on(hook: 'close', callback: () => void): () => void;

/**
* Register a hook oin this client.
* Register a hook on this client.
*/
public on(hook: string, callback: unknown): () => void {
const hooks = (this._hooks[hook] = this._hooks[hook] || []);
Expand DownExpand Up@@ -1256,3 +1261,20 @@ function isErrorEvent(event: Event): event is ErrorEvent {
function isTransactionEvent(event: Event): event is TransactionEvent {
return event.type === 'transaction';
}

/** Extract trace information from scope */
export function _getTraceInfoFromScope(
client: Client,
scope: Scope | undefined,
): [dynamicSamplingContext: Partial<DynamicSamplingContext> | undefined, traceContext: TraceContext | undefined] {
if (!scope) {
return [undefined, undefined];
}

const span = _getSpanForScope(scope);
const traceContext = span ? spanToTraceContext(span) : getTraceContextFromScope(scope);
const dynamicSamplingContext = span
? getDynamicSamplingContextFromSpan(span)
: getDynamicSamplingContextFromScope(client, scope);
return [dynamicSamplingContext, traceContext];
}
1 change: 1 addition & 0 deletions packages/core/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -113,6 +113,7 @@ export { instrumentFetchRequest } from './fetch';
export { trpcMiddleware } from './trpc';
export { captureFeedback } from './feedback';
export type { ReportDialogOptions } from './report-dialog';
export { _INTERNAL_flushLogsBuffer } from './logs';

// TODO: Make this structure pretty again and don't do "export *"
export * from './utils-hoist/index';
Expand Down
15 changes: 15 additions & 0 deletions packages/core/src/logs/constants.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import type { LogSeverityLevel } from '../types-hoist';

/**
* Maps a log severity level to a log severity number.
*
* @see LogSeverityLevel
*/
export const SEVERITY_TEXT_TO_SEVERITY_NUMBER: Partial<Record<LogSeverityLevel, number>> = {
trace: 1,
debug: 5,
info: 9,
warn: 13,
error: 17,
fatal: 21,
};
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '75.2 KB',
limit: '75.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand DownExpand Up@@ -79,7 +79,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration', 'replayCanvasIntegration'),
gzip: true,
limit: '80 KB',
limit: '80.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay, Feedback)',
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,15 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0

- feat(core): Add `captureLog` method ([#15717](https://github.com/getsentry/sentry-javascript/pull/15717))
- feat(remix/cloudflare): Export `sentryHandleError` ([#15726](https://github.com/getsentry/sentry-javascript/pull/15726))
- fix(node): Always flush on Vercel before Lambda freeze ([#15602](https://github.com/getsentry/sentry-javascript/pull/15602))
- fix(node): Ensure incoming traces are propagated without HttpInstrumentation ([#15732](https://github.com/getsentry/sentry-javascript/pull/15732))
- fix(node): Use `fatal` level for unhandled rejections in `strict` mode ([#15720](https://github.com/getsentry/sentry-javascript/pull/15720))
- fix(nuxt): Delete Nuxt server template injection ([#15749](https://github.com/getsentry/sentry-javascript/pull/15749))

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'none' })],
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

setTimeout(() => {
// should not be called
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject(new Error('test rejection'));
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
import * as childProcess from 'child_process';
import * as path from 'path';
import { afterAll, describe, expect, test } from 'vitest';
import { cleanupChildProcesses } from '../../../utils/runner';
import { createRunner } from '../../../utils/runner';

describe('onUnhandledRejectionIntegration', () => {
afterAll(() => {
cleanupChildProcesses();
});

test('should show string-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-string.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr.trim())
.toBe(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should show error-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-error.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: test rejection
at Object.<anonymous>`);
done();
});
}));

test('should not close process on unhandled rejection in strict mode', () =>
new Promise<void>(done => {
expect.assertions(4);

const testScriptPath = path.resolve(__dirname, 'mode-strict.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).not.toBeNull();
expect(err?.code).toBe(1);
expect(stdout).not.toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should not close process or warn on unhandled rejection in none mode', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-none.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr).toBe('');
done();
});
}));

test('captures exceptions for unhandled rejections', async () => {
await createRunner(__dirname, 'scenario-warn.ts')
.expect({
event: {
level: 'error',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});

test('captures exceptions for unhandled rejections in strict mode', async () => {
await createRunner(__dirname, 'scenario-strict.ts')
.expect({
event: {
level: 'fatal',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});
});
10 changes: 5 additions & 5 deletions docs/publishing-a-release.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,9 +20,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
[@getsentry/releases-approvers](https://github.com/orgs/getsentry/teams/release-approvers) to approve the release. a.
Once the release is completed, a sync from `master` ->` develop` will be automatically triggered

## Publishing a release for previous majors
## Publishing a release for previous majors or prerelease (alpha, beta) versions

1. Run `yarn changelog` on a previous major branch (e.g. `v8`) and determine what version will be released (we use
1. Run `yarn changelog` on a previous major branch (e.g. `v8` or `9.7.0-alpha`) and determine what version will be released (we use
[semver](https://semver.org))
2. Create a branch, e.g. `changelog-8.45.1`, off a previous major branch (e.g. `v8`)
3. Update `CHANGELOG.md` to add an entry for the next release number and a list of changes since the
Expand All@@ -32,9 +32,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
(as the commits already exist on this branch).
6. Once the PR is merged, open the [Prepare Release workflow](https://github.com/getsentry/sentry-javascript/actions/workflows/release.yml) and
fill in ![run-release-workflow.png](./assets/run-release-workflow.png)
1. The major branch you want to release for, e.g. `v8`
2. The version you want to release, e.g. `8.45.1`
3. The major branch to merge into, e.g. `v8`
1. The major branch you want to release for, e.g. `v8` or `9.7.0-alpha`
2. The version you want to release, e.g. `8.45.1` `9.7.0-alpha.1`
3. The major branch to merge into, e.g. `v8` `9.7.0-alpha`
7. Run the release workflow

## Updating the Changelog
Expand Down
4 changes: 4 additions & 0 deletions packages/browser/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
addAutoIpAddressToUser,
applySdkMetadata,
getSDKSource,
_INTERNAL_flushLogsBuffer,
} from '@sentry/core';
import { eventFromException, eventFromMessage } from './eventbuilder';
import { WINDOW } from './helpers';
Expand DownExpand Up@@ -85,6 +86,9 @@ export class BrowserClient extends Client<BrowserClientOptions> {
WINDOW.document.addEventListener('visibilitychange', () => {
if (WINDOW.document.visibilityState === 'hidden') {
this._flushOutcomes();
if (this._options._experiments?.enableLogs) {
_INTERNAL_flushLogsBuffer(this);
}
}
});
}
Expand Down
28 changes: 25 additions & 3 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ import type {
SpanContextData,
SpanJSON,
StartSpanOptions,
TraceContext,
TransactionEvent,
Transport,
TransportMakeRequestResponse,
Expand All@@ -44,7 +45,10 @@ import { afterSetupIntegrations } from './integration';
import { setupIntegration, setupIntegrations } from './integration';
import type { Scope } from './scope';
import { updateSession } from './session';
import { getDynamicSamplingContextFromScope } from './tracing/dynamicSamplingContext';
import {
getDynamicSamplingContextFromScope,
getDynamicSamplingContextFromSpan,
} from './tracing/dynamicSamplingContext';
import { createClientReportEnvelope } from './utils-hoist/clientreport';
import { dsnToString, makeDsn } from './utils-hoist/dsn';
import { addItemToEnvelope, createAttachmentEnvelopeItem } from './utils-hoist/envelope';
Expand All@@ -57,8 +61,9 @@ import { getPossibleEventMessages } from './utils/eventUtils';
import { merge } from './utils/merge';
import { parseSampleRate } from './utils/parseSampleRate';
import { prepareEvent } from './utils/prepareEvent';
import { showSpanDropWarning } from './utils/spanUtils';
import { showSpanDropWarning, spanToTraceContext } from './utils/spanUtils';
import { convertSpanJsonToTransactionEvent, convertTransactionEventToSpanJson } from './utils/transactionEvent';
import { _getSpanForScope } from './utils/spanOnScope';

const ALREADY_SEEN_ERROR = "Not capturing exception because it's already been captured.";
const MISSING_RELEASE_FOR_SESSION_ERROR = 'Discarded session because of missing or non-string release';
Expand DownExpand Up@@ -617,7 +622,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
public on(hook: 'close', callback: () => void): () => void;

/**
* Register a hook oin this client.
* Register a hook on this client.
*/
public on(hook: string, callback: unknown): () => void {
const hooks = (this._hooks[hook] = this._hooks[hook] || []);
Expand DownExpand Up@@ -1256,3 +1261,20 @@ function isErrorEvent(event: Event): event is ErrorEvent {
function isTransactionEvent(event: Event): event is TransactionEvent {
return event.type === 'transaction';
}

/** Extract trace information from scope */
export function _getTraceInfoFromScope(
client: Client,
scope: Scope | undefined,
): [dynamicSamplingContext: Partial<DynamicSamplingContext> | undefined, traceContext: TraceContext | undefined] {
if (!scope) {
return [undefined, undefined];
}

const span = _getSpanForScope(scope);
const traceContext = span ? spanToTraceContext(span) : getTraceContextFromScope(scope);
const dynamicSamplingContext = span
? getDynamicSamplingContextFromSpan(span)
: getDynamicSamplingContextFromScope(client, scope);
return [dynamicSamplingContext, traceContext];
}
1 change: 1 addition & 0 deletions packages/core/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -113,6 +113,7 @@ export { instrumentFetchRequest } from './fetch';
export { trpcMiddleware } from './trpc';
export { captureFeedback } from './feedback';
export type { ReportDialogOptions } from './report-dialog';
export { _INTERNAL_flushLogsBuffer } from './logs';

// TODO: Make this structure pretty again and don't do "export *"
export * from './utils-hoist/index';
Expand Down
15 changes: 15 additions & 0 deletions packages/core/src/logs/constants.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import type { LogSeverityLevel } from '../types-hoist';

/**
* Maps a log severity level to a log severity number.
*
* @see LogSeverityLevel
*/
export const SEVERITY_TEXT_TO_SEVERITY_NUMBER: Partial<Record<LogSeverityLevel, number>> = {
trace: 1,
debug: 5,
info: 9,
warn: 13,
error: 17,
fatal: 21,
};
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '75.2 KB',
limit: '75.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand DownExpand Up@@ -79,7 +79,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration', 'replayCanvasIntegration'),
gzip: true,
limit: '80 KB',
limit: '80.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay, Feedback)',
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,15 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0

- feat(core): Add `captureLog` method ([#15717](https://github.com/getsentry/sentry-javascript/pull/15717))
- feat(remix/cloudflare): Export `sentryHandleError` ([#15726](https://github.com/getsentry/sentry-javascript/pull/15726))
- fix(node): Always flush on Vercel before Lambda freeze ([#15602](https://github.com/getsentry/sentry-javascript/pull/15602))
- fix(node): Ensure incoming traces are propagated without HttpInstrumentation ([#15732](https://github.com/getsentry/sentry-javascript/pull/15732))
- fix(node): Use `fatal` level for unhandled rejections in `strict` mode ([#15720](https://github.com/getsentry/sentry-javascript/pull/15720))
- fix(nuxt): Delete Nuxt server template injection ([#15749](https://github.com/getsentry/sentry-javascript/pull/15749))

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'none' })],
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

setTimeout(() => {
// should not be called
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject(new Error('test rejection'));
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
import * as childProcess from 'child_process';
import * as path from 'path';
import { afterAll, describe, expect, test } from 'vitest';
import { cleanupChildProcesses } from '../../../utils/runner';
import { createRunner } from '../../../utils/runner';

describe('onUnhandledRejectionIntegration', () => {
afterAll(() => {
cleanupChildProcesses();
});

test('should show string-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-string.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr.trim())
.toBe(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should show error-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-error.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: test rejection
at Object.<anonymous>`);
done();
});
}));

test('should not close process on unhandled rejection in strict mode', () =>
new Promise<void>(done => {
expect.assertions(4);

const testScriptPath = path.resolve(__dirname, 'mode-strict.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).not.toBeNull();
expect(err?.code).toBe(1);
expect(stdout).not.toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should not close process or warn on unhandled rejection in none mode', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-none.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr).toBe('');
done();
});
}));

test('captures exceptions for unhandled rejections', async () => {
await createRunner(__dirname, 'scenario-warn.ts')
.expect({
event: {
level: 'error',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});

test('captures exceptions for unhandled rejections in strict mode', async () => {
await createRunner(__dirname, 'scenario-strict.ts')
.expect({
event: {
level: 'fatal',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});
});
10 changes: 5 additions & 5 deletions docs/publishing-a-release.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,9 +20,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
[@getsentry/releases-approvers](https://github.com/orgs/getsentry/teams/release-approvers) to approve the release. a.
Once the release is completed, a sync from `master` ->` develop` will be automatically triggered

## Publishing a release for previous majors
## Publishing a release for previous majors or prerelease (alpha, beta) versions

1. Run `yarn changelog` on a previous major branch (e.g. `v8`) and determine what version will be released (we use
1. Run `yarn changelog` on a previous major branch (e.g. `v8` or `9.7.0-alpha`) and determine what version will be released (we use
[semver](https://semver.org))
2. Create a branch, e.g. `changelog-8.45.1`, off a previous major branch (e.g. `v8`)
3. Update `CHANGELOG.md` to add an entry for the next release number and a list of changes since the
Expand All@@ -32,9 +32,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
(as the commits already exist on this branch).
6. Once the PR is merged, open the [Prepare Release workflow](https://github.com/getsentry/sentry-javascript/actions/workflows/release.yml) and
fill in ![run-release-workflow.png](./assets/run-release-workflow.png)
1. The major branch you want to release for, e.g. `v8`
2. The version you want to release, e.g. `8.45.1`
3. The major branch to merge into, e.g. `v8`
1. The major branch you want to release for, e.g. `v8` or `9.7.0-alpha`
2. The version you want to release, e.g. `8.45.1` `9.7.0-alpha.1`
3. The major branch to merge into, e.g. `v8` `9.7.0-alpha`
7. Run the release workflow

## Updating the Changelog
Expand Down
4 changes: 4 additions & 0 deletions packages/browser/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
addAutoIpAddressToUser,
applySdkMetadata,
getSDKSource,
_INTERNAL_flushLogsBuffer,
} from '@sentry/core';
import { eventFromException, eventFromMessage } from './eventbuilder';
import { WINDOW } from './helpers';
Expand DownExpand Up@@ -85,6 +86,9 @@ export class BrowserClient extends Client<BrowserClientOptions> {
WINDOW.document.addEventListener('visibilitychange', () => {
if (WINDOW.document.visibilityState === 'hidden') {
this._flushOutcomes();
if (this._options._experiments?.enableLogs) {
_INTERNAL_flushLogsBuffer(this);
}
}
});
}
Expand Down
28 changes: 25 additions & 3 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ import type {
SpanContextData,
SpanJSON,
StartSpanOptions,
TraceContext,
TransactionEvent,
Transport,
TransportMakeRequestResponse,
Expand All@@ -44,7 +45,10 @@ import { afterSetupIntegrations } from './integration';
import { setupIntegration, setupIntegrations } from './integration';
import type { Scope } from './scope';
import { updateSession } from './session';
import { getDynamicSamplingContextFromScope } from './tracing/dynamicSamplingContext';
import {
getDynamicSamplingContextFromScope,
getDynamicSamplingContextFromSpan,
} from './tracing/dynamicSamplingContext';
import { createClientReportEnvelope } from './utils-hoist/clientreport';
import { dsnToString, makeDsn } from './utils-hoist/dsn';
import { addItemToEnvelope, createAttachmentEnvelopeItem } from './utils-hoist/envelope';
Expand All@@ -57,8 +61,9 @@ import { getPossibleEventMessages } from './utils/eventUtils';
import { merge } from './utils/merge';
import { parseSampleRate } from './utils/parseSampleRate';
import { prepareEvent } from './utils/prepareEvent';
import { showSpanDropWarning } from './utils/spanUtils';
import { showSpanDropWarning, spanToTraceContext } from './utils/spanUtils';
import { convertSpanJsonToTransactionEvent, convertTransactionEventToSpanJson } from './utils/transactionEvent';
import { _getSpanForScope } from './utils/spanOnScope';

const ALREADY_SEEN_ERROR = "Not capturing exception because it's already been captured.";
const MISSING_RELEASE_FOR_SESSION_ERROR = 'Discarded session because of missing or non-string release';
Expand DownExpand Up@@ -617,7 +622,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
public on(hook: 'close', callback: () => void): () => void;

/**
* Register a hook oin this client.
* Register a hook on this client.
*/
public on(hook: string, callback: unknown): () => void {
const hooks = (this._hooks[hook] = this._hooks[hook] || []);
Expand DownExpand Up@@ -1256,3 +1261,20 @@ function isErrorEvent(event: Event): event is ErrorEvent {
function isTransactionEvent(event: Event): event is TransactionEvent {
return event.type === 'transaction';
}

/** Extract trace information from scope */
export function _getTraceInfoFromScope(
client: Client,
scope: Scope | undefined,
): [dynamicSamplingContext: Partial<DynamicSamplingContext> | undefined, traceContext: TraceContext | undefined] {
if (!scope) {
return [undefined, undefined];
}

const span = _getSpanForScope(scope);
const traceContext = span ? spanToTraceContext(span) : getTraceContextFromScope(scope);
const dynamicSamplingContext = span
? getDynamicSamplingContextFromSpan(span)
: getDynamicSamplingContextFromScope(client, scope);
return [dynamicSamplingContext, traceContext];
}
1 change: 1 addition & 0 deletions packages/core/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -113,6 +113,7 @@ export { instrumentFetchRequest } from './fetch';
export { trpcMiddleware } from './trpc';
export { captureFeedback } from './feedback';
export type { ReportDialogOptions } from './report-dialog';
export { _INTERNAL_flushLogsBuffer } from './logs';

// TODO: Make this structure pretty again and don't do "export *"
export * from './utils-hoist/index';
Expand Down
15 changes: 15 additions & 0 deletions packages/core/src/logs/constants.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import type { LogSeverityLevel } from '../types-hoist';

/**
* Maps a log severity level to a log severity number.
*
* @see LogSeverityLevel
*/
export const SEVERITY_TEXT_TO_SEVERITY_NUMBER: Partial<Record<LogSeverityLevel, number>> = {
trace: 1,
debug: 5,
info: 9,
warn: 13,
error: 17,
fatal: 21,
};
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .size-limit.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,7 +47,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration'),
gzip: true,
limit: '75.2 KB',
limit: '75.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay) - with treeshaking flags',
Expand DownExpand Up@@ -79,7 +79,7 @@ module.exports = [
path: 'packages/browser/build/npm/esm/index.js',
import: createImport('init', 'browserTracingIntegration', 'replayIntegration', 'replayCanvasIntegration'),
gzip: true,
limit: '80 KB',
limit: '80.5 KB',
},
{
name: '@sentry/browser (incl. Tracing, Replay, Feedback)',
Expand Down
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,6 +10,15 @@

- "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott

## 9.7.0

- feat(core): Add `captureLog` method ([#15717](https://github.com/getsentry/sentry-javascript/pull/15717))
- feat(remix/cloudflare): Export `sentryHandleError` ([#15726](https://github.com/getsentry/sentry-javascript/pull/15726))
- fix(node): Always flush on Vercel before Lambda freeze ([#15602](https://github.com/getsentry/sentry-javascript/pull/15602))
- fix(node): Ensure incoming traces are propagated without HttpInstrumentation ([#15732](https://github.com/getsentry/sentry-javascript/pull/15732))
- fix(node): Use `fatal` level for unhandled rejections in `strict` mode ([#15720](https://github.com/getsentry/sentry-javascript/pull/15720))
- fix(nuxt): Delete Nuxt server template injection ([#15749](https://github.com/getsentry/sentry-javascript/pull/15749))

## 9.6.1

- feat(deps): bump @prisma/instrumentation from 6.4.1 to 6.5.0 ([#15714](https://github.com/getsentry/sentry-javascript/pull/15714))
Expand Down
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'none' })],
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

setTimeout(() => {
// should not be called
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject(new Error('test rejection'));
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
const Sentry = require('@sentry/node');

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
});

setTimeout(() => {
process.stdout.write("I'm alive!");
process.exit(0);
}, 500);

Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
integrations: [Sentry.onUnhandledRejectionIntegration({ mode: 'strict' })],
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
import { loggingTransport } from '@sentry-internal/node-integration-tests';
import * as Sentry from '@sentry/node';

Sentry.init({
dsn: 'https://public@dsn.ingest.sentry.io/1337',
release: '1.0',
transport: loggingTransport,
});

// eslint-disable-next-line @typescript-eslint/no-floating-promises
Promise.reject('test rejection');
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,127 @@
import * as childProcess from 'child_process';
import * as path from 'path';
import { afterAll, describe, expect, test } from 'vitest';
import { cleanupChildProcesses } from '../../../utils/runner';
import { createRunner } from '../../../utils/runner';

describe('onUnhandledRejectionIntegration', () => {
afterAll(() => {
cleanupChildProcesses();
});

test('should show string-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-string.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr.trim())
.toBe(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should show error-type promise rejection warnings by default', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-warn-error.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: test rejection
at Object.<anonymous>`);
done();
});
}));

test('should not close process on unhandled rejection in strict mode', () =>
new Promise<void>(done => {
expect.assertions(4);

const testScriptPath = path.resolve(__dirname, 'mode-strict.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).not.toBeNull();
expect(err?.code).toBe(1);
expect(stdout).not.toBe("I'm alive!");
expect(stderr)
.toContain(`This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
test rejection`);
done();
});
}));

test('should not close process or warn on unhandled rejection in none mode', () =>
new Promise<void>(done => {
expect.assertions(3);

const testScriptPath = path.resolve(__dirname, 'mode-none.js');

childProcess.execFile('node', [testScriptPath], { encoding: 'utf8' }, (err, stdout, stderr) => {
expect(err).toBeNull();
expect(stdout).toBe("I'm alive!");
expect(stderr).toBe('');
done();
});
}));

test('captures exceptions for unhandled rejections', async () => {
await createRunner(__dirname, 'scenario-warn.ts')
.expect({
event: {
level: 'error',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});

test('captures exceptions for unhandled rejections in strict mode', async () => {
await createRunner(__dirname, 'scenario-strict.ts')
.expect({
event: {
level: 'fatal',
exception: {
values: [
{
type: 'Error',
value: 'test rejection',
mechanism: {
type: 'onunhandledrejection',
handled: false,
},
stacktrace: {
frames: expect.any(Array),
},
},
],
},
},
})
.start()
.completed();
});
});
10 changes: 5 additions & 5 deletions docs/publishing-a-release.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -20,9 +20,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
[@getsentry/releases-approvers](https://github.com/orgs/getsentry/teams/release-approvers) to approve the release. a.
Once the release is completed, a sync from `master` ->` develop` will be automatically triggered

## Publishing a release for previous majors
## Publishing a release for previous majors or prerelease (alpha, beta) versions

1. Run `yarn changelog` on a previous major branch (e.g. `v8`) and determine what version will be released (we use
1. Run `yarn changelog` on a previous major branch (e.g. `v8` or `9.7.0-alpha`) and determine what version will be released (we use
[semver](https://semver.org))
2. Create a branch, e.g. `changelog-8.45.1`, off a previous major branch (e.g. `v8`)
3. Update `CHANGELOG.md` to add an entry for the next release number and a list of changes since the
Expand All@@ -32,9 +32,9 @@ _These steps are only relevant to Sentry employees when preparing and publishing
(as the commits already exist on this branch).
6. Once the PR is merged, open the [Prepare Release workflow](https://github.com/getsentry/sentry-javascript/actions/workflows/release.yml) and
fill in ![run-release-workflow.png](./assets/run-release-workflow.png)
1. The major branch you want to release for, e.g. `v8`
2. The version you want to release, e.g. `8.45.1`
3. The major branch to merge into, e.g. `v8`
1. The major branch you want to release for, e.g. `v8` or `9.7.0-alpha`
2. The version you want to release, e.g. `8.45.1` `9.7.0-alpha.1`
3. The major branch to merge into, e.g. `v8` `9.7.0-alpha`
7. Run the release workflow

## Updating the Changelog
Expand Down
4 changes: 4 additions & 0 deletions packages/browser/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -15,6 +15,7 @@ import {
addAutoIpAddressToUser,
applySdkMetadata,
getSDKSource,
_INTERNAL_flushLogsBuffer,
} from '@sentry/core';
import { eventFromException, eventFromMessage } from './eventbuilder';
import { WINDOW } from './helpers';
Expand DownExpand Up@@ -85,6 +86,9 @@ export class BrowserClient extends Client<BrowserClientOptions> {
WINDOW.document.addEventListener('visibilitychange', () => {
if (WINDOW.document.visibilityState === 'hidden') {
this._flushOutcomes();
if (this._options._experiments?.enableLogs) {
_INTERNAL_flushLogsBuffer(this);
}
}
});
}
Expand Down
28 changes: 25 additions & 3 deletions packages/core/src/client.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ import type {
SpanContextData,
SpanJSON,
StartSpanOptions,
TraceContext,
TransactionEvent,
Transport,
TransportMakeRequestResponse,
Expand All@@ -44,7 +45,10 @@ import { afterSetupIntegrations } from './integration';
import { setupIntegration, setupIntegrations } from './integration';
import type { Scope } from './scope';
import { updateSession } from './session';
import { getDynamicSamplingContextFromScope } from './tracing/dynamicSamplingContext';
import {
getDynamicSamplingContextFromScope,
getDynamicSamplingContextFromSpan,
} from './tracing/dynamicSamplingContext';
import { createClientReportEnvelope } from './utils-hoist/clientreport';
import { dsnToString, makeDsn } from './utils-hoist/dsn';
import { addItemToEnvelope, createAttachmentEnvelopeItem } from './utils-hoist/envelope';
Expand All@@ -57,8 +61,9 @@ import { getPossibleEventMessages } from './utils/eventUtils';
import { merge } from './utils/merge';
import { parseSampleRate } from './utils/parseSampleRate';
import { prepareEvent } from './utils/prepareEvent';
import { showSpanDropWarning } from './utils/spanUtils';
import { showSpanDropWarning, spanToTraceContext } from './utils/spanUtils';
import { convertSpanJsonToTransactionEvent, convertTransactionEventToSpanJson } from './utils/transactionEvent';
import { _getSpanForScope } from './utils/spanOnScope';

const ALREADY_SEEN_ERROR = "Not capturing exception because it's already been captured.";
const MISSING_RELEASE_FOR_SESSION_ERROR = 'Discarded session because of missing or non-string release';
Expand DownExpand Up@@ -617,7 +622,7 @@ export abstract class Client<O extends ClientOptions = ClientOptions> {
public on(hook: 'close', callback: () => void): () => void;

/**
* Register a hook oin this client.
* Register a hook on this client.
*/
public on(hook: string, callback: unknown): () => void {
const hooks = (this._hooks[hook] = this._hooks[hook] || []);
Expand DownExpand Up@@ -1256,3 +1261,20 @@ function isErrorEvent(event: Event): event is ErrorEvent {
function isTransactionEvent(event: Event): event is TransactionEvent {
return event.type === 'transaction';
}

/** Extract trace information from scope */
export function _getTraceInfoFromScope(
client: Client,
scope: Scope | undefined,
): [dynamicSamplingContext: Partial<DynamicSamplingContext> | undefined, traceContext: TraceContext | undefined] {
if (!scope) {
return [undefined, undefined];
}

const span = _getSpanForScope(scope);
const traceContext = span ? spanToTraceContext(span) : getTraceContextFromScope(scope);
const dynamicSamplingContext = span
? getDynamicSamplingContextFromSpan(span)
: getDynamicSamplingContextFromScope(client, scope);
return [dynamicSamplingContext, traceContext];
}
1 change: 1 addition & 0 deletions packages/core/src/index.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -113,6 +113,7 @@ export { instrumentFetchRequest } from './fetch';
export { trpcMiddleware } from './trpc';
export { captureFeedback } from './feedback';
export type { ReportDialogOptions } from './report-dialog';
export { _INTERNAL_flushLogsBuffer } from './logs';

// TODO: Make this structure pretty again and don't do "export *"
export * from './utils-hoist/index';
Expand Down
15 changes: 15 additions & 0 deletions packages/core/src/logs/constants.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
import type { LogSeverityLevel } from '../types-hoist';

/**
* Maps a log severity level to a log severity number.
*
* @see LogSeverityLevel
*/
export const SEVERITY_TEXT_TO_SEVERITY_NUMBER: Partial<Record<LogSeverityLevel, number>> = {
trace: 1,
debug: 5,
info: 9,
warn: 13,
error: 17,
fatal: 21,
};
Loading