Skip to content

feat(core): Allow to specify depth to dropUndefinedKeys - #15783

Closed
mydea wants to merge 1 commit into
developfrom
fn/flatDropUndefinedKeys
Closed

feat(core): Allow to specify depth to dropUndefinedKeys#15783
mydea wants to merge 1 commit into
developfrom
fn/flatDropUndefinedKeys

Conversation

@mydea

@mydeamydea commented Mar 21, 2025

Copy link
Copy Markdown
Member

Today, dropUndefinedKeys() will iterate through all objects and arrays and make sure to drop undefined keys everywhere.

In reality, we do not need this behavior in most/many cases - often, just removing undefined values one level deep should be more than good enough (apart from cases like #15781 where we maybe do not need it at all!)

So this PR introduces an optional second argument to dropUndefinedKeys() which is a depth, which defaults to Infinity. It will drop undefined keys recursively until it reaches this depth.

By specifying e.g. 1 there, only the top level of the passed in object will be checked for undefined values.

@mydeamydea self-assigned this Mar 21, 2025
@mydea
mydea requested a review from a team as a code ownerMarch 21, 2025 11:52
@github-actions

github-actionsBot commented Mar 21, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser23.29 KB+0.07%+15 B 🔺
@sentry/browser - with treeshaking flags23.1 KB+0.07%+16 B 🔺
@sentry/browser (incl. Tracing)36.62 KB+0.05%+15 B 🔺
@sentry/browser (incl. Tracing, Replay)73.81 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.16 KB+0.04%+23 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)78.44 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)91.01 KB+0.02%+16 B 🔺
@sentry/browser (incl. Feedback)40.42 KB+0.04%+16 B 🔺
@sentry/browser (incl. sendFeedback)27.93 KB+0.06%+16 B 🔺
@sentry/browser (incl. FeedbackAsync)32.72 KB+0.05%+15 B 🔺
@sentry/react25.09 KB+0.07%+16 B 🔺
@sentry/react (incl. Tracing)38.55 KB+0.05%+18 B 🔺
@sentry/vue27.52 KB+0.07%+18 B 🔺
@sentry/vue (incl. Tracing)38.32 KB+0.04%+15 B 🔺
@sentry/svelte23.32 KB+0.07%+16 B 🔺
CDN Bundle24.51 KB+0.06%+15 B 🔺
CDN Bundle (incl. Tracing)36.63 KB+0.06%+21 B 🔺
CDN Bundle (incl. Tracing, Replay)71.65 KB+0.04%+28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)76.84 KB+0.04%+24 B 🔺
CDN Bundle - uncompressed71.66 KB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing) - uncompressed108.7 KB+0.04%+39 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed219.96 KB+0.02%+41 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed232.53 KB+0.02%+41 B 🔺
@sentry/nextjs (client)39.83 KB+0.06%+23 B 🔺
@sentry/sveltekit (client)37.04 KB+0.06%+20 B 🔺
@sentry/node142.64 KB+0.02%+17 B 🔺
@sentry/node - without tracing96.03 KB+0.02%+15 B 🔺
@sentry/aws-serverless120.4 KB+0.02%+18 B 🔺

View base workflow run

AbhiPrasad
AbhiPrasad reviewed Mar 21, 2025
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
links: convertSpanLinksForEnvelope(links),
});
return dropUndefinedKeys(

@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to call dropUndefinedKeys here?

@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@mydeamydeaMar 24, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted this out here: #15792 - I think you are right 🤔

@mydea
mydeaforce-pushed the fn/flatDropUndefinedKeys branch from 9e7b55d to f9e2f48CompareMarch 24, 2025 10:53
@mydea

mydea commented Mar 24, 2025

Copy link
Copy Markdown
MemberAuthor

Actually, after some more thought - maybe we can completely remove this and just rewrite the few places we actually need this 🤔

@mydeamydea closed this Mar 25, 2025
@mydea
mydea deleted the fn/flatDropUndefinedKeys branch March 25, 2025 14:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chargomechargomeAwaiting requested review from chargome
1 more reviewer
@AbhiPrasadAbhiPrasadAbhiPrasad left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mydeamydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@AbhiPrasad
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(core): Allow to specify depth to `dropUndefinedKeys` by mydea · Pull Request #15783 · getsentry/sentry-javascript · GitHub
Skip to content
feat(core): Allow to specify depth to dropUndefinedKeys - #15783
Closed
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Closed
feat(core): Allow to specify depth to dropUndefinedKeys#15783
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Conversation
@mydea
@mydeamydea
commented
Mar 21, 2025

Copy link


Copy Markdown

Member
Today, dropUndefinedKeys() will iterate through all objects and arrays and make sure to drop undefined keys everywhere.
In reality, we do not need this behavior in most/many cases - often, just removing undefined values one level deep should be more than good enough (apart from cases like #15781 where we maybe do not need it at all!)
So this PR introduces an optional second argument to dropUndefinedKeys() which is a depth, which defaults to Infinity. It will drop undefined keys recursively until it reaches this depth.
By specifying e.g. 1 there, only the top level of the passed in object will be checked for undefined values.
@mydeamydea
self-assigned this
Mar 21, 2025
@mydea
mydea
requested a review
from a team
as a code ownerMarch 21, 2025 11:52
@github-actions
github-actionsBot
commented
Mar 21, 2025

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.29 KB+0.07%+15 B 🔺
@sentry/browser - with treeshaking flags23.1 KB+0.07%+16 B 🔺
@sentry/browser (incl. Tracing)36.62 KB+0.05%+15 B 🔺
@sentry/browser (incl. Tracing, Replay)73.81 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.16 KB+0.04%+23 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)78.44 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)91.01 KB+0.02%+16 B 🔺
@sentry/browser (incl. Feedback)40.42 KB+0.04%+16 B 🔺
@sentry/browser (incl. sendFeedback)27.93 KB+0.06%+16 B 🔺
@sentry/browser (incl. FeedbackAsync)32.72 KB+0.05%+15 B 🔺
@sentry/react25.09 KB+0.07%+16 B 🔺
@sentry/react (incl. Tracing)38.55 KB+0.05%+18 B 🔺
@sentry/vue27.52 KB+0.07%+18 B 🔺
@sentry/vue (incl. Tracing)38.32 KB+0.04%+15 B 🔺
@sentry/svelte23.32 KB+0.07%+16 B 🔺
CDN Bundle24.51 KB+0.06%+15 B 🔺
CDN Bundle (incl. Tracing)36.63 KB+0.06%+21 B 🔺
CDN Bundle (incl. Tracing, Replay)71.65 KB+0.04%+28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)76.84 KB+0.04%+24 B 🔺
CDN Bundle - uncompressed71.66 KB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing) - uncompressed108.7 KB+0.04%+39 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed219.96 KB+0.02%+41 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed232.53 KB+0.02%+41 B 🔺
@sentry/nextjs (client)39.83 KB+0.06%+23 B 🔺
@sentry/sveltekit (client)37.04 KB+0.06%+20 B 🔺
@sentry/node142.64 KB+0.02%+17 B 🔺
@sentry/node - without tracing96.03 KB+0.02%+15 B 🔺
@sentry/aws-serverless120.4 KB+0.02%+18 B 🔺
View base workflow run
AbhiPrasad
AbhiPrasad
reviewed
Mar 21, 2025
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
 origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
 links: convertSpanLinksForEnvelope(links),
 });
 return dropUndefinedKeys(
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to call dropUndefinedKeys here?
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@mydeamydeaMar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted this out here: #15792 - I think you are right 🤔
@mydea
mydeaforce-pushed
the
fn/flatDropUndefinedKeys
branch
from
9e7b55d to
f9e2f48CompareMarch 24, 2025 10:53
@mydea
mydea
commented
Mar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Actually, after some more thought - maybe we can completely remove this and just rewrite the few places we actually need this 🤔
@mydeamydea
closed this
Mar 25, 2025
@mydea
mydea
deleted the

fn/flatDropUndefinedKeys

branch
March 25, 2025 14:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(core): Allow to specify depth to `dropUndefinedKeys` by mydea · Pull Request #15783 · getsentry/sentry-javascript · GitHub
Skip to content
feat(core): Allow to specify depth to dropUndefinedKeys - #15783
Closed
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Closed
feat(core): Allow to specify depth to dropUndefinedKeys#15783
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Conversation
@mydea
@mydeamydea
commented
Mar 21, 2025

Copy link


Copy Markdown

Member
Today, dropUndefinedKeys() will iterate through all objects and arrays and make sure to drop undefined keys everywhere.
In reality, we do not need this behavior in most/many cases - often, just removing undefined values one level deep should be more than good enough (apart from cases like #15781 where we maybe do not need it at all!)
So this PR introduces an optional second argument to dropUndefinedKeys() which is a depth, which defaults to Infinity. It will drop undefined keys recursively until it reaches this depth.
By specifying e.g. 1 there, only the top level of the passed in object will be checked for undefined values.
@mydeamydea
self-assigned this
Mar 21, 2025
@mydea
mydea
requested a review
from a team
as a code ownerMarch 21, 2025 11:52
@github-actions
github-actionsBot
commented
Mar 21, 2025

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.29 KB+0.07%+15 B 🔺
@sentry/browser - with treeshaking flags23.1 KB+0.07%+16 B 🔺
@sentry/browser (incl. Tracing)36.62 KB+0.05%+15 B 🔺
@sentry/browser (incl. Tracing, Replay)73.81 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.16 KB+0.04%+23 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)78.44 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)91.01 KB+0.02%+16 B 🔺
@sentry/browser (incl. Feedback)40.42 KB+0.04%+16 B 🔺
@sentry/browser (incl. sendFeedback)27.93 KB+0.06%+16 B 🔺
@sentry/browser (incl. FeedbackAsync)32.72 KB+0.05%+15 B 🔺
@sentry/react25.09 KB+0.07%+16 B 🔺
@sentry/react (incl. Tracing)38.55 KB+0.05%+18 B 🔺
@sentry/vue27.52 KB+0.07%+18 B 🔺
@sentry/vue (incl. Tracing)38.32 KB+0.04%+15 B 🔺
@sentry/svelte23.32 KB+0.07%+16 B 🔺
CDN Bundle24.51 KB+0.06%+15 B 🔺
CDN Bundle (incl. Tracing)36.63 KB+0.06%+21 B 🔺
CDN Bundle (incl. Tracing, Replay)71.65 KB+0.04%+28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)76.84 KB+0.04%+24 B 🔺
CDN Bundle - uncompressed71.66 KB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing) - uncompressed108.7 KB+0.04%+39 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed219.96 KB+0.02%+41 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed232.53 KB+0.02%+41 B 🔺
@sentry/nextjs (client)39.83 KB+0.06%+23 B 🔺
@sentry/sveltekit (client)37.04 KB+0.06%+20 B 🔺
@sentry/node142.64 KB+0.02%+17 B 🔺
@sentry/node - without tracing96.03 KB+0.02%+15 B 🔺
@sentry/aws-serverless120.4 KB+0.02%+18 B 🔺
View base workflow run
AbhiPrasad
AbhiPrasad
reviewed
Mar 21, 2025
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
 origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
 links: convertSpanLinksForEnvelope(links),
 });
 return dropUndefinedKeys(
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to call dropUndefinedKeys here?
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@mydeamydeaMar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted this out here: #15792 - I think you are right 🤔
@mydea
mydeaforce-pushed
the
fn/flatDropUndefinedKeys
branch
from
9e7b55d to
f9e2f48CompareMarch 24, 2025 10:53
@mydea
mydea
commented
Mar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Actually, after some more thought - maybe we can completely remove this and just rewrite the few places we actually need this 🤔
@mydeamydea
closed this
Mar 25, 2025
@mydea
mydea
deleted the

fn/flatDropUndefinedKeys

branch
March 25, 2025 14:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(core): Allow to specify depth to `dropUndefinedKeys` by mydea · Pull Request #15783 · getsentry/sentry-javascript · GitHub
Skip to content
feat(core): Allow to specify depth to dropUndefinedKeys - #15783
Closed
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Closed
feat(core): Allow to specify depth to dropUndefinedKeys#15783
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Conversation
@mydea
@mydeamydea
commented
Mar 21, 2025

Copy link


Copy Markdown

Member
Today, dropUndefinedKeys() will iterate through all objects and arrays and make sure to drop undefined keys everywhere.
In reality, we do not need this behavior in most/many cases - often, just removing undefined values one level deep should be more than good enough (apart from cases like #15781 where we maybe do not need it at all!)
So this PR introduces an optional second argument to dropUndefinedKeys() which is a depth, which defaults to Infinity. It will drop undefined keys recursively until it reaches this depth.
By specifying e.g. 1 there, only the top level of the passed in object will be checked for undefined values.
@mydeamydea
self-assigned this
Mar 21, 2025
@mydea
mydea
requested a review
from a team
as a code ownerMarch 21, 2025 11:52
@github-actions
github-actionsBot
commented
Mar 21, 2025

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.29 KB+0.07%+15 B 🔺
@sentry/browser - with treeshaking flags23.1 KB+0.07%+16 B 🔺
@sentry/browser (incl. Tracing)36.62 KB+0.05%+15 B 🔺
@sentry/browser (incl. Tracing, Replay)73.81 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.16 KB+0.04%+23 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)78.44 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)91.01 KB+0.02%+16 B 🔺
@sentry/browser (incl. Feedback)40.42 KB+0.04%+16 B 🔺
@sentry/browser (incl. sendFeedback)27.93 KB+0.06%+16 B 🔺
@sentry/browser (incl. FeedbackAsync)32.72 KB+0.05%+15 B 🔺
@sentry/react25.09 KB+0.07%+16 B 🔺
@sentry/react (incl. Tracing)38.55 KB+0.05%+18 B 🔺
@sentry/vue27.52 KB+0.07%+18 B 🔺
@sentry/vue (incl. Tracing)38.32 KB+0.04%+15 B 🔺
@sentry/svelte23.32 KB+0.07%+16 B 🔺
CDN Bundle24.51 KB+0.06%+15 B 🔺
CDN Bundle (incl. Tracing)36.63 KB+0.06%+21 B 🔺
CDN Bundle (incl. Tracing, Replay)71.65 KB+0.04%+28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)76.84 KB+0.04%+24 B 🔺
CDN Bundle - uncompressed71.66 KB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing) - uncompressed108.7 KB+0.04%+39 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed219.96 KB+0.02%+41 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed232.53 KB+0.02%+41 B 🔺
@sentry/nextjs (client)39.83 KB+0.06%+23 B 🔺
@sentry/sveltekit (client)37.04 KB+0.06%+20 B 🔺
@sentry/node142.64 KB+0.02%+17 B 🔺
@sentry/node - without tracing96.03 KB+0.02%+15 B 🔺
@sentry/aws-serverless120.4 KB+0.02%+18 B 🔺
View base workflow run
AbhiPrasad
AbhiPrasad
reviewed
Mar 21, 2025
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
 origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
 links: convertSpanLinksForEnvelope(links),
 });
 return dropUndefinedKeys(
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to call dropUndefinedKeys here?
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@mydeamydeaMar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted this out here: #15792 - I think you are right 🤔
@mydea
mydeaforce-pushed
the
fn/flatDropUndefinedKeys
branch
from
9e7b55d to
f9e2f48CompareMarch 24, 2025 10:53
@mydea
mydea
commented
Mar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Actually, after some more thought - maybe we can completely remove this and just rewrite the few places we actually need this 🤔
@mydeamydea
closed this
Mar 25, 2025
@mydea
mydea
deleted the

fn/flatDropUndefinedKeys

branch
March 25, 2025 14:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(core): Allow to specify depth to `dropUndefinedKeys` by mydea · Pull Request #15783 · getsentry/sentry-javascript · GitHub
Skip to content
feat(core): Allow to specify depth to dropUndefinedKeys - #15783
Closed
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Closed
feat(core): Allow to specify depth to dropUndefinedKeys#15783
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Conversation
@mydea
@mydeamydea
commented
Mar 21, 2025

Copy link


Copy Markdown

Member
Today, dropUndefinedKeys() will iterate through all objects and arrays and make sure to drop undefined keys everywhere.
In reality, we do not need this behavior in most/many cases - often, just removing undefined values one level deep should be more than good enough (apart from cases like #15781 where we maybe do not need it at all!)
So this PR introduces an optional second argument to dropUndefinedKeys() which is a depth, which defaults to Infinity. It will drop undefined keys recursively until it reaches this depth.
By specifying e.g. 1 there, only the top level of the passed in object will be checked for undefined values.
@mydeamydea
self-assigned this
Mar 21, 2025
@mydea
mydea
requested a review
from a team
as a code ownerMarch 21, 2025 11:52
@github-actions
github-actionsBot
commented
Mar 21, 2025

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.29 KB+0.07%+15 B 🔺
@sentry/browser - with treeshaking flags23.1 KB+0.07%+16 B 🔺
@sentry/browser (incl. Tracing)36.62 KB+0.05%+15 B 🔺
@sentry/browser (incl. Tracing, Replay)73.81 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.16 KB+0.04%+23 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)78.44 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)91.01 KB+0.02%+16 B 🔺
@sentry/browser (incl. Feedback)40.42 KB+0.04%+16 B 🔺
@sentry/browser (incl. sendFeedback)27.93 KB+0.06%+16 B 🔺
@sentry/browser (incl. FeedbackAsync)32.72 KB+0.05%+15 B 🔺
@sentry/react25.09 KB+0.07%+16 B 🔺
@sentry/react (incl. Tracing)38.55 KB+0.05%+18 B 🔺
@sentry/vue27.52 KB+0.07%+18 B 🔺
@sentry/vue (incl. Tracing)38.32 KB+0.04%+15 B 🔺
@sentry/svelte23.32 KB+0.07%+16 B 🔺
CDN Bundle24.51 KB+0.06%+15 B 🔺
CDN Bundle (incl. Tracing)36.63 KB+0.06%+21 B 🔺
CDN Bundle (incl. Tracing, Replay)71.65 KB+0.04%+28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)76.84 KB+0.04%+24 B 🔺
CDN Bundle - uncompressed71.66 KB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing) - uncompressed108.7 KB+0.04%+39 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed219.96 KB+0.02%+41 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed232.53 KB+0.02%+41 B 🔺
@sentry/nextjs (client)39.83 KB+0.06%+23 B 🔺
@sentry/sveltekit (client)37.04 KB+0.06%+20 B 🔺
@sentry/node142.64 KB+0.02%+17 B 🔺
@sentry/node - without tracing96.03 KB+0.02%+15 B 🔺
@sentry/aws-serverless120.4 KB+0.02%+18 B 🔺
View base workflow run
AbhiPrasad
AbhiPrasad
reviewed
Mar 21, 2025
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
 origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
 links: convertSpanLinksForEnvelope(links),
 });
 return dropUndefinedKeys(
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to call dropUndefinedKeys here?
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@mydeamydeaMar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted this out here: #15792 - I think you are right 🤔
@mydea
mydeaforce-pushed
the
fn/flatDropUndefinedKeys
branch
from
9e7b55d to
f9e2f48CompareMarch 24, 2025 10:53
@mydea
mydea
commented
Mar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Actually, after some more thought - maybe we can completely remove this and just rewrite the few places we actually need this 🤔
@mydeamydea
closed this
Mar 25, 2025
@mydea
mydea
deleted the

fn/flatDropUndefinedKeys

branch
March 25, 2025 14:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(core): Allow to specify depth to `dropUndefinedKeys` by mydea · Pull Request #15783 · getsentry/sentry-javascript · GitHub
Skip to content
feat(core): Allow to specify depth to dropUndefinedKeys - #15783
Closed
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Closed
feat(core): Allow to specify depth to dropUndefinedKeys#15783
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Conversation
@mydea
@mydeamydea
commented
Mar 21, 2025

Copy link


Copy Markdown

Member
Today, dropUndefinedKeys() will iterate through all objects and arrays and make sure to drop undefined keys everywhere.
In reality, we do not need this behavior in most/many cases - often, just removing undefined values one level deep should be more than good enough (apart from cases like #15781 where we maybe do not need it at all!)
So this PR introduces an optional second argument to dropUndefinedKeys() which is a depth, which defaults to Infinity. It will drop undefined keys recursively until it reaches this depth.
By specifying e.g. 1 there, only the top level of the passed in object will be checked for undefined values.
@mydeamydea
self-assigned this
Mar 21, 2025
@mydea
mydea
requested a review
from a team
as a code ownerMarch 21, 2025 11:52
@github-actions
github-actionsBot
commented
Mar 21, 2025

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.29 KB+0.07%+15 B 🔺
@sentry/browser - with treeshaking flags23.1 KB+0.07%+16 B 🔺
@sentry/browser (incl. Tracing)36.62 KB+0.05%+15 B 🔺
@sentry/browser (incl. Tracing, Replay)73.81 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.16 KB+0.04%+23 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)78.44 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)91.01 KB+0.02%+16 B 🔺
@sentry/browser (incl. Feedback)40.42 KB+0.04%+16 B 🔺
@sentry/browser (incl. sendFeedback)27.93 KB+0.06%+16 B 🔺
@sentry/browser (incl. FeedbackAsync)32.72 KB+0.05%+15 B 🔺
@sentry/react25.09 KB+0.07%+16 B 🔺
@sentry/react (incl. Tracing)38.55 KB+0.05%+18 B 🔺
@sentry/vue27.52 KB+0.07%+18 B 🔺
@sentry/vue (incl. Tracing)38.32 KB+0.04%+15 B 🔺
@sentry/svelte23.32 KB+0.07%+16 B 🔺
CDN Bundle24.51 KB+0.06%+15 B 🔺
CDN Bundle (incl. Tracing)36.63 KB+0.06%+21 B 🔺
CDN Bundle (incl. Tracing, Replay)71.65 KB+0.04%+28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)76.84 KB+0.04%+24 B 🔺
CDN Bundle - uncompressed71.66 KB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing) - uncompressed108.7 KB+0.04%+39 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed219.96 KB+0.02%+41 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed232.53 KB+0.02%+41 B 🔺
@sentry/nextjs (client)39.83 KB+0.06%+23 B 🔺
@sentry/sveltekit (client)37.04 KB+0.06%+20 B 🔺
@sentry/node142.64 KB+0.02%+17 B 🔺
@sentry/node - without tracing96.03 KB+0.02%+15 B 🔺
@sentry/aws-serverless120.4 KB+0.02%+18 B 🔺
View base workflow run
AbhiPrasad
AbhiPrasad
reviewed
Mar 21, 2025
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
 origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
 links: convertSpanLinksForEnvelope(links),
 });
 return dropUndefinedKeys(
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to call dropUndefinedKeys here?
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@mydeamydeaMar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted this out here: #15792 - I think you are right 🤔
@mydea
mydeaforce-pushed
the
fn/flatDropUndefinedKeys
branch
from
9e7b55d to
f9e2f48CompareMarch 24, 2025 10:53
@mydea
mydea
commented
Mar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Actually, after some more thought - maybe we can completely remove this and just rewrite the few places we actually need this 🤔
@mydeamydea
closed this
Mar 25, 2025
@mydea
mydea
deleted the

fn/flatDropUndefinedKeys

branch
March 25, 2025 14:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@AbhiPrasad

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
feat(core): Allow to specify depth to `dropUndefinedKeys` by mydea · Pull Request #15783 · getsentry/sentry-javascript · GitHub
Skip to content
feat(core): Allow to specify depth to dropUndefinedKeys - #15783
Closed
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Closed
feat(core): Allow to specify depth to dropUndefinedKeys#15783
mydea wants to merge 1 commit into
developfrom 
fn/flatDropUndefinedKeys
Conversation
@mydea
@mydeamydea
commented
Mar 21, 2025

Copy link


Copy Markdown

Member
Today, dropUndefinedKeys() will iterate through all objects and arrays and make sure to drop undefined keys everywhere.
In reality, we do not need this behavior in most/many cases - often, just removing undefined values one level deep should be more than good enough (apart from cases like #15781 where we maybe do not need it at all!)
So this PR introduces an optional second argument to dropUndefinedKeys() which is a depth, which defaults to Infinity. It will drop undefined keys recursively until it reaches this depth.
By specifying e.g. 1 there, only the top level of the passed in object will be checked for undefined values.
@mydeamydea
self-assigned this
Mar 21, 2025
@mydea
mydea
requested a review
from a team
as a code ownerMarch 21, 2025 11:52
@github-actions
github-actionsBot
commented
Mar 21, 2025

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.29 KB+0.07%+15 B 🔺
@sentry/browser - with treeshaking flags23.1 KB+0.07%+16 B 🔺
@sentry/browser (incl. Tracing)36.62 KB+0.05%+15 B 🔺
@sentry/browser (incl. Tracing, Replay)73.81 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.16 KB+0.04%+23 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)78.44 KB+0.03%+19 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)91.01 KB+0.02%+16 B 🔺
@sentry/browser (incl. Feedback)40.42 KB+0.04%+16 B 🔺
@sentry/browser (incl. sendFeedback)27.93 KB+0.06%+16 B 🔺
@sentry/browser (incl. FeedbackAsync)32.72 KB+0.05%+15 B 🔺
@sentry/react25.09 KB+0.07%+16 B 🔺
@sentry/react (incl. Tracing)38.55 KB+0.05%+18 B 🔺
@sentry/vue27.52 KB+0.07%+18 B 🔺
@sentry/vue (incl. Tracing)38.32 KB+0.04%+15 B 🔺
@sentry/svelte23.32 KB+0.07%+16 B 🔺
CDN Bundle24.51 KB+0.06%+15 B 🔺
CDN Bundle (incl. Tracing)36.63 KB+0.06%+21 B 🔺
CDN Bundle (incl. Tracing, Replay)71.65 KB+0.04%+28 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)76.84 KB+0.04%+24 B 🔺
CDN Bundle - uncompressed71.66 KB+0.05%+35 B 🔺
CDN Bundle (incl. Tracing) - uncompressed108.7 KB+0.04%+39 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed219.96 KB+0.02%+41 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed232.53 KB+0.02%+41 B 🔺
@sentry/nextjs (client)39.83 KB+0.06%+23 B 🔺
@sentry/sveltekit (client)37.04 KB+0.06%+20 B 🔺
@sentry/node142.64 KB+0.02%+17 B 🔺
@sentry/node - without tracing96.03 KB+0.02%+15 B 🔺
@sentry/aws-serverless120.4 KB+0.02%+18 B 🔺
View base workflow run
AbhiPrasad
AbhiPrasad
reviewed
Mar 21, 2025
View reviewed changes
Comment threadpackages/core/src/utils/spanUtils.ts
 origin: attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined,
 links: convertSpanLinksForEnvelope(links),
 });
 return dropUndefinedKeys(
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need to call dropUndefinedKeys here?
@AbhiPrasadAbhiPrasadMar 21, 2025

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
@mydeamydeaMar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I extracted this out here: #15792 - I think you are right 🤔
@mydea
mydeaforce-pushed
the
fn/flatDropUndefinedKeys
branch
from
9e7b55d to
f9e2f48CompareMarch 24, 2025 10:53
@mydea
mydea
commented
Mar 24, 2025

Copy link


Copy Markdown

MemberAuthor
Actually, after some more thought - maybe we can completely remove this and just rewrite the few places we actually need this 🤔
@mydeamydea
closed this
Mar 25, 2025
@mydea
mydea
deleted the

fn/flatDropUndefinedKeys

branch
March 25, 2025 14:54
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chargomechargomeAwaiting requested review from chargome

1 more reviewer

@AbhiPrasadAbhiPrasadAbhiPrasad left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@AbhiPrasad