Uh oh!
There was an error while loading. Please reload this page.
test: Add browser integration tests for logs - #15815
Merged
Merged
Conversation
AbhiPrasad
requested review from
s1gr1d and stephanie-anderson
and removed request for
a teamMarch 24, 2025 20:18
7 tasks
s1gr1d
reviewed
Mar 25, 2025
| Sentry.logger.warn('test warn'); | ||
| Sentry.logger.error('test error'); | ||
| Sentry.logger.fatal('test fatal'); | ||
| Sentry.logger.critical('test critical'); |
Member
There was a problem hiding this comment.
Should we maybe also test the overloaded functions here?
ContributorAuthor
There was a problem hiding this comment.
Overloaded functions only exist in Node
But we should test parameterization, I can add those!
AbhiPrasadforce-pushed
the
abhi-browser-logs-integration
branch
from
March 25, 2025 15:23
7119971 to
9376f7fCompares1gr1d
approved these changes
Mar 25, 2025
AbhiPrasad
enabled auto-merge (squash)
March 25, 2025 16:55
AbhiPrasad
commented
Mar 25, 2025
Uh oh!
There was an error while loading. Please reload this page.
AbhiPrasadforce-pushed
the
abhi-browser-logs-integration
branch
from
March 25, 2025 19:06
16cc20a to
c3605c4CompareAbhiPrasad
disabled auto-merge
March 25, 2025 21:16
AbhiPrasad
enabled auto-merge (squash)
March 25, 2025 22:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #15526