feat: Don't truncate error messages#15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lforst merged 4 commits into from
Mar 31, 2025
Merged

feat: Don't truncate error messages #15818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1273c20
feat: Don't truncate error messages
Mar 25, 2025
e8be995
Merge branch 'develop' into lforst-truncation-logic
Mar 26, 2025
40dd4fb
Fix some tests
Mar 27, 2025
f6b4763
.
Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions ...ages/browser-integration-tests/suites/public-api/captureException/linkedErrors/subject.js
View file
Open in desktop

@Lms24Lms24Mar 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't resist

image

Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
const wat = new Error(`This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be`);
const wat = new Error(`This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`);

wat.cause = new Error(`This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,`);
wat.cause = new Error(`This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`);

Sentry.captureException(wat);
18 changes: 10 additions & 8 deletions ...ackages/browser-integration-tests/suites/public-api/captureException/linkedErrors/test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ sentryTest('should capture a linked error with messages', async ({ getLocalTestU
expect(eventData.exception?.values).toHaveLength(2);
expect(eventData.exception?.values?.[0]).toMatchObject({
type: 'Error',
value: `This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long me...`,
value: `This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`,
mechanism: {
type: 'chained',
handled: true,
Expand All@@ -26,10 +27,11 @@ this is a very long me...`,
});
expect(eventData.exception?.values?.[1]).toMatchObject({
type: 'Error',
value: `This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated...`,
value: `This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`,
mechanism: {
type: 'generic',
handled: true,
Expand Down
9 changes: 0 additions & 9 deletions ...sts/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/subject.js
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions ...-tests/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/test.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/browser/src/integrations/linkederrors.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
// This differs from the LinkedErrors integration in core by using a different exceptionFromError function
exceptionFromError,
options.stackParser,
options.maxValueLength,
key,
limit,
event,
Expand Down
10 changes: 1 addition & 9 deletions packages/core/src/integrations/linkederrors.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,15 +22,7 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
preprocessEvent(event, hint, client) {
const options = client.getOptions();

applyAggregateErrorsToEvent(
exceptionFromError,
options.stackParser,
options.maxValueLength,
key,
limit,
event,
hint,
);
applyAggregateErrorsToEvent(exceptionFromError, options.stackParser, key, limit, event, hint);
},
};
}) satisfies IntegrationFn;
Expand Down
37 changes: 9 additions & 28 deletions packages/core/src/utils-hoist/aggregate-errors.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import type { Event, EventHint, Exception, ExtendedError, StackParser } from '../types-hoist';

import { isInstanceOf } from './is';
import { truncate } from './string';

/**
* Creates exceptions inside `event.exception.values` for errors that are nested on properties based on the `key` parameter.
*/
export function applyAggregateErrorsToEvent(
exceptionFromErrorImplementation: (stackParser: StackParser, ex: Error) => Exception,
parser: StackParser,
maxValueLimit: number = 250,
key: string,
limit: number,
event: Event,
Expand All@@ -25,18 +23,15 @@ export function applyAggregateErrorsToEvent(

// We only create exception grouping if there is an exception in the event.
if (originalException) {
event.exception.values = truncateAggregateExceptions(
aggregateExceptionsFromError(
exceptionFromErrorImplementation,
parser,
limit,
hint.originalException as ExtendedError,
key,
event.exception.values,
originalException,
0,
),
maxValueLimit,
event.exception.values = aggregateExceptionsFromError(
exceptionFromErrorImplementation,
parser,
limit,
hint.originalException as ExtendedError,
key,
event.exception.values,
originalException,
0,
);
}
}
Expand DownExpand Up@@ -129,17 +124,3 @@ function applyExceptionGroupFieldsForChildException(
parent_id: parentId,
};
}

/**
* Truncate the message (exception.value) of all exceptions in the event.
* Because this event processor is ran after `applyClientOptions`,
* we need to truncate the message of the added exceptions here.
*/
function truncateAggregateExceptions(exceptions: Exception[], maxValueLength: number): Exception[] {
return exceptions.map(exception => {
if (exception.value) {
exception.value = truncate(exception.value, maxValueLength);
}
return exception;
});
}
9 changes: 0 additions & 9 deletions packages/core/src/utils/prepareEvent.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -144,15 +144,6 @@ export function applyClientOptions(event: Event, options: ClientOptions): void {
event.dist = dist;
}

if (event.message) {
event.message = truncate(event.message, maxValueLength);
}

const exception = event.exception?.values?.[0];
if (exception?.value) {
exception.value = truncate(exception.value, maxValueLength);
}

const request = event.request;
if (request?.url) {
request.url = truncate(request.url, maxValueLength);
Expand Down
69 changes: 10 additions & 59 deletions packages/core/test/utils-hoist/aggregate-errors.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ describe('applyAggregateErrorsToEvent()', () => {
test('should not do anything if event does not contain an exception', () => {
const event: Event = { exception: undefined };
const eventHint: EventHint = { originalException: new Error() };
applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

// no changes
expect(event).toStrictEqual({ exception: undefined });
Expand All@@ -30,15 +30,15 @@ describe('applyAggregateErrorsToEvent()', () => {
test('should not do anything if event does not contain exception values', () => {
const event: Event = { exception: { values: undefined } };
const eventHint: EventHint = { originalException: new Error() };
applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

// no changes
expect(event).toStrictEqual({ exception: { values: undefined } });
});

test('should not do anything if event does not contain an event hint', () => {
const event: Event = { exception: { values: [] } };
applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, undefined);
applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, undefined);

// no changes
expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -47,7 +47,7 @@ describe('applyAggregateErrorsToEvent()', () => {
test('should not do anything if the event hint does not contain an original exception', () => {
const event: Event = { exception: { values: [] } };
const eventHint: EventHint = { originalException: undefined };
applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

// no changes
expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -62,7 +62,7 @@ describe('applyAggregateErrorsToEvent()', () => {
const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
const eventHint: EventHint = { originalException };

applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
expect(event).toStrictEqual({
exception: {
values: [
Expand DownExpand Up@@ -108,7 +108,7 @@ describe('applyAggregateErrorsToEvent()', () => {
const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
const eventHint: EventHint = { originalException };

applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

// no changes
expect(event).toStrictEqual({ exception: { values: [exceptionFromError(stackParser, originalException)] } });
Expand All@@ -127,7 +127,7 @@ describe('applyAggregateErrorsToEvent()', () => {
}

const eventHint: EventHint = { originalException };
applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 5, event, eventHint);
applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 5, event, eventHint);

// 6 -> one for original exception + 5 linked
expect(event.exception?.values).toHaveLength(5 + 1);
Expand All@@ -153,7 +153,7 @@ describe('applyAggregateErrorsToEvent()', () => {
const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError)] } };
const eventHint: EventHint = { originalException: fakeAggregateError };

applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
expect(event.exception?.values?.[event.exception.values.length - 1]?.mechanism?.type).toBe('instrument');
});

Expand All@@ -170,7 +170,7 @@ describe('applyAggregateErrorsToEvent()', () => {
const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError1)] } };
const eventHint: EventHint = { originalException: fakeAggregateError1 };

applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
expect(event).toStrictEqual({
exception: {
values: [
Expand DownExpand Up@@ -254,7 +254,7 @@ describe('applyAggregateErrorsToEvent()', () => {
const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
const eventHint: EventHint = { originalException };

applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
expect(event).toStrictEqual({
exception: {
values: [
Expand DownExpand Up@@ -293,53 +293,4 @@ describe('applyAggregateErrorsToEvent()', () => {
},
});
});

test('should truncate the exception values if they exceed the `maxValueLength` option', () => {
const originalException: ExtendedError = new Error('Root Error with long message');
originalException.cause = new Error('Nested Error 1 with longer message');
originalException.cause.cause = new Error('Nested Error 2 with longer message with longer message');

const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
const eventHint: EventHint = { originalException };

const maxValueLength = 15;
applyAggregateErrorsToEvent(exceptionFromError, stackParser, maxValueLength, 'cause', 10, event, eventHint);
expect(event).toStrictEqual({
exception: {
values: [
{
type: 'Error',
value: 'Nested Error 2 ...',
mechanism: {
exception_id: 2,
handled: true,
parent_id: 1,
source: 'cause',
type: 'chained',
},
},
{
type: 'Error',
value: 'Nested Error 1 ...',
mechanism: {
exception_id: 1,
handled: true,
parent_id: 0,
source: 'cause',
type: 'chained',
},
},
{
type: 'Error',
value: 'Root Error with...',
mechanism: {
exception_id: 0,
handled: true,
type: 'instrument',
},
},
],
},
});
});
});
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: Don't truncate error messages#15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

lforst
merged 4 commits into

from

Mar 31, 2025
 Merged


feat: Don't truncate error messages
#15818
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
1273c20

feat: Don't truncate error messages

Mar 25, 2025
e8be995

Merge branch 'develop' into lforst-truncation-logic

Mar 26, 2025
40dd4fb

Fix some tests

Mar 27, 2025
f6b4763

.

Mar 27, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 10 additions & 10 deletions
...ages/browser-integration-tests/suites/public-api/captureException/linkedErrors/subject.js

View file


Open in desktop

@Lms24Lms24Mar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't resist
image
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
const wat = new Error(`This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be`);
const wat = new Error(`This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`);

wat.cause = new Error(`This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,`);
wat.cause = new Error(`This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`);

Sentry.captureException(wat);

18 changes: 10 additions & 8 deletions
...ackages/browser-integration-tests/suites/public-api/captureException/linkedErrors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ sentryTest('should capture a linked error with messages', async ({ getLocalTestU
 expect(eventData.exception?.values).toHaveLength(2);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long me...`,
 value: `This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`,
 mechanism: {
 type: 'chained',
 handled: true,
Expand All@@ -26,10 +27,11 @@ this is a very long me...`,
 });
 expect(eventData.exception?.values?.[1]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated...`,
 value: `This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`,
 mechanism: {
 type: 'generic',
 handled: true,
Expand Down

9 changes: 0 additions & 9 deletions
...sts/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/subject.js

View file


Open in desktop


This file was deleted.


22 changes: 0 additions & 22 deletions
...-tests/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
packages/browser/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 // This differs from the LinkedErrors integration in core by using a different exceptionFromError function
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
Expand Down

10 changes: 1 addition & 9 deletions
packages/core/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,15 +22,7 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 preprocessEvent(event, hint, client) {
 const options = client.getOptions();

 applyAggregateErrorsToEvent(
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
 hint,
 );
 applyAggregateErrorsToEvent(exceptionFromError, options.stackParser, key, limit, event, hint);
 },
 };
}) satisfies IntegrationFn;
Expand Down

37 changes: 9 additions & 28 deletions
packages/core/src/utils-hoist/aggregate-errors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import type { Event, EventHint, Exception, ExtendedError, StackParser } from '../types-hoist';

import { isInstanceOf } from './is';
import { truncate } from './string';

/**
 * Creates exceptions inside `event.exception.values` for errors that are nested on properties based on the `key` parameter.
 */
export function applyAggregateErrorsToEvent(
 exceptionFromErrorImplementation: (stackParser: StackParser, ex: Error) => Exception,
 parser: StackParser,
 maxValueLimit: number = 250,
 key: string,
 limit: number,
 event: Event,
Expand All@@ -25,18 +23,15 @@ export function applyAggregateErrorsToEvent(

 // We only create exception grouping if there is an exception in the event.
 if (originalException) {
 event.exception.values = truncateAggregateExceptions(
 aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 ),
 maxValueLimit,
 event.exception.values = aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 );
 }
}
Expand DownExpand Up@@ -129,17 +124,3 @@ function applyExceptionGroupFieldsForChildException(
 parent_id: parentId,
 };
}

/**
 * Truncate the message (exception.value) of all exceptions in the event.
 * Because this event processor is ran after `applyClientOptions`,
 * we need to truncate the message of the added exceptions here.
 */
function truncateAggregateExceptions(exceptions: Exception[], maxValueLength: number): Exception[] {
 return exceptions.map(exception => {
 if (exception.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }
 return exception;
 });
}

9 changes: 0 additions & 9 deletions
packages/core/src/utils/prepareEvent.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,15 +144,6 @@ export function applyClientOptions(event: Event, options: ClientOptions): void {
 event.dist = dist;
 }

 if (event.message) {
 event.message = truncate(event.message, maxValueLength);
 }

 const exception = event.exception?.values?.[0];
 if (exception?.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }

 const request = event.request;
 if (request?.url) {
 request.url = truncate(request.url, maxValueLength);
Expand Down

69 changes: 10 additions & 59 deletions
packages/core/test/utils-hoist/aggregate-errors.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain an exception', () => {
 const event: Event = { exception: undefined };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: undefined });
Expand All@@ -30,15 +30,15 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain exception values', () => {
 const event: Event = { exception: { values: undefined } };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: undefined } });
 });

 test('should not do anything if event does not contain an event hint', () => {
 const event: Event = { exception: { values: [] } };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, undefined);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, undefined);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -47,7 +47,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if the event hint does not contain an original exception', () => {
 const event: Event = { exception: { values: [] } };
 const eventHint: EventHint = { originalException: undefined };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -62,7 +62,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -108,7 +108,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [exceptionFromError(stackParser, originalException)] } });
Expand All@@ -127,7 +127,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 }

 const eventHint: EventHint = { originalException };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 5, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 5, event, eventHint);

 // 6 -> one for original exception + 5 linked
 expect(event.exception?.values).toHaveLength(5 + 1);
Expand All@@ -153,7 +153,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event.exception?.values?.[event.exception.values.length - 1]?.mechanism?.type).toBe('instrument');
 });

Expand All@@ -170,7 +170,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError1)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError1 };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -254,7 +254,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -293,53 +293,4 @@ describe('applyAggregateErrorsToEvent()', () => {
 },
 });
 });

 test('should truncate the exception values if they exceed the `maxValueLength` option', () => {
 const originalException: ExtendedError = new Error('Root Error with long message');
 originalException.cause = new Error('Nested Error 1 with longer message');
 originalException.cause.cause = new Error('Nested Error 2 with longer message with longer message');

 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 const maxValueLength = 15;
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, maxValueLength, 'cause', 10, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
 {
 type: 'Error',
 value: 'Nested Error 2 ...',
 mechanism: {
 exception_id: 2,
 handled: true,
 parent_id: 1,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Nested Error 1 ...',
 mechanism: {
 exception_id: 1,
 handled: true,
 parent_id: 0,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Root Error with...',
 mechanism: {
 exception_id: 0,
 handled: true,
 type: 'instrument',
 },
 },
 ],
 },
 });
 });
});

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Don't truncate error messages#15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

lforst
merged 4 commits into

from

Mar 31, 2025
 Merged


feat: Don't truncate error messages
#15818
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
1273c20

feat: Don't truncate error messages

Mar 25, 2025
e8be995

Merge branch 'develop' into lforst-truncation-logic

Mar 26, 2025
40dd4fb

Fix some tests

Mar 27, 2025
f6b4763

.

Mar 27, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 10 additions & 10 deletions
...ages/browser-integration-tests/suites/public-api/captureException/linkedErrors/subject.js

View file


Open in desktop

@Lms24Lms24Mar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't resist
image
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
const wat = new Error(`This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be`);
const wat = new Error(`This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`);

wat.cause = new Error(`This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,`);
wat.cause = new Error(`This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`);

Sentry.captureException(wat);

18 changes: 10 additions & 8 deletions
...ackages/browser-integration-tests/suites/public-api/captureException/linkedErrors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ sentryTest('should capture a linked error with messages', async ({ getLocalTestU
 expect(eventData.exception?.values).toHaveLength(2);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long me...`,
 value: `This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`,
 mechanism: {
 type: 'chained',
 handled: true,
Expand All@@ -26,10 +27,11 @@ this is a very long me...`,
 });
 expect(eventData.exception?.values?.[1]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated...`,
 value: `This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`,
 mechanism: {
 type: 'generic',
 handled: true,
Expand Down

9 changes: 0 additions & 9 deletions
...sts/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/subject.js

View file


Open in desktop


This file was deleted.


22 changes: 0 additions & 22 deletions
...-tests/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
packages/browser/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 // This differs from the LinkedErrors integration in core by using a different exceptionFromError function
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
Expand Down

10 changes: 1 addition & 9 deletions
packages/core/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,15 +22,7 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 preprocessEvent(event, hint, client) {
 const options = client.getOptions();

 applyAggregateErrorsToEvent(
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
 hint,
 );
 applyAggregateErrorsToEvent(exceptionFromError, options.stackParser, key, limit, event, hint);
 },
 };
}) satisfies IntegrationFn;
Expand Down

37 changes: 9 additions & 28 deletions
packages/core/src/utils-hoist/aggregate-errors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import type { Event, EventHint, Exception, ExtendedError, StackParser } from '../types-hoist';

import { isInstanceOf } from './is';
import { truncate } from './string';

/**
 * Creates exceptions inside `event.exception.values` for errors that are nested on properties based on the `key` parameter.
 */
export function applyAggregateErrorsToEvent(
 exceptionFromErrorImplementation: (stackParser: StackParser, ex: Error) => Exception,
 parser: StackParser,
 maxValueLimit: number = 250,
 key: string,
 limit: number,
 event: Event,
Expand All@@ -25,18 +23,15 @@ export function applyAggregateErrorsToEvent(

 // We only create exception grouping if there is an exception in the event.
 if (originalException) {
 event.exception.values = truncateAggregateExceptions(
 aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 ),
 maxValueLimit,
 event.exception.values = aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 );
 }
}
Expand DownExpand Up@@ -129,17 +124,3 @@ function applyExceptionGroupFieldsForChildException(
 parent_id: parentId,
 };
}

/**
 * Truncate the message (exception.value) of all exceptions in the event.
 * Because this event processor is ran after `applyClientOptions`,
 * we need to truncate the message of the added exceptions here.
 */
function truncateAggregateExceptions(exceptions: Exception[], maxValueLength: number): Exception[] {
 return exceptions.map(exception => {
 if (exception.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }
 return exception;
 });
}

9 changes: 0 additions & 9 deletions
packages/core/src/utils/prepareEvent.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,15 +144,6 @@ export function applyClientOptions(event: Event, options: ClientOptions): void {
 event.dist = dist;
 }

 if (event.message) {
 event.message = truncate(event.message, maxValueLength);
 }

 const exception = event.exception?.values?.[0];
 if (exception?.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }

 const request = event.request;
 if (request?.url) {
 request.url = truncate(request.url, maxValueLength);
Expand Down

69 changes: 10 additions & 59 deletions
packages/core/test/utils-hoist/aggregate-errors.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain an exception', () => {
 const event: Event = { exception: undefined };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: undefined });
Expand All@@ -30,15 +30,15 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain exception values', () => {
 const event: Event = { exception: { values: undefined } };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: undefined } });
 });

 test('should not do anything if event does not contain an event hint', () => {
 const event: Event = { exception: { values: [] } };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, undefined);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, undefined);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -47,7 +47,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if the event hint does not contain an original exception', () => {
 const event: Event = { exception: { values: [] } };
 const eventHint: EventHint = { originalException: undefined };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -62,7 +62,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -108,7 +108,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [exceptionFromError(stackParser, originalException)] } });
Expand All@@ -127,7 +127,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 }

 const eventHint: EventHint = { originalException };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 5, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 5, event, eventHint);

 // 6 -> one for original exception + 5 linked
 expect(event.exception?.values).toHaveLength(5 + 1);
Expand All@@ -153,7 +153,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event.exception?.values?.[event.exception.values.length - 1]?.mechanism?.type).toBe('instrument');
 });

Expand All@@ -170,7 +170,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError1)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError1 };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -254,7 +254,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -293,53 +293,4 @@ describe('applyAggregateErrorsToEvent()', () => {
 },
 });
 });

 test('should truncate the exception values if they exceed the `maxValueLength` option', () => {
 const originalException: ExtendedError = new Error('Root Error with long message');
 originalException.cause = new Error('Nested Error 1 with longer message');
 originalException.cause.cause = new Error('Nested Error 2 with longer message with longer message');

 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 const maxValueLength = 15;
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, maxValueLength, 'cause', 10, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
 {
 type: 'Error',
 value: 'Nested Error 2 ...',
 mechanism: {
 exception_id: 2,
 handled: true,
 parent_id: 1,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Nested Error 1 ...',
 mechanism: {
 exception_id: 1,
 handled: true,
 parent_id: 0,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Root Error with...',
 mechanism: {
 exception_id: 0,
 handled: true,
 type: 'instrument',
 },
 },
 ],
 },
 });
 });
});

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Don't truncate error messages#15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

lforst
merged 4 commits into

from

Mar 31, 2025
 Merged


feat: Don't truncate error messages
#15818
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
1273c20

feat: Don't truncate error messages

Mar 25, 2025
e8be995

Merge branch 'develop' into lforst-truncation-logic

Mar 26, 2025
40dd4fb

Fix some tests

Mar 27, 2025
f6b4763

.

Mar 27, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 10 additions & 10 deletions
...ages/browser-integration-tests/suites/public-api/captureException/linkedErrors/subject.js

View file


Open in desktop

@Lms24Lms24Mar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't resist
image
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
const wat = new Error(`This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be`);
const wat = new Error(`This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`);

wat.cause = new Error(`This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,`);
wat.cause = new Error(`This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`);

Sentry.captureException(wat);

18 changes: 10 additions & 8 deletions
...ackages/browser-integration-tests/suites/public-api/captureException/linkedErrors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ sentryTest('should capture a linked error with messages', async ({ getLocalTestU
 expect(eventData.exception?.values).toHaveLength(2);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long me...`,
 value: `This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`,
 mechanism: {
 type: 'chained',
 handled: true,
Expand All@@ -26,10 +27,11 @@ this is a very long me...`,
 });
 expect(eventData.exception?.values?.[1]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated...`,
 value: `This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`,
 mechanism: {
 type: 'generic',
 handled: true,
Expand Down

9 changes: 0 additions & 9 deletions
...sts/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/subject.js

View file


Open in desktop


This file was deleted.


22 changes: 0 additions & 22 deletions
...-tests/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
packages/browser/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 // This differs from the LinkedErrors integration in core by using a different exceptionFromError function
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
Expand Down

10 changes: 1 addition & 9 deletions
packages/core/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,15 +22,7 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 preprocessEvent(event, hint, client) {
 const options = client.getOptions();

 applyAggregateErrorsToEvent(
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
 hint,
 );
 applyAggregateErrorsToEvent(exceptionFromError, options.stackParser, key, limit, event, hint);
 },
 };
}) satisfies IntegrationFn;
Expand Down

37 changes: 9 additions & 28 deletions
packages/core/src/utils-hoist/aggregate-errors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import type { Event, EventHint, Exception, ExtendedError, StackParser } from '../types-hoist';

import { isInstanceOf } from './is';
import { truncate } from './string';

/**
 * Creates exceptions inside `event.exception.values` for errors that are nested on properties based on the `key` parameter.
 */
export function applyAggregateErrorsToEvent(
 exceptionFromErrorImplementation: (stackParser: StackParser, ex: Error) => Exception,
 parser: StackParser,
 maxValueLimit: number = 250,
 key: string,
 limit: number,
 event: Event,
Expand All@@ -25,18 +23,15 @@ export function applyAggregateErrorsToEvent(

 // We only create exception grouping if there is an exception in the event.
 if (originalException) {
 event.exception.values = truncateAggregateExceptions(
 aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 ),
 maxValueLimit,
 event.exception.values = aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 );
 }
}
Expand DownExpand Up@@ -129,17 +124,3 @@ function applyExceptionGroupFieldsForChildException(
 parent_id: parentId,
 };
}

/**
 * Truncate the message (exception.value) of all exceptions in the event.
 * Because this event processor is ran after `applyClientOptions`,
 * we need to truncate the message of the added exceptions here.
 */
function truncateAggregateExceptions(exceptions: Exception[], maxValueLength: number): Exception[] {
 return exceptions.map(exception => {
 if (exception.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }
 return exception;
 });
}

9 changes: 0 additions & 9 deletions
packages/core/src/utils/prepareEvent.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,15 +144,6 @@ export function applyClientOptions(event: Event, options: ClientOptions): void {
 event.dist = dist;
 }

 if (event.message) {
 event.message = truncate(event.message, maxValueLength);
 }

 const exception = event.exception?.values?.[0];
 if (exception?.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }

 const request = event.request;
 if (request?.url) {
 request.url = truncate(request.url, maxValueLength);
Expand Down

69 changes: 10 additions & 59 deletions
packages/core/test/utils-hoist/aggregate-errors.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain an exception', () => {
 const event: Event = { exception: undefined };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: undefined });
Expand All@@ -30,15 +30,15 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain exception values', () => {
 const event: Event = { exception: { values: undefined } };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: undefined } });
 });

 test('should not do anything if event does not contain an event hint', () => {
 const event: Event = { exception: { values: [] } };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, undefined);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, undefined);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -47,7 +47,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if the event hint does not contain an original exception', () => {
 const event: Event = { exception: { values: [] } };
 const eventHint: EventHint = { originalException: undefined };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -62,7 +62,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -108,7 +108,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [exceptionFromError(stackParser, originalException)] } });
Expand All@@ -127,7 +127,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 }

 const eventHint: EventHint = { originalException };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 5, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 5, event, eventHint);

 // 6 -> one for original exception + 5 linked
 expect(event.exception?.values).toHaveLength(5 + 1);
Expand All@@ -153,7 +153,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event.exception?.values?.[event.exception.values.length - 1]?.mechanism?.type).toBe('instrument');
 });

Expand All@@ -170,7 +170,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError1)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError1 };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -254,7 +254,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -293,53 +293,4 @@ describe('applyAggregateErrorsToEvent()', () => {
 },
 });
 });

 test('should truncate the exception values if they exceed the `maxValueLength` option', () => {
 const originalException: ExtendedError = new Error('Root Error with long message');
 originalException.cause = new Error('Nested Error 1 with longer message');
 originalException.cause.cause = new Error('Nested Error 2 with longer message with longer message');

 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 const maxValueLength = 15;
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, maxValueLength, 'cause', 10, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
 {
 type: 'Error',
 value: 'Nested Error 2 ...',
 mechanism: {
 exception_id: 2,
 handled: true,
 parent_id: 1,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Nested Error 1 ...',
 mechanism: {
 exception_id: 1,
 handled: true,
 parent_id: 0,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Root Error with...',
 mechanism: {
 exception_id: 0,
 handled: true,
 type: 'instrument',
 },
 },
 ],
 },
 });
 });
});

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: Don't truncate error messages#15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

lforst
merged 4 commits into

from

Mar 31, 2025
 Merged


feat: Don't truncate error messages
#15818
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
1273c20

feat: Don't truncate error messages

Mar 25, 2025
e8be995

Merge branch 'develop' into lforst-truncation-logic

Mar 26, 2025
40dd4fb

Fix some tests

Mar 27, 2025
f6b4763

.

Mar 27, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 10 additions & 10 deletions
...ages/browser-integration-tests/suites/public-api/captureException/linkedErrors/subject.js

View file


Open in desktop

@Lms24Lms24Mar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't resist
image
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
const wat = new Error(`This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be`);
const wat = new Error(`This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`);

wat.cause = new Error(`This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,`);
wat.cause = new Error(`This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`);

Sentry.captureException(wat);

18 changes: 10 additions & 8 deletions
...ackages/browser-integration-tests/suites/public-api/captureException/linkedErrors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ sentryTest('should capture a linked error with messages', async ({ getLocalTestU
 expect(eventData.exception?.values).toHaveLength(2);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long me...`,
 value: `This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`,
 mechanism: {
 type: 'chained',
 handled: true,
Expand All@@ -26,10 +27,11 @@ this is a very long me...`,
 });
 expect(eventData.exception?.values?.[1]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated...`,
 value: `This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`,
 mechanism: {
 type: 'generic',
 handled: true,
Expand Down

9 changes: 0 additions & 9 deletions
...sts/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/subject.js

View file


Open in desktop


This file was deleted.


22 changes: 0 additions & 22 deletions
...-tests/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
packages/browser/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 // This differs from the LinkedErrors integration in core by using a different exceptionFromError function
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
Expand Down

10 changes: 1 addition & 9 deletions
packages/core/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,15 +22,7 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 preprocessEvent(event, hint, client) {
 const options = client.getOptions();

 applyAggregateErrorsToEvent(
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
 hint,
 );
 applyAggregateErrorsToEvent(exceptionFromError, options.stackParser, key, limit, event, hint);
 },
 };
}) satisfies IntegrationFn;
Expand Down

37 changes: 9 additions & 28 deletions
packages/core/src/utils-hoist/aggregate-errors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import type { Event, EventHint, Exception, ExtendedError, StackParser } from '../types-hoist';

import { isInstanceOf } from './is';
import { truncate } from './string';

/**
 * Creates exceptions inside `event.exception.values` for errors that are nested on properties based on the `key` parameter.
 */
export function applyAggregateErrorsToEvent(
 exceptionFromErrorImplementation: (stackParser: StackParser, ex: Error) => Exception,
 parser: StackParser,
 maxValueLimit: number = 250,
 key: string,
 limit: number,
 event: Event,
Expand All@@ -25,18 +23,15 @@ export function applyAggregateErrorsToEvent(

 // We only create exception grouping if there is an exception in the event.
 if (originalException) {
 event.exception.values = truncateAggregateExceptions(
 aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 ),
 maxValueLimit,
 event.exception.values = aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 );
 }
}
Expand DownExpand Up@@ -129,17 +124,3 @@ function applyExceptionGroupFieldsForChildException(
 parent_id: parentId,
 };
}

/**
 * Truncate the message (exception.value) of all exceptions in the event.
 * Because this event processor is ran after `applyClientOptions`,
 * we need to truncate the message of the added exceptions here.
 */
function truncateAggregateExceptions(exceptions: Exception[], maxValueLength: number): Exception[] {
 return exceptions.map(exception => {
 if (exception.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }
 return exception;
 });
}

9 changes: 0 additions & 9 deletions
packages/core/src/utils/prepareEvent.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,15 +144,6 @@ export function applyClientOptions(event: Event, options: ClientOptions): void {
 event.dist = dist;
 }

 if (event.message) {
 event.message = truncate(event.message, maxValueLength);
 }

 const exception = event.exception?.values?.[0];
 if (exception?.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }

 const request = event.request;
 if (request?.url) {
 request.url = truncate(request.url, maxValueLength);
Expand Down

69 changes: 10 additions & 59 deletions
packages/core/test/utils-hoist/aggregate-errors.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain an exception', () => {
 const event: Event = { exception: undefined };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: undefined });
Expand All@@ -30,15 +30,15 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain exception values', () => {
 const event: Event = { exception: { values: undefined } };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: undefined } });
 });

 test('should not do anything if event does not contain an event hint', () => {
 const event: Event = { exception: { values: [] } };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, undefined);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, undefined);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -47,7 +47,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if the event hint does not contain an original exception', () => {
 const event: Event = { exception: { values: [] } };
 const eventHint: EventHint = { originalException: undefined };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -62,7 +62,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -108,7 +108,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [exceptionFromError(stackParser, originalException)] } });
Expand All@@ -127,7 +127,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 }

 const eventHint: EventHint = { originalException };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 5, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 5, event, eventHint);

 // 6 -> one for original exception + 5 linked
 expect(event.exception?.values).toHaveLength(5 + 1);
Expand All@@ -153,7 +153,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event.exception?.values?.[event.exception.values.length - 1]?.mechanism?.type).toBe('instrument');
 });

Expand All@@ -170,7 +170,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError1)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError1 };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -254,7 +254,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -293,53 +293,4 @@ describe('applyAggregateErrorsToEvent()', () => {
 },
 });
 });

 test('should truncate the exception values if they exceed the `maxValueLength` option', () => {
 const originalException: ExtendedError = new Error('Root Error with long message');
 originalException.cause = new Error('Nested Error 1 with longer message');
 originalException.cause.cause = new Error('Nested Error 2 with longer message with longer message');

 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 const maxValueLength = 15;
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, maxValueLength, 'cause', 10, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
 {
 type: 'Error',
 value: 'Nested Error 2 ...',
 mechanism: {
 exception_id: 2,
 handled: true,
 parent_id: 1,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Nested Error 1 ...',
 mechanism: {
 exception_id: 1,
 handled: true,
 parent_id: 0,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Root Error with...',
 mechanism: {
 exception_id: 0,
 handled: true,
 type: 'instrument',
 },
 },
 ],
 },
 });
 });
});

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Don't truncate error messages#15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

lforst
merged 4 commits into

from

Mar 31, 2025
 Merged


feat: Don't truncate error messages
#15818
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
1273c20

feat: Don't truncate error messages

Mar 25, 2025
e8be995

Merge branch 'develop' into lforst-truncation-logic

Mar 26, 2025
40dd4fb

Fix some tests

Mar 27, 2025
f6b4763

.

Mar 27, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 10 additions & 10 deletions
...ages/browser-integration-tests/suites/public-api/captureException/linkedErrors/subject.js

View file


Open in desktop

@Lms24Lms24Mar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't resist
image
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
const wat = new Error(`This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be`);
const wat = new Error(`This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`);

wat.cause = new Error(`This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,`);
wat.cause = new Error(`This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`);

Sentry.captureException(wat);

18 changes: 10 additions & 8 deletions
...ackages/browser-integration-tests/suites/public-api/captureException/linkedErrors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ sentryTest('should capture a linked error with messages', async ({ getLocalTestU
 expect(eventData.exception?.values).toHaveLength(2);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long me...`,
 value: `This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`,
 mechanism: {
 type: 'chained',
 handled: true,
Expand All@@ -26,10 +27,11 @@ this is a very long me...`,
 });
 expect(eventData.exception?.values?.[1]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated...`,
 value: `This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`,
 mechanism: {
 type: 'generic',
 handled: true,
Expand Down

9 changes: 0 additions & 9 deletions
...sts/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/subject.js

View file


Open in desktop


This file was deleted.


22 changes: 0 additions & 22 deletions
...-tests/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
packages/browser/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 // This differs from the LinkedErrors integration in core by using a different exceptionFromError function
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
Expand Down

10 changes: 1 addition & 9 deletions
packages/core/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,15 +22,7 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 preprocessEvent(event, hint, client) {
 const options = client.getOptions();

 applyAggregateErrorsToEvent(
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
 hint,
 );
 applyAggregateErrorsToEvent(exceptionFromError, options.stackParser, key, limit, event, hint);
 },
 };
}) satisfies IntegrationFn;
Expand Down

37 changes: 9 additions & 28 deletions
packages/core/src/utils-hoist/aggregate-errors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import type { Event, EventHint, Exception, ExtendedError, StackParser } from '../types-hoist';

import { isInstanceOf } from './is';
import { truncate } from './string';

/**
 * Creates exceptions inside `event.exception.values` for errors that are nested on properties based on the `key` parameter.
 */
export function applyAggregateErrorsToEvent(
 exceptionFromErrorImplementation: (stackParser: StackParser, ex: Error) => Exception,
 parser: StackParser,
 maxValueLimit: number = 250,
 key: string,
 limit: number,
 event: Event,
Expand All@@ -25,18 +23,15 @@ export function applyAggregateErrorsToEvent(

 // We only create exception grouping if there is an exception in the event.
 if (originalException) {
 event.exception.values = truncateAggregateExceptions(
 aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 ),
 maxValueLimit,
 event.exception.values = aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 );
 }
}
Expand DownExpand Up@@ -129,17 +124,3 @@ function applyExceptionGroupFieldsForChildException(
 parent_id: parentId,
 };
}

/**
 * Truncate the message (exception.value) of all exceptions in the event.
 * Because this event processor is ran after `applyClientOptions`,
 * we need to truncate the message of the added exceptions here.
 */
function truncateAggregateExceptions(exceptions: Exception[], maxValueLength: number): Exception[] {
 return exceptions.map(exception => {
 if (exception.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }
 return exception;
 });
}

9 changes: 0 additions & 9 deletions
packages/core/src/utils/prepareEvent.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,15 +144,6 @@ export function applyClientOptions(event: Event, options: ClientOptions): void {
 event.dist = dist;
 }

 if (event.message) {
 event.message = truncate(event.message, maxValueLength);
 }

 const exception = event.exception?.values?.[0];
 if (exception?.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }

 const request = event.request;
 if (request?.url) {
 request.url = truncate(request.url, maxValueLength);
Expand Down

69 changes: 10 additions & 59 deletions
packages/core/test/utils-hoist/aggregate-errors.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain an exception', () => {
 const event: Event = { exception: undefined };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: undefined });
Expand All@@ -30,15 +30,15 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain exception values', () => {
 const event: Event = { exception: { values: undefined } };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: undefined } });
 });

 test('should not do anything if event does not contain an event hint', () => {
 const event: Event = { exception: { values: [] } };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, undefined);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, undefined);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -47,7 +47,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if the event hint does not contain an original exception', () => {
 const event: Event = { exception: { values: [] } };
 const eventHint: EventHint = { originalException: undefined };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -62,7 +62,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -108,7 +108,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [exceptionFromError(stackParser, originalException)] } });
Expand All@@ -127,7 +127,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 }

 const eventHint: EventHint = { originalException };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 5, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 5, event, eventHint);

 // 6 -> one for original exception + 5 linked
 expect(event.exception?.values).toHaveLength(5 + 1);
Expand All@@ -153,7 +153,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event.exception?.values?.[event.exception.values.length - 1]?.mechanism?.type).toBe('instrument');
 });

Expand All@@ -170,7 +170,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError1)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError1 };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -254,7 +254,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -293,53 +293,4 @@ describe('applyAggregateErrorsToEvent()', () => {
 },
 });
 });

 test('should truncate the exception values if they exceed the `maxValueLength` option', () => {
 const originalException: ExtendedError = new Error('Root Error with long message');
 originalException.cause = new Error('Nested Error 1 with longer message');
 originalException.cause.cause = new Error('Nested Error 2 with longer message with longer message');

 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 const maxValueLength = 15;
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, maxValueLength, 'cause', 10, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
 {
 type: 'Error',
 value: 'Nested Error 2 ...',
 mechanism: {
 exception_id: 2,
 handled: true,
 parent_id: 1,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Nested Error 1 ...',
 mechanism: {
 exception_id: 1,
 handled: true,
 parent_id: 0,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Root Error with...',
 mechanism: {
 exception_id: 0,
 handled: true,
 type: 'instrument',
 },
 },
 ],
 },
 });
 });
});

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Don't truncate error messages#15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

lforst
merged 4 commits into

from

Mar 31, 2025
 Merged


feat: Don't truncate error messages
#15818
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
1273c20

feat: Don't truncate error messages

Mar 25, 2025
e8be995

Merge branch 'develop' into lforst-truncation-logic

Mar 26, 2025
40dd4fb

Fix some tests

Mar 27, 2025
f6b4763

.

Mar 27, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 10 additions & 10 deletions
...ages/browser-integration-tests/suites/public-api/captureException/linkedErrors/subject.js

View file


Open in desktop

@Lms24Lms24Mar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't resist
image
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
const wat = new Error(`This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be`);
const wat = new Error(`This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`);

wat.cause = new Error(`This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,`);
wat.cause = new Error(`This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`);

Sentry.captureException(wat);

18 changes: 10 additions & 8 deletions
...ackages/browser-integration-tests/suites/public-api/captureException/linkedErrors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ sentryTest('should capture a linked error with messages', async ({ getLocalTestU
 expect(eventData.exception?.values).toHaveLength(2);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long me...`,
 value: `This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`,
 mechanism: {
 type: 'chained',
 handled: true,
Expand All@@ -26,10 +27,11 @@ this is a very long me...`,
 });
 expect(eventData.exception?.values?.[1]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated...`,
 value: `This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`,
 mechanism: {
 type: 'generic',
 handled: true,
Expand Down

9 changes: 0 additions & 9 deletions
...sts/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/subject.js

View file


Open in desktop


This file was deleted.


22 changes: 0 additions & 22 deletions
...-tests/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
packages/browser/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 // This differs from the LinkedErrors integration in core by using a different exceptionFromError function
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
Expand Down

10 changes: 1 addition & 9 deletions
packages/core/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,15 +22,7 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 preprocessEvent(event, hint, client) {
 const options = client.getOptions();

 applyAggregateErrorsToEvent(
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
 hint,
 );
 applyAggregateErrorsToEvent(exceptionFromError, options.stackParser, key, limit, event, hint);
 },
 };
}) satisfies IntegrationFn;
Expand Down

37 changes: 9 additions & 28 deletions
packages/core/src/utils-hoist/aggregate-errors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import type { Event, EventHint, Exception, ExtendedError, StackParser } from '../types-hoist';

import { isInstanceOf } from './is';
import { truncate } from './string';

/**
 * Creates exceptions inside `event.exception.values` for errors that are nested on properties based on the `key` parameter.
 */
export function applyAggregateErrorsToEvent(
 exceptionFromErrorImplementation: (stackParser: StackParser, ex: Error) => Exception,
 parser: StackParser,
 maxValueLimit: number = 250,
 key: string,
 limit: number,
 event: Event,
Expand All@@ -25,18 +23,15 @@ export function applyAggregateErrorsToEvent(

 // We only create exception grouping if there is an exception in the event.
 if (originalException) {
 event.exception.values = truncateAggregateExceptions(
 aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 ),
 maxValueLimit,
 event.exception.values = aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 );
 }
}
Expand DownExpand Up@@ -129,17 +124,3 @@ function applyExceptionGroupFieldsForChildException(
 parent_id: parentId,
 };
}

/**
 * Truncate the message (exception.value) of all exceptions in the event.
 * Because this event processor is ran after `applyClientOptions`,
 * we need to truncate the message of the added exceptions here.
 */
function truncateAggregateExceptions(exceptions: Exception[], maxValueLength: number): Exception[] {
 return exceptions.map(exception => {
 if (exception.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }
 return exception;
 });
}

9 changes: 0 additions & 9 deletions
packages/core/src/utils/prepareEvent.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,15 +144,6 @@ export function applyClientOptions(event: Event, options: ClientOptions): void {
 event.dist = dist;
 }

 if (event.message) {
 event.message = truncate(event.message, maxValueLength);
 }

 const exception = event.exception?.values?.[0];
 if (exception?.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }

 const request = event.request;
 if (request?.url) {
 request.url = truncate(request.url, maxValueLength);
Expand Down

69 changes: 10 additions & 59 deletions
packages/core/test/utils-hoist/aggregate-errors.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain an exception', () => {
 const event: Event = { exception: undefined };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: undefined });
Expand All@@ -30,15 +30,15 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain exception values', () => {
 const event: Event = { exception: { values: undefined } };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: undefined } });
 });

 test('should not do anything if event does not contain an event hint', () => {
 const event: Event = { exception: { values: [] } };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, undefined);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, undefined);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -47,7 +47,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if the event hint does not contain an original exception', () => {
 const event: Event = { exception: { values: [] } };
 const eventHint: EventHint = { originalException: undefined };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -62,7 +62,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -108,7 +108,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [exceptionFromError(stackParser, originalException)] } });
Expand All@@ -127,7 +127,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 }

 const eventHint: EventHint = { originalException };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 5, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 5, event, eventHint);

 // 6 -> one for original exception + 5 linked
 expect(event.exception?.values).toHaveLength(5 + 1);
Expand All@@ -153,7 +153,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event.exception?.values?.[event.exception.values.length - 1]?.mechanism?.type).toBe('instrument');
 });

Expand All@@ -170,7 +170,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError1)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError1 };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -254,7 +254,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -293,53 +293,4 @@ describe('applyAggregateErrorsToEvent()', () => {
 },
 });
 });

 test('should truncate the exception values if they exceed the `maxValueLength` option', () => {
 const originalException: ExtendedError = new Error('Root Error with long message');
 originalException.cause = new Error('Nested Error 1 with longer message');
 originalException.cause.cause = new Error('Nested Error 2 with longer message with longer message');

 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 const maxValueLength = 15;
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, maxValueLength, 'cause', 10, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
 {
 type: 'Error',
 value: 'Nested Error 2 ...',
 mechanism: {
 exception_id: 2,
 handled: true,
 parent_id: 1,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Nested Error 1 ...',
 mechanism: {
 exception_id: 1,
 handled: true,
 parent_id: 0,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Root Error with...',
 mechanism: {
 exception_id: 0,
 handled: true,
 type: 'instrument',
 },
 },
 ],
 },
 });
 });
});

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: Don't truncate error messages#15818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

lforst
merged 4 commits into

from

Mar 31, 2025
 Merged


feat: Don't truncate error messages
#15818
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


4 commits


Select commit
Hold shift + click to select a range
1273c20

feat: Don't truncate error messages

Mar 25, 2025
e8be995

Merge branch 'develop' into lforst-truncation-logic

Mar 26, 2025
40dd4fb

Fix some tests

Mar 27, 2025
f6b4763

.

Mar 27, 2025

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


20 changes: 10 additions & 10 deletions
...ages/browser-integration-tests/suites/public-api/captureException/linkedErrors/subject.js

View file


Open in desktop

@Lms24Lms24Mar 31, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't resist
image
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
const wat = new Error(`This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be`);
const wat = new Error(`This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`);

wat.cause = new Error(`This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,`);
wat.cause = new Error(`This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`);

Sentry.captureException(wat);

18 changes: 10 additions & 8 deletions
...ackages/browser-integration-tests/suites/public-api/captureException/linkedErrors/test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,10 +12,11 @@ sentryTest('should capture a linked error with messages', async ({ getLocalTestU
 expect(eventData.exception?.values).toHaveLength(2);
 expect(eventData.exception?.values?.[0]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long message that should be truncated and hopefully will be,
this is a very long me...`,
 value: `This is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be,
this is a very long message that should not be truncated and hopefully won't be`,
 mechanism: {
 type: 'chained',
 handled: true,
Expand All@@ -26,10 +27,11 @@ this is a very long me...`,
 });
 expect(eventData.exception?.values?.[1]).toMatchObject({
 type: 'Error',
 value: `This is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated and will be,
this is a very long message that should be truncated...`,
 value: `This is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be,
this is a very long message that should not be truncated and won't be`,
 mechanism: {
 type: 'generic',
 handled: true,
Expand Down

9 changes: 0 additions & 9 deletions
...sts/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/subject.js

View file


Open in desktop


This file was deleted.


22 changes: 0 additions & 22 deletions
...-tests/suites/public-api/instrumentation/onUnhandledRejection/thrown-string-large/test.ts

View file


Open in desktop


This file was deleted.


1 change: 0 additions & 1 deletion
packages/browser/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 // This differs from the LinkedErrors integration in core by using a different exceptionFromError function
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
Expand Down

10 changes: 1 addition & 9 deletions
packages/core/src/integrations/linkederrors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,15 +22,7 @@ const _linkedErrorsIntegration = ((options: LinkedErrorsOptions = {}) => {
 preprocessEvent(event, hint, client) {
 const options = client.getOptions();

 applyAggregateErrorsToEvent(
 exceptionFromError,
 options.stackParser,
 options.maxValueLength,
 key,
 limit,
 event,
 hint,
 );
 applyAggregateErrorsToEvent(exceptionFromError, options.stackParser, key, limit, event, hint);
 },
 };
}) satisfies IntegrationFn;
Expand Down

37 changes: 9 additions & 28 deletions
packages/core/src/utils-hoist/aggregate-errors.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
import type { Event, EventHint, Exception, ExtendedError, StackParser } from '../types-hoist';

import { isInstanceOf } from './is';
import { truncate } from './string';

/**
 * Creates exceptions inside `event.exception.values` for errors that are nested on properties based on the `key` parameter.
 */
export function applyAggregateErrorsToEvent(
 exceptionFromErrorImplementation: (stackParser: StackParser, ex: Error) => Exception,
 parser: StackParser,
 maxValueLimit: number = 250,
 key: string,
 limit: number,
 event: Event,
Expand All@@ -25,18 +23,15 @@ export function applyAggregateErrorsToEvent(

 // We only create exception grouping if there is an exception in the event.
 if (originalException) {
 event.exception.values = truncateAggregateExceptions(
 aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 ),
 maxValueLimit,
 event.exception.values = aggregateExceptionsFromError(
 exceptionFromErrorImplementation,
 parser,
 limit,
 hint.originalException as ExtendedError,
 key,
 event.exception.values,
 originalException,
 0,
 );
 }
}
Expand DownExpand Up@@ -129,17 +124,3 @@ function applyExceptionGroupFieldsForChildException(
 parent_id: parentId,
 };
}

/**
 * Truncate the message (exception.value) of all exceptions in the event.
 * Because this event processor is ran after `applyClientOptions`,
 * we need to truncate the message of the added exceptions here.
 */
function truncateAggregateExceptions(exceptions: Exception[], maxValueLength: number): Exception[] {
 return exceptions.map(exception => {
 if (exception.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }
 return exception;
 });
}

9 changes: 0 additions & 9 deletions
packages/core/src/utils/prepareEvent.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -144,15 +144,6 @@ export function applyClientOptions(event: Event, options: ClientOptions): void {
 event.dist = dist;
 }

 if (event.message) {
 event.message = truncate(event.message, maxValueLength);
 }

 const exception = event.exception?.values?.[0];
 if (exception?.value) {
 exception.value = truncate(exception.value, maxValueLength);
 }

 const request = event.request;
 if (request?.url) {
 request.url = truncate(request.url, maxValueLength);
Expand Down

69 changes: 10 additions & 59 deletions
packages/core/test/utils-hoist/aggregate-errors.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,7 +21,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain an exception', () => {
 const event: Event = { exception: undefined };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: undefined });
Expand All@@ -30,15 +30,15 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if event does not contain exception values', () => {
 const event: Event = { exception: { values: undefined } };
 const eventHint: EventHint = { originalException: new Error() };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: undefined } });
 });

 test('should not do anything if event does not contain an event hint', () => {
 const event: Event = { exception: { values: [] } };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, undefined);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, undefined);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -47,7 +47,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 test('should not do anything if the event hint does not contain an original exception', () => {
 const event: Event = { exception: { values: [] } };
 const eventHint: EventHint = { originalException: undefined };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [] } });
Expand All@@ -62,7 +62,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -108,7 +108,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);

 // no changes
 expect(event).toStrictEqual({ exception: { values: [exceptionFromError(stackParser, originalException)] } });
Expand All@@ -127,7 +127,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 }

 const eventHint: EventHint = { originalException };
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 5, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 5, event, eventHint);

 // 6 -> one for original exception + 5 linked
 expect(event.exception?.values).toHaveLength(5 + 1);
Expand All@@ -153,7 +153,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event.exception?.values?.[event.exception.values.length - 1]?.mechanism?.type).toBe('instrument');
 });

Expand All@@ -170,7 +170,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, fakeAggregateError1)] } };
 const eventHint: EventHint = { originalException: fakeAggregateError1 };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, 'cause', 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, 'cause', 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -254,7 +254,7 @@ describe('applyAggregateErrorsToEvent()', () => {
 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 applyAggregateErrorsToEvent(exceptionFromError, stackParser, undefined, key, 100, event, eventHint);
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, key, 100, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
Expand DownExpand Up@@ -293,53 +293,4 @@ describe('applyAggregateErrorsToEvent()', () => {
 },
 });
 });

 test('should truncate the exception values if they exceed the `maxValueLength` option', () => {
 const originalException: ExtendedError = new Error('Root Error with long message');
 originalException.cause = new Error('Nested Error 1 with longer message');
 originalException.cause.cause = new Error('Nested Error 2 with longer message with longer message');

 const event: Event = { exception: { values: [exceptionFromError(stackParser, originalException)] } };
 const eventHint: EventHint = { originalException };

 const maxValueLength = 15;
 applyAggregateErrorsToEvent(exceptionFromError, stackParser, maxValueLength, 'cause', 10, event, eventHint);
 expect(event).toStrictEqual({
 exception: {
 values: [
 {
 type: 'Error',
 value: 'Nested Error 2 ...',
 mechanism: {
 exception_id: 2,
 handled: true,
 parent_id: 1,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Nested Error 1 ...',
 mechanism: {
 exception_id: 1,
 handled: true,
 parent_id: 0,
 source: 'cause',
 type: 'chained',
 },
 },
 {
 type: 'Error',
 value: 'Root Error with...',
 mechanism: {
 exception_id: 0,
 handled: true,
 type: 'instrument',
 },
 },
 ],
 },
 });
 });
});