feat(node): Add ignoreIncomingRequestBody callback to httpIntegration - #15959

Merged
Lms24 merged 2 commits into
getsentry:developfrom
Page-:ignore-incoming-request-body
Apr 4, 2025
Merged

feat(node): Add ignoreIncomingRequestBody callback to httpIntegration#15959
Lms24 merged 2 commits into
getsentry:developfrom
Page-:ignore-incoming-request-body

Conversation

@Page-

@Page-Page- commented Apr 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This allows ignoring the request body for certain requests, which is very useful in situations of long-running requests with large/streaming request bodies which can result in a lot of memory usage

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

@Page-
Page-force-pushed the ignore-incoming-request-body branch from 99aa097 to b10a5e8CompareApril 2, 2025 15:30
Lms24
Lms24 reviewed Apr 3, 2025
View reviewed changes

@Lms24Lms24 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Page-, thanks for opening this PR! The proposal sounds reasonable to me. I'll also tag @mydea for input. Let me know if you have questions or need assistance to get this ready for review :)

By the way, if there's an issue for this, please link it in the PR description, thanks!

@Lms24
Lms24 requested a review from mydeaApril 3, 2025 08:24
@Page-

Page- commented Apr 3, 2025

Copy link
Copy Markdown
ContributorAuthor

@Lms24 the main reason I still have it as draft is to be able to check the build/lint/tests on a linux VM as windows isn't supported. I was able to build/run just the specific parts I changed whilst on windows but that was with heavy modification and hence wanting to double check in an environment with just the feature change and not the workarounds.

There isn't an issue associated with this (as far as I know) but I can create one to link to if you want?

@Page-
feat(node): Add ignoreIncomingRequestBody to avoid capturing reques…
46f6503
…t bodies
This allows ignoring the request body for certain requests, which is
very useful in situations of long-running requests with large/streaming
request bodies which can result in a lot of memory usage
@Page-
Page-force-pushed the ignore-incoming-request-body branch from b10a5e8 to 46f6503CompareApril 3, 2025 15:22
@Page-
Page- marked this pull request as ready for review April 3, 2025 15:23
@Page-
Page- requested a review from Lms24April 3, 2025 18:40
Lms24
Lms24 approved these changes Apr 4, 2025
View reviewed changes

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for getting back to me!

Usually it'd be best to start off with an issue (after which we'd still gladly accept a PR of course 😅). Since the PR is already here, no need for it now.

This change looks good to me so I'll approve it. Still waiting on comments from other team members before merging it.

@Lms24

Lms24 commented Apr 4, 2025

Copy link
Copy Markdown
Member

I just made one more change to also add the new option to the HttpOptions of httpIntegration. This is easy to miss because onfortunately we have an unknown in the type chain that makes TS not complain about the missing property when we initialize the SentryHttpInstrumentation.

Talked to the team and everyone is fine with the change. So I'm gonna merge it. Thanks for contributing!

@Lms24
Lms24 merged commit c6261f7 into getsentry:developApr 4, 2025
@Lms24Lms24 changed the title feat(node): Add ignoreIncomingRequestBody to avoid capturing request bodiesfeat(node): Add ignoreIncomingRequestBody callback to httpIntegrationApr 4, 2025
@HazATHazAT mentioned this pull request Apr 4, 2025
Merged
@Page-

Page- commented Apr 4, 2025

Copy link
Copy Markdown
ContributorAuthor

Awesome, thanks for the quick response @Lms24. And I agree on the issue, it was just a case that by the time I tracked down the memory usage I was already in the place to fix it :)

Lms24 added a commit that referenced this pull request Apr 4, 2025
@HazAT@Lms24
chore: Add external contributor to CHANGELOG.md (#15984)
67f4919
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15959
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@s1gr1ds1gr1d mentioned this pull request Apr 29, 2025
Closed
@s1gr1ds1gr1d mentioned this pull request May 14, 2025
Merged
6 tasks
s1gr1d added a commit to getsentry/sentry-docs that referenced this pull request May 20, 2025
@s1gr1d
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
8df2fe1
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
bitsandfoxes pushed a commit to getsentry/sentry-docs that referenced this pull request Jul 3, 2025
@s1gr1d@bitsandfoxes
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
79f78ec
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeaAwaiting requested review from mydea

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Page-@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration - #15959
Merged
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Apr 4, 2025
Merged
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration#15959
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Conversation
@Page-
@Page-Page-
commented
Apr 2, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
This allows ignoring the request body for certain requests, which is very useful in situations of long-running requests with large/streaming request bodies which can result in a lot of memory usage
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
  •  If you've added code that should be tested, please add tests.
  •  Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
99aa097 to
b10a5e8CompareApril 2, 2025 15:30
Lms24
Lms24
reviewed
Apr 3, 2025
View reviewed changes
@Lms24Lms24
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Page-, thanks for opening this PR! The proposal sounds reasonable to me. I'll also tag @mydea for input. Let me know if you have questions or need assistance to get this ready for review :)
By the way, if there's an issue for this, please link it in the PR description, thanks!
@Lms24
Lms24
requested a review
from mydeaApril 3, 2025 08:24
@Page-
Page-
commented
Apr 3, 2025

Copy link


Copy Markdown

ContributorAuthor
@Lms24 the main reason I still have it as draft is to be able to check the build/lint/tests on a linux VM as windows isn't supported. I was able to build/run just the specific parts I changed whilst on windows but that was with heavy modification and hence wanting to double check in an environment with just the feature change and not the workarounds.
There isn't an issue associated with this (as far as I know) but I can create one to link to if you want?
@Page-
feat(node): Add ignoreIncomingRequestBody to avoid capturing reques…
46f6503
…t bodies
This allows ignoring the request body for certain requests, which is
very useful in situations of long-running requests with large/streaming
request bodies which can result in a lot of memory usage
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
b10a5e8 to
46f6503CompareApril 3, 2025 15:22
@Page-
Page-
marked this pull request as ready for review
April 3, 2025 15:23
@Page-
Page-
requested a review
from Lms24April 3, 2025 18:40
Lms24
Lms24
approved these changes
Apr 4, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for getting back to me!
Usually it'd be best to start off with an issue (after which we'd still gladly accept a PR of course 😅). Since the PR is already here, no need for it now.
This change looks good to me so I'll approve it. Still waiting on comments from other team members before merging it.
@Lms24
Lms24
commented
Apr 4, 2025

Copy link


Copy Markdown

Member
I just made one more change to also add the new option to the HttpOptions of httpIntegration. This is easy to miss because onfortunately we have an unknown in the type chain that makes TS not complain about the missing property when we initialize the SentryHttpInstrumentation.
Talked to the team and everyone is fine with the change. So I'm gonna merge it. Thanks for contributing!
@Lms24
Lms24
merged commit c6261f7
into
getsentry:developApr 4, 2025
@Lms24Lms24
changed the title
feat(node): Add ignoreIncomingRequestBody to avoid capturing request bodiesfeat(node): Add ignoreIncomingRequestBody callback to httpIntegrationApr 4, 2025
@HazATHazAT
mentioned this pull request
Apr 4, 2025
 Merged

@Page-
Page-
commented
Apr 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Awesome, thanks for the quick response @Lms24. And I agree on the issue, it was just a case that by the time I tracked down the memory usage I was already in the place to fix it :)
Lms24 added a commit
that referenced
this pull request
Apr 4, 2025
@HazAT@Lms24
chore: Add external contributor to CHANGELOG.md (#15984)
67f4919
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15959
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@s1gr1ds1gr1d
mentioned this pull request
Apr 29, 2025

Closed

@s1gr1ds1gr1d
mentioned this pull request
May 14, 2025
 Merged

6 tasks
s1gr1d added a commit
to getsentry/sentry-docs
that referenced
this pull request
May 20, 2025
@s1gr1d
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
8df2fe1
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@s1gr1d@bitsandfoxes
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
79f78ec
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeaAwaiting requested review from mydea

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Page-@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration - #15959
Merged
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Apr 4, 2025
Merged
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration#15959
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Conversation
@Page-
@Page-Page-
commented
Apr 2, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
This allows ignoring the request body for certain requests, which is very useful in situations of long-running requests with large/streaming request bodies which can result in a lot of memory usage
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
  •  If you've added code that should be tested, please add tests.
  •  Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
99aa097 to
b10a5e8CompareApril 2, 2025 15:30
Lms24
Lms24
reviewed
Apr 3, 2025
View reviewed changes
@Lms24Lms24
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Page-, thanks for opening this PR! The proposal sounds reasonable to me. I'll also tag @mydea for input. Let me know if you have questions or need assistance to get this ready for review :)
By the way, if there's an issue for this, please link it in the PR description, thanks!
@Lms24
Lms24
requested a review
from mydeaApril 3, 2025 08:24
@Page-
Page-
commented
Apr 3, 2025

Copy link


Copy Markdown

ContributorAuthor
@Lms24 the main reason I still have it as draft is to be able to check the build/lint/tests on a linux VM as windows isn't supported. I was able to build/run just the specific parts I changed whilst on windows but that was with heavy modification and hence wanting to double check in an environment with just the feature change and not the workarounds.
There isn't an issue associated with this (as far as I know) but I can create one to link to if you want?
@Page-
feat(node): Add ignoreIncomingRequestBody to avoid capturing reques…
46f6503
…t bodies
This allows ignoring the request body for certain requests, which is
very useful in situations of long-running requests with large/streaming
request bodies which can result in a lot of memory usage
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
b10a5e8 to
46f6503CompareApril 3, 2025 15:22
@Page-
Page-
marked this pull request as ready for review
April 3, 2025 15:23
@Page-
Page-
requested a review
from Lms24April 3, 2025 18:40
Lms24
Lms24
approved these changes
Apr 4, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for getting back to me!
Usually it'd be best to start off with an issue (after which we'd still gladly accept a PR of course 😅). Since the PR is already here, no need for it now.
This change looks good to me so I'll approve it. Still waiting on comments from other team members before merging it.
@Lms24
Lms24
commented
Apr 4, 2025

Copy link


Copy Markdown

Member
I just made one more change to also add the new option to the HttpOptions of httpIntegration. This is easy to miss because onfortunately we have an unknown in the type chain that makes TS not complain about the missing property when we initialize the SentryHttpInstrumentation.
Talked to the team and everyone is fine with the change. So I'm gonna merge it. Thanks for contributing!
@Lms24
Lms24
merged commit c6261f7
into
getsentry:developApr 4, 2025
@Lms24Lms24
changed the title
feat(node): Add ignoreIncomingRequestBody to avoid capturing request bodiesfeat(node): Add ignoreIncomingRequestBody callback to httpIntegrationApr 4, 2025
@HazATHazAT
mentioned this pull request
Apr 4, 2025
 Merged

@Page-
Page-
commented
Apr 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Awesome, thanks for the quick response @Lms24. And I agree on the issue, it was just a case that by the time I tracked down the memory usage I was already in the place to fix it :)
Lms24 added a commit
that referenced
this pull request
Apr 4, 2025
@HazAT@Lms24
chore: Add external contributor to CHANGELOG.md (#15984)
67f4919
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15959
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@s1gr1ds1gr1d
mentioned this pull request
Apr 29, 2025

Closed

@s1gr1ds1gr1d
mentioned this pull request
May 14, 2025
 Merged

6 tasks
s1gr1d added a commit
to getsentry/sentry-docs
that referenced
this pull request
May 20, 2025
@s1gr1d
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
8df2fe1
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@s1gr1d@bitsandfoxes
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
79f78ec
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeaAwaiting requested review from mydea

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Page-@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration - #15959
Merged
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Apr 4, 2025
Merged
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration#15959
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Conversation
@Page-
@Page-Page-
commented
Apr 2, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
This allows ignoring the request body for certain requests, which is very useful in situations of long-running requests with large/streaming request bodies which can result in a lot of memory usage
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
  •  If you've added code that should be tested, please add tests.
  •  Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
99aa097 to
b10a5e8CompareApril 2, 2025 15:30
Lms24
Lms24
reviewed
Apr 3, 2025
View reviewed changes
@Lms24Lms24
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Page-, thanks for opening this PR! The proposal sounds reasonable to me. I'll also tag @mydea for input. Let me know if you have questions or need assistance to get this ready for review :)
By the way, if there's an issue for this, please link it in the PR description, thanks!
@Lms24
Lms24
requested a review
from mydeaApril 3, 2025 08:24
@Page-
Page-
commented
Apr 3, 2025

Copy link


Copy Markdown

ContributorAuthor
@Lms24 the main reason I still have it as draft is to be able to check the build/lint/tests on a linux VM as windows isn't supported. I was able to build/run just the specific parts I changed whilst on windows but that was with heavy modification and hence wanting to double check in an environment with just the feature change and not the workarounds.
There isn't an issue associated with this (as far as I know) but I can create one to link to if you want?
@Page-
feat(node): Add ignoreIncomingRequestBody to avoid capturing reques…
46f6503
…t bodies
This allows ignoring the request body for certain requests, which is
very useful in situations of long-running requests with large/streaming
request bodies which can result in a lot of memory usage
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
b10a5e8 to
46f6503CompareApril 3, 2025 15:22
@Page-
Page-
marked this pull request as ready for review
April 3, 2025 15:23
@Page-
Page-
requested a review
from Lms24April 3, 2025 18:40
Lms24
Lms24
approved these changes
Apr 4, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for getting back to me!
Usually it'd be best to start off with an issue (after which we'd still gladly accept a PR of course 😅). Since the PR is already here, no need for it now.
This change looks good to me so I'll approve it. Still waiting on comments from other team members before merging it.
@Lms24
Lms24
commented
Apr 4, 2025

Copy link


Copy Markdown

Member
I just made one more change to also add the new option to the HttpOptions of httpIntegration. This is easy to miss because onfortunately we have an unknown in the type chain that makes TS not complain about the missing property when we initialize the SentryHttpInstrumentation.
Talked to the team and everyone is fine with the change. So I'm gonna merge it. Thanks for contributing!
@Lms24
Lms24
merged commit c6261f7
into
getsentry:developApr 4, 2025
@Lms24Lms24
changed the title
feat(node): Add ignoreIncomingRequestBody to avoid capturing request bodiesfeat(node): Add ignoreIncomingRequestBody callback to httpIntegrationApr 4, 2025
@HazATHazAT
mentioned this pull request
Apr 4, 2025
 Merged

@Page-
Page-
commented
Apr 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Awesome, thanks for the quick response @Lms24. And I agree on the issue, it was just a case that by the time I tracked down the memory usage I was already in the place to fix it :)
Lms24 added a commit
that referenced
this pull request
Apr 4, 2025
@HazAT@Lms24
chore: Add external contributor to CHANGELOG.md (#15984)
67f4919
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15959
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@s1gr1ds1gr1d
mentioned this pull request
Apr 29, 2025

Closed

@s1gr1ds1gr1d
mentioned this pull request
May 14, 2025
 Merged

6 tasks
s1gr1d added a commit
to getsentry/sentry-docs
that referenced
this pull request
May 20, 2025
@s1gr1d
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
8df2fe1
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@s1gr1d@bitsandfoxes
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
79f78ec
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeaAwaiting requested review from mydea

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Page-@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration - #15959
Merged
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Apr 4, 2025
Merged
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration#15959
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Conversation
@Page-
@Page-Page-
commented
Apr 2, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
This allows ignoring the request body for certain requests, which is very useful in situations of long-running requests with large/streaming request bodies which can result in a lot of memory usage
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
  •  If you've added code that should be tested, please add tests.
  •  Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
99aa097 to
b10a5e8CompareApril 2, 2025 15:30
Lms24
Lms24
reviewed
Apr 3, 2025
View reviewed changes
@Lms24Lms24
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Page-, thanks for opening this PR! The proposal sounds reasonable to me. I'll also tag @mydea for input. Let me know if you have questions or need assistance to get this ready for review :)
By the way, if there's an issue for this, please link it in the PR description, thanks!
@Lms24
Lms24
requested a review
from mydeaApril 3, 2025 08:24
@Page-
Page-
commented
Apr 3, 2025

Copy link


Copy Markdown

ContributorAuthor
@Lms24 the main reason I still have it as draft is to be able to check the build/lint/tests on a linux VM as windows isn't supported. I was able to build/run just the specific parts I changed whilst on windows but that was with heavy modification and hence wanting to double check in an environment with just the feature change and not the workarounds.
There isn't an issue associated with this (as far as I know) but I can create one to link to if you want?
@Page-
feat(node): Add ignoreIncomingRequestBody to avoid capturing reques…
46f6503
…t bodies
This allows ignoring the request body for certain requests, which is
very useful in situations of long-running requests with large/streaming
request bodies which can result in a lot of memory usage
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
b10a5e8 to
46f6503CompareApril 3, 2025 15:22
@Page-
Page-
marked this pull request as ready for review
April 3, 2025 15:23
@Page-
Page-
requested a review
from Lms24April 3, 2025 18:40
Lms24
Lms24
approved these changes
Apr 4, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for getting back to me!
Usually it'd be best to start off with an issue (after which we'd still gladly accept a PR of course 😅). Since the PR is already here, no need for it now.
This change looks good to me so I'll approve it. Still waiting on comments from other team members before merging it.
@Lms24
Lms24
commented
Apr 4, 2025

Copy link


Copy Markdown

Member
I just made one more change to also add the new option to the HttpOptions of httpIntegration. This is easy to miss because onfortunately we have an unknown in the type chain that makes TS not complain about the missing property when we initialize the SentryHttpInstrumentation.
Talked to the team and everyone is fine with the change. So I'm gonna merge it. Thanks for contributing!
@Lms24
Lms24
merged commit c6261f7
into
getsentry:developApr 4, 2025
@Lms24Lms24
changed the title
feat(node): Add ignoreIncomingRequestBody to avoid capturing request bodiesfeat(node): Add ignoreIncomingRequestBody callback to httpIntegrationApr 4, 2025
@HazATHazAT
mentioned this pull request
Apr 4, 2025
 Merged

@Page-
Page-
commented
Apr 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Awesome, thanks for the quick response @Lms24. And I agree on the issue, it was just a case that by the time I tracked down the memory usage I was already in the place to fix it :)
Lms24 added a commit
that referenced
this pull request
Apr 4, 2025
@HazAT@Lms24
chore: Add external contributor to CHANGELOG.md (#15984)
67f4919
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15959
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@s1gr1ds1gr1d
mentioned this pull request
Apr 29, 2025

Closed

@s1gr1ds1gr1d
mentioned this pull request
May 14, 2025
 Merged

6 tasks
s1gr1d added a commit
to getsentry/sentry-docs
that referenced
this pull request
May 20, 2025
@s1gr1d
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
8df2fe1
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@s1gr1d@bitsandfoxes
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
79f78ec
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeaAwaiting requested review from mydea

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Page-@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration - #15959
Merged
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Apr 4, 2025
Merged
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration#15959
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Conversation
@Page-
@Page-Page-
commented
Apr 2, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
This allows ignoring the request body for certain requests, which is very useful in situations of long-running requests with large/streaming request bodies which can result in a lot of memory usage
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
  •  If you've added code that should be tested, please add tests.
  •  Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
99aa097 to
b10a5e8CompareApril 2, 2025 15:30
Lms24
Lms24
reviewed
Apr 3, 2025
View reviewed changes
@Lms24Lms24
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Page-, thanks for opening this PR! The proposal sounds reasonable to me. I'll also tag @mydea for input. Let me know if you have questions or need assistance to get this ready for review :)
By the way, if there's an issue for this, please link it in the PR description, thanks!
@Lms24
Lms24
requested a review
from mydeaApril 3, 2025 08:24
@Page-
Page-
commented
Apr 3, 2025

Copy link


Copy Markdown

ContributorAuthor
@Lms24 the main reason I still have it as draft is to be able to check the build/lint/tests on a linux VM as windows isn't supported. I was able to build/run just the specific parts I changed whilst on windows but that was with heavy modification and hence wanting to double check in an environment with just the feature change and not the workarounds.
There isn't an issue associated with this (as far as I know) but I can create one to link to if you want?
@Page-
feat(node): Add ignoreIncomingRequestBody to avoid capturing reques…
46f6503
…t bodies
This allows ignoring the request body for certain requests, which is
very useful in situations of long-running requests with large/streaming
request bodies which can result in a lot of memory usage
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
b10a5e8 to
46f6503CompareApril 3, 2025 15:22
@Page-
Page-
marked this pull request as ready for review
April 3, 2025 15:23
@Page-
Page-
requested a review
from Lms24April 3, 2025 18:40
Lms24
Lms24
approved these changes
Apr 4, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for getting back to me!
Usually it'd be best to start off with an issue (after which we'd still gladly accept a PR of course 😅). Since the PR is already here, no need for it now.
This change looks good to me so I'll approve it. Still waiting on comments from other team members before merging it.
@Lms24
Lms24
commented
Apr 4, 2025

Copy link


Copy Markdown

Member
I just made one more change to also add the new option to the HttpOptions of httpIntegration. This is easy to miss because onfortunately we have an unknown in the type chain that makes TS not complain about the missing property when we initialize the SentryHttpInstrumentation.
Talked to the team and everyone is fine with the change. So I'm gonna merge it. Thanks for contributing!
@Lms24
Lms24
merged commit c6261f7
into
getsentry:developApr 4, 2025
@Lms24Lms24
changed the title
feat(node): Add ignoreIncomingRequestBody to avoid capturing request bodiesfeat(node): Add ignoreIncomingRequestBody callback to httpIntegrationApr 4, 2025
@HazATHazAT
mentioned this pull request
Apr 4, 2025
 Merged

@Page-
Page-
commented
Apr 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Awesome, thanks for the quick response @Lms24. And I agree on the issue, it was just a case that by the time I tracked down the memory usage I was already in the place to fix it :)
Lms24 added a commit
that referenced
this pull request
Apr 4, 2025
@HazAT@Lms24
chore: Add external contributor to CHANGELOG.md (#15984)
67f4919
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15959
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@s1gr1ds1gr1d
mentioned this pull request
Apr 29, 2025

Closed

@s1gr1ds1gr1d
mentioned this pull request
May 14, 2025
 Merged

6 tasks
s1gr1d added a commit
to getsentry/sentry-docs
that referenced
this pull request
May 20, 2025
@s1gr1d
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
8df2fe1
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@s1gr1d@bitsandfoxes
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
79f78ec
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeaAwaiting requested review from mydea

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Page-@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration - #15959
Merged
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Apr 4, 2025
Merged
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration#15959
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Conversation
@Page-
@Page-Page-
commented
Apr 2, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
This allows ignoring the request body for certain requests, which is very useful in situations of long-running requests with large/streaming request bodies which can result in a lot of memory usage
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
  •  If you've added code that should be tested, please add tests.
  •  Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
99aa097 to
b10a5e8CompareApril 2, 2025 15:30
Lms24
Lms24
reviewed
Apr 3, 2025
View reviewed changes
@Lms24Lms24
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Page-, thanks for opening this PR! The proposal sounds reasonable to me. I'll also tag @mydea for input. Let me know if you have questions or need assistance to get this ready for review :)
By the way, if there's an issue for this, please link it in the PR description, thanks!
@Lms24
Lms24
requested a review
from mydeaApril 3, 2025 08:24
@Page-
Page-
commented
Apr 3, 2025

Copy link


Copy Markdown

ContributorAuthor
@Lms24 the main reason I still have it as draft is to be able to check the build/lint/tests on a linux VM as windows isn't supported. I was able to build/run just the specific parts I changed whilst on windows but that was with heavy modification and hence wanting to double check in an environment with just the feature change and not the workarounds.
There isn't an issue associated with this (as far as I know) but I can create one to link to if you want?
@Page-
feat(node): Add ignoreIncomingRequestBody to avoid capturing reques…
46f6503
…t bodies
This allows ignoring the request body for certain requests, which is
very useful in situations of long-running requests with large/streaming
request bodies which can result in a lot of memory usage
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
b10a5e8 to
46f6503CompareApril 3, 2025 15:22
@Page-
Page-
marked this pull request as ready for review
April 3, 2025 15:23
@Page-
Page-
requested a review
from Lms24April 3, 2025 18:40
Lms24
Lms24
approved these changes
Apr 4, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for getting back to me!
Usually it'd be best to start off with an issue (after which we'd still gladly accept a PR of course 😅). Since the PR is already here, no need for it now.
This change looks good to me so I'll approve it. Still waiting on comments from other team members before merging it.
@Lms24
Lms24
commented
Apr 4, 2025

Copy link


Copy Markdown

Member
I just made one more change to also add the new option to the HttpOptions of httpIntegration. This is easy to miss because onfortunately we have an unknown in the type chain that makes TS not complain about the missing property when we initialize the SentryHttpInstrumentation.
Talked to the team and everyone is fine with the change. So I'm gonna merge it. Thanks for contributing!
@Lms24
Lms24
merged commit c6261f7
into
getsentry:developApr 4, 2025
@Lms24Lms24
changed the title
feat(node): Add ignoreIncomingRequestBody to avoid capturing request bodiesfeat(node): Add ignoreIncomingRequestBody callback to httpIntegrationApr 4, 2025
@HazATHazAT
mentioned this pull request
Apr 4, 2025
 Merged

@Page-
Page-
commented
Apr 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Awesome, thanks for the quick response @Lms24. And I agree on the issue, it was just a case that by the time I tracked down the memory usage I was already in the place to fix it :)
Lms24 added a commit
that referenced
this pull request
Apr 4, 2025
@HazAT@Lms24
chore: Add external contributor to CHANGELOG.md (#15984)
67f4919
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15959
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@s1gr1ds1gr1d
mentioned this pull request
Apr 29, 2025

Closed

@s1gr1ds1gr1d
mentioned this pull request
May 14, 2025
 Merged

6 tasks
s1gr1d added a commit
to getsentry/sentry-docs
that referenced
this pull request
May 20, 2025
@s1gr1d
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
8df2fe1
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@s1gr1d@bitsandfoxes
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
79f78ec
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeaAwaiting requested review from mydea

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Page-@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration - #15959
Merged
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Apr 4, 2025
Merged
feat(node): Add ignoreIncomingRequestBody callback to httpIntegration#15959
Lms24 merged 2 commits into
getsentry:developfrom 
Page-:ignore-incoming-request-body
Conversation
@Page-
@Page-Page-
commented
Apr 2, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
This allows ignoring the request body for certain requests, which is very useful in situations of long-running requests with large/streaming request bodies which can result in a lot of memory usage
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
  •  If you've added code that should be tested, please add tests.
  •  Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
99aa097 to
b10a5e8CompareApril 2, 2025 15:30
Lms24
Lms24
reviewed
Apr 3, 2025
View reviewed changes
@Lms24Lms24
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Page-, thanks for opening this PR! The proposal sounds reasonable to me. I'll also tag @mydea for input. Let me know if you have questions or need assistance to get this ready for review :)
By the way, if there's an issue for this, please link it in the PR description, thanks!
@Lms24
Lms24
requested a review
from mydeaApril 3, 2025 08:24
@Page-
Page-
commented
Apr 3, 2025

Copy link


Copy Markdown

ContributorAuthor
@Lms24 the main reason I still have it as draft is to be able to check the build/lint/tests on a linux VM as windows isn't supported. I was able to build/run just the specific parts I changed whilst on windows but that was with heavy modification and hence wanting to double check in an environment with just the feature change and not the workarounds.
There isn't an issue associated with this (as far as I know) but I can create one to link to if you want?
@Page-
feat(node): Add ignoreIncomingRequestBody to avoid capturing reques…
46f6503
…t bodies
This allows ignoring the request body for certain requests, which is
very useful in situations of long-running requests with large/streaming
request bodies which can result in a lot of memory usage
@Page-
Page-force-pushed
the
ignore-incoming-request-body
branch
from
b10a5e8 to
46f6503CompareApril 3, 2025 15:22
@Page-
Page-
marked this pull request as ready for review
April 3, 2025 15:23
@Page-
Page-
requested a review
from Lms24April 3, 2025 18:40
Lms24
Lms24
approved these changes
Apr 4, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for getting back to me!
Usually it'd be best to start off with an issue (after which we'd still gladly accept a PR of course 😅). Since the PR is already here, no need for it now.
This change looks good to me so I'll approve it. Still waiting on comments from other team members before merging it.
@Lms24
Lms24
commented
Apr 4, 2025

Copy link


Copy Markdown

Member
I just made one more change to also add the new option to the HttpOptions of httpIntegration. This is easy to miss because onfortunately we have an unknown in the type chain that makes TS not complain about the missing property when we initialize the SentryHttpInstrumentation.
Talked to the team and everyone is fine with the change. So I'm gonna merge it. Thanks for contributing!
@Lms24
Lms24
merged commit c6261f7
into
getsentry:developApr 4, 2025
@Lms24Lms24
changed the title
feat(node): Add ignoreIncomingRequestBody to avoid capturing request bodiesfeat(node): Add ignoreIncomingRequestBody callback to httpIntegrationApr 4, 2025
@HazATHazAT
mentioned this pull request
Apr 4, 2025
 Merged

@Page-
Page-
commented
Apr 4, 2025

Copy link


Copy Markdown

ContributorAuthor
Awesome, thanks for the quick response @Lms24. And I agree on the issue, it was just a case that by the time I tracked down the memory usage I was already in the place to fix it :)
Lms24 added a commit
that referenced
this pull request
Apr 4, 2025
@HazAT@Lms24
chore: Add external contributor to CHANGELOG.md (#15984)
67f4919
This PR adds the external contributor to the CHANGELOG.md file, so that
they are credited for their contribution. See #15959
Co-authored-by: Lms24 <8420481+Lms24@users.noreply.github.com>
@s1gr1ds1gr1d
mentioned this pull request
Apr 29, 2025

Closed

@s1gr1ds1gr1d
mentioned this pull request
May 14, 2025
 Merged

6 tasks
s1gr1d added a commit
to getsentry/sentry-docs
that referenced
this pull request
May 20, 2025
@s1gr1d
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
8df2fe1
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
bitsandfoxes pushed a commit
to getsentry/sentry-docs
that referenced
this pull request
Jul 3, 2025
@s1gr1d@bitsandfoxes
docs(node): Add docs for maxIncomingRequestBodySize and `ignoreInco…
79f78ec
…mingRequestBody` (#13698)
## DESCRIBE YOUR PR
Documents `ignoreIncomingRequestBody `:
getsentry/sentry-javascript#15959
Documents `maxIncomingRequestBodySize`:
getsentry/sentry-javascript#16225
## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs
to go live.
- [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE -->
- [ ] Other deadline: <!-- ENTER DATE HERE -->
- [x] None: Not urgent, can wait up to 1 week+
## SLA
- Teamwork makes the dream work, so please add a reviewer to your PRs.
- Please give the docs team up to 1 week to review your PR unless you've
added an urgent due date to it.
Thanks in advance for your help!
## PRE-MERGE CHECKLIST
*Make sure you've checked the following before merging your changes:*
- [ ] Checked Vercel preview for correctness, including links
- [ ] PR was reviewed and approved by any necessary SMEs (subject matter
experts)
- [ ] PR was reviewed and approved by a member of the [Sentry docs
team](https://github.com/orgs/getsentry/teams/docs)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@mydeamydeaAwaiting requested review from mydea

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@Page-@Lms24