Skip to content

build: Actually use import eslint rules - #16134

Merged
mydea merged 13 commits into
developfrom
fn/eslint-imports
Apr 28, 2025
Merged

build: Actually use import eslint rules#16134
mydea merged 13 commits into
developfrom
fn/eslint-imports

Conversation

@mydea

@mydeamydea commented Apr 25, 2025•
edited
Loading

Copy link
Copy Markdown
Member

We had a bunch of import/export related eslint rules, but did not actually apply them to anything 🤦 this PR changes this, and also applies all the rules to all the files.

The vast majority of the changes is just auto-fixes, but there are a few small manual things that were needed - these are in separate commits, it's probably easier to look at them separately!

It also updates prettier to apply to dev-packages.

@mydea
mydea requested review from Lms24, chargome and s1gr1dApril 25, 2025 08:51
@mydeamydea self-assigned this Apr 25, 2025
@mydea
mydea requested review from a team as code ownersApril 25, 2025 08:51
@github-actions

github-actionsBot commented Apr 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize% ChangeChange
@sentry/browser23.28 KB-0.01%-2 B 🔽
@sentry/browser - with treeshaking flags23.1 KB-0.09%-20 B 🔽
@sentry/browser (incl. Tracing)36.93 KB-0.18%-65 B 🔽
@sentry/browser (incl. Tracing, Replay)74.1 KB-0.11%-76 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.47 KB-0.13%-86 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)78.76 KB-0.1%-73 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)90.58 KB-0.08%-68 B 🔽
@sentry/browser (incl. Feedback)39.68 KB-0.01%-1 B 🔽
@sentry/browser (incl. sendFeedback)27.9 KB-0.02%-3 B 🔽
@sentry/browser (incl. FeedbackAsync)32.67 KB-0.01%-3 B 🔽
@sentry/react25.09 KB+0.02%+4 B 🔺
@sentry/react (incl. Tracing)38.93 KB+0.07%+26 B 🔺
@sentry/vue27.5 KB-0.01%-1 B 🔽
@sentry/vue (incl. Tracing)38.69 KB-0.05%-18 B 🔽
@sentry/svelte23.31 KB-0.03%-7 B 🔽
CDN Bundle24.49 KB-0.03%-6 B 🔽
CDN Bundle (incl. Tracing)36.96 KB-0.05%-17 B 🔽
CDN Bundle (incl. Tracing, Replay)72 KB+0.01%+3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.3 KB+0.18%+139 B 🔺
CDN Bundle - uncompressed71.5 KB+0.02%+8 B 🔺
CDN Bundle (incl. Tracing) - uncompressed109.33 KB-0.02%-15 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed220.62 KB-0.01%-17 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed233.15 KB-0.01%-11 B 🔽
@sentry/nextjs (client)40.51 KB-0.07%-25 B 🔽
@sentry/sveltekit (client)37.41 KB-0.07%-26 B 🔽
@sentry/node143.36 KB-0.01%-12 B 🔽
@sentry/node - without tracing96.49 KB-0.03%-25 B 🔽
@sentry/aws-serverless120.82 KB-0.02%-13 B 🔽

View base workflow run

Lms24
Lms24 approved these changes Apr 25, 2025
View reviewed changes

@Lms24Lms24 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!
interesting that this decreases bundle size 🤔

@mydeamydea mentioned this pull request Apr 25, 2025
Merged
mydea added a commit that referenced this pull request Apr 25, 2025
@mydea
test(replay): Update replay tests to handle side effects explicitly (#…
7376508
…16135)
Extracted out of
#16134
During that refactor, a bunch of stuff failed. The reason for this is
that we relied on a side-effect mock in `use-fake-timers` utility, which
is really not ideal at all.
So this refactors this to instead make this explicit, as a side-effect
import on the top of the test files. Then we can just use
`vi.useFakeTimers()` normally.
@mydea
mydeaforce-pushed the fn/eslint-imports branch from a3e2fa7 to cdc91baCompareApril 25, 2025 11:21
@mydea
mydea merged commit 8dd90ae into developApr 28, 2025
@mydea
mydea deleted the fn/eslint-imports branch April 28, 2025 08:11
@Lms24Lms24 mentioned this pull request Apr 29, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@chargomechargomeAwaiting requested review from chargome
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@mydeamydea

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
build: Actually use import eslint rules by mydea · Pull Request #16134 · getsentry/sentry-javascript · GitHub
Skip to content
build: Actually use import eslint rules - #16134
Merged
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Apr 28, 2025
Merged
build: Actually use import eslint rules#16134
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Conversation
@mydea
@mydeamydea
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Member
We had a bunch of import/export related eslint rules, but did not actually apply them to anything 🤦 this PR changes this, and also applies all the rules to all the files.
The vast majority of the changes is just auto-fixes, but there are a few small manual things that were needed - these are in separate commits, it's probably easier to look at them separately!
It also updates prettier to apply to dev-packages.
@mydea
mydea
requested review from
Lms24, chargome and s1gr1dApril 25, 2025 08:51
@mydeamydea
self-assigned this
Apr 25, 2025
@mydea
mydea
requested review from
a team
as code ownersApril 25, 2025 08:51
@github-actions
github-actionsBot
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.28 KB-0.01%-2 B 🔽
@sentry/browser - with treeshaking flags23.1 KB-0.09%-20 B 🔽
@sentry/browser (incl. Tracing)36.93 KB-0.18%-65 B 🔽
@sentry/browser (incl. Tracing, Replay)74.1 KB-0.11%-76 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.47 KB-0.13%-86 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)78.76 KB-0.1%-73 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)90.58 KB-0.08%-68 B 🔽
@sentry/browser (incl. Feedback)39.68 KB-0.01%-1 B 🔽
@sentry/browser (incl. sendFeedback)27.9 KB-0.02%-3 B 🔽
@sentry/browser (incl. FeedbackAsync)32.67 KB-0.01%-3 B 🔽
@sentry/react25.09 KB+0.02%+4 B 🔺
@sentry/react (incl. Tracing)38.93 KB+0.07%+26 B 🔺
@sentry/vue27.5 KB-0.01%-1 B 🔽
@sentry/vue (incl. Tracing)38.69 KB-0.05%-18 B 🔽
@sentry/svelte23.31 KB-0.03%-7 B 🔽
CDN Bundle24.49 KB-0.03%-6 B 🔽
CDN Bundle (incl. Tracing)36.96 KB-0.05%-17 B 🔽
CDN Bundle (incl. Tracing, Replay)72 KB+0.01%+3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.3 KB+0.18%+139 B 🔺
CDN Bundle - uncompressed71.5 KB+0.02%+8 B 🔺
CDN Bundle (incl. Tracing) - uncompressed109.33 KB-0.02%-15 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed220.62 KB-0.01%-17 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed233.15 KB-0.01%-11 B 🔽
@sentry/nextjs (client)40.51 KB-0.07%-25 B 🔽
@sentry/sveltekit (client)37.41 KB-0.07%-26 B 🔽
@sentry/node143.36 KB-0.01%-12 B 🔽
@sentry/node - without tracing96.49 KB-0.03%-25 B 🔽
@sentry/aws-serverless120.82 KB-0.02%-13 B 🔽
View base workflow run
Lms24
Lms24
approved these changes
Apr 25, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

interesting that this decreases bundle size 🤔
@mydeamydea
mentioned this pull request
Apr 25, 2025
 Merged

mydea added a commit
that referenced
this pull request
Apr 25, 2025
@mydea
test(replay): Update replay tests to handle side effects explicitly (#…
7376508
…16135)
Extracted out of
#16134
During that refactor, a bunch of stuff failed. The reason for this is
that we relied on a side-effect mock in `use-fake-timers` utility, which
is really not ideal at all.
So this refactors this to instead make this explicit, as a side-effect
import on the top of the test files. Then we can just use
`vi.useFakeTimers()` normally.
@mydea
mydeaforce-pushed
the
fn/eslint-imports
branch
from
a3e2fa7 to
cdc91baCompareApril 25, 2025 11:21
@mydea
mydea
merged commit 8dd90ae
into
developApr 28, 2025
@mydea
mydea
deleted the

fn/eslint-imports

branch
April 28, 2025 08:11
@Lms24Lms24
mentioned this pull request
Apr 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@chargomechargomeAwaiting requested review from chargome
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
build: Actually use import eslint rules by mydea · Pull Request #16134 · getsentry/sentry-javascript · GitHub
Skip to content
build: Actually use import eslint rules - #16134
Merged
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Apr 28, 2025
Merged
build: Actually use import eslint rules#16134
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Conversation
@mydea
@mydeamydea
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Member
We had a bunch of import/export related eslint rules, but did not actually apply them to anything 🤦 this PR changes this, and also applies all the rules to all the files.
The vast majority of the changes is just auto-fixes, but there are a few small manual things that were needed - these are in separate commits, it's probably easier to look at them separately!
It also updates prettier to apply to dev-packages.
@mydea
mydea
requested review from
Lms24, chargome and s1gr1dApril 25, 2025 08:51
@mydeamydea
self-assigned this
Apr 25, 2025
@mydea
mydea
requested review from
a team
as code ownersApril 25, 2025 08:51
@github-actions
github-actionsBot
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.28 KB-0.01%-2 B 🔽
@sentry/browser - with treeshaking flags23.1 KB-0.09%-20 B 🔽
@sentry/browser (incl. Tracing)36.93 KB-0.18%-65 B 🔽
@sentry/browser (incl. Tracing, Replay)74.1 KB-0.11%-76 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.47 KB-0.13%-86 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)78.76 KB-0.1%-73 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)90.58 KB-0.08%-68 B 🔽
@sentry/browser (incl. Feedback)39.68 KB-0.01%-1 B 🔽
@sentry/browser (incl. sendFeedback)27.9 KB-0.02%-3 B 🔽
@sentry/browser (incl. FeedbackAsync)32.67 KB-0.01%-3 B 🔽
@sentry/react25.09 KB+0.02%+4 B 🔺
@sentry/react (incl. Tracing)38.93 KB+0.07%+26 B 🔺
@sentry/vue27.5 KB-0.01%-1 B 🔽
@sentry/vue (incl. Tracing)38.69 KB-0.05%-18 B 🔽
@sentry/svelte23.31 KB-0.03%-7 B 🔽
CDN Bundle24.49 KB-0.03%-6 B 🔽
CDN Bundle (incl. Tracing)36.96 KB-0.05%-17 B 🔽
CDN Bundle (incl. Tracing, Replay)72 KB+0.01%+3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.3 KB+0.18%+139 B 🔺
CDN Bundle - uncompressed71.5 KB+0.02%+8 B 🔺
CDN Bundle (incl. Tracing) - uncompressed109.33 KB-0.02%-15 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed220.62 KB-0.01%-17 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed233.15 KB-0.01%-11 B 🔽
@sentry/nextjs (client)40.51 KB-0.07%-25 B 🔽
@sentry/sveltekit (client)37.41 KB-0.07%-26 B 🔽
@sentry/node143.36 KB-0.01%-12 B 🔽
@sentry/node - without tracing96.49 KB-0.03%-25 B 🔽
@sentry/aws-serverless120.82 KB-0.02%-13 B 🔽
View base workflow run
Lms24
Lms24
approved these changes
Apr 25, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

interesting that this decreases bundle size 🤔
@mydeamydea
mentioned this pull request
Apr 25, 2025
 Merged

mydea added a commit
that referenced
this pull request
Apr 25, 2025
@mydea
test(replay): Update replay tests to handle side effects explicitly (#…
7376508
…16135)
Extracted out of
#16134
During that refactor, a bunch of stuff failed. The reason for this is
that we relied on a side-effect mock in `use-fake-timers` utility, which
is really not ideal at all.
So this refactors this to instead make this explicit, as a side-effect
import on the top of the test files. Then we can just use
`vi.useFakeTimers()` normally.
@mydea
mydeaforce-pushed
the
fn/eslint-imports
branch
from
a3e2fa7 to
cdc91baCompareApril 25, 2025 11:21
@mydea
mydea
merged commit 8dd90ae
into
developApr 28, 2025
@mydea
mydea
deleted the

fn/eslint-imports

branch
April 28, 2025 08:11
@Lms24Lms24
mentioned this pull request
Apr 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@chargomechargomeAwaiting requested review from chargome
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
build: Actually use import eslint rules by mydea · Pull Request #16134 · getsentry/sentry-javascript · GitHub
Skip to content
build: Actually use import eslint rules - #16134
Merged
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Apr 28, 2025
Merged
build: Actually use import eslint rules#16134
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Conversation
@mydea
@mydeamydea
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Member
We had a bunch of import/export related eslint rules, but did not actually apply them to anything 🤦 this PR changes this, and also applies all the rules to all the files.
The vast majority of the changes is just auto-fixes, but there are a few small manual things that were needed - these are in separate commits, it's probably easier to look at them separately!
It also updates prettier to apply to dev-packages.
@mydea
mydea
requested review from
Lms24, chargome and s1gr1dApril 25, 2025 08:51
@mydeamydea
self-assigned this
Apr 25, 2025
@mydea
mydea
requested review from
a team
as code ownersApril 25, 2025 08:51
@github-actions
github-actionsBot
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.28 KB-0.01%-2 B 🔽
@sentry/browser - with treeshaking flags23.1 KB-0.09%-20 B 🔽
@sentry/browser (incl. Tracing)36.93 KB-0.18%-65 B 🔽
@sentry/browser (incl. Tracing, Replay)74.1 KB-0.11%-76 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.47 KB-0.13%-86 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)78.76 KB-0.1%-73 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)90.58 KB-0.08%-68 B 🔽
@sentry/browser (incl. Feedback)39.68 KB-0.01%-1 B 🔽
@sentry/browser (incl. sendFeedback)27.9 KB-0.02%-3 B 🔽
@sentry/browser (incl. FeedbackAsync)32.67 KB-0.01%-3 B 🔽
@sentry/react25.09 KB+0.02%+4 B 🔺
@sentry/react (incl. Tracing)38.93 KB+0.07%+26 B 🔺
@sentry/vue27.5 KB-0.01%-1 B 🔽
@sentry/vue (incl. Tracing)38.69 KB-0.05%-18 B 🔽
@sentry/svelte23.31 KB-0.03%-7 B 🔽
CDN Bundle24.49 KB-0.03%-6 B 🔽
CDN Bundle (incl. Tracing)36.96 KB-0.05%-17 B 🔽
CDN Bundle (incl. Tracing, Replay)72 KB+0.01%+3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.3 KB+0.18%+139 B 🔺
CDN Bundle - uncompressed71.5 KB+0.02%+8 B 🔺
CDN Bundle (incl. Tracing) - uncompressed109.33 KB-0.02%-15 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed220.62 KB-0.01%-17 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed233.15 KB-0.01%-11 B 🔽
@sentry/nextjs (client)40.51 KB-0.07%-25 B 🔽
@sentry/sveltekit (client)37.41 KB-0.07%-26 B 🔽
@sentry/node143.36 KB-0.01%-12 B 🔽
@sentry/node - without tracing96.49 KB-0.03%-25 B 🔽
@sentry/aws-serverless120.82 KB-0.02%-13 B 🔽
View base workflow run
Lms24
Lms24
approved these changes
Apr 25, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

interesting that this decreases bundle size 🤔
@mydeamydea
mentioned this pull request
Apr 25, 2025
 Merged

mydea added a commit
that referenced
this pull request
Apr 25, 2025
@mydea
test(replay): Update replay tests to handle side effects explicitly (#…
7376508
…16135)
Extracted out of
#16134
During that refactor, a bunch of stuff failed. The reason for this is
that we relied on a side-effect mock in `use-fake-timers` utility, which
is really not ideal at all.
So this refactors this to instead make this explicit, as a side-effect
import on the top of the test files. Then we can just use
`vi.useFakeTimers()` normally.
@mydea
mydeaforce-pushed
the
fn/eslint-imports
branch
from
a3e2fa7 to
cdc91baCompareApril 25, 2025 11:21
@mydea
mydea
merged commit 8dd90ae
into
developApr 28, 2025
@mydea
mydea
deleted the

fn/eslint-imports

branch
April 28, 2025 08:11
@Lms24Lms24
mentioned this pull request
Apr 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@chargomechargomeAwaiting requested review from chargome
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
build: Actually use import eslint rules by mydea · Pull Request #16134 · getsentry/sentry-javascript · GitHub
Skip to content
build: Actually use import eslint rules - #16134
Merged
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Apr 28, 2025
Merged
build: Actually use import eslint rules#16134
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Conversation
@mydea
@mydeamydea
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Member
We had a bunch of import/export related eslint rules, but did not actually apply them to anything 🤦 this PR changes this, and also applies all the rules to all the files.
The vast majority of the changes is just auto-fixes, but there are a few small manual things that were needed - these are in separate commits, it's probably easier to look at them separately!
It also updates prettier to apply to dev-packages.
@mydea
mydea
requested review from
Lms24, chargome and s1gr1dApril 25, 2025 08:51
@mydeamydea
self-assigned this
Apr 25, 2025
@mydea
mydea
requested review from
a team
as code ownersApril 25, 2025 08:51
@github-actions
github-actionsBot
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.28 KB-0.01%-2 B 🔽
@sentry/browser - with treeshaking flags23.1 KB-0.09%-20 B 🔽
@sentry/browser (incl. Tracing)36.93 KB-0.18%-65 B 🔽
@sentry/browser (incl. Tracing, Replay)74.1 KB-0.11%-76 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.47 KB-0.13%-86 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)78.76 KB-0.1%-73 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)90.58 KB-0.08%-68 B 🔽
@sentry/browser (incl. Feedback)39.68 KB-0.01%-1 B 🔽
@sentry/browser (incl. sendFeedback)27.9 KB-0.02%-3 B 🔽
@sentry/browser (incl. FeedbackAsync)32.67 KB-0.01%-3 B 🔽
@sentry/react25.09 KB+0.02%+4 B 🔺
@sentry/react (incl. Tracing)38.93 KB+0.07%+26 B 🔺
@sentry/vue27.5 KB-0.01%-1 B 🔽
@sentry/vue (incl. Tracing)38.69 KB-0.05%-18 B 🔽
@sentry/svelte23.31 KB-0.03%-7 B 🔽
CDN Bundle24.49 KB-0.03%-6 B 🔽
CDN Bundle (incl. Tracing)36.96 KB-0.05%-17 B 🔽
CDN Bundle (incl. Tracing, Replay)72 KB+0.01%+3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.3 KB+0.18%+139 B 🔺
CDN Bundle - uncompressed71.5 KB+0.02%+8 B 🔺
CDN Bundle (incl. Tracing) - uncompressed109.33 KB-0.02%-15 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed220.62 KB-0.01%-17 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed233.15 KB-0.01%-11 B 🔽
@sentry/nextjs (client)40.51 KB-0.07%-25 B 🔽
@sentry/sveltekit (client)37.41 KB-0.07%-26 B 🔽
@sentry/node143.36 KB-0.01%-12 B 🔽
@sentry/node - without tracing96.49 KB-0.03%-25 B 🔽
@sentry/aws-serverless120.82 KB-0.02%-13 B 🔽
View base workflow run
Lms24
Lms24
approved these changes
Apr 25, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

interesting that this decreases bundle size 🤔
@mydeamydea
mentioned this pull request
Apr 25, 2025
 Merged

mydea added a commit
that referenced
this pull request
Apr 25, 2025
@mydea
test(replay): Update replay tests to handle side effects explicitly (#…
7376508
…16135)
Extracted out of
#16134
During that refactor, a bunch of stuff failed. The reason for this is
that we relied on a side-effect mock in `use-fake-timers` utility, which
is really not ideal at all.
So this refactors this to instead make this explicit, as a side-effect
import on the top of the test files. Then we can just use
`vi.useFakeTimers()` normally.
@mydea
mydeaforce-pushed
the
fn/eslint-imports
branch
from
a3e2fa7 to
cdc91baCompareApril 25, 2025 11:21
@mydea
mydea
merged commit 8dd90ae
into
developApr 28, 2025
@mydea
mydea
deleted the

fn/eslint-imports

branch
April 28, 2025 08:11
@Lms24Lms24
mentioned this pull request
Apr 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@chargomechargomeAwaiting requested review from chargome
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
build: Actually use import eslint rules by mydea · Pull Request #16134 · getsentry/sentry-javascript · GitHub
Skip to content
build: Actually use import eslint rules - #16134
Merged
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Apr 28, 2025
Merged
build: Actually use import eslint rules#16134
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Conversation
@mydea
@mydeamydea
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Member
We had a bunch of import/export related eslint rules, but did not actually apply them to anything 🤦 this PR changes this, and also applies all the rules to all the files.
The vast majority of the changes is just auto-fixes, but there are a few small manual things that were needed - these are in separate commits, it's probably easier to look at them separately!
It also updates prettier to apply to dev-packages.
@mydea
mydea
requested review from
Lms24, chargome and s1gr1dApril 25, 2025 08:51
@mydeamydea
self-assigned this
Apr 25, 2025
@mydea
mydea
requested review from
a team
as code ownersApril 25, 2025 08:51
@github-actions
github-actionsBot
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.28 KB-0.01%-2 B 🔽
@sentry/browser - with treeshaking flags23.1 KB-0.09%-20 B 🔽
@sentry/browser (incl. Tracing)36.93 KB-0.18%-65 B 🔽
@sentry/browser (incl. Tracing, Replay)74.1 KB-0.11%-76 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.47 KB-0.13%-86 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)78.76 KB-0.1%-73 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)90.58 KB-0.08%-68 B 🔽
@sentry/browser (incl. Feedback)39.68 KB-0.01%-1 B 🔽
@sentry/browser (incl. sendFeedback)27.9 KB-0.02%-3 B 🔽
@sentry/browser (incl. FeedbackAsync)32.67 KB-0.01%-3 B 🔽
@sentry/react25.09 KB+0.02%+4 B 🔺
@sentry/react (incl. Tracing)38.93 KB+0.07%+26 B 🔺
@sentry/vue27.5 KB-0.01%-1 B 🔽
@sentry/vue (incl. Tracing)38.69 KB-0.05%-18 B 🔽
@sentry/svelte23.31 KB-0.03%-7 B 🔽
CDN Bundle24.49 KB-0.03%-6 B 🔽
CDN Bundle (incl. Tracing)36.96 KB-0.05%-17 B 🔽
CDN Bundle (incl. Tracing, Replay)72 KB+0.01%+3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.3 KB+0.18%+139 B 🔺
CDN Bundle - uncompressed71.5 KB+0.02%+8 B 🔺
CDN Bundle (incl. Tracing) - uncompressed109.33 KB-0.02%-15 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed220.62 KB-0.01%-17 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed233.15 KB-0.01%-11 B 🔽
@sentry/nextjs (client)40.51 KB-0.07%-25 B 🔽
@sentry/sveltekit (client)37.41 KB-0.07%-26 B 🔽
@sentry/node143.36 KB-0.01%-12 B 🔽
@sentry/node - without tracing96.49 KB-0.03%-25 B 🔽
@sentry/aws-serverless120.82 KB-0.02%-13 B 🔽
View base workflow run
Lms24
Lms24
approved these changes
Apr 25, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

interesting that this decreases bundle size 🤔
@mydeamydea
mentioned this pull request
Apr 25, 2025
 Merged

mydea added a commit
that referenced
this pull request
Apr 25, 2025
@mydea
test(replay): Update replay tests to handle side effects explicitly (#…
7376508
…16135)
Extracted out of
#16134
During that refactor, a bunch of stuff failed. The reason for this is
that we relied on a side-effect mock in `use-fake-timers` utility, which
is really not ideal at all.
So this refactors this to instead make this explicit, as a side-effect
import on the top of the test files. Then we can just use
`vi.useFakeTimers()` normally.
@mydea
mydeaforce-pushed
the
fn/eslint-imports
branch
from
a3e2fa7 to
cdc91baCompareApril 25, 2025 11:21
@mydea
mydea
merged commit 8dd90ae
into
developApr 28, 2025
@mydea
mydea
deleted the

fn/eslint-imports

branch
April 28, 2025 08:11
@Lms24Lms24
mentioned this pull request
Apr 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@chargomechargomeAwaiting requested review from chargome
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
build: Actually use import eslint rules by mydea · Pull Request #16134 · getsentry/sentry-javascript · GitHub
Skip to content
build: Actually use import eslint rules - #16134
Merged
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Apr 28, 2025
Merged
build: Actually use import eslint rules#16134
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Conversation
@mydea
@mydeamydea
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Member
We had a bunch of import/export related eslint rules, but did not actually apply them to anything 🤦 this PR changes this, and also applies all the rules to all the files.
The vast majority of the changes is just auto-fixes, but there are a few small manual things that were needed - these are in separate commits, it's probably easier to look at them separately!
It also updates prettier to apply to dev-packages.
@mydea
mydea
requested review from
Lms24, chargome and s1gr1dApril 25, 2025 08:51
@mydeamydea
self-assigned this
Apr 25, 2025
@mydea
mydea
requested review from
a team
as code ownersApril 25, 2025 08:51
@github-actions
github-actionsBot
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.28 KB-0.01%-2 B 🔽
@sentry/browser - with treeshaking flags23.1 KB-0.09%-20 B 🔽
@sentry/browser (incl. Tracing)36.93 KB-0.18%-65 B 🔽
@sentry/browser (incl. Tracing, Replay)74.1 KB-0.11%-76 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.47 KB-0.13%-86 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)78.76 KB-0.1%-73 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)90.58 KB-0.08%-68 B 🔽
@sentry/browser (incl. Feedback)39.68 KB-0.01%-1 B 🔽
@sentry/browser (incl. sendFeedback)27.9 KB-0.02%-3 B 🔽
@sentry/browser (incl. FeedbackAsync)32.67 KB-0.01%-3 B 🔽
@sentry/react25.09 KB+0.02%+4 B 🔺
@sentry/react (incl. Tracing)38.93 KB+0.07%+26 B 🔺
@sentry/vue27.5 KB-0.01%-1 B 🔽
@sentry/vue (incl. Tracing)38.69 KB-0.05%-18 B 🔽
@sentry/svelte23.31 KB-0.03%-7 B 🔽
CDN Bundle24.49 KB-0.03%-6 B 🔽
CDN Bundle (incl. Tracing)36.96 KB-0.05%-17 B 🔽
CDN Bundle (incl. Tracing, Replay)72 KB+0.01%+3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.3 KB+0.18%+139 B 🔺
CDN Bundle - uncompressed71.5 KB+0.02%+8 B 🔺
CDN Bundle (incl. Tracing) - uncompressed109.33 KB-0.02%-15 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed220.62 KB-0.01%-17 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed233.15 KB-0.01%-11 B 🔽
@sentry/nextjs (client)40.51 KB-0.07%-25 B 🔽
@sentry/sveltekit (client)37.41 KB-0.07%-26 B 🔽
@sentry/node143.36 KB-0.01%-12 B 🔽
@sentry/node - without tracing96.49 KB-0.03%-25 B 🔽
@sentry/aws-serverless120.82 KB-0.02%-13 B 🔽
View base workflow run
Lms24
Lms24
approved these changes
Apr 25, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

interesting that this decreases bundle size 🤔
@mydeamydea
mentioned this pull request
Apr 25, 2025
 Merged

mydea added a commit
that referenced
this pull request
Apr 25, 2025
@mydea
test(replay): Update replay tests to handle side effects explicitly (#…
7376508
…16135)
Extracted out of
#16134
During that refactor, a bunch of stuff failed. The reason for this is
that we relied on a side-effect mock in `use-fake-timers` utility, which
is really not ideal at all.
So this refactors this to instead make this explicit, as a side-effect
import on the top of the test files. Then we can just use
`vi.useFakeTimers()` normally.
@mydea
mydeaforce-pushed
the
fn/eslint-imports
branch
from
a3e2fa7 to
cdc91baCompareApril 25, 2025 11:21
@mydea
mydea
merged commit 8dd90ae
into
developApr 28, 2025
@mydea
mydea
deleted the

fn/eslint-imports

branch
April 28, 2025 08:11
@Lms24Lms24
mentioned this pull request
Apr 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@chargomechargomeAwaiting requested review from chargome
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
build: Actually use import eslint rules by mydea · Pull Request #16134 · getsentry/sentry-javascript · GitHub
Skip to content
build: Actually use import eslint rules - #16134
Merged
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Apr 28, 2025
Merged
build: Actually use import eslint rules#16134
mydea merged 13 commits into
developfrom 
fn/eslint-imports
Conversation
@mydea
@mydeamydea
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Member
We had a bunch of import/export related eslint rules, but did not actually apply them to anything 🤦 this PR changes this, and also applies all the rules to all the files.
The vast majority of the changes is just auto-fixes, but there are a few small manual things that were needed - these are in separate commits, it's probably easier to look at them separately!
It also updates prettier to apply to dev-packages.
@mydea
mydea
requested review from
Lms24, chargome and s1gr1dApril 25, 2025 08:51
@mydeamydea
self-assigned this
Apr 25, 2025
@mydea
mydea
requested review from
a team
as code ownersApril 25, 2025 08:51
@github-actions
github-actionsBot
commented
Apr 25, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
size-limit report 📦
PathSize% ChangeChange
@sentry/browser23.28 KB-0.01%-2 B 🔽
@sentry/browser - with treeshaking flags23.1 KB-0.09%-20 B 🔽
@sentry/browser (incl. Tracing)36.93 KB-0.18%-65 B 🔽
@sentry/browser (incl. Tracing, Replay)74.1 KB-0.11%-76 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags67.47 KB-0.13%-86 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas)78.76 KB-0.1%-73 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback)90.58 KB-0.08%-68 B 🔽
@sentry/browser (incl. Feedback)39.68 KB-0.01%-1 B 🔽
@sentry/browser (incl. sendFeedback)27.9 KB-0.02%-3 B 🔽
@sentry/browser (incl. FeedbackAsync)32.67 KB-0.01%-3 B 🔽
@sentry/react25.09 KB+0.02%+4 B 🔺
@sentry/react (incl. Tracing)38.93 KB+0.07%+26 B 🔺
@sentry/vue27.5 KB-0.01%-1 B 🔽
@sentry/vue (incl. Tracing)38.69 KB-0.05%-18 B 🔽
@sentry/svelte23.31 KB-0.03%-7 B 🔽
CDN Bundle24.49 KB-0.03%-6 B 🔽
CDN Bundle (incl. Tracing)36.96 KB-0.05%-17 B 🔽
CDN Bundle (incl. Tracing, Replay)72 KB+0.01%+3 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)77.3 KB+0.18%+139 B 🔺
CDN Bundle - uncompressed71.5 KB+0.02%+8 B 🔺
CDN Bundle (incl. Tracing) - uncompressed109.33 KB-0.02%-15 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed220.62 KB-0.01%-17 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed233.15 KB-0.01%-11 B 🔽
@sentry/nextjs (client)40.51 KB-0.07%-25 B 🔽
@sentry/sveltekit (client)37.41 KB-0.07%-26 B 🔽
@sentry/node143.36 KB-0.01%-12 B 🔽
@sentry/node - without tracing96.49 KB-0.03%-25 B 🔽
@sentry/aws-serverless120.82 KB-0.02%-13 B 🔽
View base workflow run
Lms24
Lms24
approved these changes
Apr 25, 2025
View reviewed changes
@Lms24Lms24
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

interesting that this decreases bundle size 🤔
@mydeamydea
mentioned this pull request
Apr 25, 2025
 Merged

mydea added a commit
that referenced
this pull request
Apr 25, 2025
@mydea
test(replay): Update replay tests to handle side effects explicitly (#…
7376508
…16135)
Extracted out of
#16134
During that refactor, a bunch of stuff failed. The reason for this is
that we relied on a side-effect mock in `use-fake-timers` utility, which
is really not ideal at all.
So this refactors this to instead make this explicit, as a side-effect
import on the top of the test files. Then we can just use
`vi.useFakeTimers()` normally.
@mydea
mydeaforce-pushed
the
fn/eslint-imports
branch
from
a3e2fa7 to
cdc91baCompareApril 25, 2025 11:21
@mydea
mydea
merged commit 8dd90ae
into
developApr 28, 2025
@mydea
mydea
deleted the

fn/eslint-imports

branch
April 28, 2025 08:11
@Lms24Lms24
mentioned this pull request
Apr 29, 2025
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Lms24Lms24Lms24 approved these changes
@chargomechargomeAwaiting requested review from chargome
@s1gr1ds1gr1dAwaiting requested review from s1gr1d

Assignees

@mydeamydea

Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mydea@Lms24